Re: [Qemu-devel] [PATCH] target/ppc: Only set PCR in kvm if actually in a compat mode

On Mon, 2017-07-03 at 19:20 +1000, David Gibson wrote: > On Mon, Jul 03, 2017 at 01:18:38PM +1000, Suraj Jitindar Singh wrote: > > On Fri, 2017-06-30 at 14:03 +1000, David Gibson wrote: > > > On Thu, Jun 29, 2017 at 02:59:39PM +1000, Suraj Jitindar Singh > > > wrote: > > > > The Processor

Re: [Qemu-devel] [PATCH v4 07/11] pc-bios/s390-ccw: Add code for virtio feature negotiation

On 11.07.2017 16:23, Cornelia Huck wrote: > On Tue, 11 Jul 2017 15:56:33 +0200 > Thomas Huth wrote: > >> The upcoming virtio-net driver needs to negotiate some features, >> so we need the possibility to do this in the core virtio code. >> >> Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed

Eric Blake writes: > On 07/11/2017 11:37 AM, Manos Pitsidianakis wrote: >> This function is not used anywhere, so remove it. >> > > Might be interesting to figure out when it WAS last used. Yes. When I see "remove X because it's unused" during patch review, I immediately

Re: [Qemu-devel] [PATCH v4 0/4] block: Block driver callbacks fixes

On Wed, Jul 12, 2017 at 09:49:20AM +0200, Markus Armbruster wrote: Manos Pitsidianakis writes: This series makes implementing some of the bdrv_* callbacks easier for block filters by passing requests to bs->file if bs->drv doesn't implement it instead of failing, and

Re: [Qemu-devel] [PATCH v4 00/11] Implement network booting in the s390-ccw BIOS

On 07/11/2017 03:56 PM, Thomas Huth wrote: > It's already possible to do a network boot of an s390x guest with an > external netboot image based on a Linux installation, but it would > be much more convenient if the s390-ccw firmware supported network > booting right out of the box, without the

Re: [Qemu-devel] [PATCH v2] block: fix leaks in bdrv_open_driver()

Am 11.07.2017 um 20:50 hat Manos Pitsidianakis geschrieben: > On Tue, Jul 11, 2017 at 05:16:17PM +0200, Kevin Wolf wrote: > >Am 01.07.2017 um 17:39 hat Manos Pitsidianakis geschrieben: > >>bdrv_open_driver() is called in two places, bdrv_new_open_driver() and > >>bdrv_open_common(). In the latter,

[Qemu-devel] [PATCH v2 0/4] VT-d: some enhancements on iotlb

v2: - rebase to master - removed all "info iommu" patches for now (is it bad to introduce new HMP commands without QMP? I thought not, but in case I missed anything, please kindly let me know...) Patch 1: fixes a very rare PT path issue on iova value. It didn't break anything since it's

[Qemu-devel] [PATCH v2 2/4] intel_iommu: let iotlb size tunable

We were having static IOTLB size as 1024. Let it be a tunable. We can also turns IOTLB off if we want, by specify the size as zero. The tunable is named as "x-iotlb-size" since that should not really be something used by user yet, but mostly for debugging purpose now. Signed-off-by: Peter Xu

[Qemu-devel] [PATCH v2 3/4] intel_iommu: use access_flags for iotlb

It was cached by read/write separately. Let's merge them. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 15 +++ include/hw/i386/intel_iommu.h | 3 +-- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/i386/intel_iommu.c

[Qemu-devel] [PATCH 2/2] docker.py: Improve subprocess exit code handling

A few error handlings are missing because we ignore the subprocess exit code, for example "docker build" errors are currently ignored. Introduce _do_check() aside the existing _do() method and use it in a few places. Signed-off-by: Fam Zheng --- tests/docker/docker.py | 19

Re: [Qemu-devel] [PATCH v3 2/8] error: Functions to report warnings and informational messages

Alistair Francis writes: > Add warn_report(), warn_vreport() for reporting warnings, and > info_report(), info_vreport() for informational messages. > > These are implemented them with a helper function factored out of > error_vreport(), suitably generalized. This

Re: [Qemu-devel] [RFC 5/5] vifo: introduce new VFIO ioctl VFIO_DEVICE_PCI_GET_DIRTY_BITMAP

> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, July 11, 2017 3:47 AM > > On Fri, 7 Jul 2017 06:40:58 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Saturday, July 1, 2017 1:00 AM > >

[Qemu-devel] [PATCH v3] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

We don't want to carry along old machine types forever. If we are able to remove the pc machines up to 0.13 one day for example, this would allow us to eventually kill the code for rombar=0 (i.e. where QEMU copies ROM BARs directly to low memory). Everything up to pc-1.2 is also known to have

Re: [Qemu-devel] [PATCH v3 3/8] Convert error_report() to warn_report()

Alistair Francis writes: > Convert all uses of error_report("warning:"... to use warn_report() > instead. This helps standardise on a single method of printing warnings > to the user. > > All of the warnings where changed using these two commands: s/where/were/ >

[Qemu-devel] [PATCH v2 4/4] intel_iommu: implement mru list for iotlb

It is not wise to disgard all the IOTLB cache when cache size reaches max, but that's what we do now. A slightly better (but still simple) way to do this is, we just throw away the least recent used cache entry. This patch implemented MRU list algorithm for VT-d IOTLB. The main logic is to

[Qemu-devel] [PATCH] virtio: enhance virtio_error messages

Output like "Virtqueue size exceeded" is not much useful in identifying the culprit. This commit adds virtio device name and queue index to all error messages in virtio.c to improve debuggability. Signed-off-by: Ladi Prosek --- hw/virtio/virtio.c | 74

Re: [Qemu-devel] [PATCH v2] block: fix leaks in bdrv_open_driver()

On Wed, Jul 12, 2017 at 10:33:37AM +0200, Kevin Wolf wrote: Am 11.07.2017 um 20:50 hat Manos Pitsidianakis geschrieben: On Tue, Jul 11, 2017 at 05:16:17PM +0200, Kevin Wolf wrote: >Am 01.07.2017 um 17:39 hat Manos Pitsidianakis geschrieben: >>bdrv_open_driver() is called in two places,

[Qemu-devel] [PATCH 3/3] migration: export capabilities to props

Do the same thing to migration capabilities, just like what we did in previous patch for migration parameters. Signed-off-by: Peter Xu --- migration/migration.c | 17 + 1 file changed, 17 insertions(+) diff --git a/migration/migration.c

Re: [Qemu-devel] [PATCH v2 0/4] VT-d: some enhancements on iotlb

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1499844982-5738-1-git-send-email-pet...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/4] VT-d: some enhancements on iotlb === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v3 0/6] migration: s390x css migration

On Tue, 11 Jul 2017 16:54:35 +0200 Halil Pasic wrote: > Like for v2 the scope of this patch series is now limited to decoupling > channel subsystem migration from the migration of virtio-ccw proxies. > > There wasn't a whole lot of criticism regarding v2, so very

Re: [Qemu-devel] [PATCH v2 0/4] VT-d: some enhancements on iotlb

On Wed, Jul 12, 2017 at 12:47:22AM -0700, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 1499844982-5738-1-git-send-email-pet...@redhat.com > Subject: [Qemu-devel] [PATCH v2 0/4]

[Qemu-devel] [PATCH v3 2/4] intel_iommu: let iotlb size tunable

We were having static IOTLB size as 1024. Let it be a tunable. We can also turns IOTLB off if we want, by specify the size as zero. The tunable is named as "x-iotlb-size" since that should not really be something used by user yet, but mostly for debugging purpose now. Signed-off-by: Peter Xu

Re: [Qemu-devel] change x86 default machine type to Q35?

On 12/07/2017 8:51, Gerd Hoffmann wrote: Hi, Hi, I think simply not having a default machine type (as already suggested elsewhere in this thread) is the best way to deal with this. I would absolutely hate this. One of the nice things about qemu has always been that 'qemu disk.img' is

Re: [Qemu-devel] change x86 default machine type to Q35?

On 11/07/2017 17:47, Paolo Bonzini wrote: On 11/07/2017 16:42, Kevin Wolf wrote: Concerning QEMU, could we maybe simply emit a warning a la "you did not specify a machine type with the -M option, so you are currently running the the 'pc' machine type. Please note that future versions

Re: [Qemu-devel] [PATCH v3.5 2/8] target/s390x: Implement CONVERT UNICODE insns

On 11.07.2017 20:23, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > v3.5: Added even register checks in the translator [thuth]. > --- > target/s390x/helper.h | 6 + > target/s390x/mem_helper.c | 310 > + >

[Qemu-devel] [PATCH V3] chardev: fix parallel device can't be reconnect

Parallel device don't register be->chr_can_read function, but remote disconnect event is handled in chr_read.So connected parallel device can not detect remote disconnect event. The chardevs with chr_can_read=NULL has the same problem. Signed-off-by: Peng Hao Reviewed-by:

[Qemu-devel] [PATCH 0/2] Two small improvements for docker.py

The first one is a small simplification, the second one is an error handling improvement. Fam Zheng (2): docker.py: Drop infile parameter docker.py: Improve subprocess exit code handling tests/docker/docker.py | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-)

[Qemu-devel] [PATCH 1/2] docker.py: Drop infile parameter

The **kwargs can do this just well. Signed-off-by: Fam Zheng --- tests/docker/docker.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index e707e5b..f5ac86b 100755 --- a/tests/docker/docker.py +++

Re: [Qemu-devel] [PATCH v3 0/6] migration: s390x css migration

On 07/11/2017 04:54 PM, Halil Pasic wrote: > Like for v2 the scope of this patch series is now limited to decoupling > channel subsystem migration from the migration of virtio-ccw proxies. > > There wasn't a whole lot of criticism regarding v2, so very little > changed since then. All issues

[Qemu-devel] [PATCH v3 1/4] intel_iommu: fix VTD_PAGE_MASK

IOMMUTLBEntry.iova is returned incorrectly in one PT path (though mostly we cannot really trigger this path, even if we do, we are mostly disgarding this value, so it didn't break anything). Fix it by converting the VTD_PAGE_MASK into normal definition (normally it should be pfn mask, not offset

[Qemu-devel] [PATCH v3 0/4] VT-d: some enhancements on iotlb

v3: - fix issue reported by patchew on style v2: - rebase to master - removed all "info iommu" patches for now (is it bad to introduce new HMP commands without QMP? I thought not, but in case I missed anything, please kindly let me know...) Patch 1: fixes a very rare PT path issue on iova

Re: [Qemu-devel] change x86 default machine type to Q35?

Am 12.07.2017 um 07:51 hat Gerd Hoffmann geschrieben: > > > I think simply not having a default > > > machine type (as already suggested elsewhere in this thread) is the > > > best way to deal with this. > > > > I would absolutely hate this. One of the nice things about qemu has > > always been

[Qemu-devel] [PATCH v2 1/4] intel_iommu: fix VTD_PAGE_MASK

IOMMUTLBEntry.iova is returned incorrectly in one PT path (though mostly we cannot really trigger this path, even if we do, we are mostly disgarding this value, so it didn't break anything). Fix it by converting the VTD_PAGE_MASK into normal definition (normally it should be pfn mask, not offset

[Qemu-devel] [Bug 1696353] Re: golang binaries fail to start under linux-user

You can also apply this patch to go - I don't have an opinion on the correct course of action though! diff --git a/src/runtime/os_linux.go b/src/runtime/os_linux.go index a6efc0e3d1..64218e3f7e 100644 --- a/src/runtime/os_linux.go +++ b/src/runtime/os_linux.go @@ -132,7 +132,8 @@ const (

[Qemu-devel] [Bug 1696353] Re: golang binaries fail to start under linux-user

Note that there is a go bug about this issue too: https://github.com/golang/go/issues/20763 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1696353 Title: golang binaries fail to start under

Re: [Qemu-devel] [PATCH v3] hmp: Update info vnc

"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > The QMP query-vnc interfaces have gained a lot more information that > the HMP interfaces hasn't got yet. Update it. > > Note the output format has changed, but this is HMP so

[Qemu-devel] [PATCH 0/3] migration: export cap/params to qdev props

We have the MigrationState as QDev now (which seems crazy). Let's continue to benefit. This series is exporting all migration capabilities/params as global parameters. Then we can do something like this: qemu -global migration.postcopy-ram=true \ -global migration.max-bandwidth=4096

[Qemu-devel] [PATCH 2/3] migration: export parameters to props

Export migration parameters to qdev properties. Then we can use, for example: -global migration.cpu-throttle-initial=xxx To specify migration parameters during init. One thing to mention is that, this usage should only be used for debugging/testing purpose, and should never be used elsewhere.

[Qemu-devel] [PATCH 1/3] qdev: provide DEFINE_PROP_INT64()

We have merely all the stuff, but this one is missing. Add it in. Am going to use this new helper for MigrationParameters fields, since most of them are int64_t. CC: Markus Armbruster CC: Eduardo Habkost CC: "Marc-André Lureau"

[Qemu-devel] [PATCH] keymaps: fr-ca: add missing keys

Signed-off-by: Gerd Hoffmann --- pc-bios/keymaps/fr-ca | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pc-bios/keymaps/fr-ca b/pc-bios/keymaps/fr-ca index b645208e42..030f56a78e 100644 --- a/pc-bios/keymaps/fr-ca +++ b/pc-bios/keymaps/fr-ca @@ -48,3 +48,5 @@ parenleft

Re: [Qemu-devel] [PATCH v4 0/4] block: Block driver callbacks fixes

Manos Pitsidianakis writes: > This series makes implementing some of the bdrv_* callbacks easier for block > filters by passing requests to bs->file if bs->drv doesn't implement it > instead > of failing, and adding default bdrv_co_get_block_status() implementations. > >

[Qemu-devel] [PATCH v3 4/4] intel_iommu: implement mru list for iotlb

It is not wise to disgard all the IOTLB cache when cache size reaches max, but that's what we do now. A slightly better (but still simple) way to do this is, we just throw away the least recent used cache entry. This patch implemented MRU list algorithm for VT-d IOTLB. The main logic is to

[Qemu-devel] [PATCH v3 3/4] intel_iommu: use access_flags for iotlb

It was cached by read/write separately. Let's merge them. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 15 +++ include/hw/i386/intel_iommu.h | 3 +-- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/i386/intel_iommu.c

Re: [Qemu-devel] [PULL 09/17] spapr: Remove unnecessary differences between hotplug and coldplug paths

On Tue, Jul 11, 2017 at 02:39:09PM +1000, David Gibson wrote: > spapr_drc_attach() has a 'coldplug' parameter which sets the DRC into > configured state initially, instead of the usual ISOLATED/UNUSABLE state. > It turns out this is unnecessary: although coldplugged devices do need to > be in

Re: [Qemu-devel] [PATCH v12 13/27] target/arm: [tcg] Port to DisasContextBase

Lluís Vilanova writes: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Richard Henderson Heads up there will be some clashes with the eret

[Qemu-devel] [Bug 1703795] [NEW] Unable to release mouse in SDL2 mode

Public bug reported: Starting with commit 8f4ea9cd0b770dbe496d9d24f0ef8813fdbfe0d0 "sdl: prefer sdl2 over sdl1", I can no longer release mouse pointer grab unless I use --with-sdlabi=1.2 configure option. This easily reproduces in e.g. guest Kubuntu, when I let it start Xorg and then click into

Re: [Qemu-devel] [PULL 09/17] spapr: Remove unnecessary differences between hotplug and coldplug paths

On Wed, Jul 12, 2017 at 01:56:37PM +0530, Bharata B Rao wrote: > On Tue, Jul 11, 2017 at 02:39:09PM +1000, David Gibson wrote: > > spapr_drc_attach() has a 'coldplug' parameter which sets the DRC into > > configured state initially, instead of the usual ISOLATED/UNUSABLE state. > > It turns out

Re: [Qemu-devel] [PATCH v12 21/27] target/arm: [tcg] Port to translate_insn

Lluís Vilanova writes: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > --- > target/arm/translate.c | 148 > >

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

On 12/07/17 04:50, Bharat Bhushan wrote: [...] >> The size of the virtio_iommu_req_probe structure is variable, and depends >> what fields the device implements. So the device initially computes the size >> it >> needs to fill virtio_iommu_req_probe, describes it in probe_size, and the >> driver

Re: [Qemu-devel] [PATCHv2 3/8] spapr: Simplify unplug path

On Wed, 12 Jul 2017 12:04:51 +0200 Greg Kurz wrote: > On Wed, 12 Jul 2017 15:53:12 +1000 > David Gibson wrote: > > > spapr_lmb_release() and spapr_core_release() call hotplug_handler_unplug() > > which after a bunch of indirection calls

Re: [Qemu-devel] [PATCH v4 00/11] Implement network booting in the s390-ccw BIOS

On 12.07.2017 12:53, Thomas Huth wrote: > On 12.07.2017 10:33, Christian Borntraeger wrote: >> On 07/11/2017 03:56 PM, Thomas Huth wrote: >>> It's already possible to do a network boot of an s390x guest with an >>> external netboot image based on a Linux installation, but it would >>> be much more

Re: [Qemu-devel] [PATCH v3 0/6] migration: s390x css migration

On 07/12/2017 01:06 PM, Halil Pasic wrote: > > > On 07/12/2017 10:01 AM, Christian Borntraeger wrote: >> On 07/11/2017 04:54 PM, Halil Pasic wrote: >>> Like for v2 the scope of this patch series is now limited to decoupling >>> channel subsystem migration from the migration of virtio-ccw

Re: [Qemu-devel] How to stop `qemu-system-x86_64 ...` instead of `kill -9`?

Hi Sam, On 07/12/2017 06:24 AM, Sam wrote: I'm running `qemu-system-x86_64 ...` to start a guest vm. Now I want to stop and destroy this vm, I found there is no `qemu-stop` related command, so I have to `kill -9` this process. How could I stop `qemu-system-x86_64` instead of `kill -9`? Use

[Qemu-devel] [PATCH RFC 1/3] tests/vhost-user-bridge: disable debug output by default

From: Jens Freimann vhost-user-bridge prints out a lot of information, including dumps of all transmitted data. When called from a testcase this output clutters the actual test results, so let's make the default no debug output. Signed-off-by: Jens Freimann

[Qemu-devel] [PATCH v5 3/4] qcow2: add shrink image support

This patch add shrinking of the image file for qcow2. As a result, this allows us to reduce the virtual image size and free up space on the disk without copying the image. Image can be fragmented and shrink is done by punching holes in the image file. Signed-off-by: Pavel Butsykin

[Qemu-devel] [PATCH v5 4/4] qemu-iotests: add shrinking image test

Signed-off-by: Pavel Butsykin Reviewed-by: Max Reitz --- tests/qemu-iotests/163 | 170 + tests/qemu-iotests/163.out | 5 ++ tests/qemu-iotests/group | 1 + 3 files changed, 176 insertions(+)

Re: [Qemu-devel] [PATCH v12 04/27] target: [tcg] Add generic translation framework

Richard Henderson writes: > On 07/11/2017 06:40 AM, Lluís Vilanova wrote: >> Since other hooks can set db->is_jmp and return values (breakpoint_check), >> I'll >> stick with db->is_jmp instead. Then tb_start can return max_insns, and >> generic >> code can refine it with checks like

Re: [Qemu-devel] [PULL v1 0/5] Merge sockets 2017/07/11

On Tue, Jul 11, 2017 at 07:21:32AM -0700, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Message-id:

[Qemu-devel] How to stop `qemu-system-x86_64 ...` instead of `kill -9`?

hi all, I'm running `qemu-system-x86_64 ...` to start a guest vm. Now I want to stop and destroy this vm, I found there is no `qemu-stop` related command, so I have to `kill -9` this process. How could I stop `qemu-system-x86_64` instead of `kill -9`? Use `virsh` command or something? Thank

Re: [Qemu-devel] How to stop `qemu-system-x86_64 ...` instead of `kill -9`?

On Wed, Jul 12, 2017 at 05:24:40PM +0800, Sam wrote: > hi all, > > I'm running `qemu-system-x86_64 ...` to start a guest vm. Now I want to > stop and destroy this vm, I found there is no `qemu-stop` related command, > so I have to `kill -9` this process. > > How could I stop `qemu-system-x86_64`

Re: [Qemu-devel] [PATCH RFC 0/5] Introduce "-object iothread-group"

On Tue, Jul 11, 2017 at 11:14:21PM +0800, Fam Zheng wrote: > On Tue, 07/11 15:15, Stefan Hajnoczi wrote: > > On Mon, Jul 10, 2017 at 03:20:22PM +0800, Fam Zheng wrote: > > > Last time we've looked at "-object iothread,spawns=N" but it was a bit > > > abusive. > > > A dedicated "iothread-group"

Re: [Qemu-devel] [PATCH v12 05/27] target/i386: [tcg] Port to DisasContextBase

Alex Bennée writes: > Lluís Vilanova writes: >> Incrementally paves the way towards using the generic instruction translation >> loop. >> >> Signed-off-by: Lluís Vilanova >> Reviewed-by: Emilio G. Cota >> Reviewed-by: Richard

Re: [Qemu-devel] [PATCH 1/2] docker.py: Drop infile parameter

On 07/12/2017 04:55 AM, Fam Zheng wrote: The **kwargs can do this just well. Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé --- tests/docker/docker.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 2/3] qdev: support properties which don't set a default value

On 12 July 2017 at 12:22, Markus Armbruster wrote: > Peter Maydell writes: > >> In some situations it's useful to have a qdev property which doesn't >> automatically set its default value when qdev_property_add_static is >> called (for instance when

Re: [Qemu-devel] [PATCHv2 1/8] spapr: Treat devices added before inbound migration as coldplugged

On Wed, 12 Jul 2017 15:53:10 +1000 David Gibson wrote: > From: Laurent Vivier > > When migrating a guest which has already had devices hotplugged, > libvirt typically starts the destination qemu with -incoming defer, > adds those hotplugged

Re: [Qemu-devel] [PATCH v12 07/27] target/i386: [tcg] Port to insn_start

Lluís Vilanova writes: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Emilio G. Cota > Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v12 06/27] target/i386: [tcg] Port to init_disas_context

Lluís Vilanova writes: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Richard Henderson Hah, I see now ;-) Reviewed-by: Alex Bennée

Re: [Qemu-devel] [PULL 09/17] spapr: Remove unnecessary differences between hotplug and coldplug paths

On Wed, 12 Jul 2017 13:56:37 +0530 Bharata B Rao wrote: > On Tue, Jul 11, 2017 at 02:39:09PM +1000, David Gibson wrote: > > spapr_drc_attach() has a 'coldplug' parameter which sets the DRC into > > configured state initially, instead of the usual ISOLATED/UNUSABLE

Re: [Qemu-devel] [PATCH v12 25/27] target/arm: [tcg] Port to disas_log

Lluís Vilanova writes: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée >

Re: [Qemu-devel] [PATCHv2 3/8] spapr: Simplify unplug path

On Wed, 12 Jul 2017 15:53:12 +1000 David Gibson wrote: > spapr_lmb_release() and spapr_core_release() call hotplug_handler_unplug() > which after a bunch of indirection calls spapr_memory_unplug() or > spapr_core_unplug(). But we already know which is the

Re: [Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

On Wed, Jul 12, 2017 at 11:48:39AM +0200, Greg Kurz wrote: > Since commit 5c1da81215c7 ("spapr: Remove unnecessary differences between > hotplug and coldplug paths"), the CPU DT for the DRC is always allocated. > This causes a memory leak for pseries-2.6 and older machine types, that > don't

Re: [Qemu-devel] [PATCH v4 1/4] block: pass bdrv_* methods to bs->file by default in block filters

On Tue, Jul 11, 2017 at 07:37:45PM +0300, Manos Pitsidianakis wrote: > The following functions fail if bs->drv is a filter and does not > implement them: > > bdrv_probe_blocksizes > bdrv_probe_geometry > bdrv_truncate > bdrv_has_zero_init > bdrv_get_info > > Instead, the call should be passed to

Re: [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed

On Tue, Jul 11, 2017 at 07:37:46PM +0300, Manos Pitsidianakis wrote: > This function is not used anywhere, so remove it. > > Signed-off-by: Manos Pitsidianakis > --- > block.c | 14 -- > block/raw-format.c| 6 -- >

Re: [Qemu-devel] [Qemu-block] [PATCH 11/11] block/snapshot: do not take AioContext lock

On Tue, Jul 11, 2017 at 11:48:02AM +0200, Paolo Bonzini wrote: > On 11/07/2017 11:43, Stefan Hajnoczi wrote: > >>> > >>> 1. Must be called under BQL? > >>> 2. Can I/O requests be in flight? > >>> 3. Is it thread-safe? > >>> > >>> Otherwise it will be a nightmare to modify the code since these >

Re: [Qemu-devel] [PATCH v4 00/11] Implement network booting in the s390-ccw BIOS

On 12.07.2017 10:33, Christian Borntraeger wrote: > On 07/11/2017 03:56 PM, Thomas Huth wrote: >> It's already possible to do a network boot of an s390x guest with an >> external netboot image based on a Linux installation, but it would >> be much more convenient if the s390-ccw firmware supported

Re: [Qemu-devel] [PATCH] spapr: make default PHB optionnal

[libvir-list added to the loop] On Tue, 2017-07-04 at 10:47 +0200, Greg Kurz wrote: > On Tue, 4 Jul 2017 17:29:01 +1000 David Gibson > wrote: > > On Mon, Jul 03, 2017 at 06:48:25PM +0200, Greg Kurz wrote: > > >  > > > The sPAPR machine always create a default PHB

[Qemu-devel] Supporting unsafe create when backing file is not accessible

Hi, We encountered a performance issue when creating a volume for a running VM and we'd like to share the info with you. The root cause of the issue is in our code but we found a workaround that relies on qemu-img create undocumented behavior. During our tests, we found that in order to create a

[Qemu-devel] [PATCH v5 0/4] Add shrink image for qcow2

This patch add shrinking of the image file for qcow2. As a result, this allows us to reduce the virtual image size and free up space on the disk without copying the image. Image can be fragmented and shrink is done by punching holes in the image file. # ./qemu-img create -f qcow2 image.qcow2 4G

Re: [Qemu-devel] [PATCH v4 0/4] some gdbstub fixes for debug and vcont

CC'ed Kamil Rytarowski (new NetBSD maintainer) On 07/12/2017 07:52 AM, Alex Bennée wrote: Hi Paolo, I was going through my review queue and realised I had this hanging around with an outstanding comment. Basically the only change is to fix the bsd-user build by adding a field for the

Re: [Qemu-devel] [PATCH qemu v9 1/2] memory/iommu: QOM'fy IOMMU MemoryRegion

On Wed, 12 Jul 2017 12:22:17 +0200 Cornelia Huck wrote: > On Tue, 11 Jul 2017 13:56:19 +1000 > Alexey Kardashevskiy wrote: > > > This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion > > as a parent. > > > > This moves IOMMU-related fields from

Re: [Qemu-devel] [PATCH v12 04/27] target: [tcg] Add generic translation framework

Alex Bennée writes: > Lluís Vilanova writes: >> Signed-off-by: Lluís Vilanova >> --- >> accel/tcg/Makefile.objs |1 >> accel/tcg/translator.c| 152 >> + >> include/exec/gen-icount.h |2 - >>

Re: [Qemu-devel] [PATCH v12 03/27] target: [tcg] Use a generic enum for DISAS_ values

Lluís Vilanova writes: > Used later. An enum makes expected values explicit and bounds the value space > of > switches. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Emilio G. Cota > Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH 5/8] apb: fix endianness for APB and PCI config accesses

On Tue, Jul 11, 2017 at 11:53 PM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/pci-host/apb.c |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/pci-host/apb.c

Re: [Qemu-devel] [PATCH v12 16/27] target/arm: [tcg] Port to tb_start

Lluís Vilanova writes: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée >

Re: [Qemu-devel] [PATCH 3/5] migration/rdma: Allow cancelling while waiting for wrid

On Tue, Jul 04, 2017 at 07:49:13PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When waiting for a WRID, if the other side dies we end up waiting > for ever with no way to cancel the migration. > Cure this by poll()ing the fd first with a

Re: [Qemu-devel] [PATCH v3 4/8] hw/i386: Improve some of the warning messages

Alistair Francis writes: > Signed-off-by: Alistair Francis > Suggested-by: Eduardo Habkost You forgot to cc: Eduardo. Fixed. > --- > > hw/i386/acpi-build.c | 7 --- > hw/i386/pc.c | 9 - >

Re: [Qemu-devel] [PATCH 8/8] sun4u: move in-built devices behind PCI bridge A

On Tue, Jul 11, 2017 at 11:53 PM, Mark Cave-Ayland wrote: > This switches the sun4u model to being much closer to a real Ultra 5. > > Since the existing code previously bypassed the PCI bridge interrupt > swizzling, reorganise the interrupt mapping functions so that

Re: [Qemu-devel] [PATCH v4 3/4] block: remove bdrv_truncate callback in blkdebug

On Tue, Jul 11, 2017 at 07:37:47PM +0300, Manos Pitsidianakis wrote: > Now that bdrv_truncate is passed to bs->file by default, remove the > callback from block/blkdebug.c and set is_filter to true. > > Signed-off-by: Manos Pitsidianakis > --- > block/blkdebug.c | 7

Re: [Qemu-devel] [PATCH v4 4/4] block: add default implementations for bdrv_co_get_block_status()

On Tue, Jul 11, 2017 at 07:37:48PM +0300, Manos Pitsidianakis wrote: > bdrv_co_get_block_status_from_file() and > bdrv_co_get_block_status_from_backing() set *file to bs->file and > bs->backing respectively, so that bdrv_co_get_block_status() can recurse > to them. Future block drivers won't have

Re: [Qemu-devel] should we update QEMU's u-boot submodule and binary?

On 11.07.2017 20:22, Alexander Graf wrote: > > On 11.07.17 19:43, Peter Maydell wrote: >> Hi; I just noticed that our u-boot submodule is still stuck on >> a commit from 2014 when it was first added to QEMU. Should we >> move this forward to some more recent u-boot release? >> >> I think we only

Re: [Qemu-devel] [PATCH v3 2/6] block: Add VFIO based NVMe driver

On Wed, Jul 12, 2017 at 10:14:48AM +0800, Fam Zheng wrote: > On Mon, 07/10 15:55, Stefan Hajnoczi wrote: > > On Wed, Jul 05, 2017 at 09:36:31PM +0800, Fam Zheng wrote: > > > +static int nvme_co_prw(BlockDriverState *bs, uint64_t offset, uint64_t > > > bytes, > > > +

Re: [Qemu-devel] [PATCH v3 2/8] error: Functions to report warnings and informational messages

On Wed, Jul 12, 2017 at 9:57 AM, Markus Armbruster wrote: > Alistair Francis writes: > >> Add warn_report(), warn_vreport() for reporting warnings, and >> info_report(), info_vreport() for informational messages. >> >> These are implemented them

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

On 12/07/17 11:27, Bharat Bhushan wrote: > > >> -Original Message- >> From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com] >> Sent: Wednesday, July 12, 2017 3:48 PM >> To: Bharat Bhushan ; Auger Eric >> ;

[Qemu-devel] [PATCH v4 3/4] qom/cpu: remove host_tid field

This was only used by the gdbstub and even then was only being set for subsequent threads. Rather the continue duplicating the number just make the gdbstub get the information from TaskState structure. Now the tid is correctly reported for all threads the bug I was seeing with "vCont;C04:0;c"

Re: [Qemu-devel] [PATCH RFC 0/5] Introduce "-object iothread-group"

On Tue, 07/11 15:58, Stefan Hajnoczi wrote: > On Mon, Jul 10, 2017 at 03:20:22PM +0800, Fam Zheng wrote: > > Last time we've looked at "-object iothread,spawns=N" but it was a bit > > abusive. > > A dedicated "iothread-group" class is cleaner from the interface point of > > view. > > This series

Re: [Qemu-devel] [PATCH] spapr: make default PHB optionnal

On 07/12/2017 04:25 PM, Andrea Bolognani wrote: [libvir-list added to the loop] On Tue, 2017-07-04 at 10:47 +0200, Greg Kurz wrote: On Tue, 4 Jul 2017 17:29:01 +1000 David Gibson wrote: On Mon, Jul 03, 2017 at 06:48:25PM +0200, Greg Kurz wrote: The sPAPR

[Qemu-devel] [PATCH v5 1/4] qemu-img: add --shrink flag for resize

The flag is additional precaution against data loss. Perhaps in the future the operation shrink without this flag will be blocked for all formats, but for now we need to maintain compatibility with raw. Signed-off-by: Pavel Butsykin Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH] spapr: make default PHB optionnal

On Wed, 12 Jul 2017 12:55:34 +0200 Andrea Bolognani wrote: > [libvir-list added to the loop] > > On Tue, 2017-07-04 at 10:47 +0200, Greg Kurz wrote: > > On Tue, 4 Jul 2017 17:29:01 +1000 David Gibson > > wrote: > > > On Mon, Jul 03, 2017 at

Re: [Qemu-devel] [PATCHv2 2/8] spapr: Remove 'awaiting_allocation' DRC flag

On 12/07/2017 07:53, David Gibson wrote: > The awaiting_allocation flag in the DRC was introduced by aab9913 > "spapr_drc: Prevent detach racing against attach for CPU DR", allegedly to > prevent a guest crash on racing attach and detach. Except.. information > from the BZ actually suggests a

Re: [Qemu-devel] should we update QEMU's u-boot submodule and binary?

On 12.07.17 12:34, Thomas Huth wrote: On 11.07.2017 20:22, Alexander Graf wrote: On 11.07.17 19:43, Peter Maydell wrote: Hi; I just noticed that our u-boot submodule is still stuck on a commit from 2014 when it was first added to QEMU. Should we move this forward to some more recent u-boot

  1   2   3   4   5   >