[Qemu-devel] [PULL 19/21] pseries: Allow HPT resizing with KVM

2017-07-17 Thread David Gibson
So far, qemu implements the PAPR Hash Page Table (HPT) resizing extension with TCG. The same implementation will work with KVM PR, but we don't currently allow that. For KVM HV we can only implement resizing with the assistance of the host kernel, which needs a new capability and ioctl()s. This

[Qemu-devel] [PULL 02/21] spapr: migrate pending_events of spapr state

2017-07-17 Thread David Gibson
From: Daniel Henrique Barboza In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration is started. In this case the pending_events of spapr state need be transmitted to the target so that the hotpl

[Qemu-devel] [PULL 11/21] spapr: Remove sPAPRConfigureConnectorState sub-structure

2017-07-17 Thread David Gibson
Most of the time, the state of a DRC object is contained in the single 'state' variable. However, during the transition from UNISOLATE to CONFIGURED state requires multiple calls to the ibm,configure-connector RTAS call to retrieve the device tree for the attached device. We need some extra state

[Qemu-devel] [PULL 05/21] spapr: Remove 'awaiting_allocation' DRC flag

2017-07-17 Thread David Gibson
The awaiting_allocation flag in the DRC was introduced by aab9913 "spapr_drc: Prevent detach racing against attach for CPU DR", allegedly to prevent a guest crash on racing attach and detach. Except.. information from the BZ actually suggests a qemu crash, not a guest crash. And there shouldn't b

[Qemu-devel] [PULL 16/21] pseries: Implement HPT resizing

2017-07-17 Thread David Gibson
This patch implements hypercalls allowing a PAPR guest to resize its own hash page table. This will eventually allow for more flexible memory hotplug. The implementation is partially asynchronous, handled in a special thread running the hpt_prepare_thread() function. The state of a pending resiz

[Qemu-devel] [PULL 03/21] spapr: Minor cleanups to events handling

2017-07-17 Thread David Gibson
The rtas_error_log structure is marked packed, which strongly suggests its precise layout is important to match an external interface. Along with that one could expect it to have a fixed endianness to match the same interface. That used to be the case - matching the layout of PAPR RTAS event form

[Qemu-devel] [PULL 08/21] spapr: Refactor spapr_drc_detach()

2017-07-17 Thread David Gibson
This function has two unused parameters - remove them. It also sets awaiting_release on all paths, except one. On that path setting it is harmless, since it will be immediately cleared by spapr_drc_release(). So factor it out of the if statements. Signed-off-by: David Gibson Reviewed-by: Greg

[Qemu-devel] [PULL 10/21] spapr: Consolidate DRC state variables

2017-07-17 Thread David Gibson
Each DRC has three fields describing its state: isolation_state, allocation_state and configured. At first this seems like a reasonable representation, since its based directly on the PAPR defined isolation-state and allocation-state indicators. However: * Only a few combinations of the two fie

[Qemu-devel] [PULL 09/21] spapr: Cleanups relating to DRC awaiting_release field

2017-07-17 Thread David Gibson
'awaiting_release' indicates that the host has requested an unplug of the device attached to the DRC, but the guest has not (yet) put the device into a state where it is safe to complete removal. 1. Rename it to 'unplug_requested' which to me at least is clearer 2. Remove the ->release_pending()

[Qemu-devel] [PULL 18/21] pseries: Use smaller default hash page tables when guest can resize

2017-07-17 Thread David Gibson
We've now implemented a PAPR extension allowing PAPR guest to resize their hash page table (HPT) during runtime. This patch makes use of that facility to allocate smaller HPTs by default. Specifically when a guest is aware of the HPT resize facility, qemu sizes the HPT to the initial memory size,

[Qemu-devel] [PULL 13/21] spapr: fix potential memory leak in spapr_core_plug()

2017-07-17 Thread David Gibson
From: Greg Kurz Since commit 5c1da81215c7 ("spapr: Remove unnecessary differences between hotplug and coldplug paths"), the CPU DT for the DRC is always allocated. This causes a memory leak for pseries-2.6 and older machine types, that don't support CPU hotplug and don't allocate DRCs for CPUs.

[Qemu-devel] [PULL 15/21] pseries: Stubs for HPT resizing

2017-07-17 Thread David Gibson
This introduces stub implementations of the H_RESIZE_HPT_PREPARE and H_RESIZE_HPT_COMMIT hypercalls which we hope to add in a PAPR extension to allow run time resizing of a guest's hash page table. It also adds a new machine property for controlling whether this new facility is available. For now

[Qemu-devel] [PULL 14/21] ppc/pnv: Remove unused XICSState reference

2017-07-17 Thread David Gibson
From: Alexey Kardashevskiy e6f7e110ee70 "ppc/xics: remove the XICSState classes" got rid of XICSState, this is just an leftover. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Cédric Le Goater Signed-off-by: David Gibson --- include/hw/ppc/pnv_psi.h | 2 -- 1 file changed, 2 deletions(-)

[Qemu-devel] [PULL 12/21] spapr: Implement DR-indicator for physical DRCs only

2017-07-17 Thread David Gibson
According to PAPR, the DR-indicator should only be valid for physical DRCs, not logical DRCs. At the moment we implement it for all DRCs, so restrict it to physical ones only. We move the state to the physical DRC subclass, which means adding some QOM boilerplate to handle the newly distinct type

[Qemu-devel] [PULL 21/21] target/ppc: fix CPU hotplug when radix is enabled (TCG)

2017-07-17 Thread David Gibson
From: Cédric Le Goater But when a guest initializes radix mode, it issues a H_REGISTER_PROC_TBL to update the LPCR of all CPUs. Hot-plugged CPUs inherit from the same setting under KVM but not under TCG. So, Let's check for radix and update the default LPCR to keep new CPUs in sync. Signed-off-b

Re: [Qemu-devel] [RFC] RFC on Backup tool

2017-07-17 Thread Fam Zheng
On Sun, 07/16 02:13, Ishani Chugh wrote: > This is a Request For Comments patch for qemu backup tool. As an > Outreachy intern, I am assigned to the project for creating a backup > tool. qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. Onl

Re: [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-17 Thread Laurent Vivier
On 14/07/2017 16:37, Michael S. Tsirkin wrote: > On Fri, Jul 14, 2017 at 02:20:33AM -0400, Paolo Bonzini wrote: >> >>> NACK. >>> >>> It's not that simple. If you do it like this, you then suddenly get >>> these ugly '"kvm" accelerator not found' messages during "make check" >>> which we really shou

Re: [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm

2017-07-17 Thread Thomas Huth
On 14.07.2017 16:45, Michael S. Tsirkin wrote: > On Fri, Jul 14, 2017 at 07:59:54AM +0200, Thomas Huth wrote: >> On 13.07.2017 19:00, Paolo Bonzini wrote: >>> On 13/07/2017 18:47, Michael S. Tsirkin wrote: Speed up tests on host systems with kvm support. [...] diff --git a/tests/vmgenid-t

Re: [Qemu-devel] [Question] Seabios HANGs when mmio wirte in a nested vmware host wtih virito-scsi controller

2017-07-17 Thread Xulei (Stone)
On 07/17/2017 11:13 AM, Xulei (Stone) wrote: >> |--virtio_queue_empty >> >> Then, kmod falls in infinite loop in handle EPT_MISCONFIG. >> As far as i know, when kvm enters guest after handling EPT_MISCONFIG, >> seabios should return >> from mmio write and wait for vi

Re: [Qemu-devel] [PATCH V2 2/4] net/colo-compare.c: Compare the tcp packets that has the same sequence number

2017-07-17 Thread Zhang Chen
On 07/14/2017 11:25 AM, Jason Wang wrote: On 2017年07月13日 13:52, Zhang Chen wrote: If primary packet's sequence number not same with secondary packet's sequence number, no need to compare the packet other field. Signed-off-by: Zhang Chen --- net/colo-compare.c | 6 ++ 1 file changed,

Re: [Qemu-devel] [Question] Seabios HANGs when mmio wirte in a nested vmware host wtih virito-scsi controller

2017-07-17 Thread Xiao Guangrong
On 07/17/2017 03:34 PM, Xulei (Stone) wrote: On 07/17/2017 11:13 AM, Xulei (Stone) wrote: >> |--virtio_queue_empty >> >> Then, kmod falls in infinite loop in handle EPT_MISCONFIG. >> As far as i know, when kvm enters guest after handling EP

[Qemu-devel] [PATCH v3 0/9] virtio: enhance virtio_error messages

2017-07-17 Thread Ladi Prosek
Output like "Virtqueue size exceeded" is not much useful in identifying the culprit. This series beefs up virtio_error to print the virtio device name and id, and introduces virtqueue_error which additionally includes the index of the virtqueue where the error occured. Patches 1 to 3 lay the groun

[Qemu-devel] [PATCH v3 5/9] virtio-blk: use virtqueue_error for errors with queue context

2017-07-17 Thread Ladi Prosek
virtqueue_error includes the queue index in the error output and is preferred for errors that pertain to a virtqueue rather than to the device as a whole. Signed-off-by: Ladi Prosek Reviewed-by: Cornelia Huck Reviewed-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 6 +++--- 1 file changed, 3

[Qemu-devel] [PATCH v3 4/9] virtio-9p: use virtqueue_error for errors with queue context

2017-07-17 Thread Ladi Prosek
virtqueue_error includes the queue index in the error output and is preferred for errors that pertain to a virtqueue rather than to the device as a whole. Signed-off-by: Ladi Prosek Acked-by: Greg Kurz Reviewed-by: Cornelia Huck Reviewed-by: Stefan Hajnoczi --- hw/9pfs/virtio-9p-device.c | 37

[Qemu-devel] [PATCH v3 3/9] virtio: use virtqueue_error for errors with queue context

2017-07-17 Thread Ladi Prosek
virtqueue_error includes the queue index in the error output and is preferred for errors that pertain to a virtqueue rather than to the device as a whole. Signed-off-by: Ladi Prosek Reviewed-by: Cornelia Huck Reviewed-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 57 +++-

[Qemu-devel] [PATCH v3 6/9] virtio-net: use virtqueue_error for errors with queue context

2017-07-17 Thread Ladi Prosek
virtqueue_error includes the queue index in the error output and is preferred for errors that pertain to a virtqueue rather than to the device as a whole. Signed-off-by: Ladi Prosek Reviewed-by: Cornelia Huck Reviewed-by: Stefan Hajnoczi --- hw/net/virtio-net.c | 24 1

[Qemu-devel] [PATCH v3 8/9] virtio-crypto: use virtqueue_error for errors with queue context

2017-07-17 Thread Ladi Prosek
virtqueue_error includes the queue index in the error output and is preferred for errors that pertain to a virtqueue rather than to the device as a whole. Signed-off-by: Ladi Prosek --- hw/virtio/virtio-crypto.c | 49 --- 1 file changed, 25 insertions(

[Qemu-devel] [PATCH v3 2/9] virtio: introduce virtqueue_error

2017-07-17 Thread Ladi Prosek
Most virtio error output pertains to a specific virtqueue so it makes sense to include the queue index in error messages. Suggested-by: Stefan Hajnoczi Signed-off-by: Ladi Prosek --- hw/virtio/virtio.c | 44 +--- include/hw/virtio/virtio.h | 1 +

[Qemu-devel] [PATCH v3 7/9] virtio-scsi: use virtqueue_error for errors with queue context

2017-07-17 Thread Ladi Prosek
virtqueue_error includes the queue index in the error output and is preferred for errors that pertain to a virtqueue rather than to the device as a whole. Signed-off-by: Ladi Prosek Reviewed-by: Cornelia Huck Reviewed-by: Stefan Hajnoczi --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1 inse

[Qemu-devel] [PATCH v3 1/9] virtio: enhance virtio_error messages

2017-07-17 Thread Ladi Prosek
Output like "Virtqueue size exceeded" is not much useful in identifying the culprit. This commit adds virtio device name (e.g. "virtio-input") and id if set (e.g. "mouse0") to all virtio error messages to improve debuggability. Some virtio devices (virtio-scsi, virtio-serial) insert a bus between

[Qemu-devel] [PATCH v3 9/9] checkpatch: add virtio_error and virtqueue_error to error funcs

2017-07-17 Thread Ladi Prosek
Two more error functions that should not contain newlines. Suggested-by: Greg Kurz Signed-off-by: Ladi Prosek --- scripts/checkpatch.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 4e91122..2cd2713 100755 --- a/script

Re: [Qemu-devel] [PATCHv3 1/2] pci: move check for existing devfn into new pci_bus_devfn_available() helper

2017-07-17 Thread Marcel Apfelbaum
On 16/07/2017 23:27, Mark Cave-Ayland wrote: Also touch up the logic in do_pci_register_device() accordingly. Signed-off-by: Mark Cave-Ayland --- hw/pci/pci.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 0c6f74a..efc9c86 1

Re: [Qemu-devel] [PATCHv3 2/2] pci: add reserved slot check to do_pci_register_device()

2017-07-17 Thread Marcel Apfelbaum
On 16/07/2017 23:27, Mark Cave-Ayland wrote: Add a new slot_reserved_mask bitmask to PCIBus indicating whether or not each PCI slot on the bus is reserved. Ensure that it is initialised to zero to maintain the existing behaviour that all slots are available by default, and add the additional chec

[Qemu-devel] [PATCH v2 02/11] migration: export parameters to props

2017-07-17 Thread Peter Xu
Export migration parameters to qdev properties. Then we can use, for example: -global migration.x-cpu-throttle-initial=xxx To specify migration parameters during init. Prefix "x-" is appended for each parameter exported to show that this is not a stable interface, and only for debugging/testin

[Qemu-devel] [PATCH v2 00/11] migration: export cap/params to qdev props

2017-07-17 Thread Peter Xu
v2: - extended the series from 3 -> 11 patches - renamed all the properties with "x-" prefix - handled the cap/param check for these new properties (mostly patch 4-11, but it contains lots of refactorings in general) We have the MigrationState as QDev now (which seems crazy). Let's continue to b

[Qemu-devel] [PATCH v2 01/11] qdev: provide DEFINE_PROP_INT64()

2017-07-17 Thread Peter Xu
We have merely all the stuff, but this one is missing. Add it in. Am going to use this new helper for MigrationParameters fields, since most of them are int64_t. CC: Markus Armbruster CC: Eduardo Habkost CC: Marc-André Lureau CC: Peter Xu CC: Juan Quintela CC: Marcel Apfelbaum Reviewed-by:

[Qemu-devel] [PATCH v2 04/11] qom: call parent first on post_init()

2017-07-17 Thread Peter Xu
It makes more sense to call the post_init() hook of the parent first then the child, just like what we do in the rest of the hooks. CC: Andreas Färber CC: Markus Armbruster CC: Eduardo Habkost Signed-off-by: Peter Xu --- qom/object.c | 8 1 file changed, 4 insertions(+), 4 deletions(

[Qemu-devel] [PATCH v2 03/11] migration: export capabilities to props

2017-07-17 Thread Peter Xu
Do the same thing to migration capabilities, just like what we did in previous patch for migration parameters. Signed-off-by: Peter Xu --- migration/migration.c | 17 + 1 file changed, 17 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index ad2505c..320

[Qemu-devel] [PATCH v2 05/11] migration: introduce migrate_params_check()

2017-07-17 Thread Peter Xu
Helper to check the parameters. Abstracted from qmp_migrate_set_parameters(). Signed-off-by: Peter Xu --- migration/migration.c | 42 -- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 320

[Qemu-devel] [PATCH v2 06/11] migration: provide migrate_params_apply()

2017-07-17 Thread Peter Xu
Abstracted from qmp_migrate_set_parameters(). Signed-off-by: Peter Xu --- migration/migration.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 2821f8a..8c65054 100644 --- a/migration/migration.c

[Qemu-devel] [PATCH v2 08/11] migration: remove check against colo support

2017-07-17 Thread Peter Xu
Since commit a15215f3 ("build: remove --enable-colo/--disable-colo"), colo is always supported. We don't need any colo_supported() now since it is always true. Removing any extra code that depends on it. CC: Paolo Bonzini CC: Hailiang Zhang Signed-off-by: Peter Xu --- include/migration/colo.h

[Qemu-devel] [PATCH v2 07/11] migration: check global params for validity

2017-07-17 Thread Peter Xu
Adding validity check for the migration parameters passed in via global properties. Signed-off-by: Peter Xu --- migration/migration.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 8c65054..5a7f22c 10064

[Qemu-devel] [PATCH v2 09/11] migration: provide migrate_caps_check()

2017-07-17 Thread Peter Xu
Abstract helper function to check migration capabilities (from the old qmp_migrate_set_capabilities). Prepare to be used somewhere else. There is side effect on the change: when applying the capabilities, we were skipping the invalid ones, but still applying the valid ones (if they are provided i

[Qemu-devel] [PATCH v2 10/11] migration: provide migrate_cap_add()

2017-07-17 Thread Peter Xu
Abstracted from migrate_set_block_enabled() to allocate MigrationCapabilityStatusList properly. Signed-off-by: Peter Xu --- migration/migration.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 52db5e7..

Re: [Qemu-devel] [PATCH v2 01/11] qdev: provide DEFINE_PROP_INT64()

2017-07-17 Thread Marcel Apfelbaum
On 17/07/2017 11:26, Peter Xu wrote: We have merely all the stuff, but this one is missing. Add it in. Am going to use this new helper for MigrationParameters fields, since most of them are int64_t. CC: Markus Armbruster CC: Eduardo Habkost CC: Marc-André Lureau CC: Peter Xu CC: Juan Quinte

[Qemu-devel] [PATCH v2 11/11] migration: check global caps for validity

2017-07-17 Thread Peter Xu
Checks validity for all the capabilities that we enabled with command line. Stop the VM if detected anything wrong. Signed-off-by: Peter Xu --- migration/migration.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration

Re: [Qemu-devel] [Qemu-block] [PATCH v5 7/9] nbd: Implement NBD_OPT_GO on client

2017-07-17 Thread Kevin Wolf
Am 07.07.2017 um 22:30 hat Eric Blake geschrieben: > NBD_OPT_EXPORT_NAME is lousy: per the NBD protocol, any failure > requires the server to close the connection rather than report an > error to us. Therefore, upstream NBD recently added NBD_OPT_GO as > the improved version of the option that doe

Re: [Qemu-devel] [PATCH v3 8/9] virtio-crypto: use virtqueue_error for errors with queue context

2017-07-17 Thread Gonglei (Arei)
> -Original Message- > From: Ladi Prosek [mailto:lpro...@redhat.com] > Sent: Monday, July 17, 2017 4:12 PM > To: qemu-devel@nongnu.org > Cc: casasferna...@hotmail.com; m...@redhat.com; jasow...@redhat.com; > coh...@redhat.com; arm...@redhat.com; gr...@kaod.org; Gonglei (Arei); > aneesh.ku

Re: [Qemu-devel] Supporting unsafe create when backing file is not accessible

2017-07-17 Thread Kevin Wolf
Am 14.07.2017 um 21:13 hat Nir Soffer geschrieben: > On Wed, Jul 12, 2017 at 5:40 PM Eric Blake wrote: > > > On 07/12/2017 03:56 AM, Ala Hino wrote: > > > Hi, > > > > > > We encountered a performance issue when creating a volume for a running > > VM > > > and we'd like to share the info with you.

Re: [Qemu-devel] [PATCH V2 2/4] net/colo-compare.c: Compare the tcp packets that has the same sequence number

2017-07-17 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > > > On 07/14/2017 11:25 AM, Jason Wang wrote: > > > > > > On 2017年07月13日 13:52, Zhang Chen wrote: > > > If primary packet's sequence number not same with secondary packet's > > > sequence number, no need to compare the packet other field. >

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-17 Thread Daniel P. Berrange
On Mon, Jul 17, 2017 at 08:54:18AM +0200, Ladi Prosek wrote: > On Fri, Jul 14, 2017 at 12:41 PM, Daniel P. Berrange > wrote: > > On Thu, Jul 13, 2017 at 02:32:06PM +0100, Stefan Hajnoczi wrote: > >> On Thu, Jul 13, 2017 at 01:02:30PM +0200, Ladi Prosek wrote: > >> > +/* > >> > + * Print an error m

Re: [Qemu-devel] [PATCH v4 1/2] docs: document support lifetime for features

2017-07-17 Thread Daniel P. Berrange
On Fri, Jul 14, 2017 at 02:06:17PM -0300, Eduardo Habkost wrote: > On Fri, Jul 14, 2017 at 11:15:48AM +0100, Daniel P. Berrange wrote: > > There is currently no explicit guidance on the duration of support > > for features such as versioned machine types, which have a finite > > useful lifespan. Th

Re: [Qemu-devel] [PATCH 00/11] Make memory_region_init_ram() and friends handle migration

2017-07-17 Thread Peter Maydell
On 14 July 2017 at 18:01, Peter Maydell wrote: > On 10 July 2017 at 11:05, Paolo Bonzini wrote: >> On 07/07/2017 16:42, Peter Maydell wrote: >>> This patchset changes the memory region functions >>> - memory_region_init_ram() >>> - memory_region_init_rom() >>> - memory_region_init_rom_device()

[Qemu-devel] [PATCH v4 0/2] VT-d: some enhancements on iotlb

2017-07-17 Thread Peter Xu
v4: - removed patch 2 (x-iotlb-size patch) and patch 4 (mru list for iotlb) [mst] - used VTD_PAGE_SIZE_4K for patch 1 [Jason] v3: - fix issue reported by patchew on style v2: - rebase to master - removed all "info iommu" patches for now (is it bad to introduce new HMP commands without QMP? I

Re: [Qemu-devel] qapi: Stop abusing "special" values for something entirely different

2017-07-17 Thread Daniel P. Berrange
On Fri, Jul 14, 2017 at 07:12:52PM +0200, Markus Armbruster wrote: > Here's what I propose to do: > > 1. Stop abusing values the schema accepts, but are invalid to mean "do > something else entirely". > > 2. Add a first class null type to QAPI. > > 3. Turn MigrationParameters members tls-creds a

[Qemu-devel] [PATCH v4 2/2] intel_iommu: use access_flags for iotlb

2017-07-17 Thread Peter Xu
It was cached by read/write separately. Let's merge them. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 15 +++ include/hw/i386/intel_iommu.h | 3 +-- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index e0

Re: [Qemu-devel] investigating TPM for OVMF-on-QEMU

2017-07-17 Thread Javier Martinez Canillas
Hello Laszlo, Thanks a lot for the great summary. On 07/14/2017 08:04 PM, Laszlo Ersek wrote: [snip] > > Here I should mention some ACPI and hardware aspects. Under TPM1 > (whose ACPI table was called "TCPA"), the TPM events (measurements > I think) were logged in a reserved mem

[Qemu-devel] [PATCH v4 1/2] intel_iommu: fix iova for pt

2017-07-17 Thread Peter Xu
IOMMUTLBEntry.iova is returned incorrectly on one PT path (though mostly we cannot really trigger this path, even if we do, we are mostly disgarding this value, so it didn't break anything). Fix it by converting the VTD_PAGE_MASK into the correct definition VTD_PAGE_MASK_4K, then remove VTD_PAGE_MA

Re: [Qemu-devel] [PATCH V2 3/4] net/colo-compare.c: Optimize unpredictable tcp options comparison

2017-07-17 Thread Zhang Chen
On 07/14/2017 11:33 AM, Jason Wang wrote: On 2017年07月13日 13:52, Zhang Chen wrote: When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same, but the two packet's payload is identical. colo just care about p

[Qemu-devel] [PULL 0/1] Ipxe patches

2017-07-17 Thread Gerd Hoffmann
The following changes since commit 6e2c46334385c7e295ac883c801c81b4925fb54f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170711' into staging (2017-07-13 10:47:10 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ipxe-pull-request for y

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-17 Thread Stefan Hajnoczi
On Mon, Jul 17, 2017 at 02:35:21PM +0800, Fam Zheng wrote: > Q1: In the worst case, you get four individual auto replies from patchew. Is > that too many? Do you prefer one reply with all the results concatenated into > one? I'd like to avoid situations where one of the failure emails is sent hour

Re: [Qemu-devel] Could you please create an account

2017-07-17 Thread Stefan Hajnoczi
On Sun, Jul 16, 2017 at 01:47:18AM +0800, tim3385 wrote: >       Could you please create an account for me? Done, please see private email. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v6 2/2] live-block-ops.txt: Rename, rewrite, and improve it

2017-07-17 Thread Kashyap Chamarthy
On Tue, Jul 11, 2017 at 10:03:29AM -0500, Eric Blake wrote: [...] > Overall, looking good! Content-wise, I think we have a good document, > and it was just a few spelling errors and grammar suggestions, minor > enough that I'm comfortable with you adding: > Reviewed-by: Eric Blake All your sug

Re: [Qemu-devel] [PATCH V2 2/4] net/colo-compare.c: Compare the tcp packets that has the same sequence number

2017-07-17 Thread Zhang Chen
On 07/17/2017 04:55 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: On 07/14/2017 11:25 AM, Jason Wang wrote: On 2017年07月13日 13:52, Zhang Chen wrote: If primary packet's sequence number not same with secondary packet's sequence number, no need to compa

Re: [Qemu-devel] [PATCH] virtio-net: fix offload ctrl endian

2017-07-17 Thread Jason Wang
On 2017年07月14日 22:26, Michael S. Tsirkin wrote: On Fri, Jul 14, 2017 at 08:27:06PM +0800, Jason Wang wrote: Spec said offloads should be le64, so use virtio_ldq_p() to guarantee valid endian. Fixes: 644c98587d4c ("virtio-net: dynamic network offloads configuration") Cc: qemu-sta...@nongnu.org

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-17 Thread Peter Maydell
On 17 July 2017 at 10:05, Stefan Hajnoczi wrote: > On Mon, Jul 17, 2017 at 02:35:21PM +0800, Fam Zheng wrote: >> Q1: In the worst case, you get four individual auto replies from patchew. Is >> that too many? Do you prefer one reply with all the results concatenated into >> one? > > I'd like to avo

[Qemu-devel] [PULL 2/3] audio/fmopl: modify timer callback to give opaque and channel parameters in two arguments

2017-07-17 Thread Gerd Hoffmann
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Message-id: 20170621043401.19842-2-hpous...@reactos.org Signed-off-by: Gerd Hoffmann --- hw/audio/fmopl.h | 7 --- hw/audio/adlib.c | 2 +- hw/audio/fmopl.c | 18 +- 3 files change

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-17 Thread Ladi Prosek
On Mon, Jul 17, 2017 at 10:58 AM, Daniel P. Berrange wrote: > On Mon, Jul 17, 2017 at 08:54:18AM +0200, Ladi Prosek wrote: >> On Fri, Jul 14, 2017 at 12:41 PM, Daniel P. Berrange >> wrote: >> > On Thu, Jul 13, 2017 at 02:32:06PM +0100, Stefan Hajnoczi wrote: >> >> On Thu, Jul 13, 2017 at 01:02:30

[Qemu-devel] [PULL 0/3] Audio 20170717 patches

2017-07-17 Thread Gerd Hoffmann
The following changes since commit 6e2c46334385c7e295ac883c801c81b4925fb54f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170711' into staging (2017-07-13 10:47:10 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/audio-201

[Qemu-devel] [PULL 1/3] audio: st_rate_flow exist a infinite loop

2017-07-17 Thread Gerd Hoffmann
From: Peng Hao If a voice recording equipment is opened for a long time(several days) in windows guest, rate->ipos will overflow and rate->opos will never have a chance to change. It will result to a infinite loop. Signed-off-by: Peng Hao Signed-off-by: Wang Yechao Message-id: 1500128061-20849

[Qemu-devel] [PULL 3/3] audio/adlib: remove limitation of one adlib card

2017-07-17 Thread Gerd Hoffmann
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Message-id: 20170621043401.19842-3-hpous...@reactos.org Signed-off-by: Gerd Hoffmann --- hw/audio/adlib.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/hw/audio/adlib

Re: [Qemu-devel] [PATCH V2 1/4] net/colo-compare.c: Add checkpoint min period to optimize performance

2017-07-17 Thread Zhang Chen
On 07/14/2017 08:10 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: If colo-compare find out the first different packet that means the following packet almost is different. we needn't do a lot of checkpoint in this time, so we set the no-need-checkpoint pe

Re: [Qemu-devel] [PATCH v6 07/18] docker: add debian/amd64

2017-07-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/Makefile.include | 1 + > tests/docker/dockerfiles/debian-amd64-cross.docker | 18 ++ > 2 files changed, 19 insertions(+) > create mode 100644 tests/docker/dockerf

Re: [Qemu-devel] [PATCH v6 07/18] docker: add debian/amd64

2017-07-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/Makefile.include | 1 + > tests/docker/dockerfiles/debian-amd64-cross.docker | 18 ++ > 2 files changed, 19 insertions(+) > create mode 100644 tests/docker/dockerf

[Qemu-devel] [PULL 0/3] Ui 20170717 patches

2017-07-17 Thread Gerd Hoffmann
The following changes since commit 6e2c46334385c7e295ac883c801c81b4925fb54f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170711' into staging (2017-07-13 10:47:10 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-201

[Qemu-devel] [PULL 2/3] hmp: Update info vnc

2017-07-17 Thread Gerd Hoffmann
From: "Dr. David Alan Gilbert" The QMP query-vnc interfaces have gained a lot more information that the HMP interfaces hasn't got yet. Update it. Note the output format has changed, but this is HMP so that's OK. In particular, this now includes client information for reverse connections: -vnc

[Qemu-devel] [PULL 1/3] vnc: Set default kbd delay to 10ms

2017-07-17 Thread Gerd Hoffmann
From: Alexander Graf The current VNC default keyboard delay is 1ms. With that we're constantly typing faster than the guest receives keyboard events from an XHCI attached USB HID device. The default keyboard delay time in the input layer however is 10ms. I don't know how that number came to be,

[Qemu-devel] [PULL 3/3] keymaps: fr-ca: add missing keys

2017-07-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20170712072305.29233-1-kra...@redhat.com --- pc-bios/keymaps/fr-ca | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pc-bios/keymaps/fr-ca b/pc-bios/keymaps/fr-ca index b645208e42..030f56a78e 100644 --- a/pc-bios/keymaps/fr-ca +++ b/pc-bios/keymaps/fr-

Re: [Qemu-devel] [PATCH v6 18/18] shippable: restrict builds to master/staging and shippable* branches

2017-07-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: Why? Don't this stop people testing their feature branches? > Signed-off-by: Philippe Mathieu-Daudé > --- > .shippable.yml | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/.shippable.yml b/.shippable.yml > index 4c8a85941f..1f05d934e4 100644 > ---

[Qemu-devel] [PULL 1/1] ehci: add sanity check for maxframes

2017-07-17 Thread Gerd Hoffmann
Reported-by: Peter Maydell Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Maydell Message-id: 20170703111549.10924-1-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 73090e

[Qemu-devel] [PULL 0/1] Vga 20170717 patches

2017-07-17 Thread Gerd Hoffmann
The following changes since commit 6e2c46334385c7e295ac883c801c81b4925fb54f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170711' into staging (2017-07-13 10:47:10 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/vga-201

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-17 Thread Fam Zheng
On Mon, 07/17 10:28, Peter Maydell wrote: > On 17 July 2017 at 10:05, Stefan Hajnoczi wrote: > > On Mon, Jul 17, 2017 at 02:35:21PM +0800, Fam Zheng wrote: > >> Q1: In the worst case, you get four individual auto replies from patchew. > >> Is > >> that too many? Do you prefer one reply with all t

[Qemu-devel] [PULL 0/1] Usb 20170717 patches

2017-07-17 Thread Gerd Hoffmann
The following changes since commit 6e2c46334385c7e295ac883c801c81b4925fb54f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170711' into staging (2017-07-13 10:47:10 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-201

[Qemu-devel] [PULL 1/1] virtio-gpu: skip update cursor in post_load if we don't have one

2017-07-17 Thread Gerd Hoffmann
If the cursor resource id isn't set the guest didn't define a cursor. Skip the cursor update in post_load in that that case. Reported-by: wanghaibin Signed-off-by: Gerd Hoffmann Tested-by: wanghaibin Message-id: 20170710070432.856-1-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/displa

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-17 Thread Thomas Huth
On 17.07.2017 08:35, Fam Zheng wrote: > Hi all, > > Today I've included a fourth type of the automatic patchew replies: FreeBSD. > > So far we have these tests running by patchew on each patch series: > > * Docker tests > Basically it is > make docker-test-quick@centos6 \ >

Re: [Qemu-devel] [PATCH] keymaps: fr-ca: add missing keys

2017-07-17 Thread Thomas Huth
On 12.07.2017 09:23, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > pc-bios/keymaps/fr-ca | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/pc-bios/keymaps/fr-ca b/pc-bios/keymaps/fr-ca > index b645208e42..030f56a78e 100644 > --- a/pc-bios/keymaps/fr-ca > +++ b/pc-bios/keym

Re: [Qemu-devel] [PATCH] tests: Handle $RANDOM not being supported by the shell

2017-07-17 Thread Stefan Hajnoczi
On Fri, Jul 14, 2017 at 11:45:17AM +0100, Peter Maydell wrote: > In various places in our test makefiles and scripts we use the > shell $RANDOM to create a random number. This is a bash > specific extension, and doesn't work on other shells. > With dash the shell doesn't complain, it just effective

Re: [Qemu-devel] [PATCH] ide: check BlockBackend object in ide_cancel_dma_sync

2017-07-17 Thread Stefan Hajnoczi
On Fri, Jul 14, 2017 at 03:30:29PM +0530, P J P wrote: > From: Prasad J Pandit > > When cancelling pending DMA requests in ide_cancel_dma_sync, > the s->blk object could be null, leading to a null dereference. > Add check to avoid it. Please include details on how to reproduce the bug and/or whi

Re: [Qemu-devel] [PATCH v4 1/2] docs: document support lifetime for features

2017-07-17 Thread Stefan Hajnoczi
On Fri, Jul 14, 2017 at 02:06:17PM -0300, Eduardo Habkost wrote: > On Fri, Jul 14, 2017 at 11:15:48AM +0100, Daniel P. Berrange wrote: > > There is currently no explicit guidance on the duration of support > > for features such as versioned machine types, which have a finite > > useful lifespan. Th

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-17 Thread Daniel P. Berrange
On Mon, Jul 17, 2017 at 02:35:21PM +0800, Fam Zheng wrote: > Hi all, > > Today I've included a fourth type of the automatic patchew replies: FreeBSD. > > So far we have these tests running by patchew on each patch series: > > * Docker tests > Basically it is > make docker-test-quic

Re: [Qemu-devel] [PATCH V2 2/4] net/colo-compare.c: Compare the tcp packets that has the same sequence number

2017-07-17 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > > > On 07/17/2017 04:55 PM, Dr. David Alan Gilbert wrote: > > * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > > > > > > On 07/14/2017 11:25 AM, Jason Wang wrote: > > > > > > > > On 2017年07月13日 13:52, Zhang Chen wrote: > > > > > If prim

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-17 Thread Daniel P. Berrange
On Mon, Jul 17, 2017 at 10:05:31AM +0100, Stefan Hajnoczi wrote: > On Mon, Jul 17, 2017 at 02:35:21PM +0800, Fam Zheng wrote: > > Q1: In the worst case, you get four individual auto replies from patchew. Is > > that too many? Do you prefer one reply with all the results concatenated > > into > > o

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-17 Thread Peter Maydell
On 17 July 2017 at 10:39, Fam Zheng wrote: > On Mon, 07/17 10:28, Peter Maydell wrote: >> Ideally we'd streamline our make process to not produce so much >> irrelevant output :-) > > Does that mean to make "quite-command" absolutely quiet if V=1 is not > specified? The current 'quiet' mode is no

Re: [Qemu-devel] Poor 8K random IO performance inside the guest

2017-07-17 Thread Stefan Hajnoczi
On Fri, Jul 14, 2017 at 04:28:12AM +, Nagarajan, Padhu (HPE Storage) wrote: > During an 8K random-read fio benchmark, we observed poor performance inside > the guest in comparison to the performance seen on the host block device. The > table below shows the IOPS on the host and inside the gue

Re: [Qemu-devel] [PULL 0/4] slirp updates

2017-07-17 Thread Peter Maydell
On 15 July 2017 at 13:30, Samuel Thibault wrote: > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ > The following changes since commit 4871b51b9241b10f4fd8e04bbb21577886795e25: > > vmgenid-test: use boot-sector infrastructure (2017-07-14 17:03:03 +0100) > > are availabl

[Qemu-devel] [PATCH] add editorconfig

2017-07-17 Thread Gerd Hoffmann
Add a .editorconfig file for qemu. Specifies the indent and tab style for various files (C code and Makefiles for starters). Most popular editors support this either natively or via plugin. Check http://editorconfig.org/ for details. Signed-off-by: Gerd Hoffmann --- .editorconfig | 15 +++

[Qemu-devel] [PATCH] add scripts/git.orderfile

2017-07-17 Thread Gerd Hoffmann
Based on a old patch by Laszlo. Time to get this in ... Signed-off-by: Gerd Hoffmann --- scripts/git.orderfile | 29 + 1 file changed, 29 insertions(+) create mode 100644 scripts/git.orderfile diff --git a/scripts/git.orderfile b/scripts/git.orderfile new file mode

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

2017-07-17 Thread Stefan Hajnoczi
On Thu, Jul 13, 2017 at 08:01:16PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > There's a rare exit seg if the guest is accessing > IO during exit. > It's always hitting the atomic_inc(&bs->in_flight) with a NULL > bs. This was added recently in 99723548 but I

[Qemu-devel] [PATCH] add scripts/indent.sh

2017-07-17 Thread Gerd Hoffmann
Script to reformat sources in qemu style. Signed-off-by: Gerd Hoffmann --- scripts/indent.sh | 11 +++ 1 file changed, 11 insertions(+) create mode 100755 scripts/indent.sh diff --git a/scripts/indent.sh b/scripts/indent.sh new file mode 100755 index 00..8f045ecb1d --- /dev/nul

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

2017-07-17 Thread Kevin Wolf
Am 13.07.2017 um 15:27 hat Markus Armbruster geschrieben: > From: Alistair Francis > > Convert all uses of error_report("warning:"... to use warn_report() > instead. This helps standardise on a single method of printing warnings > to the user. > > All of the warnings were changed using these two

  1   2   3   4   5   6   7   >