Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 19/26] ppc/xive: introduce a helper to map the XIVE memory regions

2017-07-25 Thread Cédric Le Goater
On 07/25/2017 04:54 AM, Alexey Kardashevskiy wrote: > On 06/07/17 03:13, Cédric Le Goater wrote: >> It will be used when the guest chooses the XIVE exploitation mode in >> CAS. >> >> Signed-off-by: Cédric Le Goater >> --- >> hw/intc/xive.c| 11 +++ >>

Re: [Qemu-devel] [PULL for-2.10 00/14] A set of s390x patches

2017-07-25 Thread Cornelia Huck
On Tue, 25 Jul 2017 02:58:27 -0700 (PDT) no-re...@patchew.org wrote: > Hi, > > This series failed build test on FreeBSD host. Please find the details below. > > Message-id: 20170725094026.5376-1-coh...@redhat.com > Subject: [Qemu-devel] [PULL for-2.10 00/14] A set of s390x patches > Type:

Re: [Qemu-devel] [PULL 0/4] ppc-for-2.10 queue 20170725

2017-07-25 Thread Peter Maydell
> 18:15:45 +0100) > > are available in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.10-20170725 > > for you to fetch changes up to 86844c213348a596ea716a44a6f337555e07ad09: > > pseries: Update S

Re: [Qemu-devel] [PATCH v5 2/2 (for 2.10)] docs: document deprecated features in appendix

2017-07-25 Thread Daniel P. Berrange
On Tue, Jul 25, 2017 at 11:35:53AM +0200, Thomas Huth wrote: > On 19.07.2017 12:08, Daniel P. Berrange wrote: > > The deprecation of features in QEMU is totally adhoc currently, > > with no way for the user to get a list of what is deprecated > > in each release. This adds an appendix to the doc

Re: [Qemu-devel] [PATCH v1 0/6] target/s390x: tcg improvments + MSA functions

2017-07-25 Thread Cornelia Huck
On Fri, 21 Jul 2017 14:56:03 +0200 David Hildenbrand wrote: > Based on series: > "[PATCH v2 0/5] target/s390x: cpu model cleanups + improvements" I'm trying to decide what to do with this series; probably nothing for 2.10. > > 1. smaller pgm irq instruction length fixes

Re: [Qemu-devel] [PATCH] io: Always remove an old channel watch before adding a new one.

2017-07-25 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 11:15:44AM -0700, Brandon Carpenter wrote: > Also set saved handle to zero when removing without adding a new watch. > > Signed-off-by: Brandon Carpenter > --- > ui/vnc-auth-vencrypt.c | 3 +++ > ui/vnc-ws.c| 6 ++ >

Re: [Qemu-devel] [PATCH for 2.10 09/35] ui/vnc: fix leak of SocketAddress **

2017-07-25 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 03:27:25PM -0300, Philippe Mathieu-Daudé wrote: > Extract the (correct) cleaning code as a new function vnc_free_addresses() > then > use it to remove the memory leaks. > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé > ---

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 10:15:30PM -0300, Philippe Mathieu-Daudé wrote: > Reported-by: Sameeh Jubran > Signed-off-by: Philippe Mathieu-Daudé > --- > original report from Sameeh Jubran: > http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg00906.html >

Re: [Qemu-devel] [Qemu-block] [PATCH v3] util: remove the obsolete non-blocking connect

2017-07-25 Thread Daniel P. Berrange
On Tue, Jul 25, 2017 at 08:18:31AM +0200, Markus Armbruster wrote: > Mao Zhongyi writes: > > > On 07/25/2017 06:07 AM, John Snow wrote: > >> This was posted over a month ago with two R-Bs, did it get merged or > >> dropped? > >> > >> --js > > > > Not yet, I hope that

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Wei Wang
On 07/24/2017 05:00 PM, Michal Hocko wrote: On Wed 19-07-17 20:01:18, Wei Wang wrote: On 07/19/2017 04:13 PM, Michal Hocko wrote: [... All you should need is the check for the page reference count, no? I assume you do some sort of pfn walk and so you should be able to get an access to the

Re: [Qemu-devel] [PATCH V3] rtc: fix a infinite loop in windows vmstartup

2017-07-25 Thread peng.hao2
>On 25/07/2017 06:14, peng.h...@zte.com.cn wrote: >>> On 24/07/2017 20:35, Peng Hao wrote: >> >> >> >> >> When a windows vm starts, periodic timer of rtc will stop several times. windows kernel will check whether REG_A_UIP is changed. REG_C's interrupt flags will not be

[Qemu-devel] [PULL for-2.10 00/14] A set of s390x patches

2017-07-25 Thread Cornelia Huck
The following changes since commit b5a74cd81d76cb467552f38f2b39520d07c65ea2: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170724' into staging (2017-07-24 18:15:45 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20170725

[Qemu-devel] [PULL for-2.10 03/14] s390/cpumodel: remove KSS from the default model of z14

2017-07-25 Thread Cornelia Huck
From: Christian Borntraeger The SIE_KSS feature will allow a guest to use KSS for a nested guest. To create a nested guest the SIE_F2 facility is still necessary. Since SIE_F2 is not part of the default model it does not make a lot of sense to provide the SIE_KSS feature

[Qemu-devel] [PULL for-2.10 02/14] vfio/ccw: fix initialization of the Object DeviceState pointer in the common base-device

2017-07-25 Thread Cornelia Huck
From: Dong Jia Shi Commit 7da624e2 ("vfio: Test realized when using VFIOGroup.device_list iterator") introduced a pointer to the Object DeviceState in the VFIO common base-device and skipped non-realized devices as we iterate VFIOGroup.device_list. While it missed to

[Qemu-devel] [PULL for-2.10 12/14] target/s390x: Move exception-related functions to a new excp_helper.c file

2017-07-25 Thread Cornelia Huck
From: Thomas Huth These functions can not be compiled with --disable-tcg. But since we need the other functions from helper.c in the non-tcg build, we can also not simply remove helper.c from the non-tcg builds. Thus the problematic functions have to be moved into a separate

Re: [Qemu-devel] [PATCH V3] rtc: fix a infinite loop in windows vmstartup

2017-07-25 Thread Paolo Bonzini
On 25/07/2017 11:29, peng.h...@zte.com.cn wrote: >>On 25/07/2017 06:14, peng.h...@zte.com.cn wrote: > On 24/07/2017 20:35, Peng Hao wrote: >>> >>> >>> >>> >>> > When a windows vm starts, periodic timer of rtc will stop several times. > windows kernel will check whether REG_A_UIP

Re: [Qemu-devel] [PATCH] migration: optimize the downtime

2017-07-25 Thread Dr. David Alan Gilbert
* Jay Zhou (jianjay.z...@huawei.com) wrote: > > On 2017/7/24 23:35, Dr. David Alan Gilbert wrote: > > * Jay Zhou (jianjay.z...@huawei.com) wrote: > > > Hi Dave, > > > > > > On 2017/7/21 17:49, Dr. David Alan Gilbert wrote: > > > > * Jay Zhou (jianjay.z...@huawei.com) wrote: > > > > >

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about deprecation of old interfaces and features

2017-07-25 Thread Daniel P. Berrange
On Tue, Jul 25, 2017 at 01:10:38PM +0200, Paolo Bonzini wrote: > On 25/07/2017 13:07, Thomas Huth wrote: > > The list of deprecated interfaces/features in the wiki should be pretty > > complete now, so it is now time to draw some more public attention to our > > plans of removing certain

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Michal Hocko
On Tue 25-07-17 17:32:00, Wei Wang wrote: > On 07/24/2017 05:00 PM, Michal Hocko wrote: > >On Wed 19-07-17 20:01:18, Wei Wang wrote: > >>On 07/19/2017 04:13 PM, Michal Hocko wrote: > >[... > >>>All you should need is the check for the page reference count, no? I > >>>assume you do some sort of

Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port

2017-07-25 Thread Marcel Apfelbaum
On 25/07/2017 0:58, Michael S. Tsirkin wrote: On Tue, Jul 25, 2017 at 12:41:12AM +0300, Alexander Bezzubikov wrote: 2017-07-24 23:46 GMT+03:00 Michael S. Tsirkin : On Sun, Jul 23, 2017 at 05:13:11PM +0300, Marcel Apfelbaum wrote: On 23/07/2017 15:22, Michael S. Tsirkin wrote:

[Qemu-devel] [Bug 1181354] Re: assert failed in scsi-bus.c line 1539 in SCSI_XFER_NONE

2017-07-25 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1181354 Title: assert failed in scsi-bus.c line 1539 in SCSI_XFER_NONE Status in QEMU:

Re: [Qemu-devel] [PATCH 4/4] tests/pxe-test: add testcase using vhost-user-bridge

2017-07-25 Thread Jens Freimann
On Tue, Jul 25, 2017 at 01:06:51AM +0300, Michael S. Tsirkin wrote: On Fri, Jul 21, 2017 at 11:55:53AM +0200, Jens Freimann wrote: From: Jens Freimann Add a PXE testcase tunneling traffic through vhost-user-bridge process. Create a vhost-user-bridge process and connect

Re: [Qemu-devel] [PATCH v5 3/4] sockets: factor out a new try_bind() function

2017-07-25 Thread Daniel P. Berrange
On Sat, Jul 22, 2017 at 09:49:32AM +0200, Knut Omang wrote: > Another refactoring step to prepare for the problem > exposed by the test-listen test. > > This time simplify and reorganize the IPv6 specific extra > measures and move it out of the for loop to increase > code readability. No semantic

Re: [Qemu-devel] [PATCH v5 4/4] sockets: Handle race condition between binds to the same port

2017-07-25 Thread Daniel P. Berrange
On Sat, Jul 22, 2017 at 09:49:33AM +0200, Knut Omang wrote: > If an offset of ports is specified to the inet_listen_saddr function(), > and two or more processes tries to bind from these ports at the same time, > occasionally more than one process may be able to bind to the same > port. The

[Qemu-devel] [PATCH v6 (for 2.10) 0/1] Document deprecation policy & features

2017-07-25 Thread Daniel P. Berrange
This is a followup to v1: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg02390.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01286.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg00651.html v4:

Re: [Qemu-devel] Can I mount encrypt qcow2?

2017-07-25 Thread Eric Blake
On 07/24/2017 11:26 PM, lampahome wrote: > I thought 2.9.0 is the latest and check to the wrong commit. You're still top-posting, even after being told not to: http://www.caliburn.nl/topposting.html > Now it supports encryption. > > My cmd is: > >> qemu-nbd --object

Re: [Qemu-devel] [PATCH] Makefile: add all-user/all-linux-user/all-softmmu meta-targets

2017-07-25 Thread Peter Maydell
On 25 July 2017 at 07:11, Philippe Mathieu-Daudé wrote: > Useful to build a whole set at once. You can already do this by not specifying a --target-list= option and using whichever of --disable-system and --disable-user you need to skip the ones you don't want, can't you?

[Qemu-devel] [PULL for-2.10 09/14] target/s390x: Move s390_cpu_dump_state() to helper.c

2017-07-25 Thread Cornelia Huck
From: Thomas Huth translate.c can not be compiled with --disable-tcg, but we need the s390_cpu_dump_state() in KVM-only builds, too. So let's move that function to helper.c instead, which will also be compiled when --disable-tcg has been specified. Reviewed-by: Richard

[Qemu-devel] [PULL for-2.10 07/14] s390x/kvm: better comment regarding zPCI feature availability

2017-07-25 Thread Cornelia Huck
From: David Hildenbrand Acked-by: Christian Borntraeger Signed-off-by: David Hildenbrand Message-Id: <20170720123721.12366-5-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/kvm.c | 2 +- 1 file

[Qemu-devel] [PATCH v2] char: don't exit on hmp 'chardev-add help'

2017-07-25 Thread Anton Nefedov
qemu_chr_new_from_opts() is used from both vl.c and hmp, and it is quite confusing to see qemu suddenly exit after receiving a help option in hmp. Do exit(0) from vl.c instead. Signed-off-by: Anton Nefedov --- include/chardev/char.h | 4 +++- chardev/char.c

Re: [Qemu-devel] [PATCH 4/7] block: convert ThrottleGroup to object with QOM

2017-07-25 Thread Manos Pitsidianakis
On Mon, Jul 24, 2017 at 04:12:47PM +0100, Stefan Hajnoczi wrote: On Fri, Jul 14, 2017 at 12:45:18PM +0300, Manos Pitsidianakis wrote: ThrottleGroup is converted to an object. This will allow the future throttle block filter drive easy creation and configuration of throttle groups in QMP and

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix reference output for 186

2017-07-25 Thread Markus Armbruster
Kevin Wolf writes: > Commits 70f17a1 ('error: Revert unwanted change of warning messages') > and e1824e5 ('qemu-iotests: Test 'info block'') had a semantic merge > conflict, which results in failure for qemu-iotests case 186. Fix the > reference output to consider the changes

Re: [Qemu-devel] [Bug 1706296] [NEW] Booting NT 4 disk causes /home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion failed: (!qemu_mutex_iothread_locked())

2017-07-25 Thread Thomas Huth
On 25.07.2017 11:30, Richard Jones wrote: > ERROR:/home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion > failed: (!qemu_mutex_iothread_locked()) > Aborted (core dumped) > > The stack trace in the failing thread is: > > Thread 4 (Thread 0x7fffb0418700 (LWP 21979)): > #0

Re: [Qemu-devel] [RFC PATCH v2 6/6] hw/pci: add hint capabilty for additional bus reservation to pcie-root-port

2017-07-25 Thread Marcel Apfelbaum
On 25/07/2017 0:43, Alexander Bezzubikov wrote: 2017-07-24 23:43 GMT+03:00 Michael S. Tsirkin : On Sun, Jul 23, 2017 at 01:15:43AM +0300, Aleksandr Bezzubikov wrote: Signed-off-by: Aleksandr Bezzubikov --- hw/pci-bridge/pcie_root_port.c | 5 + 1

Re: [Qemu-devel] [PULL for-2.10 00/14] A set of s390x patches

2017-07-25 Thread Peter Maydell
00) > > are available in the git repository at: > > git://github.com/cohuck/qemu tags/s390x-20170725 > > for you to fetch changes up to 7e01376daea75e888c370aab521a7d4aeaf2ffd1: > > s390x/css: fix ilen in IO in

[Qemu-devel] [Bug 1473451] Re: Please support the native bios format for dec alpha

2017-07-25 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1473451 Title: Please support the native bios format for dec alpha Status in QEMU: New

Re: [Qemu-devel] [PATCH v5 2/2 (for 2.10)] docs: document deprecated features in appendix

2017-07-25 Thread Thomas Huth
On 19.07.2017 12:08, Daniel P. Berrange wrote: > The deprecation of features in QEMU is totally adhoc currently, > with no way for the user to get a list of what is deprecated > in each release. This adds an appendix to the doc that records > when each deprecation was made and provides text

[Qemu-devel] [PULL for-2.10 14/14] s390x/css: fix ilen in IO instruction handlers

2017-07-25 Thread Cornelia Huck
From: Halil Pasic When initiating a program check interruption by calling program_interrupt the instruction length (ilen) of the current instruction is supplied as the third parameter. On s390x all the IO instructions are of instruction format S and their ilen is 4.

[Qemu-devel] [PULL for-2.10 13/14] target/s390x: Add remaining switches to compile with --disable-tcg

2017-07-25 Thread Cornelia Huck
From: Thomas Huth Adding some CONFIG_TCG tests to be finally able to compile QEMU on s390x also without TCG. Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth Message-Id: <1500886370-14572-6-git-send-email-th...@redhat.com>

Re: [Qemu-devel] [RFC PATCH 09/26] ppc/xive: add an overall memory region for the ESBs

2017-07-25 Thread Cédric Le Goater
On 07/25/2017 04:19 AM, David Gibson wrote: > On Mon, Jul 24, 2017 at 03:25:29PM +0200, Cédric Le Goater wrote: >> On 07/24/2017 08:09 AM, Benjamin Herrenschmidt wrote: >>> On Mon, 2017-07-24 at 14:49 +1000, David Gibson wrote: On Wed, Jul 05, 2017 at 07:13:22PM +0200, Cédric Le Goater wrote:

Re: [Qemu-devel] [PATCH v6 (for 2.10) 1/1] docs: document deprecation policy & deprecated features in appendix

2017-07-25 Thread Thomas Huth
On 25.07.2017 13:36, Daniel P. Berrange wrote: > The deprecation of features in QEMU is totally adhoc currently, s/adhoc/ad hoc/ > with no way for the user to get a list of what is deprecated > in each release. This adds an appendix to the doc that records > when each deprecation was made and

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

2017-07-25 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 09:55:20PM +0200, Hervé Poussineau wrote: > Le 24/07/2017 à 18:46, Daniel P. Berrange a écrit : > > The processing of the scancodes for PAUSE/BREAK has been broken since > > the conversion to qcodes in: > > > > commit 8c10e0baf0260b59a4e984744462a18016662e3e > >

[Qemu-devel] [PATCH] qemu-iotests: Fix reference output for 186

2017-07-25 Thread Kevin Wolf
Commits 70f17a1 ('error: Revert unwanted change of warning messages') and e1824e5 ('qemu-iotests: Test 'info block'') had a semantic merge conflict, which results in failure for qemu-iotests case 186. Fix the reference output to consider the changes of 70f17a1. Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL for-2.10 08/14] target/s390x: improve baselining if certain base features are missing

2017-07-25 Thread Cornelia Huck
From: David Hildenbrand There are certain features that we put into base models, but that are not relevant for the actual search. The most famous example are MSA subfunctions that might be disabled on certain real hardware out there. While the kvm host model detection will

Re: [Qemu-devel] [PATCH v2] char: don't exit on hmp 'chardev-add help'

2017-07-25 Thread Paolo Bonzini
On 25/07/2017 12:04, Anton Nefedov wrote: > qemu_chr_new_from_opts() is used from both vl.c and hmp, > and it is quite confusing to see qemu suddenly exit after receiving a help > option in hmp. > > Do exit(0) from vl.c instead. Queued, thanks. Paolo > Signed-off-by: Anton Nefedov

Re: [Qemu-devel] [PATCH V2] vhost: fix a migration failed because of vhost region merge

2017-07-25 Thread Igor Mammedov
On Mon, 24 Jul 2017 23:50:00 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 24, 2017 at 11:14:19AM +0200, Igor Mammedov wrote: > > On Sun, 23 Jul 2017 20:46:11 +0800 > > Peng Hao wrote: > > > > > When a guest that has several hotplugged dimms is

Re: [Qemu-devel] [RFC PATCH 14/26] ppc/xive: add MMIO handlers to the XIVE interrupt presenter model

2017-07-25 Thread Cédric Le Goater
On 07/25/2017 06:20 AM, David Gibson wrote: > On Mon, Jul 24, 2017 at 04:44:00PM +0200, Cédric Le Goater wrote: >> On 07/24/2017 08:35 AM, David Gibson wrote: >>> On Wed, Jul 05, 2017 at 07:13:27PM +0200, Cédric Le Goater wrote: The Thread Interrupt Management Area for the OS is mostly used

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 26/26] spapr: force XIVE exploitation mode for POWER9 (HACK)

2017-07-25 Thread Cédric Le Goater
On 07/25/2017 04:43 AM, Alexey Kardashevskiy wrote: > On 06/07/17 03:13, Cédric Le Goater wrote: >> The CAS negotiation process determines the interrupt controller model >> to use in the guest but currently, the sPAPR machine make uses of the >> controller very early in the initialization

[Qemu-devel] [PULL for-2.10 01/14] vfio/ccw: allocate irq info with the right size

2017-07-25 Thread Cornelia Huck
From: Jing Zhang When allocating memory for the vfio_irq_info parameter of the VFIO_DEVICE_GET_IRQ_INFO ioctl, we used the wrong size. Let's fix it by using the right size. Reviewed-by: Dong Jia Shi Signed-off-by: Jing Zhang

[Qemu-devel] [Bug 1706296] [NEW] Booting NT 4 disk causes /home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion failed: (!qemu_mutex_iothread_locked())

2017-07-25 Thread Richard Jones
Public bug reported: Grab the NT 4 disk from https://archive.org/details/Microsoft_Windows_NT_Server_Version_4.0_227-075 -385_CD-KEY_419-1343253_1996 Try to boot it as follows: qemu-system-x86_64 -hda disk.img -cdrom

Re: [Qemu-devel] [PULL for-2.10 00/14] A set of s390x patches

2017-07-25 Thread no-reply
Hi, This series failed build test on FreeBSD host. Please find the details below. Message-id: 20170725094026.5376-1-coh...@redhat.com Subject: [Qemu-devel] [PULL for-2.10 00/14] A set of s390x patches Type: series === TEST SCRIPT BEGIN === #!/bin/sh # Testing script will be invoked under the

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-25 Thread Peter Maydell
On 17 July 2017 at 11:26, Daniel P. Berrange wrote: > On Mon, Jul 17, 2017 at 11:06:12AM +0100, Peter Maydell wrote: >> The current 'quiet' mode is not quite aimed at the same purpose: >> it's good for interactive use where you don't want the long detail >> of command lines

[Qemu-devel] [qemu-web PATCH] Add a blog post about deprecation of old interfaces and features

2017-07-25 Thread Thomas Huth
The list of deprecated interfaces/features in the wiki should be pretty complete now, so it is now time to draw some more public attention to our plans of removing certain interfaces/features in future releases. Signed-off-by: Thomas Huth --- _posts/2017-07-25-deprecation.md |

Re: [Qemu-devel] [PATCH 11/13] instrument: [qapi] Add library loader

2017-07-25 Thread Eric Blake
On 07/25/2017 03:24 AM, Lluís Vilanova wrote: > Eric Blake writes: > >> On 07/24/2017 12:46 PM, Lluís Vilanova wrote: >>> Signed-off-by: Lluís Vilanova >>> --- >>> instrument/Makefile.objs |1 + >>> instrument/qmp.c | 71 >>>

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Wei Wang
On 07/25/2017 07:25 PM, Michal Hocko wrote: On Tue 25-07-17 17:32:00, Wei Wang wrote: On 07/24/2017 05:00 PM, Michal Hocko wrote: On Wed 19-07-17 20:01:18, Wei Wang wrote: On 07/19/2017 04:13 PM, Michal Hocko wrote: [... All you should need is the check for the page reference count, no? I

Re: [Qemu-devel] [RFC PATCH 08/26] ppc/xive: add flags to the XIVE interrupt source

2017-07-25 Thread Cédric Le Goater
On 07/25/2017 07:47 AM, Benjamin Herrenschmidt wrote: > On Tue, 2017-07-25 at 14:18 +1000, David Gibson wrote: >>> Well, at this point I think nothing will set that flag It's there >>> for workaround around HW bugs on some chips. At least in full emu it >>> shouldn't happen unless we try to

Re: [Qemu-devel] [RFC PATCH 04/26] ppc/xive: introduce a skeleton for the XIVE interrupt controller model

2017-07-25 Thread Cédric Le Goater
On 07/24/2017 12:03 PM, David Gibson wrote: > On Mon, Jul 24, 2017 at 05:20:26PM +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2017-07-24 at 15:38 +1000, David Gibson wrote: >>> >>> Can we assign our logical numbers sparsely, or will that cause other >>> problems? >> >> The main issue is that

Re: [Qemu-devel] [PATCH v5 2/4] sockets: factor out create_fast_reuse_socket

2017-07-25 Thread Daniel P. Berrange
On Sat, Jul 22, 2017 at 09:49:31AM +0200, Knut Omang wrote: > First refactoring step to prepare for fixing the problem > exposed with the test-listen test in the previous commit > > Signed-off-by: Knut Omang > --- > util/qemu-sockets.c | 24 +--- > 1

Re: [Qemu-devel] [PATCH] Makefile: add all-user/all-linux-user/all-softmmu meta-targets

2017-07-25 Thread Paolo Bonzini
On 25/07/2017 08:11, Philippe Mathieu-Daudé wrote: > Useful to build a whole set at once. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Makefile | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index

[Qemu-devel] [PULL for-2.10 10/14] target/s390x: Move diag helpers to a separate file

2017-07-25 Thread Cornelia Huck
From: Thomas Huth misc_helper.c won't be compiled with --disable-tcg anymore, but we still need the diag helpers in KVM builds, too, so move the helper functions to a separate file. Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH v6 (for 2.10) 1/1] docs: document deprecation policy & deprecated features in appendix

2017-07-25 Thread Daniel P. Berrange
The deprecation of features in QEMU is totally adhoc currently, with no way for the user to get a list of what is deprecated in each release. This adds an appendix to the doc that records when each deprecation was made and provides text explaining what to use instead, if anything. Since there has

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

2017-07-25 Thread Gerd Hoffmann
Hi, > > You're putting some specific code for spice in ps2 emulation. > > IMO, the workaround should be moved to spice keyboard handling > > (ui/spice-input.c), > > which needs to generate a qcode instead of a scancode. > > This isn't really a spice specific hack. QEMU internal code is *not* >

Re: [Qemu-devel] [PATCH 11/13] instrument: [qapi] Add library loader

2017-07-25 Thread Lluís Vilanova
Eric Blake writes: > On 07/24/2017 12:46 PM, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> --- >> instrument/Makefile.objs |1 + >> instrument/qmp.c | 71 >> qapi-schema.json |3 ++ >>

Re: [Qemu-devel] [PATCH] io: Improve websocket support by becoming more RFC compliant.

2017-07-25 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 11:42:17AM -0700, Brandon Carpenter wrote: > Remembering the opcode is sufficient for handling fragmented frames from > the client, which may be introduced by an intermediary server/proxy. > Respond to pings and ignore pongs rather than close the connection as > many

[Qemu-devel] [PULL for-2.10 05/14] target/s390x: indicate query subfunction in s390_fill_feat_block

2017-07-25 Thread Cornelia Huck
From: David Hildenbrand We'll have to do the same for TCG, so let's just move it in there. Reviewed-by: Christian Borntraeger Signed-off-by: David Hildenbrand Message-Id: <20170720123721.12366-3-da...@redhat.com> Signed-off-by:

[Qemu-devel] [PULL for-2.10 06/14] target/s390x: introduce (test|set)_be_bit

2017-07-25 Thread Cornelia Huck
From: David Hildenbrand Using ordinary bitmap operations to set/test bits does not work properly on architectures !s390x. Let's drop (test|set)_bit_inv and introduce (test|set)_be_bit instead. These functions work on uint8_t array, not on unsigned longs arrays and are for now

[Qemu-devel] [PULL for-2.10 04/14] target/s390x: drop BE_BIT()

2017-07-25 Thread Cornelia Huck
From: David Hildenbrand Unused and broken, let's just get rid of it. Acked-by: Christian Borntraeger Signed-off-by: David Hildenbrand Message-Id: <20170720123721.12366-2-da...@redhat.com> Signed-off-by: Cornelia Huck

[Qemu-devel] [PULL for-2.10 11/14] target/s390x: Rework program_interrupt() and related functions

2017-07-25 Thread Cornelia Huck
From: Thomas Huth misc_helper.c won't be compiled with --disable-tcg anymore, but we still need the program_interrupt() function in that case. Move it to interrupt.c instead, and refactor it to re-use the code from trigger_pgm_exception() (for TCG) and enter_pgmcheck() (for

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about deprecation of old interfaces and features

2017-07-25 Thread Paolo Bonzini
On 25/07/2017 13:07, Thomas Huth wrote: > The list of deprecated interfaces/features in the wiki should be pretty > complete now, so it is now time to draw some more public attention to our > plans of removing certain interfaces/features in future releases. > > Signed-off-by: Thomas Huth

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about deprecation of old interfaces and features

2017-07-25 Thread Thomas Huth
On 25.07.2017 13:15, Daniel P. Berrange wrote: > On Tue, Jul 25, 2017 at 01:10:38PM +0200, Paolo Bonzini wrote: >> On 25/07/2017 13:07, Thomas Huth wrote: >>> The list of deprecated interfaces/features in the wiki should be pretty >>> complete now, so it is now time to draw some more public

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about deprecation of old interfaces and features

2017-07-25 Thread Daniel P. Berrange
On Tue, Jul 25, 2017 at 01:23:24PM +0200, Thomas Huth wrote: > On 25.07.2017 13:15, Daniel P. Berrange wrote: > > On Tue, Jul 25, 2017 at 01:10:38PM +0200, Paolo Bonzini wrote: > >> On 25/07/2017 13:07, Thomas Huth wrote: > >>> The list of deprecated interfaces/features in the wiki should be

Re: [Qemu-devel] [PATCH 11/13] instrument: [qapi] Add library loader

2017-07-25 Thread Lluís Vilanova
Eric Blake writes: > On 07/25/2017 03:24 AM, Lluís Vilanova wrote: >> Eric Blake writes: >> >>> On 07/24/2017 12:46 PM, Lluís Vilanova wrote: Signed-off-by: Lluís Vilanova --- instrument/Makefile.objs |1 + instrument/qmp.c | 71

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Michal Hocko
On Tue 25-07-17 19:56:24, Wei Wang wrote: > On 07/25/2017 07:25 PM, Michal Hocko wrote: > >On Tue 25-07-17 17:32:00, Wei Wang wrote: > >>On 07/24/2017 05:00 PM, Michal Hocko wrote: > >>>On Wed 19-07-17 20:01:18, Wei Wang wrote: > On 07/19/2017 04:13 PM, Michal Hocko wrote: > >>>[... > >All

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix reference output for 186

2017-07-25 Thread Stefan Hajnoczi
On Tue, Jul 25, 2017 at 10:59:36AM +0200, Kevin Wolf wrote: > Commits 70f17a1 ('error: Revert unwanted change of warning messages') > and e1824e5 ('qemu-iotests: Test 'info block'') had a semantic merge > conflict, which results in failure for qemu-iotests case 186. Fix the > reference output to

Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

2017-07-25 Thread Michael S. Tsirkin
On Mon, Jul 24, 2017 at 08:48:48AM +0200, Igor Mammedov wrote: > On Sat, 22 Jul 2017 02:40:46 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Jul 21, 2017 at 12:10:48PM +0200, Igor Mammedov wrote: > > > On Fri, 21 Jul 2017 10:49:55 +0100 > > > "Daniel P. Berrange"

[Qemu-devel] [PATCH for 2.10 v2 1/6] docker: ensure NOUSER for travis images

2017-07-25 Thread Alex Bennée
While adding the current user is a useful default behaviour for creating new images it is not appropriate for Travis which already has a default user. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH for 2.10 v2 3/6] docker: ignore submodules when checking diff

2017-07-25 Thread Alex Bennée
The QEMU tree often has dirty submodules in it but this will confuse things as git stash is not going to save their state directly. They are likely just dirty from build files anyway. Ignore them in the diff-index command. Signed-off-by: Alex Bennée Reviewed-by: Eric

Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port

2017-07-25 Thread Michael S. Tsirkin
On Sun, Jul 23, 2017 at 05:13:11PM +0300, Marcel Apfelbaum wrote: > On 23/07/2017 15:22, Michael S. Tsirkin wrote: > > On Sun, Jul 23, 2017 at 01:15:42AM +0300, Aleksandr Bezzubikov wrote: > > > To enable hotplugging of a newly created pcie-pci-bridge, > > > we need to tell firmware (SeaBIOS in

Re: [Qemu-devel] [RFC PATCH 11/26] ppc/xics: introduce a print_info() handler to the ICS and ICP objects

2017-07-25 Thread David Gibson
On Mon, Jul 24, 2017 at 03:58:50PM +0200, Cédric Le Goater wrote: > On 07/24/2017 07:13 AM, David Gibson wrote: > > On Wed, Jul 05, 2017 at 07:13:24PM +0200, Cédric Le Goater wrote: > >> This handler will be used to customize the ouput of the XIVE interrupt > >> source and presenter objects. > >

Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port

2017-07-25 Thread Alexander Bezzubikov
2017-07-25 16:53 GMT+03:00 Michael S. Tsirkin : > On Tue, Jul 25, 2017 at 04:50:49PM +0300, Alexander Bezzubikov wrote: >> 2017-07-25 16:43 GMT+03:00 Michael S. Tsirkin : >> > On Sun, Jul 23, 2017 at 05:13:11PM +0300, Marcel Apfelbaum wrote: >> >> On 23/07/2017

[Qemu-devel] [PATCH V5 07/10] block/qcow2: optimize qcow2_co_pwritev_compressed

2017-07-25 Thread Peter Lieven
if we specify exactly one iov of s->cluster_size bytes we can avoid the bounce buffer. Signed-off-by: Peter Lieven --- block/qcow2.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index ffe609d..a12b3d7 100644 ---

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Wang, Wei W
On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: > On Tue 25-07-17 19:56:24, Wei Wang wrote: > > On 07/25/2017 07:25 PM, Michal Hocko wrote: > > >On Tue 25-07-17 17:32:00, Wei Wang wrote: > > >>On 07/24/2017 05:00 PM, Michal Hocko wrote: > > >>>On Wed 19-07-17 20:01:18, Wei Wang wrote: > >

Re: [Qemu-devel] [sw-dev] RFC: QEMU RISC-V modular ISA decoding

2017-07-25 Thread Samuel Falvo II
For those of us who are not in the know, how does target/s390 decoding work? I've maintained a 65816 emulator (https://bitbucket.org/kc5tja/lib65816/src) which also uses a giant case construct. This method is used because it's fast. Any alternative approaches you decide to take might well work

Re: [Qemu-devel] [PATCH v2 1/1] monitor: improve tracing in handle_qmp_command

2017-07-25 Thread Eric Blake
On 07/25/2017 09:39 AM, Denis V. Lunev wrote: > Calculate req_json only if trace_handle_qmp_command enabled. > > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Lluís Vilanova > CC: Dr. David Alan Gilbert

[Qemu-devel] [PATCH for 2.10 v2 4/6] docker: docker.py make --no-cache skip checksum test

2017-07-25 Thread Alex Bennée
If you invoke with NOCACHE=1 we pass --no-cache in the argv to docker.py but may still not force a rebuild if the dockerfile checksum hasn't changed. By testing for its presence we can force builds without having to manually remove the docker image. Signed-off-by: Alex Bennée

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-25 Thread Stefan Hajnoczi
On Mon, Jul 24, 2017 at 07:32:29PM +0300, Lluís Vilanova wrote: > Denis V Lunev writes: > > > On 07/24/2017 05:43 PM, Lluís Vilanova wrote: > >> Denis V Lunev writes: > >> > >>> On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: > On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir

Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port

2017-07-25 Thread Michael S. Tsirkin
On Tue, Jul 25, 2017 at 04:50:49PM +0300, Alexander Bezzubikov wrote: > 2017-07-25 16:43 GMT+03:00 Michael S. Tsirkin : > > On Sun, Jul 23, 2017 at 05:13:11PM +0300, Marcel Apfelbaum wrote: > >> On 23/07/2017 15:22, Michael S. Tsirkin wrote: > >> > On Sun, Jul 23, 2017 at

Re: [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input

2017-07-25 Thread Stefan Hajnoczi
On Fri, Jul 21, 2017 at 03:53:23PM +0200, Markus Armbruster wrote: > Leaving interpolation into JSON to qmp() is more robust than building > QMP input manually, as explained in the commit before previous. > > The case in qpci_plug_device_test() is a bit complicated: it > interpolates several JSON

[Qemu-devel] [PATCH V5 05/10] block/qcow2: read and write the compress format extension

2017-07-25 Thread Peter Lieven
we now read the extension on open and write it on update, but do not yet use it. Signed-off-by: Peter Lieven --- block/qcow2.c | 92 +++ block/qcow2.h | 21 ++ 2 files changed, 108 insertions(+), 5 deletions(-)

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Michal Hocko
On Tue 25-07-17 14:47:16, Wang, Wei W wrote: > On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: > > On Tue 25-07-17 19:56:24, Wei Wang wrote: > > > On 07/25/2017 07:25 PM, Michal Hocko wrote: > > > >On Tue 25-07-17 17:32:00, Wei Wang wrote: > > > >>On 07/24/2017 05:00 PM, Michal Hocko wrote: >

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: Fix reference output for 186

2017-07-25 Thread Max Reitz
On 2017-07-25 10:59, Kevin Wolf wrote: > Commits 70f17a1 ('error: Revert unwanted change of warning messages') > and e1824e5 ('qemu-iotests: Test 'info block'') had a semantic merge > conflict, which results in failure for qemu-iotests case 186. Fix the > reference output to consider the changes

Re: [Qemu-devel] [PATCH v6 (for 2.10) 0/1] Document deprecation policy & features

2017-07-25 Thread Stefan Hajnoczi
On Tue, Jul 25, 2017 at 12:26:55PM +0100, Daniel P. Berrange wrote: > This is a followup to > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg02390.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01286.html > v3:

Re: [Qemu-devel] [RFC PATCH 14/26] ppc/xive: add MMIO handlers to the XIVE interrupt presenter model

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 11:08:46AM +0200, Cédric Le Goater wrote: > On 07/25/2017 06:20 AM, David Gibson wrote: > > On Mon, Jul 24, 2017 at 04:44:00PM +0200, Cédric Le Goater wrote: > >> On 07/24/2017 08:35 AM, David Gibson wrote: > >>> On Wed, Jul 05, 2017 at 07:13:27PM +0200, Cédric Le Goater

Re: [Qemu-devel] [RFC PATCH 04/26] ppc/xive: introduce a skeleton for the XIVE interrupt controller model

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 10:52:27AM +0200, Cédric Le Goater wrote: > On 07/24/2017 12:03 PM, David Gibson wrote: > > On Mon, Jul 24, 2017 at 05:20:26PM +1000, Benjamin Herrenschmidt wrote: > >> On Mon, 2017-07-24 at 15:38 +1000, David Gibson wrote: > >>> > >>> Can we assign our logical numbers

[Qemu-devel] [PATCH for 2.10 v2 6/6] docker: reduce noise when building travis.docker

2017-07-25 Thread Alex Bennée
Set the DEBIAN_FRONTEND and locale env vars to stop apt complaining so much as we build the image. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/travis.docker | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-25 Thread Stefan Hajnoczi
On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote: > Let's make args public so users can extend it without feeling like > abusing the internal API. Nothing is abusing an internal API. PEP8 describes the difference between public (no underscore), protected aka subclass API (single

Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port

2017-07-25 Thread Alexander Bezzubikov
2017-07-25 16:43 GMT+03:00 Michael S. Tsirkin : > On Sun, Jul 23, 2017 at 05:13:11PM +0300, Marcel Apfelbaum wrote: >> On 23/07/2017 15:22, Michael S. Tsirkin wrote: >> > On Sun, Jul 23, 2017 at 01:15:42AM +0300, Aleksandr Bezzubikov wrote: >> > > To enable hotplugging of a newly

Re: [Qemu-devel] [PATCH] hw/core/loader: do not check for regions overlap

2017-07-25 Thread Hua Yanghao
On Mon, Jul 24, 2017 at 11:21 PM, Peter Maydell wrote: > On 24 July 2017 at 21:03, Hua Yanghao wrote: >> Sounds good PPM! currently I am working around this by >> objcopy a pure binary and it looks like qemu-system-arm is >> loading a binary at

Re: [Qemu-devel] [PATCH for 2.10 v2 5/6] docker: don't install device-tree-compiler build-deps in travis.docker

2017-07-25 Thread Philippe Mathieu-Daudé
On 07/25/2017 10:34 AM, Alex Bennée wrote: Installing the device-tree-compiler build-deps is a little extreme. We only actually need the binary so include it with the other packages. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 19/26] ppc/xive: introduce a helper to map the XIVE memory regions

2017-07-25 Thread Alexey Kardashevskiy
On 25/07/17 19:18, Cédric Le Goater wrote: > On 07/25/2017 04:54 AM, Alexey Kardashevskiy wrote: >> On 06/07/17 03:13, Cédric Le Goater wrote: >>> It will be used when the guest chooses the XIVE exploitation mode in >>> CAS. >>> >>> Signed-off-by: Cédric Le Goater >>> --- >>>

  1   2   3   4   5   >