Re: [Qemu-devel] [PATCH for-2.10?] file-posix: Clear out first sector in hdev_create

2017-08-10 Thread Eric Blake
On 08/10/2017 03:01 AM, Fam Zheng wrote: > People get surprised when, after "qemu-imc create -f raw /dev/sdX", they > still see qcow2 with "qemu-img info", if previously the bdev had a qcow2 > header. While this is natural because raw doesn't need to write any > magic bytes during creation,

Re: [Qemu-devel] [PATCH 2/2] vl: Partial support for non-scalar properties with -object

2017-08-10 Thread Paolo Bonzini
On 10/08/2017 14:25, Markus Armbruster wrote: > We've wanted -object to support non-scalar properties for a while. > Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based > authorization API". Review led to the conclusion that we need to > replace rather than add to QemuOpts. Initial work

[Qemu-devel] [PATCH 07/15] input: convert ps2 device to keycodemapdb

2017-08-10 Thread Daniel P. Berrange
Replace the qcode_to_keycode_set1, qcode_to_keycode_set2, and qcode_to_keycode_set3 tables with automatically generated tables. Missing entries in qcode_to_keycode_set1 now fixed: - Q_KEY_CODE_SYSRQ -> 0x54 - Q_KEY_CODE_PRINT -> 0x54 (NB ignored due to special case) - Q_KEY_CODE_AGAIN ->

[Qemu-devel] [PATCH 13/15] ui: remove qemu_input_qcode_to_number method

2017-08-10 Thread Daniel P. Berrange
The qemu_input_qcode_to_number method is only used in one place and no new code should require it, so inline it at the only caller. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 1 - ui/input-keymap.c | 16 +++- 2 files changed, 7 insertions(+),

[Qemu-devel] [PATCH 09/15] char: convert the escc device to keycodemapdb

2017-08-10 Thread Daniel P. Berrange
Replace the qcode_to_keycode table with automatically generated tables. Missing entries in qcode_to_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x2d Signed-off-by: Daniel P. Berrange --- hw/char/escc.c | 126 +++--

[Qemu-devel] [PULL] 9pfs: local: fix fchmodat_nofollow() limitations

2017-08-10 Thread Greg Kurz
This function has to ensure it doesn't follow a symlink that could be used to escape the virtfs directory. This could be easily achieved if fchmodat() on linux honored the AT_SYMLINK_NOFOLLOW flag as described in POSIX, but it doesn't. There was a tentative to implement a new fchmodat2() syscall

[Qemu-devel] [PATCH 1/8] tests: add functional test validating ipv4/ipv6 address flag handling

2017-08-10 Thread Daniel P. Berrange
The semantics around handling ipv4=on|off & ipv6=on|off are quite subtle to understand in combination with the various hostname addresses and backend types. Introduce a massive test matrix that launches QEMU and validates the ability to connect a client on each protocol as appropriate. The test

[Qemu-devel] [PATCH 6/8] chardev: convert the socket server to QIONetListener

2017-08-10 Thread Daniel P. Berrange
Instead of creating a QIOChannelSocket directly for the chardev server socket, use a QIONetListener. This provides the ability to listen on multiple sockets at the same time, so enables full support for IPv4/IPv6 dual stack. Signed-off-by: Daniel P. Berrange ---

Re: [Qemu-devel] [PATCH] virtio-blk: handle blk_getlength() errors

2017-08-10 Thread Stefan Hajnoczi
On Tue, Aug 08, 2017 at 01:22:51PM +0100, Stefan Hajnoczi wrote: > If blk_getlength() fails in virtio_blk_update_config() consider the disk > image length to be 0 bytes. > > Signed-off-by: Stefan Hajnoczi > --- > hw/block/virtio-blk.c | 4 +++- > 1 file changed, 3

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-10 Thread Pradeep Jagadeesh
On 8/8/2017 5:18 PM, Markus Armbruster wrote: Alberto Garcia writes: On Tue 08 Aug 2017 02:30:43 PM CEST, Pradeep Jagadeesh wrote: On 8/8/2017 1:30 PM, Alberto Garcia wrote: On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote: Awkward question for a v7, but here

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-10 Thread Eric Blake
On 08/10/2017 09:06 AM, Pradeep Jagadeesh wrote: >>> It's not "moving it back", it's keeping it where it is. But I see no big >>> problem with moving it to a common file either. >> >> I'd rather not put every struct shared across subsystem boundaries in >> its own file. >> >> We can keep it right

[Qemu-devel] [PATCH 05/15] ui: use QKeyCode exclusively in InputKeyEvent

2017-08-10 Thread Daniel P. Berrange
Now that keycode numbers are converted to QKeyCodes immediately when creating input events, the InputKeyEvent struct can be changed to only accept a QKeyCode, instead of a KeyValue. Signed-off-by: Daniel P. Berrange --- hw/char/escc.c | 2 +- hw/input/adb.c

[Qemu-devel] [PATCH 04/15] ui: don't export qemu_input_event_new_key

2017-08-10 Thread Daniel P. Berrange
All public code should use qemu_input_event_send_key* functions instead of creating an event directly. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 1 - ui/input.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/ui/input.h

[Qemu-devel] [PATCH 15/15] display: convert XenInput keyboard to keycodemapdb

2017-08-10 Thread Daniel P. Berrange
Replace the scancode2linux table with an automatically generated table. In doing so, the XenFB keyboard handler is also converted to the modern InputEvent framework. Signed-off-by: Daniel P. Berrange --- hw/display/xenfb.c | 131

[Qemu-devel] [PATCH 14/15] ui: remove qemu_input_linux_to_qcode method

2017-08-10 Thread Daniel P. Berrange
The qemu_input_linux_to_qcode method is only used in one place and no new code should require it, so inline it at the only caller. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 1 - ui/input-keymap.c | 8 ui/input-linux.c | 4 ++-- 3 files changed,

Re: [Qemu-devel] [PATCH v4 4/7] block: convert ThrottleGroup to object with QOM

2017-08-10 Thread Alberto Garcia
On Wed 09 Aug 2017 12:07:31 PM CEST, Manos Pitsidianakis wrote: > +/* unfix buckets to check validity */ > +throttle_get_config(>ts, cfg); > +if (!throttle_is_valid(cfg, errp)) { > +return; > +} > +/* fix buckets again */ > +throttle_config(>ts, tg->clock_type,

Re: [Qemu-devel] [PATCH v6 02/19] migration: Teach it about G_SOURCE_REMOVE

2017-08-10 Thread Daniel P. Berrange
On Tue, Aug 08, 2017 at 06:26:12PM +0200, Juan Quintela wrote: > As this is defined on glib 2.32, add compatibility macros for older glibs. > > Signed-off-by: Juan Quintela > --- > include/glib-compat.h | 2 ++ > migration/exec.c | 2 +- > migration/fd.c| 2 +-

Re: [Qemu-devel] [PATCH v6 05/19] qio: Create new qio_channel_{readv, writev}_all

2017-08-10 Thread Daniel P. Berrange
On Tue, Aug 08, 2017 at 06:26:15PM +0200, Juan Quintela wrote: > The functions waits until it is able to write the full iov. > > Signed-off-by: Juan Quintela > > -- > > Add tests. > > fix reader to check for len == 0. > --- > include/io/channel.h | 46

[Qemu-devel] [PATCH 11/15] ui: convert the SDL2 frontend to keycodemapdb

2017-08-10 Thread Daniel P. Berrange
The SDL2 scancodes are conveniently identical to the USB scancodes. Replace the sdl2_scancode_to_qcode table with an automatically generated table. Missing entries in sdl2_scancode_to_qcode now fixed: - 0x32 -> Q_KEY_CODE_BACKSLASH - 0x66 -> Q_KEY_CODE_POWER - 0x67 -> Q_KEY_CODE_KP_EQUALS

[Qemu-devel] [PATCH 01/15] ui: add keycodemapdb repository as a GIT submodule

2017-08-10 Thread Daniel P. Berrange
The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a data file mapping between all the different scancode/keycode/keysym sets that are known, and a tool to auto-generate lookup tables for different combinations. It is used by GTK-VNC, SPICE-GTK and libvirt for mapping keys. Using it in

[Qemu-devel] [PATCH 06/15] input: convert virtio-input-hid device to keycodemapdb

2017-08-10 Thread Daniel P. Berrange
Replace the keymap_qcode table with automatically generated tables. Missing entries in keymap_qcode now fixed: Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK Q_KEY_CODE_STOP -> KEY_STOP Q_KEY_CODE_AGAIN -> KEY_AGAIN Q_KEY_CODE_PROPS -> KEY_PROPS

[Qemu-devel] [PATCH 3/8] blockdev: convert internal NBD server to QIONetListener

2017-08-10 Thread Daniel P. Berrange
Instead of creating a QIOChannelSocket directly for the NBD server socket, use a QIONetListener. This provides the ability to listen on multiple sockets at the same time, so enables full support for IPv4/IPv6 dual stack. Signed-off-by: Daniel P. Berrange --- blockdev-nbd.c

Re: [Qemu-devel] [PATCH v4 5/7] block: add throttle block filter driver

2017-08-10 Thread Alberto Garcia
On Wed 09 Aug 2017 12:07:32 PM CEST, Manos Pitsidianakis wrote: > +/* Extract ThrottleConfig options. Assumes cfg is initialized and will be > + * checked for validity. > + * > + * Returns -1 and sets errp if a burst_length value is over UINT_MAX. > + */ > +static int

Re: [Qemu-devel] [PATCH] error: Improve documentation of error_append_hint()

2017-08-10 Thread Eric Blake
On 08/10/2017 05:06 AM, Markus Armbruster wrote: > Suggested-by: Halil Pasic > Signed-off-by: Markus Armbruster > --- > include/qapi/error.h | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Eric Blake -- Eric Blake,

Re: [Qemu-devel] [PATCH v6 03/19] migration: Add comments to channel functions

2017-08-10 Thread Daniel P. Berrange
On Tue, Aug 08, 2017 at 06:26:13PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/channel.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/migration/channel.c b/migration/channel.c > index edceebd..79b0f8b 100644 >

[Qemu-devel] [PATCH 0/8] Enable full IPv4/IPv6 dual stack support

2017-08-10 Thread Daniel P. Berrange
Currently all the network listeners in QEMU, except the VNC server, are restricted to listening on a single socket. This makes it impossible to fully support IPv4/IPv6 dual stack. We're restricted to using IPV6_V6ONLY=0 to listen on both protocols from a single socket, but this doesn't work at all

Re: [Qemu-devel] [PULL v2 6/7] exec: allow to get a pointer for some mmio memory region

2017-08-10 Thread KONRAD Frederic
On 08/10/2017 02:59 PM, Paolo Bonzini wrote: On 10/08/2017 14:56, Peter Maydell wrote: +qemu_mutex_lock_iothread(); + +/* Reset dirty so this doesn't happen later. */ +cpu_physical_memory_test_and_clear_dirty(offset, size, 1); + +if (section.mr != mr) { +/*

[Qemu-devel] Odd character rendering/refresh behaviour?

2017-08-10 Thread Dr. David Alan Gilbert
I'm seeing something odd with character rendering and I can't quite put my finger on it. Generally I'm booting a Fedora26 guest and I'm seeing as I type the characters appear in sections, and you see the rest of the character appear shortly after (i.e. parts of each character, not obviously

[Qemu-devel] [Bug 1709784] Re: KVM on 16.04.3 throws an error

2017-08-10 Thread Andrew Cloke
** Also affects: qemu Importance: Undecided Status: New ** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** No longer affects: qemu ** Changed in: ubuntu-power-systems Assignee: (unassigned) => Canonical Server Team (canonical-server) -- You received

Re: [Qemu-devel] [PATCH v6 04/19] migration: Create migration_has_all_channels

2017-08-10 Thread Daniel P. Berrange
On Tue, Aug 08, 2017 at 06:26:14PM +0200, Juan Quintela wrote: > This functions allows us to decide when to close the listener socket. > For now, we only need one connection. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 11 +++ >

[Qemu-devel] [PATCH 03/15] ui: convert key events to QKeyCodes immediately

2017-08-10 Thread Daniel P. Berrange
Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. Signed-off-by: Daniel P. Berrange --- ui/input.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/input.c b/ui/input.c index

[Qemu-devel] [PULL] 9pfs fixes for 2.10 20170810

2017-08-10 Thread Greg Kurz
The following changes since commit b38df311c174c98ef8cce7dec9f46603b083018e: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.10-20170809' into staging (2017-08-10 11:12:36 +0100) are available in the git repository at: https://github.com/gkurz/qemu.git tags/for-upstream for

[Qemu-devel] [PATCH 5/8] migration: convert socket server to QIONetListener

2017-08-10 Thread Daniel P. Berrange
Instead of creating a QIOChannelSocket directly for the migration server socket, use a QIONetListener. This provides the ability to listen on multiple sockets at the same time, so enables full support for IPv4/IPv6 dual stack. Signed-off-by: Daniel P. Berrange ---

[Qemu-devel] [PATCH 2/8] io: introduce a network socket listener API

2017-08-10 Thread Daniel P. Berrange
The existing QIOChannelSocket class provides the ability to listen on a single socket at a time. This patch introduces a QIONetListener class that provides a higher level API concept around listening for network services, allowing for listening on multiple sockets. Signed-off-by: Daniel P.

[Qemu-devel] [PATCH v2 for-2.11 2/2] tests/pxe: Check virtio-net-ccw on s390x

2017-08-10 Thread Thomas Huth
Now that we've got a firmware that can do TFTP booting on s390x (i.e. the pc-bios/s390-netboot.img), we can enable the PXE tester for this architecture, too. Signed-off-by: Thomas Huth --- tests/Makefile.include | 1 + tests/boot-sector.c| 20

[Qemu-devel] [PATCH v2 for-2.11 0/2] Improvements for the pxe tester

2017-08-10 Thread Thomas Huth
The first patch improves the buffer handling in the pxe tester a little bit by allocating a separate buffer on the heap for each architecture. This also gets rid of the huge pre-initialized array in the tester, shrinking the size of the executable by half of a megabyte! The second patch adds s390x

[Qemu-devel] [PATCH v2 for-2.11 1/2] tests/boot-sector: Do not overwrite the x86 buffer on other architectures

2017-08-10 Thread Thomas Huth
Re-using the boot_sector code buffer from x86 for other architectures is not very nice, especially if we add more architectures later. It's also ugly that the test uses a huge pre-initialized array at all - the size of the executable is very huge due to this array. So let's use a separate buffer

Re: [Qemu-devel] [PATCH v5 17/17] migration: Flush receive queue

2017-08-10 Thread Peter Xu
On Tue, Aug 08, 2017 at 01:40:58PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jul 17, 2017 at 03:42:38PM +0200, Juan Quintela wrote: > >> Each time that we sync the bitmap, it is a possiblity that we receive > >> a page that is being processed by a different

Re: [Qemu-devel] [PATCH v3] 9pfs: fix dependencies

2017-08-10 Thread Cornelia Huck
On Wed, 9 Aug 2017 18:53:11 +0200 Greg Kurz wrote: > On Wed, 9 Aug 2017 18:30:19 +0200 > Cornelia Huck wrote: > > > Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > > on CONFIG_VIRTFS and CONFIG_VIRTIO/CONFIG_XEN only. > > > >

Re: [Qemu-devel] [PATCH v4 14/22] libqtest: Separate qmp_discard_response() from command

2017-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/09/2017 10:15 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Upcoming patches will be adding new convenience methods for >>> constructing QMP commands. But making every variation of sending >>> support every variation

[Qemu-devel] [PATCH] block/qcow2-snapshot: Fix a null pointer dereference in qcow2_free_snapshots

2017-08-10 Thread Hu Chaojian
From: chaojianhu In function qcow2_do_open, if "go fail;" before calling qcow2_read_snapshots, then snapshots will always be NULL. When dealing with "fail:", qcow2_free_snapshots will be called, and s->snapshots will be dereferenced without checked. Reported-by:

Re: [Qemu-devel] [PATCH v8 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-08-10 Thread Stefan Hajnoczi
On Thu, Jul 27, 2017 at 3:33 PM, Ashijeet Acharya wrote: > Previously posted series patches: > v1 - http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg02044.html > v2 - http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg05080.html > v3 -

[Qemu-devel] [PATCH] qemu-iothread: IOThread supports the GMainContext event loop

2017-08-10 Thread Wang yong
From: Wang Yong IOThread uses AioContext event loop and does not run a GMainContext. Therefore,chardev cannot work in IOThread,such as the chardev is used for colo-compare packets reception. This patch makes the IOThread run the GMainContext event loop, chardev and

Re: [Qemu-devel] [PATCH v4 19/22] libqtest: Add qmp_args_dict() helper

2017-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/09/2017 10:59 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Leaving interpolation into JSON to qobject_from_jsonf() is more >>> robust than building QMP input manually; however, we have a few >>> places where code is

Re: [Qemu-devel] [PATCH v8 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-08-10 Thread Ashijeet Acharya
On Thu, Aug 10, 2017 at 1:41 PM, Stefan Hajnoczi wrote: > On Thu, Jul 27, 2017 at 3:33 PM, Ashijeet Acharya > wrote: > > Previously posted series patches: > > v1 - http://lists.nongnu.org/archive/html/qemu-devel/2017- > 03/msg02044.html > > v2 -

Re: [Qemu-devel] [PATCH for-2.10 2/2] xilinx-spips: add a migration blocker when using mmio_execution

2017-08-10 Thread Peter Maydell
On 1 August 2017 at 10:41, Peter Maydell wrote: > On 1 August 2017 at 10:35, KONRAD Frederic > wrote: >> >> >> On 08/01/2017 11:30 AM, Edgar E. Iglesias wrote: >>> At this stage, perhaps we should just register the blocker when this dev >>>

Re: [Qemu-devel] [PATCH 09/12] qemu-iotests: do not search for binaries in the current directory

2017-08-10 Thread Markus Armbruster
Paolo Bonzini writes: > Looking in the build root is enough. > > Signed-off-by: Paolo Bonzini It's actually *better*. I hate it when tests pick up random garbage I have lying around.

[Qemu-devel] 答复: Re: [PATCH] qemu-iothread: IOThread supports the GMainContext eventloop

2017-08-10 Thread wang.yong155
>Nice. Just a note, I think an iothread should have its own (optional) >GMainContext accessed with iothread_get_g_main_context(iothread). When >you call it for the first time, the iothread: > >1) creates a GMainContext > >2) adds the AioContext as a GSource in the GMainContext > >3) asks

Re: [Qemu-devel] [qemu-web PATCH v2] Add a blog post about deprecation of old interfaces and features

2017-08-10 Thread Paolo Bonzini
On 10/08/2017 11:23, Daniel P. Berrange wrote: > On Thu, Aug 10, 2017 at 10:46:30AM +0200, Thomas Huth wrote: >> Now that we've got a list of deprecated interfaces/features in the QEMU >> documentation, it is time to draw some more public attention to our plans >> of removing certain

Re: [Qemu-devel] [PATCH v2 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2017-08-10 Thread Paolo Bonzini
On 09/08/2017 19:10, Michael S. Tsirkin wrote: > So user specifies properties and > they get sent to backend at init time. Only handle geometry changes > specially. So QEMU would get the configuration, set these properties, and send the result to the backend via SET_CONFIG?

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

2017-08-10 Thread Peter Maydell
On 9 August 2017 at 22:30, Philippe Mathieu-Daudé wrote: > I wonder if I'm understanding correctly what the MAINTAINERS file is for and > how to use it. > > From an submitter view I feel a bit confused. I thought ./get_maintainer.pl > would give me the list of person to email the

Re: [Qemu-devel] 答复: Re: [PATCH] qemu-iothread: IOThread supports the GMainContext eventloop

2017-08-10 Thread Paolo Bonzini
On 10/08/2017 11:17, wang.yong...@zte.com.cn wrote: >> Nice. Just a note, I think an iothread should have its own (optional) > >> GMainContext accessed with iothread_get_g_main_context(iothread). When > >> you call it for the first time, the iothread: > >> > >> 1) creates a GMainContext >

Re: [Qemu-devel] [PATCH v4 15/22] libqtest: Delete qtest_qmp() wrappers

2017-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/09/2017 10:34 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> None of our tests were directly using qtest_qmp() and friends; >>> even tests like postcopy-test.c that manage multiple connections >>> get along just fine

[Qemu-devel] [PATCH for-2.10] qemu-doc: Mention host_net_add/-remove in the deprecation chapter

2017-08-10 Thread Thomas Huth
The two HMP commands host_net_add and -remove have recently been marked as deprecated, too, so we should now mention them in the chapter of deprecated features. Signed-off-by: Thomas Huth --- qemu-doc.texi | 8 1 file changed, 8 insertions(+) diff --git

[Qemu-devel] [PATCH v2 for-2.10] qemu-doc: Mention host_net_add/-remove in the deprecation chapter

2017-08-10 Thread Thomas Huth
The two HMP commands host_net_add and -remove have recently been marked as deprecated, too, so we should now mention them in the chapter of deprecated features. Signed-off-by: Thomas Huth --- qemu-doc.texi | 8 1 file changed, 8 insertions(+) diff --git

[Qemu-devel] [PATCH] file-posix: Clear out first sector in hdev_create

2017-08-10 Thread Fam Zheng
People get surprised when, after "qemu-imc create -f raw /dev/sdX", they still see qcow2 with "qemu-img info", if previously the bdev had a qcow2 header. While this is natural because raw doesn't need to write any magic bytes during creation, hdev_create is free to clear out the first sector to

Re: [Qemu-devel] [RFC PATCH 01/56] qobject: Touch up comments to say @param instead of 'param'

2017-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/07/2017 09:45 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> qobject/qdict.c | 68 >> - >> qobject/qlist.c | 2 +- >> 2 files changed, 35

Re: [Qemu-devel] [PATCH v2 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support

2017-08-10 Thread Paolo Bonzini
On 09/08/2017 22:51, Lan Tianyu wrote: > This patchset is to deal with MSI interrupt remapping request when guest > updates MSI registers. > > Chao Gao (3): > i386/msi: Correct mask of destination ID in MSI address > xen-pt: bind/unbind interrupt remapping format MSI > msi: Handle

Re: [Qemu-devel] [qemu-web PATCH v2] Add a blog post about deprecation of old interfaces and features

2017-08-10 Thread Paolo Bonzini
On 10/08/2017 10:46, Thomas Huth wrote: > Now that we've got a list of deprecated interfaces/features in the QEMU > documentation, it is time to draw some more public attention to our plans > of removing certain interfaces/features in future releases. > > Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

2017-08-10 Thread Paolo Bonzini
On 10/08/2017 11:35, Peter Maydell wrote: >> actual default for un-matched: "recent contributors" + qemu-devel@ >> >> $ ./scripts/get_maintainer.pl -f disas.c >> get_maintainer.pl: No maintainers found, printing recent contributors. >> get_maintainer.pl: Do not blindly cc: them on patches!

Re: [Qemu-devel] [PATCH v2 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support

2017-08-10 Thread Lan Tianyu
On 2017年08月10日 17:04, Paolo Bonzini wrote: > On 09/08/2017 22:51, Lan Tianyu wrote: >> This patchset is to deal with MSI interrupt remapping request when guest >> updates MSI registers. >> >> Chao Gao (3): >> i386/msi: Correct mask of destination ID in MSI address >> xen-pt: bind/unbind

Re: [Qemu-devel] [Qemu-block] [PATCH 01/12] qemu-iotests: remove dead code

2017-08-10 Thread Paolo Bonzini
On 10/08/2017 00:18, Eric Blake wrote: > On 08/09/2017 04:54 PM, Paolo Bonzini wrote: >> This includes shell function, shell variables, command line options >> (randomize.awk does not exist) and conditions that can never be true >> (./qemu does not exist anymore). > > Can we point to a commit id

Re: [Qemu-devel] No video for Windows 2000 guest

2017-08-10 Thread Michael Tokarev
10.08.2017 06:51, Thomas Huth wrote: [] > I guess you'll end up with QEMU 2.1 as good version and 2.2 as the first > "bad" version. According the qemu-doc: > > -vga type > > Select type of VGA card to emulate. Valid values for type are > > cirrus > > Cirrus Logic GD5446 Video

Re: [Qemu-devel] [PATCH v4 17/22] libqtest: Add qmp_args() helper

2017-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/09/2017 10:57 AM, Markus Armbruster wrote: > >> I don't like the qmp_args name. It's not about arguments, it's about >> sending a command with arguments. >> >> I'm afraid I'm getting pretty thorougly confused by the evolving >> interface. So I

Re: [Qemu-devel] [PATCH 2/2] file-posix: Do runtime check for ofd lock API

2017-08-10 Thread Christian Ehrhardt
On Fri, Jul 21, 2017 at 2:36 PM, Eric Blake wrote: > On 07/21/2017 05:20 AM, Fam Zheng wrote: > > It is reported that on Windows Subsystem for Linux, ofd operations fail > > with -EINVAL. In other words, QEMU binary built with system headers that > > exports F_OFD_SETLK

Re: [Qemu-devel] make check-help not working

2017-08-10 Thread Fam Zheng
On Fri, 07/28 20:56, Philippe Mathieu-Daudé wrote: > I'm a bit lost with this error: > > (master)$ make check-help V=1 > cc -nostdlib -o check-help.mo > cc: fatal error: no input files > compilation terminated. > rules.mak:115: recipe for target 'check-help.mo' failed > make: *** [check-help.mo]

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

2017-08-10 Thread Cornelia Huck
On Wed, 9 Aug 2017 18:30:25 -0300 Philippe Mathieu-Daudé wrote: > [I added mails of other person who reply to this series, this mail is > not directly addressed to Alex] Hey, a maintainership discussion! I don't think we had one before 8) > > On 08/09/2017 11:38 AM, Alex

[Qemu-devel] [qemu-web PATCH v2] Add a blog post about deprecation of old interfaces and features

2017-08-10 Thread Thomas Huth
Now that we've got a list of deprecated interfaces/features in the QEMU documentation, it is time to draw some more public attention to our plans of removing certain interfaces/features in future releases. Signed-off-by: Thomas Huth --- v2: Use a link to the qemu-doc instead

[Qemu-devel] [PATCH] Makefile: Let "make check-help" work without running ./configure

2017-08-10 Thread Fam Zheng
Currently if you do "make check-help" in a fresh checkout, only an error is printed which is not nice: $ make check-help V=1 cc -nostdlib -o check-help.mo cc: fatal error: no input files compilation terminated. rules.mak:115: recipe for target 'check-help.mo' failed make:

Re: [Qemu-devel] [PATCH v2 for-2.10] qemu-doc: Mention host_net_add/-remove in the deprecation chapter

2017-08-10 Thread Paolo Bonzini
On 10/08/2017 10:00, Thomas Huth wrote: > The two HMP commands host_net_add and -remove have recently been > marked as deprecated, too, so we should now mention them in the > chapter of deprecated features. > > Signed-off-by: Thomas Huth > --- > qemu-doc.texi | 8 > 1

Re: [Qemu-devel] [PATCH] qemu-iothread: IOThread supports the GMainContext event loop

2017-08-10 Thread Fam Zheng
On Fri, 08/11 08:29, Wang yong wrote: > From: Wang Yong > > IOThread uses AioContext event loop and does not run a GMainContext. > Therefore,chardev cannot work in IOThread,such as the chardev is > used for colo-compare packets reception. > > This patch makes the

Re: [Qemu-devel] [PATCH 08/12] qemu-iotests: fix uninitialized variable

2017-08-10 Thread Markus Armbruster
Drive-by comment: Paolo Bonzini writes: > The function is used in "common" but defined only after the file "This variable" > is sourced. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH for-2.10 2/2] xilinx-spips: add a migration blocker when using mmio_execution

2017-08-10 Thread Edgar E. Iglesias
On Thu, Aug 10, 2017 at 10:11:13AM +0100, Peter Maydell wrote: > On 1 August 2017 at 10:41, Peter Maydell wrote: > > On 1 August 2017 at 10:35, KONRAD Frederic > > wrote: > >> > >> > >> On 08/01/2017 11:30 AM, Edgar E. Iglesias wrote: > >>>

Re: [Qemu-devel] [PATCH for-2.10 2/2] xilinx-spips: add a migration blocker when using mmio_execution

2017-08-10 Thread KONRAD Frederic
On 08/10/2017 11:22 AM, Edgar E. Iglesias wrote: On Thu, Aug 10, 2017 at 10:11:13AM +0100, Peter Maydell wrote: On 1 August 2017 at 10:41, Peter Maydell wrote: On 1 August 2017 at 10:35, KONRAD Frederic wrote: On 08/01/2017 11:30

Re: [Qemu-devel] [PATCH v4 13/22] libqtest: Add qmp_raw()

2017-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/09/2017 09:54 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> The majority of calls into libqtest's qmp() and friends are passing >>> a JSON object that includes a command name; we can prove this by >>> adding an

Re: [Qemu-devel] [PATCH for-2.10] qemu-doc: Mention host_net_add/-remove in the deprecation chapter

2017-08-10 Thread Thomas Huth
On 10.08.2017 09:48, Thomas Huth wrote: > The two HMP commands host_net_add and -remove have recently been > marked as deprecated, too, so we should now mention them in the > chapter of deprecated features. > > Signed-off-by: Thomas Huth > --- > qemu-doc.texi | 8 > 1

Re: [Qemu-devel] [PATCH] qemu-iothread: IOThread supports the GMainContext event loop

2017-08-10 Thread Paolo Bonzini
- Original Message - > From: "Wang yong" > To: pbonz...@redhat.com, stefa...@redhat.com, f...@redhat.com, > jasow...@redhat.com > Cc: "wang yong155" , "wang guang55" > , "zhangchen fnst" >

Re: [Qemu-devel] [RFC 23/29] vub+postcopy: madvises

2017-08-10 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > On 08/08/2017 08:06 PM, Dr. David Alan Gilbert wrote: > > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > > On 06/28/2017 10:00 PM, Dr. David Alan Gilbert (git) wrote: > > > > From: "Dr. David Alan Gilbert" > > > >

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

2017-08-10 Thread Peter Maydell
On 10 August 2017 at 09:46, Cornelia Huck wrote: > The root problem is "some files have no maintainers". The reasons range > from "forgot to include the file in the pattern" (easily fixed), over > "file is updated via a script" (the linux-headers case), to "nobody > feels up to

Re: [Qemu-devel] [qemu-web PATCH v2] Add a blog post about deprecation of old interfaces and features

2017-08-10 Thread Daniel P. Berrange
On Thu, Aug 10, 2017 at 10:46:30AM +0200, Thomas Huth wrote: > Now that we've got a list of deprecated interfaces/features in the QEMU > documentation, it is time to draw some more public attention to our plans > of removing certain interfaces/features in future releases. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] target/i386: fix packusdw in-place operation

2017-08-10 Thread Paolo Bonzini
On 10/08/2017 02:24, Joseph Myers wrote: > The SSE4.1 packusdw instruction combines source and destination > vectors of signed 32-bit integers into a single vector of unsigned > 16-bit integers, with unsigned saturation. When the source and > destination are the same register, this means each

Re: [Qemu-devel] [PATCH 0/2] IDE: Do not flush empty drives

2017-08-10 Thread Stefan Hajnoczi
On Wed, Aug 09, 2017 at 05:02:10PM +0100, Stefan Hajnoczi wrote: > John Snow is offline until Monday, QEMU 2.10-rc3 is due to be tagged on > Tuesday, and so I've taken two patches John sent for 2.10 and addressed review > comments. > > Kevin Wolf (1): > IDE: test flush on empty CDROM > >

Re: [Qemu-devel] [PATCH] x86: Increase max vcpu number to 352

2017-08-10 Thread Daniel P. Berrange
On Thu, Aug 10, 2017 at 02:13:30PM +0200, Paolo Bonzini wrote: > On 10/08/2017 12:08, Lan Tianyu wrote: > > Intel Xeon phi chip will support 352 logical threads. For HPC > > usage case, it will create a huge VM with vcpus number as same as host > > cpus. This patch is to increase max vcpu number

Re: [Qemu-devel] [PATCH] qemu-doc: Fix "-net van" typo

2017-08-10 Thread Eric Blake
On 08/10/2017 06:44 AM, Thomas Huth wrote: > While Andrew S. Tanenbaum has a point by saying "Never underestimate the > bandwidth of a station wagon full of tapes hurtling down the highway", > we don't support that way of transportation in QEMU yet, so replace the > typo with the correct word

Re: [Qemu-devel] [PATCH v6 04/19] migration: Create migration_has_all_channels

2017-08-10 Thread Eric Blake
On 08/08/2017 11:26 AM, Juan Quintela wrote: > This functions allows us to decide when to close the listener socket. s/functions/function/ > For now, we only need one connection. > > Signed-off-by: Juan Quintela > --- -- Eric Blake, Principal Software Engineer Red Hat,

Re: [Qemu-devel] [for-2.10 PATCH v4] 9pfs: local: fix fchmodat_nofollow() limitations

2017-08-10 Thread Zhi Yong Wu
Tested-by: Zhi Yong Wu Regards, Zhi Yong Wu At 2017-08-10 00:40:57, "Greg Kurz" wrote: >This function has to ensure it doesn't follow a symlink that could be used >to escape the virtfs directory. This could be easily achieved if fchmodat() >on linux

[Qemu-devel] [PATCH 12/15] ui: convert GTK and SDL1 frontends to keycodemapdb

2017-08-10 Thread Daniel P. Berrange
The x_keycode_to_pc_keycode and evdev_keycode_to_pc_keycode tables are replaced with automatically generated tables. In addition the X11 heuristics are improved to detect running on XQuartz and XWin X11 servers, to activate the correct OS-X and Win32 keycode maps. Signed-off-by: Daniel P.

[Qemu-devel] [PATCH 08/15] input: convert the adb device to keycodemapdb

2017-08-10 Thread Daniel P. Berrange
Replace the qcode_to_adb_keycode table with automatically generated tables. Missing entries in qcode_to_adb_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x47 Signed-off-by: Daniel P. Berrange --- hw/input/adb.c | 124 +-

Re: [Qemu-devel] [PATCH 0/8] Enable full IPv4/IPv6 dual stack support

2017-08-10 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170810160451.32723-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH 0/8] Enable full IPv4/IPv6 dual stack

[Qemu-devel] [PATCH 2/2] backup: QEMU Backup Tool

2017-08-10 Thread Ishani Chugh
qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. The tool writes details of guest in a configuration file and the

Re: [Qemu-devel] [PULL] 9pfs fixes for 2.10 20170810

2017-08-10 Thread Peter Maydell
On 10 August 2017 at 17:02, Greg Kurz wrote: > The following changes since commit b38df311c174c98ef8cce7dec9f46603b083018e: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.10-20170809' > into staging (2017-08-10 11:12:36 +0100) > > are available in the git

[Qemu-devel] [PULL for-2.10 1/3] IDE: Do not flush empty CDROM drives

2017-08-10 Thread Stefan Hajnoczi
The block backend changed in a way that flushing empty CDROM drives now crashes. Amend IDE to avoid doing so until the root problem can be addressed for 2.11. Original patch by John Snow . Reported-by: Kieron Shorrock Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb

2017-08-10 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb Type: series Message-id: 20170810155522.31099-1-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under

[Qemu-devel] [PATCH 4/8] blockdev: convert qemu-nbd server to QIONetListener

2017-08-10 Thread Daniel P. Berrange
Instead of creating a QIOChannelSocket directly for the NBD server socket, use a QIONetListener. This provides the ability to listen on multiple sockets at the same time, so enables full support for IPv4/IPv6 dual stack. Signed-off-by: Daniel P. Berrange --- qemu-nbd.c | 50

Re: [Qemu-devel] [PATCH 1/2] vl: Factor object_create() out of main()

2017-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/10/2017 07:25 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> vl.c | 21 ++--- >> 1 file changed, 10 insertions(+), 11 deletions(-) >> > >> +++ b/vl.c >> @@ -2845,7 +2845,6 @@ static

Re: [Qemu-devel] [PATCH 2/2] vl: Partial support for non-scalar properties with -object

2017-08-10 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/08/2017 14:25, Markus Armbruster wrote: >> We've wanted -object to support non-scalar properties for a while. >> Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based >> authorization API". Review led to the conclusion that we need to >>

Re: [Qemu-devel] [PATCH v8 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-08-10 Thread Stefan Hajnoczi
On Thu, Aug 10, 2017 at 9:18 AM, Ashijeet Acharya wrote: > On Thu, Aug 10, 2017 at 1:41 PM, Stefan Hajnoczi wrote: >> >> On Thu, Jul 27, 2017 at 3:33 PM, Ashijeet Acharya >> wrote: >> > Previously posted series patches:

[Qemu-devel] [PULL for-2.10 2/3] IDE: test flush on empty CDROM

2017-08-10 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: John Snow Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi Message-id: 20170809160212.29976-3-stefa...@redhat.com Signed-off-by:

[Qemu-devel] [PATCH 8/8] sockets: fix parsing of ipv4/ipv6 opts in parse_socket_addr

2017-08-10 Thread Daniel P. Berrange
The inet_parse() function looks for 'ipv4' and 'ipv6' flags, but only treats them as bare bool flags. The normal QemuOpts parsing would allow on/off values to be set too. This updated inet_parse() so that its handling of the 'ipv4' and 'ipv6' flags matches that done by QemuOpts. Signed-off-by:

Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb

2017-08-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170810155522.31099-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

  1   2   >