[Qemu-devel] [RFC 15/15] qmp: let migrate-incoming allow out-of-band

So it can get rid of being run on main thread. Signed-off-by: Peter Xu --- qapi/migration.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index ee2b3b8..dedc4f8 100644 --- a/qapi/migration.json +++

[Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

Having "allow-oob" to true for a command does not mean that this command will always be run in out-of-band mode. The out-of-band quick path will only be executed if we specify the extra "run-oob" flag when sending the QMP request: { "execute": "command-that-allows-oob", "arguments": { ...

Re: [Qemu-devel] [PATCH 2/2] Add --firmwarepath to configure

Hi, > > +  --firmwarepath=PATH  search PATH for firmware files > > Maybe --firmwaredir or --with-firmwaredir (because firmwaredir is not > one of the "standard" directories)? I've intentionally named this "path" because it can actually have multiple directories. Or do you mean something

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback

Hi Eric, On Fri Sep 01, 2017 at 07:21:16PM +0200, Eric Auger wrote: > memory_region_iommu_replay() is used for VFIO integration. > > However its default implementation is not adapted to SMMUv3 > IOMMU memory region. Indeed the input address range is too > huge and its execution is too slow as it

Re: [Qemu-devel] [PATCH v7 0/3] hmp, qmp: 'info memory_size_summary', 'query-memory-size-summary', 'info numa' updates

On Thu, 14 Sep 2017 11:35:36 +0200 Vadim Galitsyn wrote: > Hi Guys, > > Could you please let me know if you have an update on this topic? Series looks good to me. so with comments I've made fixed up Reviewed-by: Igor Mammedov > > Thank

Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

On Thu, Sep 14, 2017 at 12:36:03PM +0200, Thomas Huth wrote: > libseccomp supports s390x since version 2.3.0, and I was able to start > a VM with "-sandbox on" without any obvious problems by using this patch, > so it should be safe to allow --enable-seccomp on s390x nowadays, too. > I don't

Re: [Qemu-devel] [PATCH for-2.9?] configure: Remove unused code (found by shellcheck)

16.08.2017 15:57, Stefan Weil пишет: > It looks like this patch got lost somehow. > > Stefan > > See also https://patchwork.codeaurora.org/patch/210129/ > > > Am 28.03.2017 um 20:49 schrieb Stefan Weil: >> smartcard_cflags is no longer needed since commit >>

Re: [Qemu-devel] [PATCH] filter-mirror: segfault when specifying non existent device

21.08.2017 18:50, Eduardo Otubo wrote: > When using filter-mirror like the example below where the interface > 'ndev0' does not exist on the host, QEMU crashes into segmentation > fault. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v2 5/5] arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly

On Thu, 14 Sep 2017 00:47:20 -0300 Philippe Mathieu-Daudé wrote: > Hi Igor, > > awesome clean refactor! Thanks, there is more patches on this topic for other targets to post but it's waiting on 1-3/5 to land in master so it would be easier for maintainers to verify/test them

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3 00/15] add missing entries in MAINTAINERS

08.09.2017 20:31, Philippe Mathieu-Daudé wrote: > Hi, > > I tried to have a more helpful ./scripts/get_maintainer.pl output, filling > missing entries in MAINTAINERS. Applied all to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH for-2.11] aux-to-i2c-bridge: don't allow user to create one

25.08.2017 14:46, KONRAD Frederic wrote: > This device is private and is created once per aux-bus. > So don't allow the user to create one from command-line. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] osdep: Fix ROUND_UP(64-bit, 32-bit)

On 09/13/17 23:03, Eric Blake wrote: > When using bit-wise operations that exploit the power-of-two > nature of the second argument of ROUND_UP(), we still need to > ensure that the mask is as wide as the first argument (done > by using addition of 0 to force proper arithmetic promotion). >

[Qemu-devel] question：a question about throttle and hot-unplug

Hi, Kevin the patch you commited: https://github.com/qemu/qemu/commit/7ca7f0f6db1fedd28d490795d778cf23979a2aa7#diff-ea36ba0f79150cc299732696a069caba remove blk_io_limits_disable from blk_remove_bs Then, if a disk which configured qos hot-unplug from VM, the backend of the disk reminds in

Re: [Qemu-devel] [PATCH v4 0/4] hmp: fix "dump-quest-memory" segfault

* Laurent Vivier (lviv...@redhat.com) wrote: > Fix aarch64 and ppc when dump-guest-memory is > used with none machine type and no CPU. > > The other machine types don't have the problem. > > Update test-hmp, to test none machine type > with (2 MB) and without memory, and add a test > to test

Re: [Qemu-devel] [PATCH v7 2/3] qmp: introduce query-memory-size-summary command

On Tue, 29 Aug 2017 17:30:21 +0200 Vadim Galitsyn wrote: > Add a new query-memory-size-summary command which provides the > following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option -m. > > *

[Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

If the host has both KVM PR and KVM HV loaded and we pass: -machine pseries,accel=kvm,kvm-type=PR the kvmppc_is_pr() returns false instead of true. Since the helper is mostly used as fallback, it doesn't have any real impact with recent kernels. A notable exception is the workaround to

[Qemu-devel] [PATCH 1/1] virtio-ccw: remove stale comments on endiannes

We have two stale comments suggesting one should think about virtio config space endiannes a bit longer. We have just done that, and came to the conclusion we are fine as is: it's the responsibility of the virtio device and not of the transport (and that is how it works now). Putting the

Re: [Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

On 14.09.2017 12:48, Greg Kurz wrote: > If the host has both KVM PR and KVM HV loaded and we pass: > > -machine pseries,accel=kvm,kvm-type=PR > > the kvmppc_is_pr() returns false instead of true. Since the helper > is mostly used as fallback, it doesn't have any real impact with > recent

Re: [Qemu-devel] [PATCH 1/1] virtio-ccw: remove stale comments on endiannes

On Thu, 14 Sep 2017 12:55:35 +0200 Halil Pasic wrote: > We have two stale comments suggesting one should think about virtio > config space endiannes a bit longer. We have just done that, and came to > the conclusion we are fine as is: it's the responsibility of the

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] Replace round_page() with TARGET_PAGE_ALIGN()

11.09.2017 23:16, Kamil Rytarowski пишет: > This change fixes conflict with the DragonFly BSD headers. Applied to -trivial, thanks! /mjt

[Qemu-devel] [RFC 05/15] qjson: add "opaque" field to JSONMessageParser

It'll be passed to emit() as well when it happens. Signed-off-by: Peter Xu --- include/qapi/qmp/json-streamer.h | 8 ++-- monitor.c| 7 --- qga/main.c | 5 +++-- qobject/json-streamer.c | 7 +--

[Qemu-devel] [RFC 10/15] monitor: introduce monitor_qmp_respond()

A tiny refactoring, preparing to split the QMP dispatcher away. Signed-off-by: Peter Xu --- monitor.c | 48 +++- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git a/monitor.c b/monitor.c index 83f5e87..aa0c384 100644 ---

Re: [Qemu-devel] [PATCH] tests/libqtest: Use a proper error message if QTEST_QEMU_BINARY is missing

28.08.2017 13:35, Thomas Huth weote: > The user can currently still cause an abort() if running certain tests > (like the prom-env-test) without setting the QTEST_QEMU_BINARY first. > A similar problem has been fixed with commit 7c933ad61b8f3f51337 > already, but forgot to also take care of the

Re: [Qemu-devel] [PATCH RESEND v7 0/3] Red Hat PCI bridge resource reserve capability

2017-09-10 22:40 GMT+03:00 Marcel Apfelbaum : > On 10/09/2017 21:34, Aleksandr Bezzubikov wrote: >> >> >> пт, 18 авг. 2017 г. в 2:33, Aleksandr Bezzubikov > >: >> >> >> Now PCI bridges get a bus range number on a system init,

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

On Wed, 13 Sep 2017 13:50:29 +0200 Halil Pasic wrote: > Let's add indirect data addressing support for our virtual channel > subsystem. This implementation does no bother with any kind of s/no/not/ > prefetching. We simply step trough the IDAL on demand.

Re: [Qemu-devel] [PATCH v7 0/3] hmp, qmp: 'info memory_size_summary', 'query-memory-size-summary', 'info numa' updates

Hi Guys, Could you please let me know if you have an update on this topic? Thank you, Vadim On Tue, Aug 29, 2017 at 5:30 PM, Vadim Galitsyn < vadim.galit...@profitbricks.com> wrote: > Hi Guys, > > Sorry for the delay. This is continuation of >

Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

On 9/14/2017 1:19 PM, Greg Kurz wrote: On Thu, 14 Sep 2017 06:40:06 -0400 Pradeep Jagadeesh wrote: This patch factors out code to use the ThrottleLimits strurcture. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Greg Kurz

Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on big endian systems

30.08.2017 16:39, Thomas Huth пишет: > The "slow" ivshmem-tests currently fail when they are running on a > big endian host: Applied to -trivial, thanks! /mjt

[Qemu-devel] [RFC 12/15] monitor: enable IO thread for (qmp & !mux) typed

Start to use dedicate IO thread for QMP monitors that are not using MUXed chardev. Signed-off-by: Peter Xu --- monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index f649d6a..599ea36 100644 --- a/monitor.c +++ b/monitor.c

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

On Thu, 14 Sep 2017 13:48:26 +0530 Bharata B Rao wrote: > On Thu, Sep 14, 2017 at 10:00:11AM +0200, Igor Mammedov wrote: > > On Thu, 14 Sep 2017 12:31:18 +0530 > > Bharata B Rao wrote: > > > > > Hi, > > > > > > QEMU hits the below

[Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

libseccomp supports s390x since version 2.3.0, and I was able to start a VM with "-sandbox on" without any obvious problems by using this patch, so it should be safe to allow --enable-seccomp on s390x nowadays, too. Signed-off-by: Thomas Huth --- configure | 2 +- 1 file

Re: [Qemu-devel] [PATCH v11 3/6] qmp: factor out throttle code to reuse code

On Thu, 14 Sep 2017 06:40:07 -0400 Pradeep Jagadeesh wrote: > This patch reuses the code to set throttle limits. > > Signed-off-by: Pradeep Jagadeesh > Reviewed-by: Alberto Garcia > Reviewed-by: Greg Kurz

[Qemu-devel] [RFC 13/15] qapi: introduce new cmd option "allow-oob"

Here "oob" stands for "Out-Of-Band". When "allow-oob" is set, it means the command allows out-of-band execution. Please see the spec update for more details. The "oob" idea is proposed by Markus Armbruster in following thread:

[Qemu-devel] [RFC 09/15] monitor: allow to use IO thread for parsing

For each Monitor, add one field "use_io_thr" to show whether it will be using the dedicated monitor IO thread to handle input/output. When set, monitor IO parsing work will be offloaded to dedicated monitor IO thread, rather than the original main loop thread. This only works for QMP. HMP will

Re: [Qemu-devel] [PATCH v7 3/3] hmp: introduce 'info memory_size_summary' command

On Tue, 29 Aug 2017 17:30:22 +0200 Vadim Galitsyn wrote: > Add 'info memory_size_summary' command which is a sibling > of QMP command query-memory-size-summary. It provides the > following memory information in bytes: > > * base-memory - size of "base" memory

[Qemu-devel] [PATCH v11 4/6] hmp: create a throttle initialization function for code reuse

This patch creates a throttle initialization function to maximize the code reusability. The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Alberto Garcia Reviewed-by: Greg Kurz Acked-by: Dr. David

Re: [Qemu-devel] [PATCH v2 0/4] add CCW indirect data access support

On 09/14/2017 11:15 AM, Cornelia Huck wrote: > On Wed, 13 Sep 2017 13:50:25 +0200 > Halil Pasic wrote: > >> Abstract >> >> >> The objective of this series is introducing CCW IDA (indirect data >> access) support to our virtual channel subsystem

Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

On Thu, 14 Sep 2017 06:40:06 -0400 Pradeep Jagadeesh wrote: > This patch factors out code to use the ThrottleLimits > strurcture. > > Signed-off-by: Pradeep Jagadeesh > Reviewed-by: Greg Kurz > Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v2 0/4] add CCW indirect data access support

On Thu, 14 Sep 2017 13:02:51 +0200 Halil Pasic wrote: > About the r-b's I think the guys in cc are the most likely > candidates. Pierre should be back starting next week. Dong > Jia I haven't seen in a while, but I don't know about anything. Let's see what comes in,

[Qemu-devel] [RFC 06/15] monitor: move the cur_mon hack deeper for QMP

In monitor_qmp_read(), we have the hack to temporarily replace the cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher routine since the Monitor pointer can be passed in to that using the new JSON Parser opaque field now. This does not make much sense as a single patch.

[Qemu-devel] [RFC 04/15] monitor: move skip_flush into monitor_data_init

It's part of the data init. Collect it. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- monitor.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 9239f7a..8b32519 100644 ---

[Qemu-devel] [RFC 02/15] qobject: allow NULL for qstring_get_str()

Then I can get NULL rather than crash when calling things like: qstring_get_str(qobject_to_qstring(object)); when key does not exist. CC: Markus Armbruster Signed-off-by: Peter Xu --- qobject/qstring.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH v2 1/4] s390x/css: introduce css data stream

On Wed, 13 Sep 2017 13:50:26 +0200 Halil Pasic wrote: > This is a preparation for introducing handling for indirect data > addressing and modified indirect data addressing (CCW). Here we introduce > an interface which should make the addressing scheme transparent for

Re: [Qemu-devel] [RFC v2 30/32] vhost: Merge neighbouring hugepage regions where appropriate

On Thu, 24 Aug 2017 20:27:28 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Where two regions are created with a gap such that when aligned > to hugepage boundaries, the two regions overlap, merge them. why only

Re: [Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent guest memory

* Laurent Vivier (lviv...@redhat.com) wrote: > On 13/09/2017 16:27, Cornelia Huck wrote: > > On Wed, 13 Sep 2017 16:20:35 +0200 > > Laurent Vivier wrote: > > > >> From: Cornelia Huck > >> > >> It does not really make sense to dump memory that is not there.

[Qemu-devel] [PATCH v11 5/6] fsdev: QMP interface for throttling

This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Dr. David Alan

[Qemu-devel] [PATCH v11 0/6] fsdev: qmp interface for io throttling

These patches provide the qmp interface, to query the io throttle status of the all fsdev devices that are present in a vm. also, it provides an interface to set the io throttle parameters of a fsdev to a required value. Some of the patches also remove the duplicate code that was present in block

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.11] tests: Fix broken ivshmem-server-msi/-irq tests

29.08.2017 21:13, Thomas Huth wrote: > Broken with commit b4ba67d9a7025 ("libqos: Change PCI accessors to take > opaque BAR handle") a while ago, but nobody noticed since the tests are > only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized > anymore if bir_pba has the same

[Qemu-devel] [RFC 11/15] monitor: separate QMP parser and dispatcher

Originally QMP is going throw these steps: JSON Parser --> QMP Dispatcher --> Respond /|\(2)(3) | (1) | \|/ (4) +- main thread + This patch does this: JSON Parser QMP Dispatcher --> Respond /|\

[Qemu-devel] [RFC 03/15] qobject: introduce qobject_to_str()

A quick way to fetch string from qobject when it's a QString. Signed-off-by: Peter Xu --- include/qapi/qmp/qstring.h | 1 + qobject/qstring.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/qapi/qmp/qstring.h b/include/qapi/qmp/qstring.h

[Qemu-devel] [RFC 08/15] monitor: create IO thread

Create one IO thread for the monitors, prepared to handle all the input/output IOs. Only adding the thread, loop and context, but doing nothing else yet. Signed-off-by: Peter Xu --- monitor.c | 49 + 1 file changed, 49

Re: [Qemu-devel] [PATCH v7 2/3] qmp: introduce query-memory-size-summary command

I think I made a typo here. It should be: +# @plugged-memory: size *of* memory that can be hot-unplugged. This field +# is omitted if target does *not* support memory hotplug +# (i.e. CONFIG_MEM_HOTPLUG not defined on build time). On Thu, Sep 14, 2017 at

[Qemu-devel] [PATCH v11 1/6] throttle: factor out duplicate code

This patch factors out the duplicate throttle code that was still present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Alberto Garcia Reviewed-by: Greg Kurz Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v7 2/3] qmp: introduce query-memory-size-summary command

* Vadim Galitsyn (vadim.galit...@profitbricks.com) wrote: > I think I made a typo here. It should be: > > +# @plugged-memory: size *of* memory that can be hot-unplugged. This field > +# is omitted if target does *not* support memory hotplug > +# (i.e.

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

Hi On Thu, Sep 14, 2017 at 9:50 AM, Peter Xu wrote: > This series was born from this one: > > https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04310.html > > The design comes from Markus, and also the whole-bunch-of discussions > in previous thread. My heartful

[Qemu-devel] [RFC 07/15] monitor: unify global init

There are many places for monitor init its globals, at least: - monitor_init_qmp_commands() at the very beginning - single function to init monitor_lock - in the first entry of monitor_init() using "is_first_init" Unify them a bit. Signed-off-by: Peter Xu ---

Re: [Qemu-devel] [PATCH] util/qemu-thread-posix.c: Replace OS ifdefs with CONFIG_HAVE_SEM_TIMEDWAIT

05.09.2017 15:19, Peter Maydell wrote: > In qemu-thread-posix.c we have two implementations of the > various qemu_sem_* functions, one of which uses native POSIX > sem_* and the other of which emulates them with pthread conditions. > This is necessary because not all our host OSes support >

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

On Thu, Sep 14, 2017 at 10:00:11AM +0200, Igor Mammedov wrote: > On Thu, 14 Sep 2017 12:31:18 +0530 > Bharata B Rao wrote: > > > Hi, > > > > QEMU hits the below assert > > > > qemu-system-ppc64: used ring relocated for ring 2 > > qemu-system-ppc64:

Re: [Qemu-devel] [PATCH v2 3/4] virtio-ccw: use ccw data stream

On Wed, 13 Sep 2017 13:50:28 +0200 Halil Pasic wrote: > Replace direct access which implicitly assumes no IDA > or MIDA with the new ccw data stream interface which should > cope with these transparently in the future. > > Signed-off-by: Halil Pasic

Re: [Qemu-devel] [PATCH v1 0/2] Virtio GPU for S390

Hi, > Do you have a list of CONFIG options that need to be enabled there? > Are there also any patches to the guest kernel driver required? guest kernel driver should be fine, it works for ppc64 (big endian) guests. cheers, Gerd

Re: [Qemu-devel] [PATCH v2 0/4] add CCW indirect data access support

On Wed, 13 Sep 2017 13:50:25 +0200 Halil Pasic wrote: > Abstract > > > The objective of this series is introducing CCW IDA (indirect data > access) support to our virtual channel subsystem implementation. Briefly > CCW IDA can be thought of as a kind of a

Re: [Qemu-devel] [PATCH v7 0/3] hmp, qmp: 'info memory_size_summary', 'query-memory-size-summary', 'info numa' updates

* Igor Mammedov (imamm...@redhat.com) wrote: > On Thu, 14 Sep 2017 11:35:36 +0200 > Vadim Galitsyn wrote: > > > Hi Guys, > > > > Could you please let me know if you have an update on this topic? > Series looks good to me. > so with comments I've made fixed up

Re: [Qemu-devel] [PATCH v7 2/3] qmp: introduce query-memory-size-summary command

* Igor Mammedov (imamm...@redhat.com) wrote: > On Tue, 29 Aug 2017 17:30:21 +0200 > Vadim Galitsyn wrote: > > > Add a new query-memory-size-summary command which provides the > > following memory information in bytes: > > > > * base-memory - size of "base"

Re: [Qemu-devel] [PATCH v7 0/3] hmp, qmp: 'info memory_size_summary', 'query-memory-size-summary', 'info numa' updates

Igor, David, Thank you! Best regards, Vadim On Thu, Sep 14, 2017 at 12:09 PM, Dr. David Alan Gilbert < dgilb...@redhat.com> wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Thu, 14 Sep 2017 11:35:36 +0200 > > Vadim Galitsyn wrote: > > > > > Hi

[Qemu-devel] [PATCH v11 3/6] qmp: factor out throttle code to reuse code

This patch reuses the code to set throttle limits. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Alberto Garcia Reviewed-by: Greg Kurz --- blockdev.c | 53 +++-- 1 file changed, 3

[Qemu-devel] [PATCH v11 6/6] fsdev: hmp interface for throttling

This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Dr. David Alan Gilbert --- hmp-commands-info.hx | 18 hmp-commands.hx | 19 + hmp.c

[Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

This patch factors out code to use the ThrottleLimits strurcture. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Greg Kurz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

On 14.09.2017 12:48, Greg Kurz wrote: > If the host has both KVM PR and KVM HV loaded and we pass: > > -machine pseries,accel=kvm,kvm-type=PR > > the kvmppc_is_pr() returns false instead of true. Since the helper > is mostly used as fallback, it doesn't have any real impact with > recent

[Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

This is not a problem if we are only having one single loop thread like before. However, after per-monitor thread is introduced, this is not true any more, and the race can happen. The race can be triggered with "make check -j8" sometimes: qemu-system-x86_64:

[Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

This series was born from this one: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04310.html The design comes from Markus, and also the whole-bunch-of discussions in previous thread. My heartful thanks to Markus, Daniel, Dave, Stefan, etc. on discussing the topic (...again!),

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

On Thu, 14 Sep 2017 12:31:18 +0530 Bharata B Rao wrote: > Hi, > > QEMU hits the below assert > > qemu-system-ppc64: used ring relocated for ring 2 > qemu-system-ppc64: qemu/hw/virtio/vhost.c:649: vhost_commit: Assertion `r >= > 0' failed. > > in the following

Re: [Qemu-devel] [PATCH v2] hw/display/xenfb.c: Add trace_xenfb_key_event

23.08.2017 18:27, Liang Yan wrote: > It may be better to add a trace event to monitor the last moment of > a key event from QEMU to guest VM The patch looks okay, hopefully it is also useful - I haven't dealt with xen and with keys it sends to a guest :) Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v1 1/2] virtio_gpu: Handle endian conversion

On Wed, 2017-09-13 at 11:53 -0400, Farhan Ali wrote: > > On 09/13/2017 04:13 AM, Gerd Hoffmann wrote: > > Please move this to a helper function, maybe by updating the > > VIRTIO_GPU_FILL_CMD macro. > > > > The header fields should be byteswapped too.  As most structs have > > 32bit fields only

Re: [Qemu-devel] [PATCH] throttle: Assert that bkt->max is valid in throttle_compute_wait()

On Wed 13 Sep 2017 06:31:58 PM CEST, Philippe Mathieu-Daudé wrote: >> If bkt->max == 0 and bkt->burst_length > 1 then we could have a >> division by 0 in throttle_do_compute_wait(). That configuration is >> however not permitted and is already detected by throttle_is_valid(), >> but let's assert

[Qemu-devel] [PATCH] checkpatch: add hwaddr to @typeList

The script doesn't know about all possible types and learn them as it parses the code. If it reaches a line with a type cast but the type isn't known yet, it is misinterpreted as an identifier. For example the following line: foo = (hwaddr) -1; results in the following false-positive to be

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

On Thu, Sep 14, 2017 at 10:59:05AM +0200, Igor Mammedov wrote: > On Thu, 14 Sep 2017 13:48:26 +0530 > Bharata B Rao wrote: > > > On Thu, Sep 14, 2017 at 10:00:11AM +0200, Igor Mammedov wrote: > > > On Thu, 14 Sep 2017 12:31:18 +0530 > > > Bharata B Rao

Re: [Qemu-devel] [PATCH v11 1/6] throttle: factor out duplicate code

On Thu, 14 Sep 2017 06:40:05 -0400 Pradeep Jagadeesh wrote: > This patch factors out the duplicate throttle code that was still > present in block and fsdev devices. > > Signed-off-by: Pradeep Jagadeesh > Reviewed-by: Alberto Garcia

Re: [Qemu-devel] [PATCH v7 05/20] dirty-bitmap: Check for size query failure during truncate

On 09/13/2017 06:27 PM, John Snow wrote: > > > On 09/12/2017 04:31 PM, Eric Blake wrote: >> We've previously fixed several places where we failed to account >> for possible errors from bdrv_nb_sectors(). Fix another one by >> making bdrv_dirty_bitmap_truncate() report the error rather then >>

Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

On Thu, Sep 14, 2017 at 12:58:26PM +0100, Peter Maydell wrote: > On 14 September 2017 at 12:55, Gerd Hoffmann wrote: > > Hi, > > > >> I think a better approach is to have something in rules.mak > >> that ensures the submodule is checked out correctly (only > >> when building

Re: [Qemu-devel] [PATCH] spapr_pci: make index property mandatory

On Thu, Sep 14, 2017 at 09:03:15AM +0200, Greg Kurz wrote: > Creating several PHBs without index property confuses the DRC code > and causes issues: > - only the first index-less PHB is functional, the other ones will > silently ignore hotplugging of PCI devices > - QEMU will even terminate if

Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

On 09/14/2017 12:36 PM, Thomas Huth wrote: > libseccomp supports s390x since version 2.3.0, and I was able to start > a VM with "-sandbox on" without any obvious problems by using this patch, > so it should be safe to allow --enable-seccomp on s390x nowadays, too. > > Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH] sparc: Fix typedef clash

On 09/14/2017 09:36 AM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Older compilers (rhel6) don't like redefinition of typedefs Newer neither (clang-5) fatal error: redefinition of typedef [-Wtypedef-redefinition] d61d1b20610 Fixes:

[Qemu-devel] [PATCH v2 0/2] spapr_pci: make index property mandatory

Patch 1 is a proposal to silence patchew when it parses patch 2 :) -- Greg --- Greg Kurz (2): checkpatch: add hwaddr to @typeList spapr_pci: make index property mandatory hw/ppc/spapr_pci.c| 53 ++--- scripts/checkpatch.pl |1

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

On Wed, 13 Sep 2017 15:27:51 +0200 Halil Pasic wrote: > Add a fake device meant for testing the correctness of our css emulation. > > What we currently have is writing a Fibonacci sequence of uint32_t to the > device via ccw write. The write is going to fail if it

Re: [Qemu-devel] [RFC 0/6] initial plugin support

On 6 September 2017 at 21:28, Emilio G. Cota wrote: > Related threads: > [PATCH 00/13] instrument: Add basic event instrumentation > Date: Mon, 24 Jul 2017 20:02:24 +0300 > https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg07419.html > and > [PATCH v4 00/20]

[Qemu-devel] [PATCH v3 10/20] qcow: Switch to .bdrv_co_block_status()

We are gradually moving away from sector-based interfaces, towards byte-based. Update the qcow driver accordingly. There is no intent to optimize based on the mapping flag for this format. Signed-off-by: Eric Blake --- v3: rebase to master v2: rebase to mapping flag ---

[Qemu-devel] [PATCH v3 03/20] file-posix: Switch to .bdrv_co_block_status()

We are gradually moving away from sector-based interfaces, towards byte-based. Update the file protocol driver accordingly. In mapping mode, note that the entire file is reported as allocated, so we can take a shortcut and skip lseek(). Signed-off-by: Eric Blake --- v2:

[Qemu-devel] [PATCH v3 14/20] sheepdog: Switch to .bdrv_co_block_status()

We are gradually moving away from sector-based interfaces, towards byte-based. Update the sheepdog driver accordingly. Signed-off-by: Eric Blake --- v2: rebase to mapping flag --- block/sheepdog.c | 23 +++ 1 file changed, 11 insertions(+), 12

[Qemu-devel] [PATCH v3 01/20] block: Add .bdrv_co_block_status() callback

We are gradually moving away from sector-based interfaces, towards byte-based. Now that the block layer exposes byte-based allocation, it's time to tackle the drivers. Add a new callback that operates on as small as byte boundaries. Subsequent patches will then update individual drivers, then

[Qemu-devel] [PATCH v3 17/20] vmdk: Switch to .bdrv_co_block_status()

We are gradually moving away from sector-based interfaces, towards byte-based. Update the vmdk driver accordingly. Signed-off-by: Eric Blake --- v2: rebase to mapping flag --- block/vmdk.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-)

[Qemu-devel] [PATCH v3 16/20] vdi: Switch to .bdrv_co_block_status()

We are gradually moving away from sector-based interfaces, towards byte-based. Update the vdi driver accordingly. Note that the TODO is already covered (the block layer guarantees bounds of its requests), and that we can remove the now-unused s->block_sectors. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v3 04/20] gluster: Switch to .bdrv_co_block_status()

We are gradually moving away from sector-based interfaces, towards byte-based. Update the gluster driver accordingly. In mapping mode, note that the entire file is reported as allocated, so we can take a shortcut and skip find_allocation(). Signed-off-by: Eric Blake --- v2:

[Qemu-devel] [PATCH v3 11/20] qcow2: Switch to .bdrv_co_block_status()

We are gradually moving away from sector-based interfaces, towards byte-based. Update the qcow2 driver accordingly. For now, we are ignoring the 'mapping' hint. However, it should be relatively straightforward to honor the hint as a way to return larger *pnum values when we have consecutive

Re: [Qemu-devel] [PATCH 2/2] Add --firmwarepath to configure

On 14/09/2017 10:36, Gerd Hoffmann wrote: > Hi, > >>> + --firmwarepath=PATH search PATH for firmware files >> >> Maybe --firmwaredir or --with-firmwaredir (because firmwaredir is not >> one of the "standard" directories)? > > I've intentionally named this "path" because it can actually

Re: [Qemu-devel] [libvirt] QEMU -M nvdimm=on and hotplug

On 09/14/2017 02:33 AM, Haozhong Zhang wrote: > On 09/13/17 17:28 +0200, Michal Privoznik wrote: >> >> BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on >> and guest migrated happily. So looks like guest ABI is stable (or at >> least stable enough not to crash). But since

[Qemu-devel] host doesn't support requested feature: CPUID.01H:EDX.ds [bit 21] Does this warn affect virtual machine performance or use?

this is my stackoverflow question: https://stackoverflow.com/questions/46219552/host-doesnt-support-requested-feature-cpuid-01hedx-ds-bit-21-does-this-warn I found a lot of warning from the VM qemu log, Does this warn affect virtual machine performance or use? , is my libvirt.xml file problem?

Re: [Qemu-devel] [libvirt] QEMU -M nvdimm=on and hotplug

On Thu, 14 Sep 2017 13:51:45 +0200 Michal Privoznik wrote: > On 09/14/2017 02:33 AM, Haozhong Zhang wrote: > > On 09/13/17 17:28 +0200, Michal Privoznik wrote: > >> > >> BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on > >> and guest migrated

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback

Hi Eric, On 14.09.2017 11:27, Linu Cherian wrote: Hi Eric, On Fri Sep 01, 2017 at 07:21:16PM +0200, Eric Auger wrote: memory_region_iommu_replay() is used for VFIO integration. However its default implementation is not adapted to SMMUv3 IOMMU memory region. Indeed the input address range is

Re: [Qemu-devel] [PATCH] sparc: Fix typedef clash

On 14 September 2017 at 13:36, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Older compilers (rhel6) don't like redefinition of typedefs > > Fixes: 12a6c15ef31c98ecefa63e91ac36955383038384 > > Signed-off-by: Dr. David Alan

[Qemu-devel] [PATCH v3 02/20] block: Switch passthrough drivers to .bdrv_co_block_status()

We are gradually moving away from sector-based interfaces, towards byte-based. Update the generic helpers, and all passthrough clients (blkdebug, commit, mirror, throttle) accordingly. Signed-off-by: Eric Blake --- v3: rebase to addition of throttle driver v2: rebase to

  1   2   3   4   >