[Qemu-devel] [PATCH] target/i386: add CPU model "Skylake-Server-clflushopt"

2017-12-11 Thread Haozhong Zhang
The only difference from the existing CPU model "Skylake-Server" is the add of CPUID_7_0_EBX_CLFLUSHOPT, which is missed in "Skylake-Server". Signed-off-by: Haozhong Zhang --- target/i386/cpu.c | 49 + 1 file changed, 49

Re: [Qemu-devel] [PATCH 00/12] Refactor get_phys_addr() not to return FSR values

2017-12-11 Thread Edgar E. Iglesias
On Tue, Dec 05, 2017 at 07:46:20PM +, Peter Maydell wrote: > Currently get_phys_addr() and its various subfunctions return a > hard-coded fault status register value for translation failures. This > is awkward because FSR values these days may be either long-descriptor > format or

Re: [Qemu-devel] [PATCH 3/3] ide: abort TRIM operation for invalid range

2017-12-11 Thread Anton Nefedov
On 8/12/2017 10:51 PM, John Snow wrote: Looks about right, just remember that this flow won't call block_acct_invalid because you're bypassing the return to ide_dma_cb. I assume you'll get to that in your next series. Yes; I meant to keep the trim accounting in ide_issue_trim_cb() For now,

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Longpeng (Mike)
On 2017/12/6 19:01, Halil Pasic wrote: > > > On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: >> +\field{outcome_len} is the size of struct virtio_crypto_session_input or >> +ZERO for the session-destroy operation. > > This ain't correct. It should have been something like >

[Qemu-devel] [PATCH v1 14/19] fpu/softfloat: re-factor round_to_int

2017-12-11 Thread Alex Bennée
We can now add float16_round_to_int and use the common round_decomposed and canonicalize functions to have a single implementation for float16/32/64 round_to_int functions. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 304

[Qemu-devel] [PATCH v1 09/19] fpu/softfloat: define decompose structures

2017-12-11 Thread Alex Bennée
These structures pave the way for generic softfloat helper routines that will operate on fully decomposed numbers. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 72 - 1 file changed, 71 insertions(+), 1

[Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper

2017-12-11 Thread Alex Bennée
Signed-off-by: Alex Bennée --- include/fpu/softfloat.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index 32036382c6..17dfe60dbd 100644 --- a/include/fpu/softfloat.h +++ b/include/fpu/softfloat.h @@ -390,6

Re: [Qemu-devel] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

2017-12-11 Thread Yoni Bettan
On 12/07/2017 10:58 PM, Eduardo Habkost wrote: On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't

[Qemu-devel] [PATCH v4 00/46] Windbg supporting

2017-12-11 Thread Mihail Abakumov
An update of: v1: https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07092.html We made the debugger module WinDbg (like GDB) for QEMU. This is the replacement of the remote stub in Windows kernel. Used for remote Windows kernel debugging without debugging mode. WinDbg is a

[Qemu-devel] [PATCH v4 06/46] windbg: added WindbgState

2017-12-11 Thread Mihail Abakumov
Added definition of the WindbgState struct and its initialization. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 28 1 file

[Qemu-devel] [PATCH v4 01/46] windbg: added empty windbgstub files

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- Makefile.target |5 + include/exec/windbgstub-utils.h | 18 ++

[Qemu-devel] [PATCH v4 04/46] windbg: added '-windbg' option

2017-12-11 Thread Mihail Abakumov
This option starts windbg server. Signed-off-by: Mihail Abakumov Acked-by: Alistair Francis Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- qemu-options.hx |8

[Qemu-devel] [PATCH v4 13/46] windbg: handler of parsing context

2017-12-11 Thread Mihail Abakumov
Implemented handler of parsing context. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 36 ++-- 1 file changed, 34

[Qemu-devel] [PATCH v4 22/46] windbg: kernel's structures

2017-12-11 Thread Mihail Abakumov
Defined Windows kernel's structures (CPU_CONTEXT and CPU_KSPECIAL_REGISTERS) for i386 and x64_86. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c |

[Qemu-devel] [PATCH v4 03/46] windbg: modified windbgkd.h

2017-12-11 Thread Mihail Abakumov
Added useful name arrays of some defines. Not used yet. Needs for the future. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgkd.h | 83

[Qemu-devel] [PATCH v4 10/46] windbg: structures for parsing data stream

2017-12-11 Thread Mihail Abakumov
Added structures for parsing data stream from windbg to packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h | 11 +++

[Qemu-devel] [PATCH v4 12/46] windbg: send data and control packets

2017-12-11 Thread Mihail Abakumov
Added functions for send data and control packets to windbg. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 56

[Qemu-devel] [PATCH v4 28/46] windbg: implemented windbg_write_ks_regs

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 111 ++ 1 file changed, 111 insertions(+) diff --git

[Qemu-devel] [PATCH v4 23/46] windbg: implemented kd_api_get_context and kd_api_set_context

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ target/i386/windbgstub.c| 39 +++

[Qemu-devel] [PATCH v4 36/46] windbg: implemented kd_api_read_io_space and kd_api_write_io_space

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 + windbgstub-utils.c | 62 +++

[Qemu-devel] [PATCH v4 43/46] windbg: added new api functions

2017-12-11 Thread Mihail Abakumov
Added some definitions for new windbg. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgkd.h | 21 - 1 file changed, 20 insertions(+),

[Qemu-devel] [PATCH v4 39/46] windbg: implemented kd_api_read_msr and kd_api_write_msr

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 target/i386/windbgstub.c| 328 +++

[Qemu-devel] [PATCH v4 40/46] windbg: implemented kd_api_search_memory

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + windbgstub-utils.c | 33 + windbgstub.c

[Qemu-devel] [PATCH v1 for-2-12 04/15] s390x/flic: simplify flic initialization

2017-12-11 Thread David Hildenbrand
This makes it clearer, which device is used for which accelerator. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 9 +++-- hw/intc/s390_flic_kvm.c | 12 include/hw/s390x/s390_flic.h | 9 - 3 files changed, 7 insertions(+),

Re: [Qemu-devel] [RFC] vhost: check if ring mapping is still valid when building memmap

2017-12-11 Thread Igor Mammedov
On Mon, 11 Dec 2017 11:03:00 + "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Fri, 8 Dec 2017 17:51:56 + > > "Dr. David Alan Gilbert" wrote: > > > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > >

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB

2017-12-11 Thread David Hildenbrand
On 11.12.2017 13:21, Christian Borntraeger wrote: > KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically > limiting the memory per slot to 8TB-4k. As memory slots on s390/kvm must > be a multiple of 1MB we need start a new memory region if we cross > 8TB-1M. > > With that (and

[Qemu-devel] [PATCH v1 for-2-12 02/15] cpu-exec: fix missed CPU kick during interrupt injection

2017-12-11 Thread David Hildenbrand
The conditional memory barrier not only looks strange but actually is wrong. On s390x, I can reproduce interrupts via cpu_interrupt() not leading to a proper kick out of emulation every now and then. cpu_interrupt() is especially used for inter CPU communication via SIGP (esp. external calls and

Re: [Qemu-devel] [PATCH v6 3/4] contrib/libvhost-user: enable virtio config space messages

2017-12-11 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 02:27:18PM +0800, Changpeng Liu wrote: > @@ -798,6 +801,70 @@ vu_set_slave_req_fd(VuDev *dev, VhostUserMsg *vmsg) > } > > static bool > +vu_get_config(VuDev *dev, VhostUserMsg *vmsg) > +{ > +int ret = -1; > + > +if (dev->iface->get_config) { > +ret =

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Michael S. Tsirkin
On Mon, Dec 11, 2017 at 02:54:25PM +0100, Halil Pasic wrote: > * I assume one request is supposed to correspond to one descriptor chain. > Right? If yes, could you tell me, where is this expressed in the spec. > > Halil That's always the default for all virtio devices, exceptions have to be

Re: [Qemu-devel] [PATCH v6 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application

2017-12-11 Thread Stefan Hajnoczi
> +static int vub_virtio_process_req(VubDev *vdev_blk, > + VuVirtq *vq) > +{ > +VugDev *gdev = _blk->parent; > +VuDev *vu_dev = >parent; > +VuVirtqElement *elem; > +uint32_t type; > +unsigned in_num; > +unsigned out_num; > +VubReq

[Qemu-devel] [PATCH v1 00/19] re-factor softfloat and add fp16 functions

2017-12-11 Thread Alex Bennée
Hi, In my previous run at this I'd simply taken the existing float32 functions and attempted to copy and paste the code changing the relevant constants. Apart from the usual typos and missed bits there were sections where softfloat pulls tricks because it knows the exact bit positions of things.

[Qemu-devel] [PATCH v1 02/19] include/fpu/softfloat: implement float16_abs helper

2017-12-11 Thread Alex Bennée
This will be required when expanding the MINMAX() macro for 16 bit/half-precision operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- include/fpu/softfloat.h | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Qemu-devel] [PATCH v1 03/19] include/fpu/softfloat: implement float16_chs helper

2017-12-11 Thread Alex Bennée
Signed-off-by: Alex Bennée --- include/fpu/softfloat.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index edf402d422..32036382c6 100644 --- a/include/fpu/softfloat.h +++ b/include/fpu/softfloat.h @@ -381,6

[Qemu-devel] [PATCH v1 15/19] fpu/softfloat: re-factor float to int/uint

2017-12-11 Thread Alex Bennée
We share the common int64/uint64_pack_decomposed function across all the helpers and simply limit the final result depending on the final size. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 1000 ++-

[Qemu-devel] [PATCH v1 10/19] fpu/softfloat: re-factor add/sub

2017-12-11 Thread Alex Bennée
We can now add float16_add/sub and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 add and sub functions. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 903 +---

[Qemu-devel] [PATCH v1 19/19] fpu/softfloat: re-factor compare

2017-12-11 Thread Alex Bennée
Signed-off-by: Alex Bennée --- fpu/softfloat.c | 135 +--- include/fpu/softfloat.h | 2 + 2 files changed, 83 insertions(+), 54 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 5eba996932..31b437e000

[Qemu-devel] [PATCH v4 05/46] windbg: added helper features

2017-12-11 Thread Mihail Abakumov
Added some helper features for windbgstub. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h | 31 +++

[Qemu-devel] [PATCH v4 02/46] windbg: added windbg's KD header file

2017-12-11 Thread Mihail Abakumov
Header file from windbg's source code describing the main structures. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgkd.h | 873

[Qemu-devel] [PATCH v4 09/46] windbg: handler of fs/gs register

2017-12-11 Thread Mihail Abakumov
Added handler of fs/gs register. It tries to find and check KPCR and version address. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |8

[Qemu-devel] [PATCH v4 24/46] windbg: implemented kd_api_read_control_space and kd_api_write_control_space

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 + target/i386/windbgstub.c| 89 +++

[Qemu-devel] [PATCH v4 15/46] windbg: generate ExceptionStateChange

2017-12-11 Thread Mihail Abakumov
Added function for generate ExceptionStateChange packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ target/i386/windbgstub.c

[Qemu-devel] [PATCH v4 29/46] windbg: implemented windbg_set_sr

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v18 10/10] virtio-balloon: don't report free pages when page poisoning is enabled

2017-12-11 Thread Michael S. Tsirkin
On Mon, Dec 11, 2017 at 02:38:45PM +0800, Wei Wang wrote: > On 12/01/2017 11:49 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2017 at 09:55:26PM +0800, Wei Wang wrote: > > > The guest free pages should not be discarded by the live migration thread > > > when page poisoning is enabled with

[Qemu-devel] [PATCH v4 30/46] windbg: implemented windbg_set_dr

2017-12-11 Thread Mihail Abakumov
Defined useful macros for breakpoints. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 50 +- 1 file

[Qemu-devel] [PATCH v4 27/46] windbg: implemented windbg_read_ks_regs

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 39 +++ 1 file changed, 39 insertions(+) diff --git

[Qemu-devel] [PATCH v4 38/46] windbg: implemented kd_api_get_version

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + windbgstub-utils.c | 22 ++ windbgstub.c

[Qemu-devel] [PATCH v4 45/46] windbg: changed kd_api_read_msr and kd_api_write_msr

2017-12-11 Thread Mihail Abakumov
Added sub functions for helper_wrmsr and helper_rdmsr: cpu_x86_write_msr and cpu_x86_read_msr. Also they are used in packet handlers, i.e. duplication of code is removed. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk

[Qemu-devel] [PATCH v4 42/46] windbg: implemented kd_api_query_memory

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + windbgstub-utils.c |9 + windbgstub.c|

[Qemu-devel] [PATCH v1 for-2-12 05/15] s390x/tcg: simplify machine check handling

2017-12-11 Thread David Hildenbrand
We currently only support CRW machine checks. This is a preparation for real floating interrupt support. Get rid of the queue and handle it via the bit INTERRUPT_MCHK. We don't rename it for now, as it will be soon gone (when moving crw machine checks into the flic). Please note that this is the

[Qemu-devel] [PATCH v1 for-2-12 00/15] s390x: flic rework, tcg flic support and tcg

2017-12-11 Thread David Hildenbrand
This patch series implements floating interrupt support for TCG and fixes STSI so we can remove warnings related to s390x SMP and MTTCG. KVM code has to be touched in order to factor out the injection routines into the flic ("s390x/flic: factor out injection of floating interrupts"). Basic

[Qemu-devel] [PATCH v1 for-2-12 01/15] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread David Hildenbrand
pause_all_cpus() is sometimes called from a VCPU thread (e.g. s390x during special reset). It cannot deal with multiple VCPUs per Thread (single threaded TCG) yet. Booting an s390x guest with -smp 2 and single threaded TCG from disk currently fails. The DIAG 308 will issue a pause_all_cpus() and

[Qemu-devel] [PATCH v1 for-2-12 14/15] s390x/tcg: remove SMP warning

2017-12-11 Thread David Hildenbrand
We should be pretty good in shape now. Floating interrupts are working and atomic instructions should be atomic. Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c

[Qemu-devel] [PATCH v1 for-2-12 12/15] s390x/tcg: fix size + content of STSI blocks

2017-12-11 Thread David Hildenbrand
All blocks are 4k in size, which is only true for two of them right now. Also some reserved fields were wrong, fix it and convert all reserved fields to u8. This also fixes the LPAR part output in /proc/sysinfo under TCG. (for now, everything was indicated as 0) Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH v6 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2017-12-11 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 02:27:17PM +0800, Changpeng Liu wrote: > This commit introduces a new vhost-user device for block, it uses a > chardev to connect with the backend, same with Qemu virito-blk device, > Guest OS still uses the virtio-blk frontend driver. > > To use it, start QEMU with

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Halil Pasic
On 12/11/2017 01:56 PM, Longpeng (Mike) wrote: > > > On 2017/12/6 19:01, Halil Pasic wrote: > >> >> >> On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: >>> +\field{outcome_len} is the size of struct virtio_crypto_session_input or >>> +ZERO for the session-destroy operation. >> >> This ain't

[Qemu-devel] [PATCH v1 13/19] fpu/softfloat: re-factor muladd

2017-12-11 Thread Alex Bennée
We can now add float16_muladd and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 muladd functions. Signed-off-by: Alex Bennée --- fpu/softfloat-specialize.h | 104 --- fpu/softfloat.c| 756

[Qemu-devel] [PATCH v1 11/19] fpu/softfloat: re-factor mul

2017-12-11 Thread Alex Bennée
We can now add float16_mul and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 versions. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 207 ++--

[Qemu-devel] [PATCH v4 19/46] windbg: implemented windbg_process_data_packet

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/windbgstub.c

[Qemu-devel] [PATCH v4 14/46] windbg: init DBGKD_ANY_WAIT_STATE_CHANGE

2017-12-11 Thread Mihail Abakumov
Added function for init DBGKD_ANY_WAIT_STATE_CHANGE. It is a header of 'state change' packets. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov ---

[Qemu-devel] [PATCH v4 31/46] windbg: implemented windbg_set_dr7

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v4 18/46] windbg: implemented windbg_process_control_packet

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/windbgstub.c

[Qemu-devel] [PATCH v4 26/46] windbg: implemented windbg_write_context

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 216 ++ 1 file changed, 216 insertions(+) diff --git

Re: [Qemu-devel] qemu process crash: Assertion failed: QLIST_EMPTY(>tracked_requests)

2017-12-11 Thread Fernando Casas Schössow
Hello Stefan, Thanks for your reply. Fortunately I didn’t have the problem again and it’s not clear how it can be consistently reproduced. Daily backups are running as usual at the moment. If there is anything I can do from my side or if you have any ideas to try to reproduce it let me know.

[Qemu-devel] [PATCH v4 44/46] windbg: implemented kd_api_get_context_ex and kd_api_set_context_ex

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 + target/i386/windbgstub.c| 130 ---

[Qemu-devel] [PATCH v1 for-2-12 10/15] s390x/flic: implement qemu_s390_clear_io_flic()

2017-12-11 Thread David Hildenbrand
Now that we have access to the io interrupts, we can implement clear_io_irq() for TCG. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/hw/intc/s390_flic.c

Re: [Qemu-devel] [PATCH v6 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-12-11 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 02:27:16PM +0800, Changpeng Liu wrote: > +* VHOST_USER_SET_CONFIG > + Id: 25 > + Equivalent ioctl: N/A > + Master payload: virtio device config space > + > + Submitted by the vhost-user master when the Guest changes the virtio > + device

Re: [Qemu-devel] [PATCH v13 00/12] Add ARMv8 RAS virtualization support in QEMU

2017-12-11 Thread Igor Mammedov
On Mon, 11 Dec 2017 19:31:14 +0800 gengdongjiu wrote: > Hi maintainer, > > This patch set seems pending about one month, could you help review for > them? Thanks. I'm going to look at ACPI side of it this week. > In this series, except the three patches in [1] are

[Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-11 Thread David Hildenbrand
Let the flic device handle it internally. This will allow us to later on store floating interrupts in the flic for the TCG case. This now also simplifies kvm.c. All that's left is the fallback interface for floating interrupts, which is no triggered directly via the flic in case anything goes

[Qemu-devel] [PATCH v1 for-2-12 11/15] s390x/flic: optimize CPU wakeup for TCG

2017-12-11 Thread David Hildenbrand
Kicking all CPUs on every floating interrupt is far from efficient. Let's optimize it at least a little bit. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 31 +-- target/s390x/cpu.h | 4 target/s390x/internal.h | 5 -

[Qemu-devel] [PATCH v1 for-2-12 13/15] s390x/tcg: STSI overhaul

2017-12-11 Thread David Hildenbrand
Current STSI implementation is a mess, so let's rewrite it. Problems fixed by this patch: 1) The order of exceptions/when recognized is wrong. 2) We have to store to virtual address space, not absolute. 3) Alignment check of the block is missing. 3) The SMP information is not indicated. While at

Re: [Qemu-devel] [PATCH v1 for-2-12 04/15] s390x/flic: simplify flic initialization

2017-12-11 Thread Christian Borntraeger
On 12/11/2017 02:47 PM, David Hildenbrand wrote: > This makes it clearer, which device is used for which accelerator. > > Signed-off-by: David Hildenbrand nice. Reviewed-by: Christian Borntraeger > --- > hw/intc/s390_flic.c | 9 +++-- >

Re: [Qemu-devel] [PATCH 2/5] lock-guard: add scoped lock implementation

2017-12-11 Thread Eric Blake
On 12/11/2017 04:16 AM, Stefan Hajnoczi wrote: >>> I don't understand the need for the qemu_lock_guard_is_taken() >>> condition, why not do the following? >>> >>> for (QEMU_LOCK_GUARD(type, name, lock); >>>; >>>qemu_lock_guard_unlock()) >> >> Because that would be an infinite

Re: [Qemu-devel] [PATCH] baum: Truncate braille device size to 84x1

2017-12-11 Thread Eric Blake
On 12/10/2017 06:19 PM, Samuel Thibault wrote: > Baum device bigger than 84 do not actually exist, some guest drivers > would be upset by such sizes. > > Signed-off-by: Samuel Thibault > --- > chardev/baum.c | 8 +++- > 1 file changed, 7 insertions(+), 1

Re: [Qemu-devel] [PATCH] baum: Truncate braille device size to 84x1

2017-12-11 Thread Samuel Thibault
Eric Blake, on lun. 11 déc. 2017 08:30:39 -0600, wrote: > On 12/10/2017 06:19 PM, Samuel Thibault wrote: > > Baum device bigger than 84 do not actually exist, some guest drivers > > would be upset by such sizes. > > > > Signed-off-by: Samuel Thibault > > --- > >

[Qemu-devel] [PATCH v1 01/19] fpu/softfloat: implement float16_squash_input_denormal

2017-12-11 Thread Alex Bennée
This will be required when expanding the MINMAX() macro for 16 bit/half-precision operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- fpu/softfloat.c | 15 +++ include/fpu/softfloat.h | 1 + 2

[Qemu-devel] [PATCH v1 07/19] fpu/softfloat: improve comments on ARM NaN propagation

2017-12-11 Thread Alex Bennée
Mention the pseudo-code fragment from which this is based and correct the spelling of signalling. Signed-off-by: Alex Bennée --- fpu/softfloat-specialize.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/fpu/softfloat-specialize.h

[Qemu-devel] [PATCH v1 05/19] include/fpu/softfloat: add some float16 contants

2017-12-11 Thread Alex Bennée
This defines the same set of common constants for float 16 as defined for 32 and 64 bit floats. These are often used by target helper functions. Signed-off-by: Alex Bennée --- include/fpu/softfloat.h | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Qemu-devel] [PATCH v1 08/19] fpu/softfloat: move the extract functions to the top of the file

2017-12-11 Thread Alex Bennée
This is pure code-motion during re-factoring as the helpers will be needed earlier. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 119 +--- 1 file changed, 53 insertions(+), 66 deletions(-) diff --git

[Qemu-devel] [PATCH v1 18/19] fpu/softfloat: re-factor minmax

2017-12-11 Thread Alex Bennée
Let's do the same re-factor treatment for minmax functions. I still use the MACRO trick to expand but now all the checking code is common. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 242 ++--

[Qemu-devel] [PATCH v1 12/19] fpu/softfloat: re-factor div

2017-12-11 Thread Alex Bennée
We can now add float16_div and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 versions. Signed-off-by: Alex Bennée --- fpu/softfloat-macros.h | 44 + fpu/softfloat.c | 235

[Qemu-devel] [PATCH v4 07/46] windbg: added chardev

2017-12-11 Thread Mihail Abakumov
Added chardev for listening to windbg. Target device is a parameter in the '-windbg' option. Signed-off-by: Mihail Abakumov Acked-by: Alistair Francis Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov

[Qemu-devel] [PATCH v4 17/46] windbg: windbg_vm_stop

2017-12-11 Thread Mihail Abakumov
Added function for stop vm. Also, ExceptionStateChange data is generated and sent here. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 13 +++-- 1

[Qemu-devel] [PATCH v4 21/46] windbg: implemented kd_api_read_virtual_memory and kd_api_write_virtual_memory

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ windbgstub-utils.c | 47 +++

[Qemu-devel] [PATCH v4 34/46] windbg: debug exception subscribing

2017-12-11 Thread Mihail Abakumov
Added handler registration of gdb debug exception. Its exception also can be used for windbg. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- cpus.c | 19

[Qemu-devel] [PATCH v4 46/46] windbg: maintainers

2017-12-11 Thread Mihail Abakumov
Added WinDbg stub to the MAINTAINERS. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- MAINTAINERS | 12 1 file changed, 12 insertions(+) diff --git

[Qemu-devel] [PATCH v1 for-2-12 03/15] s390x/tcg: deliver multiple interrupts in a row

2017-12-11 Thread David Hildenbrand
We have to consider all deliverable interrupts. We now have to take care of the special scenario, where we first inject an interrupt with a WAIT PSW, followed by a !WAIT PSW. (very unlikely but possible) Signed-off-by: David Hildenbrand --- target/s390x/excp_helper.c | 20

Re: [Qemu-devel] [RFC PATCH 0/5] Scoped locks using attribute((cleanup))

2017-12-11 Thread Eric Blake
On 12/11/2017 03:38 AM, Peter Maydell wrote: > On 8 December 2017 at 19:40, Eric Blake wrote: >> On 12/08/2017 04:55 AM, Paolo Bonzini wrote: >>> Likewise, >>> >>> QEMU_WITH_LOCK(QemuMutex, guard_name, _mutex) { >>> ... >>> } >>> >>> is the same as >>> >>>

[Qemu-devel] [PATCH v1 for-2-12 15/15] configure: s390x supports mttcg now

2017-12-11 Thread David Hildenbrand
s390x is ready. Most likely we are missing some pieces, but it should already be in pretty good shape now. Signed-off-by: David Hildenbrand --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 0c6e7572db..1e593b6fab 100755 ---

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB

2017-12-11 Thread Christian Borntraeger
On 12/11/2017 02:55 PM, David Hildenbrand wrote: > On 11.12.2017 13:21, Christian Borntraeger wrote: >> KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically >> limiting the memory per slot to 8TB-4k. As memory slots on s390/kvm must >> be a multiple of 1MB we need start a new

[Qemu-devel] [PATCH v1 06/19] fpu/softfloat: propagate signalling NaNs in MINMAX

2017-12-11 Thread Alex Bennée
While a comparison between a QNaN and a number will return the number it is not the same with a signaling NaN. In this case the SNaN will "win" and after potentially raising an exception it will be quietened. Signed-off-by: Alex Bennée --- v2 - added return for

[Qemu-devel] [PATCH v1 17/19] fpu/softfloat: re-factor scalbn

2017-12-11 Thread Alex Bennée
This is one of the simpler manipulations you could make to a floating point number. Signed-off-by: Alex Bennée --- fpu/softfloat.c | 104 +++- include/fpu/softfloat.h | 1 + 2 files changed, 32 insertions(+), 73

[Qemu-devel] [PATCH v1 16/19] fpu/softfloat: re-factor int/uint to float

2017-12-11 Thread Alex Bennée
These are considerably simpler as the lower order integers can just use the higher order conversion function. As the decomposed fractional part is a full 64 bit rounding and inexact handling comes from the pack functions. Signed-off-by: Alex Bennée --- fpu/softfloat.c

[Qemu-devel] [PATCH v4 11/46] windbg: parsing data stream

2017-12-11 Thread Mihail Abakumov
Added function of parsing data stream from windbg to packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 111

[Qemu-devel] [PATCH v4 08/46] windbg: hook to wrmsr operation

2017-12-11 Thread Mihail Abakumov
Inserted hook to wrmsr operation. Windows Kernel put address on KPCR struct to fs/gs (x32/x64) register. Needs catch this moment and allow windbg server handle packets. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by:

[Qemu-devel] [PATCH v4 16/46] windbg: generate LoadSymbolsStateChange

2017-12-11 Thread Mihail Abakumov
Added function for generate LoadSymbolsStateChange packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + target/i386/windbgstub.c

[Qemu-devel] [PATCH v4 25/46] windbg: implemented windbg_read_context

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 96 ++ 1 file changed, 96 insertions(+) diff --git

[Qemu-devel] [PATCH v4 20/46] windbg: implemented windbg_process_manipulate_packet

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ windbgstub-utils.c |8 windbgstub.c|

[Qemu-devel] [PATCH v4 32/46] windbg: implemented windbg_hw_breakpoint_insert and windbg_hw_breakpoint_remove

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 56 ++ 1 file changed, 56 insertions(+) diff --git

[Qemu-devel] [PATCH v4 37/46] windbg: implemented kd_api_read_physical_memory and kd_api_write_physical_memory

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ windbgstub-utils.c | 29 + windbgstub.c

[Qemu-devel] [PATCH v4 35/46] windbg: implemented kd_api_continue

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + windbgstub-utils.c | 15 +++ windbgstub.c

  1   2   3   >