Re: [Qemu-devel] [PATCH 1/1] nbd: implement bdrv_get_info callback

2018-02-02 Thread Edgar Kaziakhmedov
On 01/26/2018 05:28 PM, Eric Blake wrote: On 01/26/2018 06:39 AM, Edgar Kaziakhmedov wrote: PIng So, let me know if I need to make any changes in patch On 1/18/18 1:09 PM, Paolo Bonzini wrote: On 18/01/2018 12:51, Edgar Kaziakhmedov wrote: +static int nbd_get_info(BlockDriverState *bs, Blo

[Qemu-devel] [PATCH] s390x/sclp: fix event mask handling

2018-02-02 Thread Christian Borntraeger
commit 67915de9f038 ("s390x/event-facility: variable-length event masks") switches the sclp receive/send mask. This broke the sclp lm console. Signed-off-by: Christian Borntraeger Fixes: commit 67915de9f038 ("s390x/event-facility: variable-length event masks") Cc: Cornelia Huck Cc: Jason J. Hern

Re: [Qemu-devel] [PATCH v3] iotests: Fix CID for VMDK afl image

2018-02-02 Thread Max Reitz
On 2018-02-02 06:23, Fam Zheng wrote: > This reverts commit 76bf133c4 which updated the reference output, and > fixed the reference image, because the code path we want to exercise is > actually the invalid image size. > > The descriptor block in the image, which includes the CID to verify, has be

Re: [Qemu-devel] [PATCH v6 13/23] hmp: display memory encryption support in 'info kvm'

2018-02-02 Thread Brijesh Singh
On 2/2/18 7:08 AM, Daniel P. Berrangé wrote: > On Thu, Feb 01, 2018 at 08:04:43PM +, Dr. David Alan Gilbert wrote: >> * Brijesh Singh (brijesh.si...@amd.com) wrote: >>> >>> On 2/1/18 11:58 AM, Dr. David Alan Gilbert wrote: * Brijesh Singh (brijesh.si...@amd.com) wrote: > update 'info

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: add missing break in h_get_cpu_characteristics()

2018-02-02 Thread Daniel Henrique Barboza
On 02/01/2018 05:47 PM, Greg Kurz wrote: Detected by Coverity (CID 1385702). This fixes the recently added hypercall to let guests properly apply Spectre and Meltdown workarounds. Paolo Bonzini reported this error in a reply to the pull request that added the patch: "Re: [Qemu-ppc] [Qemu-dev

Re: [Qemu-devel] [PATCH 1/2] qcow2: add overlap check for bitmap directory

2018-02-02 Thread Vladimir Sementsov-Ogievskiy
02.02.2018 16:53, Max Reitz wrote: On 2018-02-02 14:48, Vladimir Sementsov-Ogievskiy wrote: 02.02.2018 16:00, Max Reitz wrote: On 2018-02-02 13:07, Vladimir Sementsov-Ogievskiy wrote: 29.01.2018 18:34, Max Reitz wrote: On 2017-11-30 17:47, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: V

Re: [Qemu-devel] [PATCH 1/3] target/ppc: add basic support for PTCR on POWER9

2018-02-02 Thread Cédric Le Goater
On 02/02/2018 03:34 AM, Suraj Jitindar Singh wrote: > On Wed, 2018-01-31 at 09:27 +0100, Cédric Le Goater wrote: >> The Partition Table Control Register (PTCR) is a hypervisor >> privileged >> SPR. It contains the host real address of the Partition Table and its >> size. >> >> Signed-off-by: Cédric

[Qemu-devel] [PATCH 4/4] tpm: tis: move one-line function into caller

2018-02-02 Thread Stefan Berger
Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 08f41d2..f81168a 100644 --- a/hw/tpm/tpm_tis.c +++ b/hw/tpm/tpm_tis.c @@ -946,11 +946,6 @@ static const MemoryRegionOps tpm_tis_mem

Re: [Qemu-devel] [PATCH v2 0/6] qmp dirty bitmap API

2018-02-02 Thread Vladimir Sementsov-Ogievskiy
22.01.2018 20:23, John Snow wrote: On 01/22/2018 07:22 AM, Vladimir Sementsov-Ogievskiy wrote: 22.01.2018 12:20, Vladimir Sementsov-Ogievskiy wrote: 20.01.2018 02:30, John Snow wrote: On 01/16/2018 07:54 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. There are three qmp commands, needed to

Re: [Qemu-devel] [PATCH 1/2] qcow2: add overlap check for bitmap directory

2018-02-02 Thread Vladimir Sementsov-Ogievskiy
02.02.2018 16:00, Max Reitz wrote: On 2018-02-02 13:07, Vladimir Sementsov-Ogievskiy wrote: 29.01.2018 18:34, Max Reitz wrote: On 2017-11-30 17:47, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy ---   block/qcow2.h  |  7 +--   block/qcow2-refcoun

[Qemu-devel] [PATCH 2/4] tpm: wrap stX_be_p in tpm_cmd_set_XYZ functions

2018-02-02 Thread Stefan Berger
Wrap the calls to stl_be_p and stw_be_p in tpm_cmd_set_XYZ functions that are similar to existing getters. Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau --- hw/tpm/tpm_util.c | 6 +++--- hw/tpm/tpm_util.h | 15 +++ 2 files changed, 18 insertions(+), 3 deletions(-) di

[Qemu-devel] [PATCH v3 01/12] vl: deprecate -no-frame

2018-02-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- vl.c | 4 qemu-doc.texi | 7 +++ 2 files changed, 11 insertions(+) diff --git a/vl.c b/vl.c index e517a8d995..ac0efca708 100644 --- a/vl.c +++ b/vl.c @@ -2104,6 +2104,8 @@ static DisplayType select_display(const char *p) const char

[Qemu-devel] [PATCH 1/4] tpm: Split off tpm_crb_reset function

2018-02-02 Thread Stefan Berger
Split off the tpm_crb_reset function part from tpm_crb_realize that we need to run every time the machine resets. Also register our reset function with the system since TYPE_DEVICE seems to not get a reset otherwise. Signed-off-by: Stefan Berger --- v1->v2: register reset function with qemu_re

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-02 Thread Marcel Apfelbaum
On 02/02/2018 12:04, Peter Xu wrote: > On Thu, Feb 01, 2018 at 10:01:31PM +0200, Marcel Apfelbaum wrote: > > [...] > >> Root ports can't be nested, anyway, I suppose the migration should >> follow the bus numbering order. > > Could I ask whether this is a must? And if yes, why? > Not sure. Th

Re: [Qemu-devel] [PATCH 1/3] target/ppc: add basic support for PTCR on POWER9

2018-02-02 Thread Cédric Le Goater
On 02/02/2018 03:41 AM, Suraj Jitindar Singh wrote: >>> +/* >>> + * Partition table definitions >>> + */ >>> +#define PTCR_PTAB 0x0000ULL /* Partition >>> Table Base */ >>> +#define PTCR_PTAS 0x001FULL /* Partition >>> Table Size */ >>> + >> s/PTC

[Qemu-devel] [PATCH v3 08/12] curses: use DisplayOptions

2018-02-02 Thread Gerd Hoffmann
Switch curses ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 ++-- ui/curses.c | 2 +- vl.c | 4 +++- qapi/ui.json | 5 +++-- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/include/ui/con

Re: [Qemu-devel] [PATCH 1/2] qcow2: add overlap check for bitmap directory

2018-02-02 Thread Vladimir Sementsov-Ogievskiy
29.01.2018 18:34, Max Reitz wrote: On 2017-11-30 17:47, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 7 +-- block/qcow2-refcount.c | 12 block/qcow2.c | 6 ++ 3 files changed, 23 insertions(+),

[Qemu-devel] [PATCH 0/4] tpm: A fix and cleanups

2018-02-02 Thread Stefan Berger
The following patches fix the resetting of the CRB interface and wrap calls to st{w,l}_be_p in tpm_cmd_set_XYZ functions. We also clean up a one-liner in the TIS. Stefan Stefan Berger (4): tpm: Split off tpm_crb_reset function tpm: wrap stX_be_p in tpm_cmd_set_XYZ functions MAINTAINERS:

Re: [Qemu-devel] [PATCH 3/3] target/ppc: generalize check on radix when in HV mode

2018-02-02 Thread Cédric Le Goater
On 02/02/2018 03:43 AM, Suraj Jitindar Singh wrote: > On Wed, 2018-01-31 at 09:27 +0100, Cédric Le Goater wrote: >> On a POWER9 processor, the first doubleword of the PTCR indicates >> whether the partition uses HPT or Radix Trees translation. Use that >> bit to check for radix mode on powernv QEMU

[Qemu-devel] [PATCH v3 06/12] vl: drop no_quit variable

2018-02-02 Thread Gerd Hoffmann
Not used any more, delete it. Signed-off-by: Gerd Hoffmann --- vl.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index 25e784be63..c17dedfa4e 100644 --- a/vl.c +++ b/vl.c @@ -152,7 +152,6 @@ int vga_interface_type = VGA_NONE; static int full_screen = 0;

Re: [Qemu-devel] [PATCH 1/1] nbd: implement bdrv_get_info callback

2018-02-02 Thread Edgar Kaziakhmedov
On 02/02/2018 05:15 PM, Eric Blake wrote: On 02/02/2018 08:06 AM, Edgar Kaziakhmedov wrote: However, it would be nice to remove can_write_zeroes_with_unmap from BlockDriverInfo, and make bdrv_can_write_zeroes_with_unmap just return !!(bs->supported_zero_flags & BDRV_REQ_MAY_UNMAP).  Kevin, wh

[Qemu-devel] [PATCH v3 02/12] vl: deprecate -alt-grab and -ctrl-grab

2018-02-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- vl.c | 8 qemu-doc.texi | 6 ++ 2 files changed, 14 insertions(+) diff --git a/vl.c b/vl.c index ac0efca708..fa19a61500 100644 --- a/vl.c +++ b/vl.c @@ -2115,6 +2115,8 @@ static DisplayType select_display(const char *p)

[Qemu-devel] [PATCH 3/4] MAINTAINERS: add pointer to tpm-next repository

2018-02-02 Thread Stefan Berger
Signed-off-by: Stefan Berger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f8deaf6..d352d16 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1593,6 +1593,7 @@ F: include/hw/acpi/tpm.h F: include/sysemu/tpm* F: qapi/tpm.json F: backends/tpm.c

[Qemu-devel] [PATCH v3 09/12] cocoa: use DisplayOptions

2018-02-02 Thread Gerd Hoffmann
Switch cocoa ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 ++-- vl.c | 3 ++- qapi/ui.json | 6 -- ui/cocoa.m | 4 ++-- 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/include/ui/c

Re: [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties

2018-02-02 Thread Markus Armbruster
Alexey Kardashevskiy writes: > On 01/02/18 04:22, Markus Armbruster wrote: >> Alexey Kardashevskiy writes: >> >>> There is already 'device-list-properties' which does most of the job, >>> however it does not handle everything returned by qom-list-types such >>> as machines as they inherit direc

[Qemu-devel] [PATCH v3] linux-user: Fix register used for 6th and 7th syscall argument on aarch64

2018-02-02 Thread Guido Günther
This unbreaks the testcase from http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html Thanks to Laurent Vivier for spotting the 7th one. Signed-off-by: Guido Günther Tested-by: Philippe Mathieu-Daudé Suggested-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-

Re: [Qemu-devel] [PATCH v3 17/50] qapi: do not define enumeration value explicitely

2018-02-02 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Dec 8, 2017 at 8:50 AM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> On Thu, Dec 7, 2017 at 5:23 PM, Markus Armbruster wrote: Marc-André Lureau writes: > The C standard has the initial value at 0 and the subsequent value

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: add missing break in h_get_cpu_characteristics()

2018-02-02 Thread Greg Kurz
On Fri, 2 Feb 2018 07:11:08 -0200 Daniel Henrique Barboza wrote: > On 02/01/2018 05:47 PM, Greg Kurz wrote: > > Detected by Coverity (CID 1385702). This fixes the recently added hypercall > > to let guests properly apply Spectre and Meltdown workarounds. > > Paolo Bonzini reported this error i

[Qemu-devel] [PATCH v3 11/12] vl: drop request_opengl variable

2018-02-02 Thread Gerd Hoffmann
Switch over the one leftover user to qapi DisplayType. The delete the unused request_opengl variable. Signed-off-by: Gerd Hoffmann --- vl.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/vl.c b/vl.c index 899fcad75e..4ef774e783 100644 --- a/vl.c +++ b/vl.c @@ -135,7 +

[Qemu-devel] [PATCH v3 00/12] rework display initialization, part one

2018-02-02 Thread Gerd Hoffmann
Hi, This series is the first part of my the qemu display initialization update. Changes: * Create a QAPI DisplayOptions type for display configuration. * Switch all display initialization calls to accept DisplayOptions instead of a bunch of bools. v2: add 'default' in the patch shich

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-02 Thread Peter Xu
On Thu, Feb 01, 2018 at 07:51:31PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > In the past, we prioritized IOMMU migration so that we have such a > > priority order: > > > > IOMMU > PCI Devices > > > > When migrating a guest with both vIOMMU and pcie-root-

[Qemu-devel] [PATCH v3 12/12] vl: drop display_type variable

2018-02-02 Thread Gerd Hoffmann
Switch over all leftover users to qapi DisplayType. Then delete the unused display_type variable. Add 'default' DisplayType, which isn't an actual display type but a placeholder for "user didn't specify a display". It will be replaced by the DisplayType actually used, which in turn depends on the

[Qemu-devel] [PATCH v3 10/12] vl: drop full_screen variable

2018-02-02 Thread Gerd Hoffmann
Not used any more, delete it. Signed-off-by: Gerd Hoffmann --- vl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/vl.c b/vl.c index eb8aca9479..899fcad75e 100644 --- a/vl.c +++ b/vl.c @@ -149,7 +149,6 @@ static int rtc_utc = 1; static int rtc_date_offset = -1; /* -1 means no change */ Q

Re: [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

2018-02-02 Thread Eduardo Habkost
(CCing qemu-devel) On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: > On Fri, 2 Feb 2018 14:19:38 + > Daniel P. Berrangé wrote: > > On Fri, Feb 02, 2018 at 12:15:54PM -0200, Eduardo Habkost wrote: [...] > > > It would be also interesting to update QEMU QMP documentation to > >

Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling

2018-02-02 Thread Christian Borntraeger
On 02/02/2018 10:42 AM, Christian Borntraeger wrote: > commit 67915de9f038 ("s390x/event-facility: variable-length event > masks") switches the sclp receive/send mask. This broke the sclp > lm console. > > Signed-off-by: Christian Borntraeger > Fixes: commit 67915de9f038 ("s390x/event-facility:

[Qemu-devel] [PATCH v3 05/12] sdl: use DisplayOptions

2018-02-02 Thread Gerd Hoffmann
Switch sdl ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 8 ui/sdl.c | 19 +-- ui/sdl2.c| 33 +++-- vl.c | 13 +++-- qapi/ui.json

[Qemu-devel] [PATCH v3 03/12] vl: rename DisplayType to LegacyDisplayType

2018-02-02 Thread Gerd Hoffmann
qapi DisplayType will replace the current enum. For the transition both will coexist though, so rename it so we don't have a name clash. Signed-off-by: Gerd Hoffmann --- vl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index fa19a61500..a2478412c7

[Qemu-devel] [PATCH v3 07/12] egl-headless: use DisplayOptions

2018-02-02 Thread Gerd Hoffmann
Switch egl-headless ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- ui/egl-headless.c| 2 +- vl.c | 3 ++- qapi/ui.json | 5 +++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/ui/

[Qemu-devel] [PATCH v2 1/2] Add a git-publish configuration file

2018-02-02 Thread Fam Zheng
git-publish [1] is a convenient tool to send patches and has been popular among QEMU developers. Recently it has been made available in Fedora official repo thanks to Stefan's work. One nice feature of the tool is a per-project configuration with profiles, especially in which the cccmd option is

[Qemu-devel] [PATCH v3 04/12] gtk: add and use DisplayOptions + DisplayGTK

2018-02-02 Thread Gerd Hoffmann
Add QAPI DisplayType enum, DisplayOptions union and DisplayGTK struct. Switch gtk configuration to use the qapi type. Some bookkeeping (fullscreen for example) is done twice now, this is temporary until more/all UIs are switched over to qapi configuration. Signed-off-by: Gerd Hoffmann --- inclu

[Qemu-devel] [PATCH v3] iotests: Fix CID for VMDK afl image

2018-02-02 Thread Fam Zheng
This reverts commit 76bf133c4 which updated the reference output, and fixed the reference image, because the code path we want to exercise is actually the invalid image size. The descriptor block in the image, which includes the CID to verify, has been invalid since the reference image was added.

[Qemu-devel] [PATCH v2 2/2] README: Document 'git-publish' workflow

2018-02-02 Thread Fam Zheng
Signed-off-by: Fam Zheng --- .gitpublish | 1 + README | 30 +- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/.gitpublish b/.gitpublish index 170bd2ed48..7542e878fc 100644 --- a/.gitpublish +++ b/.gitpublish @@ -26,6 +26,7 @@ cccmd = scripts/get_

[Qemu-devel] [PATCH v2 0/2] Add git-publish config file

2018-02-02 Thread Fam Zheng
v2: Add README paragraph [Marc-André, Stefan] Fix 'trivial' profile [Marc-André] Rename profiles [Stefan] Fam Zheng (2): Add a git-publish configuration file README: Document 'git-publish' workflow .gitpublish | 58 ++ README

[Qemu-devel] [PULL 0/2] Audio 20180202 patches

2018-02-02 Thread Gerd Hoffmann
The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into staging (2018-01-31 15:50:29 +) are available in the git repository at: git://git.kraxel.org/qemu tags/audio-20180202-pull-re

Re: [Qemu-devel] [PATCH v3 24/50] qapi: add some struct member tests

2018-02-02 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Sat, Dec 9, 2017 at 10:07 AM, Markus Armbruster wrote: >> Marc-André Lureau writes: [...] >>> diff --git a/tests/qapi-schema/struct-member-type.json >>> b/tests/qapi-schema/struct-member-type.json >>> new file mode 100644 >>> index 00..8b33027817 >

Re: [Qemu-devel] [PATCH v3 1/1] s390x/cpu: expose the guest crash information

2018-02-02 Thread Eric Blake
On 02/02/2018 08:37 AM, Christian Borntraeger wrote: > This patch is the s390 implementation of guest crash information, > similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM > property") and the related commits. We will detect several crash > reasons, with the "disabled wait" being

Re: [Qemu-devel] [PATCH V9 3/4] pvrdma: initial implementation

2018-02-02 Thread Marcel Apfelbaum
On 02/02/2018 14:08, Dotan Barak wrote: > Reviewed-by: Dotan Barak > The Mellanox review for the RDMA code is very much appreciated! Thanks Dotan, we know you put much effort into it and the V9 re-spin quality just went up :) Marcel > --

Re: [Qemu-devel] [PATCH 1/1] nbd: implement bdrv_get_info callback

2018-02-02 Thread Eric Blake
On 02/02/2018 08:06 AM, Edgar Kaziakhmedov wrote: However, it would be nice to remove can_write_zeroes_with_unmap from BlockDriverInfo, and make bdrv_can_write_zeroes_with_unmap just return !!(bs->supported_zero_flags & BDRV_REQ_MAY_UNMAP).  Kevin, what do you think? >> Actuall

Re: [Qemu-devel] [PATCH v5 11/14] input: add missing JIS keys to virtio input

2018-02-02 Thread Eduardo Habkost
On Fri, Feb 02, 2018 at 01:13:14PM +, Daniel P. Berrangé wrote: > On Thu, Feb 01, 2018 at 06:46:46PM -0200, Eduardo Habkost wrote: > > On Tue, Jan 16, 2018 at 01:42:14PM +, Daniel P. Berrange wrote: > > > From: Miika S > > > > > > keycodemapdb updated to add the QKeyCodes muhenkan and kat

Re: [Qemu-devel] Windows balloon driver PFN issue

2018-02-02 Thread Peter Xu
On Thu, Feb 01, 2018 at 02:48:20PM +0200, Michael S. Tsirkin wrote: [...] > > > > > PFN is GPA>>12. Do you have more than 1<<44 bytes of memory in this > > > > > VM then? > > > > > > > > No. But isn't it still not good to drop the page at offset zero (and > > > > drop it NNN times)? > > > >

Re: [Qemu-devel] [PULL 0/7] Small IPMI fixes

2018-02-02 Thread Peter Maydell
On 1 February 2018 at 18:52, wrote: > The following changes since commit 6521130b0a7f699fdb82446d57df5627bfa7ed3c: > > Merge remote-tracking branch > 'remotes/stefanberger/tags/pull-tpm-2018-01-26-2' into staging (2018-01-30 > 15:20:01 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

2018-02-02 Thread Luiz Capitulino
On Fri, 2 Feb 2018 12:50:14 -0200 Eduardo Habkost wrote: > (CCing qemu-devel) > > On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: > > On Fri, 2 Feb 2018 14:19:38 + > > Daniel P. Berrangé wrote: > > > On Fri, Feb 02, 2018 at 12:15:54PM -0200, Eduardo Habkost wrote: > [..

[Qemu-devel] [PULL 2/2] hw/audio/sb16.c: change dolog() to qemu_log_mask()

2018-02-02 Thread Gerd Hoffmann
From: John Arbuckle Changes all the occurrances of dolog() to qemu_log_mask(). Signed-off-by: John Arbuckle Message-id: 20180201172744.7504-1-programmingk...@gmail.com Signed-off-by: Gerd Hoffmann --- hw/audio/sb16.c | 79 +++-- 1 file chang

Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

2018-02-02 Thread Max Reitz
On 2017-12-02 23:37, Shravan Rajinikanth wrote: > Signed-off-by: Shravan Rajinikanth > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 68b375f..bea9268 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -580,7 +580,7 @@ sta

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-02 Thread Peter Xu
On Thu, Feb 01, 2018 at 10:01:31PM +0200, Marcel Apfelbaum wrote: [...] > Root ports can't be nested, anyway, I suppose the migration should > follow the bus numbering order. Could I ask whether this is a must? And if yes, why? > > The question now is what happens if the migration is happenin

Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code

2018-02-02 Thread Markus Armbruster
Markus Armbruster writes: > Our qapi-schema.json is composed of modules connected by include > directives, but the generated code is monolithic all the same: one > qapi-types.h with all the types, one qapi-visit.h with all the > visitors, and so forth. These monolithic headers get included all >

Re: [Qemu-devel] [PATCH 3/4] MAINTAINERS: add pointer to tpm-next repository

2018-02-02 Thread Eric Blake
On 02/02/2018 08:44 AM, Stefan Berger wrote: > Signed-off-by: Stefan Berger > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake > > diff --git a/MAINTAINERS b/MAINTAINERS > index f8deaf6..d352d16 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1593,6 +1593

Re: [Qemu-devel] [PATCH v6 18/23] sev: emit the SEV_MEASUREMENT event

2018-02-02 Thread Brijesh Singh
On 02/01/2018 11:27 AM, Dr. David Alan Gilbert wrote: * Brijesh Singh (brijesh.si...@amd.com) wrote: On 1/30/18 2:08 PM, Dr. David Alan Gilbert wrote: * Brijesh Singh (brijesh.si...@amd.com) wrote: During machine creation we encrypted the guest bios image, the LAUNCH_MEASURE command can be

[Qemu-devel] How to make memory mapped controller receive data?

2018-02-02 Thread Fangda Cai
Hi, I have built a virtual arm board that includes onboard memory-mapped SPI controller and CAN controller. I also built a bare metal program that can run on the virtual arm board. Is it possible to make the SPI/CAN receive data during the bare-metal program running on the board? I don't know how t

Re: [Qemu-devel] [PATCH v1 06/21] RISC-V FPU Support

2018-02-02 Thread Michael Clark
On Mon, Jan 29, 2018 at 12:33 PM, Jim Wilson wrote: > On Wed, Jan 24, 2018 at 3:47 PM, Richard Henderson > wrote: > > On 01/24/2018 10:58 AM, Jim Wilson wrote: > >> Although, looking at this again, I see another statement in a > >> different place that says: > >> > >> Except when otherwise state

Re: [Qemu-devel] [PATCH v3 02/12] vl: deprecate -alt-grab and -ctrl-grab

2018-02-02 Thread Eric Blake
On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > vl.c | 8 > qemu-doc.texi | 6 ++ > 2 files changed, 14 insertions(+) > > case QEMU_OPTION_ctrl_grab: > +g_printerr("The -ctrl-grab switch is deprecated, and wi

Re: [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

2018-02-02 Thread Eric Blake
On 02/02/2018 08:50 AM, Eduardo Habkost wrote: > (CCing qemu-devel) > > On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: >> On Fri, 2 Feb 2018 14:19:38 + >> Daniel P. Berrangé wrote: >>> On Fri, Feb 02, 2018 at 12:15:54PM -0200, Eduardo Habkost wrote: > [...] It would be

Re: [Qemu-devel] [PATCH v4 0/5] coroutine-lock: polymorphic CoQueue

2018-02-02 Thread Fam Zheng
On Fri, Feb 2, 2018 at 6:01 AM, wrote: > === OUTPUT BEGIN === > Checking PATCH 1/5: test-coroutine: add simple CoMutex test... > ERROR: do not initialise statics to 0 or NULL > #30: FILE: tests/test-coroutine.c:198: > +static bool locked = false; > > total: 1 errors, 0 warnings, 74 lines checked

Re: [Qemu-devel] [PATCH V9 3/4] pvrdma: initial implementation

2018-02-02 Thread Dotan Barak via Qemu-devel
Reviewed-by: Dotan Barak From: Marcel Apfelbaum To: qemu-devel@nongnu.org Cc: ehabk...@redhat.com; yuval.sh...@oracle.com; mar...@redhat.com; pbonz...@redhat.com; m...@redhat.com; coh...@redhat.com; dotan...@yahoo.com Sent: Thursday, February 1, 2018 10:55 PM Subject: [Qemu-devel] [PA

Re: [Qemu-devel] [PATCH v6 18/23] sev: emit the SEV_MEASUREMENT event

2018-02-02 Thread Daniel P . Berrangé
On Fri, Feb 02, 2018 at 09:11:41AM -0600, Brijesh Singh wrote: > > > On 02/01/2018 11:27 AM, Dr. David Alan Gilbert wrote: > > * Brijesh Singh (brijesh.si...@amd.com) wrote: > > > > > > > > > On 1/30/18 2:08 PM, Dr. David Alan Gilbert wrote: > > > > * Brijesh Singh (brijesh.si...@amd.com) wrote

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: add missing break in h_get_cpu_characteristics()

2018-02-02 Thread Daniel Henrique Barboza
On 02/02/2018 08:00 AM, Greg Kurz wrote: On Fri, 2 Feb 2018 07:11:08 -0200 Daniel Henrique Barboza wrote: On 02/01/2018 05:47 PM, Greg Kurz wrote: Detected by Coverity (CID 1385702). This fixes the recently added hypercall to let guests properly apply Spectre and Meltdown workarounds. Paol

Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling

2018-02-02 Thread Cornelia Huck
On Fri, 2 Feb 2018 10:43:18 +0100 Christian Borntraeger wrote: > On 02/02/2018 10:42 AM, Christian Borntraeger wrote: > > commit 67915de9f038 ("s390x/event-facility: variable-length event > > masks") switches the sclp receive/send mask. This broke the sclp > > lm console. Hum. Probably should ad

Re: [Qemu-devel] [PATCH v2] block: maintain persistent disabled bitmaps

2018-02-02 Thread Vladimir Sementsov-Ogievskiy
31.01.2018 22:04, Max Reitz wrote: On 2018-01-29 19:43, Max Reitz wrote: On 2018-01-22 11:41, Vladimir Sementsov-Ogievskiy wrote: To maintain load/store disabled bitmap there is new approach: - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored - store enabled bitmaps as "

[Qemu-devel] [PULL 1/2] hw/audio/wm8750: move WM8750 declarations from i2c/i2c.h to audio/wm8750.h

2018-02-02 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé while here use TYPE_WM8750 and declare a data_req_cb() typedef. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20170919123053.32675-1-f4...@amsat.org Signed-off-by: Gerd Hoffmann --- include/hw/audio/wm8750.h | 30 ++ include/hw/i2c

[Qemu-devel] [PATCH] hw/timer/mt48t59: Fix bit-rotten NVRAM_PRINTF format strings

2018-02-02 Thread Thomas Huth
When compiling with NVRAM_PRINTF enabled, gcc currently bails out with: CC hw/timer/m48t59.o CC hw/timer/m48t59-isa.o hw/timer/m48t59.c: In function ‘NVRAM_writeb’: hw/timer/m48t59.c:460:5: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘hwaddr’

Re: [Qemu-devel] Qemu Trace

2018-02-02 Thread Stefan Hajnoczi
On Thu, Feb 01, 2018 at 04:30:10PM +0100, Nesrine Zouari wrote: > I am a computer engineering student and I am actually working on my > graduation project at Lauterbach company. The project is about Qemu Trace > and as a future I would like to contribute this work to the main line. > > My project

Re: [Qemu-devel] [PATCH v3 03/12] vl: rename DisplayType to LegacyDisplayType

2018-02-02 Thread Eric Blake
On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > qapi DisplayType will replace the current enum. For the transition both > will coexist though, so rename it so we don't have a name clash. > > Signed-off-by: Gerd Hoffmann > --- > vl.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions

Re: [Qemu-devel] [PULL 0/1] Dump patches

2018-02-02 Thread Peter Maydell
On 1 February 2018 at 11:16, Marc-André Lureau wrote: > The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: > > Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into > staging (2018-01-31 15:50:29 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH RFC 01/21] qapi: Streamline boilerplate comment generation

2018-02-02 Thread Eric Blake
On 02/02/2018 07:03 AM, Markus Armbruster wrote: > Every generator has separate boilerplate for .h and .c, and their > differences are boring. All of them repeat the license note. > > Reduce the repetition as follows. Move common text like the license > note to common open_output(), next to the

Re: [Qemu-devel] [PATCH v3 17/39] qcow2: Update l2_allocate() to support L2 slices

2018-02-02 Thread Alberto Garcia
On Thu 01 Feb 2018 07:15:23 PM CET, Max Reitz wrote: -static int l2_allocate(BlockDriverState *bs, int l1_index, uint64_t **table) +static int l2_allocate(BlockDriverState *bs, int l1_index) { BDRVQcow2State *s = bs->opaque; uint64_t old_l2_offset; -

Re: [Qemu-devel] [PATCH v2] block: maintain persistent disabled bitmaps

2018-02-02 Thread Max Reitz
On 2018-02-02 16:18, Vladimir Sementsov-Ogievskiy wrote: > 31.01.2018 22:04, Max Reitz wrote: >> On 2018-01-29 19:43, Max Reitz wrote: >>> On 2018-01-22 11:41, Vladimir Sementsov-Ogievskiy wrote: To maintain load/store disabled bitmap there is new approach:   - deprecate @autoload fl

Re: [Qemu-devel] [PATCH v3 31/39] qcow2: Update qcow2_truncate() to support L2 slices

2018-02-02 Thread Alberto Garcia
On Thu 01 Feb 2018 08:46:46 PM CET, Max Reitz wrote: >> @@ -3261,8 +3261,9 @@ static int qcow2_truncate(BlockDriverState *bs, >> int64_t offset, >> guest_offset = old_length; >> while (nb_new_data_clusters) { >> int64_t guest_cluster = guest_offset >> s->cluster_bit

Re: [Qemu-devel] [PATCH v6 13/23] hmp: display memory encryption support in 'info kvm'

2018-02-02 Thread Dr. David Alan Gilbert
* Brijesh Singh (brijesh.si...@amd.com) wrote: > > > On 2/2/18 7:08 AM, Daniel P. Berrangé wrote: > > On Thu, Feb 01, 2018 at 08:04:43PM +, Dr. David Alan Gilbert wrote: > >> * Brijesh Singh (brijesh.si...@amd.com) wrote: > >>> > >>> On 2/1/18 11:58 AM, Dr. David Alan Gilbert wrote: > *

Re: [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

2018-02-02 Thread Daniel P . Berrangé
On Fri, Feb 02, 2018 at 12:50:14PM -0200, Eduardo Habkost wrote: > (CCing qemu-devel) > > On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: > > On Fri, 2 Feb 2018 14:19:38 + > > Daniel P. Berrangé wrote: > > > On Fri, Feb 02, 2018 at 12:15:54PM -0200, Eduardo Habkost wrote: > [

[Qemu-devel] [PATCH RFC 06/21] qapi-gen: New common driver for code and doc generators

2018-02-02 Thread Markus Armbruster
Whenever qapi-schema.json changes, we run six programs eleven times to update eleven files. This is silly. Replace the six programs by a single program that spits out all eleven files. Signed-off-by: Markus Armbruster --- Makefile | 86 ++--

Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling

2018-02-02 Thread Cornelia Huck
On Fri, 2 Feb 2018 11:33:01 +0100 Cornelia Huck wrote: > On Fri, 2 Feb 2018 10:43:18 +0100 > Christian Borntraeger wrote: > > > On 02/02/2018 10:42 AM, Christian Borntraeger wrote: > > > commit 67915de9f038 ("s390x/event-facility: variable-length event > > > masks") switches the sclp receive/

Re: [Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

2018-02-02 Thread Wei Wang
On 02/02/2018 01:08 AM, Michael S. Tsirkin wrote: On Tue, Jan 30, 2018 at 08:09:19PM +0800, Wei Wang wrote: Issues: Suppose we have both the vhost and virtio-net set up, and vhost pmd <-> virtio-net pmd communication works well. Now, vhost pmd exits (virtio-net pmd is still there). Some time lat

Re: [Qemu-devel] [PATCH v3 17/39] qcow2: Update l2_allocate() to support L2 slices

2018-02-02 Thread Alberto Garcia
On Thu 01 Feb 2018 07:22:16 PM CET, Max Reitz wrote: > On 2018-02-01 16:43, Alberto Garcia wrote: >> On Thu 01 Feb 2018 04:23:09 PM CET, Anton Nefedov wrote: > However, I'm wondering whether this is the best approach. The old > L2 table is probably not going to be used after this function,

[Qemu-devel] [PATCH RFC 03/21] qapi: New classes QAPIGenC, QAPIGenH, QAPIGenDoc

2018-02-02 Thread Markus Armbruster
These classes encapsulate accumulating and writing output. Convert C code generation to QAPIGenC and QAPIGenH. The conversion is rather shallow: most of the output accumulation is not converted. Left for later. The indentation machinery uses a single global variable indent_level, even though we

Re: [Qemu-devel] [PATCH v3 21/39] qcow2: Update qcow2_alloc_cluster_link_l2() to support L2 slices

2018-02-02 Thread Alberto Garcia
On Thu 01 Feb 2018 07:44:56 PM CET, Max Reitz wrote: > On 2018-01-26 15:59, Alberto Garcia wrote: >> There's a loop in this function that iterates over the L2 entries in a >> table, so now we need to assert that it remains within the limits of >> an L2 slice. >> >> Apart from that, this function

Re: [Qemu-devel] [PATCH v3 27/39] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices

2018-02-02 Thread Alberto Garcia
On Thu 01 Feb 2018 08:26:26 PM CET, Max Reitz wrote: >> @@ -1273,12 +1276,13 @@ int qcow2_update_snapshot_refcount(BlockDriverState >> *bs, >> case QCOW2_CLUSTER_NORMAL: >> case QCOW2_CLUSTER_ZERO_ALLOC: >> if (offset_into_cluster

[Qemu-devel] [PATCH RFC 13/21] qapi: Record 'include' directives in parse tree

2018-02-02 Thread Markus Armbruster
The parse tree is a list of expressions. Except include expressions currently get replaced by the included file's parse tree. Instead of throwing away the include expression, keep it with the file name expanded so you don't have to track the including file's directory to make sense of it. A futu

[Qemu-devel] [PATCH RFC 14/21] qapi: Generate in source order

2018-02-02 Thread Markus Armbruster
The generators' conversion to visitors (merge commit 9e72681d16) changed the processing order of entities from source order to alphabetical order. The next commit needs source order, so change it back. Signed-off-by: Markus Armbruster --- scripts/qapi/common.py | 4 +- tests

[Qemu-devel] [PATCH RFC 02/21] qapi: Generate up-to-date copyright notice

2018-02-02 Thread Markus Armbruster
Each generator carries a copyright notice for the generator itself, and another one for the files it generates. Only the former have been updated along the way, the latter have not, and are all out of date. Fix by copying the generator's copyright notice to the generated files instead. Signed-of

Re: [Qemu-devel] [PATCH v2] block: maintain persistent disabled bitmaps

2018-02-02 Thread Vladimir Sementsov-Ogievskiy
02.02.2018 18:23, Max Reitz wrote: On 2018-02-02 16:18, Vladimir Sementsov-Ogievskiy wrote: 31.01.2018 22:04, Max Reitz wrote: On 2018-01-29 19:43, Max Reitz wrote: On 2018-01-22 11:41, Vladimir Sementsov-Ogievskiy wrote: To maintain load/store disabled bitmap there is new approach:   - dep

[Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

2018-02-02 Thread Markus Armbruster
Error messages print absolute filenames of included files even gave a relative one on the command line: PYTHONPATH=scripts python -B tests/qapi-schema/test-qapi.py tests/qapi-schema/include-cycle.json In file included from tests/qapi-schema/include-cycle.json:1: In file included from

Re: [Qemu-devel] [PATCH v3 24/39] qcow2: Update discard_single_l2() to support L2 slices

2018-02-02 Thread Alberto Garcia
On Thu 01 Feb 2018 08:07:15 PM CET, Max Reitz wrote: > On 2018-01-26 15:59, Alberto Garcia wrote: >> discard_single_l2() limits the number of clusters to be discarded to >> the amount that fits inside an L2 table. Since we'll be loading L2 >> slices instead of full tables we need to update that li

[Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code

2018-02-02 Thread Markus Armbruster
Our qapi-schema.json is composed of modules connected by include directives, but the generated code is monolithic all the same: one qapi-types.h with all the types, one qapi-visit.h with all the visitors, and so forth. These monolithic headers get included all over the place. In my "build everyhi

[Qemu-devel] [PULL 1/3] ui: fix mixup between qnum and qcode in SDL1 key handling

2018-02-02 Thread Gerd Hoffmann
From: Daniel P. Berrangé The previous commit: commit 2ec78706d188df7d3dab43d07b19b05ef7800a44 Author: Daniel P. Berrange Date: Wed Jan 17 16:47:15 2018 + ui: convert GTK and SDL1 frontends to keycodemapdb changed the x_keymap.c keymap so that its target was qcodes instead of q

[Qemu-devel] [PATCH RFC 07/21] qapi: Move parse_command_line() next to its only use

2018-02-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi-gen.py| 52 +++- scripts/qapi/common.py | 54 -- 2 files changed, 51 insertions(+), 55 deletions(-) diff --git a/scripts/qapi-gen.py b/scripts/qapi-ge

[Qemu-devel] [PATCH RFC 12/21] qapi: Concentrate QAPISchemaParser.exprs updates in .__init__()

2018-02-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi/common.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index d334e1db5a..7a327bfe9f 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@ -286,8 +

[Qemu-devel] [PATCH RFC 01/21] qapi: Streamline boilerplate comment generation

2018-02-02 Thread Markus Armbruster
Every generator has separate boilerplate for .h and .c, and their differences are boring. All of them repeat the license note. Reduce the repetition as follows. Move common text like the license note to common open_output(), next to the existintg common text there. For each generator, replace th

Re: [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

2018-02-02 Thread Eduardo Habkost
On Fri, Feb 02, 2018 at 03:07:18PM +, Daniel P. Berrangé wrote: > On Fri, Feb 02, 2018 at 12:50:14PM -0200, Eduardo Habkost wrote: > > (CCing qemu-devel) > > > > On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: > > > On Fri, 2 Feb 2018 14:19:38 + > > > Daniel P. Berrangé w

[Qemu-devel] [PATCH RFC 04/21] qapi: Reduce use of global variables in generators some

2018-02-02 Thread Markus Armbruster
In preparation of the next commit, which will turn the generators into modules. These global variables will become local to main() then. Signed-off-by: Markus Armbruster --- scripts/qapi-commands.py | 9 + scripts/qapi-event.py | 15 +++ scripts/qapi-introspect.py |

[Qemu-devel] [PATCH RFC 19/21] qapi/types: Generate separate .h, .c for each module

2018-02-02 Thread Markus Armbruster
Our qapi-schema.json is composed of modules connected by include directives, but the generated code is monolithic all the same: one qapi-types.h with all the types, one qapi-visit.h with all the visitors, and so forth. These monolithic headers get included all over the place. In my "build everyth

  1   2   3   >