Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-03-16 Thread Su Hang
Because I generate my first patch on master, it should work. I have a little trouble understanding what Mr.Peter wants me to do, would you please spare a little of your time and have a look at it? It will help me. Please... Su Hang > -Original Messages- > From: "Fam Zheng"

[Qemu-devel] [PATCH v2] Add udmabuf misc device

2018-03-16 Thread Gerd Hoffmann
A driver to let userspace turn iovecs into dma-bufs. Use case: Allows qemu create dmabufs for the vga framebuffer or virtio-gpu ressources. Then they can be passed around to display those guest things on the host. To spice client for classic full framebuffer display, and hopefully some day to

Re: [Qemu-devel] [PATCH v2] Add udmabuf misc device

2018-03-16 Thread Greg KH
On Fri, Mar 16, 2018 at 08:46:49AM +0100, Gerd Hoffmann wrote: > --- /dev/null > +++ b/drivers/dma-buf/udmabuf.c > @@ -0,0 +1,261 @@ > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + *

Re: [Qemu-devel] [PATCH] virtio_net: flush uncompleted TX on reset

2018-03-16 Thread Jason Wang
On 2018年03月08日 02:57, Greg Kurz wrote: If the backend could not transmit a packet right away for some reason, the packet is queued for asynchronous sending. The corresponding vq element is tracked in the async_tx.elem field of the VirtIONetQueue, for later freeing when the transmission is

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-16 Thread Xiao Guangrong
Hi David, Thanks for your review. On 03/15/2018 06:25 PM, Dr. David Alan Gilbert wrote: migration/ram.c | 32 Hi, Do you have some performance numbers to show this helps? Were those taken on a normal system or were they taken with one of the

Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-03-16 Thread Fam Zheng
On Fri, 03/16 10:58, Su Hang wrote: > (Sorry, I don't know this patch should base on which commit, > so I generate this patch based on > commit:fb8446d94ec7a3dc0c3a7e7da672406476f075ac, > I choose this by `git log -2 scripts/checkpath.pl`. > Sincerely say sorry, if I have misunderstand any

Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-03-16 Thread Fam Zheng
On Fri, 03/16 14:31, Su Hang wrote: > Because I generate my first patch on master, it should work. Nope. "git am" doesn't know to resolve the conflict automatically despite it being straightforward, unfortunately:

Re: [Qemu-devel] SSD virtio-scsi passthrough

2018-03-16 Thread Fam Zheng
On Mon, Mar 12, 2018 at 4:16 PM, Nitin Gupta wrote: > Hi Stefan > > Thanks for your response , i tried the the command provided by you and it > did not work as well > somehow i find that after changing the controller to LSI in qemu command > it started working ,

[Qemu-devel] [PATCH for-2.13 v3 2/2] tests: Use query-usernet instead of 'info usernet'

2018-03-16 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 686d88decf..f51604e0ab 100755 --- a/tests/vm/basevm.py +++

[Qemu-devel] [PATCH for-2.13 v3 1/2] slirp: Add "query-usernet" QMP command

2018-03-16 Thread Fam Zheng
HMP "info usernet" has been available but it isn't ideal for programmed use cases. This closes the gap in QMP by adding a counterpart "query-usernet" command. It is basically translated from the HMP slirp_connection_info() loop, which now calls the QMP implementation and prints the data, just like

[Qemu-devel] [PATCH for-2.13 v3 0/2] slirp: Add query-usernet QMP command

2018-03-16 Thread Fam Zheng
v3: - Add Eric's rev-by to patch 2. - Address Eric's comments on patch 1: * Fix spell/grammar: "programmed", "awaiting". * Fix include "qapi/qapi-commands-net.h". * Underscores to dashes. * "Since 2.13" now. v2: Fix compiler error. [patchew] The command is a

Re: [Qemu-devel] Using new TCG Vector infrastructure in PowerPC

2018-03-16 Thread Richard Henderson
On 03/16/2018 12:08 PM, Nikunj A Dadhania wrote: > @@ -1078,8 +1079,8 @@ struct CPUPPCState { > /* Altivec registers */ > ppc_avr_t avr[32]; > uint32_t vscr; > -/* VSX registers */ > -uint64_t vsr[32]; > +/* 32 (128bit)- VSX registers */ > +ppc_avr_t vsr[32];

Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-03-16 Thread Su Hang
Thanks for your reply! I'm glad to understand where problem lies. Su Hang > -Original Messages- > From: "Fam Zheng" > Sent Time: 2018-03-16 15:08:19 (Friday) > To: "Su Hang" > Cc: peter.mayd...@linaro.org, vsement...@virtuozzo.com,

Re: [Qemu-devel] [PATCH v2] Add udmabuf misc device

2018-03-16 Thread Greg KH
On Fri, Mar 16, 2018 at 08:46:49AM +0100, Gerd Hoffmann wrote: > --- /dev/null > +++ b/tools/testing/selftests/drivers/dma-buf/udmabuf.c > @@ -0,0 +1,69 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include No license text at all? Come on, I already made

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions are not being interpreted by the firmware, then

Re: [Qemu-devel] SSD virtio-scsi passthrough

2018-03-16 Thread Nitin Gupta
Vm just hang in Escape character , there is no error ..but from the qemu control window i am able to see sdc is passthrough Regards Nitin On Fri, Mar 16, 2018 at 1:16 PM, Fam Zheng wrote: > On Mon, Mar 12, 2018 at 4:16 PM, Nitin Gupta > wrote: > >

Re: [Qemu-devel] [PATCH 2/8] migration: stop allocating and freeing memory frequently

2018-03-16 Thread Xiao Guangrong
On 03/15/2018 07:03 PM, Dr. David Alan Gilbert wrote: +static int compress_threads_load_setup(void) +{ +int i, thread_count; + +if (!migrate_use_compression()) { +return 0; +} + +thread_count = migrate_decompress_threads(); +decompress_threads = g_new0(QemuThread,

Re: [Qemu-devel] [PULL v2 0/9] Socket next patches

2018-03-16 Thread Peter Maydell
On 13 March 2018 at 18:12, Daniel P. Berrangé wrote: > The following changes since commit 59667bb167f773965ce6547352f312eff0d4d523: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2018-03-13 14:02:47 +) > > are available

[Qemu-devel] [PATCH 1/4] hw/net/can: Fix segfaults when using the devices without bus

2018-03-16 Thread Thomas Huth
The CAN devices can currently be used to crash QEMU, e.g.: $ x86_64-softmmu/qemu-system-x86_64 -device kvaser_pci Segmentation fault (core dumped) So we've got to add a proper check here that the corresponding bus is available. Signed-off-by: Thomas Huth ---

[Qemu-devel] [PATCH 3/4] hw/audio: Fix crashes when devices are used on ISA bus without DMA

2018-03-16 Thread Thomas Huth
The cs4231a, gus and sb16 sound cards crash QEMU when the user tries to instantiate them on a machine with DMA-less ISA bus (for example with "qemu-system-mips64el -M mips -device sb16"). Add proper checks to the realize functions to avoid the crashes. Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH for-2.12 0/4] Fix crashes with CAN bus and ISA DMA devices

2018-03-16 Thread Thomas Huth
The new CAN bus devices and some older ISA devices that use DMA can be used to crash QEMU. These patches introduce some proper checks so that the users get a proper error message instead. Alexey Kardashevskiy (1): fdc: Exit if ISA controller does not support DMA Thomas Huth (3): hw/net/can:

[Qemu-devel] [PATCH 2/4] fdc: Exit if ISA controller does not support DMA

2018-03-16 Thread Thomas Huth
From: Alexey Kardashevskiy A "powernv" machine type defines an ISA bus but it does not add any DMA controller to it so it is possible to hit assert(fdctrl->dma) by adding "-machine powernv -device isa-fdc". This replaces assert() with an error message. Signed-off-by: Alexey

[Qemu-devel] [PATCH 4/4] scripts/device-crash-test: Remove fixed isapc-with-iommu entry

2018-03-16 Thread Thomas Huth
Fixed in a0c167a18470831e359f0538c3cf67907808f13e ("x86_iommu: check if machine has PCI bus"). Signed-off-by: Thomas Huth --- scripts/device-crash-test | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index

Re: [Qemu-devel] [PATCH] virtio_net: flush uncompleted TX on reset

2018-03-16 Thread Greg Kurz
On Fri, 16 Mar 2018 16:05:17 +0800 Jason Wang wrote: > On 2018年03月08日 02:57, Greg Kurz wrote: > > If the backend could not transmit a packet right away for some reason, > > the packet is queued for asynchronous sending. The corresponding vq > > element is tracked in the

Re: [Qemu-devel] [PATCH v3 7/7] s390: doc: detailed specifications for AP virtualization

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:25, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak

Re: [Qemu-devel] [PATCH for-2.12 0/4] Fix crashes with CAN bus and ISA DMA devices

2018-03-16 Thread Paolo Bonzini
On 16/03/2018 10:51, Thomas Huth wrote: > The new CAN bus devices and some older ISA devices that use DMA can be > used to crash QEMU. These patches introduce some proper checks so that > the users get a proper error message instead. > > Alexey Kardashevskiy (1): > fdc: Exit if ISA controller

Re: [Qemu-devel] [PATCH] docker: fedora: test more components

2018-03-16 Thread Paolo Bonzini
On 16/03/2018 10:43, Daniel P. Berrangé wrote: >> I wonder if we should simply do "dnf build-dep qemu" and only list additional >> (mingw, for example) packages explicitly, like the debian dockerfiles. > From an upstream POV it feels wrong to have our builds depend on the state > of stuff listed

Re: [Qemu-devel] [PATCH v3 2/7] s390x/ap: base Adjunct Processor (AP) object

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 38 ++

[Qemu-devel] [PATCH] linux-user: Allocate extra space for brk in PIE executable

2018-03-16 Thread Richard Henderson
Limit this to 16M; there does not appear to be any special support for this in the kernel itself, at least for i686. Fixes: https://bugs.launchpad.net/bugs/1749393 Signed-off-by: Richard Henderson --- Commentary in the launchpad bug suggests 128M gap for x86_64,

Re: [Qemu-devel] [PATCH v3 4/7] s390x/kvm: interface to interpret AP instructions

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: The VFIO AP device exploits interpretive execution of AP instructions (APIE). APIE is enabled by setting a device attribute via the KVM_SET_DEVICE_ATTR ioctl. Signed-off-by: Tony Krowiak --- target/s390x/kvm.c | 16

Re: [Qemu-devel] [PATCH v8 1/9] mirror: inherit supported write/zero flags

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:50 AM CET, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov > --- > block/mirror.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/block/mirror.c b/block/mirror.c > index f5bf620..2fb786f 100644 > --- a/block/mirror.c

Re: [Qemu-devel] [PATCH v3 4/7] s390x/kvm: interface to interpret AP instructions

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: The VFIO AP device exploits interpretive execution of AP instructions (APIE). APIE is enabled by setting a device attribute via the KVM_SET_DEVICE_ATTR ioctl. Signed-off-by: Tony Krowiak --- target/s390x/kvm.c | 16

Re: [Qemu-devel] [PATCH v3 2/7] s390x/ap: base Adjunct Processor (AP) object

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 38 ++

Re: [Qemu-devel] [PATCH v8 3/9] quorum: set supported write/zero flags

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:52 AM CET, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= The mediated matrix device is created by the VFIO AP device driver by writing a UUID to a sysfs attribute file (see

Re: [Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device

2018-03-16 Thread Thomas Huth
On 27.11.2017 09:40, Eduardo Otubo wrote: > On Fri, Nov 24, 2017 at 06:44:59PM +0100, Thomas Huth wrote: >> Hi Eduardo, >> >> On 24.11.2017 14:46, Eduardo Otubo wrote: >>> v3: >>> * Removed all unecessary local_err >>> * Change return of isa_bus_dma() and DMA_init() from void to int8_t, >>>

Re: [Qemu-devel] [PATCH] gtk: drop pointless code from gd_window_close

2018-03-16 Thread Mark Cave-Ayland
On 15/03/18 11:35, Philippe Mathieu-Daudé wrote: On 03/14/2018 09:04 AM, Gerd Hoffmann wrote: Unregistering the display change listener looks like a pointless excercise given we'll exit in a moment. When exiting qemu via exercise menu/file/quit this will not happen either. Just drop the

Re: [Qemu-devel] [PATCH v2 0/3] Add new CD-ROM related qtests

2018-03-16 Thread Mark Cave-Ayland
On 16/03/18 05:39, Thomas Huth wrote: With one of my clean-up patches (see commit 1454509726719e0933c800), I recently accidentially broke the "-cdrom" parameter (more precisely "-drive if=scsi") on a couple of boards, since there was no error detected during the "make check" regression testing.

Re: [Qemu-devel] [PATCH v8 4/9] block: introduce BDRV_REQ_ALLOCATE flag

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:53 AM CET, Anton Nefedov wrote: > The flag is supposed to indicate that the region of the disk image has > to be sufficiently allocated so it reads as zeroes. > > The call with the flag set must return -ENOTSUP if allocation cannot > be done efficiently. > This has to be

Re: [Qemu-devel] [PATCH v8 7/9] block: support BDRV_REQ_ALLOCATE in passthrough drivers

2018-03-16 Thread Alberto Garcia
On Mon 12 Mar 2018 11:16:56 AM CET, Anton Nefedov wrote: > Support the flag if the underlying BDS supports it > > Signed-off-by: Anton Nefedov > Reviewed-by: Alberto Garcia This is again not the patch that I reviewed (the quorum bits were not

Re: [Qemu-devel] [PULL 00/11] vfio updates for QEMU-2.12 soft freeze

2018-03-16 Thread Peter Maydell
On 13 March 2018 at 20:17, Alex Williamson wrote: > The following changes since commit 9f750794985d7386f088da941c76b73880b2b6c4: > > sev/i386: add sev_get_capabilities() (2018-03-13 17:36:06 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH] linux-user: Allocate extra space for brk in PIE executable

2018-03-16 Thread Peter Maydell
On 16 March 2018 at 10:34, Richard Henderson wrote: > Limit this to 16M; there does not appear to be any special > support for this in the kernel itself, at least for i686. > > Fixes: https://bugs.launchpad.net/bugs/1749393 > Signed-off-by: Richard Henderson

Re: [Qemu-devel] Using new TCG Vector infrastructure in PowerPC

2018-03-16 Thread Nikunj A Dadhania
Richard Henderson writes: > On 03/16/2018 12:08 PM, Nikunj A Dadhania wrote: >> @@ -1078,8 +1079,8 @@ struct CPUPPCState { >> /* Altivec registers */ >> ppc_avr_t avr[32]; >> uint32_t vscr; >> -/* VSX registers */ >> -uint64_t vsr[32]; >> +

Re: [Qemu-devel] [PATCH v3 3/7] s390x/cpumodel: Set up CPU model for AP device support

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP facilities are installed. This feature will be

Re: [Qemu-devel] [PATCH] i386: add KNM cpu model

2018-03-16 Thread Daniel P . Berrangé
On Fri, Mar 16, 2018 at 10:11:57AM +0800, Boqun Feng wrote: > On Wed, Mar 14, 2018 at 01:01:30PM +, Daniel P. Berrangé wrote: > > On Wed, Mar 14, 2018 at 03:29:59PM +0800, Boqun Feng wrote: > > > A new cpu model called "KNM" is added to model Knights Mill processors. > > > > Why the obscure

Re: [Qemu-devel] [PATCH v3 7/7] s390: doc: detailed specifications for AP virtualization

2018-03-16 Thread Pierre Morel
On 16/03/2018 00:25, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak

Re: [Qemu-devel] [PATCH v10 19/24] migration: Create multifd channels

2018-03-16 Thread Juan Quintela
Peter Xu wrote: > On Thu, Mar 15, 2018 at 01:57:54PM +0100, Juan Quintela wrote: >> Peter Xu wrote: >> > On Wed, Mar 07, 2018 at 12:00:05PM +0100, Juan Quintela wrote: >> >> In both sides. We still don't transmit anything through them. >> > >> > s/In/On/?

Re: [Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

2018-03-16 Thread Xiao Guangrong
On 03/15/2018 07:47 PM, Dr. David Alan Gilbert wrote: /* Check the pages is dirty and if it is send it */ if (migration_bitmap_clear_dirty(rs, pss->block, pss->page)) { +RAMBlock *block = pss->block; +ram_addr_t offset = pss->page << TARGET_PAGE_BITS; + +if

Re: [Qemu-devel] [PATCH 3/8] migration: support to detect compression and decompression errors

2018-03-16 Thread Xiao Guangrong
On 03/15/2018 07:29 PM, Dr. David Alan Gilbert wrote: @@ -1051,11 +1052,13 @@ static int do_compress_ram_page(QEMUFile *f, z_stream *stream, RAMBlock *block, { RAMState *rs = ram_state; int bytes_sent, blen; -uint8_t *p = block->host + (offset & TARGET_PAGE_MASK); +

Re: [Qemu-devel] [PATCH 4/8] migration: introduce control_save_page()

2018-03-16 Thread Xiao Guangrong
On 03/15/2018 07:37 PM, Dr. David Alan Gilbert wrote: * guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: From: Xiao Guangrong Abstract the common function control_save_page() to cleanup the code, no logic is changed Signed-off-by: Xiao Guangrong

Re: [Qemu-devel] [PATCH] net/vde: print error on vde_open() failure

2018-03-16 Thread Jason Wang
On 2018年03月16日 04:06, Julia Suvorova via Qemu-devel wrote: Despite the fact that now when the initialization of vde fails, qemu does not end silently, no informative error is printed. The patch generates an error and pushes it through the calling function. Related bug:

Re: [Qemu-devel] [RFC 0/3] target/m68k: fix TCGv array overflow

2018-03-16 Thread Laurent Vivier
Le 15/03/2018 à 20:34, Richard Henderson a écrit : > On 03/16/2018 03:19 AM, Laurent Vivier wrote: >> I try to fix this by introducing a new TCG function >> to try to free a TCGv if it is a temporary one and >> do nothing otherwise (patches 1 and 2) > > I would prefer not to approach this in this

Re: [Qemu-devel] [PATCH] docker: fedora: test more components

2018-03-16 Thread Daniel P . Berrangé
On Fri, Mar 16, 2018 at 10:40:23AM +0800, Fam Zheng wrote: > On Thu, 03/15 14:47, Daniel P. Berrangé wrote: > > On Tue, Mar 13, 2018 at 01:05:52PM +0100, Paolo Bonzini wrote: > > > Install optional dependencies of QEMU to get better coverage. > > > > > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v3 7/7] s390: doc: detailed specifications for AP virtualization

2018-03-16 Thread Tony Krowiak
On 03/16/2018 06:03 AM, Pierre Morel wrote: On 16/03/2018 00:25, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

2018-03-16 Thread Halil Pasic
On 03/16/2018 04:29 PM, Tony Krowiak wrote: >>> However it is a general switch for the VM. >>> It looks strange to have this inside the realize callback >>> >> I kind of semi agree. >> >> The previous solution (having this transparent for QEMU) had >> benefits. Why did we move away from that 

Re: [Qemu-devel] [PATCH] net/slirp: Convert atoi to qemu_strtoi to allow error checking

2018-03-16 Thread Samuel Thibault
Nia Alarie, on ven. 16 mars 2018 14:39:21 +, wrote: > Signed-off-by: Nia Alarie Applied to my tree, thanks! > --- > net/slirp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/net/slirp.c b/net/slirp.c > index 8991816bbf..e938944bd4 100644

Re: [Qemu-devel] [PULL 0/9] ppc-for-2.12 queue 20180315

2018-03-16 Thread Peter Maydell
On 15 March 2018 at 04:18, David Gibson wrote: > The following changes since commit 026aaf47c02b79036feb830206cfebb2a726510d: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/python-next-pull-request' into staging (2018-03-13 > 16:26:44 +) > > are

Re: [Qemu-devel] [PATCH 2/2] i386/kvm: lower requirements for Hyper-V frequency MSRs exposure

2018-03-16 Thread Paolo Bonzini
On 16/03/2018 16:40, Vitaly Kuznetsov wrote: >> On older kernel without re-enlightenment support, you don't want to >> expose the frequency MSRs unless invtsc is on, right? >> > Actually no, I think it's OK to expose frequency MSRs even when we don't > have invtsc and don't support

[Qemu-devel] [PATCH] gdbstub: send a terminaison packet instead of crashing gdb

2018-03-16 Thread KONRAD Frederic
Since the commit: commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 Author: Stefan Hajnoczi Date: Wed Mar 7 14:42:05 2018 + vl: introduce vm_shutdown() GDB crash when qemu exits (at least on sparc-softmmu): Remote communication error. Target disconnected.:

[Qemu-devel] [PATCH v2 2/2] i386/kvm: lower requirements for Hyper-V frequency MSRs exposure

2018-03-16 Thread Vitaly Kuznetsov
Requiring tsc_is_stable_and_known() is too restrictive: even without INVTCS nested Hyper-V-on-KVM enables TSC pages for its guests e.g. when Reenlightenment MSRs are present. Presence of frequency MSRs doesn't mean these frequencies are stable, it just means they're available for reading.

[Qemu-devel] [PATCH 2/2] docker: fedora: include more build dependencies

2018-03-16 Thread Paolo Bonzini
Install optional dependencies of QEMU to get better coverage. Signed-off-by: Paolo Bonzini --- tests/docker/dockerfiles/fedora.docker | 67 -- 1 file changed, 55 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH 1/2] docker: test-mingw: use SDL2 and GTK+3

2018-03-16 Thread Paolo Bonzini
Do not test the deprecated API versions. debian-win32-cross and debian-win64-cross are already using SDL2 (they do not cover GTK+ at all). Signed-off-by: Paolo Bonzini --- tests/docker/dockerfiles/fedora.docker | 8 tests/docker/test-mingw| 4 ++--

Re: [Qemu-devel] [PATCH 2/2] docker: fedora: include more build dependencies

2018-03-16 Thread Paolo Bonzini
On 16/03/2018 13:45, Daniel P. Berrangé wrote: > On Fri, Mar 16, 2018 at 01:25:40PM +0100, Paolo Bonzini wrote: >> Install optional dependencies of QEMU to get better coverage. >> >> Signed-off-by: Paolo Bonzini >> --- >> tests/docker/dockerfiles/fedora.docker | 67 >>

[Qemu-devel] [Bug 1435359] Re: Booting kernel 3.19.2 fails most of the time

2018-03-16 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1435101] Re: Windows, QEMU 2.2.50 fails to boot XP CD

2018-03-16 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] tpm-tis-test and tpm-crb-test crash on OSX

2018-03-16 Thread Marc-André Lureau
Hi On Fri, Mar 16, 2018 at 2:37 PM, Marc-André Lureau wrote: > Hi > > On Fri, Mar 16, 2018 at 2:27 PM, Daniel P. Berrangé > wrote: >> On Fri, Mar 16, 2018 at 01:24:53PM +, Peter Maydell wrote: >>> On 16 March 2018 at 13:12, Peter Maydell

Re: [Qemu-devel] tpm-tis-test and tpm-crb-test crash on OSX

2018-03-16 Thread Stefan Berger
On 03/16/2018 09:45 AM, Stefan Berger wrote: On 03/16/2018 09:41 AM, Marc-André Lureau wrote: Hi On Fri, Mar 16, 2018 at 2:37 PM, Marc-André Lureau wrote: Hi On Fri, Mar 16, 2018 at 2:27 PM, Daniel P. Berrangé wrote: On Fri, Mar 16, 2018

[Qemu-devel] [PULL 27/38] qmp: add new event "command-dropped"

2018-03-16 Thread Eric Blake
This event will be emitted if one QMP command is dropped. Also, declare an enum for the reasons. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu Message-Id: <20180309090006.10018-16-pet...@redhat.com>

Re: [Qemu-devel] [PATCH v3 2/7] s390x/ap: base Adjunct Processor (AP) object

2018-03-16 Thread Tony Krowiak
On 03/16/2018 06:38 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 38

Re: [Qemu-devel] tpm-tis-test and tpm-crb-test crash on OSX

2018-03-16 Thread Daniel P . Berrangé
On Fri, Mar 16, 2018 at 09:45:59AM -0400, Stefan Berger wrote: > On 03/16/2018 09:41 AM, Marc-André Lureau wrote: > > Hi > > > > On Fri, Mar 16, 2018 at 2:37 PM, Marc-André Lureau > > wrote: > > > Hi > > > > > > On Fri, Mar 16, 2018 at 2:27 PM, Daniel P. Berrangé

[Qemu-devel] [PATCH] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-03-16 Thread Wanpeng Li
From: Wanpeng Li This patch adds support for KVM_CAP_X86_DISABLE_EXITS. Provides userspace with per-VM capability(KVM_CAP_X86_DISABLE_EXITS) to not intercept MWAIT/HLT/PAUSE in order that to improve latency in some workloads. Cc: Paolo Bonzini Cc:

Re: [Qemu-devel] [PATCH v3 4/7] s390x/kvm: interface to interpret AP instructions

2018-03-16 Thread Tony Krowiak
On 03/16/2018 06:36 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: The VFIO AP device exploits interpretive execution of AP instructions (APIE). APIE is enabled by setting a device attribute via the KVM_SET_DEVICE_ATTR ioctl. Signed-off-by: Tony Krowiak

Re: [Qemu-devel] [PATCH v8 6/9] file-posix: support BDRV_REQ_ALLOCATE

2018-03-16 Thread Anton Nefedov
On 12/3/2018 1:16 PM, Anton Nefedov wrote: Current write_zeroes implementation is good enough to satisfy this flag too Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz strictly speaking this

Re: [Qemu-devel] [PATCH] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-03-16 Thread Paolo Bonzini
On 16/03/2018 15:58, Wanpeng Li wrote: >> WARNING: line over 80 characters >> #52: FILE: target/i386/kvm.c:1003: >> +int disable_exits = kvm_check_extension(cs->kvm_state, >> KVM_CAP_X86_DISABLE_EXITS); >> >> ERROR: line over 90 characters >> #58: FILE: target/i386/kvm.c:1009: >> +

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

2018-03-16 Thread Tony Krowiak
On 03/16/2018 09:22 AM, Halil Pasic wrote: On 03/16/2018 11:42 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= The mediated matrix device is

Re: [Qemu-devel] [PATCH 2/2] i386/kvm: lower requirements for Hyper-V frequency MSRs exposure

2018-03-16 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 16/03/2018 16:05, Vitaly Kuznetsov wrote: -if (has_msr_hv_frequencies && tsc_is_stable_and_known(env)) { +if (has_msr_hv_frequencies && env->tsc_khz) { >>> Should this be >>> >>> ((env->tsc_khz &&

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

2018-03-16 Thread Tony Krowiak
On 03/16/2018 11:36 AM, Halil Pasic wrote: On 03/16/2018 04:29 PM, Tony Krowiak wrote: However it is a general switch for the VM. It looks strange to have this inside the realize callback I kind of semi agree. The previous solution (having this transparent for QEMU) had benefits. Why did we

[Qemu-devel] [PATCH] tcg: fix cpu_io_recompile

2018-03-16 Thread Richard Henderson
We have confused the number of instructions that have been executed in the TB with the number of instructions needed to repeat the I/O instruction. We have used cpu_restore_state_from_tb, which means that the guest pc is pointing to the I/O instruction. The only time the answer to the later

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

2018-03-16 Thread Halil Pasic
On 03/16/2018 04:53 PM, Tony Krowiak wrote: > On 03/16/2018 11:36 AM, Halil Pasic wrote: >> >> On 03/16/2018 04:29 PM, Tony Krowiak wrote: > However it is a general switch for the VM. > It looks strange to have this inside the realize callback > I kind of semi agree.

Re: [Qemu-devel] [PULL 00/22] virtio, vhost, pci, pc: features, cleanups

2018-03-16 Thread Peter Maydell
On 13 March 2018 at 21:45, Michael S. Tsirkin wrote: > The following changes since commit 026aaf47c02b79036feb830206cfebb2a726510d: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/python-next-pull-request' into staging (2018-03-13 > 16:26:44 +) > > are available

[Qemu-devel] [PATCH v7 09/11] target/xtensa: add linux-user support

2018-03-16 Thread Max Filippov
Import list of syscalls from the kernel source. Conditionalize code/data that is only used with softmmu. Implement exception handlers. Implement signal hander (only the core registers for now, no coprocessors or TIE). Cc: Riku Voipio Cc: Laurent Vivier

Re: [Qemu-devel] [PATCH] gdbstub: send a terminaison packet instead of crashing gdb

2018-03-16 Thread Peter Maydell
On 16 March 2018 at 16:23, KONRAD Frederic wrote: > Since the commit: > commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 > Author: Stefan Hajnoczi > Date: Wed Mar 7 14:42:05 2018 + > > vl: introduce vm_shutdown() > > GDB crash when qemu

Re: [Qemu-devel] [PATCH v2] RISC-V: Fix riscv_isa_string, use popcount to count bits

2018-03-16 Thread Michael Clark
On Thu, Mar 15, 2018 at 12:27 PM, Peter Maydell wrote: > On 10 March 2018 at 21:25, Philippe Mathieu-Daudé wrote: > > On 03/09/2018 10:01 PM, Michael Clark wrote: > >> Logic bug caused the string size calculation for the RISC-V > >> format ISA string

Re: [Qemu-devel] [PATCH] net/vde: print error on vde_open() failure

2018-03-16 Thread Stefan Hajnoczi
On Thu, Mar 15, 2018 at 11:06:32PM +0300, Julia Suvorova wrote: > Despite the fact that now when the initialization of vde fails, qemu > does not end silently, no informative error is printed. The patch > generates an error and pushes it through the calling function. > > Related bug:

Re: [Qemu-devel] [virtio-dev] Re: [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-03-16 Thread Michael S. Tsirkin
On Tue, Jan 09, 2018 at 06:05:41PM +0100, Halil Pasic wrote: > > +\item[\field{max_cipher_key_len}] is the maximum length of cipher key > > supported by the device. > > I can't find what happens if this limit isn't honored by the driver. Moreover > reading it is only SHOULD. Is it undefined

Re: [Qemu-devel] qemu master build failure

2018-03-16 Thread Paolo Bonzini
On 16/03/2018 18:01, Andrew Jones wrote: > Hi Thomas, > > QEMU master is failing to build on an AArch64 machine with GCC 4.8. I get > > ... > CC qemu-nbd.o > /home/drjones/code/qemu/qemu-nbd.c: In function ‘version’: > /home/drjones/code/qemu/qemu-nbd.c:133:7: error: expected ‘)’ before

Re: [Qemu-devel] qemu master build failure

2018-03-16 Thread Peter Maydell
On 16 March 2018 at 17:11, Paolo Bonzini wrote: > On 16/03/2018 18:01, Andrew Jones wrote: >> Hi Thomas, >> >> QEMU master is failing to build on an AArch64 machine with GCC 4.8. I get >> >> ... >> CC qemu-nbd.o >> /home/drjones/code/qemu/qemu-nbd.c: In function

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

2018-03-16 Thread Tony Krowiak
On 03/16/2018 04:03 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions are

Re: [Qemu-devel] block-layer: questions on manipulation of internal nodes

2018-03-16 Thread Stefan Hajnoczi
On Wed, Mar 14, 2018 at 03:07:21PM +, Stefano Panella wrote: > Hi everybody, > > I am a relatively new user of qemu block layer. I am interested in it mainly > because it looks very powerful and general and I am hoping to integrate it on > our product and to contribute to it for new

[Qemu-devel] [Bug 1438572] Re: kvm does not support KVM_CAP_USER_MEMORY Please upgrade to at least kernel 2.6.29 or recent kvm-kmod (see http://sourceforge.net/projects/kvm)

2018-03-16 Thread Paolo Bonzini
This error has never existed in QEMU, only in the old qemu-kvm fork which has been obsolete for about 5 years. I'm closing this ticket. ** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [PATCH v2 0/2] i386/kvm: TSC page clocksource for Hyper-V-on-KVM fixes

2018-03-16 Thread Vitaly Kuznetsov
Changes since v1: - add vmstate_msr_hyperv_reenlightenment subsection to vmstate_x86_cpu [Paolo Bonzini] - rebase. Previously, Ladi was working on enabling TSC page clocksource for nested Hyper-V-on-KVM workloads. He found out that if Hyper-V frequency MSRs are exposed to L1 as well as INVTSC

[Qemu-devel] [PATCH v2 1/2] i386/kvm: add support for Hyper-V reenlightenment MSRs

2018-03-16 Thread Vitaly Kuznetsov
KVM recently gained support for Hyper-V Reenlightenment MSRs which are required to make KVM-on-Hyper-V enable TSC page clocksource to its guests when INVTSC is not passed to it (and it is not passed by default in Qemu as it effectively blocks migration). Signed-off-by: Vitaly Kuznetsov

[Qemu-devel] qemu master build failure

2018-03-16 Thread Andrew Jones
Hi Thomas, QEMU master is failing to build on an AArch64 machine with GCC 4.8. I get ... CC qemu-nbd.o /home/drjones/code/qemu/qemu-nbd.c: In function ‘version’: /home/drjones/code/qemu/qemu-nbd.c:133:7: error: expected ‘)’ before ‘QEMU_FULL_VERSION’ "%s " QEMU_FULL_VERSION "\n"

[Qemu-devel] [PATCH v3] RISC-V: Fix riscv_isa_string memory size bug

2018-03-16 Thread Michael Clark
This version uses a constant size memory buffer sized for the maximum possible ISA string length. It also uses g_new instead of g_new0, uses more efficient logic to append extensions and adds manual zero termination of the string. Cc: Palmer Dabbelt Cc: Peter Maydell

Re: [Qemu-devel] [PULL 00/13] Bitmaps patches

2018-03-16 Thread Vladimir Sementsov-Ogievskiy
Just note here too, that this relates to bug in checkpatch, work on fixing is in progress: https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg04651.html 14.03.2018 00:36, no-re...@patchew.org wrote: Hi, This series seems to have some coding style problems. See output below for more

[Qemu-devel] [PATCH 0/2] docker: update package list for fedora image

2018-03-16 Thread Paolo Bonzini
The first patch modernizes and completes the list of packages installed in the Fedora docker image. Both MinGW cross and native compilation are switched to SDL 2.0 and GTK+ 3.0. Paolo Paolo Bonzini (2): docker: test-mingw: use SDL2 and GTK+3 docker: fedora: include more build dependencies

Re: [Qemu-devel] [PATCH 1/2] docker: test-mingw: use SDL2 and GTK+3

2018-03-16 Thread Philippe Mathieu-Daudé
On 03/16/2018 01:25 PM, Paolo Bonzini wrote: > Do not test the deprecated API versions. debian-win32-cross and > debian-win64-cross > are already using SDL2 (they do not cover GTK+ at all). Good idea to start a doc/test/docker-coverage.txt with a matrix of configs tested (for example

Re: [Qemu-devel] [PATCH v2 0/3] Add new CD-ROM related qtests

2018-03-16 Thread Michael S. Tsirkin
On Fri, Mar 16, 2018 at 06:39:52AM +0100, Thomas Huth wrote: > With one of my clean-up patches (see commit 1454509726719e0933c800), I > recently accidentially broke the "-cdrom" parameter (more precisely > "-drive if=scsi") on a couple of boards, since there was no error > detected during the

[Qemu-devel] tpm-tis-test and tpm-crb-test crash on OSX

2018-03-16 Thread Peter Maydell
On OSX host, I noticed that tpm-tis-test and tpm-crb-test both crash on OSX, hitting an error_abort case: (lldb) run Process 65115 launched: '/Users/pm215/src/qemu-for-merges/build/all/tests/tpm-tis-test' (x86_64) /i386/tpm-tis/test_check_localities: OK /i386/tpm-tis/test_check_access_reg: OK

Re: [Qemu-devel] tpm-tis-test and tpm-crb-test crash on OSX

2018-03-16 Thread Daniel P . Berrangé
On Fri, Mar 16, 2018 at 02:37:16PM +0100, Marc-André Lureau wrote: > Hi > > On Fri, Mar 16, 2018 at 2:27 PM, Daniel P. Berrangé > wrote: > > On Fri, Mar 16, 2018 at 01:24:53PM +, Peter Maydell wrote: > >> On 16 March 2018 at 13:12, Peter Maydell

  1   2   3   >