Your e-mail From: header is messed up. Please fix.
root writes:
> From: Li Qiang
>
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-triv...@nongnu.org
>
> Signed-off-by: Li Qiang
> ---
> target/i386/hax-all.c | 15 +++
> 1 file changed, 3
On Mon, 5 Nov 2018 02:40:38 +0100
Samuel Ortiz wrote:
> This is the standard way of building SRAT on x86 platfoms. But future
> machine types could decide to define their own custom SRAT build method
> through the ACPI builder methods.
> Moreover, we will also need to reach build_srat() from
On 11/15/18 7:22 AM, Simon Ruderich wrote:
Hello again,
Please ignore v6, I forgot one patch. I hope I got it right this
time.
Our automated tooling doesn't spot patches sent in reply to an earlier
series; you may want to repost v7 as a new top-level thread (not
in-reply-to any earlier
Hello,
This time as a new thread to help patchew. The only change is to use the
correct next version.
Regards
Simon Ruderich
Simon Ruderich (7):
cpus: correct coding style in qmp_memsave/qmp_pmemsave
cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open
cpus: use size_t in
This enables completion for the filename arguments.
Suggested-by: Dr. David Alan Gilbert
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Simon Ruderich
---
hmp-commands.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index
On Wed 14 Nov 2018 06:24:10 PM CET, Max Reitz wrote:
>>> Permission system
>>> =
>>>
>>> GRAPH_MOD
>>> -
>>>
>>> We need some way for the commit job to prevent graph changes on its
>>> chain while it is running. Our current blocker doesn’t do the job,
>>> however. What to
On Thu, 15 Nov 2018 12:21:55 +0100
Cornelia Huck wrote:
> After a quick look, this seems fine; have not actually tried to run it
> yet.
Played a bit with it (with zpci devices for a s390x machine), seems to
work as expected.
On 11/15/18 9:15 AM, Erik Skultety wrote:
Since QEMU always picks the default DRI device, libvirt doesn't know which one
to put into the mount namespace and relabel it accordingly, hence hitting
permission issues, unless admin tweaks the default permissions of the DRI
devices.
On 11/15/18 3:35 PM, Peter Maydell wrote:
> An off-by-one error in a switch case in onenand_read() allowed
> a misbehaving guest to read off the end of a block of memory.
>
> NB: the onenand device is used only by the "n800" and "n810"
> machines, which are usable only with TCG, not KVM, so this
Daniel P. Berrangé writes:
> On Wed, Nov 14, 2018 at 04:36:02PM +0400, Marc-André Lureau wrote:
>> Hi,
>>
>> Based-on: https://people.debian.org/~sthibault/qemu.git/ slirp branch
>>
>> This series goal is to allow building libslirp as an independent library.
Marc-André, thanks for working on
On 2 November 2018 at 13:41, Richard Henderson
wrote:
> Provide a trivial implementation with zero limited ordering regions,
> which causes the LDLAR and STLLR instructions to devolve into the
> LDAR and STLR instructions from the base ARMv8.0 instruction set.
>
> Signed-off-by: Richard Henderson
On 15.11.18 14:17, Eric Blake wrote:
> On 11/15/18 5:09 AM, David Hildenbrand wrote:
>
>>> Three more: in qobject-input-visitor.c's
>>> qobject_input_type_number_keyval(),
>>
>> This one is interesting, as it properly bails out when parsing "inf"
>> (via isFinite()). - should we do the same for
Reviewed-by: Eric Blake
Signed-off-by: Simon Ruderich
---
cpus.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index a2b33ccb29..e67efbb58b 100644
--- a/cpus.c
+++ b/cpus.c
@@ -2394,8 +2394,9 @@ void qmp_memsave(int64_t addr, int64_t size, const char
The vhost-user-test is one of the most complex qtests in the tree,
and converting it to qgraph poses some unique challenges. This series
addresses them in a way that does not depend on the qgraph conversion
itself, but prepares for it.
First of all, vhost-user-test is slow and that is a pain
On 11/15/18 8:04 AM, David Hildenbrand wrote:
Let's use the new function. In order to do so, we have to convert all
users of qemu_strtosz*() to pass a "const char **end" ptr.
We will now also reject "inf" properly.
Signed-off-by: David Hildenbrand
---
include/qemu/cutils.h | 6 +++---
Update the onenand device to use qemu_log_mask() for reporting
guest errors and unimplemented features, rather than plain
fprintf() and hw_error().
(We leave the hw_error() in onenand_reset(), as that is
triggered by a failure to read the underlying block device
for the bootRAM, not by guest
On 15/11/18 15:35, Peter Maydell wrote:
An off-by-one error in a switch case in onenand_read() allowed
a misbehaving guest to read off the end of a block of memory.
NB: the onenand device is used only by the "n800" and "n810"
machines, which are usable only with TCG, not KVM, so this is
not a
EGL headless has been missing from QEMU's help or man page, we should
mention that such a thing exists, especially since projects like libvirt
might rely on that. This patch also adds the newly introduced option for
egl-headless 'rendernode'.
Signed-off-by: Erik Skultety
---
qemu-options.hx | 6
Eric Blake writes:
> On 11/15/18 8:04 AM, David Hildenbrand wrote:
>> Let's provide a wrapper for strtod().
>>
>> Signed-off-by: David Hildenbrand
>> ---
>> include/qemu/cutils.h | 2 ++
>> util/cutils.c | 38 ++
>> 2 files changed, 40
On Wed, 2018-11-14 at 21:38 -0200, Eduardo Habkost wrote:
> Many of the current virtio-*-pci device types actually represent
> 3 different types of devices:
> * virtio 1.0 non-transitional devices
> * virtio 1.0 transitional devices
> * virtio 0.9 ("legacy device" in virtio 1.0 terminology)
>
>
On 2 November 2018 at 13:41, Richard Henderson
wrote:
> At the same time, define the fields for these registers,
> and use those defines in arm_pamax().
>
> Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
thanks
-- PMM
Signed-off-by: Simon Ruderich
---
cpus.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index a2b33ccb29..e67efbb58b 100644
--- a/cpus.c
+++ b/cpus.c
@@ -2394,8 +2394,9 @@ void qmp_memsave(int64_t addr, int64_t size, const char
*filename,
while
On 15 November 2018 at 11:59, Laurent Vivier wrote:
> On 15/11/2018 12:46, Peter Maydell wrote:
>> Coverity complains (CID 1390847) about some dead code in
>> do_sigreturn(). This is an if (err) clause that can never be
>> true, copied from the kernel (where __get_user returns an error).
>> The
On 14 November 2018 at 16:55, Michael Roth wrote:
> Quoting Michael Roth (2018-11-09 10:13:52)
>> This is needed to build skiboot from tarball-distributed sources
>> since the git data the make_release.sh script relies on to generate
>> it is not available.
>>
>> Cc: qemu-sta...@nongnu.org
>>
qemu_open() allow passing file descriptors to qemu which is used in
restricted environments like libvirt where open() is prohibited.
Suggested-by: Eric Blake
Reviewed-by: Eric Blake
Signed-off-by: Simon Ruderich
---
cpus.c | 20 ++--
1 file changed, 10 insertions(+), 10
We now support virtual walks, so use that instead.
Signed-off-by: David Hildenbrand
---
tests/test-string-input-visitor.c | 36 +++
1 file changed, 12 insertions(+), 24 deletions(-)
diff --git a/tests/test-string-input-visitor.c
b/tests/test-string-input-visitor.c
On Wed, Aug 1, 2018 at 12:37 AM Guenter Roeck wrote:
>
> sd-card is currently listed as uncategorized device.
> Mark it as storage device.
>
> Signed-off-by: Guenter Roeck
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/sd/sd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
On Mon, Nov 12, 2018 at 07:42:20PM +0800, Peng Hao wrote:
> Add mmio support info in docs/specs/pvpanic.txt.
>
> Signed-off-by: Peng Hao
> ---
> docs/specs/pvpanic.txt | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/docs/specs/pvpanic.txt
The virt machine cannot run the vhost-user qtests because they hardcode
the presence of memory at address 0. Report the tests as a skip so that
they can be converted to use qgraph.
Signed-off-by: Paolo Bonzini
---
tests/vhost-user-test.c | 58 -
1 file
This makes the tests more independent, and also the source and destination
TestServers in the migration test.
Signed-off-by: Paolo Bonzini
---
tests/vhost-user-test.c | 75 +++--
1 file changed, 34 insertions(+), 41 deletions(-)
diff --git
An off-by-one error in a switch case in onenand_read() allowed
a misbehaving guest to read off the end of a block of memory.
NB: the onenand device is used only by the "n800" and "n810"
machines, which are usable only with TCG, not KVM, so this is
not a security issue.
Reported-by: Thomas Huth
On 15.11.18 15:37, Eric Blake wrote:
> On 11/15/18 8:04 AM, David Hildenbrand wrote:
>> Let's use the new function. "NaN" and "inf" are now properly rejected.
>>
>> Signed-off-by: David Hildenbrand
>> ---
>> qapi/string-input-visitor.c | 6 ++
>> 1 file changed, 2 insertions(+), 4
From: "Dr. David Alan Gilbert"
x86 doesn't need a 3.1 machine type, because there's no incompatibility,
but it looks odd not having one, especially since s390, ppc and ARM have
it. Join the party.
Signed-off-by: Dr. David Alan Gilbert
Suggested-by: Peter Maydell
---
hw/i386/pc_piix.c|
Am 15.11.2018 um 03:03 hat Eric Blake geschrieben:
> This change has no semantic impact: all drivers either leave the
> value at 0 (no inherent 32-bit limit is still translated into
> fragmentation below 2G; see the previous patch for that audit), or
> set it to a value less than 2G. However,
From: Aleksandar Markovic
Add Stefan Markovic as a MIPS reviewer. He had several key
contributions to QEMU for MIPS this year. He is a meticulous
person with the ability to think and act on many levels.
Signed-off-by: Aleksandar Markovic
---
MAINTAINERS | 9 +
1 file changed, 9
On 11/15/18 2:53 PM, Peter Maydell wrote:
>> switch (offset) {
>> -case 0x ... 0xc000:
>> +case 0x ... 0xbfff:
>> return lduw_le_p(s->boot[0] + addr);
>>
>> case 0xf000: /* Manufacturer ID */
>>
>> as the memory segment has size 0xc000.
>
> Presumably it
On 19 October 2018 at 09:55, Hongbo Zhang wrote:
> there are two commit reverts I have to do to boot system currently, these
> block not only my new 'sbsa-ref', but also the 'virt'.
> (other two workarounds can be ignored, they are just for temp using before
> firmware porting is fully
David Hildenbrand writes:
> Let's use the new function. "NaN" and "inf" are now properly rejected.
>
> Signed-off-by: David Hildenbrand
Whether this is a bug fix or just a change is debatable. But the commit
message's title should highlight the change. Perhaps you want to steal
from the one
On 11/15/18 8:04 AM, David Hildenbrand wrote:
Test that very big/small values are not accepted and that ranges with
only one element work.
Rename expect4 to expect5, as we will be moving that to a separate ulist
test after the rework.
Signed-off-by: David Hildenbrand
---
Adapted patch from Baojun Wang [1] with the following commit message:
I found this could be useful to have qemu-softmmu as a cross
debugger (launch with -s -S command line option), then if we can
have a command to load guest physical memory, we can use cross gdb
to do some target
i is only 32-bit. To prevent possible truncation when dumping large
memory regions use l which is target long.
Suggested-by: Dr. David Alan Gilbert
Signed-off-by: Simon Ruderich
---
hmp-commands.hx | 4 ++--
hmp.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git
qemu_open() allow passing file descriptors to qemu which is used in
restricted environments like libvirt where open() is prohibited.
Suggested-by: Eric Blake
Signed-off-by: Simon Ruderich
---
cpus.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
Let's use the new function. Just as current behavior, we have to
consume the whole string (now it's just way clearer what's going on).
Signed-off-by: David Hildenbrand
---
qapi/qobject-input-visitor.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
Adapted patch from Baojun Wang [1] with the following commit message:
I found this could be useful to have qemu-softmmu as a cross
debugger (launch with -s -S command line option), then if we can
have a command to load guest physical memory, we can use cross gdb
to do some target
Display a message during the test using g_test_message rather
than fprintf.
Signed-off-by: Stefan Berger
Reviewed-by: Thomas Huth
---
tests/tpm-tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
index 93a5beba01..582ec0cfd4 100644
vhost-user already has a way to communicate the endianness of the guest
via the vring endianness messages. The vring endianness always matches
the vnet header endianness so there is no need to do anything else in
the backend.
Signed-off-by: Paolo Bonzini
---
net/vhost-user.c | 13 +
This makes the tests more independent and removes the need to defer
test_server_free
via an idle event source.
Signed-off-by: Paolo Bonzini
---
tests/vhost-user-test.c | 38 --
1 file changed, 16 insertions(+), 22 deletions(-)
diff --git
Am 12.11.2018 um 17:50 hat Kevin Wolf geschrieben:
> Am 31.10.2018 um 22:56 hat Kevin Wolf geschrieben:
> > This series cleans up and simplifies the code that calls worker thread
> > functions for the various operations in the file-posix driver. This
> > results in less indirection and better
On 19 October 2018 at 09:55, Hongbo Zhang wrote:
> For the Aarch64, there is one machine 'virt', it is primarily meant to
> run on KVM and execute virtualization workloads, but we need an
> environment as faithful as possible to physical hardware, for supporting
> firmware and OS development for
Am 15.11.2018 um 03:03 hat Eric Blake geschrieben:
> No need to reimplement fragmentation to BLOCK_CRYPTO_MAX_IO_SIZE
> ourselves when we can ask the block layer to do it for us.
>
> Signed-off-by: Eric Blake
>
> ---
> Question - is this patch for 'crypto' acceptable, or should we stick
> with
On 11/15/18 3:35 PM, Peter Maydell wrote:
> Update the onenand device to use qemu_log_mask() for reporting
> guest errors and unimplemented features, rather than plain
> fprintf() and hw_error().
>
> (We leave the hw_error() in onenand_reset(), as that is
> triggered by a failure to read the
Li Qiang writes:
> When the parse_keyboard_layout() find a "include " line
> in the keyboard layout file, it will call parse_keyboard_layout()
> to perform a recursive parse. If the keyboard layout is malformed
> by adding a line include itself, this can cause an infinite parse.
> Thus cause
Adapted patch from Baojun Wang [1] with the following commit message:
I found this could be useful to have qemu-softmmu as a cross
debugger (launch with -s -S command line option), then if we can
have a command to load guest physical memory, we can use cross gdb
to do some target
Let's use the new function. "NaN" and "inf" are now properly rejected.
Signed-off-by: David Hildenbrand
---
qapi/string-input-visitor.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
index
Test that very big/small values are not accepted and that ranges with
only one element work.
Rename expect4 to expect5, as we will be moving that to a separate ulist
test after the rework.
Signed-off-by: David Hildenbrand
---
tests/test-string-input-visitor.c | 22 --
1
Let's provide a wrapper for strtod().
Signed-off-by: David Hildenbrand
---
include/qemu/cutils.h | 2 ++
util/cutils.c | 38 ++
2 files changed, 40 insertions(+)
diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h
index 7071bfe2d4..756b41c193
i is only 32-bit. To prevent possible truncation when dumping large
memory regions use l which is target long.
Suggested-by: Dr. David Alan Gilbert
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Simon Ruderich
---
hmp-commands.hx | 4 ++--
hmp.c | 4 ++--
2 files changed, 4
On 15 November 2018 at 14:09, Stefan Berger wrote:
> The 2 patches in this series fix some minor issues.
>
>Stefan
>
> The following changes since commit cb968d275c145467c8b385a3618a207ec111eab1:
>
> Update version for v3.1.0-rc1 release (2018-11-13 18:16:14 +)
>
> are available in the
On 15/11/18 15:35, Peter Maydell wrote:
Update the onenand device to use qemu_log_mask() for reporting
guest errors and unimplemented features, rather than plain
fprintf() and hw_error().
(We leave the hw_error() in onenand_reset(), as that is
triggered by a failure to read the underlying block
On Thu, Nov 15, 2018 at 03:24:25PM +0100, Philippe Mathieu-Daudé wrote:
> On Wed, Aug 1, 2018 at 12:37 AM Guenter Roeck wrote:
> >
> > sd-card is currently listed as uncategorized device.
> > Mark it as storage device.
> >
> > Signed-off-by: Guenter Roeck
>
> Reviewed-by: Philippe Mathieu-Daudé
On Wed 14 Nov 2018 12:03:17 AM CET, Eric Blake wrote:
> @@ -427,7 +451,9 @@ Standard Cluster Descriptor:
> Compressed Clusters Descriptor (x = 62 - (cluster_bits - 8)):
>
> Bit 0 - x-1: Host cluster offset. This is usually _not_ aligned to a
> -cluster or sector
On Fri, 26 Oct 2018 12:57:11 +0200
Cornelia Huck wrote:
> The MAINTAINERS file is a bit sparse on information about what
> the different designators are. Let's add some more information
> to give contributors a better idea about what the different
> roles are.
>
> Signed-off-by: Cornelia Huck
On 11/15/18 9:17 AM, Alberto Garcia wrote:
On Wed 14 Nov 2018 12:03:17 AM CET, Eric Blake wrote:
@@ -427,7 +451,9 @@ Standard Cluster Descriptor:
Compressed Clusters Descriptor (x = 62 - (cluster_bits - 8)):
Bit 0 - x-1: Host cluster offset. This is usually _not_ aligned to a
-
Am 15.11.2018 um 03:03 hat Eric Blake geschrieben:
> The raw format driver and the filter drivers default to picking
> up the same limits as what they wrap, and I've audited that they
> are otherwise simple enough in their passthrough to be 64-bit
> clean; it's not worth changing their
On 11/15/18 10:24 AM, Kevin Wolf wrote:
Am 15.11.2018 um 03:03 hat Eric Blake geschrieben:
The raw format driver and the filter drivers default to picking
up the same limits as what they wrap, and I've audited that they
are otherwise simple enough in their passthrough to be 64-bit
clean; it's
On 11/15/18 10:20 AM, Cornelia Huck wrote:
On Fri, 26 Oct 2018 12:57:11 +0200
Cornelia Huck wrote:
The MAINTAINERS file is a bit sparse on information about what
the different designators are. Let's add some more information
to give contributors a better idea about what the different
roles
Hello again,
Please ignore v6, I forgot one patch. I hope I got it right this
time.
As I got no replies to my last mails, here again the full patch
set (rebased on current master) in the hope to get this merged.
The first few patches are cleanup, the last two patches add the
pmemload feature.
It's the natural type for object sizes and matches the return value of
sizeof(buf).
Signed-off-by: Simon Ruderich
---
cpus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index c0d796f441..ee54595733 100644
--- a/cpus.c
+++ b/cpus.c
@@ -2370,7 +2370,7
This enables completion for the filename arguments.
Suggested-by: Dr. David Alan Gilbert
Signed-off-by: Simon Ruderich
---
hmp-commands.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index ff96c3ad24..2404a5210d 100644
---
On 14/11/2018 13:36, Marc-André Lureau wrote:
> Only slirp/libslirp.h should be included.
>
> Instead of using some slirp declarations and utility functions directly,
> let's copy them in net/util.h.
>
> Signed-off-by: Marc-André Lureau
> ---
> net/colo.h| 3 +--
> net/util.h
On 11/15/18 7:22 AM, Simon Ruderich wrote:
Signed-off-by: Simon Ruderich
---
cpus.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org |
Let's use the new function. In order to do so, we have to convert all
users of qemu_strtosz*() to pass a "const char **end" ptr.
We will now also reject "inf" properly.
Signed-off-by: David Hildenbrand
---
include/qemu/cutils.h | 6 +++---
monitor.c | 2 +-
tests/test-cutils.c
On Thu, Nov 15, 2018 at 07:45:29AM -0600, Eric Blake wrote:
> On 11/15/18 7:22 AM, Simon Ruderich wrote:
>> Hello again,
>>
>> Please ignore v6, I forgot one patch. I hope I got it right this
>> time.
>
> Our automated tooling doesn't spot patches sent in reply to an earlier
> series; you may want
Adapted patch from Baojun Wang [1] with the following commit message:
I found this could be useful to have qemu-softmmu as a cross
debugger (launch with -s -S command line option), then if we can
have a command to load guest physical memory, we can use cross gdb
to do some target
g_cond_signal is rarely the right thing to do, it works now because
vhost-user-test only has two threads but it is not correct in general.
Fix it before adding more calls.
Signed-off-by: Paolo Bonzini
---
tests/vhost-user-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
This speeds up wait_for_rings_started, which currently is just waiting for
the timeout before checking s->rings.
Signed-off-by: Paolo Bonzini
---
tests/vhost-user-test.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index
The vhost-user-test is one of the most complex qtests in the tree,
and converting it to qgraph poses some unique challenges. This series
addresses them in a way that does not depend on the qgraph conversion
itself, but prepares for it.
First of all, vhost-user-test is slow and that is a pain
Currently vhost-net is compiled only for KVM-enabled targets. This is
not needed anymore because ioeventfd is supported and emulated by the
memory core. Compile it and vhost-user-test for all targets.
While at it, fix the annoying typo CONFIG_VHOST_NET_USED.
Signed-off-by: Paolo Bonzini
---
On 11/15/18 9:15 AM, Erik Skultety wrote:
Unlike SPICE, egl-headless doesn't offer a way of specifying the DRM
node used for OpenGL, hence QEMU always selecting the first one that is
available. Thus, add rendernode option to QAPI.
Signed-off-by: Erik Skultety
---
qapi/ui.json | 16
On Wed, 14 Nov 2018 17:29:30 +0400
Marc-André Lureau wrote:
> Because they are supposed to remain const.
>
> Signed-off-by: Marc-André Lureau
> ---
> include/migration/vmstate.h | 6 +-
> hw/display/virtio-gpu.c | 4 +-
> hw/intc/s390_flic_kvm.c | 4 +-
> hw/nvram/eeprom93xx.c
Am 31.10.2018 um 22:56 hat Kevin Wolf geschrieben:
> aio_worker() for reads and writes isn't boring enough yet. It still does
> some postprocessing for handling short reads and turning the result into
> the right return value.
>
> However, there is no reason why handle_aiocb_rw() couldn't do the
On 11/15/18 9:45 AM, Kevin Wolf wrote:
Am 15.11.2018 um 03:03 hat Eric Blake geschrieben:
This change has no semantic impact: all drivers either leave the
value at 0 (no inherent 32-bit limit is still translated into
fragmentation below 2G; see the previous patch for that audit), or
set it to a
Eric Blake writes:
> On 11/15/18 8:04 AM, David Hildenbrand wrote:
>> Let's use the new function. In order to do so, we have to convert all
>> users of qemu_strtosz*() to pass a "const char **end" ptr.
We shouldn't have qemu_strtol() "improve" on strtol() by splicing in
another const. Since we
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1795527
Title:
Malformed audio and video output stuttering after upgrade to QEMU 3.0
Status
From: Prasad J Pandit
When TIS request is done, set 'sts' data field across all localities.
Signed-off-by: Prasad J Pandit
Reviewed-by: Stefan Berger
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/tpm/tpm_tis.c
Let's make sure that the range handling code can properly deal with
ranges that end at the biggest possible number.
Signed-off-by: David Hildenbrand
---
tests/test-string-input-visitor.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tests/test-string-input-visitor.c
This will be useful to run the qtest for ppc64 targets on (for example)
x86_64 hosts.
Signed-off-by: Paolo Bonzini
---
tests/vhost-user-test.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index
After the conversion to qgraph, the equivalent of "main" will be in
a constructor and will run even if the tests are not being requested.
Therefore, it should not assert that init_hugepagefs succeeds and will
be called when creating the TestServer. This patch changes the prototype
of
On 11/15/18 8:04 AM, David Hildenbrand wrote:
Let's use the new function. Just as current behavior, we have to
consume the whole string (now it's just way clearer what's going on).
Signed-off-by: David Hildenbrand
---
qapi/qobject-input-visitor.c | 9 +
1 file changed, 5
David Hildenbrand writes:
> On 15.11.18 10:48, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> On 14.11.18 18:38, Markus Armbruster wrote:
David Hildenbrand writes:
> The input visitor has some problems right now, especially
> - unsigned type "Range" is used to
As libvirt can't predict which rendernode QEMU would pick, it
won't adjust the permissions on the device, hence QEMU getting
"Permission denied" when opening the DRI device. Therefore, enable
'rendernode' option for egl-headless display type.
Resolves:
Unlike SPICE, egl-headless doesn't offer a way of specifying the DRM
node used for OpenGL, hence QEMU always selecting the first one that is
available. Thus, add rendernode option to QAPI.
Signed-off-by: Erik Skultety
---
qapi/ui.json | 16 +++-
1 file changed, 15 insertions(+), 1
Since QEMU always picks the default DRI device, libvirt doesn't know which one
to put into the mount namespace and relabel it accordingly, hence hitting
permission issues, unless admin tweaks the default permissions of the DRI
devices.
https://bugzilla.redhat.com/show_bug.cgi?id=1648236
Erik
On 11/15/18 6:48 AM, Peter Maydell wrote:
> On 17 October 2018 at 10:51, Stefan Hajnoczi wrote:
>> On Tue, Oct 16, 2018 at 04:20:18PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>>> Theoretically possible that we finish the skipping loop with bs = NULL
>>> and the following code will crash
On 15 November 2018 at 07:32, Richard Henderson wrote:
> On 11/14/18 6:19 PM, Thomas Huth wrote:
>> Program received signal SIGSEGV, Segmentation fault.
>> [...]
>> (gdb) bt
>> #0 0x55addc68 in onenand_read (opaque=0x57600600, addr=98304,
>> size=4) at hw/block/onenand.c:612
>
> So
Rewrite string-input-visitor to be (hopefully) less ugly. Support
int and uint lists (including ranges, but not implemented via type
"Range").
Virtual walks are now supported and more errors are cought (and some bugs
fixed). Fix and extend the tests. Parsing of uint64_t is now properly
supported.
Basically copy all int64 list tests but adapt them to work on uint64
instead. The values for very big/very small values have to be adapted.
Signed-off-by: David Hildenbrand
---
tests/test-string-input-visitor.c | 94 +--
1 file changed, 90 insertions(+), 4
It's the natural type for object sizes and matches the return value of
sizeof(buf).
Reviewed-by: Eric Blake
Signed-off-by: Simon Ruderich
---
cpus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index c0d796f441..ee54595733 100644
--- a/cpus.c
+++
On Mon, Nov 12, 2018 at 07:42:19PM +0800, Peng Hao wrote:
> add pvpanic device in virt acpi table, so when kenrel command line uses
> acpi=force, kernel can get info from acpi table in aarch64.
>
> Signed-off-by: Peng Hao
> ---
> hw/arm/virt-acpi-build.c | 16
> 1 file changed,
On 11/15/18 8:04 AM, David Hildenbrand wrote:
Let's provide a wrapper for strtod().
Signed-off-by: David Hildenbrand
---
include/qemu/cutils.h | 2 ++
util/cutils.c | 38 ++
2 files changed, 40 insertions(+)
+
+/**
+ * Convert string @nptr
1 - 100 of 351 matches
Mail list logo
