Re: [Qemu-devel] [PATCH 3/4] nvme: check msix_init_exclusive_bar return value

2019-01-09 Thread Li Qiang
Max Reitz 于2019年1月9日周三 下午10:52写道: > On 30.10.18 06:18, Li Qiang wrote: > > As this function can fail. > > > > Signed-off-by: Li Qiang > > --- > > hw/block/nvme.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > > index

Re: [Qemu-devel] [PATCH] ppc/xive: fix remaining XiveFabric names

2019-01-09 Thread David Gibson
On Wed, Jan 09, 2019 at 04:15:32PM +0100, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater Applied, thanks. > --- > include/hw/ppc/xive.h | 2 +- > hw/intc/xive.c| 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/hw/ppc/xive.h

Re: [Qemu-devel] [PATCH v1 0/3] gitdm updates

2019-01-09 Thread Aleksandar Markovic
On Tuesday, January 8, 2019, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Monday, January 7, 2019, Alex Bennée wrote: > >> >> Hi, >> >> Added a few more updates mostly of IBMers with non corporate emails. > > > Hi, Alex, could you please add > > leon.al...@imgtec.com > > to

Re: [Qemu-devel] [PULL 00/29] ppc-for-4.0 queue 20190109

2019-01-09 Thread Peter Maydell
are available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.0-20190109 > > for you to fetch changes up to 3a8eb78e6c135422017888380db091793039b6dd: > > spapr: enable XIVE MMIOs at reset (2019-01-09 09:28:14 +1100) > >

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-09 Thread Dave Chinner
On Wed, Jan 09, 2019 at 08:17:31PM +0530, Pankaj Gupta wrote: > This patch series has implementation for "virtio pmem". > "virtio pmem" is fake persistent memory(nvdimm) in guest > which allows to bypass the guest page cache. This also > implements a VIRTIO based asynchronous flush

Re: [Qemu-devel] [PATCH v2 43/52] audio: add mixeng option (documentation)

2019-01-09 Thread Eric Blake
On 12/23/18 2:52 PM, Kővágó, Zoltán wrote: > This will allow us to disable mixeng when we use a decent backend. > > Disabling mixeng have a few advantages: > * we no longer convert the audio output from one format to another, when > the underlying audio system would just convert it to a third

[Qemu-devel] [PATCH] vfio/common: Work around kernel overflow bug in DMA unmap

2019-01-09 Thread Alex Williamson
A kernel bug was introduced in v4.15 via commit 71a7d3d78e3c which adds a test for address space wrap-around in the vfio DMA unmap path. Unfortunately due to overflow, the kernel detects an unmap of the last page in the 64-bit address space as a wrap-around. In QEMU, a Q35 guest with VT-d

[Qemu-devel] [PATCH v2 2/3] globals: Allow global properties to be optional

2019-01-09 Thread Eduardo Habkost
Making some global properties optional will let us simplify compat code when a given property works on most (but not all) subclasses of a given type. Device types will be able to opt out from optional compat properties by simply not registering those properties, or by making the property setter

Re: [Qemu-devel] [PATCH v2 03/52] qapi: qapi for audio backends

2019-01-09 Thread Eric Blake
On 12/23/18 2:51 PM, Kővágó, Zoltán wrote: > This patch adds structures into qapi to replace the existing > configuration structures used by audio backends currently. This qapi > will be the base of the -audiodev command line parameter (that replaces > the old environment variables based config).

Re: [Qemu-devel] [PATCH] vfio/common: Work around kernel overflow bug in DMA unmap

2019-01-09 Thread Peter Xu
On Wed, Jan 09, 2019 at 04:10:51PM -0700, Alex Williamson wrote: > A kernel bug was introduced in v4.15 via commit 71a7d3d78e3c which > adds a test for address space wrap-around in the vfio DMA unmap path. > Unfortunately due to overflow, the kernel detects an unmap of the last > page in the

Re: [Qemu-devel] [PATCH] target/arm: Allow to switch from MON->HYP on AArch32

2019-01-09 Thread Peter Maydell
On Wed, 9 Jan 2019 at 17:14, Alexander Graf wrote: > > On 01/09/2019 05:59 PM, Peter Maydell wrote: > > On Wed, 9 Jan 2019 at 16:52, Peter Maydell wrote: > >> On Wed, 9 Jan 2019 at 15:26, Alexander Graf wrote: > >>> In U-boot, we switch from S-SVC -> MON -> HYP when we want to enter > >>> HYP

Re: [Qemu-devel] [PATCH 2/5] nbd: Allow bitmap export during QMP nbd-server-add

2019-01-09 Thread Eric Blake
On 1/8/19 10:14 PM, Eric Blake wrote: > With the experimental x-nbd-server-add-bitmap command, there was > a window of time where a client could see the export but not the > associated dirty bitmap, which can cause a client that planned > on using the dirty bitmap to be forced to treat the entire

[Qemu-devel] [PATCH] ppc440: Avoid reporting error when reading non-existent RAM slot

2019-01-09 Thread BALATON Zoltan
When reading base register of RAM slot with no RAM we should not try to calculate register value because that will result printing an error due to invalid RAM size. Just return 0 without the error in this case. Signed-off-by: BALATON Zoltan --- hw/ppc/ppc440_uc.c | 6 -- 1 file changed, 4

[Qemu-devel] [PATCH v1 1/1] default-configs: Enable USB support for RISC-V machines

2019-01-09 Thread Alistair Francis
Signed-off-by: Alistair Francis --- default-configs/riscv32-softmmu.mak | 1 + default-configs/riscv64-softmmu.mak | 1 + 2 files changed, 2 insertions(+) diff --git a/default-configs/riscv32-softmmu.mak b/default-configs/riscv32-softmmu.mak index dbc9398284..c9c5971409 100644 ---

Re: [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays

2019-01-09 Thread Eduardo Habkost
On Tue, Jan 08, 2019 at 11:20:12AM +0100, Cornelia Huck wrote: > On Tue, 8 Jan 2019 07:45:43 +0100 > Gerd Hoffmann wrote: > > > Hi, > > > > > +{ "migration", "decompress-error-check", "off" }, > > > +{ "hda-audio", "use-timer", "false" }, > > > +{ "cirrus-vga", "global-vmstate",

Re: [Qemu-devel] [PATCH] vfio: assign idstr for VFIO's mmaped regions for migration

2019-01-09 Thread Zhao Yan
On Tue, Jan 08, 2019 at 10:09:11AM -0700, Alex Williamson wrote: > On Tue, 8 Jan 2019 01:03:48 -0500 > Zhao Yan wrote: > > > if multiple regions in vfio are mmaped, their corresponding ramblocks > > are like below, i.e. their idstrs are "". > > > > (qemu) info ramblock > > Block Name PSize

Re: [Qemu-devel] [PATCH v1 3/3] contrib/gitdm: add two more IBM'ers to group-map-ibm

2019-01-09 Thread Aleksandar Markovic
On Monday, January 7, 2019, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > contrib/gitdm/group-map-ibm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/contrib/gitdm/group-map-ibm b/contrib/gitdm/group-map-ibm > index 6c0570107d..22727319b3 100644 > ---

Re: [Qemu-devel] [PATCH QEMU v5] hw/arm/sysbus-fdt: Add support for instantiating generic devices

2019-01-09 Thread Peter Maydell
So I should start out upfront by saying that I'm aware that the reality is that people do want to do passthrough with this kind of hardware, and that's not an unreasonable thing to do. I just don't really like the way that pushes the software into having to do ugly things... Overall I'll let Eric

Re: [Qemu-devel] [PATCH v2 06/52] audio: -audiodev command line option basic implementation

2019-01-09 Thread Zoltán Kővágó
On 2019-01-08 04:42, Markus Armbruster wrote: > "Zoltán Kővágó" writes: > >> On 2019-01-07 14:13, Markus Armbruster wrote: >>> "Kővágó, Zoltán" writes: >>> Audio drivers now get an Audiodev * as config paramters, instead of the global audio_option structs. There is some code in

Re: [Qemu-devel] [PATCH 2/4] nvme: ensure the num_queues is not zero

2019-01-09 Thread Li Qiang
Max Reitz 于2019年1月9日周三 下午10:38写道: > On 30.10.18 06:18, Li Qiang wrote: > > When it is zero, it causes segv. Backtrack: > > Thread 5 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > > [Switching to Thread 0x7fffc6c17700 (LWP 51808)] > > 0x55acbd90 in nvme_start_ctrl

Re: [Qemu-devel] [PATCH v1 2/3] contrib/gitdm: Add other IBMers

2019-01-09 Thread Aleksandar Markovic
On Monday, January 7, 2019, Alex Bennée wrote: > From: Joel Stanley > > Here are some IBMers who use their personal addresses when submitting > patches. > > Signed-off-by: Joel Stanley > Acked-by: Andrew Jeffery > Signed-off-by: Alex Bennée > --- > contrib/gitdm/group-map-ibm | 5 + > 1

Re: [Qemu-devel] [SPDK] Qemu migration with vhost-user-blk on top of local storage

2019-01-09 Thread wuzhouhui
> -Original Messages- > From: "Wodkowski, PawelX" > Sent Time: 2019-01-10 00:19:48 (Thursday) > To: "stefa...@gmail.com" , "s...@lists.01.org" > > Cc: "libvir-l...@redhat.com" , "xieyon...@baidu.com" > , "qemu-devel@nongnu.org" , > "lili...@baidu.com" > Subject: Re: [SPDK]

[Qemu-devel] [PATCH v2 3/3] virtio: Make disable-legacy/disable-modern compat properties optional

2019-01-09 Thread Eduardo Habkost
The disable-legacy and disable-modern properties apply only to some virtio-pci devices. Make those properties optional. This fixes the crash introduced by commit f6e501a28ef9 ("virtio: Provide version-specific variants of virtio PCI devices"): $ qemu-system-x86_64 -machine pc-i440fx-2.6 \

[Qemu-devel] [PATCH v2 1/3] qom: Don't keep error value between object_property_parse() calls

2019-01-09 Thread Eduardo Habkost
When handling errp==NULL at object_apply_global_props(), we are leaving the old error value in `err` after printing a warning. This makes QEMU crash if two global properties generate warnings: $ echo device_add rtl8139 | qemu-system-x86_64 -monitor stdio -global rtl8139.xxx=yyy -global

[Qemu-devel] [PATCH v2 0/3] Fix virtio-*(-non)-transitional crash on 2.6 machine-types

2019-01-09 Thread Eduardo Habkost
This is a second attempt to fix the crash reported by Thomas[1]. This keeps the compat property array simple, different from my first attempt[2]. This also avoids extra complexity on the device code: we don't need interface name, inheritance tricks, or devices overriding a compat property after

Re: [Qemu-devel] [PATCH v1 1/3] contrib/gitdm: add Nokia and Proxmox to the domain-map

2019-01-09 Thread Aleksandar Markovic
On Monday, January 7, 2019, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > contrib/gitdm/domain-map | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map > index 8cbbcfe93d..0ab41ee27a 100644 > --- a/contrib/gitdm/domain-map >

Re: [Qemu-devel] Emulation of TCG OPAL self-encrypting drive

2019-01-09 Thread David Kozub
On Mon, 7 Jan 2019, Stefan Hajnoczi wrote: QEMU supports LUKS encrypted disk images so no new code is needed for the actual encryption. Thanks for the feedback, Stefan. I know very little about qemu internals (I looked around a bit). One issue is: OPAL needs some persistent data outside of

Re: [Qemu-devel] [PATCH v2 1/3] qom: Don't keep error value between object_property_parse() calls

2019-01-09 Thread Eric Blake
On 1/9/19 8:02 PM, Eduardo Habkost wrote: > When handling errp==NULL at object_apply_global_props(), we are > leaving the old error value in `err` after printing a warning. > This makes QEMU crash if two global properties generate warnings: > > $ echo device_add rtl8139 | qemu-system-x86_64

Re: [Qemu-devel] [PATCH v3 2/2] configure: Force the C standard to gnu99

2019-01-09 Thread Thomas Huth
On 2019-01-09 22:26, Paolo Bonzini wrote: > On 09/01/19 19:10, Philippe Mathieu-Daudé wrote: >> Using '-std=gnu++98' for g++ v4.8 looks like a good compromise to the >> issues Daniel mentioned (still 'experimental'). >> >> Reviewed-by: Philippe Mathieu-Daudé > > C++11 has many new features that

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Thomas Huth
On 2019-01-09 18:47, Greg Kurz wrote: > On Wed, 9 Jan 2019 18:40:48 +0100 > Cédric Le Goater wrote: > >> On 1/9/19 6:28 PM, Daniel P. Berrangé wrote: >>> On Wed, Jan 09, 2019 at 06:13:01PM +0100, Cédric Le Goater wrote: On 1/9/19 5:39 PM, Thomas Huth wrote: > When compiling with

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-09 Thread Thomas Huth
On 2019-01-09 22:20, Paolo Bonzini wrote: > On 09/01/19 18:28, Daniel P. Berrangé wrote: >>> so both files include each other, how nice ... >> If the header files are mutually dependent it makes me wonder what the >> point of having them split up is ? >> >> Feels like either they need to be

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2019-01-09 Thread Eric Blake
On 1/9/19 1:21 PM, Eric Blake wrote: > Revisiting an older thread: > > On 6/9/18 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: >> Handle new NBD meta namespace: "qemu", and corresponding queries: >> "qemu:dirty-bitmap:". >> >> With new metadata context negotiated, BLOCK_STATUS query will reply >>

[Qemu-devel] [PATCH v2 4/6] nbd: Remove x-nbd-server-add-bitmap

2019-01-09 Thread Eric Blake
Now that nbd-server-add can do the same functionality, we no longer need the experimental separate command. Signed-off-by: Eric Blake --- qapi/block.json | 23 --- blockdev-nbd.c | 23 --- 2 files changed, 46 deletions(-) diff --git a/qapi/block.json

[Qemu-devel] [PATCH v2 2/6] nbd: Merge nbd_export_set_name into nbd_export_new

2019-01-09 Thread Eric Blake
The existing NBD code had a weird split where nbd_export_new() created an export but did not add it to the list of exported names until a later nbd_export_set_name() came along and grabbed a second reference on the object; later, nbd_export_close() drops the second reference. But since we never

[Qemu-devel] [PATCH v2 1/6] nbd: Only require disabled bitmap for read-only exports

2019-01-09 Thread Eric Blake
Our initial implementation of x-nbd-server-add-bitmap put in a restriction because of incremental backups: in that usage, we are exporting one qcow2 file (the temporary overlay target of a blockdev-backup sync:none job) and a dirty bitmap owned by a second qcow2 file (the source of the

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-09 Thread Rik van Riel
On Thu, 2019-01-10 at 12:26 +1100, Dave Chinner wrote: > On Wed, Jan 09, 2019 at 08:17:31PM +0530, Pankaj Gupta wrote: > > This patch series has implementation for "virtio pmem". > > "virtio pmem" is fake persistent memory(nvdimm) in guest > > which allows to bypass the guest page cache. This

[Qemu-devel] [PATCH v2 3/6] nbd: Allow bitmap export during QMP nbd-server-add

2019-01-09 Thread Eric Blake
With the experimental x-nbd-server-add-bitmap command, there was a window of time where an NBD client could see the export but not the associated dirty bitmap, which can cause a client that planned on using the dirty bitmap to be forced to treat the entire image as dirty as a safety fallback.

[Qemu-devel] [PATCH v2 0/6] Promote x-nbd-server-add-bitmap to stable

2019-01-09 Thread Eric Blake
Or rather, move its functionality into nbd-server-add. And as a side effect, teach qemu-nbd how to export a persistent bitmap without having to go through a qemu process and several QMP commands. Based-on: <20181221093529.23855-1-js...@redhat.com> [0/11 bitmaps: remove x- prefix from QMP api]

[Qemu-devel] [PATCH v2 6/6] qemu-nbd: Add --bitmap=NAME option

2019-01-09 Thread Eric Blake
Having to fire up qemu, then use QMP commands for nbd-server-start and nbd-server-add, just to expose a persistent dirty bitmap, is rather tedious. Make it possible to expose a dirty bitmap using just qemu-nbd (of course, for now this only works when qemu-nbd is visiting a BDS formatted as

Re: [Qemu-devel] [PATCH v2 06/52] audio: -audiodev command line option basic implementation

2019-01-09 Thread Gerd Hoffmann
Hi, > I was thinking about creating an Audiodev (the qapi type) directly would > be better, then somehow print it with reflection. While this is not a > typical use of qapi, at least qmp_qom_list creates qapi objects > directly, so I assume it's ok. Yes, it's perfectly fine. > The second

Re: [Qemu-devel] [PATCH] target/arm: Allow to switch from MON->HYP on AArch32

2019-01-09 Thread Alexander Graf
On 10.01.19 00:08, Peter Maydell wrote: > On Wed, 9 Jan 2019 at 17:14, Alexander Graf wrote: >> >> On 01/09/2019 05:59 PM, Peter Maydell wrote: >>> On Wed, 9 Jan 2019 at 16:52, Peter Maydell wrote: On Wed, 9 Jan 2019 at 15:26, Alexander Graf wrote: > In U-boot, we switch from S-SVC

Re: [Qemu-devel] [PATCH] target-i386: hvf: remove MPX support

2019-01-09 Thread Roman Bolshakov
On Thu, Dec 20, 2018 at 01:11:12PM +0100, Paolo Bonzini wrote: > MPX support is being phased out by Intel and actually I am not sure that > OS X has ever enabled it in XCR0. Drop it from the Hypervisor.framework > acceleration. > I also doubt if OS X enabled it, but I can't confirm that as I

Re: [Qemu-devel] [PATCH] spice: Remove unused include

2019-01-09 Thread Gerd Hoffmann
On Mon, Jan 07, 2019 at 06:44:04PM +, Frediano Ziglio wrote: > The definitions in the header are not used. > Also this fixes porting SPICE to Windows where the header is not > available. Added to ui queue. thanks, Gerd

[Qemu-devel] [PATCH v2 5/6] nbd: Merge nbd_export_bitmap into nbd_export_new

2019-01-09 Thread Eric Blake
We only have one caller that wants to export a bitmap name, which it does right after creation of the export. But there is still a brief window of time where an NBD client could see the export but not the dirty bitmap, which a robust client would have to interpret as meaning the entire image

Re: [Qemu-devel] [PATCH] linux-user: make pwrite64/pread64(fd, NULL, 0, offset) return 0

2019-01-09 Thread Laurent Vivier
Le 08/01/2019 à 19:49, Peter Maydell a écrit : > Linux returns success if pwrite64() or pread64() are called with a > zero length NULL buffer, but QEMU was returning -TARGET_EFAULT. > > This is the same bug that we fixed in commit 58cfa6c2e6eb51b23cc9 > for the write syscall, and long before that

[Qemu-devel] Qemu migration with vhost-user-blk on top of local storage

2019-01-09 Thread wuzhouhui
Hi everyone, I'm working qemu with vhost target (e.g. spdk), and I attempt to migrate VM with 2 local storages. One local storage is a regular file, e.g. /tmp/c74.qcow2, and the other is a malloc bdev that spdk created. This malloc bdev will exported to VM via vhost-user-blk. When I execute

Re: [Qemu-devel] [PATCH] linux-user: make pwrite64/pread64(fd, NULL, 0, offset) return 0

2019-01-09 Thread Laurent Vivier
On 08/01/2019 19:49, Peter Maydell wrote: > Linux returns success if pwrite64() or pread64() are called with a > zero length NULL buffer, but QEMU was returning -TARGET_EFAULT. > > This is the same bug that we fixed in commit 58cfa6c2e6eb51b23cc9 > for the write syscall, and long before that in

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ioapic: use TYPE_FOO MACRO than constant string

2019-01-09 Thread Laurent Vivier
On 05/01/2019 03:38, Li Qiang wrote: > Make them more QOMConventional. > Cc:qemu-triv...@nongnu.org > > Signed-off-by: Li Qiang > --- > hw/i386/kvm/ioapic.c | 2 +- > hw/i386/pc.c | 4 ++-- > hw/intc/ioapic.c | 2 +- > include/hw/i386/ioapic.h | 3 +++ > 4 files changed,

Re: [Qemu-devel] [PATCH v3] dump: Set correct vaddr for ELF dump

2019-01-09 Thread Laszlo Ersek
On 01/09/19 09:25, Marc-André Lureau wrote: > On Wed, Jan 9, 2019 at 12:22 PM Jon Doron wrote: >> >> vaddr needs to be equal to the paddr since the dump file represents the >> physical memory image. >> >> Without setting vaddr correctly, GDB would load all the different memory >> regions on top

Re: [Qemu-devel] [PATCH v4] tests: vm: auto_install OpenBSD

2019-01-09 Thread Daniel P . Berrangé
On Wed, Nov 14, 2018 at 05:58:07PM +0800, Fam Zheng wrote: > On Sun, 11/11 18:20, Brad Smith wrote: > > ping. > > Queued. Will send a pull request soon. ping, this seems to have got lost, and is blocking us deleting SDL 1.2 support from QEMU. > > On 10/30/2018 10:57 PM, Fam Zheng wrote: > > >

Re: [Qemu-devel] [PATCH v3] qemu-io: Add generic function for reinitializing optind.

2019-01-09 Thread Richard W.M. Jones
On Wed, Jan 09, 2019 at 01:44:48PM +, Daniel P. Berrangé wrote: > On Wed, Jan 09, 2019 at 01:23:01PM +, Richard W.M. Jones wrote: > > How about this one? Add a generic osdep function for reinitializing > > optind, which does optreset on FreeBSD (but is identical on all other > > OSes).

Re: [Qemu-devel] [PATCH] configure: Force the C standard to gnu11

2019-01-09 Thread Thomas Huth
On 2019-01-09 15:20, Markus Armbruster wrote: > Thomas Huth writes: > >> On 2019-01-09 14:10, Markus Armbruster wrote: >>> Thomas Huth writes: >>> On 2019-01-09 12:44, Daniel P. Berrangé wrote: > On Wed, Jan 09, 2019 at 12:25:43PM +0100, Thomas Huth wrote: >> On 2019-01-09 11:58,

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Max Reitz
On 09.01.19 15:21, Kevin Wolf wrote: > Am 09.01.2019 um 15:10 hat Max Reitz geschrieben: >> On 06.09.18 13:11, Daniel Henrique Barboza wrote: >>> changes in v2: >>> - removed the "RFC" marker; >>> - added a new patch (patch 2) that removes >>> bdrv_snapshot_delete_by_id_or_name from the code; >>>

Re: [Qemu-devel] [PATCH] iotests: Make 234 stable

2019-01-09 Thread Kevin Wolf
Am 21.12.2018 um 19:42 hat Max Reitz geschrieben: > This test waits for a MIGRATION event with status=completed on the > source VM before querying the migration status on both source and > destination. However, just because the source says migration has > completed does not mean the destination

Re: [Qemu-devel] [PATCH v3 4/5] ext4: disable map_sync for virtio pmem

2019-01-09 Thread Jan Kara
On Wed 09-01-19 19:26:05, Pankaj Gupta wrote: > Virtio pmem provides asynchronous host page cache flush > mechanism. We don't support 'MAP_SYNC' with virtio pmem > and ext4. > > Signed-off-by: Pankaj Gupta ... > @@ -371,6 +373,13 @@ static int ext4_file_mmap(struct file *file, struct >

Re: [Qemu-devel] [PATCH v15 5/6] acpi: add ACPI memory clear interface

2019-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2019 at 12:29:01PM +0400, Marc-André Lureau wrote: > The interface is described in the "TCG Platform Reset Attack > Mitigation Specification", chapter 6 "ACPI _DSM Function". According > to Laszlo, it's not so easy to implement in OVMF, he suggested to do > it in qemu instead. > >

[Qemu-devel] [PATCH v3 4/5] ext4: disable map_sync for virtio pmem

2019-01-09 Thread Pankaj Gupta
Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and ext4. Signed-off-by: Pankaj Gupta --- fs/ext4/file.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index

Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-09 Thread Daniel P . Berrangé
On Wed, Jan 09, 2019 at 03:32:47PM +0100, Markus Armbruster wrote: > Max Reitz writes: > > > On 08.01.19 11:36, Markus Armbruster wrote: > >> Copying block maintainers for help with assessing the bug's (non-)impact > >> on security. > >> > >> Christophe Fergeau writes: > >> > >>> On Mon, Jan

Re: [Qemu-devel] [PATCH v2] configure: Force the C standard to gnu99

2019-01-09 Thread Daniel P . Berrangé
On Wed, Jan 09, 2019 at 03:51:33PM +0100, Thomas Huth wrote: > On 2019-01-09 15:31, Daniel P. Berrangé wrote: > > On Wed, Jan 09, 2019 at 03:24:29PM +0100, Thomas Huth wrote: > >> Different versions of GCC and Clang use different versions of the C > >> standard. > >> This repeatedly caused

Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-09 Thread Max Reitz
On 09.01.19 15:49, Daniel P. Berrangé wrote: > On Wed, Jan 09, 2019 at 03:32:47PM +0100, Markus Armbruster wrote: >> Max Reitz writes: >> >>> On 08.01.19 11:36, Markus Armbruster wrote: Copying block maintainers for help with assessing the bug's (non-)impact on security.

Re: [Qemu-devel] [PATCH v2] configure: Force the C standard to gnu99

2019-01-09 Thread Thomas Huth
On 2019-01-09 15:58, Daniel P. Berrangé wrote: > On Wed, Jan 09, 2019 at 03:51:33PM +0100, Thomas Huth wrote: >> On 2019-01-09 15:31, Daniel P. Berrangé wrote: [...] >>> We could consider also setting a suitable -std for CXXFLAGS too in future >>> though... >> >> Shall I send a v3 with

Re: [Qemu-devel] [PATCH] block: Acquire the AioContext in guess_disk_lchs()

2019-01-09 Thread Kevin Wolf
Am 09.01.2019 um 15:28 hat Alberto Garcia geschrieben: > This fixes the following crash: > > { "execute": "blockdev-add", > "arguments": {"driver": "null-co", "node-name": "hd0"}} > { "execute": "object-add", > "arguments": {"qom-type": "iothread", "id": "iothread0"}} > { "execute":

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Kevin Wolf
Am 09.01.2019 um 15:54 hat Max Reitz geschrieben: > On 09.01.19 15:48, Kevin Wolf wrote: > > Am 09.01.2019 um 15:27 hat Max Reitz geschrieben: > >> On 09.01.19 15:21, Kevin Wolf wrote: > >>> Am 09.01.2019 um 15:10 hat Max Reitz geschrieben: > On 06.09.18 13:11, Daniel Henrique Barboza wrote:

Re: [Qemu-devel] [PATCH for-4.0 v9 13/16] qemu_thread: supplement error handling for migration

2019-01-09 Thread Markus Armbruster
Fei Li writes: > Update qemu_thread_create()'s callers by > - setting an error on qemu_thread_create() failure for callers that > set an error on failure; > - reporting the error and returning failure for callers that return > an error code on failure; > - reporting the error and setting

Re: [Qemu-devel] [PATCH for-4.0 v9 16/16] qemu_thread_join: fix segmentation fault

2019-01-09 Thread Markus Armbruster
Fei Li writes: > 在 2019/1/9 上午1:29, Markus Armbruster 写道: >> fei writes: >> 在 2019年1月8日,01:55,Markus Armbruster 写道: Fei Li writes: > To avoid the segmentation fault in qemu_thread_join(), just directly > return when the QemuThread *thread failed to be created in

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-09 Thread Alberto Garcia
On Wed 09 Jan 2019 12:01:44 PM CET, Stefan Hajnoczi wrote: > The following QMP command leads to a crash when iothreads are used: > > { 'execute': 'device_del', 'arguments': {'id': 'data'} } How did you reproduce this? Do you have a test case? Berto

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-09 Thread Tony Krowiak
On 1/9/19 5:14 AM, Cornelia Huck wrote: On Tue, 8 Jan 2019 15:34:37 -0500 Tony Krowiak wrote: On 1/8/19 12:06 PM, Cornelia Huck wrote: On Tue, 8 Jan 2019 17:50:21 +0100 Halil Pasic wrote: On Tue, 8 Jan 2019 17:31:13 +0100 Cornelia Huck wrote: On Tue, 8 Jan 2019 11:08:56 -0500 Tony

[Qemu-devel] [PATCH v3 5/5] xfs: disable map_sync for virtio pmem

2019-01-09 Thread Pankaj Gupta
Virtio pmem provides asynchronous host page cache flush mechanism. we don't support 'MAP_SYNC' with virtio pmem and xfs. Signed-off-by: Pankaj Gupta --- fs/xfs/xfs_file.c | 8 1 file changed, 8 insertions(+) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index e474250..eae4aa4

[Qemu-devel] [PATCH v3 1/5] libnvdimm: nd_region flush callback support

2019-01-09 Thread Pankaj Gupta
This patch adds functionality to perform flush from guest to host over VIRTIO. We are registering a callback based on 'nd_region' type. virtio_pmem driver requires this special flush function. For rest of the region types we are registering existing flush function. Report error returned by host

[Qemu-devel] [PATCH] hw/ppc/spapr: Encode the SCSI channel (bus) in the SRP LUNs

2019-01-09 Thread Thomas Huth
In hw/scsi/spapr_vio.c we declare that the controller supports multiple buses by specifying "max_channel = 7" there. So in the code that fixes up the device tree nodes, we must encode the channel number (a.k.a. bus number in the "Logical unit addressing format" table of SAM5) into the 64-bit LUN,

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Max Reitz
On 06.09.18 13:11, Daniel Henrique Barboza wrote: > changes in v2: > - removed the "RFC" marker; > - added a new patch (patch 2) that removes > bdrv_snapshot_delete_by_id_or_name from the code; > - made changes in patch 1 as suggested by Murilo; > - previous patch set link: >

Re: [Qemu-devel] [PATCH v3] qemu-io: Add generic function for reinitializing optind.

2019-01-09 Thread Daniel P . Berrangé
On Wed, Jan 09, 2019 at 02:14:46PM +, Richard W.M. Jones wrote: > On Wed, Jan 09, 2019 at 01:44:48PM +, Daniel P. Berrangé wrote: > > On Wed, Jan 09, 2019 at 01:23:01PM +, Richard W.M. Jones wrote: > > > How about this one? Add a generic osdep function for reinitializing > > > optind,

Re: [Qemu-devel] [PATCH] configure: Force the C standard to gnu11

2019-01-09 Thread Markus Armbruster
Thomas Huth writes: > On 2019-01-09 14:10, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> On 2019-01-09 12:44, Daniel P. Berrangé wrote: On Wed, Jan 09, 2019 at 12:25:43PM +0100, Thomas Huth wrote: > On 2019-01-09 11:58, Daniel P. Berrangé wrote: >> On Mon, Jan 07, 2019 at

Re: [Qemu-devel] [libvirt] Qemu migration with vhost-user-blk on top of local storage

2019-01-09 Thread Peter Krempa
On Wed, Jan 09, 2019 at 21:23:25 +0800, wuzhouhui wrote: > > -Original Messages- > > From: "Stefan Hajnoczi" > > Sent Time: 2019-01-09 20:42:58 (Wednesday) > > To: wuzhouhui > > Cc: qemu-devel@nongnu.org, xieyon...@baidu.com, lili...@baidu.com, > > libvir-l...@redhat.com,

[Qemu-devel] [PATCH v2] configure: Force the C standard to gnu99

2019-01-09 Thread Thomas Huth
Different versions of GCC and Clang use different versions of the C standard. This repeatedly caused problems already, e.g. with duplicated typedefs: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html or with for-loop variable initializers:

[Qemu-devel] [PATCH v2] spapr/vio: remove the "irq" property"

2019-01-09 Thread Cédric Le Goater
commit efe2add7cb7f ("spapr/vio: deprecate the "irq" property") was merged in QEMU version 3.0. The "irq" property" can be removed for QEMU version 4.0. Signed-off-by: Cédric Le Goater Reviewed-by: Thomas Huth Reviewed-by: Greg Kurz --- qemu-deprecated.texi | 6 -- hw/ppc/spapr_vio.c |

Re: [Qemu-devel] [PATCH v2] configure: Force the C standard to gnu99

2019-01-09 Thread Daniel P . Berrangé
On Wed, Jan 09, 2019 at 03:24:29PM +0100, Thomas Huth wrote: > Different versions of GCC and Clang use different versions of the C standard. > This repeatedly caused problems already, e.g. with duplicated typedefs: > > https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html > > or

Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-09 Thread Markus Armbruster
Max Reitz writes: > On 08.01.19 11:36, Markus Armbruster wrote: >> Copying block maintainers for help with assessing the bug's (non-)impact >> on security. >> >> Christophe Fergeau writes: >> >>> On Mon, Jan 07, 2019 at 04:47:44PM +0100, Markus Armbruster wrote: Eric Blake writes:

Re: [Qemu-devel] [PATCH 2/4] nvme: ensure the num_queues is not zero

2019-01-09 Thread Max Reitz
On 30.10.18 06:18, Li Qiang wrote: > When it is zero, it causes segv. Backtrack: > Thread 5 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > [Switching to Thread 0x7fffc6c17700 (LWP 51808)] > 0x55acbd90 in nvme_start_ctrl (n=0x624c8100) at > hw/block/nvme.c:820 >

Re: [Qemu-devel] [PATCH 1/4] nvme: use TYPE_NVME instead of constant string

2019-01-09 Thread Max Reitz
On 30.10.18 06:18, Li Qiang wrote: > Signed-off-by: Li Qiang > --- > hw/block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-09 Thread Pankaj Gupta
Please ignore this series as my network went down while sending this. I will send this series again. Thanks, Pankaj > > This patch series has implementation for "virtio pmem". > "virtio pmem" is fake persistent memory(nvdimm) in guest > which allows to bypass the guest page cache. This

[Qemu-devel] [PATCH v3 3/5] libnvdimm: add nd_region buffered dax_dev flag

2019-01-09 Thread Pankaj Gupta
This patch adds 'DAXDEV_BUFFERED' flag which is set for virtio pmem corresponding nd_region. This later is used to disable MAP_SYNC functionality for ext4 & xfs filesystem. Signed-off-by: Pankaj Gupta --- drivers/dax/super.c | 17 + drivers/nvdimm/pmem.c| 3 +++

Re: [Qemu-devel] [PATCH v2] configure: Force the C standard to gnu99

2019-01-09 Thread Thomas Huth
On 2019-01-09 15:31, Daniel P. Berrangé wrote: > On Wed, Jan 09, 2019 at 03:24:29PM +0100, Thomas Huth wrote: >> Different versions of GCC and Clang use different versions of the C standard. >> This repeatedly caused problems already, e.g. with duplicated typedefs: >> >>

Re: [Qemu-devel] [PATCH v3] qemu-io: Add generic function for reinitializing optind.

2019-01-09 Thread Eric Blake
On 1/9/19 7:44 AM, Daniel P. Berrangé wrote: > On Wed, Jan 09, 2019 at 01:23:01PM +, Richard W.M. Jones wrote: >> How about this one? Add a generic osdep function for reinitializing >> optind, which does optreset on FreeBSD (but is identical on all other >> OSes). Use it from qemu-io and

Re: [Qemu-devel] [PATCH] block: Acquire the AioContext in guess_disk_lchs()

2019-01-09 Thread Stefan Hajnoczi
On Wed, Jan 09, 2019 at 04:28:50PM +0200, Alberto Garcia wrote: > This fixes the following crash: > > { "execute": "blockdev-add", > "arguments": {"driver": "null-co", "node-name": "hd0"}} > { "execute": "object-add", > "arguments": {"qom-type": "iothread", "id": "iothread0"}} > { "execute":

Re: [Qemu-devel] [PATCH 3/4] nvme: check msix_init_exclusive_bar return value

2019-01-09 Thread Max Reitz
On 30.10.18 06:18, Li Qiang wrote: > As this function can fail. > > Signed-off-by: Li Qiang > --- > hw/block/nvme.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 72c9644..a406c23 100644 > --- a/hw/block/nvme.c > +++

[Qemu-devel] [PATCH v3 5/5] xfs: disable map_sync for virtio pmem

2019-01-09 Thread Pankaj Gupta
Virtio pmem provides asynchronous host page cache flush mechanism. we don't support 'MAP_SYNC' with virtio pmem and xfs. Signed-off-by: Pankaj Gupta --- fs/xfs/xfs_file.c | 8 1 file changed, 8 insertions(+) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index e474250..eae4aa4

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Max Reitz
On 09.01.19 15:48, Kevin Wolf wrote: > Am 09.01.2019 um 15:27 hat Max Reitz geschrieben: >> On 09.01.19 15:21, Kevin Wolf wrote: >>> Am 09.01.2019 um 15:10 hat Max Reitz geschrieben: On 06.09.18 13:11, Daniel Henrique Barboza wrote: > changes in v2: > - removed the "RFC" marker; >

Re: [Qemu-devel] [PATCH v15 0/6] Add support for TPM Physical Presence interface

2019-01-09 Thread Marc-André Lureau
Hi On Wed, Jan 9, 2019 at 6:51 PM Michael S. Tsirkin wrote: > > On Wed, Jan 09, 2019 at 12:28:56PM +0400, Marc-André Lureau wrote: > > Hi, > > > > The following patches implement the TPM Physical Presence Interface > > that allows a user to set a command via ACPI (sysfs entry in Linux) > > that,

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-09 Thread Alberto Garcia
On Wed 09 Jan 2019 12:01:44 PM CET, Stefan Hajnoczi wrote: > The following QMP command leads to a crash when iothreads are used: > > { 'execute': 'device_del', 'arguments': {'id': 'data'} } I was trying to reproduce this and I found this crashing in master: $ qemu-system-x86_64 -enable-kvm

Re: [Qemu-devel] [PATCH] configure: Force the C standard to gnu11

2019-01-09 Thread Thomas Huth
On 2019-01-09 14:27, Daniel P. Berrangé wrote: > On Wed, Jan 09, 2019 at 02:20:02PM +0100, Thomas Huth wrote: >> On 2019-01-09 13:58, Daniel P. Berrangé wrote: >>> On Wed, Jan 09, 2019 at 01:52:02PM +0100, Thomas Huth wrote: On 2019-01-09 12:44, Daniel P. Berrangé wrote: > On Wed, Jan 09,

[Qemu-devel] [PATCH v3 3/5] libnvdimm: add nd_region buffered dax_dev flag

2019-01-09 Thread Pankaj Gupta
This patch adds 'DAXDEV_BUFFERED' flag which is set for virtio pmem corresponding nd_region. This later is used to disable MAP_SYNC functionality for ext4 & xfs filesystem. Signed-off-by: Pankaj Gupta --- drivers/dax/super.c | 17 + drivers/nvdimm/pmem.c| 3 +++

[Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-09 Thread Pankaj Gupta
This patch series has implementation for "virtio pmem". "virtio pmem" is fake persistent memory(nvdimm) in guest which allows to bypass the guest page cache. This also implements a VIRTIO based asynchronous flush mechanism. Sharing guest kernel driver in this patchset with the changes

Re: [Qemu-devel] [PATCH v4] tests: vm: auto_install OpenBSD

2019-01-09 Thread Daniel P . Berrangé
On Wed, Jan 09, 2019 at 01:55:04PM +, Daniel P. Berrangé wrote: > On Wed, Nov 14, 2018 at 05:58:07PM +0800, Fam Zheng wrote: > > On Sun, 11/11 18:20, Brad Smith wrote: > > > ping. > > > > Queued. Will send a pull request soon. > > ping, this seems to have got lost, and is blocking us

[Qemu-devel] [PATCH v3 2/5] virtio-pmem: Add virtio pmem driver

2019-01-09 Thread Pankaj Gupta
This patch adds virtio-pmem driver for KVM guest. Guest reads the persistent memory range information from Qemu over VIRTIO and registers it on nvdimm_bus. It also creates a nd_region object with the persistent memory range information so that existing 'nvdimm/pmem' driver can reserve this into

Re: [Qemu-devel] [PATCH for-4.0 v9 16/16] qemu_thread_join: fix segmentation fault

2019-01-09 Thread Fei Li
在 2019/1/9 上午1:29, Markus Armbruster 写道: fei writes: 在 2019年1月8日,01:55,Markus Armbruster 写道: Fei Li writes: To avoid the segmentation fault in qemu_thread_join(), just directly return when the QemuThread *thread failed to be created in either qemu-thread-posix.c or qemu-thread-win32.c.

Re: [Qemu-devel] [PATCH] spapr/vio: remove the "irq" property"

2019-01-09 Thread Greg Kurz
On Wed, 9 Jan 2019 11:30:28 +0100 Cédric Le Goater wrote: > commit efe2add7cb7f ("spapr/vio: deprecate the "irq" property") was > merged in QEMU version 3.0. The "irq" property" can be removed for > QEMU version 4.0, 2 version later. > > Signed-off-by: Cédric Le Goater > --- > The change in

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-09 Thread Kevin Wolf
Am 09.01.2019 um 15:10 hat Max Reitz geschrieben: > On 06.09.18 13:11, Daniel Henrique Barboza wrote: > > changes in v2: > > - removed the "RFC" marker; > > - added a new patch (patch 2) that removes > > bdrv_snapshot_delete_by_id_or_name from the code; > > - made changes in patch 1 as suggested

[Qemu-devel] [PATCH v3 2/5] virtio-pmem: Add virtio pmem driver

2019-01-09 Thread Pankaj Gupta
This patch adds virtio-pmem driver for KVM guest. Guest reads the persistent memory range information from Qemu over VIRTIO and registers it on nvdimm_bus. It also creates a nd_region object with the persistent memory range information so that existing 'nvdimm/pmem' driver can reserve this into

[Qemu-devel] [PATCH v3 1/5] libnvdimm: nd_region flush callback support

2019-01-09 Thread Pankaj Gupta
This patch adds functionality to perform flush from guest to host over VIRTIO. We are registering a callback based on 'nd_region' type. virtio_pmem driver requires this special flush function. For rest of the region types we are registering existing flush function. Report error returned by host

  1   2   3   4   >