Re: [Qemu-devel] [PATCH 05/19] ppc/pnv: add XIVE support

2019-02-20 Thread David Gibson
On Tue, Feb 19, 2019 at 08:31:25AM +0100, Cédric Le Goater wrote: > On 2/12/19 6:40 AM, David Gibson wrote: > > On Mon, Jan 28, 2019 at 10:46:11AM +0100, Cédric Le Goater wrote: [snip] > >> #endif /* _PPC_PNV_H */ > >> diff --git a/include/hw/ppc/pnv_core.h b/include/hw/ppc/pnv_core.h > >> index

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> -Original Message- > From: Zhao Yan [mailto:yan.y.z...@intel.com] > Sent: Thursday, February 21, 2019 8:25 AM > To: Gonglei (Arei) > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > intel-gvt-...@lists.freedesktop.org; zhengxiao...@alibaba-inc.com; > yi.l@intel.com;

Re: [Qemu-devel] [PATCH 1/5] vfio/migration: define kernel interfaces

2019-02-20 Thread Zhao Yan
On Wed, Feb 20, 2019 at 06:08:13PM +0100, Cornelia Huck wrote: > On Wed, 20 Feb 2019 02:36:36 -0500 > Zhao Yan wrote: > > > On Tue, Feb 19, 2019 at 02:09:18PM +0100, Cornelia Huck wrote: > > > On Tue, 19 Feb 2019 16:52:14 +0800 > > > Yan Zhao wrote: > (...) > > > > + * Size of device

Re: [Qemu-devel] [PATCH] target-i386: Enhance the stub for kvm_arch_get_supported_cpuid()

2019-02-20 Thread Kamil Rytarowski
On 20.02.2019 18:29, Paolo Bonzini wrote: > On 20/02/19 12:59, Kamil Rytarowski wrote: >> Ping, still valid. > > Sorry, I missed your email. > >> On 15.02.2019 00:38, Kamil Rytarowski wrote: >>> I consider it as fragile hack and certainly not something to depend on. >>> Also in some

Re: [Qemu-devel] [PATCH v3 0/5] Add migration support for VFIO device

2019-02-20 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Thursday, February 21, 2019 1:25 PM > > On 2/20/2019 3:52 PM, Dr. David Alan Gilbert wrote: > > * Kirti Wankhede (kwankh...@nvidia.com) wrote: > >> Add migration support for VFIO device > > > > Hi Kirti, > > Can you explain how this

Re: [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup

2019-02-20 Thread Xiao Guangrong
On 2/20/19 8:51 AM, Wei Yang wrote: Three trivial cleanup for pc-dimm. Patch [1] remove the check on class->hotpluggable since pc-dimm is always hotpluggable. Patch [2] remove nvdimm_realize Patch [2] remove pcdimm realize-callback v2: * fix warning in Patch 1 * split Patch 2 into two

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-20 Thread Jason Wang
On 2019/2/21 下午2:00, Yuri Benditovich wrote: On Tue, Feb 19, 2019 at 8:27 AM Jason Wang wrote: On 2019/2/19 上午7:34, Michael S. Tsirkin wrote: On Mon, Feb 18, 2019 at 10:49:08PM +0200, Yuri Benditovich wrote: On Mon, Feb 18, 2019 at 6:39 PM Michael S. Tsirkin wrote: On Mon, Feb 18, 2019

Re: [Qemu-devel] [PATCH 0/4] RFC: make chardev context switching safer

2019-02-20 Thread Peter Xu
On Wed, Feb 20, 2019 at 05:06:24PM +0100, Marc-André Lureau wrote: > Hi, Hi, > > The chardev context switching code is a bit fragile, as it works as if > the current context is properly synchronized with the new context. It > isn't so obvious to me that concurrent usage of chardev can't

Re: [Qemu-devel] [PATCH v3 0/5] Add migration support for VFIO device

2019-02-20 Thread Neo Jia
On Thu, Feb 21, 2019 at 05:52:53AM +, Tian, Kevin wrote: > > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > > Sent: Thursday, February 21, 2019 1:25 PM > > > > On 2/20/2019 3:52 PM, Dr. David Alan Gilbert wrote: > > > * Kirti Wankhede (kwankh...@nvidia.com) wrote: > > >> Add migration

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Zhao Yan
> > > > > 5) About log sync, why not register log_global_start/stop in > > vfio_memory_listener? > > > > > > > > seems log_global_start/stop cannot be iterately called in pre-copy phase? > > for dirty pages in system memory, it's better to transfer dirty data > > iteratively to reduce down time,

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Zhao Yan
On Thu, Feb 21, 2019 at 03:16:45AM +, Gonglei (Arei) wrote: > > > > > -Original Message- > > From: Zhao Yan [mailto:yan.y.z...@intel.com] > > Sent: Thursday, February 21, 2019 10:05 AM > > To: Gonglei (Arei) > > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > >

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/43] ppc-for-4.0 queue 20190219

2019-02-20 Thread David Gibson
On Wed, Feb 20, 2019 at 05:54:25PM +0100, Greg Kurz wrote: > On Wed, 20 Feb 2019 15:49:41 + > Peter Maydell wrote: > > > On Wed, 20 Feb 2019 at 15:43, Greg Kurz wrote: > > > I have an account. I'll start updating the wiki according to what was > > > actually merged up to this pull request.

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> > > > > -Original Message- > > > From: Zhao Yan [mailto:yan.y.z...@intel.com] > > > Sent: Thursday, February 21, 2019 10:05 AM > > > To: Gonglei (Arei) > > > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > > > intel-gvt-...@lists.freedesktop.org; zhengxiao...@alibaba-inc.com; >

Re: [Qemu-devel] m68k gdb has stopped single stepping correctly

2019-02-20 Thread Lucien Anti-Spam via Qemu-devel
Hi Thomas, > did you ever sent the patch? I can't find it on the mailing list, and I think >this bug is still pending?Yes, I have patches but was waiting for my first one >to be successful in order to make sure I got the process down.  I will finish >that shortly. CheersLuc On 24/01/2019

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> -Original Message- > From: Zhao Yan [mailto:yan.y.z...@intel.com] > Sent: Thursday, February 21, 2019 12:08 PM > To: Gonglei (Arei) > Cc: c...@nvidia.com; k...@vger.kernel.org; a...@ozlabs.ru; > zhengxiao...@alibaba-inc.com; shuangtai@alibaba-inc.com; > qemu-devel@nongnu.org;

[Qemu-devel] [PATCH v2] ui/gtk: Fix the license information

2019-02-20 Thread Thomas Huth
The license information in this file is very messy. A short note at the beginning says GPL first, but the long boilerplate code then talks about "GNU Lesser General Public License version 2.0". First, there is no such version of the "GNU Lesser GPL", it only started with version 2.1. In version

Re: [Qemu-devel] [PATCH v2 2/3] vfio/display: add xres + yres properties

2019-02-20 Thread Gerd Hoffmann
Hi, > > +DEFINE_PROP_UINT32("xres", VFIOPCIDevice, display_xres, 0), > > +DEFINE_PROP_UINT32("yres", VFIOPCIDevice, display_yres, 0), > > This is actually quite fun, I started my VM with arbitrary numbers and > the Windows GUI honored it every time. Probably very useful for > playing

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Zhao Yan
On Thu, Feb 21, 2019 at 01:35:43AM +, Gonglei (Arei) wrote: > > > > -Original Message- > > From: Zhao Yan [mailto:yan.y.z...@intel.com] > > Sent: Thursday, February 21, 2019 8:25 AM > > To: Gonglei (Arei) > > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > >

Re: [Qemu-devel] [qemu-s390x] [PATCH 15/15] s390-bios: Support booting from real dasd device

2019-02-20 Thread Eric Farman
On 01/29/2019 08:29 AM, Jason J. Herne wrote: Allows guest to boot from a vfio configured real dasd device. Signed-off-by: Jason J. Herne --- docs/devel/s390-dasd-ipl.txt | 132 +++ pc-bios/s390-ccw/Makefile| 2 +- pc-bios/s390-ccw/dasd-ipl.c | 249

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> -Original Message- > From: Zhao Yan [mailto:yan.y.z...@intel.com] > Sent: Thursday, February 21, 2019 9:59 AM > To: Gonglei (Arei) > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > intel-gvt-...@lists.freedesktop.org; zhengxiao...@alibaba-inc.com; > yi.l@intel.com;

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Zhao Yan
On Thu, Feb 21, 2019 at 03:33:24AM +, Gonglei (Arei) wrote: > > > -Original Message- > > From: Zhao Yan [mailto:yan.y.z...@intel.com] > > Sent: Thursday, February 21, 2019 9:59 AM > > To: Gonglei (Arei) > > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > >

Re: [Qemu-devel] [PATCH v3 0/5] Add migration support for VFIO device

2019-02-20 Thread Kirti Wankhede
On 2/20/2019 3:52 PM, Dr. David Alan Gilbert wrote: > * Kirti Wankhede (kwankh...@nvidia.com) wrote: >> Add migration support for VFIO device > > Hi Kirti, > Can you explain how this compares and works with Yan Zhao's > set? This patch set is incremental version of my previous patch set:

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-20 Thread Yuri Benditovich
On Tue, Feb 19, 2019 at 8:27 AM Jason Wang wrote: > > > On 2019/2/19 上午7:34, Michael S. Tsirkin wrote: > > On Mon, Feb 18, 2019 at 10:49:08PM +0200, Yuri Benditovich wrote: > >> On Mon, Feb 18, 2019 at 6:39 PM Michael S. Tsirkin wrote: > >>> On Mon, Feb 18, 2019 at 11:58:51AM +0200, Yuri

Re: [Qemu-devel] [PATCH v2 1/3] vfio/display: add edid support.

2019-02-20 Thread Gerd Hoffmann
On Wed, Feb 20, 2019 at 02:54:35PM -0700, Alex Williamson wrote: > On Wed, 20 Feb 2019 09:47:51 +0100 > Gerd Hoffmann wrote: > > > This patch adds EDID support to the vfio display (aka vgpu) code. > > When supported by the mdev driver qemu will generate a EDID blob > > and pass it on using the

Re: [Qemu-devel] [PATCH v6 0/7] vhost-user-blk: Add support for backend reconnecting

2019-02-20 Thread Yongji Xie
On Thu, 21 Feb 2019 at 04:00, Michael S. Tsirkin wrote: > > On Mon, Feb 18, 2019 at 06:27:41PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > This patchset is aimed at supporting qemu to reconnect > > vhost-user-blk backend after vhost-user-blk backend crash or > > restart. > > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> -Original Message- > From: Zhao Yan [mailto:yan.y.z...@intel.com] > Sent: Thursday, February 21, 2019 10:05 AM > To: Gonglei (Arei) > Cc: alex.william...@redhat.com; qemu-devel@nongnu.org; > intel-gvt-...@lists.freedesktop.org; zhengxiao...@alibaba-inc.com; > yi.l@intel.com;

Re: [Qemu-devel] [PATCH v11 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2019-02-20 Thread Wei Wang
On 02/20/2019 09:12 PM, Dr. David Alan Gilbert wrote: * Wang, Wei W (wei.w.w...@intel.com) wrote: On Friday, December 14, 2018 7:17 PM, Dr. David Alan Gilbert wrote: On 12/14/2018 05:56 PM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: On 12/13/2018 11:45 PM, Dr.

Re: [Qemu-devel] [PATCH v6 01/18] update-linux-headers.sh: Copy new headers

2019-02-20 Thread Alexey Kardashevskiy
On 15/02/2019 03:36, Peter Maydell wrote: > On Tue, 5 Feb 2019 at 17:33, Eric Auger wrote: >> >> From: Alexey Kardashevskiy >> >> Since Linux'es ab66dcc76d "powerpc: generate uapi header and system call >> table files" there are 2 new files: unistd_32.h and unistd_64.h. These >> files content

Re: [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup

2019-02-20 Thread Wei Yang
On Thu, Feb 21, 2019 at 02:03:19PM +0800, Xiao Guangrong wrote: > > >On 2/20/19 8:51 AM, Wei Yang wrote: >> Three trivial cleanup for pc-dimm. >> >> Patch [1] remove the check on class->hotpluggable since pc-dimm is always >> hotpluggable. >> Patch [2] remove nvdimm_realize >> Patch [2] remove

Re: [Qemu-devel] [PATCH v3 19/25] s390/ebcdic: Use size_t to iterate over arrays

2019-02-20 Thread Philippe Mathieu-Daudé
On 2/20/19 10:40 AM, Cornelia Huck wrote: > On Wed, 20 Feb 2019 02:02:26 +0100 > Philippe Mathieu-Daudé wrote: > >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/hw/s390x/ebcdic.h | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
Hi yan, Thanks for your work. I have some suggestions or questions: 1) Would you add msix mode support,? if not, pls add a check in vfio_pci_save_config(), likes Nvidia's solution. 2) We should start vfio devices before vcpu resumes, so we can't rely on vm start change handler completely. 3)

[Qemu-devel] [PATCH v2 1/8] multifd: Only send pages when packet are not empty

2019-02-20 Thread Juan Quintela
We send packages without pages sometimes for sysnchronizanion. The iov functions do the right thing, but we will be changing this code in future patches. Signed-off-by: Juan Quintela --- migration/ram.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] target-i386: Enhance the stub for kvm_arch_get_supported_cpuid()

2019-02-20 Thread Kamil Rytarowski
Ping, still valid. On 15.02.2019 00:38, Kamil Rytarowski wrote: > On 14.02.2019 21:51, Paolo Bonzini wrote: >> On 14/02/19 20:41, Kamil Rytarowski wrote: >>> Please do replace the current kludge that is sensitive to: >>> - compiler behavior that can change with new versions >>> - compiler

Re: [Qemu-devel] [PATCH v2] Add a gitlab-ci file for Continuous Integration testing on Gitlab

2019-02-20 Thread Alex Bennée
Thomas Huth writes: > This is very convenient for people like me who store their QEMU git trees > on gitlab.com: Automatic CI pipelines are now run for each branch that is > pushed to the server - useful for some extra-testing before sending PULL- > requests for example. Since the runtime of

Re: [Qemu-devel] [PATCH v2] travis: the xcode10 image seems to be hosed

2019-02-20 Thread Alex Bennée
Paolo Bonzini writes: > It fails to install homebrew. Unfortunately we cannot mark > it as an expected failure because Travis does not match > allow_failures rows against include rows (only against the > main test matrix, which we do not use at all), so just disable > it. > > Signed-off-by:

[Qemu-devel] [PATCH v2 8/8] tests: Add migration multifd test

2019-02-20 Thread Juan Quintela
We set multifd-channels. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- tests/migration-test.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index

[Qemu-devel] [PATCH v2 4/8] multifd: Drop x-multifd-page-count parameter

2019-02-20 Thread Juan Quintela
Libvirt don't want to expose (and explain it). From now on we measure the number of packages in bytes instead of pages, so it is the same independently of architecture. We choose the page size of x86. Notice that in the following patch we make this variable. Signed-off-by: Juan Quintela ---

[Qemu-devel] [PATCH v2 3/8] multifd: Create new next_packet_size field

2019-02-20 Thread Juan Quintela
We need to send this field when we add compression support. As we are still on x- stage, we can do this kind of changes. Signed-off-by: Juan Quintela --- migration/ram.c| 15 +-- migration/trace-events | 4 ++-- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] qemu-img: fix error reporting for -object

2019-02-20 Thread Kevin Wolf
Am 19.02.2019 um 12:46 hat Daniel P. Berrangé geschrieben: > Error reporting for user_creatable_add_opts_foreach was changed so that > it no longer called 'error_report_err' in: > > commit 7e1e0c11127bde81cff260fc6859690435c509d6 > Author: Markus Armbruster > Date: Wed Oct 17 10:26:43

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Gonglei (Arei)
> -Original Message- > From: Cornelia Huck [mailto:coh...@redhat.com] > Sent: Wednesday, February 20, 2019 7:43 PM > To: Gonglei (Arei) > Cc: Dr. David Alan Gilbert ; Zhao Yan > ; c...@nvidia.com; k...@vger.kernel.org; > a...@ozlabs.ru; zhengxiao...@alibaba-inc.com;

[Qemu-devel] [PATCH v2 7/8] multifd: Drop x-

2019-02-20 Thread Juan Quintela
We make it supported from now on. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- hmp.c | 10 +- migration/migration.c | 26 +- qapi/migration.json | 34 +- 3 files changed, 35 insertions(+),

Re: [Qemu-devel] [PATCH v3 25/25] chardev: Let qemu_chr_write[_all] use size_t

2019-02-20 Thread Philippe Mathieu-Daudé
On 2/20/19 11:42 AM, Marc-André Lureau wrote: > Hi > > On Wed, Feb 20, 2019 at 11:39 AM Daniel P. Berrangé > wrote: >> >> On Wed, Feb 20, 2019 at 02:02:32AM +0100, Philippe Mathieu-Daudé wrote: >> >>> diff --git a/include/chardev/char.h b/include/chardev/char.h >>> index 0341dd1ba2..2e3b5a15ca

[Qemu-devel] [PATCH v2 0/8] migration: Make multifd not experimental

2019-02-20 Thread Juan Quintela
v2: - Measure packet size in bytes/not pages - Change the defalut value from 64KB to 512KB - rename used field to pages_used - rename size field to pages_alloc - Create nnext_packet_size field Will be used on compression series later. - Be flexible about what packet sizes we allow. Please

[Qemu-devel] [PATCH v2 2/8] multifd: Rename "size" member to pages_alloc

2019-02-20 Thread Juan Quintela
It really indicates what is the number of allocated pages for one packet. Once there rename "used" to "pages_used". Signed-off-by: Juan Quintela --- migration/ram.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/migration/ram.c b/migration/ram.c

[Qemu-devel] [RFC PATCH] hw/sd/sdhci: Move PCI-related code into a separate file

2019-02-20 Thread Thomas Huth
Some machines have an SDHCI device, but no PCI. To be able to compile hw/sd/sdhci.c without CONFIG_PCI, we must not call functions like pci_get_address_space() and pci_allocate_irq() there. Thus move the PCI-related code into a separate file. This is required for the upcoming Kconfig-like build

Re: [Qemu-devel] [PATCH v3 00/25] chardev: Convert qemu_chr_write() to take a size_t argument

2019-02-20 Thread Daniel P . Berrangé
On Wed, Feb 20, 2019 at 11:53:42AM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Feb 20, 2019 at 2:02 AM Philippe Mathieu-Daudé > wrote: > > > > Hi, > > > > This series convert the chardev::qemu_chr_write() to take unsigned > > length argument. To do so I went through all caller and checked

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-20 Thread Cornelia Huck
On Wed, 20 Feb 2019 11:28:46 + "Gonglei (Arei)" wrote: > > -Original Message- > > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > > Sent: Wednesday, February 20, 2019 7:02 PM > > To: Zhao Yan > > Cc: c...@nvidia.com; k...@vger.kernel.org; a...@ozlabs.ru; > >

[Qemu-devel] [PATCH v2 6/8] multifd: Change default packet size

2019-02-20 Thread Juan Quintela
We moved from 64KB to 512KB, as it makes less locking contention without any downside in testing. Signed-off-by: Juan Quintela --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 75a8fc21f8..d57db00ce4 100644 ---

[Qemu-devel] [PATCH v2 5/8] multifd: Be flexible about packet size

2019-02-20 Thread Juan Quintela
This way we can change the packet size in the future and everything will work. We choose an arbitrary big number (100 times configured size) as a limit about how big we will reallocate. Signed-off-by: Juan Quintela --- migration/ram.c | 24 ++-- 1 file changed, 18

Re: [Qemu-devel] [PATCH 0/3] target/arm: Implement ARMv8.5-CondM

2019-02-20 Thread Richard Henderson
On 2/20/19 2:07 AM, Laurent Desnogues wrote: > I tested xaflag/axflag (after setting the ID_AA64ISAR0 TS field to 2). Whoops, at least that line is missing. ;-) r~

[Qemu-devel] [Bug 1685242] Re: ovmf hangs at efi with virtio-net memory hotplug

2019-02-20 Thread Laszlo Ersek (Red Hat)
* From "debug-nonworking.log": > GetFirstNonAddress: Pci64Base=0x88 Pci64Size=0x8 > [...] > PublishPeiMemory: mPhysMemAddressWidth=40 PeiMemoryCap=69644 KB > [...] > Type = Mem64; Base = 0x88; Length = 0x10; Alignment = > 0xF > Base = 0x88; Length

Re: [Qemu-devel] [PATCH v13 2/3] migration: Create socket-address parameter

2019-02-20 Thread Eric Blake
On 2/20/19 3:22 AM, Juan Quintela wrote: > It will be used to store the uri parameters. We want this only for > tcp, so we don't set it for other uris. We need it to know what port > is migration running. > > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan Quintela > > -- > +++

[Qemu-devel] [PATCH 12/19] migration: Add a VMSTATE_BOOL_TEST() macro

2019-02-20 Thread minyard
From: Corey Minyard This will be needed by coming I2C changes. Signed-off-by: Corey Minyard Reviewed-by: Dr. David Alan Gilbert --- include/migration/vmstate.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index

[Qemu-devel] [PATCH 01/19] i2c: Split smbus into parts

2019-02-20 Thread minyard
From: Corey Minyard smbus.c and smbus.h had device side code, master side code, and smbus.h has some smbus_eeprom.c definitions. Split them into separate files. Signed-off-by: Corey Minyard Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- MAINTAINERS

[Qemu-devel] [PATCH] fixup! vhost-user-test: create a main loop per TestServer

2019-02-20 Thread Paolo Bonzini
Fix a hang that is only latent until qgraph is merged. Signed-off-by: Paolo Bonzini --- tests/vhost-user-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 33030e0..527d3b3 100644 --- a/tests/vhost-user-test.c

[Qemu-devel] [PATCH 1/2] qga: process_event() simplification

2019-02-20 Thread Marc-André Lureau
Simplify the code around qmp_dispatch(): - rely on qmp_dispatch/check_obj() for message checking - have a single send_response() point - constify send_response() argument It changes a couple of error messages: * When @req isn't a dictionary, from Invalid JSON syntax to QMP input must

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/43] ppc-for-4.0 queue 20190219

2019-02-20 Thread Greg Kurz
On Tue, 19 Feb 2019 09:37:44 + Peter Maydell wrote: > On Mon, 18 Feb 2019 at 14:30, David Gibson > wrote: > > > > The following changes since commit 1e36232994c8ad01774501d2e299deba3a2469af: > > > > Merge remote-tracking branch > > 'remotes/mcayland/tags/qemu-openbios-20190215' into

Re: [Qemu-devel] [PATCH 05/51] kconfig: introduce kconfig files

2019-02-20 Thread Paolo Bonzini
On 20/02/19 16:42, Thomas Huth wrote: > On 07/02/2019 18.56, Paolo Bonzini wrote: >> The Kconfig files were generated mostly with this script: >> >> for i in `grep -ho CONFIG_[A-Z0-9_]* default-configs/* | sort -u`; do >> set fnord `git grep -lw $i -- 'hw/*/Makefile.objs' ` >> shift >>

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/43] ppc-for-4.0 queue 20190219

2019-02-20 Thread Cédric Le Goater
On 2/20/19 4:49 PM, Peter Maydell wrote: > On Wed, 20 Feb 2019 at 15:43, Greg Kurz wrote: >> I have an account. I'll start updating the wiki according to what was >> actually merged up to this pull request. > > Thanks. Personally I've found for the arm parts of the changelog > that it's much

Re: [Qemu-devel] MemoryRegionOps access sizes

2019-02-20 Thread Peter Maydell
On Fri, 15 Feb 2019 at 09:56, BALATON Zoltan wrote: > > Hello, > > Could someone please explain how the MemoryRegionOps > valid.{min,max}_access_size and unaligned and corresponding impl > constraints work and where are these implemented? And in particular if > this would work: > > static const

Re: [Qemu-devel] [PATCH v3 04/25] chardev: Let qemu_chr_be_can_write() return a size_t types

2019-02-20 Thread Marc-André Lureau
Hi On Wed, Feb 20, 2019 at 12:26 PM Philippe Mathieu-Daudé wrote: > > On 2/20/19 11:40 AM, Marc-André Lureau wrote: > > Hi > > > > On Wed, Feb 20, 2019 at 2:04 AM Philippe Mathieu-Daudé > > wrote: > >> > >> In the previous commit we added an assert to be sure than > >> qemu_chr_be_can_write()

Re: [Qemu-devel] [PATCH] kbd-state: don't block auto-repeat events

2019-02-20 Thread Eric Blake
On 2/20/19 4:02 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/kbd-state.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/ui/kbd-state.c b/ui/kbd-state.c > index ac14add70e..09e3cfedfc 100644 > --- a/ui/kbd-state.c > +++

[Qemu-devel] [PATCH] ui/gtk: Fix the license information

2019-02-20 Thread Thomas Huth
The license information in this file is very messy. A short note at the beginning says GPL first, but the long boilerplate code then talks about "GNU Lesser General Public License version 2.0". First, there is no such version of the "GNU Lesser GPL", it only started with version 2.1. In version

Re: [Qemu-devel] [PATCH v5 10/10] tests/virtio-blk: add test for DISCARD command

2019-02-20 Thread Stefan Hajnoczi
On Mon, Feb 18, 2019 at 03:03:01PM +0100, Stefano Garzarella wrote: > If the DISCARD feature is enabled, we try this command in the > test_basic(), checking only the status returned by the request. > > Signed-off-by: Stefano Garzarella > --- > tests/virtio-blk-test.c | 27

Re: [Qemu-devel] [PATCH] ui/gtk: Fix the license information

2019-02-20 Thread Daniel P . Berrangé
On Wed, Feb 20, 2019 at 05:05:35PM +0100, Thomas Huth wrote: > The license information in this file is very messy. A short note at > the beginning says GPL first, but the long boilerplate code then > talks about "GNU Lesser General Public License version 2.0". First, > there is no such version of

Re: [Qemu-devel] [PATCH v3 24/25] chardev: Let qemu_chr_fe_write[_all] use size_t type argument

2019-02-20 Thread Marc-André Lureau
On Wed, Feb 20, 2019 at 2:08 AM Philippe Mathieu-Daudé wrote: > > All caller have been audited and call these functions with > unsigned arguments. > > Most of them use a size_t argument, or directly pass sizeof(). > > One case is unclear: the mux_chr_write() call in chardev/char-mux.c. > There we

Re: [Qemu-devel] [PATCH v6 31/73] cpu: convert to cpu_halted

2019-02-20 Thread Richard Henderson
On 1/29/19 4:47 PM, Emilio G. Cota wrote: > This finishes the conversion to cpu_halted. > > Signed-off-by: Emilio G. Cota > --- > cpus.c| 8 > qom/cpu.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v2 1/2] iotests: ensure we print nbd server log on error

2019-02-20 Thread Daniel P . Berrangé
If we abort the iotest early the server.log file might contain useful information for diagnosing the problem. Ensure its contents are displayed in this case. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- tests/qemu-iotests/233 | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [Qemu-devel] [PATCH 1/2] qga: process_event() simplification

2019-02-20 Thread Eric Blake
On 2/20/19 9:42 AM, Marc-André Lureau wrote: > Simplify the code around qmp_dispatch(): > - rely on qmp_dispatch/check_obj() for message checking > - have a single send_response() point > - constify send_response() argument > > It changes a couple of error messages: > > * When @req isn't a

[Qemu-devel] [PATCH v2 0/2] Fix NBD TLS iotests on RHEL-7

2019-02-20 Thread Daniel P . Berrangé
This fixes a failure of iotest 233 due to certtool problesm in RHEL7 wrt to SIGPIPE Changed in v2: - Put certtool.log into the $tls_dir instead of cwd Daniel P. Berrangé (2): iotests: ensure we print nbd server log on error iotests: avoid broken pipe with certtool tests/qemu-iotests/233

Re: [Qemu-devel] Why only devdax guarantees guest data persistence ?

2019-02-20 Thread Pankaj Gupta
> wrote: > > Text from "docs/nvdimm.txt" says: > > Guest Data Persistence > > -- > > > > Though QEMU supports multiple types of vNVDIMM backends on Linux, > > currently the only one that can guarantee the guest write persistence > > is the device DAX on the real NVDIMM

Re: [Qemu-devel] [PATCH 07/12] nbd: Increase bs->in_flight during AioContext switch

2019-02-20 Thread Kevin Wolf
Am 18.02.2019 um 18:22 hat Paolo Bonzini geschrieben: > On 18/02/19 17:18, Kevin Wolf wrote: > > +/* aio_ctx_switch is only supposed to be set if we're sitting > > in > > + * the qio_channel_yield() below. */ > > +assert(!*aio_ctx_switch); > >

Re: [Qemu-devel] [PATCH 1/5] vfio/migration: define kernel interfaces

2019-02-20 Thread Cornelia Huck
On Wed, 20 Feb 2019 02:36:36 -0500 Zhao Yan wrote: > On Tue, Feb 19, 2019 at 02:09:18PM +0100, Cornelia Huck wrote: > > On Tue, 19 Feb 2019 16:52:14 +0800 > > Yan Zhao wrote: (...) > > > + * Size of device config data is smaller than or equal to that > > > of > > > + * device

[Qemu-devel] [PATCH 10/19] boards.h: Ignore migration for SMBus devices on older machines

2019-02-20 Thread minyard
From: Corey Minyard Migration capability is being added for pm_smbus and SMBus devices. This change will allow backwards compatibility to be kept when migrating back to an old qemu version. Add a bool to the machine class tho keep smbus migration from happening. Future changes will use this.

Re: [Qemu-devel] [PATCH v2] target/mips: implement QMP query-cpu-definitions command

2019-02-20 Thread Aleksandar Markovic
> From: Markus Armbruster > Subject: Re: [Qemu-devel] [PATCH v2] target/mips: implement QMP > query-cpu-definitions command ... > Reviewed-by: Markus Armbruster Unless there is somebody's objection, I am going to accept this patch into the next MIPS pull request, planned to be sent in next

[Qemu-devel] [PATCH 03/19] arm:i2c: Don't mask return from i2c_recv()

2019-02-20 Thread minyard
From: Corey Minyard It can't fail, and now that it returns a uint8_t a 0xff mask is unnecessary. Signed-off-by: Corey Minyard Suggested-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/arm/stellaris.c | 2 +- 1 file

[Qemu-devel] [Bug 1685242] Re: ovmf hangs at efi with virtio-net memory hotplug

2019-02-20 Thread Laszlo Ersek (Red Hat)
The reason why it behaves differently with machine types <= 2.4 is that - up to and including qemu-2.4, the calculation of the DIMM hotplug area was incorrect, - in 2.5, the calculation was fixed, - but for the migration compatibility of machine types <= 2.4, the old calculation was preserved

[Qemu-devel] [PATCH 02/19] i2c: have I2C receive operation return uint8_t

2019-02-20 Thread minyard
From: Corey Minyard It is never supposed to fail and cannot return an error, so just have it return the proper type. Have it return 0xff on nothing available, since that's what would happen on a real bus. Signed-off-by: Corey Minyard Reviewed-by: Peter Maydell Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH v6 12/18] hw/arm/boot: Expose the PC-DIMM nodes in the DT

2019-02-20 Thread Auger Eric
Hi Igor, On 2/18/19 9:58 AM, Igor Mammedov wrote: > On Tue, 5 Feb 2019 18:33:00 +0100 > Eric Auger wrote: > >> From: Shameer Kolothum >> >> This patch add memory nodes corresponding to PC-DIMM regions. > s/add/adds/ or s/This patch add/Add/ > >> >> NV_DIMM and ACPI_NVDIMM configs are not yet

[Qemu-devel] [PATCH 13/19] i2c:pm_smbus: Fix state transfer

2019-02-20 Thread minyard
From: Corey Minyard Transfer the state information for the SMBus registers and internal data so it will work on a VM transfer. Signed-off-by: Corey Minyard Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Dr. David Alan Gilbert Reviewed-by: Dr. David Alan Gilbert --- hw/acpi/piix4.c

Re: [Qemu-devel] [PATCH 28/51] ipmi: express dependencies with kconfig

2019-02-20 Thread Corey Minyard
On Thu, Feb 07, 2019 at 06:57:11PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > Message-Id: <20190123065618.3520-36-yang.zh...@intel.com> > Reviewed-by: Thomas Huth > Signed-off-by: Paolo Bonzini > --- > default-configs/i386-softmmu.mak | 3 --- >

[Qemu-devel] [PATCH] chardev-socket: do not blindly reset handlers when switching GMainContext

2019-02-20 Thread Paolo Bonzini
If the socket is connecting or connected, tcp_chr_update_read_handler will be called but it should not set the NetListener's callbacks again. Otherwise, tcp_chr_accept is invoked while the socket is in connected state and you get an assertion failure. Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PATCH 2/2] qmp: common 'id' handling & make QGA conform to QMP spec

2019-02-20 Thread Marc-André Lureau
Let qmp_dispatch() copy the 'id' field. That way any qmp client will conform to the specification, including QGA. Furthermore, it simplifies the work for qemu monitor. CC: Michael Roth Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- monitor.c | 33

[Qemu-devel] [PATCH 2/3] multifd: compression support variables

2019-02-20 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index d57db00ce4..7de27e1a35 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -597,6 +597,12 @@ typedef

[Qemu-devel] [PATCH 1/4] iothread: wait until the glib context is acquired

2019-02-20 Thread Marc-André Lureau
Another thread may acquire the glib context (temporarily) before g_main_context_push_thread_default(). This can happen with the following qemu_chr_fe_set_handlers() modifications. Unfortunately, g_main_context_wait() is deprecated in glib 2.58 (apparently it was a broken interface). Use a

[Qemu-devel] [PATCH 0/4] RFC: make chardev context switching safer

2019-02-20 Thread Marc-André Lureau
Hi, The chardev context switching code is a bit fragile, as it works as if the current context is properly synchronized with the new context. It isn't so obvious to me that concurrent usage of chardev can't happen, as there might be various main loop sources being dispatched during the switch.

[Qemu-devel] [PATCH 06/19] i2c:smbus: Simplify write operation

2019-02-20 Thread minyard
From: Corey Minyard There were two different write functions and the SMBus code kept track of the command. Keeping track of the command wasn't useful, in fact it wasn't quite correct for the eeprom_smbus code. And there is no need for two write functions. Just have one write function and the

[Qemu-devel] [PATCH 4/4] char-socket: restart the reconnect timer to switch context

2019-02-20 Thread Marc-André Lureau
The reconnect timer is not switched to the given context, fix it. Signed-off-by: Marc-André Lureau --- chardev/char-socket.c | 5 + 1 file changed, 5 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 4fcdd8aedd..671861f98c 100644 --- a/chardev/char-socket.c +++

Re: [Qemu-devel] [Qemu-block] [PATCH v5 05/10] virtio-blk: set config size depending on the features enabled

2019-02-20 Thread Stefan Hajnoczi
On Mon, Feb 18, 2019 at 03:02:56PM +0100, Stefano Garzarella wrote: > Starting from DISABLE and WRITE_ZEROES features, we use an array of > VirtIOFeature (as virtio-net) to properly set the config size > depending on the features enabled. > > Signed-off-by: Stefano Garzarella > --- >

Re: [Qemu-devel] [PATCH v5 05/17] spapr/drc: Drop spapr_drc_attach() fdt argument

2019-02-20 Thread David Gibson
On Wed, Feb 20, 2019 at 10:01:23AM +0100, Greg Kurz wrote: > On Wed, 20 Feb 2019 14:22:19 +1100 > David Gibson wrote: > > > On Tue, Feb 19, 2019 at 06:17:58PM +0100, Greg Kurz wrote: > > > All DRC subtypes have been converted to generate the FDT fragment at > > > configure connector time instead

[Qemu-devel] [PATCH 3/3] multifd: Start of zlib compression code

2019-02-20 Thread Juan Quintela
This is still work in progress. It is already faster that normal compression code inside qemu. It don't do any unnecesary copies. And as packages are bigger, we get better compression. Signed-off-by: Juan Quintela --- hmp.c | 6 ++- migration/ram.c| 96

Re: [Qemu-devel] [PATCH] shippable: fix build

2019-02-20 Thread Alex Bennée
Paolo Bonzini writes: > It looks like something in netmap has changed and compilation fails: > >install -D libnetmap.a //usr/local/lib/libnetmap.a >install: cannot stat libnetmap.a: No such file or directory > > Add an explicit "make" step to fix it. I took an alternate approach as

Re: [Qemu-devel] [PATCH v11 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2019-02-20 Thread Dr. David Alan Gilbert
* Wang, Wei W (wei.w.w...@intel.com) wrote: > On Friday, December 14, 2018 7:17 PM, Dr. David Alan Gilbert wrote: > > > On 12/14/2018 05:56 PM, Dr. David Alan Gilbert wrote: > > > > * Wei Wang (wei.w.w...@intel.com) wrote: > > > > > On 12/13/2018 11:45 PM, Dr. David Alan Gilbert wrote: > > > > > >

Re: [Qemu-devel] [PATCH v2] target/mips: implement QMP query-cpu-definitions command

2019-02-20 Thread Markus Armbruster
Aleksandar Markovic writes: >> From: Markus Armbruster >> Subject: Re: [Qemu-devel] [PATCH v2] target/mips: implement QMP >> query-cpu-definitions command > > ... > >> Reviewed-by: Markus Armbruster > > Unless there is somebody's objection, I am going to accept this patch into > the next >

Re: [Qemu-devel] [PATCH] chardev-socket: do not blindly reset handlers when switching GMainContext

2019-02-20 Thread Marc-André Lureau
Hi On Wed, Feb 20, 2019 at 5:08 PM Paolo Bonzini wrote: > > If the socket is connecting or connected, tcp_chr_update_read_handler will > be called but it should not set the NetListener's callbacks again. > Otherwise, tcp_chr_accept is invoked while the socket is in connected > state and you get

Re: [Qemu-devel] [PATCH v7 00/35] target/riscv: Convert to decodetree

2019-02-20 Thread Bastian Koppelmann
Hi Palmer, On 2/13/19 4:53 PM, Palmer Dabbelt wrote: Palmer: I caused some merge conflicts in Bastian's patch set so I figured I'd attempt to clean these up. As far as I'm concerned v6 was good to go, but since the merge conflicts were fairly extensive (if somewhat mechanical) I'd like to pass

Re: [Qemu-devel] [PATCH] shippable: fix build

2019-02-20 Thread Philippe Mathieu-Daudé
Hi Paolo, Please also Cc reviewers :) On 2/20/19 11:45 AM, Paolo Bonzini wrote: > It looks like something in netmap has changed and compilation fails: Partly my fault, I had the intention to add a git 'stable' tag for reproducible builds [*] but forgot to add to my TODO list :/ [*]

Re: [Qemu-devel] [PATCH v6 16/18] hw/arm/virt: Add nvdimm hot-plug infrastructure

2019-02-20 Thread Auger Eric
Hi Igor, On 2/18/19 11:30 AM, Igor Mammedov wrote: > On Tue, 5 Feb 2019 18:33:04 +0100 > Eric Auger wrote: > >> From: Kwangwoo Lee >> >> Pre-plug and plug handlers are prepared for NVDIMM support. >> >> Signed-off-by: Eric Auger >> Signed-off-by: Kwangwoo Lee >> --- >>

Re: [Qemu-devel] [PATCH v3 00/25] chardev: Convert qemu_chr_write() to take a size_t argument

2019-02-20 Thread Eric Blake
On 2/20/19 5:30 AM, Daniel P. Berrangé wrote: >> Since Paolo you suggested the change, could you give some convincing >> arguments that it's worth taking the plunge? > > The chardev write/read methods will end up calling libc read/write > methods, whose parameters are "size_t count". In my

[Qemu-devel] [PATCH 19/19] i2c: Verify that the count passed in to smbus_eeprom_init() is valid

2019-02-20 Thread minyard
From: Corey Minyard Keep someone from passing in a bogus number Signed-off-by: Corey Minyard --- hw/i2c/smbus_eeprom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index 44887b4a27..ee392f7cb1 100644 --- a/hw/i2c/smbus_eeprom.c +++

  1   2   3   4   >