Re: [Qemu-devel] [PATCH v2 0/7] s390x/tcg: Cleanups and refactorings for vector instructions

2019-02-26 Thread Cornelia Huck
On Mon, 25 Feb 2019 21:03:11 +0100 David Hildenbrand wrote: > Before we start with the real magic, some more cleanups and refactorings. > This series does not depend on other patches not yet in master. > > Also add a variant of "LOAD LENGTHENED" that is used along with > vector instructions in

Re: [Qemu-devel] [PATCH] riscv: Add proper alignment check and pending 'C' extension upon misa writes

2019-02-26 Thread Amed Magdy
> > >> > It seems to me that the C extension can be enabled at any point, since >> if C is >> > off, you know that the next insn is aligned modulo 4. >> > >> > > > Ok, This is mostly right. When C extension is enabled 32-bit base > instructions can be aligned on 2 bytes boundaries instead of 4

Re: [Qemu-devel] Build error with git commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116 on x86_64

2019-02-26 Thread Thomas Huth
On 25/02/2019 18.29, Andrew Randrianasulu wrote: > В сообщении от Monday 25 February 2019 19:19:01 Philippe Mathieu-Daudc3a9 > написал(а): >> Hi Andrew, >> >> On 2/23/19 1:35 AM, Andrew Randrianasulu wrote: >>> Hello! >>> >>> I just pulled latest git >> >> [...] >> >>> and default build with

Re: [Qemu-devel] [PATCH v7 00/17] ARM virt: Initial RAM expansion and PCDIMM/NVDIMM support

2019-02-26 Thread Auger Eric
Hi Igor, On 2/25/19 10:42 AM, Igor Mammedov wrote: > On Fri, 22 Feb 2019 18:35:26 +0100 > Auger Eric wrote: > >> Hi Igor, >> >> On 2/22/19 5:27 PM, Igor Mammedov wrote: >>> On Wed, 20 Feb 2019 23:39:46 +0100 >>> Eric Auger wrote: >>> This series aims to bump the 255GB RAM limit in

Re: [Qemu-devel] Build error with git commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116 on x86_64

2019-02-26 Thread Andrew Randrianasulu
В сообщении от Tuesday 26 February 2019 11:54:12 вы написали: > On 25/02/2019 18.29, Andrew Randrianasulu wrote: > > В сообщении от Monday 25 February 2019 19:19:01 Philippe Mathieu-Daudc3a9 > > > > написал(а): > >> Hi Andrew, > >> > >> On 2/23/19 1:35 AM, Andrew Randrianasulu wrote: > >>> Hello!

Re: [Qemu-devel] [PATCH v3 0/3] softmmu demacro

2019-02-26 Thread Alex Bennée
Mark Cave-Ayland writes: > On 19/02/2019 18:25, Emilio G. Cota wrote: > >> On Tue, Feb 19, 2019 at 14:22:37 +, Alex Bennée wrote: >>> Emilio, >>> >>> Any chance you could run it through your benchmark suite? >> >> Something isn't quite right. For instance, gcc in SPEC doesn't >> complete;

Re: [Qemu-devel] [PATCH v3] iotests: use -M accel=qtest in 238

2019-02-26 Thread Kevin Wolf
Am 25.02.2019 um 17:18 hat Stefan Hajnoczi geschrieben: > Test 238 does not require the kvm accelerator. tcg and qtest work too. > > Use qtest since it's always built in while kvm and tcg are not. > > Suggested-by: Thomas Huth > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/238 |

[Qemu-devel] mirror questions

2019-02-26 Thread Vladimir Sementsov-Ogievskiy
Hi! A question about s->cow_bitmap, introduced in far b812f6719c "mirror: perform COW if the cluster size is bigger than the granularity" cow_bitmap is just a bitmap which tracks, what clusters of target are allocated, to prevent COW in target, if target backing is not ready yet. And it is

Re: [Qemu-devel] Build error with git commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116 on x86_64

2019-02-26 Thread Thomas Huth
On 26/02/2019 09.58, Andrew Randrianasulu wrote: > В сообщении от Tuesday 26 February 2019 11:54:12 вы написали: >> On 25/02/2019 18.29, Andrew Randrianasulu wrote: >>> В сообщении от Monday 25 February 2019 19:19:01 Philippe Mathieu-Daudc3a9 >>> >>> написал(а): Hi Andrew, On

Re: [Qemu-devel] [PATCH] qmp: add query-qemu-capabilities

2019-02-26 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, Feb 25, 2019 at 10:28:46AM +0100, Peter Krempa wrote: >> On Mon, Feb 25, 2019 at 09:50:26 +0100, Markus Armbruster wrote: >> > Stefan Hajnoczi writes: >> > >> > > QMP clients can usually detect the presence of features via schema >> > > introspection. There

Re: [Qemu-devel] [RFC PATCH 6/6] pc: Support firmware configuration with -blockdev

2019-02-26 Thread Laszlo Ersek
Hi Markus, On 02/25/19 19:37, Markus Armbruster wrote: > The PC machines put firmware in ROM by default. To get it put into > flash memory (required by OVMF), you have to use -drive > if=pflash,unit=0,... and optionally -drive if=pflash,unit=1,... > > Why two -drive? This permits setting up

Re: [Qemu-devel] Build error with git commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116 on x86_64

2019-02-26 Thread Thomas Huth
On 26/02/2019 10.46, Andrew Randrianasulu wrote: [...] > also, -g 1186x864x32 resulted in funnuy diagonal corruption even at firmware > screen level, and probably same happening with x86-64/kvm guest if I select > some less comon, but exposed via xrandr mode. (this bit for -vga std, default)

Re: [Qemu-devel] [PATCH 1/3] Migration/colo.c: Fix double close bug when occur COLO failover

2019-02-26 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > From: Zhang Chen > > In migration_incoming_state_destroy(void) will check the mis->to_src_file > to double close the mis->to_src_file when occur COLO failover. > > Signed-off-by: Zhang Chen Reviewed-by: Dr. David Alan Gilbert > --- >

Re: [Qemu-devel] [regression] Clock jump on VM migration

2019-02-26 Thread Stefan Hajnoczi
On Tue, Feb 12, 2019 at 10:56:58AM +0800, Stefan Hajnoczi wrote: > I'll return to this issue on Monday. I have played around with posix_fadvise(POSIX_FADV_DONTNEED) and measured 100+ millisecond latencies. This is not a great primitive to rely on during migration downtime since it can be slow.

Re: [Qemu-devel] [Qemu-block] [PATCH v2] iotests: handle TypeError for Python3 in test 242

2019-02-26 Thread Eduardo Habkost
On Tue, Feb 26, 2019 at 03:42:11AM +0200, Nir Soffer wrote: > On Mon, Feb 25, 2019 at 10:36 PM Eduardo Habkost [...] > > -c = f.read(1) > > -toggled = chr(ord(c) ^ bitmap_flag_unknown) > > +# The casts to bytearray() below are only necessary > > +# for Python 2

[Qemu-devel] [PATCH] Added periodic IRQ support for bcm2836_control local timer

2019-02-26 Thread bzt
Dear qemu developers, Honestly SubmitAPatch is a bit complicated for me, so I'm hoping I've done everything right. To be sure, you can find my patch here: https://github.com/bztsrc/qemu-local-timer and diff against the latest github repo here:

[Qemu-devel] [PATCH v1 10/33] s390x/tcg: Implement VECTOR LOAD ELEMENT

2019-02-26 Thread David Hildenbrand
Fairly easy, load with desired size and store it into the right element. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 5 + target/s390x/translate_vx.inc.c | 18 ++ 2 files changed, 23 insertions(+) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PATCH v1 00/33] s390x/tcg: Vector Instruction Support Part 1

2019-02-26 Thread David Hildenbrand
This is the first part of vector instruction support for s390x. Parts will be sent and reviewed piece by piece. Part 1: Vector Support Instructions Part 2: Vector Integer Instructions Part 3: Vector String Instructions Part 4: Vector Floating-Point Instructions The current state can be found at

[Qemu-devel] [PATCH v1 08/33] s390x/tcg: Implement VECTOR LOAD

2019-02-26 Thread David Hildenbrand
When loading from memory, load to our temporary vector first, so in case we get an access exception on the second 64 bit element, the vector won't get modified. Loading with strange alingment from the end of the address space will not properly wrap, we can ignore that for now. Signed-off-by:

[Qemu-devel] [PATCH v1 17/33] s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT

2019-02-26 Thread David Hildenbrand
Fairly easy, just load from to gprs into a single vector. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index

[Qemu-devel] [PATCH v1 14/33] s390x/tcg: Implement VECTOR LOAD MULTIPLE

2019-02-26 Thread David Hildenbrand
Also fairly easy to implement. One issue we have is that exceptions will result in some vectors already being modified. At least handle it consistently per vector by using a temporary vector. Good enough for now, add a FIXME. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def

[Qemu-devel] [PATCH v1 18/33] s390x/tcg: Implement VECTOR LOAD WITH LENGTH

2019-02-26 Thread David Hildenbrand
We can reuse the helper introduced along with VECTOR LOAD TO BLOCK BOUNDARY. We just have to take care of converting the highest index into a length. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate.c| 7 +++

[Qemu-devel] [PATCH v1 24/33] s390x/tcg: Implement VECTOR REPLICATE

2019-02-26 Thread David Hildenbrand
Load the element and replicate it using gvec_dup. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 18 ++ 2 files changed, 20 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index

Re: [Qemu-devel] [PATCH 1/3] migration: Add multifd-compress parameter

2019-02-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > hmp.c| 17 + > hw/core/qdev-properties.c| 11 +++ > include/hw/qdev-properties.h | 1 + > migration/migration.c| 25 + >

Re: [Qemu-devel] mirror questions

2019-02-26 Thread Vladimir Sementsov-Ogievskiy
26.02.2019 12:28, Kevin Wolf wrote: > Am 26.02.2019 um 09:48 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Hi! >> >> A question about s->cow_bitmap, introduced in far b812f6719c >> "mirror: perform COW if the cluster size is bigger than the >> granularity" >> >> cow_bitmap is just a

[Qemu-devel] [PATCH v2 4/6] target/mips: Add emulation of MMI instruction PCPYUD

2019-02-26 Thread Mateja Marjanovic
From: Mateja Marjanovic Add emulation of MMI instruction PCPYUD. The emulation is implemented using TCG front end operations directly to achieve better performance. Signed-off-by: Mateja Marjanovic Reviewed-by: Aleksandar Rikalo --- target/mips/translate.c | 43

[Qemu-devel] [PATCH v2 5/6] target/mips: Add emulation of MMI instruction PEXCH

2019-02-26 Thread Mateja Marjanovic
From: Mateja Marjanovic Add emulation of MMI instruction PEXCH. The emulation is implemented using TCG front end operations directly to achieve better performance. Signed-off-by: Mateja Marjanovic --- target/mips/translate.c | 97 - 1 file

[Qemu-devel] [PATCH v2 2/6] target/mips: Add emulation of MMI instruction PCPYH

2019-02-26 Thread Mateja Marjanovic
From: Mateja Marjanovic Add emulation of MMI instruction PCPYH. The emulation is implemented using TCG front end operations directly to achieve better performance. Signed-off-by: Mateja Marjanovic Reviewed-by: Aleksandar Rikalo --- target/mips/translate.c | 66

Re: [Qemu-devel] can we disable the migration-test for TCG targets ?

2019-02-26 Thread Peter Maydell
On Tue, 26 Feb 2019 at 12:17, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > Backtrace of process 125450: > > Thread 6 (Thread 0xfff800012de0b900 (LWP 127434)): > > #0 0xfff80001034c5cdc in futex_abstimed_wait_cancelable (private=0, > >

Re: [Qemu-devel] [PATCH 2/3] Migration/colo.c: Fix COLO failover status error

2019-02-26 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > From: Zhang Chen > > When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED. > The origin codes misunderstand the FAILOVER_STATUS_REQUIRE. > > Signed-off-by: Zhang Chen Why do these 'case's have to only deal with COMPLETED - what

Re: [Qemu-devel] [PATCH 2/3] Migration/colo.c: Fix COLO failover status error

2019-02-26 Thread Zhang, Chen
-Original Message- From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] Sent: Tuesday, February 26, 2019 6:55 PM To: Zhang, Chen Cc: Li Zhijian ; Zhang Chen ; Juan Quintela ; zhanghailiang ; qemu-dev Subject: Re: [PATCH 2/3] Migration/colo.c: Fix COLO failover status error *

[Qemu-devel] [PATCH v1 12/33] s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT

2019-02-26 Thread David Hildenbrand
To avoid an helper, we have to do the actual calculation of the element address (offset in cpu_env + cpu_env) manually. Factor that out into get_vec_element_ptr_i64(). The same logic will be reused for "VECTOR LOAD VR ELEMENT FROM GR". Signed-off-by: David Hildenbrand ---

[Qemu-devel] [PATCH v1 20/33] s390x/tcg: Implement VECTOR PACK

2019-02-26 Thread David Hildenbrand
We cannot use gvex expansion as the element size of source and destination differs. So expand manually. Luckily, VECTOR PACK does not care about saturation or setting the CC, so it can be implemented without a helper. We have to watch out for overlapping source and destination registers and use a

[Qemu-devel] [PATCH v1 04/33] s390x/tcg: Utilities for vector instruction helpers

2019-02-26 Thread David Hildenbrand
We'll have to read/write vector elements quite frequently from helpers. The tricky bit is properly taking care of endianess. Handle it similar to aarch64. target/s390x/vec_helper.c will later also contain vector support instruction helpers. Signed-off-by: David Hildenbrand ---

[Qemu-devel] [PATCH v1 29/33] s390x/tcg: Implement VECTOR STORE

2019-02-26 Thread David Hildenbrand
Add a FIXME regarding exceptions during the second store. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PATCH v1 31/33] s390x/tcg: Implement VECTOR STORE MULTIPLE

2019-02-26 Thread David Hildenbrand
Similar to VECTOR LOAD MULTIPLE, just the opposite direction. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 25 + 2 files changed, 27 insertions(+) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PATCH v4 2/9] disas: nanoMIPS: Fix a function misnomer

2019-02-26 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename function extract_ac_13_12() to extract_ac_15_14(). Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo --- disas/nanomips.cpp | 96 +++--- disas/nanomips.h | 2 +- 2 files changed, 49

Re: [Qemu-devel] [PATCH v7 00/17] ARM virt: Initial RAM expansion and PCDIMM/NVDIMM support

2019-02-26 Thread Auger Eric
Hi Igor, On 2/26/19 9:40 AM, Auger Eric wrote: > Hi Igor, > > On 2/25/19 10:42 AM, Igor Mammedov wrote: >> On Fri, 22 Feb 2019 18:35:26 +0100 >> Auger Eric wrote: >> >>> Hi Igor, >>> >>> On 2/22/19 5:27 PM, Igor Mammedov wrote: On Wed, 20 Feb 2019 23:39:46 +0100 Eric Auger wrote:

Re: [Qemu-devel] Build error with git commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116 on x86_64

2019-02-26 Thread Andrew Randrianasulu
В сообщении от Tuesday 26 February 2019 12:58:11 вы написали: > On 26/02/2019 10.46, Andrew Randrianasulu wrote: > [...] > > > also, -g 1186x864x32 resulted in funnuy diagonal corruption even at > > firmware screen level, and probably same happening with x86-64/kvm guest > > if I select some less

[Qemu-devel] [PATCH v1 07/33] s390x/tcg: Implement VECTOR GENERATE MASK

2019-02-26 Thread David Hildenbrand
This is the first instruction that uses gvec expansion for duplicating elements. We will use makros for most gvec calls to simplify translating vector numbers into offsets (and to not have to worry about oprsz and maxsz). Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2

[Qemu-devel] [PATCH v1 22/33] s390x/tcg: Implement VECTOR PERMUTE

2019-02-26 Thread David Hildenbrand
Take care of overlying inputs and outputs by using a temporary vector. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 12 target/s390x/vec_helper.c | 20

[Qemu-devel] [PATCH v1 05/33] s390x/tcg: Implement VECTOR GATHER ELEMENT

2019-02-26 Thread David Hildenbrand
Let's start with a more involved one, but it is the first in the list of vector support instructions (introduced with the vector facility). Good thing is, we need a lot of basic infrastructure for this. Reading and writing vector elements, checking element validity as well as loading vector

[Qemu-devel] [PATCH v1 19/33] s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)

2019-02-26 Thread David Hildenbrand
We cannot use gvec expansion as source and destination elements are have different element numbers. So we'll expand using a fancy loop. Also, we have to take care of overlapping source and target registers and use a temporary register in case they do. Signed-off-by: David Hildenbrand ---

[Qemu-devel] [PATCH v1 26/33] s390x/tcg: Implement VECTOR SCATTER ELEMENT

2019-02-26 Thread David Hildenbrand
Similar to VECTOR GATHER ELEMENT, but the other direction. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 3 +++ target/s390x/translate_vx.inc.c | 22 ++ 2 files changed, 25 insertions(+) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PATCH v1 25/33] s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE

2019-02-26 Thread David Hildenbrand
Like VECTOR REPLICATE, but the element to be replicated comes from an immediate. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 18 ++ 2 files changed, 20 insertions(+) diff --git a/target/s390x/insn-data.def

Re: [Qemu-devel] can we disable the migration-test for TCG targets ?

2019-02-26 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 25 Feb 2019 at 14:00, Peter Maydell wrote: > > > > Hi; the migration-test is failing really frequently for me > > for TCG targets (usually on sparc64 host) -- can we just disable > > it from the test set until we've figured out and

Re: [Qemu-devel] [PATCH] Added periodic IRQ support for bcm2836_control local timer

2019-02-26 Thread Peter Maydell
On Tue, 26 Feb 2019 at 11:38, bzt wrote: > > Dear qemu developers, > > Honestly SubmitAPatch is a bit complicated for me, so I'm hoping I've > done everything right. To be sure, you can find my patch here: > https://github.com/bztsrc/qemu-local-timer and diff against the latest > github repo

[Qemu-devel] [PATCH v2 6/6] target/mips: Add emulation of MMI instruction PEXCW

2019-02-26 Thread Mateja Marjanovic
From: Mateja Marjanovic Add emulation of MMI instruction PEXCW. The emulation is implemented using TCG front end operations directly to achieve better performance. Signed-off-by: Mateja Marjanovic --- target/mips/translate.c | 73 - 1 file

Re: [Qemu-devel] [RFC PATCH 4/6] sysbus: Fix latent bug with onboard devices

2019-02-26 Thread Marc-André Lureau
Hi On Mon, Feb 25, 2019 at 7:40 PM Markus Armbruster wrote: > > The first call of sysbus_get_default() creates the main system bus and > stores it in QOM as "/machine/unattached/sysbus". This must not > happen before main() creates "/machine", or else container_get() would > "helpfully" create

[Qemu-devel] [PATCH v4 3/9] qemu-doc: Move section on MIPS' mipssim pseudo board

2019-02-26 Thread Aleksandar Markovic
From: Aleksandar Markovic Move section on MIPS' mipssim pseudo board to the more appropriate place. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Rikalo --- qemu-doc.texi | 26 +- 1 file changed, 13 insertions(+), 13

[Qemu-devel] [PATCH v4 6/9] tests/tcg: target/mips: Add wrappers for MSA integer max/min instructions

2019-02-26 Thread Aleksandar Markovic
From: Aleksandar Markovic Add wrappers for MSA integer max/min instructions. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo --- tests/tcg/mips/include/wrappers_msa.h | 30 ++ 1 file changed, 30 insertions(+) diff --git

Re: [Qemu-devel] can we disable the migration-test for TCG targets ?

2019-02-26 Thread Peter Maydell
On Tue, 26 Feb 2019 at 12:30, Peter Maydell wrote: > > On Tue, 26 Feb 2019 at 12:17, Dr. David Alan Gilbert > wrote: > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > Backtrace of process 125450: > > > Thread 6 (Thread 0xfff800012de0b900 (LWP 127434)): > > > #0 0xfff80001034c5cdc

[Qemu-devel] [PATCH 2/3] hmp: add compress-type parameter to migration parameters

2019-02-26 Thread Denis Plotnikov
Signed-off-by: Denis Plotnikov --- hmp.c | 8 1 file changed, 8 insertions(+) diff --git a/hmp.c b/hmp.c index b2a2b1f84e..5f105b816f 100644 --- a/hmp.c +++ b/hmp.c @@ -334,6 +334,10 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict) params =

[Qemu-devel] [PATCH 3/3] migration: add zstd compression

2019-02-26 Thread Denis Plotnikov
zstd allows to migrate with less cpu consumption maintaining the the same level of data compression as qzip (zlib). Compression level for zstd is set with migration parameter "compress-level" in the range 1 - 22. 1 - the best speed, 22 - the best compression. Levels in the range of 20-22 should

Re: [Qemu-devel] [PATCH 5/5] decodetree: Allow grouping of overlapping patterns

2019-02-26 Thread Bastian Koppelmann
On 2/24/19 12:29 AM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- docs/decodetree.rst | 58 + scripts/decodetree.py | 144 ++ 2 files changed, 191 insertions(+), 11 deletions(-) diff --git a/docs/decodetree.rst

Re: [Qemu-devel] Build error with git commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116 on x86_64

2019-02-26 Thread Andrew Randrianasulu
В сообщении от Tuesday 26 February 2019 12:05:02 Thomas Huth написал(а): > On 26/02/2019 09.58, Andrew Randrianasulu wrote: > > В сообщении от Tuesday 26 February 2019 11:54:12 вы написали: > >> On 25/02/2019 18.29, Andrew Randrianasulu wrote: > >>> В сообщении от Monday 25 February 2019 19:19:01

Re: [Qemu-devel] Build error with git commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116 on x86_64

2019-02-26 Thread Peter Maydell
On Tue, 26 Feb 2019 at 09:06, Thomas Huth wrote: > Ok, then that's the problem here: GCC often produces some additional > "may be unused" warnings with -O3, and we normally only guarantee that > QEMU compiles without warnings when using the standard -O2 optimization > level. > So if you want to

[Qemu-devel] [PATCH v1 16/33] s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR

2019-02-26 Thread David Hildenbrand
Very similar to VECTOR LOAD GR FROM VR ELEMENT, just the opposite direction. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 33 + 2 files changed, 35 insertions(+) diff --git

[Qemu-devel] [PATCH v1 03/33] s390x: Add one temporary vector register in CPU state for TCG

2019-02-26 Thread David Hildenbrand
We sometimes want to work on a temporary vector register instead of the actual destination, because source and destination might overlap. An alternative would be loading the vector into two i64 variables, but than separate handling for accessing the vector elements would be needed. This is easier.

[Qemu-devel] [PATCH v1 11/33] s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE

2019-02-26 Thread David Hildenbrand
Take care of properly sign-extending the immediate. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 5 + target/s390x/translate_vx.inc.c | 17 + 2 files changed, 22 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def

[Qemu-devel] [PATCH v1 30/33] s390x/tcg: Implement VECTOR STORE ELEMENT

2019-02-26 Thread David Hildenbrand
As we only store one element, there is nothing to consider regarding exceptions. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 5 + target/s390x/translate_vx.inc.c | 18 ++ 2 files changed, 23 insertions(+) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PATCH v1 33/33] s390x/tcg: Implement VECTOR UNPACK *

2019-02-26 Thread David Hildenbrand
Combine all variant in a single handler. As source and destination have different element sizes, we can't use gvec expansion. Expand manually. Also watch out for overlapping source and destination and use a temporary register in that case. Signed-off-by: David Hildenbrand ---

[Qemu-devel] [PATCH v1 32/33] s390x/tcg: Implement VECTOR STORE WITH LENGTH

2019-02-26 Thread David Hildenbrand
Very similar to VECTOR LOAD WITH LENGTH, just the opposite direction. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 13 + target/s390x/vec_helper.c | 15 +++ 4

Re: [Qemu-devel] Build error with git commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116 on x86_64

2019-02-26 Thread Thomas Huth
On 26/02/2019 12.05, Peter Maydell wrote: > On Tue, 26 Feb 2019 at 09:06, Thomas Huth wrote: >> Ok, then that's the problem here: GCC often produces some additional >> "may be unused" warnings with -O3, and we normally only guarantee that >> QEMU compiles without warnings when using the standard

[Qemu-devel] [PATCH v2 3/6] target/mips: Add emulation of MMI instruction PCPYLD

2019-02-26 Thread Mateja Marjanovic
Add emulation of MMI instruction PCPYLD. The emulation is implemented using TCG front end operations directly to achieve better performance. Signed-off-by: Mateja Marjanovic Reviewed-by: Aleksandar Rikalo --- target/mips/translate.c | 43 ++- 1 file

[Qemu-devel] [PATCH v4 5/9] qemu-doc: Add section on MIPS' Boston board

2019-02-26 Thread Aleksandar Markovic
From: Aleksandar Markovic Add section on MIPS' Boston board in QEMU user documentation. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Rikalo --- qemu-doc.texi | 9 + 1 file changed, 9 insertions(+) diff --git a/qemu-doc.texi

[Qemu-devel] [PATCH v1 02/33] s390x/tcg: Check vector register instructions at central point

2019-02-26 Thread David Hildenbrand
Check them at a central point. We'll use a new instruction flag to flag all vector instructions (IF_VEC) and handle it very similar to AFP, whereby we use another unused position in the PSW mask to store the state of vector register enablement per translation block. Signed-off-by: David

[Qemu-devel] [PATCH v1 23/33] s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE

2019-02-26 Thread David Hildenbrand
Read the whole input before modifying the destination vector. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 16 2 files changed, 18 insertions(+) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PATCH v1 28/33] s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD

2019-02-26 Thread David Hildenbrand
Load both elements signed and store them into the two 64 bit elements. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 33 + 2 files changed, 35 insertions(+) diff --git a/target/s390x/insn-data.def

[Qemu-devel] [PATCH v2 0/6] target/mips: Add emulation of data communication MMI instructions

2019-02-26 Thread Mateja Marjanovic
From: Mateja Marjanovic This series adds emulation of PCPYH, PCPYLD, and PCPYUD MMI instructions. v2: - The patch for PCPYH is split into two patches - Cleaned up handler for PCPYH - Fixed bugs and cleaned up in handler for PCPYLD - Fixed bugs and cleaned up in handler for PCPYUD -

[Qemu-devel] [PATCH v2 1/6] target/mips: Preparing for adding MMI instructions

2019-02-26 Thread Mateja Marjanovic
From: Mateja Marjanovic Set up MMI code to be compiled only for TARGET_MIPS64. This is needed so that GPRs are 64 bit, and combined with MMI registers, they will form full 128 bit registers. Signed-off-by: Mateja Marjanovic Reviewed-by: Aleksandar Rikalo --- target/mips/translate.c | 43

Re: [Qemu-devel] [RFC PATCH 6/6] pc: Support firmware configuration with -blockdev

2019-02-26 Thread Markus Armbruster
Laszlo Ersek writes: > Hi Markus, > > On 02/25/19 19:37, Markus Armbruster wrote: >> The PC machines put firmware in ROM by default. To get it put into >> flash memory (required by OVMF), you have to use -drive >> if=pflash,unit=0,... and optionally -drive if=pflash,unit=1,... >> >> Why two

Re: [Qemu-devel] [RFC PATCH 2/6] qom: Move compat_props machinery from qdev to QOM

2019-02-26 Thread Marc-André Lureau
Hi On Mon, Feb 25, 2019 at 7:46 PM Markus Armbruster wrote: > > See the previous commit for rationale. > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > hw/core/qdev.c | 39 --- > include/hw/qdev-core.h | 4 >

Re: [Qemu-devel] [RFC PATCH 3/6] vl: Fix latent bug with -global and onboard devices

2019-02-26 Thread Marc-André Lureau
On Mon, Feb 25, 2019 at 7:41 PM Markus Armbruster wrote: > > main() registers the user's -global only after we create the machine > object, i.e. too late for devices created in the machine's > .instance_init(). > > Fortunately, we know the bug is only latent: the commit before > previous fixed a

[Qemu-devel] [PATCH v4 9/9] target/mips: Add support for DSPRAM

2019-02-26 Thread Aleksandar Markovic
From: Yongbok Kim The optional Data Scratch Pad RAM (DSPRAM) block provides a general scratch pad RAM used for temporary storage of data. The DSPRAM provides a connection to on-chip memory or memory-mapped registers, which are accessed in parallel with the L1 data cache to minimize access

[Qemu-devel] [PATCH v4 0/9] Misc target/mips fixes and improvements

2019-02-26 Thread Aleksandar Markovic
From: Aleksandar Markovic A collection of misc target/mips fixes and improvements for February 2019. v3->v4: - added a patch on DSPRAM support - order of patches slightly changed - minor changes in commit messages - rebased to the latest code v2->v3: - added a patches on

[Qemu-devel] [PATCH 1/3] migration: rework compression code for adding more data compressors

2019-02-26 Thread Denis Plotnikov
Also, the patch adds new migration parameter parameter: compress-type to be able choose between data compressors available. By the moment, the only available data compressor is gzip (zlib) Signed-off-by: Denis Plotnikov --- migration/migration.c | 42 - migration/migration.h | 1 +

Re: [Qemu-devel] [PATCH v1 3/6] contrib: gitdm: add some more people academic group

2019-02-26 Thread Aurelien Jarno
On 2019-02-26 16:44, Alex Bennée wrote: > I'm basing this on email addresses or published employment. Please > confirm if this is correct or you want to be under (None). Please list me as (None) instead, QEMU is not related to my paid work. Aurelien -- Aurelien Jarno

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 15/15] s390x: Add floating-point extension facility to "qemu" cpu model

2019-02-26 Thread Thomas Huth
On 18/02/2019 13.27, David Hildenbrand wrote: > The floating-point extension facility implemented certain changes to > BFP, HFP and DFP instructions. > > As we don't implement HFP/DFP, we can ignore those completely. Related > to BFP, the changes include > - SET BFP ROUNDING MODE (SRNMB)

Re: [Qemu-devel] [PATCH 17/51] i386: express dependencies with Kconfig

2019-02-26 Thread Paolo Bonzini
On 26/02/19 14:44, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 25/02/19 09:44, Stefano Garzarella wrote: config I440FX bool +select PC_PCI +select PC_ACPI +select ACPI_SMBUS +select PCI_PIIX +select FDC >>> Should we move

Re: [Qemu-devel] [PULL 08/11] authz: add QAuthZList object type for an access control list

2019-02-26 Thread Daniel P . Berrangé
On Mon, Feb 25, 2019 at 08:36:33AM -0600, Eric Blake wrote: > I missed reviewing this before the pull request, so comments here are > best for a followup patch: > > On 2/25/19 6:31 AM, Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > > > Add a QAuthZList object type that implements

[Qemu-devel] [PULL v2 06/11] authz: add QAuthZ object as an authorization base class

2019-02-26 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The current qemu_acl module provides a simple access control list facility inside QEMU, which is used via a set of monitor commands acl_show, acl_policy, acl_add, acl_remove & acl_reset. Note there is no ability to create ACLs - the network services (eg VNC server)

Re: [Qemu-devel] [PULL 00/13] Netpatches

2019-02-26 Thread Peter Maydell
On Fri, 22 Feb 2019 at 14:55, Jason Wang wrote: > > The following changes since commit 7817ea16c1bb91ba3849e704d5f3e3c5775087bf: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190221' into > staging (2019-02-22 13:04:42 +) > > are available in the git repository at: > >

[Qemu-devel] [PULL v2 3/3] iotests: avoid broken pipe with certtool

2019-02-26 Thread Eric Blake
From: Daniel P. Berrangé When we run "certtool 2>&1 | head -1" the latter command is likely to complete and exit before certtool has written everything it wants to stderr. In at least the RHEL-7 gnutls 3.3.29 this causes certtool to quit with broken pipe before it has finished writing the

Re: [Qemu-devel] [PATCH v7 00/17] ARM virt: Initial RAM expansion and PCDIMM/NVDIMM support

2019-02-26 Thread Igor Mammedov
On Tue, 26 Feb 2019 14:11:58 +0100 Auger Eric wrote: > Hi Igor, > > On 2/26/19 9:40 AM, Auger Eric wrote: > > Hi Igor, > > > > On 2/25/19 10:42 AM, Igor Mammedov wrote: > >> On Fri, 22 Feb 2019 18:35:26 +0100 > >> Auger Eric wrote: > >> > >>> Hi Igor, > >>> > >>> On 2/22/19 5:27 PM, Igor

Re: [Qemu-devel] [PULL 11/27] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-02-26 Thread Peter Maydell
On Thu, 21 Feb 2019 at 14:20, Auger Eric wrote: > > Hi Peter, Alex, > On 2/14/19 8:05 PM, Peter Maydell wrote: > > Support this by making kvm_arch_put_registers() synchronize > > CPU state back into the list. We sync only those registers > > where the initial write succeeds, which should be

Re: [Qemu-devel] [RFC PATCH 6/6] pc: Support firmware configuration with -blockdev

2019-02-26 Thread Laszlo Ersek
On 02/26/19 13:35, Markus Armbruster wrote: > Laszlo Ersek writes: >>> -#define FLASH_MAP_UNIT_MAX 2 >>> +static PFlashCFI01 *pc_pflash_create(const char *name) >>> +{ >>> +DeviceState *dev = qdev_create(NULL, TYPE_CFI_PFLASH01); >>> + >>> +qdev_prop_set_uint64(dev, "sector-length",

Re: [Qemu-devel] [PATCH v3] iotests: handle TypeError for Python 3 in test 242

2019-02-26 Thread Eric Blake
On 2/26/19 10:11 AM, Andrey Shinkevich wrote: > The data type for bytes in Python 3 differs from the one in Python 2. > The type cast that is compatible with both versions was applied. > > Signed-off-by: Nir Soffer > Signed-off-by: Andrey Shinkevich > Reported-by: Kevin Wolf > ---

Re: [Qemu-devel] [PATCH v3 00/13] vhost-user-backend & vhost-user-input

2019-02-26 Thread Marc-André Lureau
Hi On Thu, Feb 21, 2019 at 5:09 PM Michael S. Tsirkin wrote: > > On Fri, Feb 08, 2019 at 12:23:44PM +0100, Marc-André Lureau wrote: > > Hi, > > > > This series is based on previously discussed "[PATCH v4 00/29] > > vhost-user for input & GPU" and "vhost-user: define conventions for > >

Re: [Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-02-26 Thread Andrey Shinkevich
On 26/02/2019 16:33, Alberto Garcia wrote: > On Mon 25 Feb 2019 05:39:14 PM CET, Vladimir Sementsov-Ogievskiy wrote: >>> --- a/block/stream.c >>> +++ b/block/stream.c >>> @@ -259,6 +259,15 @@ void stream_start(const char *job_id, BlockDriverState >>> *bs, >>>

Re: [Qemu-devel] [PATCH v3] iotests: handle TypeError for Python 3 in test 242

2019-02-26 Thread Andrey Shinkevich
On 26/02/2019 19:35, Eric Blake wrote: > On 2/26/19 10:11 AM, Andrey Shinkevich wrote: >> The data type for bytes in Python 3 differs from the one in Python 2. >> The type cast that is compatible with both versions was applied. >> >> Signed-off-by: Nir Soffer >> Signed-off-by: Andrey Shinkevich

[Qemu-devel] [PATCH v1 1/6] contrib: gitdm: Update domain-map

2019-02-26 Thread Alex Bennée
From: Aleksandar Markovic Add Citrix, Huawei, Intel, and Microsoft to domain-map. Signed-off-by: Aleksandar Markovic [AJB: sorted, added Fujitsu] Signed-off-by: Alex Bennée --- contrib/gitdm/domain-map | 5 + 1 file changed, 5 insertions(+) diff --git a/contrib/gitdm/domain-map

[Qemu-devel] [PATCH v1 0/6] current state of gitdm/next

2019-02-26 Thread Alex Bennée
Hi, I had a few patches sat in my queue so I spent a little time doing some email address archaeology and cleaning up the gitdm output. Some of these are guesses so I won't be including them in a pull-request until I get confirmation from the various contributors. For reference the current

[Qemu-devel] [PATCH v1 5/6] contrib: gitdm: another IBM email

2019-02-26 Thread Alex Bennée
Based on Tom's LinkedIn profile his QEMU work was while in IBM's virtualisation group. Cc: Tom Musta Signed-off-by: Alex Bennée --- contrib/gitdm/group-map-ibm | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/group-map-ibm b/contrib/gitdm/group-map-ibm index

[Qemu-devel] [PATCH v1 6/6] contrib: gitdm: another non-corporate email from RedHat

2019-02-26 Thread Alex Bennée
Marcel works in Red Hat's KVM team. Cc: Marcel Apfelbaum Signed-off-by: Alex Bennée --- contrib/gitdm/group-map-redhat | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/group-map-redhat b/contrib/gitdm/group-map-redhat index 6d05c6b54f..1335569dda 100644 ---

[Qemu-devel] [PATCH v1 3/6] contrib: gitdm: add some more people academic group

2019-02-26 Thread Alex Bennée
I'm basing this on email addresses or published employment. Please confirm if this is correct or you want to be under (None). Cc: Samuel Thibault Cc: Aurelien Jarno Cc: BALATON Zoltan Signed-off-by: Alex Bennée --- contrib/gitdm/group-map-academics | 9 + 1 file changed, 9

[Qemu-devel] [PATCH v1 2/6] contrib: gitdm: Update Wave Computing group

2019-02-26 Thread Alex Bennée
From: Aleksandar Markovic Add all missing MIPS/Imgtec/Wave contributors (from the inception of QEMU). Signed-off-by: Aleksandar Markovic Signed-off-by: Alex Bennée --- contrib/gitdm/group-map-wavecomp | 12 1 file changed, 12 insertions(+) diff --git

[Qemu-devel] [PATCH v1 4/6] contrib: gitdm: add more individual contributors

2019-02-26 Thread Alex Bennée
I know Richard's is right because I asked him in the pub. I'm guessing Fredrik's based on the fact I vaguely remember an Atari demo. Cc: Richard Henderson Cc: Fredrik Noring Signed-off-by: Alex Bennée --- contrib/gitdm/group-map-individuals | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [PATCH PULL 00/11] RDMA queue

2019-02-26 Thread Peter Maydell
On Sat, 23 Feb 2019 at 14:16, Marcel Apfelbaum wrote: > > The following changes since commit 8eb29f1bf5a974dc4c11d2d1f5e7c7f7a62be116: > > Merge remote-tracking branch > 'remotes/awilliam/tags/vfio-updates-20190221.0' into staging (2019-02-22 > 15:48:04 +) > > are available in the Git

[Qemu-devel] [PULL v2 1/3] iotests: handle TypeError for Python 3 in test 242

2019-02-26 Thread Eric Blake
From: Andrey Shinkevich The data type for bytes in Python 3 differs from the one in Python 2. The type cast that is compatible with both versions was applied. Signed-off-by: Nir Soffer Signed-off-by: Andrey Shinkevich Reported-by: Kevin Wolf Message-Id:

  1   2   3   4   >