Stefan Hajnoczi writes:
> The following statement produces a SyntaxWarning with Python 3.8:
>
> if len(format) is 0:
> scripts/tracetool/__init__.py:459: SyntaxWarning: "is" with a literal. Did
> you mean "=="?
>
> Use the conventional len(x) == 0 syntax instead.
>
> Reported-by: Daniel P.
On Wed, Oct 09, 2019 at 11:15:04AM +0200, Paolo Bonzini wrote:
> On 09/10/19 10:02, Jan Glauber wrote:
> > I'm still not sure what the actual issue is here, but could it be some bad
> > interaction between the notify_me and the list_lock? The are both 4 byte
> > and side-by-side:
> >
> > address
> From: Kevin Wolf [mailto:kw...@redhat.com]
> Am 25.09.2019 um 11:02 hat Pavel Dovgalyuk geschrieben:
> > > From: Kevin Wolf [mailto:kw...@redhat.com]
> > > Am 20.09.2019 um 09:25 hat Pavel Dovgalyuk geschrieben:
> > > > > From: Kevin Wolf [mailto:kw...@redhat.com]
> > > > > Am 19.09.2019 um
Oh... are you using the SLOF (guest firmware) image included in the qemu
tree, or is it coming from a separate package?
If it's from a separate package, that could be the problem - it needs to be
updated before that qemu patch is safe.
--
You received this bug notification because you are a
On Fri, 11 Oct 2019 16:07:58 +1100
David Gibson wrote:
> On Thu, Oct 10, 2019 at 10:33:04PM +0200, Greg Kurz wrote:
> > On Thu, 10 Oct 2019 08:29:58 +0200
> > Greg Kurz wrote:
> >
> > > On Thu, 10 Oct 2019 13:02:09 +1100
> > > David Gibson wrote:
> > >
> > > > On Wed, Oct 09, 2019 at
On 10/10/19 20:08, Michael S. Tsirkin wrote:
> On Thu, Oct 10, 2019 at 06:23:00PM +0200, Laszlo Ersek wrote:
>> On 10/10/19 14:48, Igor Mammedov wrote:
>>
>>> it doesn't really matter if it's ACPI blob or fw_cfg,
>>> what firmware needs is a table of possible CPUs with APIC IDs.
>>
>> To repeat my
On 10/10/19 17:57, Igor Mammedov wrote:
> On Thu, 10 Oct 2019 09:59:42 -0400
> "Michael S. Tsirkin" wrote:
>
>> On Thu, Oct 10, 2019 at 03:39:12PM +0200, Igor Mammedov wrote:
>>> On Thu, 10 Oct 2019 05:56:55 -0400
>>> "Michael S. Tsirkin" wrote:
>>>
On Wed, Oct 09, 2019 at 09:22:49AM
On 09/10/2019 11.13, Thomas Huth wrote:
> On 07/10/2019 20.21, Markus Armbruster wrote:
>> Markus Armbruster writes:
>>
>>> Please excuse the attention-grabbing subject.
>>
>> Again.
>>
>> [...]
>>> So, to make use of QEMU's netmap backend (CONFIG_NETMAP), you have to
>>> build and install netmap
Some might actually care about the return value of dma_memory_rw. So
let us pass it along instead of ignoring it.
Signed-off-by: Klaus Jensen
---
include/hw/pci/pci.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index
On 10/10/2019 17.24, Max Reitz wrote:
> iotests.py itself does not store socket files, but it machine.py and
> qtest.py do. iotests.py needs to pass the respective path to them, and
> they need to adhere to it.
>
> Signed-off-by: Max Reitz
> ---
> python/qemu/machine.py| 15
Kevin Wolf writes:
> Am 02.10.2019 um 13:57 hat Markus Armbruster geschrieben:
>> Eric Blake writes:
>>
>> > On 10/1/19 2:34 PM, Markus Armbruster wrote:
>> >> Peter Krempa writes:
>> >>
>> >>> savevm was buggy as it considered all monitor owned block device nodes
>> >>
>> >> Recommend
Hi,
While working on fixing the emulated nvme device to pass more tests in
the blktests suite, I discovered that the pci_dma_rw function ignores
the return value of dma_memory_rw.
The nvme device needs to handle DMA errors gracefully in order to pass
the block/011 test ("disable PCI device while
Philippe Mathieu-Daudé writes:
> Hi Sergio,
>
> On 10/10/19 4:31 PM, Sergio Lopez wrote:
>> Follow checkpatch.pl recommendation and replace the use of strtol with
>> qemu_strtol in x86_load_linux().
>>
>> Signed-off-by: Sergio Lopez
>> ---
>> hw/i386/pc.c | 11 +--
>> 1 file
On 10/10/2019 17.24, Max Reitz wrote:
> Hi,
>
> Perhaps the main reason we cannot run important tests such as 041 in CI
> is that when they care Unix sockets in $TEST_DIR, the path may become
> too long to connect to them.
>
> To get by this problem, this series lets the check script create a
MPX support is being phased out by Intel. Following other CPU models
like Skylake, Icelake and Cascadelake, do not enable it by default.
Signed-off-by: Xiaoyao Li
---
I'm not sure is there anyone already use Snowridge CPU model and whether to
add it in pc_compat_4_1, since Snowridge has not been
UMWAIT and TPAUSE instructions use 32bits IA32_UMWAIT_CONTROL at MSR
index E1H to determines the maximum time in TSC-quanta that the processor
can reside in either C0.1 or C0.2.
This patch is to Add support for save/load IA32_UMWAIT_CONTROL MSR in
guest.
Co-developed-by: Jingqi Liu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions.
This patch adds support for user wait instructions in KVM. Availability
of the user wait instructions is indicated by the presence of the CPUID
feature flag WAITPKG CPUID.0x07.0x0:ECX[5]. User wait instructions may
be executed at any
On 10/10/2019 17.24, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/183 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Thomas Huth
On 10.10.19 21:50, Eric Blake wrote:
> On 10/10/19 10:24 AM, Max Reitz wrote:
>> Signed-off-by: Max Reitz
>> ---
>> tests/qemu-iotests/common.filter | 8 ++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>
>> @@ -218,7 +221,8 @@ _filter_nbd()
>> # Filter out the TCP port
On 11/10/2019 09.54, Max Reitz wrote:
> On 10.10.19 20:42, Eric Blake wrote:
>> On 10/10/19 10:24 AM, Max Reitz wrote:
>>> Signed-off-by: Max Reitz
>>> ---
>>> tests/qemu-iotests/common.filter | 8 ++--
>>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git
Peter Krempa writes:
> On Thu, Oct 10, 2019 at 15:53:30 +0200, Markus Armbruster wrote:
>> Peter Krempa writes:
>>
>> > Signed-off-by: Peter Krempa
>> > ---
>> > tests/qapi-schema/qapi-schema-test.json | 26 ++
>> > tests/qapi-schema/qapi-schema-test.out | 29
On 11/10/2019 10.03, Max Reitz wrote:
> On 11.10.19 09:27, Thomas Huth wrote:
>> On 10/10/2019 17.24, Max Reitz wrote:
>>> Hi,
>>>
>>> Perhaps the main reason we cannot run important tests such as 041 in CI
>>> is that when they care Unix sockets in $TEST_DIR, the path may become
>>> too long to
Various shell files contain a mix of obsolete `` and
modern $(); It would be nice to convert to use $()
everywhere.
Signed-off-by: Yifan Luo
---
tests/data/acpi/rebuild-expected-aml.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/data/acpi/rebuild-expected-aml.sh
On Fri, Oct 11, 2019 at 10:18:18AM +0200, Paolo Bonzini wrote:
> On 11/10/19 08:05, Jan Glauber wrote:
> > On Wed, Oct 09, 2019 at 11:15:04AM +0200, Paolo Bonzini wrote:
> >>> ...but if I bump notify_me size to uint64_t the issue goes away.
> >>
> >> Ouch. :) Is this with or without my patch(es)?
04.10.2019 19:31, Max Reitz wrote:
> On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote:
>> Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up
>> region in the dirty bitmap, which means that we may not copy some bytes
>> and assume them copied, which actually leads to
MultiFDPacket_t's magic and version field never changes during
migration, so move these two fields in setup stage.
Signed-off-by: Wei Yang
---
migration/ram.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 6a3bef0434..71d845b851
Command and event details are indented three spaces, everything else
four. Messed up in commit 156402e5042. Use four spaces consistently.
Signed-off-by: Markus Armbruster
---
tests/qapi-schema/doc-good.out | 4 +-
tests/qapi-schema/event-case.out | 2 +-
Add 'features' field in the schema for commands and add a feature flag
to advertise that the fix for savevm [1] is present.
[1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03487.html
Based-on: <20191001191514.11208-1-arm...@redhat.com>
v4:
- PATCH 1: New
- PATCH 2: Factor out
From: Peter Krempa
Signed-off-by: Peter Krempa
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
tests/test-qmp-cmds.c | 24
tests/qapi-schema/qapi-schema-test.json | 22 ++
From: Peter Krempa
'savevm' was buggy as it considered all monitor-owned block device
nodes for snapshot. With the introduction of -blockdev, the common
usage made all nodes including protocol and backing file nodes be
monitor-owned and thus considered for snapshot.
This is a problem since the
On 11.10.19 09:27, Thomas Huth wrote:
> On 10/10/2019 17.24, Max Reitz wrote:
>> Hi,
>>
>> Perhaps the main reason we cannot run important tests such as 041 in CI
>> is that when they care Unix sockets in $TEST_DIR, the path may become
>> too long to connect to them.
>>
>> To get by this problem,
On 10/10/2019 17.24, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/083 | 6 +++---
> tests/qemu-iotests/083.out | 34 +-
> 2 files changed, 20 insertions(+), 20 deletions(-)
Reviewed-by: Thomas Huth
11.10.2019 0:00, Eric Blake wrote:
> Qemu as server currently won't accept export names larger than 256
> bytes, nor create dirty bitmap names longer than 1023 bytes, so most
> uses of qemu as client or server have no reason to get anywhere near
> the NBD spec maximum of a 4k limit per string.
>
On 10/10/2019 17.24, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/140 | 8
> tests/qemu-iotests/140.out | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/143 | 6 +++---
> tests/qemu-iotests/143.out | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/147 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/181 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Thomas Huth
On 10/10/19 20:15, Michael S. Tsirkin wrote:
> On Thu, Oct 10, 2019 at 05:57:54PM +0200, Igor Mammedov wrote:
>>> Then we should consider switching acpi to use fw cfg.
>>> Or build another interface that can scale.
>>
>> Could be an option, it would be a pain to write a driver in AML for fwcfg
>>
On 10/10/2019 17.24, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/182 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Thomas Huth
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions.
UMONITOR arms address monitoring hardware using an address. A store
to an address within the specified address range triggers the
monitoring hardware to wake up the processor waiting in umwait.
UMWAIT instructs the processor to
11.10.2019 0:00, Eric Blake wrote:
> Allow blockdevs to match the feature already present in qemu-nbd -D.
> Enhance iotest 223 to cover it.
>
> Signed-off-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
> ---
> qapi/block.json| 8 +---
> blockdev-nbd.c
On Thu, Oct 10, 2019 at 15:53:30 +0200, Markus Armbruster wrote:
> Peter Krempa writes:
>
> > Signed-off-by: Peter Krempa
> > ---
> > tests/qapi-schema/qapi-schema-test.json | 26 ++
> > tests/qapi-schema/qapi-schema-test.out | 29 +
> >
On 10/11/2019 3:41 PM, Xu, Tao3 wrote:
[...]
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index 11b9c854b5..a465c893b5 100644
--- a/target/i386/kvm.c
+++ b/target/i386/kvm.c
@@ -401,6 +401,12 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s,
uint32_t function,
if
On 10/11/19 08:50, Laszlo Ersek wrote:
> On 10/10/19 20:08, Michael S. Tsirkin wrote:
>> On Thu, Oct 10, 2019 at 06:23:00PM +0200, Laszlo Ersek wrote:
>>> On 10/10/19 14:48, Igor Mammedov wrote:
>>>
it doesn't really matter if it's ACPI blob or fw_cfg,
what firmware needs is a table of
On 10.10.19 18:15, Anton Nefedov wrote:
> On 10/10/2019 6:17 PM, Max Reitz wrote:
>> Hi everyone,
>>
>> (CCs just based on tags in the commit in question)
>>
>> I have two bug reports which claim problems of qcow2 on XFS on ppc64le
>> machines since qemu 4.1.0. One of those is about bad
On 10.10.19 20:18, Eric Blake wrote:
> On 10/10/19 10:24 AM, Max Reitz wrote:
>> Unix sockets generally have a maximum path length. Depending on your
>> $TEST_DIR, it may be exceeded and then all tests that create and use
>> Unix sockets there may fail.
>>
>> Circumvent this by adding a new
On 10.10.19 21:43, Eric Blake wrote:
> On 10/10/19 10:24 AM, Max Reitz wrote:
>> Signed-off-by: Max Reitz
>> ---
>> tests/qemu-iotests/194 | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194
>> index
On 10.10.19 20:42, Eric Blake wrote:
> On 10/10/19 10:24 AM, Max Reitz wrote:
>> Signed-off-by: Max Reitz
>> ---
>> tests/qemu-iotests/common.filter | 8 ++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/common.filter
>>
On 10/10/19 21:20, Eduardo Habkost wrote:
> On Thu, Oct 10, 2019 at 05:57:54PM +0200, Igor Mammedov wrote:
>> On Thu, 10 Oct 2019 09:59:42 -0400
>> "Michael S. Tsirkin" wrote:
>>
>>> On Thu, Oct 10, 2019 at 03:39:12PM +0200, Igor Mammedov wrote:
On Thu, 10 Oct 2019 05:56:55 -0400
On 11.10.19 09:27, Thomas Huth wrote:
> On 10/10/2019 17.24, Max Reitz wrote:
>> Hi,
>>
>> Perhaps the main reason we cannot run important tests such as 041 in CI
>> is that when they care Unix sockets in $TEST_DIR, the path may become
>> too long to connect to them.
>>
>> To get by this problem,
On 10/10/19 21:26, Eduardo Habkost wrote:
> Topology info is already available on CPUID.
Independently of everything else, thanks for pointing this out.
The edk2 library called "LocalApicLib" has two relevant functions:
> /**
> Get Package ID/Core ID/Thread ID of a processor.
>
> The
On 11/10/19 08:05, Jan Glauber wrote:
> On Wed, Oct 09, 2019 at 11:15:04AM +0200, Paolo Bonzini wrote:
>>> ...but if I bump notify_me size to uint64_t the issue goes away.
>>
>> Ouch. :) Is this with or without my patch(es)?
You didn't answer this question.
>> Also, what if you just add a dummy
On Fri, 11 Oct 2019 08:13:33 +0200
Greg Kurz wrote:
> On Fri, 11 Oct 2019 16:07:58 +1100
> David Gibson wrote:
>
> > On Thu, Oct 10, 2019 at 10:33:04PM +0200, Greg Kurz wrote:
> > > On Thu, 10 Oct 2019 08:29:58 +0200
> > > Greg Kurz wrote:
> > >
> > > > On Thu, 10 Oct 2019 13:02:09 +1100
> >
On Thu, Oct 10, 2019 at 02:12:00PM -0700, no-re...@patchew.org wrote:
> 4/7 Checking commit e3477ab2dc8e (libqos: add MSI-X callbacks to
> QVirtioPCIDevice)
> ERROR: line over 90 characters
> #31: FILE: tests/libqos/virtio-pci.c:283:
> +static void qvirtio_pci_set_queue_vector(QVirtioPCIDevice
On Wed, Sep 04, 2019 at 08:29:15AM +0200, Juan Quintela wrote:
>Reviewed-by: Daniel P. Berrangé
>Signed-off-by: Juan Quintela
>---
> migration/socket.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/migration/socket.c b/migration/socket.c
>index
Signed-off-by: Wei Yang
---
migration/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 22423f08cd..cf30171f44 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -838,7 +838,7 @@ static int
From: Peter Krempa
Similarly to features for struct types introduce the feature flags also
for commands. This will allow notifying management layers of fixes and
compatible changes in the behaviour of a command which may not be
detectable any other way.
The changes were heavily inspired by
Here are four trivial cleanups related to multifd.
Fix a typo, use a proper variable and setup never changed variables only once.
Wei Yang (4):
migration/multifd: fix a typo in comment of
multifd_recv_unfill_packet()
migration/multifd: use pages->allocated instead of the static max
The current libqos virtio-pci.c code implements the VIRTIO Legacy
interface. Extract existing code in preparation for VIRTIO 1.0 support.
Signed-off-by: Stefan Hajnoczi
---
tests/libqos/virtio-pci.h | 2 --
tests/libqos/virtio-pci.c | 25 ++---
2 files changed, 10
v2:
* Fix checkpatch.pl issues, except MAINTAINERS file warning. libqos already
has maintainers and the new virtio-pci-modern.[ch] files don't need extra
entries since they are already covered by the existing libqos/ entry.
New VIRTIO devices are Non-Transitional. This means they only
When we found an available channel in multifd_send_pages(), its
pages->used is cleared and then attached to multifd_send_state.
It is not necessary to do this twice.
Signed-off-by: Wei Yang
---
migration/ram.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
multifd_send_fill_packet() prepares meta data for following pages to
transfer. It would be more proper to fill pages->allocated instead of
static max value, especially we want to support flexible packet size.
Signed-off-by: Wei Yang
---
migration/ram.c | 3 +--
1 file changed, 1 insertion(+), 2
VIRTIO 1.0 PCI devices have multiple PCI_CAP_ID_VNDR capabilities so we
need a way to iterate over them. Extend qpci_find_capability() to take
the last address.
Signed-off-by: Stefan Hajnoczi
---
tests/libqos/pci.h | 2 +-
tests/libqos/pci.c | 18 --
2 files changed, 13
Instead of just passing the vring page frame number, pass the full
QVirtQueue. This will allow the VIRTIO 1.0 transport to program the
fine-grained vring address registers in the future.
Signed-off-by: Stefan Hajnoczi
---
tests/libqos/virtio.h | 2 +-
tests/libqos/virtio-mmio.c | 6 --
Am 11.10.2019 um 08:08 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 02.10.2019 um 13:57 hat Markus Armbruster geschrieben:
> >> Eric Blake writes:
> >>
> >> > On 10/1/19 2:34 PM, Markus Armbruster wrote:
> >> >> Peter Krempa writes:
> >> >>
> >> >>> savevm was buggy as it
The MSI-X vectors are programmed differently in the VIRTIO 1.0 and
Legacy interfaces. Introduce callbacks so different implementations can
be used depending on the interface version.
Signed-off-by: Stefan Hajnoczi
---
tests/libqos/virtio-pci.h | 12
tests/libqos/virtio-pci.c | 37
The VIRTIO 1.0 code will need to perform additional steps but it will
reuse the common virtqueue setup/cleanup code. Make these functions
public.
Make sure to invoke callbacks via QVirtioBus instead of directly calling
the virtio-pci Legacy versions of these functions.
Signed-off-by: Stefan
The Legacy virtio-pci interface always uses BAR 0. VIRTIO 1.0 may need
to use a different BAR index, so make it configurable.
Signed-off-by: Stefan Hajnoczi
---
tests/libqos/virtio-pci.h | 2 ++
tests/libqos/virtio-pci.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git
Implement the VIRTIO 1.0 virtio-pci interface. The main change here is
that the register layout is no longer a fixed layout in BAR 0. Instead
we have to iterate of PCI Capabilities to find descriptions of where
various registers are located. The vring registers are also more
fine-grained,
Add blk write function with qiov_offset parameter. It's needed for the
following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
include/sysemu/block-backend.h | 4
block/block-backend.c | 17 +
2 files changed, 17 insertions(+), 4
On 11.10.19 10:33, Vladimir Sementsov-Ogievskiy wrote:
> 04.10.2019 19:31, Max Reitz wrote:
>> On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote:
>>> Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up
>>> region in the dirty bitmap, which means that we may not copy some
do_sync_target_write is called from bdrv_mirror_top_do_write after
write/discard operation, all inside active_write/active_write_settle
protecting us from mirror iteration. So the whole area is dirty for
sure, no reason to examine dirty bitmap.
Signed-off-by: Vladimir Sementsov-Ogievskiy
For long test image paths, the order of the "Formatting" line and the
"(qemu)" prompt after a drive_backup HMP command may be reversed. It is
not well-defined anyway, so just silence everything and wait until we
get a prompt.
Reported-by: Thomas Huth
Signed-off-by: Max Reitz
---
On Fri, Oct 11, 2019 at 10:50:24 +0200, Markus Armbruster wrote:
> Command and event details are indented three spaces, everything else
> four. Messed up in commit 156402e5042. Use four spaces consistently.
>
> Signed-off-by: Markus Armbruster
> ---
> tests/qapi-schema/doc-good.out |
11.10.2019 11:58, Max Reitz wrote:
> On 11.10.19 10:33, Vladimir Sementsov-Ogievskiy wrote:
>> 04.10.2019 19:31, Max Reitz wrote:
>>> On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote:
Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up
region in the dirty bitmap,
On Fri, Oct 11, 2019 at 10:50:23 +0200, Markus Armbruster wrote:
> Add 'features' field in the schema for commands and add a feature flag
> to advertise that the fix for savevm [1] is present.
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03487.html
>
> Based-on:
Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up
region in the dirty bitmap, which means that we may not copy some bytes
and assume them copied, which actually leads to producing corrupted
target.
So 9adc1cb49af8d forced dirty bitmap granularity to be
request_alignment for
Passing zero length to these functions leads to unpredicted results.
Zero-length set/reset may occur in active-mirror, on zero-length write
(which is unlikely, but not guaranteed to never happen).
Let's just do nothing on zero-length request.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
This reverts commit 9adc1cb49af8d4e54f57980b1eed5c0a4b2dafa6.
"mirror: Only mirror granularity-aligned chunks"
Since previous commit unaligned chunks are supported by
do_sync_target_write.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
block/mirror.c | 29
On Thu, Oct 10, 2019 at 14:08:12 -0400, John Snow wrote:
> On 10/10/19 7:54 AM, Peter Krempa wrote:
> > On Thu, Oct 10, 2019 at 13:42:26 +0200, Philippe Mathieu-Daudé wrote:
> >> On 10/10/19 1:26 PM, Peter Krempa wrote:
[...]
> > To be honest, I didn't really review the code nor the
11.10.2019 11:58, Max Reitz wrote:
> On 11.10.19 10:33, Vladimir Sementsov-Ogievskiy wrote:
>> 04.10.2019 19:31, Max Reitz wrote:
>>> On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote:
Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up
region in the dirty bitmap,
Commit 9adc1cb49af8d fixed a bug about unaligned (to dirty bitmap
granularity) guest writes (and discards) by simply requesting
corresponding alignment on mirror-top filter. However forcing large
alignment obviously decreases performance of unaligned requests.
So it's time for a new solution
Am 11.10.2019 um 08:10 hat Pavel Dovgalyuk geschrieben:
> > From: Kevin Wolf [mailto:kw...@redhat.com]
> > Am 25.09.2019 um 11:02 hat Pavel Dovgalyuk geschrieben:
> > > I started playing with -blockdev: added new blockdev for blkreplay and
> > > constructed the following command line:
> > >
> > >
Am 17.09.2019 um 13:57 hat Pavel Dovgalyuk geschrieben:
> The set of patches include the block-related updates
> of the record/replay icount feature:
> - application of 'snapshot' option on the file layer instead of
>the top one: command line and documentation fix
> - implementation of
On 11/10/2019 11.07, Max Reitz wrote:
> For long test image paths, the order of the "Formatting" line and the
> "(qemu)" prompt after a drive_backup HMP command may be reversed. It is
> not well-defined anyway, so just silence everything and wait until we
> get a prompt.
>
> Reported-by: Thomas
041 works fine on Linux, FreeBSD and OpenBSD, so let's mark it as
only supported on these systems.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/041 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index
According to Kevin, tests 030, 040 and 041 are among the most valuable
tests that we have, so we should always run them if possible, even if
they take a little bit longer.
According to Max, it would be good to have a test for iothreads and
migration. 127 and 256 seem to be good candidates for
On 10/11/19 9:26 AM, Sergio Lopez wrote:
Philippe Mathieu-Daudé writes:
Hi Sergio,
On 10/10/19 4:31 PM, Sergio Lopez wrote:
Follow checkpatch.pl recommendation and replace the use of strtol with
qemu_strtol in x86_load_linux().
Signed-off-by: Sergio Lopez
---
hw/i386/pc.c | 11
Hi Michael,
On 9/2/19 4:01 PM, Michael Rolnik wrote:
This series of patches adds 8bit AVR cores to QEMU.
All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested
yet.
However I was able to execute simple code with functions. e.g fibonacci
calculation.
This series of
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
tests/qemu-iotests/common.rc | 20
1 file changed, 20 insertions(+)
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index 12b4751848..fa7bae2422 100644
--- a/tests/qemu-iotests/common.rc
+++
Public bug reported:
When I install a new vm with qemu 4.1.0 all the guest filesystems are
corrupt. The first boot from the install dvd iso is ok and the installer
work fine. But the guest system hangs after the installer finishes and I
reboot the guest. I can see the grub boot menue but the
Continue setting, but not relying upon, env->hflags.
Signed-off-by: Richard Henderson
---
target/arm/m_helper.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/target/arm/m_helper.c b/target/arm/m_helper.c
index 27cd2f3f96..f2512e448e 100644
--- a/target/arm/m_helper.c
+++
We do not need to compute any of these values for M-profile.
Further, XSCALE_CPAR overlaps VECSTRIDE so obviously the two
sets must be mutually exclusive.
Signed-off-by: Richard Henderson
---
target/arm/helper.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff
Make qbus_list_bus and qbus_list_dev hint append helpers well formed:
rename errp to errp_in, as it is IN-parameter here (which is unusual
for errp), rename functions to be error_append_*_hint.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qdev-monitor.c | 24
1 file
Avoid calling arm_current_el() twice.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
target/arm/internals.h | 9 +
target/arm/helper.c| 12 +++-
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/target/arm/internals.h
Begin setting, but not relying upon, env->hflags.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c| 1 +
target/arm/cpu.c| 1 +
target/arm/helper-a64.c | 3 +++
target/arm/helper.c | 2 ++
target/arm/machine.c| 1 +
target/arm/op_helper.c | 1 +
6 files changed, 9
We don't need Error **, as all callers pass local Error object, which
isn't used after the call, or NULL. Use Error * instead.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
ui/vnc.h | 2 +-
ui/vnc.c | 20 +++-
2 files changed, 8 insertions(+), 14 deletions(-)
diff --git
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/i386/amd_iommu.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index d3726361dd..c496a0679b 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -1533,7
fit_load_fdt forget to check that errp is not NULL and to zero it after
freeing. Fix it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
hw/core/loader-fit.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/core/loader-fit.c
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == _err
(the program will exit prior to the error_append_hint() or
error_prepend() call). Fix such cases.
If we want to
1 - 100 of 503 matches
Mail list logo
