Re: [PATCH for 4.2 v6 00/54] Support for TCG plugins

Patchew URL: https://patchew.org/QEMU/20191017131615.19660-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH for 4.2 v6 00/54] Support for TCG plugins Type: series Message-id: 20191017131615.19660-1-alex.

Re: Python 2 and test/vm/netbsd

On 18/10/2019 00.55, Eduardo Habkost wrote: > On Thu, Oct 17, 2019 at 07:05:41PM -0300, Eduardo Habkost wrote: >> On Wed, Oct 16, 2019 at 07:41:24PM -0300, Eduardo Habkost wrote: >>> On Wed, Oct 16, 2019 at 08:11:57AM +0200, Thomas Huth wrote: On 16/10/2019 05.00, Eduardo Habkost wrote: >

Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

On Thu, Oct 17, 2019 at 6:48 PM Miklos Szeredi wrote: > Even simpler: allow O_PATH descriptors for f*xattr(). Attached patch. Will post shortly. However, I think it would make sense to fix virtiofsd as well, as this will take time to percolate down, even if Al doesn't find anything wrong with

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

** Attachment added: "strace of the hanging qemu-img" https://bugs.launchpad.net/qemu/+bug/1848556/+attachment/5298128/+files/qemu-img-hangs.strace -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/18

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

Hi Rod, I did try to recreate with the qemu version that you have. $ apt install apache2 qemu-system-x86 $ qemu-img create -f qcow2 /var/www/html/test.img 1G # local $ qemu-img check test.img No errors were found on the image. # remote $ qemu-img check http://localhost:80/test.img

Re: [PATCH] Fix unsigned integer underflow in fd-trans.c

Le 18/10/2019 à 02:19, Shu-Chun Weng a écrit : > In any of these `*_for_each_*` functions, the last entry in the buffer (so the > "remaining length in the buffer" `len` is equal to the length of the > entry `nlmsg_len`/`nla_len`/etc) has size that is not a multiple of the > alignment, the aligned l

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

The stuck poll is at: #0 0x7fafb935ad26 in __GI_ppoll (fds=0x560dba615670, nfds=1, timeout=, timeout@entry=0x0, sigmask=sigmask@entry=0x0) at ../sysdeps/unix/sysv/linux/ppoll.c:39 #1 0x560db89550b9 in ppoll (__ss=0x0, __timeout=0x0, __nfds=, __fds=) at /usr/include/x86_64-linux-gnu/bits

Re: [PATCH] hw/s390x: Emit a warning if user tried to enable USB

On 10/18/19 8:35 AM, Thomas Huth wrote: On 17/10/2019 20.18, Philippe Mathieu-Daudé wrote: On 10/17/19 4:40 PM, Thomas Huth wrote: On 17/10/2019 16.34, Cornelia Huck wrote: On Thu, 17 Oct 2019 16:21:23 +0200 Thomas Huth wrote: There is no USB on s390x, so running qemu-system-s390x with "-ma

[PULL 00/13] Audio 20191018 patches

The following changes since commit f22f553efffd083ff624be116726f843a39f1148: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20191013' into staging (2019-10-17 16:48:56 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-20191018-pull-re

[PULL 03/13] audio: paaudio: ability to specify stream name

From: Kővágó, Zoltán This can be used to identify stream in tools like pavucontrol when one creates multiple -audiodevs or runs multiple qemu instances. Signed-off-by: Kővágó, Zoltán Acked-by: Markus Armbruster Message-id: 2d6e337c474ac84172d0809e6959c26b21d48120.1568157545.git.dirty.ice...@g

[PULL 07/13] audio: support more than two channels in volume setting

From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 5d3dd2ee3baaa62805e79c3901abb7415ae32461.1570996490.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/audio.h | 10 ++ audio/audio_int.h | 4 ++-- audio/audio.c | 30 ++--

[PULL 09/13] audio: basic support for multichannel audio

From: Kővágó, Zoltán Which currently only means removing some checks. Old code won't require more than two channels, but new code will need it. Signed-off-by: Kővágó, Zoltán Message-id: 7e53be1f97e939ed3bb729ef39e76b775643118a.1570996490.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann

[PULL 08/13] audio: replace shift in audio_pcm_info with bytes_per_frame

From: Kővágó, Zoltán The bit shifting trick worked because the number of bytes per frame was always a power-of-two (since QEMU only supports mono, stereo and 8, 16 and 32 bit samples). But if we want to add support for surround sound, this no longer holds true. Signed-off-by: Kővágó, Zoltán Me

[PULL 01/13] audio: fix parameter dereference before NULL check

From: Kővágó, Zoltán This should fix Coverity issues CID 1405305 and 1405301. Signed-off-by: Kővágó, Zoltán Message-id: 0eadcc88b8421bb86ce2d68ac70517f920c3ad6c.1568157545.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/audio_template.h | 7 +-- 1 file changed, 5 insert

[PULL 05/13] audio: make mixeng optional

From: Kővágó, Zoltán Implementation of the previously added mixing-engine option. Signed-off-by: Kővágó, Zoltán Message-id: c05bc258889ed289e8ee1bdbcc5e84174ec221e7.1570996490.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/audio_template.h | 24 ++- audio/audio

[PULL 13/13] paaudio: fix channel order for usb-audio 5.1 and 7.1 streams

From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 2900e462d27bd73277ae083d037c32b1b4451ee2.1570996490.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/paaudio.c | 50 - 1 file changed, 45 insertions(+), 5 deletions(

[PULL 12/13] usbaudio: change playback counters to 64 bit

From: Kővágó, Zoltán With stereo playback, they need about 375 minutes of continuous audio playback to overflow, which is usually not a problem (as stopping and later resuming playback resets the counters). But with 7.1 audio, they only need about 95 minutes to overflow. After the overflow, the

[PATCH v2 1/7] qapi: Don't suppress doc generation without pragma doc-required

Commit bc52d03ff5 "qapi: Make doc comments optional where we don't need them" made scripts/qapi2texi.py fail[*] unless the schema had pragma 'doc-required': true. The stated reason was inability to cope with incomplete documentation. When commit fb0bc835e5 "qapi-gen: New common driver for code an

[PULL 04/13] audio: add mixing-engine option (documentation)

From: Kővágó, Zoltán This will allow us to disable mixeng when we use a decent backend. Disabling mixeng have a few advantages: * we no longer convert the audio output from one format to another, when the underlying audio system would just convert it to a third format. We no longer convert,

[PULL 06/13] paaudio: get/put_buffer functions

From: Kővágó, Zoltán This lets us avoid some buffer copying when using mixeng. Signed-off-by: Kővágó, Zoltán Message-id: d03d30138b9b5a9681cc90cbfbfec0a197cac88c.1570996490.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/paaudio.c | 83 ++

[PATCH v2 7/7] qapi: Clear scripts/qapi/doc.py executable bits again

Commit fbf09a2fa4 "qapi: add 'ifcond' to visitor methods" brought back the executable bits. Fix that. Drop the #! line for good measure. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi/doc.py | 1 - 1 file changed, 1 deletion(-) mode change 100755 => 100644 scripts/

[PULL 11/13] usb-audio: support more than two channels of audio

From: Kővágó, Zoltán This commit adds support for 5.1 and 7.1 audio playback. This commit adds a new property to usb-audio: * multi=on|off Whether to enable the 5.1 and 7.1 audio support. When off (default) it continues to emulate the old stereo-only device. When on, it emulates a sligh

[PULL 10/13] usb-audio: do not count on avail bytes actually available

From: Kővágó, Zoltán This assumption is no longer true when mixeng is turned off. Signed-off-by: Kővágó, Zoltán Message-id: d63f4d39a0ee7a2e4e7e4a2eb005ba79120eaf1d.1570996490.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-audio.c | 30 ++

[PULL 02/13] audio: paaudio: fix connection and stream name

From: Kővágó, Zoltán Connection name was previously erroneously set to the server socket path, while connection names were simply "qemu". After this patch, the connection name will be the vm name (falling back to "qemu" if not specified), while stream names will be the audiodev's id. Signed-off

[PATCH v2 0/7] qapi: Cleanups and test speedup

v2: * PATCH 4,6 - Commit message improved [Eric] * PATCH 6 - Makefiles updated [Kevin] - Import statements fixed Markus Armbruster (7): qapi: Don't suppress doc generation without pragma doc-required qapi: Store pragma state in QAPISourceInfo, not global state qapi: Eliminate accidenta

[PATCH v2 5/7] qapi: Move gen_enum(), gen_enum_lookup() back to qapi/types.py

The next commit will split up qapi/common.py. gen_enum() needs QAPISchemaEnumMember, and that's in the way. Move it to qapi/types.py along with its buddy gen_enum_lookup(). Permit me a short a digression on history: how did gen_enum() end up in qapi/common.py? Commit 21cd70dfc1 "qapi script: ad

[PATCH v2 2/7] qapi: Store pragma state in QAPISourceInfo, not global state

The frontend can't be run more than once due to its global state. A future commit will want to do that. Recent commit "qapi: Move context-sensitive checking to the proper place" got rid of many global variables already, but pragma state is still stored in global variables (that's why a pragma dire

[PATCH v2 3/7] qapi: Eliminate accidental global frontend state

The frontend can't be run more than once due to its global state. A future commit will want to do that. The only global frontend state remaining is accidental: QAPISchemaParser.__init__()'s parameter previously_included=[]. Python evaluates the default once, at definition time. Any modifications

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

Quick checks: - does not depend on the exact image, e.g. https://cloud-images.ubuntu.com/eoan/current/eoan-server-cloudimg-amd64.img or https://download.fedoraproject.org/pub/fedora/linux/releases/30/Cloud/x86_64/images/Fedora-Cloud-Base-30-1.2.x86_64.qcow2 hang as well - the former qemu 3.1 bas

Re: [PATCH 1/2] spapr: Introduce a interrupt presenter reset handler

On Thu, 17 Oct 2019 16:42:40 +0200 Cédric Le Goater wrote: > The interrupt presenters are not reseted today. Extend the sPAPR IRQ > backend with a new cpu_intc_reset() handler which will be called by > the CPU reset handler. > > spapr_realize_vcpu() is modified to call the CPU reset only after t

Re: [PATCH 2/2] spapr/xive: Set the OS CAM line at reset

On Thu, 17 Oct 2019 16:42:41 +0200 Cédric Le Goater wrote: > When a Virtual Processor is scheduled to run on a HW thread, the > hypervisor pushes its identifier in the OS CAM line. When running in > TCG or kernel_irqchip=off, QEMU needs to emulate the same behavior. > This is only related to ke

[PATCH v5 3/5] tests: qapi: Test 'features' of commands

From: Peter Krempa Signed-off-by: Peter Krempa Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- tests/test-qmp-cmds.c | 24 tests/qapi-schema/qapi-schema-test.json | 18 ++ tests/qapi-schema/qapi-schema-test.out |

[PATCH v5 0/5] qapi: Add detection for the 'savevm' fix for blockdev

Add 'features' field in the schema for commands and add a feature flag to advertise that the fix for savevm [1] is present. [1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03487.html Based-on: <20191018074345.24034-1-arm...@redhat.com> v5: * PATCH 2: - qapi-code-gen.txt grammar

[PATCH v5 4/5] tests/qapi-schema: Cover feature documentation comments

Commit 8aa3a33e44 "tests/qapi-schema: Test for good feature lists in structs" neglected to cover documentation comments, and the previous commit followed its example. Make up for them. Signed-off-by: Markus Armbruster --- tests/qapi-schema/doc-good.texi | 22 ++ tests/qapi-s

[PATCH v5 2/5] qapi: Add feature flags to commands

From: Peter Krempa Similarly to features for struct types introduce the feature flags also for commands. This will allow notifying management layers of fixes and compatible changes in the behaviour of a command which may not be detectable any other way. The changes were heavily inspired by commi

[PATCH v5 5/5] qapi: Allow introspecting fix for savevm's cooperation with blockdev

From: Peter Krempa 'savevm' was buggy as it considered all monitor-owned block device nodes for snapshot. With the introduction of -blockdev, the common usage made all nodes including protocol and backing file nodes be monitor-owned and thus considered for snapshot. This is a problem since the '

Re: [PATCH v2 2/2] migration: savevm_state_handler_insert: constant-time element insertion

* Scott Cheloha (chel...@linux.vnet.ibm.com) wrote: > savevm_state's SaveStateEntry TAILQ is a priority queue. Priority > sorting is maintained by searching from head to tail for a suitable > insertion spot. Insertion is thus an O(n) operation. > > If we instead keep track of the head of each pr

[PATCH v5 1/5] tests/qapi-schema: Tidy up test output indentation

Command and event details are indented three spaces, everything else four. Messed up in commit 156402e5042. Use four spaces consistently. Signed-off-by: Markus Armbruster Reviewed-by: Peter Krempa --- tests/qapi-schema/doc-good.out | 4 +- tests/qapi-schema/event-case.out | 2

Re: [PATCH] configure: Require Python >= 3.5

Am 17.10.2019 um 21:39 hat John Snow geschrieben: > On 10/17/19 7:21 AM, Kevin Wolf wrote: > > Am 17.10.2019 um 00:48 hat John Snow geschrieben: > >> On 10/16/19 6:42 PM, Eduardo Habkost wrote: > >>> Python 3.5 is the oldest Python version available on our > >>> supported build platforms, and Pytho

Re: [PATCH 1/2] spapr: Introduce a interrupt presenter reset handler

On 18/10/2019 09:46, Greg Kurz wrote: > On Thu, 17 Oct 2019 16:42:40 +0200 > Cédric Le Goater wrote: > >> The interrupt presenters are not reseted today. Extend the sPAPR IRQ >> backend with a new cpu_intc_reset() handler which will be called by >> the CPU reset handler. >> >> spapr_realize_vcpu(

Re: [PATCH v7 1/2] docs: improve qcow2 spec about extending image header

08.10.2019 12:05, Vladimir Sementsov-Ogievskiy wrote: > 07.10.2019 23:21, Eric Blake wrote: >> On 10/7/19 11:04 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Make it more obvious how to add new fields to the version 3 header and >>> how to interpret them. >>> >>> Signed-off-by: Vladimir Sementsov-Ogi

Re: [PATCH 2/2] spapr/xive: Set the OS CAM line at reset

On 18/10/2019 10:07, Greg Kurz wrote: > On Thu, 17 Oct 2019 16:42:41 +0200 > Cédric Le Goater wrote: > >> When a Virtual Processor is scheduled to run on a HW thread, the >> hypervisor pushes its identifier in the OS CAM line. When running in >> TCG or kernel_irqchip=off, QEMU needs to emulate th

Re: [PATCH] block/backup: drop dead code from backup_job_create

Hi Vladimir, On Thu, Oct 17, 2019 at 05:21:22PM +0300, Vladimir Sementsov-Ogievskiy wrote: > After commit 00e30f05de1d195, there is no more "goto error" points > after job creation, so after "error:" @job is always NULL and we don't > need roll-back job creation. I don't know this code very well,

Re: [PATCH v2 2/2] migration: savevm_state_handler_insert: constant-time element insertion

On 18/10/2019 10:16, Dr. David Alan Gilbert wrote: > * Scott Cheloha (chel...@linux.vnet.ibm.com) wrote: >> savevm_state's SaveStateEntry TAILQ is a priority queue. Priority >> sorting is maintained by searching from head to tail for a suitable >> insertion spot. Insertion is thus an O(n) operati

RE: [QEMU][PATCH v2] ssi: xilinx_spips: Skip update of cs and fifo releated to spips in gqspi

Hi Francisco, Thanks I will send a V3 following your suggestion. Regards, Sai Pavan > -Original Message- > From: Francisco Iglesias > Sent: Thursday, October 17, 2019 7:05 PM > To: Sai Pavan Boddu > Cc: Alistair Francis ; Edgar Iglesias > ; Peter Maydell ; qemu- > de...@nongnu.org > Su

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

Since it seemed so easy, while bisecting I found that it hangs with v4.0.0 and v3.1.0 from git and even v3.0.0. Since the reported good version was 3.1 I began to wonder if I might have overlooked something. I wondered if it might be e.g. the apache version providing a different behavior on http

Re: [PATCH] hw/s390x: Emit a warning if user tried to enable USB

On Fri, 18 Oct 2019 08:35:17 +0200 Thomas Huth wrote: > On 17/10/2019 20.18, Philippe Mathieu-Daudé wrote: > > On 10/17/19 4:40 PM, Thomas Huth wrote: > >> On 17/10/2019 16.34, Cornelia Huck wrote: > >>> On Thu, 17 Oct 2019 16:21:23 +0200 > >>> Thomas Huth wrote: > >>> > There is no U

Re: iotest failure -- test possibly not using sufficiently unique temp filename?

On 18.10.19 08:20, Thomas Huth wrote: > On 17/10/2019 18.41, Peter Maydell wrote: >> On Fri, 27 Sep 2019 at 17:44, Max Reitz wrote: >>> >>> On 27.09.19 18:39, Peter Maydell wrote: Hi; I just saw this iotest failure (on an s390x box, as it happens): TESTiotest-qcow2: 130 [fail]

Re: [PATCH v32 04/13] target/avr: Add instruction translation - Registers definition

On Thursday, October 17, 2019, Michael Rolnik wrote: > On Thu, Oct 17, 2019 at 11:17 PM Aleksandar Markovic > wrote: > >> > >> > >> >> +static TCGv cpu_Cf; > >> >> +static TCGv cpu_Zf; > >> >> +static TCGv cpu_Nf; > >> >> +static TCGv cpu_Vf; > >> >> +static TCGv cpu_Sf; > >> >> +static TCGv cpu

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

Hi, Could you try the qemu’s master branch? bfb23b480a49114315877aacf700b49453e0f9d9 has fixed an issue that sounds very much like this. The problem in that case is that libcurl 7.59.0 changed behavior, so bisecting qemu will not produce results. Max -- You received this bug notification becau

Re: [PATCH v2 01/23] iotests: Introduce $SOCK_DIR

On 17.10.19 16:52, Eric Blake wrote: > On 10/17/19 8:31 AM, Max Reitz wrote: >> Unix sockets generally have a maximum path length.  Depending on your >> $TEST_DIR, it may be exceeded and then all tests that create and use >> Unix sockets there may fail. >> >> Circumvent this by adding a new scratch

[PATCH v3] ssi: xilinx_spips: Skip spi bus update for few register writes

Few of the register writes need not update the spi bus state, so just return after reg write. Added few more dummy register offsets which need the same behaviour. Signed-off-by: Sai Pavan Boddu --- Changes for V2: Just skip update of spips cs and fifos Update commit message accord

Re: [PATCH 25/32] hw/pci-host/piix: Extract piix3_create()

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > Extract the PIIX3 creation code from the i440fx_init() function. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/piix.c | 51 -- > 1 file changed, 31 insertions(+), 20 deletio

Re: [PATCH 26/32] hw/pci-host/piix: Move RCR_IOPORT register definition

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > The RCR_IOPORT register belongs to the PIIX chipset. > Move the definition to "piix.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/piix.c| 1 + > include/hw/i386/pc.h

[PATCH v4] migration: Support QLIST migration

Support QLIST migration using the same principle as QTAILQ: 94869d5c52 ("migration: migrate QTAILQ"). The VMSTATE_QLIST_V macro has the same proto as VMSTATE_QTAILQ_V. The change mainly resides in QLIST RAW macros: QLIST_RAW_INSERT_HEAD and QLIST_RAW_REVERSE. Tests also are provided. Signed-off-

Re: [PATCH v3] migration: Support QLIST migration

Hi Juan, On 10/17/19 10:06 AM, Juan Quintela wrote: > Eric Auger wrote: >> Support QLIST migration using the same principle as QTAILQ: >> 94869d5c52 ("migration: migrate QTAILQ"). >> >> The VMSTATE_QLIST_V macro has the same proto as VMSTATE_QTAILQ_V. >> The change mainly resides in QLIST_RAW_INS

Re: [PATCH 27/32] hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > The IRQ Route Control registers definitions belong to the PIIX > chipset. We were only defining the 'A' register. Define the other > B, C and D registers, and use them. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/xen/xe

Re: [PATCH v7 1/2] docs: improve qcow2 spec about extending image header

18.10.2019 11:29, Vladimir Sementsov-Ogievskiy wrote: > 08.10.2019 12:05, Vladimir Sementsov-Ogievskiy wrote: >> 07.10.2019 23:21, Eric Blake wrote: >>> On 10/7/19 11:04 AM, Vladimir Sementsov-Ogievskiy wrote: Make it more obvious how to add new fields to the version 3 header and how to i

Re: [PATCH 28/32] hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > The hw/pci-host/piix.c contains a mix of PIIX3 and i440FX chipsets > functions. To be able to split it, we need to export some > declarations first. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH 29/32] hw/pci-host/piix: Fix code style issues

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > We will move this code, fix its style first. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/piix.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > Reviewed-by: Aleksandar Markovic > diff --git a/h

Re: [PATCH 2/2] spapr/xive: Set the OS CAM line at reset

On Thu, Oct 17, 2019 at 04:42:41PM +0200, Cédric Le Goater wrote: > When a Virtual Processor is scheduled to run on a HW thread, the > hypervisor pushes its identifier in the OS CAM line. When running in > TCG or kernel_irqchip=off, QEMU needs to emulate the same behavior. > > Introduce a 'os-cam'

Re: [PATCH 1/2] spapr: Introduce a interrupt presenter reset handler

On Thu, Oct 17, 2019 at 04:42:40PM +0200, Cédric Le Goater wrote: > The interrupt presenters are not reseted today. I don't think that's accurate. We register reset handlers for both ICP and TCTX already. We might not be resetting in quite the right order, but this will need a clearer descriptio

Re: [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings

On 22/01/2019 19.10, Eric Blake wrote: > On 1/22/19 11:23 AM, Daniel P. Berrangé wrote: > >> On this point though, does anyone know of any platforms we support[1], or are likely to support in future, where 'strerror' is *not* thread safe ? >>> >>> I'm not coming up with one, and I t

Re: [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings

On Fri, Oct 18, 2019 at 11:31:15AM +0200, Thomas Huth wrote: > On 22/01/2019 19.10, Eric Blake wrote: > > On 1/22/19 11:23 AM, Daniel P. Berrangé wrote: > > > >> > On this point though, does anyone know of any platforms we support[1], > or are likely to support in future, where 'strerror

Re: [PATCH 30/32] hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Move all the PIIX3 functions to a new file: hw/isa/piix3.c. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Checkpatch warning: > > ERROR: spaces required around that '*' (ctx:VxV) > #312: FILE: h

Re: [PATCH 31/32] hw/pci-host: Rename incorrectly named 'piix' as 'i440fx'

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > We moved all the PIIX3 southbridge code out of hw/pci-host/piix.c, > it now only contains i440FX northbridge code. > Rename it to match the chipset modelled. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH 1/2] spapr: Introduce a interrupt presenter reset handler

On Fri, 18 Oct 2019 13:47:07 +1100 David Gibson wrote: > On Thu, Oct 17, 2019 at 04:42:40PM +0200, Cédric Le Goater wrote: > > The interrupt presenters are not reseted today. > > I don't think that's accurate. We register reset handlers for both > ICP and TCTX already. We might not be resettin

Re: [PATCH 2/2] spapr/xive: Set the OS CAM line at reset

On 18/10/2019 05:55, David Gibson wrote: > On Thu, Oct 17, 2019 at 04:42:41PM +0200, Cédric Le Goater wrote: >> When a Virtual Processor is scheduled to run on a HW thread, the >> hypervisor pushes its identifier in the OS CAM line. When running in >> TCG or kernel_irqchip=off, QEMU needs to emulat

Re: [PATCH v2 2/2] migration: savevm_state_handler_insert: constant-time element insertion

* Laurent Vivier (lviv...@redhat.com) wrote: > On 18/10/2019 10:16, Dr. David Alan Gilbert wrote: > > * Scott Cheloha (chel...@linux.vnet.ibm.com) wrote: > >> savevm_state's SaveStateEntry TAILQ is a priority queue. Priority > >> sorting is maintained by searching from head to tail for a suitable

Re: [PATCH 1/2] spapr: Introduce a interrupt presenter reset handler

On 18/10/2019 04:47, David Gibson wrote: > On Thu, Oct 17, 2019 at 04:42:40PM +0200, Cédric Le Goater wrote: >> The interrupt presenters are not reseted today. > > I don't think that's accurate. We register reset handlers for both > ICP and TCTX already. We might not be resetting in quite the ri

[PATCH v8 0/3] qcow2: add zstd cluster compression

Hi all! Here is my proposal, about how to correctly update qcow2 specification to introduce new field, keeping in mind currently existing images and downstream Qemu instances. v8: Add padding, and clarify "zero equals absence" concept. Move some points to commit message from the spec itself.

[PATCH v8 2/3] docs: define padding for qcow2 header

Header extensions ends are already defined to be multiply of 8. Let's gently ask for header length to be a multiply of 8 too, when we have some additional fields. Requiring this may be considered as an incompatible change, so the padding is optional. Actually, padding is allowed before this patch (

[PATCH v8 3/3] docs: qcow2: introduce compression type feature

The patch add new additional field to qcow2 header: compression_type, which specifies compression type. If field is absent or zero, default compression type is set: ZLIB, which corresponds to current behavior. New compression type (ZSTD) is to be added in further commit. Suggested-by: Denis Plotn

[PATCH v8 1/3] docs: improve qcow2 spec about extending image header

Make it more obvious how to add new fields to the version 3 header and how to interpret them. The specification is adjusted so for new defined optional fields: 1. Software may support some of these optional fields and ignore the others, which means that features may be backported to downstream

Re: [PULL 00/18] x86 and machine queue, 2019-10-15

On Tue, 15 Oct 2019 at 22:37, Eduardo Habkost wrote: > > The following changes since commit 69b81893bc28feb678188fbcdce52eff1609bdad: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20191015' into staging (2019-10-15 > 18:15:59 +0100) > > are available in the Git repo

[PATCH] qemu-img.texi: Describe data_file and data_file_raw

https://bugzilla.redhat.com/show_bug.cgi?id=1763105 Signed-off-by: Han Han --- qemu-img.texi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index b5156d6316..44596c2d93 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -763,6 +763,16 @@ file which i

Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support

On Fri, Oct 18, 2019 at 08:48:23AM +0200, Thomas Huth wrote: > On 17/10/2019 18.18, Thomas Huth wrote: > > On 17/10/2019 18.07, Stefan Hajnoczi wrote: > >> On Thu, Oct 17, 2019 at 04:52:54PM +0200, Thomas Huth wrote: > >>> On 11/10/2019 10.56, Stefan Hajnoczi wrote: > Implement the VIRTIO 1.0

Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

On Fri, Oct 18, 2019 at 09:16:36AM +0200, Miklos Szeredi wrote: > On Thu, Oct 17, 2019 at 6:48 PM Miklos Szeredi wrote: > > > Even simpler: allow O_PATH descriptors for f*xattr(). > > Attached patch. Will post shortly. > > However, I think it would make sense to fix virtiofsd as well, as this

Re: [PATCH 26/32] hw/pci-host/piix: Move RCR_IOPORT register definition

On 10/18/19 11:19 AM, Aleksandar Markovic wrote: On Tuesday, October 15, 2019, Philippe Mathieu-Daudé > wrote: From: Philippe Mathieu-Daudé mailto:f4...@amsat.org>> The RCR_IOPORT register belongs to the PIIX chipset. Move the definition to "piix.h". S

[PULL 0/4] Ui 20191018 patches

The following changes since commit f22f553efffd083ff624be116726f843a39f1148: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20191013' into staging (2019-10-17 16:48:56 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20191018-pull-reques

[PULL 2/4] curses: use the bit mask constants provided by curses

From: Matthew Kilgore The curses API provides the A_ATTRIBUTES and A_CHARTEXT bit masks for getting the attributes and character parts of a chtype, respectively. We should use provided constants instead of using 0xff. Signed-off-by: Matthew Kilgore Reviewed-by: Philippe Mathieu-Daudé Reviewed-

[PULL 4/4] ui: fix keymap file search in input-barrier object

From: Laurent Vivier If we try to start QEMU with "-k en-us", qemu prints a message and exits with: qemu-system-i386: could not read keymap file: 'en-us' It's because this function is called way too early, before qemu_add_data_dir() is called, and so qemu_find_file() fails. To fix that, mo

[PULL 3/4] curses: correctly pass the color pair to setcchar()

From: Matthew Kilgore The current code does not correctly pass the color pair information to setcchar(), it instead always passes zero. This results in the curses output always being in white on black. This patch fixes this by using PAIR_NUMBER() to retrieve the color pair number from the chtype

[PULL 1/4] ui: Fix hanging up Cocoa display on macOS 10.15 (Catalina)

From: Hikaru Nishida macOS API documentation says that before applicationDidFinishLaunching is called, any events will not be processed. However, some events are fired before it is called in macOS Catalina. This causes deadlock of iothread_lock in handleEvent while it will be released after the a

[PATCH] tests/vm: update openbsd to release 6.6

Signed-off-by: Gerd Hoffmann --- tests/vm/openbsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index b92c39f89a6f..9f82cd459fde 100755 --- a/tests/vm/openbsd +++ b/tests/vm/openbsd @@ -22,8 +22,8 @@ class OpenBSDVM(basevm.BaseVM):

Re: [PATCH v2 06/10] hw/arm/bcm2836: Create VideoCore address space in the SoC

On 10/18/19 12:57 AM, Philippe Mathieu-Daudé wrote: Currently the VideoCore is created in the Peripheral container as the 'GPU bus'. It is created there because the peripherals using DMA use physical addresses from the VideoCore bus. However the VideoCore is a GPU core placed at the same hierarch

Re: [PATCH 2/2] spapr/xive: Set the OS CAM line at reset

On 18/10/2019 11:42, Cédric Le Goater wrote: > On 18/10/2019 05:55, David Gibson wrote: >> On Thu, Oct 17, 2019 at 04:42:41PM +0200, Cédric Le Goater wrote: >>> When a Virtual Processor is scheduled to run on a HW thread, the >>> hypervisor pushes its identifier in the OS CAM line. When running in

Re: Python 2 and test/vm/netbsd

Hi, > > Running with V=1, I see packages being downloaded at reasonable speeds, but > > there's a huge interval (of various minutes) between each package download. > > I've found the cause for the slowness I'm seeing: for each file > being downloaded, the guest spents at least 75 seconds trying

[PATCH] Do not use %m in common code to print error messages

The %m format specifier is an extension from glibc - and when compiling QEMU for NetBSD, the compiler correctly complains, e.g.: /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c: In function 'sigfd_handler': /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c:64:13: warning: %m is only allowed in sy

[PATCH v11 00/15] Introduce the microvm machine type

microvm is a machine type inspired by Firecracker and constructed after its machine model. It's a minimalist machine type without PCI nor ACPI support, designed for short-lived guests. microvm also establishes a baseline for benchmarking and optimizing both QEMU and guest operating systems, since

[PATCH v11 01/15] hw/virtio: Factorize virtio-mmio headers

Put QOM and main struct definition in a separate header file, so it can be accessed from other components. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin --- include/hw/virtio/virtio-mmio.h | 73 +++

[PATCH v11 02/15] hw/i386/pc: rename functions shared with non-PC machines

The following functions are named *pc* but are not PC-machine specific but generic to the X86 architecture, rename them: load_linux -> x86_load_linux pc_new_cpu -> x86_new_cpu pc_cpus_init -> x86_cpus_init pc_cpu_index_to_props -> x86_cpu_

[PATCH v11 03/15] hw/i386/pc: fix code style issues on functions that will be moved out

Fix code style issues detected by checkpatch.pl on functions that will be moved out to x86.c. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- hw/i386/pc.c | 53 1 file changed, 29 insertions

[PATCH v11 04/15] hw/i386/pc: replace use of strtol with qemu_strtoui in x86_load_linux()

Follow checkpatch.pl recommendation and replace the use of strtol with qemu_strtoui in x86_load_linux(). Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- hw/i386/pc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/h

[PATCH v11 10/15] fw_cfg: add "modify" functions for all types

This allows to alter the contents of an already added item. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin Reviewed-by: Marc-André Lureau --- include/hw/nvram/fw_cfg.h | 42 +++ hw/nvram/fw_cfg.c | 29 +++ 2 files

[PATCH v11 14/15] hw/i386: Introduce the microvm machine type

microvm is a machine type inspired by Firecracker and constructed after its machine model. It's a minimalist machine type without PCI nor ACPI support, designed for short-lived guests. microvm also establishes a baseline for benchmarking and optimizing both QEMU and guest operating systems, since

[PATCH v11 05/15] hw/i386/pc: avoid an assignment in if condition in x86_load_linux()

Follow checkpatch.pl recommendation and avoid an assignment in if condition in x86_load_linux(). Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index c8608b8

Re: [PATCH] Do not use %m in common code to print error messages

On Fri, Oct 18, 2019 at 12:44:38PM +0200, Thomas Huth wrote: > The %m format specifier is an extension from glibc - and when compiling > QEMU for NetBSD, the compiler correctly complains, e.g.: > > /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c: In function 'sigfd_handler': > /home/qemu/qemu-tes

[PATCH v11 07/15] hw/i386/pc: move shared x86 functions to x86.c and export them

Move x86 functions that will be shared between PC and non-PC machine types to x86.c, along with their helpers. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Stefano Garzarella Reviewed-by: Michael S. Tsirkin --- include/hw/i386

[PATCH v11 09/15] hw/i386: make x86.c independent from PCMachineState

As a last step into splitting PCMachineState and deriving X86MachineState from it, make the functions previously extracted from pc.c to x86.c independent from PCMachineState, using X86MachineState instead. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathie

  1   2   3   4   5   >