From: Janosch Frank
Let's start moving the cpu reset functions into a single function with
a switch/case, so we can later use fallthroughs and share more code
between resets.
This patch introduces the reset function by renaming cpu_reset().
Signed-off-by: Janosch Frank
Reviewed-by: David
From: Janosch Frank
Let's also move the clear reset function into the reset handler.
Signed-off-by: Janosch Frank
Message-Id: <20191127175046.4911-5-fran...@linux.ibm.com>
Reviewed-by: David Hildenbrand
Reviewed-by: Thomas Huth
Signed-off-by: Cornelia Huck
---
target/s390x/cpu-qom.h | 1 +
The following changes since commit 084a398bf8aa7634738e6c6c0103236ee1b3b72f:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2019-12-13 18:14:07 +)
are available in the Git repository at:
https://github.com/cohuck/qemu tags/s390x-20191214-2
On 12/12/2019 20:01, Laurent Vivier wrote:
> 0xc020 is for Q900/Q950, Q800 uses 0xc000.
> This value was provided to the kernel, this explains why it was working
> even with wrong value
>
> Signed-off-by: Laurent Vivier
> ---
> hw/m68k/q800.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On Fri, 13 Dec 2019 21:12:18 +
Peter Maydell wrote:
> On Fri, 13 Dec 2019 at 16:19, Cornelia Huck wrote:
> >
> > The following changes since commit b0ca999a43a22b38158a33d3f5881648bb4f:
> >
> > Update version for v4.2.0 release (2019-12-12 16:45:57 +)
> >
> > are available in the
From: Janosch Frank
As it turns out we need to clear the ri controls and PSW enablement
bit to be architecture compliant.
Signed-off-by: Janosch Frank
Reviewed-by: Christian Borntraeger
Message-Id: <20191203132813.2734-4-fran...@linux.ibm.com>
Signed-off-by: Cornelia Huck
---
From: Janosch Frank
Let's move the intial reset into the reset handler and cleanup
afterwards.
Signed-off-by: Janosch Frank
Reviewed-by: David Hildenbrand
Message-Id: <20191128083723.11937-1-fran...@linux.ibm.com>
Reviewed-by: Thomas Huth
Signed-off-by: Cornelia Huck
---
From: Janosch Frank
It defaults to returning 0 anyway and that return value is not
necessary, as 0 is also the default rc that the caller would return.
While doing that we can simplify the logic a bit and return early if
we inject a PGM exception.
Signed-off-by: Janosch Frank
Reviewed-by:
On 10/12/2019 14:06, bilalwasim...@gmail.com wrote:
> From: bwasim
>
> This addition ensures that the IP does NOT boot up in promiscuous mode
> by default, and so the software only receives the desired
> packets(Unicast, Broadcast, Unicast / Multicast hashed) by default.
> The software running
On 12/12/2019 20:01, Laurent Vivier wrote:
> MacOS reads this address to identify the hardware.
>
> This is a basic implementation returning the ID of Quadra 800.
>
> Details:
>
> http://mess.redump.net/mess/driver_info/mac_technical_notes
>
> "There are 3 ID schemes [...]
> The third and
On 12/12/2019 20:01, Laurent Vivier wrote:
> On the way to run a MacOS ROM we need a more accurate
> emulation of the Quadra 800.
>
> This series fixes the ESCC base address that was wrong but
> as the linux kernel uses the one provided by the bootloader
> (in our case QEMU) it was not a
Am Thu, 12 Dec 2019 20:40:45 +0100
schrieb Laurent Vivier :
> This is used by netBSD (and MacOS ROM) to detect the MMU type
>
> Signed-off-by: Laurent Vivier
> ---
> target/m68k/cpu.c| 28 ++--
> target/m68k/cpu.h| 4
> target/m68k/helper.c | 16
From: Janosch Frank
The initiating cpu needs to be reset with an initial reset. While
doing a normal reset followed by a initial reset is not wrong per se,
the Ultravisor will only allow the correct reset to be performed.
Signed-off-by: Janosch Frank
Reviewed-by: David Hildenbrand
Add 5.0 machine types for arm/i440fx/q35/s390x/spapr.
For i440fx and q35, unversioned cpu models are still translated
to -v1; I'll leave changing this (if desired) to the respective
maintainers.
Signed-off-by: Cornelia Huck
Message-Id: <20191112104811.30323-1-coh...@redhat.com>
Acked-by: David
From: Boris Fiuczynski
Signed-off-by: Boris Fiuczynski
Reviewed-by: Eric Farman
Message-Id: <20191128143015.5231-1-fiu...@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Cornelia Huck
---
hw/vfio/ccw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
We neglected to clean up pending interrupts and emergency signals;
fix that.
Message-Id: <20191206135404.16051-1-coh...@redhat.com>
Signed-off-by: Cornelia Huck
Reviewed-by: David Hildenbrand
---
target/s390x/cpu.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
From: Markus Armbruster
cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(),
qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It
dereferences @errp when the visitor or the QOM setter fails. That's
wrong; see the big comment in error.h. Introduced in commit
From: Markus Armbruster
get_max_cpu_model() dereferences @errp when
kvm_s390_get_host_cpu_model() fails, apply_cpu_model() dereferences it
when kvm_s390_apply_cpu_model() fails, and s390_realize_cpu_model()
dereferences it when get_max_cpu_model() or check_compatibility()
fail. That's wrong;
From: Janosch Frank
Let's improve readability by:
* Using constants for the subcodes
* Moving parameter checking into a function
* Removing subcode > 6 check as the default case catches that
Signed-off-by: Janosch Frank
Reviewed-by: Cornelia Huck
Reviewed-by: Thomas Huth
Reviewed-by: David
From: Markus Armbruster
sclp_events_bus_realize() dereferences @errp when
object_property_set_bool() fails. That's wrong; see the big comment
in error.h. Introduced in commit f6102c329c "s390/sclp: rework sclp
event facility initialization + device realization".
No caller actually passes
On 12/12/2019 20:01, Laurent Vivier wrote:
> Current implementation is based on GLUE, an early implementation
> of the memory controller found in Macintosh II series.
>
> Quadra 800 uses in fact djMEMC:
>
> The djMEMC is an Apple custom integrated circuit chip that performs a
> variety of
From: Markus Armbruster
s390x-cpu property setters set_feature() and set_feature_group()
dereference @errp when the visitor fails. That's wrong; see the big
comment in error.h. Introduced in commit 0754f60429 "s390x/cpumodel:
expose features and feature groups as properties".
No caller
From: Markus Armbruster
qmp_query_cpu_definitions() passes @errp to get_max_cpu_model(), then
frees any error it gets back. This effectively ignores errors.
Dereferencing @errp is wrong; see the big comment in error.h. Passing
@errp is also wrong, because it works only as long as @errp is
The Posix implementation of guest-set-time invokes hwclock to
set/retrieve the time to/from the hardware clock. If hwclock
is not available, the user is currently informed that "hwclock
failed to set hardware clock to system time", which is quite
misleading. This may happen e.g. on s390x, which
On 13/12/2019 08:45, Laurent Vivier wrote:
> Le 13/12/2019 à 02:44, David Gibson a écrit :
>> On Thu, Dec 12, 2019 at 08:43:59PM +0100, Laurent Vivier wrote:
>>> Register addr 1 is defined as buffer A with handshake (vBufAH),
>>> register addr 15 is also defined as buffer A without handshake
On 13/12/2019 15.46, Stefan Hajnoczi wrote:
> The Linux virtio_blk.ko guest driver is removing legacy SCSI passthrough
> support. Deprecate this feature in QEMU too.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> qemu-deprecated.texi | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff
On 12/9/19 7:02 AM, Michal Simek wrote:
On 09. 12. 19 15:32, Guenter Roeck wrote:
On 12/8/19 11:48 PM, Edgar E. Iglesias wrote:
On Sun, Dec 08, 2019 at 11:19:33PM -0800, Guenter Roeck wrote:
On 12/8/19 10:42 PM, Michal Simek wrote:
Hi, +Edgar
On 08. 12. 19 23:38, Guenter Roeck wrote:
On
From: Joakim Tjernlund
ppc logs every type of Invalid instruction. This generates a lot
of garbage on console when sshd/ssh_keygen executes as
they try various insn to optimize its performance.
The invalid operation log is still there so an unknown insn
will still be logged.
Signed-off-by:
Signed-off-by: Philippe Mathieu-Daudé
---
hw/rtc/m48t59-internal.h | 5 -
hw/rtc/m48t59.c | 11 +--
hw/rtc/trace-events | 6 ++
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/hw/rtc/m48t59-internal.h b/hw/rtc/m48t59-internal.h
index
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5e5e3e52d6..4519592e64 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1078,6 +1078,8 @@ F: hw/pci-host/prep.[hc]
F: hw/isa/i82378.c
F: hw/isa/pc87312.c
Patchew URL:
https://patchew.org/QEMU/20191214121347.17071-1-joakim.tjernl...@infinera.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] ppc: remove excessive logging
Type: series
Message-id:
On Sunday, December 15, 2019, Aleksandar Markovic <
aleksandar.m.m...@gmail.com> wrote:
>
>
> On Sunday, December 15, 2019, Finn Thain
> wrote:
>
>> On Sat, 14 Dec 2019, Aleksandar Markovic wrote:
>>
>> > On Saturday, December 14, 2019, Finn Thain
>> > wrote:
>> >
>> > > Hi All,
>> > >
>> > >
On Sat, 14 Dec 2019, Aleksandar Markovic wrote:
> On Saturday, December 14, 2019, Finn Thain
> wrote:
>
> > Hi All,
> >
> > There is a bug in the DP8393X emulation that can stop packet reception.
> >
> >
> Can you provide the details of your test scenario?
>
> Thanks,
> Aleksandar
>
I test
On Sunday, December 15, 2019, Finn Thain wrote:
> On Sat, 14 Dec 2019, Aleksandar Markovic wrote:
>
> > On Saturday, December 14, 2019, Finn Thain
> > wrote:
> >
> > > Hi All,
> > >
> > > There is a bug in the DP8393X emulation that can stop packet reception.
> > >
> > >
> > Can you provide the
Hello
Anything suspicious that anyone can spot in here?? Still cannot get qemu to
compile
Keen to hear
-Original Message-
From: aijaz.b...@protonmail.com
Sent: Saturday, December 7, 2019 11:25 AM
To: 'Daniel P. Berrangé'
Cc: qemu-devel@nongnu.org
Subject: RE: Error compiling
Another trivial cleanup series.
v2: Rebased on 4.2
Philippe Mathieu-Daudé (2):
MAINTAINERS: Add missing m48t59 files to the PReP section
hw/timer/m48t59: Convert debug printf()s to trace events
hw/rtc/m48t59-internal.h | 5 -
hw/rtc/m48t59.c | 11 +--
MAINTAINERS
On Sat, 14 Dec 2019, Philippe Mathieu-Daud? wrote:
> Hi Finn,
>
> On 12/14/19 2:25 AM, Finn Thain wrote:
> > The LSB of descriptor address registers is used as an EOL flag.
> > It has to be masked when those registers are to be used as actual
> > addresses for copying memory around. But when the
On 11/20/19 4:24 PM, Marc-André Lureau wrote:
Since clocks are not QOM objects, replace PROP_PTR of clocks with
setters methods.
(in theory there should probably be different methods for omap1 &
omap2 intc, but this is left as a future improvement)
Reviewed-by: Peter Maydell
Signed-off-by:
On 11/20/19 4:24 PM, Marc-André Lureau wrote:
Since clocks are not QOM objects, replace PROP_PTR of clocks with
setters methods.
Move/adapt the existing TODO comment about a clock framework.
Reviewed-by: Peter Maydell
Signed-off-by: Marc-André Lureau
---
hw/arm/omap1.c| 2 +-
On 11/20/19 4:24 PM, Marc-André Lureau wrote:
Since clocks are not QOM objects, replace PROP_PTR of clocks with
setters methods.
Reviewed-by: Peter Maydell
Reviewed-by: Corey Minyard
Signed-off-by: Marc-André Lureau
---
hw/arm/omap1.c| 2 +-
hw/arm/omap2.c| 8
On 11/20/19 4:24 PM, Marc-André Lureau wrote:
There is no "saar" property. Note: I haven't been able to test this
code. Help welcome.
May fix commit 043715d1e0fbb3e3411be3f898c5b77b7f90327a ("target/mips:
Update ITU to utilize SAARI and SAAR CP0 registers")
Cc: Aleksandar Markovic
From: Joakim Tjernlund
QEMU can autodetect if it is started from Linux binfmt loader
when binfmt flag O is on.
Use that and require binfmt flag P as well which will enable QEMU
to pass in correct argv0 to the application.
Signed-off-by: Joakim Tjernlund
---
linux-user/main.c | 18
On 11/20/19 4:24 PM, Marc-André Lureau wrote:
Signed-off-by: Marc-André Lureau
---
hw/mips/mips_mipssim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c
index 3cd0e6eb33..2c2c7f25b2 100644
--- a/hw/mips/mips_mipssim.c
+++
On 11/20/19 4:24 PM, Marc-André Lureau wrote:
Register the memory region with sysbus_init_mmio() and look it up with
sysbus_mmio_get_region() to avoid accessing internal device fields.
Suggested-by: Peter Maydell
Signed-off-by: Marc-André Lureau
---
hw/char/serial.c | 1 +
On 12/12/19 1:36 AM, Richard Henderson wrote:
On 12/9/19 8:00 AM, Alex Bennée wrote:
-#ifdef CONFIG_DEBUG_TCG
-assert(flags == rebuild_hflags_internal(env));
-#endif
+assert_hflags_rebuild_correctly(env);
I'm trying to recall why we don't just use:
g_assert_cmphex(flags, =,
Hi Marc-André,
On 12/11/19 1:01 PM, Marc-André Lureau wrote:
Hi
On Sun, Dec 1, 2019 at 2:19 PM Marc-André Lureau
wrote:
- "chardev: generate an internal id when none given"
As explained, this is necessary for qdev_prop_set_chr()
ping
- "serial: register vmsd with DeviceClass"
This
On 11/21/19 2:51 PM, Peter Maydell wrote:
On Wed, 20 Nov 2019 at 15:30, Marc-André Lureau
wrote:
Signed-off-by: Marc-André Lureau
---
hw/sparc/leon3.c | 6 --
target/sparc/cpu.h | 1 -
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/sparc/leon3.c
Hi Joakim,
I'm cc'ing the PPC maintainers for you, so they won't miss your patch
(see
https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer
and the output of ./scripts/get_maintainer.pl -f target/ppc/excp_helper.c).
On 12/14/19 1:13 PM, Joakim Tjernlund wrote:
From:
Forgot to mention, the crash is a segfault.
If there is more information needed, I am happy to provide it.
** Description changed:
Hello,
I am using an uptodate Arch Linux 64bit with qemu version 4.2.0, but the
problem was also present in older versions. The problem occurs with Linux 5.4
Public bug reported:
Hello,
I am using an uptodate Arch Linux 64bit with qemu version 4.2.0, but the
problem was also present in older versions. The problem occurs with Linux 5.4
and 4.19.
The problem also occurs with Debian as guest. I am running sway.
If I provide -vga std, then qemu works
It is pointless to overlap a memory subregion with priority 0.
Use the simpler memory_region_add_subregion() function.
This patch was produced with the following spatch script:
@@
expression region;
expression offset;
expression subregion;
@@
The codebase use 'as' in variable names for AddressSpace objects,
and 'mr' for MemoryRegion objects. Since these variables are
MemoryRegion objects, rename them as 'mr' to avoid confusion with
AddressSpace objects.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.h | 2 +-
It is pointless to overlap a memory subregion with priority 0.
Use the simpler memory_region_add_subregion() function.
This patch was produced with the following spatch script:
@@
expression region;
expression offset;
expression subregion;
@@
It is pointless to overlap a memory subregion with priority 0.
Use the simpler memory_region_add_subregion() function.
This patch was produced with the following spatch script:
@@
expression region;
expression offset;
expression subregion;
@@
It is pointless to overlap a memory subregion with priority 0.
Use the simpler memory_region_add_subregion() function.
This patch was produced with the following spatch script:
@@
expression region;
expression offset;
expression subregion;
@@
If a subregion is mapped out of the parent region range, it
will never get accessed. Since this is a bug, abort to help
the developer notice the mistake.
Signed-off-by: Philippe Mathieu-Daudé
---
memory.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/memory.c b/memory.c
index
It is pointless to overlap a memory subregion with priority 0.
Use the simpler memory_region_add_subregion() function.
This patch was produced with the following spatch script:
@@
expression region;
expression offset;
expression subregion;
@@
On Sat, Dec 14, 2019 at 2:59 PM Philippe Mathieu-Daudé
wrote:
> On 12/13/19 10:00 PM, Niek Linnenbank wrote:
> > On Fri, Dec 13, 2019 at 12:56 AM Philippe Mathieu-Daudé
> > mailto:phi...@redhat.com>> wrote:
> >
> > Hi Niek,
> >
> > On 12/11/19 11:34 PM, Niek Linnenbank wrote:
> > >
It is pointless to overlap a memory subregion with priority 0.
Use the simpler memory_region_add_subregion() function.
This patch was produced with the following spatch script:
@@
expression region;
expression offset;
expression subregion;
@@
Hi,
In this series we use coccinelle to replace:
- memory_region_add_subregion_overlap(..., priority=0)
+ memory_region_add_subregion(...)
Rationale is the code is easier to read, and reviewers don't
have to worry about overlapping because it isn't used.
Last patch is a minor cleanup in
On 12/13/2019 11:03 PM, Dr. David Alan Gilbert wrote:
* Paolo Bonzini (pbonz...@redhat.com) wrote:
Use WITH_RCU_READ_LOCK_GUARD to avoid exiting colo_init_ram_cache
without releasing RCU.
Cc: Dr. David Alan Gilbert
Signed-off-by: Paolo Bonzini
Reviewed-by: Dr. David Alan Gilbert
It is pointless to overlap a memory subregion with priority 0.
Use the simpler memory_region_add_subregion() function.
This patch was produced with the following spatch script:
@@
expression region;
expression offset;
expression subregion;
@@
On 12/13/19 10:00 PM, Niek Linnenbank wrote:
On Fri, Dec 13, 2019 at 12:56 AM Philippe Mathieu-Daudé
mailto:phi...@redhat.com>> wrote:
Hi Niek,
On 12/11/19 11:34 PM, Niek Linnenbank wrote:
> Ping!
>
> Anyone would like to comment on this driver?
>
> I finished
On 12/14/19 5:28 PM, Peter Maydell wrote:
On Sat, 14 Dec 2019 at 15:56, Philippe Mathieu-Daudé wrote:
Hi,
In this series we use coccinelle to replace:
- memory_region_add_subregion_overlap(..., priority=0)
+ memory_region_add_subregion(...)
Rationale is the code is easier to read, and
On 12/12/19 9:01 PM, Laurent Vivier wrote:
MacOS reads this address to identify the hardware.
This is a basic implementation returning the ID of Quadra 800.
Details:
http://mess.redump.net/mess/driver_info/mac_technical_notes
"There are 3 ID schemes [...]
The third and most scalable is
On 12/14/19 11:47 AM, Mark Cave-Ayland wrote:
On 13/12/2019 08:45, Laurent Vivier wrote:
Le 13/12/2019 à 02:44, David Gibson a écrit :
On Thu, Dec 12, 2019 at 08:43:59PM +0100, Laurent Vivier wrote:
Register addr 1 is defined as buffer A with handshake (vBufAH),
register addr 15 is also
On Sat, 14 Dec 2019 at 18:17, Philippe Mathieu-Daudé wrote:
> Maybe we can a warning if priority=0, to force board designers to use
> explicit priority (explicit overlap).
Priority 0 is fine, it's just one of the possible positive and
negative values. I think what ideally we would complain about
On 12/14/19 2:25 AM, Finn Thain wrote:
A received packet consumes pkt_size bytes in the buffer and the frame
checksum that's appended to it consumes another 4 bytes. The Receive
Buffer Address register takes the former quantity into account but
not the latter. So the next packet written to the
Hi Finn,
On 12/14/19 2:25 AM, Finn Thain wrote:
This function re-uses its 'size' argument as a scratch variable.
Instead, declare a local 'size' variable for that purpose so that the
function result doesn't get messed up.
Signed-off-by: Finn Thain
---
hw/net/dp8393x.c | 9 +
1 file
On 12/14/19 2:25 AM, Finn Thain wrote:
It doesn't make sense to clear the command register bit unless the
command was actually issued.
Signed-off-by: Finn Thain
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/dp8393x.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff
Hi Finn,
On 12/14/19 2:25 AM, Finn Thain wrote:
The LSB of descriptor address registers is used as an EOL flag.
It has to be masked when those registers are to be used as actual
addresses for copying memory around. But when the registers are
to be updated the EOL bit should not be masked.
On Sat, 14 Dec 2019 at 15:56, Philippe Mathieu-Daudé wrote:
>
> Hi,
>
> In this series we use coccinelle to replace:
> - memory_region_add_subregion_overlap(..., priority=0)
> + memory_region_add_subregion(...)
>
> Rationale is the code is easier to read, and reviewers don't
> have to worry about
On 12/14/19 3:52 AM, Finn Thain wrote:
On Fri, 13 Dec 2019, no-re...@patchew.org wrote:
=== OUTPUT BEGIN ===
1/10 Checking commit 9c9ffc38e9b9 (dp8393x: Mask EOL bit from descriptor
addresses)
ERROR: return is not a function, parentheses are not required
#24: FILE: hw/net/dp8393x.c:200:
+
On 12/14/19 7:38 AM, Philippe Mathieu-Daudé wrote:
On 12/14/19 3:52 AM, Finn Thain wrote:
On Fri, 13 Dec 2019, no-re...@patchew.org wrote:
=== OUTPUT BEGIN ===
1/10 Checking commit 9c9ffc38e9b9 (dp8393x: Mask EOL bit from
descriptor addresses)
ERROR: return is not a function, parentheses
On Saturday, December 14, 2019, Finn Thain
wrote:
> Hi All,
>
> There is a bug in the DP8393X emulation that can stop packet reception.
>
>
Can you provide the details of your test scenario?
Thanks,
Aleksandar
> Whilst debugging that issue I found that the receiver algorithm differs
> from
Hi Alistair,
On 12/14/19 3:44 AM, Alistair Francis wrote:
Signed-off-by: Alistair Francis
Reviewed-by: Peter Maydell
---
hw/arm/Kconfig | 1 +
hw/misc/Kconfig | 3 +
hw/misc/Makefile.objs| 1 +
hw/misc/stm32f4xx_exti.c | 189
76 matches
Mail list logo
