[PULL 0/1] qemu-openbios queue 20200707

2020-07-07 Thread Mark Cave-Ayland
u-openbios-20200707 for you to fetch changes up to 1e04092feecfc8caaf314df2670bf9c645a0b122: Update OpenBIOS images to 75fbb41d built from submodule. (2020-07-07 21:54:37 +0100) qemu-open

Re: [PATCH v2 000/100] target/arm: Implement SVE2

2020-07-07 Thread LIU Zhiwei
On 2020/6/18 12:25, Richard Henderson wrote: I know this patch set is too big, and that there are parts that can be split out that are prepatory rather that specifically sve2. It's also not 100% tested. I have done some amount of testing vs ArmIE, but because of bugs and missing features ther

Re: [PATCH v3 3/7] roms/Makefile: Build the generic platform for RISC-V OpenSBI firmware

2020-07-07 Thread Alistair Francis
On Thu, Jul 2, 2020 at 8:22 PM Bin Meng wrote: > > From: Bin Meng > > The RISC-V generic platform is a flattened device tree (FDT) based > platform where all platform specific functionality is provided based > on FDT passed by previous booting stage. The support was added in > the upstream OpenSB

Re: [PATCH 0/6] target/riscv: NaN-boxing for multiple precison

2020-07-07 Thread LIU Zhiwei
Hi Richard, Ping for other patches in this patch set. I may not get you ideas. Could you give more information? Zhiwei On 2020/7/3 20:33, LIU Zhiwei wrote: On 2020/7/3 1:37, Richard Henderson wrote: On 6/26/20 1:59 PM, LIU Zhiwei wrote: Multiple precison shoule be supported by NaN-boxing.

[PULL 0/3] MIPS + TCG Continuous Benchmarking queue for July 7th, 2020

2020-07-07 Thread Aleksandar Markovic
On Tuesday, July 7, 2020, Paolo Bonzini wrote: > I haven't looked at the disassembler code; assuming it comes from an > upstream code base I don't think we should treat it differently from the > ARM disassembler (or for that matter the binutils ones) and basically > handle it as a black box for w

Re: [PATCH 00/21] target/xtensa: implement double precision FPU

2020-07-07 Thread Max Filippov
On Tue, Jul 7, 2020 at 12:21 PM Alex Bennée wrote: > Well it ran some xtensa tests thanks to the docker cross compiler > support. Do you know what toolchains we need? > > Currently we have the following: > > ENV CPU_LIST csp dc232b dc233c > ENV TOOLCHAIN_RELEASE 2018.02 > > RUN for cpu in $C

Re: [PATCH v3 6/7] gitlab-ci/opensbi: Update GitLab CI to build generic platform

2020-07-07 Thread Alistair Francis
On Thu, Jul 2, 2020 at 8:19 PM Bin Meng wrote: > > From: Bin Meng > > This updates the GitLab CI opensbi job to build opensbi bios images > for the generic platform. > > Signed-off-by: Bin Meng > Reviewed-by: Anup Patel Reviewed-by: Alistair Francis Alistair > > --- > > Changes in v3: > - G

Re: [PATCH v3 7/7] Makefile: Ship the generic platform bios images for RISC-V

2020-07-07 Thread Alistair Francis
On Thu, Jul 2, 2020 at 8:20 PM Bin Meng wrote: > > From: Bin Meng > > Update the install blob list to include the generic platform > fw_dynamic bios images. > > Signed-off-by: Bin Meng Shouldn't this patch be included in an earlier patch? Otherwise won't this break `make install` bisection? A

Re: [PATCH] cpu: Add starts_halted() method

2020-07-07 Thread Thiago Jung Bauermann
Hello Eduardo, Eduardo Habkost writes: > On Tue, Jul 07, 2020 at 05:43:33PM -0300, Thiago Jung Bauermann wrote: >> PowerPC sPAPRs CPUs start in the halted state, but generic QEMU code >> assumes that CPUs start in the non-halted state. spapr_reset_vcpu() >> attempts to rectify this by setting

Re: [PULL 40/41] vhost-vdpa: introduce vhost-vdpa backend

2020-07-07 Thread Bruce Rogers
On Fri, 2020-07-03 at 05:05 -0400, Michael S. Tsirkin wrote: > From: Cindy Lu > > Currently we have 2 types of vhost backends in QEMU: vhost kernel and > vhost-user. The above patch provides a generic device for vDPA > purpose, > this vDPA device exposes to user space a non-vendor-specific > conf

Re: [PATCH v1 3/3] target/riscv: Regen floating point rounding mode in dynamic mode

2020-07-07 Thread Bin Meng
Hi Alistair, On Wed, Jul 8, 2020 at 1:33 AM Alistair Francis wrote: > > On Thu, Jul 2, 2020 at 6:25 PM Bin Meng wrote: > > > > On Wed, Jul 1, 2020 at 4:23 AM Alistair Francis > > wrote: > > > > > > When a guest specificies the the rounding mode should be dynamic 0b111 > > > then we want to re-c

Re: [PATCH] ppc/pnv: Make PSI device types not user creatable

2020-07-07 Thread David Gibson
On Tue, Jul 07, 2020 at 06:35:57PM +0200, Greg Kurz wrote: > QEMU aborts with -device pnv-psi-POWER8: > > $ qemu-system-ppc64 -device pnv-psi-POWER8 > qemu-system-ppc64: hw/intc/xics.c:605: ics_realize: Assertion > `ics->xics' failed. > Aborted (core dumped) > > The Processor Service Interface Co

Re: [PATCH v4 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-07-07 Thread Andrzej Jakowski
On 7/6/20 12:15 AM, Klaus Jensen wrote: > On Jul 2 16:33, Andrzej Jakowski wrote: >> On 7/2/20 10:51 AM, Klaus Jensen wrote: >>> On Jul 2 08:07, Andrzej Jakowski wrote: On 7/2/20 3:31 AM, Klaus Jensen wrote: > Aight, an update here. This only happens when QEMU is run with a virtual >

RE: [PATCH V3 0/3] migration/colo: Optimize COLO framework code

2020-07-07 Thread Zhang, Chen
Hi Hailiang/Dave, No news for a while, any comments? Thanks Zhang Chen > -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Zhang, Chen > Sent: Monday, June 22, 2020 2:53 PM > To: Dr. David Alan Gilbert > Cc: Zhanghailiang ; qemu-dev de...@nong

[PATCH v2 0/4] target/avr: Few fixes

2020-07-07 Thread Philippe Mathieu-Daudé
Since v1: - added missing 'Fix store instructions display order' Few fixes on top of the AVR merger series Thomas sent yesterday: https://www.mail-archive.com/qemu-devel@nongnu.org/msg720089.html Based-on: <20200705140315.260514-1-h...@tuxfamily.org> Philippe Mathieu-Daudé (4): target/avr/cpu:

[PATCH v2 1/4] target/avr/cpu: Drop tlb_flush() in avr_cpu_reset()

2020-07-07 Thread Philippe Mathieu-Daudé
Since commit 1f5c00cfdb tlb_flush() is called from cpu_common_reset(). Signed-off-by: Philippe Mathieu-Daudé --- target/avr/cpu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/avr/cpu.c b/target/avr/cpu.c index 4e4dd4f6aa..50fb1c378b 100644 --- a/target/avr/cpu.c +++ b/target/avr/c

[PATCH v2 3/4] target/avr/disas: Fix store instructions display order

2020-07-07 Thread Philippe Mathieu-Daudé
While LOAD instructions use the target register as first argument, STORE instructions use it as second argument: LD Rd, X// Rd <- (X) ST Y, Rd// (Y) <- Rr Reported-by: Joaquin de Andres Signed-off-by: Philippe Mathieu-Daudé --- target/avr/disas.c | 20 ++--

[PATCH v2 2/4] target/avr/cpu: Fix $PC displayed address

2020-07-07 Thread Philippe Mathieu-Daudé
$PC is 16-bit wide. Other registers display addresses on a byte granularity. To have a coherent ouput, display $PC using byte granularity too. Signed-off-by: Philippe Mathieu-Daudé --- target/avr/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/avr/cpu.c b/target/

[RFC PATCH v2 4/4] target/avr/translate: Fix SBRC/SBRS instructions

2020-07-07 Thread Philippe Mathieu-Daudé
SBRC/SBRS instructions seem to be inverted. Signed-off-by: Philippe Mathieu-Daudé --- target/avr/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index fe03e676df..2f77fe3ba7 100644 --- a/target/avr/translate.c ++

[PULL 15/41] tests/docker: change tag naming scheme of our images

2020-07-07 Thread Alex Bennée
We've been misusing the tag naming scheme for some time by overloading the post : section with the image type. Really it should be saved for the revision of that particular build. Move the details to the other side so we have: qemu/image-name with the implied :latest version added by the toolin

[PULL 03/41] tests/vm: pass args through to BaseVM's __init__

2020-07-07 Thread Alex Bennée
From: Robert Foley Adding the args parameter to BaseVM's __init__. We will shortly need to pass more parameters to the class so let's just pass args rather than growing the parameter list. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Phil

[PULL 01/41] crypto/linux_keyring: fix 'secret_keyring' configure test

2020-07-07 Thread Alex Bennée
From: David Edmondson The configure test for 'secret_keyring' incorrectly checked the 'have_keyring' variable. Fixes: 54e7aac0562452e4fcab65ca5001d030eef2de15 Signed-off-by: David Edmondson Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20200618092636.71832-1-david.edmond...

[PULL 00/41] testing updates (vm, gitlab, misc build fixes)

2020-07-07 Thread Alex Bennée
There will be some docker failures until the official repository has seeded but local builds should continue to work. The following changes since commit eb6490f544388dd24c0d054a96dd304bc7284450: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200703' into staging (2

[PULL 04/41] tests/vm: Add configuration to basevm.py

2020-07-07 Thread Alex Bennée
From: Robert Foley Added use of a configuration to tests/vm/basevm.py. The configuration provides parameters used to configure a VM. This allows for providing alternate configurations to the VM being created/launched. cpu, machine, memory, and NUMA configuration are all examples of configuration

[PULL 07/41] tests/vm: Added a new script for ubuntu.aarch64.

2020-07-07 Thread Alex Bennée
From: Robert Foley ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Signed-off-by:

[PULL 02/41] util/coroutine: Cleanup start_switch_fiber_ for TSAN.

2020-07-07 Thread Alex Bennée
From: Robert Foley This is a cleanup patch to follow-up the patch which introduced TSAN. This patch makes separate start_switch_fiber_ functions for TSAN and ASAN. This does two things: 1. Unrelated ASAN and TSAN code is separate and each function only has arguments that are actually needed.

[PULL 41/41] tests/qht-bench: Adjust threshold computation

2020-07-07 Thread Alex Bennée
From: Richard Henderson In 06c4cc3660b3, we split the multiplication in two parts to avoid a clang warning. But because double still rounds to 53 bits, this does not provide additional precision beyond multiplication by nextafter(0x1p64, 0), the largest representable value smaller than 2**64. H

[PULL 10/41] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-07-07 Thread Alex Bennée
From: Robert Foley We add the ConsoleSocket object, which has a socket interface and which will consume all arriving characters on the socket, placing them into an in memory buffer. This will also provide those chars via recv() as would a regular socket. ConsoleSocket also has the option of dumpi

[PULL 05/41] tests/vm: Added configuration file support

2020-07-07 Thread Alex Bennée
From: Robert Foley Changes to tests/vm/basevm.py to allow accepting a configuration file as a parameter. Allows for specifying VM options such as cpu, machine, memory, and arbitrary qemu arguments for specifying options such as NUMA configuration. Also added an example conf_example_aarch64.yml an

[PULL 08/41] tests/vm: Added a new script for centos.aarch64.

2020-07-07 Thread Alex Bennée
From: Robert Foley centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20200601211421.1277-7-robert.fo...@linar

[PULL 20/41] gitlab: convert jobs to use custom built containers

2020-07-07 Thread Alex Bennée
From: Daniel P. Berrangé Now that we're building standard container images from dockerfiles in tests/docker/dockerfiles, we can convert the build jobs to use them. The key benefit of this is that a contributor can now more easily replicate the CI environment on their local machine. The container

[PULL 06/41] tests/vm: Add common Ubuntu python module

2020-07-07 Thread Alex Bennée
From: Robert Foley Add a common Ubuntu python module and make use of it with the ubuntu.i386 script. This is preparation for adding an Ubuntu script ubuntu.aarch64. Splitting out the common logic such as build_image() will reduce duplication. Signed-off-by: Robert Foley Tested-by: Philippe Mat

[PULL 18/41] gitlab: introduce explicit "container" and "build" stages

2020-07-07 Thread Alex Bennée
From: Daniel P. Berrangé If no stage is listed, jobs get put in an implicit "test" stage. Some jobs which create container images to be used by later stages are currently listed as in a "build" stages. Signed-off-by: Daniel P. Berrangé Acked-by: Laszlo Ersek Signed-off-by: Alex Bennée Reviewe

[PULL 09/41] tests/vm: change scripts to use self._config

2020-07-07 Thread Alex Bennée
From: Robert Foley This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-of

[PULL 27/41] tests/acceptance: skip LinuxInitrd 2gib with v4.16 on GitLab

2020-07-07 Thread Alex Bennée
This fails on GitLab but not when run locally on the same container image. It's very confusing. Signed-off-by: Alex Bennée Acked-by: Philippe Mathieu-Daudé Message-Id: <20200701135652.1366-30-alex.ben...@linaro.org> diff --git a/tests/acceptance/linux_initrd.py b/tests/acceptance/linux_initrd.p

[PULL 39/41] travis.yml: Test also the other targets on s390x

2020-07-07 Thread Alex Bennée
From: Thomas Huth s390x is our only big endian host in our CI, so building and testing QEMU there is quite valuable. Thus let's also test the other targets with additional jobs (also using different sets of pre-installed libraries to get a better coverage of the things that we test). Signed-off-

[PULL 11/41] tests/vm: Add workaround to consume console

2020-07-07 Thread Alex Bennée
From: Robert Foley This adds support to basevm.py so that we always drain the console chars. This makes use of support added in an earlier commit that allows QEMUMachine to use the ConsoleSocket. This is a workaround we found was needed since there is a known issue where QEMU will hang waiting

[PULL 12/41] tests/vm: switch from optsparse to argparse

2020-07-07 Thread Alex Bennée
optparse has been deprecated since version 3.2 and argparse is the blessed replacement. Take the opportunity to enhance our help output showing defaults when called. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé Reviewed-by: Robert Foley Message-Id: <20200701135652.1366-15-alex.be

[PULL 13/41] tests/vm: allow us to take advantage of MTTCG

2020-07-07 Thread Alex Bennée
We currently limit TCG guests to -smp 1 but now we have added some aarch64 guests we can do better when running on x86_64 hardware. Raise the limit for TCG guests when it is safe to do so. Signed-off-by: Alex Bennée Reviewed-by: Robert Foley Reviewed-by: Philippe Mathieu-Daudé Message-Id: <202

[PULL 14/41] tests/docker: check for an parameters not empty string

2020-07-07 Thread Alex Bennée
Reported-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Suggested-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200701135652.1366-17-alex.ben...@linaro.org> diff --git a/tests/docker/common.rc b/tests/docker/common.rc index 02cd67a8c5e8..ebc5b97ecf91 100755 --- a

[PULL 35/41] gitlab: limit re-builds of the containers

2020-07-07 Thread Alex Bennée
Most of the time we are just rebuilding the same things. We can skip this although currently there is no mechanism for picking up new distro releases. Rather than try to be too fine grained allow any change to trigger all the images being rebuilt. Signed-off-by: Alex Bennée Reviewed-by: Philippe

[PULL 17/41] gitlab-ci: Fix the change rules after moving the YML files

2020-07-07 Thread Alex Bennée
From: Thomas Huth The edk2.yml and opensbi.yml files have recently been moved/renamed, but the change has not been reflected in the rules in the YML files yet. Fixes: 922febe2af ("Move edk2 and opensbi YAML files to .gitlab-ci.d folder") Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PULL 38/41] shippable: pull images from registry instead of building

2020-07-07 Thread Alex Bennée
Now we have a source for registry images pull from there rather than re-building every time on shippable. Signed-off-by: Alex Bennée Message-Id: <20200701135652.1366-41-alex.ben...@linaro.org> diff --git a/.shippable.yml b/.shippable.yml index 81905727d14c..f6b742432e5f 100644 --- a/.shippable.y

[PULL 29/41] tests/tcg: add more default compilers to configure.sh

2020-07-07 Thread Alex Bennée
We were missing a bunch of compilers which we could use if they were locally installed. The defaults are based on Debian as they seem to be the best distro for well distributed cross-build compilers. Signed-off-by: Alex Bennée Message-Id: <20200701135652.1366-32-alex.ben...@linaro.org> diff --gi

[PULL 25/41] tests/acceptance: fix dtb path for machine_rx_gdbsim

2020-07-07 Thread Alex Bennée
The old path doesn't exist but the rx-virt.dtb file has the same checksum so lets use that. Signed-off-by: Alex Bennée Acked-by: Philippe Mathieu-Daudé Message-Id: <20200701135652.1366-28-alex.ben...@linaro.org> diff --git a/tests/acceptance/machine_rx_gdbsim.py b/tests/acceptance/machine_rx_g

[PULL 36/41] containers.yml: build with docker.py tooling

2020-07-07 Thread Alex Bennée
Instead of building the docker files directly use the same docker.py scripting as we do for building locally. This should help ensure we use the exact same steps and allow us to cache properly when building locally. To get this working you have to have a fairly recent docker binary otherwise you w

[PULL 32/41] gitlab: enable check-tcg for linux-user tests

2020-07-07 Thread Alex Bennée
Switch to building in the new debian-all-test-cross image which has most of the cross compilers inline. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20200701135652.1366-35-alex.ben...@linaro.org> diff --git a/.gitlab-ci.yml b/.gitlab-ci.y

[PULL 26/41] tests/acceptance: skip multicore mips_malta tests on GitLab

2020-07-07 Thread Alex Bennée
For some reason these tests fail all the time on GitLab. I can re-create the hang around 3% of the time locally but it doesn't seem to be MTTCG related. For now skipIf on GITLAB_CI. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Cc: Aleksandar Markovic Message-Id: <2020070113565

[PULL 31/41] linux-user/elfload: use MAP_FIXED_NOREPLACE in pgb_reserved_va

2020-07-07 Thread Alex Bennée
Given we assert the requested address matches what we asked we should also make that clear in the mmap flags. Otherwise we see failures in the GitLab environment for some currently unknown but allowable reason. We use MAP_FIXED_NOREPLACE if we can so we don't just clobber an existing mapping. Also

[PULL 28/41] gitlab: add acceptance testing to system builds

2020-07-07 Thread Alex Bennée
As part of migrating things from Travis to GitLab add the acceptance tests. To do this: - rename system1 to system-ubuntu-main - rename system2 to system-fedora-misc - split into build/check/acceptance - remove -j from check stages - use artifacts to save build stage - add post accepta

[PULL 40/41] tests/qht-bench: Adjust testing rate by -1

2020-07-07 Thread Alex Bennée
From: Richard Henderson Since the seed must be non-zero, subtracting 1 means puts the rate in 0..UINT64_MAX-1, which allows the 0 and UINT64_MAX thresholds to corrspond to 0% (never) and 100% (always). Suggested-by: Emilio G. Cota Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-

[PULL 24/41] tests/acceptance: skip s390x_ccw_vrtio_tcg on GitLab

2020-07-07 Thread Alex Bennée
Currently the test takes more the 900 seconds on GitLab and then times out. Running on Travis seems to be OK. Signed-off-by: Alex Bennée Message-Id: <20200701135652.1366-27-alex.ben...@linaro.org> diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py index 3aa57e88b0bf..00

[PULL 19/41] gitlab: build all container images during CI

2020-07-07 Thread Alex Bennée
From: Daniel P. Berrangé We have a number of container images in tests/docker/dockerfiles that are intended to provide well defined environments for doing test builds. We want our CI system to use these containers too. This introduces builds of all of them as the first stage in the CI, so that t

[PULL 16/41] .gitignore: un-ignore .gitlab-ci.d

2020-07-07 Thread Alex Bennée
The sooner we deprecate in-tree builds the sooner this mess of regexes can be thrown away. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200701135652.1366-19-alex.ben...@linaro.org> diff --git a/.gitignore b/.gitignore index 90acb4347d4

[PULL 21/41] gitlab: build containers with buildkit and metadata

2020-07-07 Thread Alex Bennée
According to the documentation to be able to use --cache-from for remote registries you need to enable both buildkit and inline the metadata. We want to do this to support pulling from gitlab when users build their local docker images. Signed-off-by: Alex Bennée Message-Id: <20200701135652.1366-2

[PULL 34/41] gitlab: split build-disabled into two phases

2020-07-07 Thread Alex Bennée
As we run check-qtest in "SLOW" mode this can timeout so split into two jobs. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20200701135652.1366-37-alex.ben...@linaro.org> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 13e9531724d2..83

[PULL 22/41] tests/docker: add --registry support to tooling

2020-07-07 Thread Alex Bennée
This allows us to point the tools towards a registry from which they can grab pre-built layers instead of doing everything from scratch each time. To enable this we need to be using the DOCKER_BUILDKIT engine. Signed-off-by: Alex Bennée Message-Id: <20200701135652.1366-25-alex.ben...@linaro.org>

[PULL 23/41] tests/docker: add packages needed for check-acceptance

2020-07-07 Thread Alex Bennée
We need additional python packages to run check-acceptance. Add them to the docker images we will be using later. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20200701135652.1366-26-alex.ben...@linaro.org> diff --git a/tests/docker/docker

[PULL 33/41] gitlab: add avocado asset caching

2020-07-07 Thread Alex Bennée
These can be quite big so lets cache them. I couldn't find any nots on ccache in the gitlab docs so I've just ignored it for now. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200701135652.1366-36-alex.ben...@linaro.org> diff --git a/.gitlab-ci.yml b/.gitlab-ci.y

[PULL 37/41] testing: add check-build target

2020-07-07 Thread Alex Bennée
If we want to continue to split build and check phase it seems like a good idea to allow building of the tests during our multi-threaded build phase. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Cc: Daniel P. Berrangé Message-Id: <20200701135652.1366-40-alex.ben...@linaro.org>

[Bug 1885827] Re: building plugin failed on Windows with mingw

2020-07-07 Thread Xiaolei
Hi Emilio, I got the ideas for the attempt with a dummy dll. However, my collegue and I both failed to generate libqemu_plugin.dll.a during make process. And running "make install" yields errors as follows: mkdir -p "C:/QEMU_install/QEMUa/applications" install -c -m 0644 /c/QRS_Project/simd

[PULL 30/41] tests/docker: add a linux-user testing focused image

2020-07-07 Thread Alex Bennée
We happily use all the cross images for both cross-building QEMU as well as building the linux-user tests. However calling docker from within docker seems not to work. As we can build in Debian anyway why not include an image that has all the compilers available for non-docker invocation. Signed-o

Re: [PATCH] virtio-net: fix removal of failover device

2020-07-07 Thread Jason Wang
On 2020/7/3 下午7:59, Michael S. Tsirkin wrote: On Fri, Jul 03, 2020 at 01:48:13PM +0200, Juan Quintela wrote: If you have a networking device and its virtio failover device, and you remove them in this order: - virtio device - the real device You get qemu crash. See bugzilla:https://bugzilla.r

Re: [PATCH v2] ftgmac100: fix dblac write test

2020-07-07 Thread Erik Smit
Hi Andrew, On Mon, 6 Jul 2020 at 03:59, Andrew Jeffery wrote: > On Sun, 28 Jun 2020, at 23:56, erik-smit wrote: > > The test of the write of the dblac register was testing the old value > > instead of the new value. This would accept the write of an invalid value > > but subsequently refuse any f

Re: [PATCH v3 1/2] net: tap: check if the file descriptor is valid before using it

2020-07-07 Thread Jason Wang
On 2020/7/2 上午3:39, Laurent Vivier wrote: +void qemu_set_nonblock(int fd) +{ +int f; +f = qemu_try_set_nonblock(fd); +assert(f == 0); } So we keep this assert which means it can still be triggered from monitor? I don't check all the callers, but I got: in tap_init_one() we ha

Re: Failure prints during format or mounting a usb storage device

2020-07-07 Thread Gerd Hoffmann
Hi, > > Gerd, do you know the purpose of the 'short_not_ok' parameter to > usb_packet_setup()? Well, some usb host controllers have a flag in the transfer control blocks to indicate the host controller should stop processing requests in case of a short transfer. The usb core uses the flag to j

Re: [v1] docs: Add to gdbstub documentation the PhyMemMode

2020-07-07 Thread Alex Bennée
Jon Doron writes: > The PhyMemMode gdb extension command was missing from the gdb.rst > document. > > Signed-off-by: Jon Doron Queued to docs/next, thanks. > --- > docs/system/gdb.rst | 20 > 1 file changed, 20 insertions(+) > > diff --git a/docs/system/gdb.rst b/docs/s

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Paolo Bonzini
On 07/07/20 07:33, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 7/7/20 6:45 AM, Thomas Huth wrote: >>> On 27/05/2020 10.47, Markus Armbruster wrote: "info qom-tree" prints children in unstable order. This is a pain when diffing output for different versions to find

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-07-07 Thread Jason Wang
On 2020/7/3 下午9:03, Peter Xu wrote: On Fri, Jul 03, 2020 at 03:24:19PM +0800, Jason Wang wrote: On 2020/7/2 下午11:45, Peter Xu wrote: On Thu, Jul 02, 2020 at 11:01:54AM +0800, Jason Wang wrote: So I think we agree that a new notifier is needed? Good to me, or a new flag should be easier (IOM

Re: [PATCH v2 2/2] tests: Skip over pcrUpdateCounter byte in result comparison

2020-07-07 Thread David Gibson
On Tue, Jul 07, 2020 at 12:05:22AM -0400, Stefan Berger wrote: > Due to a change in the TPM 2 code the pcrUpdate counter in the > PCRRead response is now different, so we skip comparison of the > 14th byte. Can you elaborate on this a bit, both in the code comment and the commit message. > > Sig

Re: [PATCH v2 1/2] tpm: tpm_spapr: Exit on TPM backend failures

2020-07-07 Thread David Gibson
On Tue, Jul 07, 2020 at 06:20:49AM +0200, Philippe Mathieu-Daudé wrote: > Hi Stefan, > > On 7/7/20 6:05 AM, Stefan Berger wrote: > > Exit on TPM backend failures in the same way as the TPM CRB and TIS device > > models do. > > Maybe the other models are not the best examples ;) > > > > > Signed

Re: [PATCH v2 1/4] target/avr/cpu: Drop tlb_flush() in avr_cpu_reset()

2020-07-07 Thread Thomas Huth
Am Tue, 7 Jul 2020 09:00:18 +0200 schrieb Philippe Mathieu-Daudé : > Since commit 1f5c00cfdb tlb_flush() is called from cpu_common_reset(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/avr/cpu.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target/avr/cpu.c b/target/av

Re: [PATCH v2 2/4] target/avr/cpu: Fix $PC displayed address

2020-07-07 Thread Thomas Huth
Am Tue, 7 Jul 2020 09:00:19 +0200 schrieb Philippe Mathieu-Daudé : > $PC is 16-bit wide. Other registers display addresses on a byte > granularity. > To have a coherent ouput, display $PC using byte granularity too. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/avr/cpu.c | 2 +- > 1

Re: [PATCH v3 07/44] qemu-option: Make uses of find_desc_by_name() more similar

2020-07-07 Thread Greg Kurz
On Mon, 6 Jul 2020 10:09:13 +0200 Markus Armbruster wrote: > This is to make the next commit easier to review. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- Reviewed-by: Greg Kurz > util/qemu-option.c | 32 +++

Re: [PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient

2020-07-07 Thread Greg Kurz
On Mon, 06 Jul 2020 22:01:38 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > On Mon, 6 Jul 2020 10:09:12 +0200 > > Markus Armbruster wrote: > > > >> Convert uses like > >> > >> opts = qemu_opts_create(..., &err); > >> if (err) { > >> ... > >> } > >> > >> to > >>

Re: [PATCH 1/3] target/avr: Drop tlb_flush() in avr_cpu_reset()

2020-07-07 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Since commit 1f5c00cfdb tlb_flush() is called from cpu_common_reset(). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > target/avr/cpu.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target/avr/cpu.c b/target/avr/cpu.c

Re: [PATCH v7 05/17] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

2020-07-07 Thread Philippe Mathieu-Daudé
On Tue, Jun 30, 2020 at 3:39 PM Philippe Mathieu-Daudé wrote: > > Only move the state machine to ReceivingData if there is no > pending error. This avoids later OOB access while processing > commands queued. > > "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" > > 4.3.3 Data Re

Re: [PATCH 2/3] target/avr: Fix $PC displayed address

2020-07-07 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > $PC is 16-bit wide. Other registers display addresses on a byte > granularity. > To have a coherent ouput, display $PC using byte granularity too. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/avr/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-07 Thread Daniel P . Berrangé
On Tue, Jul 07, 2020 at 04:14:40AM +0200, Philippe Mathieu-Daudé wrote: > On 7/7/20 3:14 AM, Richard Henderson wrote: > > On 6/29/20 12:08 AM, Philippe Mathieu-Daudé wrote: > >> Coverity noticed commit 950c4e6c94 introduced a dereference before > >> null check in get_opt_value (CID1391003): > >> >

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Daniel P . Berrangé
On Tue, Jul 07, 2020 at 06:45:57AM +0200, Thomas Huth wrote: > On 27/05/2020 10.47, Markus Armbruster wrote: > > "info qom-tree" prints children in unstable order. This is a pain > > when diffing output for different versions to find change. Print it > > sorted. > > > > Signed-off-by: Markus Arm

Re: [PATCH v3 08/44] qemu-option: Factor out helper find_default_by_name()

2020-07-07 Thread Greg Kurz
On Mon, 6 Jul 2020 10:09:14 +0200 Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > util/qemu-option.c | 47 ++ > 1 file changed, 27 insertions(+), 20 deletions

Re: [PATCH v4 1/1] tricore: added triboard with tc27x_soc

2020-07-07 Thread Bastian Koppelmann
On Mon, Jul 06, 2020 at 02:40:30PM +0200, David Brenken wrote: > From: Andreas Konopik > > Signed-off-by: Andreas Konopik > Signed-off-by: David Brenken > Signed-off-by: Georg Hofstetter > Signed-off-by: Robert Rasche > Signed-off-by: Lars Biermanski > --- > hw/tricore/Kconfig |

Re: [RFC PATCH 3/3] target/avr: Fix SBRC/SBRS instructions

2020-07-07 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > SBRC/SBRS instructions seem to be inverted. I'm having trouble following exactly how the skip logic is meant to work. Intuitively I would expect a skip if clear to be TCG_COND_EQ because that is true if bit & mask is compared to 0 but it's not clear that what h

Re: [PATCH v2 1/2] hw/net: Added CSO for IPv6

2020-07-07 Thread Jason Wang
On 2020/6/29 上午9:17, and...@daynix.com wrote: From: Andrew Added fix for checksum offload for IPv6 if a backend doesn't have a virtual header. This patch is a part of IPv6 fragmentation. Signed-off-by: Andrew Melnychenko Applied. Thanks --- hw/net/net_tx_pkt.c | 15 ---

Re: [PATCH] tests/qtest/libqtest: Do not overwrite child coredump

2020-07-07 Thread Thomas Huth
On 07/07/2020 05.19, Philippe Mathieu-Daudé wrote: > We are interested by the coredump of the child, not the qtest > parent. If the child generated a coredump, simply call > exit(EXIT_FAILURE) in the parent to avoid overwriting the > child coredump. > > Fixes: 71a268a5fd ("tests/libqtest: Improve

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Paolo Bonzini
On 07/07/20 10:46, Daniel P. Berrangé wrote: > On Tue, Jul 07, 2020 at 06:45:57AM +0200, Thomas Huth wrote: >> Sure, we can work around that problem in the CI (Alex has already a >> patch queued), but still, is there something you could do about this >> massive slowdown? > > I think the answer is

Re: [PATCH v2 2/2] hw/net: Added basic IPv6 fragmentation

2020-07-07 Thread Jason Wang
On 2020/6/29 上午9:18, and...@daynix.com wrote: From: Andrew Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1708065 Overall, there was an issue that big frames of IPv6 doesn't sent. With network backend with 'virtual header' - there was an issue in 'plen' field. Overall, during TSO, 'plen

Re: [PATCH 0/6] migration: bring savevm/loadvm/delvm over to QMP

2020-07-07 Thread Daniel P . Berrangé
On Mon, Jul 06, 2020 at 06:21:56PM +0200, Kevin Wolf wrote: > Am 06.07.2020 um 18:03 hat Daniel P. Berrangé geschrieben: > > On Mon, Jul 06, 2020 at 05:50:11PM +0200, Kevin Wolf wrote: > > > Am 06.07.2020 um 17:29 hat Daniel P. Berrangé geschrieben: > > > > On Mon, Jul 06, 2020 at 05:27:01PM

Re: [PATCH] riscv: Add OpenTitan Big Number (OTBN) device address

2020-07-07 Thread Bin Meng
On Tue, Jul 7, 2020 at 10:08 AM Julio Faracco wrote: > > This commit adds basics skecthes to implemente a OTBN unit. typo: skecthes, implemente > OTBN has address 0x5000 and size 0x40. > For further reference, see OTBN docummentation: typo: docummentation > https://docs.opentitan.org/h

Re: [PATCH 0/1] hw/block/nvme: fix assert on invalid irq vector

2020-07-07 Thread Maxim Levitsky
On Tue, 2020-06-09 at 17:32 +0200, Kevin Wolf wrote: > Am 09.06.2020 um 16:18 hat Philippe Mathieu-Daudé geschrieben: > > On 6/9/20 4:14 PM, Kevin Wolf wrote: > > > Am 09.06.2020 um 13:46 hat Klaus Jensen geschrieben: > > > > On Jun 9 13:17, Philippe Mathieu-Daudé wrote: > > > > > On 6/9/20 11:45

Re: [PATCH 5/6] migration: support excluding block devs in QMP snapshot commands

2020-07-07 Thread Daniel P . Berrangé
On Mon, Jul 06, 2020 at 05:57:08PM +0200, Kevin Wolf wrote: > Am 02.07.2020 um 19:57 hat Daniel P. Berrangé geschrieben: > > This wires up support for a new "exclude" parameter to the QMP commands > > for snapshots (savevm, loadvm, delvm). This parameter accepts a list of > > block driver state

Re: [PATCH] intel_iommu: Use correct shift for 256 bits qi descriptor

2020-07-07 Thread Jason Wang
On 2020/7/4 下午4:07, Liu Yi L wrote: In chapter 10.4.23 of VT-d spec 3.0, Descriptor Width bit was introduced in VTD_IQA_REG. Sfotware could set this bit to tell VT-d the QI descriptor Typo. from software would be 256 bits. Accordingly, the VTD_IQH_QH_SHIFT should be 5 when descriptor size

Re: [PATCH] trivial: Remove trailing whitespaces

2020-07-07 Thread David Gibson
On Mon, Jul 06, 2020 at 06:23:00PM +0200, Christophe de Dinechin wrote: > There are a number of unnecessary trailing whitespaces that have > accumulated over time in the source code. They cause stray changes > in patches if you use tools that automatically remove them. > > Tested by doing a `git d

Re: [PATCH 0/1] hw/block/nvme: fix assert on invalid irq vector

2020-07-07 Thread Klaus Jensen
On Jul 7 12:10, Maxim Levitsky wrote: > On Tue, 2020-06-09 at 17:32 +0200, Kevin Wolf wrote: > > Am 09.06.2020 um 16:18 hat Philippe Mathieu-Daudé geschrieben: > > > On 6/9/20 4:14 PM, Kevin Wolf wrote: > > > > Am 09.06.2020 um 13:46 hat Klaus Jensen geschrieben: > > > > > On Jun 9 13:17, Philipp

Re: [PATCH] tests/qtest/libqtest: Do not overwrite child coredump

2020-07-07 Thread Paolo Bonzini
On 07/07/20 11:03, Thomas Huth wrote: >> +++ b/tests/qtest/libqtest.c >> @@ -173,7 +173,12 @@ static void kill_qemu(QTestState *s) >> fprintf(stderr, "%s:%d: kill_qemu() detected QEMU death " >> "from signal %d (%s)%s\n", >> __FILE__, __LINE__, sig, signam

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Daniel P . Berrangé
On Tue, Jul 07, 2020 at 06:45:57AM +0200, Thomas Huth wrote: > On 27/05/2020 10.47, Markus Armbruster wrote: > > "info qom-tree" prints children in unstable order. This is a pain > > when diffing output for different versions to find change. Print it > > sorted. > > > > Signed-off-by: Markus Arm

Re: [PULL 00/41] testing updates (vm, gitlab, misc build fixes)

2020-07-07 Thread Alex Bennée
Alex Bennée writes: > There will be some docker failures until the official repository has > seeded but local builds should continue to work. You can force the docker builds to use my registry for example by setting: make docker-test-build REGISTRY=registry.gitlab.com/stsquad/qemu > >

Re: [PATCH] linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols

2020-07-07 Thread Laurent Vivier
Le 07/07/2020 à 02:10, Josh Kunz a écrit : > Linux uses the EPROTONOSUPPORT error code[1] if the users requests a > netlink socket with an unsupported netlink protocol. This change > switches linux-user to use the same code as Linux, instead of > EPFNOSUPPORT (which AFAIK is just an anachronistic v

Re: [PATCH v3] hw/core/qdev: Increase qdev_realize() kindness

2020-07-07 Thread Paolo Bonzini
On 07/07/20 05:33, Philippe Mathieu-Daudé wrote: > Since commit 510ef98dca5, qdev_realize() aborts if bus-less device > is realized on a bus. While commits 514db7710b..007d1dbf72 took > care of converting all mainstream uses, QEMU forks weren't. These > forks are usually maintained by hobbyist with

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Paolo Bonzini
On 07/07/20 11:40, Daniel P. Berrangé wrote: > > The info qom-tree calls could be pushed outside the loop > >info qom-tree >for each device type > device_addr type,help >info qom-tree > > Taking /x86_64/device/introspect/concrete/defaults/pc-q35-5.1 as a > example, this change

  1   2   3   4   5   >