Re: [PATCH 0/6] target/riscv: NaN-boxing for multiple precison

2020-07-10 Thread LIU Zhiwei
On 2020/7/8 23:35, Richard Henderson wrote: On 7/7/20 2:45 PM, LIU Zhiwei wrote: On 2020/7/3 1:37, Richard Henderson wrote: I think it would be better to do all of the nan-boxing work inside of the helpers, including the return values. Do you mean a helper function just for nan-boxing work?

Re: [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it

2020-07-10 Thread Paolo Bonzini
On 09/07/20 19:00, Jim Mattson wrote: >> >> Mostly fine. Some edge cases, like different page fault errors for >> addresses above GUEST_MAXPHYADDR and below HOST_MAXPHYADDR. Which I >> think Mohammed fixed in the kernel recently. > Doesn't this require intercepting MOV-to-CR3 when the

Re: [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it

2020-07-10 Thread Paolo Bonzini
On 09/07/20 21:13, Eduardo Habkost wrote: >> Doesn't this require intercepting MOV-to-CR3 when the guest is in PAE >> mode, so that the hypervisor can validate the high bits in the PDPTEs? > If the fix has additional overhead, is the additional overhead > bad enough to warrant making it optional?

Re: Separate notifications from list messages?

2020-07-10 Thread Liviu Ionescu
> On 10 Jul 2020, at 07:19, Thomas Huth wrote: > > ... creating a qemu-notify mailing list for notification e-mails? In GitHub it is possible to 'Watch' projects, and when doing so, you get various notifications. Isn't something similar available in GitLab too? Liviu

Re: [PATCH RFC 3/5] s390x: prepare device memory address space

2020-07-10 Thread David Hildenbrand
On 09.07.20 12:59, Cornelia Huck wrote: > On Wed, 8 Jul 2020 20:51:33 +0200 > David Hildenbrand wrote: > >> Let's allocate the device memory information and setup the device >> memory address space. Expose the maximum ramsize via SCLP and the actual >> initial ramsize via diag260. >> >> Signed-o

Re: [PULL 0/5] fw_cfg/crypto patches for 5.1 soft freeze

2020-07-10 Thread Peter Maydell
On Sat, 4 Jul 2020 at 17:41, Philippe Mathieu-Daudé wrote: > > The following changes since commit 4abf70a661a5df3886ac9d7c19c3617fa92b922a: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-06-24' = > into staging (2020-07-03 15:34:45 +0100) > > are available in the Git rep

Re: [PATCH v2] vhost-vdpa :Fix Coverity CID 1430270 / CID 1420267

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 07:47, Cindy Lu wrote: > > In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialized > all its fields. > > Signed-off-by: Cindy Lu > --- > hw/virtio/vhost-vdpa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Peter Maydell

Re: Separate notifications from list messages?

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 05:20, Thomas Huth wrote: > > On 09/07/2020 20.14, Liviu Ionescu wrote: > > Now, with the migration to GitLab under way, could you consider separating > > the notifications sent by GitLab from the messages exchanged on the list? > > > > I mean allowing those interested in r

Re: [PATCH] Remove VXHS block device

2020-07-10 Thread Peter Maydell
On Thu, 9 Jul 2020 at 19:49, Marc-André Lureau wrote: > > The vxhs code doesn't compile since v2.12.0. There's no point in fixing > and then adding CI for a config that our users have demonstrated that > they do not use; better to just remove it. > > Signed-off-by: Marc-André Lureau > --- > conf

Re: [PULL 00/10] Modules 20200707 patches

2020-07-10 Thread Thomas Huth
On 07/07/2020 15.42, Gerd Hoffmann wrote: > The following changes since commit 7623b5ba017f61de5d7c2bba12c6feb3d55091b1: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging > (2020-07-06 11:40:10 +0100) > > are available in the Git repository

Re: [PATCH 1/2] hw/char/serial: Separate and document static properties

2020-07-10 Thread Peter Maydell
On Fri, 3 Jul 2020 at 19:59, Philippe Mathieu-Daudé wrote: > > Add more descriptive comments to keep a clear separation > between static property vs runtime changeable. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/char/serial.h | 7 +-- > 1 file changed, 5 insertions(+), 2 de

Re: Separate notifications from list messages?

2020-07-10 Thread Liviu Ionescu
> On 10 Jul 2020, at 11:09, Peter Maydell wrote: > > What sort of notifications are we talking about here ? For example: ... Received: from mg.gitlab.com (74.90.74.34.bc.googleusercontent.com [34.74.90.74]) by smtp-out-n18.prod.us-west-2.postgun.com with SMTP id 5f074fb9a33b1a3dd4571072 (v

Re: [PATCH 09/13] nbd: add GUri-based URI parsing version

2020-07-10 Thread Daniel P . Berrangé
On Thu, Jul 09, 2020 at 11:42:30PM +0400, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > block/nbd.c| 86 +++--- > util/Makefile.objs | 2 +- > 2 files changed, 66 insertions(+), 22 deletions(-) > > diff --git a/block/nbd.c b/

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-10 Thread David Hildenbrand
On 09.07.20 12:37, Cornelia Huck wrote: > On Wed, 8 Jul 2020 20:51:32 +0200 > David Hildenbrand wrote: > >> Let's implement the "storage configuration" part of diag260. This diag >> is found under z/VM, to indicate usable chunks of memory tot he guest OS. >> As I don't have access to documentati

Re: Separate notifications from list messages?

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 09:25, Liviu Ionescu wrote: > > > > > On 10 Jul 2020, at 11:09, Peter Maydell wrote: > > > > What sort of notifications are we talking about here ? > > For example: > > ... > Received: from mg.gitlab.com (74.90.74.34.bc.googleusercontent.com > [34.74.90.74]) by smtp-out-n1

Re: [PATCH 2/2] hw/char/serial: Allow migration of the I/O serial device

2020-07-10 Thread Peter Maydell
On Tue, 7 Jul 2020 at 11:40, Paolo Bonzini wrote: > > On 03/07/20 20:58, Philippe Mathieu-Daudé wrote: > > The serial device mapped on the I/O bus hold a migratable > > SerialState. Keep the same version range from SerialState: > > > > 837 const VMStateDescription vmstate_serial = { > > 838

Re: [PULL 00/12] Block patches

2020-07-10 Thread Kevin Wolf
Am 09.07.2020 um 20:41 hat Eduardo Habkost geschrieben: > On Thu, Jul 09, 2020 at 05:02:06PM +0200, Kevin Wolf wrote: > > Am 08.07.2020 um 00:05 hat Eduardo Habkost geschrieben: > > > On Tue, Jul 07, 2020 at 05:28:21PM +0200, Philippe Mathieu-Daudé wrote: > > > > On 6/26/20 12:25 PM, Stefan Hajnoc

Re: Separate notifications from list messages?

2020-07-10 Thread Liviu Ionescu
> On 10 Jul 2020, at 11:32, Peter Maydell wrote: > > ... Do we expect any other > kinds to appear as we make more use of gitlab? I have zero experience with gitlab, but on github yes, most project activity can trigger notifications. this is not a problem in itself. the problem is that, inst

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-10 Thread David Hildenbrand
On 10.07.20 10:32, David Hildenbrand wrote: > On 09.07.20 12:37, Cornelia Huck wrote: >> On Wed, 8 Jul 2020 20:51:32 +0200 >> David Hildenbrand wrote: >> >>> Let's implement the "storage configuration" part of diag260. This diag >>> is found under z/VM, to indicate usable chunks of memory tot he

Re: Separate notifications from list messages?

2020-07-10 Thread Philippe Mathieu-Daudé
On 7/10/20 10:32 AM, Peter Maydell wrote: > On Fri, 10 Jul 2020 at 09:25, Liviu Ionescu wrote: >>> On 10 Jul 2020, at 11:09, Peter Maydell wrote: >>> >>> What sort of notifications are we talking about here ? qemu-ci-notifications@ for all our CI? >> >> For example: >> >> ... >> Received: from

Re: Separate notifications from list messages?

2020-07-10 Thread Liviu Ionescu
> On 10 Jul 2020, at 11:43, Philippe Mathieu-Daudé wrote: > > On 7/10/20 10:32 AM, Peter Maydell wrote: >> On Fri, 10 Jul 2020 at 09:25, Liviu Ionescu wrote: On 10 Jul 2020, at 11:09, Peter Maydell wrote: What sort of notifications are we talking about here ? > > qemu-ci-not

Re: Separate notifications from list messages?

2020-07-10 Thread Daniel P . Berrangé
On Fri, Jul 10, 2020 at 09:32:28AM +0100, Peter Maydell wrote: > On Fri, 10 Jul 2020 at 09:25, Liviu Ionescu wrote: > > > > > > > > > On 10 Jul 2020, at 11:09, Peter Maydell wrote: > > > > > > What sort of notifications are we talking about here ? > > > > For example: > > > > ... > > Received: fr

[PATCH] softmmu/vl: Be less verbose about missing KVM when running the qtests

2020-07-10 Thread Thomas Huth
Some of the qtests use "-accel kvm -accel tcg" to run real guest code. This causes some error messages when kvm is not available. We do not really care about these messages since the fallback to tcg is expected here. So let's silence them to avoid that they spoil the output of the tests. Unfortuna

Re: [PATCH] block: Avoid stale pointer dereference in blk_get_aio_context()

2020-07-10 Thread Kevin Wolf
Am 09.07.2020 um 15:50 hat Greg Kurz geschrieben: > It is possible for blk_remove_bs() to race with blk_drain_all(), causing > the latter to dereference a stale blk->root pointer: > > > blk_remove_bs(blk) >bdrv_root_unref_child(blk->root) > child_bs = blk->root->bs > bdrv_detach_chi

[PATCH v1] qmp: don't hold ctx lock while querying blockstats

2020-07-10 Thread Zhenyu Ye
Because the QMP command runs in the main thread, and changes to the aio context of iothread will only be executed in the main thread (they will not be in parallel), so there is no need a lock protection while querying blockstats. If we hold the lock here, while the I/O pressure is high in vm and t

Re: Separate notifications from list messages?

2020-07-10 Thread Daniel P . Berrangé
On Fri, Jul 10, 2020 at 11:40:05AM +0300, Liviu Ionescu wrote: > > > > On 10 Jul 2020, at 11:32, Peter Maydell wrote: > > > > ... Do we expect any other > > kinds to appear as we make more use of gitlab? > > I have zero experience with gitlab, but on github yes, most project activity > can tr

Re: Separate notifications from list messages?

2020-07-10 Thread Liviu Ionescu
> On 10 Jul 2020, at 11:49, Daniel P. Berrangé wrote: > > This was an explicit configuration choice to make the CI failure reports > appear on the list, rather than expecting one or two people to be > responsible for watching the CI. I'm not familiar with your workflow, it might be so, but n

[PATCH] hw/net/ftgmac100: Fix integer overflow in ftgmac100_do_tx()

2020-07-10 Thread Mauro Matteo Cascella
An integer overflow issue was reported by Mr. Ziming Zhang, CC'd here. It occurs while inserting the VLAN tag in packets whose length is less than 12 bytes, as (len-12) is passed to memmove() without proper checking. This patch is intended to fix this issue by checking the minimum Ethernet frame si

Re: [PATCH v3 05/11] hw/arm/smmu-common: Manage IOTLB block entries

2020-07-10 Thread Peter Maydell
On Wed, 8 Jul 2020 at 15:19, Eric Auger wrote: > > At the moment each entry in the IOTLB corresponds to a page sized > mapping (4K, 16K or 64K), even if the page belongs to a mapped > block. In case of block mapping this unefficiently consumes IOTLB > entries. > > Change the value of the entry so

Re: [PATCH v3 05/11] hw/arm/smmu-common: Manage IOTLB block entries

2020-07-10 Thread Peter Maydell
On Wed, 8 Jul 2020 at 15:19, Eric Auger wrote: > > At the moment each entry in the IOTLB corresponds to a page sized > mapping (4K, 16K or 64K), even if the page belongs to a mapped > block. In case of block mapping this unefficiently consumes IOTLB > entries. > > Change the value of the entry so

QEMU | Pipeline #165121243 has failed for master | aecdfcc3

2020-07-10 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: aecdfcc3 ( https://gitlab.com/qemu-project/qemu/-/commit/aecdfcc3f8499b34a90e5b21159b4d245bc833c2 ) Commit Message: Merge remote-tr

Re: [RFC PATCH 2/3] hw/i2c/smbus_eeprom: Add description based on child name

2020-07-10 Thread Philippe Mathieu-Daudé
+Stefan for tracing PoV On 7/9/20 9:48 PM, Eduardo Habkost wrote: > On Fri, Jun 26, 2020 at 04:26:33PM +0200, Philippe Mathieu-Daudé wrote: >> On 6/26/20 1:00 PM, BALATON Zoltan wrote: >>> On Fri, 26 Jun 2020, Philippe Mathieu-Daudé wrote: Suggested-by: Markus Armbruster Signed-off-by

Re: [PATCH v3 07/11] hw/arm/smmuv3: Get prepared for range invalidation

2020-07-10 Thread Peter Maydell
On Wed, 8 Jul 2020 at 15:19, Eric Auger wrote: > > Enhance the smmu_iotlb_inv_iova() helper with range invalidation. > This uses the new fields passed in the NH_VA and NH_VAA commands: > the size of the range, the level and the granule. > > As NH_VA and NH_VAA both use those fields, their decoding

Re: [PATCH v3 08/11] hw/arm/smmuv3: Fix IIDR offset

2020-07-10 Thread Peter Maydell
On Wed, 8 Jul 2020 at 15:20, Eric Auger wrote: > > The SMMU IIDR register is at 0x018 offset. > > Signed-off-by: Eric Auger > Fixes: 10a83cb9887 ("hw/arm/smmuv3: Skeleton") > --- > hw/arm/smmuv3-internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/smmuv3-int

Re: [PATCH v3 09/11] hw/arm/smmuv3: Let AIDR advertise SMMUv3.0 support

2020-07-10 Thread Peter Maydell
On Wed, 8 Jul 2020 at 15:20, Eric Auger wrote: > > Add the support for AIDR register. It currently advertises > SMMU V3.0 spec. > > Signed-off-by: Eric Auger > > --- > --- > hw/arm/smmuv3-internal.h | 1 + > include/hw/arm/smmuv3.h | 1 + > hw/arm/smmuv3.c | 3 +++ > 3 files changed, 5

Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent

2020-07-10 Thread Philippe Mathieu-Daudé
On 7/9/20 10:05 PM, Eduardo Habkost wrote: > On Fri, Jun 26, 2020 at 04:15:40PM +0200, Philippe Mathieu-Daudé wrote: >> On 6/26/20 4:03 PM, BALATON Zoltan wrote: >>> On Fri, 26 Jun 2020, Philippe Mathieu-Daudé wrote: + Eduardo / Mark / Edgard / Alistair / Fred for QOM design. On 6/

Re: [PATCH v2] vhost-vdpa :Fix Coverity CID 1430270 / CID 1420267

2020-07-10 Thread Jason Wang
On 2020/7/10 下午2:46, Cindy Lu wrote: In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialized all its fields. Signed-off-by: Cindy Lu Acked-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virti

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-10 Thread David Hildenbrand
On 09.07.20 20:15, David Hildenbrand wrote: > On 09.07.20 12:52, Christian Borntraeger wrote: >> >> On 08.07.20 20:51, David Hildenbrand wrote: >>> Let's implement the "storage configuration" part of diag260. This diag >>> is found under z/VM, to indicate usable chunks of memory tot he guest OS. >>

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-10 Thread Cornelia Huck
On Fri, 10 Jul 2020 10:41:33 +0200 David Hildenbrand wrote: > On 10.07.20 10:32, David Hildenbrand wrote: > > On 09.07.20 12:37, Cornelia Huck wrote: > >> On Wed, 8 Jul 2020 20:51:32 +0200 > >> David Hildenbrand wrote: > >>> diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.

[PATCH] hw/net/xgmac: Fix buffer overflow in xgmac_enet_send()

2020-07-10 Thread Mauro Matteo Cascella
A buffer overflow issue was reported by Mr. Ziming Zhang, CC'd here. It occurs while sending an Ethernet frame due to missing break statements and improper checking of the buffer size. Reported-by: Ziming Zhang Signed-off-by: Mauro Matteo Cascella --- hw/net/xgmac.c | 7 +-- 1 file changed,

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#3] QEMU 5.0 and 5.1-pre-soft-freeze Dissect Comparison

2020-07-10 Thread Ahmed Karaman
On Thu, Jul 9, 2020 at 4:41 PM Alex Bennée wrote: > > > Ahmed Karaman writes: > > > Hi, > > > > The third report of the TCG Continuous Benchmarking series utilizes > > the tools presented in the previous report for comparing the > > performance of 17 different targets across two versions of QEMU.

Re: Separate notifications from list messages?

2020-07-10 Thread Liviu Ionescu
> On 10 Jul 2020, at 11:54, Daniel P. Berrangé wrote: > > This wasn't a mistake - it was very delibrate, precisely so that all > involved in QEMU development will see the failures, instead of expecting > a handful of people to take all the work of dealing with failures. In > general anyone who

Re: [PATCH 1/2] hw/char/serial: Separate and document static properties

2020-07-10 Thread Juan Quintela
Philippe Mathieu-Daudé wrote: > Add more descriptive comments to keep a clear separation > between static property vs runtime changeable. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [RFC PATCH 0/2] hw/sd: Deprecate the SPI mode and the SPI to SD adapter

2020-07-10 Thread Bin Meng
Hi Philippe, On Mon, Jul 6, 2020 at 6:07 AM Philippe Mathieu-Daudé wrote: > > I tried to maintain the SPI mode because it is useful in > tiny embedded devices, and thought it would be helpful for > the AVR MCUs. > As AVR was blocked, I thought it was wise to deprecate the > SPI mode as users are

Re: [PATCH v1] qmp: don't hold ctx lock while querying blockstats

2020-07-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200710085400.343-1-yezhen...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v3 10/11] hw/arm/smmuv3: Support HAD and advertise SMMUv3.1 support

2020-07-10 Thread Peter Maydell
On Wed, 8 Jul 2020 at 15:20, Eric Auger wrote: > > HAD is a mandatory features with SMMUv3.1 if S1P is set, which is > our case. Other 3.1 mandatory features come with S2P which we don't > have. > > So let's support HAD and advertise SMMUv3.1 support in AIDR. > > HAD support allows the CD to disab

Re: [PATCH v5 01/11] hw/misc: Add NPCM7xx System Global Control Registers device model

2020-07-10 Thread Philippe Mathieu-Daudé
On 7/9/20 7:42 PM, Havard Skinnemoen wrote: > On Thu, Jul 9, 2020 at 10:24 AM Philippe Mathieu-Daudé > wrote: >> On 7/9/20 7:09 PM, Havard Skinnemoen wrote: >>> On Thu, Jul 9, 2020 at 9:23 AM Philippe Mathieu-Daudé >>> wrote: On 7/9/20 8:43 AM, Havard Skinnemoen wrote: > On Wed, Jul 8,

Re: [PATCH 2/2] hw/char/serial: Allow migration of the I/O serial device

2020-07-10 Thread Juan Quintela
Philippe Mathieu-Daudé wrote: > The serial device mapped on the I/O bus hold a migratable > SerialState. Keep the same version range from SerialState: > > 837 const VMStateDescription vmstate_serial = { > 838 .name = "serial", > 839 .version_id = 3, > 840 .minimum_version_id = 2, >

Re: [PATCH v1] qmp: don't hold ctx lock while querying blockstats

2020-07-10 Thread Kevin Wolf
Am 10.07.2020 um 10:54 hat Zhenyu Ye geschrieben: > Because the QMP command runs in the main thread, and changes > to the aio context of iothread will only be executed in the > main thread (they will not be in parallel), so there is no > need a lock protection while querying blockstats. > > If we

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-10 Thread Anthony PERARD
On Thu, Jul 02, 2020 at 07:12:08AM -0400, Michael S. Tsirkin wrote: > memory: align to min access size > > If impl.min_access_size > valid.min_access_size access callbacks > can get a misaligned access as size is increased. > They don't expect that, let's fix it in the memory core. > > Signed-off

Re: [PATCH v3 0/2] qga: Ditch g_get_host_name()

2020-07-10 Thread Michal Privoznik
On 6/22/20 8:19 PM, Michal Privoznik wrote: v3 of: https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg06913.html diff to v2: - don't leak @hostname in util/oslib-posix.c:qemu_get_host_name() - document why we are allocating one byte more than needed - switch to g_new0() from g_malloc0(

Re: [PATCH v3 11/11] hw/arm/smmuv3: Advertise SMMUv3.2 range invalidation

2020-07-10 Thread Peter Maydell
On Wed, 8 Jul 2020 at 15:20, Eric Auger wrote: > > Expose the RIL bit so that the guest driver uses range > invalidation. Range invalidation being an SMMU3.2 feature, > let AIDR advertise SMMUv3.2 support. > > Signed-off-by: Eric Auger I think that to advertise SMMUv3.2 we would also need to set

[PATCH] block/amend: Check whether the node exists

2020-07-10 Thread Max Reitz
We should check whether the user-specified node-name actually refers to a node. The simplest way to do that is to use bdrv_lookup_bs() instead of bdrv_find_node() (the former wraps the latter, and produces an error message if necessary). Reported-by: Coverity (CID 1430268) Fixes: ced914d0ab9fb2c9

Re: [PATCH] hw/register: Document register_init_block @memory_size

2020-07-10 Thread Philippe Mathieu-Daudé
On 7/9/20 10:17 PM, Laurent Vivier wrote: > Le 09/07/2020 à 19:19, Alistair Francis a écrit : >> On Wed, Jul 8, 2020 at 5:43 AM Laurent Vivier wrote: >>> >>> Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit : Document the 'memory_size' argument of register_init_block(). Fixes:

Re: [PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation

2020-07-10 Thread Philippe Mathieu-Daudé
Corey, this series is now fully reviewed :) On 7/6/20 12:41 AM, Philippe Mathieu-Daudé wrote: > In commit d88c42ff2c we added 2 methods: i2c_try_create_slave() > and i2c_realize_and_unref(). > Markus noted their name could be improved for consistency [1], > and Peter reported the lack of documenta

Re: [PULL 18/31] block/core: add generic infrastructure for x-blockdev-amend qmp command

2020-07-10 Thread Max Reitz
On 09.07.20 17:09, Peter Maydell wrote: > On Mon, 6 Jul 2020 at 11:05, Max Reitz wrote: >> >> From: Maxim Levitsky >> >> blockdev-amend will be used similiar to blockdev-create >> to allow on the fly changes of the structure of the format based block >> devices. >> >> Current plan is to first su

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-10 Thread Peter Maydell
On Thu, 9 Jul 2020 at 17:27, Alistair Francis wrote: > > On Thu, Jul 9, 2020 at 7:35 AM Philippe Mathieu-Daudé wrote: > > > > On 7/9/20 4:15 PM, Peter Maydell wrote: > > > The only chance you have of something that's actually > > > generic would probably involve "qemu-img resize". But I'm a bit >

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-10 Thread Kevin Wolf
Am 09.07.2020 um 16:15 hat Peter Maydell geschrieben: > On Thu, 9 Jul 2020 at 14:56, Philippe Mathieu-Daudé wrote: > > > > On 7/7/20 10:29 PM, Niek Linnenbank wrote: > > > So I manually copy & pasted the change into hw/sd/sd.c to test it. > > > It looks like the check works, but my concern is tha

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 10:58, Kevin Wolf wrote: > > Am 09.07.2020 um 16:15 hat Peter Maydell geschrieben: > > dd/truncate etc won't work if the image file is not raw (eg if > > it's qcow2). The only chance you have of something that's actually > > generic would probably involve "qemu-img resize".

Re: [PATCH v3 11/11] hw/arm/smmuv3: Advertise SMMUv3.2 range invalidation

2020-07-10 Thread Auger Eric
Hi Peter, On 7/10/20 11:47 AM, Peter Maydell wrote: > On Wed, 8 Jul 2020 at 15:20, Eric Auger wrote: >> >> Expose the RIL bit so that the guest driver uses range >> invalidation. Range invalidation being an SMMU3.2 feature, >> let AIDR advertise SMMUv3.2 support. >> >> Signed-off-by: Eric Auger

Re: [RFC PATCH 0/2] hw/sd: Deprecate the SPI mode and the SPI to SD adapter

2020-07-10 Thread Philippe Mathieu-Daudé
On 7/10/20 11:27 AM, Bin Meng wrote: > Hi Philippe, > > On Mon, Jul 6, 2020 at 6:07 AM Philippe Mathieu-Daudé wrote: >> >> I tried to maintain the SPI mode because it is useful in >> tiny embedded devices, and thought it would be helpful for >> the AVR MCUs. >> As AVR was blocked, I thought it wa

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#3] QEMU 5.0 and 5.1-pre-soft-freeze Dissect Comparison

2020-07-10 Thread Alex Bennée
Ahmed Karaman writes: > On Thu, Jul 9, 2020 at 4:41 PM Alex Bennée wrote: >> >> >> Ahmed Karaman writes: >> >> > Hi, >> > >> > The third report of the TCG Continuous Benchmarking series utilizes >> > the tools presented in the previous report for comparing the >> > performance of 17 different

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#3] QEMU 5.0 and 5.1-pre-soft-freeze Dissect Comparison

2020-07-10 Thread Philippe Mathieu-Daudé
On 7/10/20 11:20 AM, Ahmed Karaman wrote: > On Thu, Jul 9, 2020 at 4:41 PM Alex Bennée wrote: >> >> If you identify a drop in performance due to a commit linking to it from >> the report wouldn't be a bad idea so those that want to quickly >> replicate the test can do before/after runs. >> > > Re

Re: [PULL 0/1] Tracing patches

2020-07-10 Thread Peter Maydell
On Tue, 7 Jul 2020 at 16:20, Stefan Hajnoczi wrote: > > The following changes since commit 7623b5ba017f61de5d7c2bba12c6feb3d55091b1: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging > (2020-07-06 11:40:10 +0100) > > are available in the Git

Re: [PATCH v2] vhost-vdpa :Fix Coverity CID 1430270 / CID 1420267

2020-07-10 Thread Li Qiang
Cindy Lu 于2020年7月10日周五 下午2:47写道: > > In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialized > all its fields. > > Signed-off-by: Cindy Lu Reviewed-by: Li Qiang > --- > hw/virtio/vhost-vdpa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw

Re: [Bug 1886362] [NEW] Heap use-after-free in lduw_he_p through e1000e_write_to_rx_buffers

2020-07-10 Thread Li Qiang
Paolo Bonzini 于2020年7月10日周五 上午1:36写道: > > On 09/07/20 17:51, Li Qiang wrote: > > Maybe we should check whether the address is a RAM address in > > 'dma_memory_rw'? > > But it is a hot path. I'm not sure it is right. Hope more discussion. > > Half of the purpose of dma-helpers.c (as opposed to add

Re: [PATCH v3 11/11] hw/arm/smmuv3: Advertise SMMUv3.2 range invalidation

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 11:05, Auger Eric wrote: > On 7/10/20 11:47 AM, Peter Maydell wrote: > > I think that to advertise SMMUv3.2 we would also need to > > set the IDR3.BBML field to something non-zero. That means > > we need to analyze our implementation of the caching of page > > table structur

Re: [PULL 0/3] MIPS + TCG Continuous Benchmarking queue for July 7th, 2020

2020-07-10 Thread Peter Maydell
On Tue, 7 Jul 2020 at 22:58, Aleksandar Markovic wrote: > Peter, please discard this pull request, I will send a new one, as soon as I > can, most likely tomorrow, that will fully follow Paolo's and Thomas' > recommendations, no need to worry. Thanks. As Paolo says, on the technical aspects of

Re: [PATCH] docs/system/s390x: Improve the 3270 documentation

2020-07-10 Thread Cornelia Huck
On Thu, 9 Jul 2020 18:04:39 +0200 Thomas Huth wrote: > There is some additional information about the 3270 support in our > Wiki at https://wiki.qemu.org/Features/3270 - so let's include this > information into the main documentation now to have one single > source of information (the Wiki page

Re: [PATCH] hw/net/xgmac: Fix buffer overflow in xgmac_enet_send()

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 10:20, Mauro Matteo Cascella wrote: > > A buffer overflow issue was reported by Mr. Ziming Zhang, CC'd here. It > occurs while sending an Ethernet frame due to missing break statements > and improper checking of the buffer size. > > Reported-by: Ziming Zhang > Signed-off-by

Re: [PATCH] hw/net/ftgmac100: Fix integer overflow in ftgmac100_do_tx()

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 09:56, Mauro Matteo Cascella wrote: > > An integer overflow issue was reported by Mr. Ziming Zhang, CC'd here. It > occurs while inserting the VLAN tag in packets whose length is less than > 12 bytes, as (len-12) is passed to memmove() without proper checking. > This patch i

Re: [PATCH] 9p: null terminate fs driver options list

2020-07-10 Thread Greg Kurz
On Thu, 9 Jul 2020 23:28:48 +0530 P J P wrote: > From: Prasad J Pandit > > NULL terminate fs driver options' list, validate_opt() looks for > a null entry to terminate the loop. > Good catch ! And this never bit us before because opt ends up pointing to some valid memory containing zeroes...

QEMU | Pipeline #165193477 has failed for master | b6d7e9b6

2020-07-10 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: b6d7e9b6 ( https://gitlab.com/qemu-project/qemu/-/commit/b6d7e9b66f59ca6ebc6e9b830cd5e7bf849d31cf ) Commit Message: Merge remote-tr

Re: [PULL 00/32] AVR port

2020-07-10 Thread Peter Maydell
On Tue, 7 Jul 2020 at 19:19, Philippe Mathieu-Daudé wrote: > > Possible false-positives from checkpatch: > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > > The following changes since commit 7623b5ba017f61de5d7c2bba12c6feb3d55091b1: > > Merge remote-tracking bran

Re: [PATCH] docs/system/s390x: Improve the 3270 documentation

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 11:56, Cornelia Huck wrote: > > On Thu, 9 Jul 2020 18:04:39 +0200 > Thomas Huth wrote: > > > There is some additional information about the 3270 support in our > > Wiki at https://wiki.qemu.org/Features/3270 - so let's include this > > information into the main documentati

Re: Separate notifications from list messages?

2020-07-10 Thread Thomas Huth
On 10/07/2020 11.24, Liviu Ionescu wrote: > > >> On 10 Jul 2020, at 11:54, Daniel P. Berrangé wrote: >> >> This wasn't a mistake - it was very delibrate, precisely so that all >> involved in QEMU development will see the failures, instead of expecting >> a handful of people to take all the work

[Bug 1886793] Re: "go install" command fails while running inside s390x docker container on x86_64 host using qemu

2020-07-10 Thread Nirman Narang
Cloned qemu source code, checked out latest tag v5.0.0, built and installed the same on x86 Ubuntu host using "make" and "make install". root:~# qemu-s390x --version qemu-s390x version 5.0.0 (v5.0.0-dirty) Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers root:~# wget -q h

Re: Separate notifications from list messages?

2020-07-10 Thread Liviu Ionescu
> On 10 Jul 2020, at 14:43, Thomas Huth wrote: > > ... The Gitlab messages that you > can see currently on the list are from the main repository, not from a > contributor's private repo! I don't know why we should worry about contributor's private repos, but anyway, the GitLab workflow seems

Re: [RFC 60/65] softfloat: add fp16 and uint8/int8 interconvert functions

2020-07-10 Thread Alex Bennée
frank.ch...@sifive.com writes: > From: Frank Chang > > Signed-off-by: Frank Chang Did I miss the rest of the series somewhere? Otherwise this looks fine to me: Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-10 Thread Kevin Wolf
Am 10.07.2020 um 11:59 hat Peter Maydell geschrieben: > On Fri, 10 Jul 2020 at 10:58, Kevin Wolf wrote: > > > > Am 09.07.2020 um 16:15 hat Peter Maydell geschrieben: > > > dd/truncate etc won't work if the image file is not raw (eg if > > > it's qcow2). The only chance you have of something that's

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-10 Thread David Hildenbrand
On 10.07.20 11:17, David Hildenbrand wrote: > On 09.07.20 20:15, David Hildenbrand wrote: >> On 09.07.20 12:52, Christian Borntraeger wrote: >>> >>> On 08.07.20 20:51, David Hildenbrand wrote: Let's implement the "storage configuration" part of diag260. This diag is found under z/VM, to i

Re: [PATCH v2 2/3] virtio-balloon: Add locking to prevent possible race when starting hinting

2020-07-10 Thread David Hildenbrand
On 06.07.20 23:14, Alexander Duyck wrote: > From: Alexander Duyck > > There is already locking in place when we are stopping free page hinting > but there is not similar protections in place when we start. I can only > assume this was overlooked as in most cases the page hinting should not be > o

Re: [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze

2020-07-10 Thread Peter Maydell
On Wed, 8 Jul 2020 at 22:32, Paolo Bonzini wrote: > > The following changes since commit eb2c66b10efd2b914b56b20ae90655914310c925: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-07-06' > into staging (2020-07-07 19:47:26 +0100) > > are available in the Git repository at

Re: [RFC 62/65] fpu: add api to handle alternative sNaN propagation

2020-07-10 Thread Alex Bennée
frank.ch...@sifive.com writes: > From: Chih-Min Chao > > Signed-off-by: Chih-Min Chao > Signed-off-by: Frank Chang > --- > fpu/softfloat.c | 68 + > include/fpu/softfloat.h | 6 > 2 files changed, 48 insertions(+), 26 deletions(-) > > dif

[PATCH for-5.1] qemu-img resize: Require --shrink for shrinking all image formats

2020-07-10 Thread Kevin Wolf
QEMU 2.11 introduced the --shrink option for qemu-img resize to avoid accidentally shrinking images (commit 4ffca8904a3). However, for compatibility reasons, it was not enforced for raw images yet, but only a deprecation warning was printed. This warning has existed for long enough that we can now

Re: [RFC 63/65] fpu: implement full set compare for fp16

2020-07-10 Thread Alex Bennée
frank.ch...@sifive.com writes: > From: Kito Cheng > > Signed-off-by: Kito Cheng > Signed-off-by: Chih-Min Chao > Signed-off-by: Frank Chang NACK I'm afraid. What's wrong with the exiting float_compare support? Even if you did want to bring in aliases for these functions within softfloat it

Re: [PATCH for-5.1] qemu-img resize: Require --shrink for shrinking all image formats

2020-07-10 Thread Daniel P . Berrangé
On Fri, Jul 10, 2020 at 02:17:17PM +0200, Kevin Wolf wrote: > QEMU 2.11 introduced the --shrink option for qemu-img resize to avoid > accidentally shrinking images (commit 4ffca8904a3). However, for > compatibility reasons, it was not enforced for raw images yet, but only > a deprecation warning wa

Re: [RFC 63/65] fpu: implement full set compare for fp16

2020-07-10 Thread Alex Bennée
Alex Bennée writes: > frank.ch...@sifive.com writes: > >> From: Kito Cheng >> >> Signed-off-by: Kito Cheng >> Signed-off-by: Chih-Min Chao >> Signed-off-by: Frank Chang > > NACK I'm afraid. What's wrong with the exiting float_compare support? > > Even if you did want to bring in aliases for

Re: [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 13:14, Peter Maydell wrote: > > On Wed, 8 Jul 2020 at 22:32, Paolo Bonzini wrote: > > > > The following changes since commit eb2c66b10efd2b914b56b20ae90655914310c925: > > > > Merge remote-tracking branch > > 'remotes/maxreitz/tags/pull-block-2020-07-06' into staging (202

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 13:07, Kevin Wolf wrote: > > Am 10.07.2020 um 11:59 hat Peter Maydell geschrieben: > > On Fri, 10 Jul 2020 at 10:58, Kevin Wolf wrote: > > > > > > Am 09.07.2020 um 16:15 hat Peter Maydell geschrieben: > > > > dd/truncate etc won't work if the image file is not raw (eg if >

[Bug 1886793] Re: "go install" command fails while running inside s390x docker container on x86_64 host using qemu

2020-07-10 Thread Laurent Vivier
If you install go directly in your host system you must also install the libraries of s390x somewhere (except if it statically linked). The easiest way to test this is to install debian chroot, with something like: Check binftm_misc is configured: # cat /proc/sys/fs/binfmt_misc/qemu-s390x enabl

Re: [PATCH for-5.1] qemu-img resize: Require --shrink for shrinking all image formats

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 13:17, Kevin Wolf wrote: > > QEMU 2.11 introduced the --shrink option for qemu-img resize to avoid > accidentally shrinking images (commit 4ffca8904a3). However, for > compatibility reasons, it was not enforced for raw images yet, but only > a deprecation warning was printed

Re: [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze

2020-07-10 Thread Claudio Fontana
On 7/10/20 2:14 PM, Peter Maydell wrote: > On Wed, 8 Jul 2020 at 22:32, Paolo Bonzini wrote: >> >> The following changes since commit eb2c66b10efd2b914b56b20ae90655914310c925: >> >> Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-07-06' >> into staging (2020-07-07 19:47:26 +

Re: [PATCH for-5.1] qemu-img resize: Require --shrink for shrinking all image formats

2020-07-10 Thread Kevin Wolf
Am 10.07.2020 um 14:33 hat Peter Maydell geschrieben: > On Fri, 10 Jul 2020 at 13:17, Kevin Wolf wrote: > > > > QEMU 2.11 introduced the --shrink option for qemu-img resize to avoid > > accidentally shrinking images (commit 4ffca8904a3). However, for > > compatibility reasons, it was not enforced

Re: [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze

2020-07-10 Thread Peter Maydell
On Fri, 10 Jul 2020 at 13:38, Claudio Fontana wrote: > I got regular green test reports from cirrus-ci for Mac, seems different > compilation options. That's odd -- what is cirrus-ci doing differently? Building the cocoa UI frontend is the default and is definitely something we want to be testin

Re: [RFC 60/65] softfloat: add fp16 and uint8/int8 interconvert functions

2020-07-10 Thread Alex Bennée
Frank Chang writes: > On Fri, Jul 10, 2020 at 8:07 PM Alex Bennée wrote: > >> >> frank.ch...@sifive.com writes: >> >> > From: Frank Chang >> > >> > Signed-off-by: Frank Chang >> >> Did I miss the rest of the series somewhere? >> >> Otherwise this looks fine to me: >> >> Reviewed-by: Alex Ben

Re: [PULL 00/53] Error reporting patches patches for 2020-07-07

2020-07-10 Thread Markus Armbruster
This now conflicts with master (b6d7e9b66f5). Conflict #1: include/hw/audio/pcspk.h 2336172d9b "audio: set default value for pcspk.iobase property" 2336172d9b audio: set default value for pcspk.iobase property diff --git a/include/hw/audio/pcspk.h b/include/hw/audio/pcspk.h index

Re: [PATCH v3 1/2] linux-user: refactor ipc syscall

2020-07-10 Thread Laurent Vivier
Le 26/06/2020 à 14:46, Matus Kysel a écrit : > Refactoring ipc syscall for s390x and SPARC, so it matches glibc > implementation > > Signed-off-by: Matus Kysel > --- > linux-user/syscall.c | 26 +- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/linux

Re: [PATCH v3 2/2] linux-user: support of semtimedop syscall

2020-07-10 Thread Laurent Vivier
Le 26/06/2020 à 14:46, Matus Kysel a écrit : > We should add support of semtimedop syscall as new version of glibc > 2.31 uses semop based on semtimedop > (commit: > https://gitlab.com/freedesktop-sdk/mirrors/sourceware/glibc/-/commit/765cdd0bffd77960ae852104fc4ea5edcdb8aed3 > ). > > Signed-off-

Re: [PATCH v2] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch

2020-07-10 Thread Stefan Hajnoczi
On Fri, Jul 10, 2020 at 06:55:15AM +0200, Thomas Huth wrote: > GCC supports "#pragma GCC diagnostic" since version 4.6, and > Clang seems to support it, too, since its early versions 3.x. > That means that our minimum required compiler versions all support > this pragma already and we can remove th

  1   2   3   4   >