Re: [PATCH v2 2/4] cirrus.yml: Compile FreeBSD with -Werror

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 09:44:03AM +0200, Thomas Huth wrote: > Compiler warnings currently go unnoticed in our FreeBSD builds, since > -Werror is only enabled for Linux and MinGW builds by default. So let's > enable them here now, too. > > Reviewed-by: Ed Maste > Signed-off-by: Thomas Huth >

Re: [PATCH v2 3/4] cirrus.yml: Compile macOS with -Werror

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 09:44:04AM +0200, Thomas Huth wrote: > Compiler warnings currently go unnoticed in our macOS builds, since -Werror > is only enabled for Linux and MinGW builds by default. So let's enable them > here now, too. > Unfortunately, the sasl header is marked as deprecated in the

[PATCH for-5.1 0/2] block: Fix bdrv_aligned_p*v() for qiov_offset != 0

2020-07-28 Thread Max Reitz
Hi, Patch 1 is the fix, patch 2 adds a test. I think we must get this into 5.1, rc2 or not. Max Reitz (2): block: Fix bdrv_aligned_p*v() for qiov_offset != 0 iotests/028: Add test for cross-base-EOF reads block/io.c | 10 ++ tests/qemu-iotests/028 | 19

[PATCH for-5.1 2/2] iotests/028: Add test for cross-base-EOF reads

2020-07-28 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/028 | 19 +++ tests/qemu-iotests/028.out | 11 +++ 2 files changed, 30 insertions(+) diff --git a/tests/qemu-iotests/028 b/tests/qemu-iotests/028 index 5d043cef92..6dd3ae09a3 100755 --- a/tests/qemu-iotests/028 +++

[PATCH for-5.1 1/2] block: Fix bdrv_aligned_p*v() for qiov_offset != 0

2020-07-28 Thread Max Reitz
Since these functions take a @qiov_offset, they must always take it into account when working with @qiov. There are a couple of places where they do not, but they should. Fixes: 65cd4424b9df03bb5195351c33e04cbbecc0705c Fixes: 28c4da28695bdbe04b336b2c9c463876cc3aaa6d Reported-by: Claudio Fontana

Re: [PATCH for-5.1? 0/3] Fix AIRCR.SYSRESETREQ for most M-profile boards

2020-07-28 Thread Philippe Mathieu-Daudé
On 7/28/20 12:37 PM, Peter Maydell wrote: > QEMU's NVIC device provides an outbound qemu_irq "SYSRESETREQ" which > it signals when the guest sets the SYSRESETREQ bit in the AIRCR > register. This matches the hardware design (where the CPU has a > signal of this name and it is up to the SoC to

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-28 Thread Claudio Fontana
On 7/28/20 1:10 PM, Max Reitz wrote: > On 28.07.20 01:09, Bruce Rogers wrote: >> On Tue, 2020-07-21 at 10:22 +0200, Claudio Fontana wrote: >>> On 7/20/20 8:24 PM, Claudio Fontana wrote: I have now been able to reproduce this on X86 as well. It happens much more rarely, about once

Re: [PATCH v2 1/4] block: nbd: Fix convert qcow2 compressed to nbd

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2020 00:58, Nir Soffer wrote: When converting to qcow2 compressed format, the last step is a special zero length compressed write, ending in call to bdrv_co_truncate(). This call always fails for the nbd driver since it does not implement bdrv_co_truncate(). For block devices, which have

Re: [PATCH v11 10/11] qcow2_format.py: introduce Qcow2HeaderExtensionsDoc class

2020-07-28 Thread Andrey Shinkevich
On 28.07.2020 14:36, Vladimir Sementsov-Ogievskiy wrote: 17.07.2020 11:14, Andrey Shinkevich wrote: Per original script design, QcowHeader class may dump the QCOW2 header info separately from the QCOW2 extensions info. To implement the to_dict() method for dumping extensions, let us introduce

Re: [PATCH for-5.1 1/2] block: Fix bdrv_aligned_p*v() for qiov_offset != 0

2020-07-28 Thread Bruce Rogers
On Tue, 2020-07-28 at 14:08 +0200, Max Reitz wrote: > Since these functions take a @qiov_offset, they must always take it > into > account when working with @qiov. There are a couple of places where > they do not, but they should. > > Fixes: 65cd4424b9df03bb5195351c33e04cbbecc0705c > Fixes:

Re: [PULL 08/16] linux-user: don't use MAP_FIXED in pgd_find_hole_fallback

2020-07-28 Thread Peter Maydell
On Mon, 27 Jul 2020 at 13:24, Alex Bennée wrote: > > Plain MAP_FIXED has the undesirable behaviour of splatting exiting > maps so we don't actually achieve what we want when looking for gaps. > We should be using MAP_FIXED_NOREPLACE. As this isn't always available > we need to potentially check

Re: [RFC 0/2] virtio-rng: add a control queue

2020-07-28 Thread Laurent Vivier
On 29/01/2020 16:43, Stefan Hajnoczi wrote: > On Fri, Jan 24, 2020 at 03:05:18PM +0100, Laurent Vivier wrote: >> On 24/01/2020 12:02, Stefan Hajnoczi wrote: >>> On Thu, Jan 23, 2020 at 04:16:58PM +0100, Laurent Vivier wrote: The kernel needs sometime to be able to cancel an ongoing command.

[PATCH v1 0/2] clean-ups for sleep=off behaviour

2020-07-28 Thread Alex Bennée
Hi, These fixes are more band-aids than anything else but they at least improve on the original situation where running a zephyr build with: -icount shift=6,align=off,sleep=off would lock the monitor hard as time rushed into the future. With these patches time still runs to the future pretty

[Bug 1888467] Re: qemu-img http convert bug

2020-07-28 Thread Max Reitz
Because nobody has implemented it so far. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888467 Title: qemu-img http convert bug Status in QEMU: New Bug description: Hello, Why the file

[PATCH for-5.2 v4 01/11] hw/arm/smmu-common: Factorize some code in smmu_ptw_64()

2020-07-28 Thread Eric Auger
Page and block PTE decoding can share some code. Let's first handle table PTE and factorize some code shared by page and block PTEs. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell --- v1 -> v2: - restore goto error in case get_pte() fails --- hw/arm/smmu-common.c | 48

[PULL 8/9] block/nbd: on shutdown terminate connection attempt

2020-07-28 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy On shutdown nbd driver may be in a connecting state. We should shutdown it as well, otherwise we may hang in nbd_teardown_connection, waiting for conneciton_co to finish in BDRV_POLL_WHILE(bs, s->connection_co) loop if remote server is down. How to reproduce

[PULL 5/9] iotests: Test convert to qcow2 compressed to NBD

2020-07-28 Thread Eric Blake
From: Nir Soffer Add test for "qemu-img convert -O qcow2 -c" to NBD target. The tests     create a OVA file and write compressed qcow2 disk content directly into the OVA file via qemu-nbd. Signed-off-by: Nir Soffer Message-Id: <20200727215846.395443-5-nsof...@redhat.com> Tested-by: Eric Blake

Re: [PATCH v7 3/6] 9pfs: add new function v9fs_co_readdir_many()

2020-07-28 Thread Christian Schoenebeck
On Dienstag, 28. Juli 2020 10:46:00 CEST Greg Kurz wrote: > > So I'll prepare a v8 with this patch here split into two. > > > > But this is it. I don't see another chunk in this patch set that could be > > split further down in an useful way. > > > > Best regards, > > Christian Schoenebeck > >

Re: [PATCH v11 07/11] qcow2_format.py: Dump bitmap table serialized entries

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 11:14, Andrey Shinkevich wrote: Add bitmap table information to the QCOW2 metadata dump. Bitmap name bitmap-1 ... Bitmap table typeoffset size 0 serialized 4718592 65536 1 serialized

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 08:43:29AM +0200, Thomas Huth wrote: > On 27/07/2020 12.57, Daniel P. Berrangé wrote: > > On Fri, Jul 24, 2020 at 05:50:47PM +0100, Peter Maydell wrote: > >> On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé > >> wrote: > >>> I guess we were expecting the distrib to

Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200728100925.10454-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH] Makefile: Compute libraries for libqemuutil.a and libvhost-user.a

2020-07-28 Thread Stefan Hajnoczi
On Thu, Jul 02, 2020 at 04:06:32PM +0300, Michael Tokarev wrote: > 01.07.2020 12:12, Christophe de Dinechin wrote: > .. > >>> # Build libraries > >>> > >>> +libqemuutil.a-libs += $(call extract-libs, $(util-obj-y) $(trace-obj-y) > >>> $(stub-obj-y)) > >>> +libvhost-user.a-libs += $(call

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 11:00, Philippe Mathieu-Daudé wrote: > Apparently kvm_enabled() checks CONFIG_KVM_IS_POSSIBLE instead > of CONFIG_KVM, I suppose to bypass this limitation (from osdep.h): > > 21 #ifdef NEED_CPU_H > 22 # ifdef CONFIG_KVM > 24 # define CONFIG_KVM_IS_POSSIBLE > 25 # endif

[PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-28 Thread Aleksandar Markovic
On Thursday, July 16, 2020, Ahmed Karaman wrote: > Python script that prints executed helpers of a QEMU invocation. > > Hi, Ahmed. You outlined the envisioned user workflow regarding this script in your report. As I understand it, it generally goes like this: 1) The user first discovers

Re: [PATCH] virtio-ccw-input: fix description

2020-07-28 Thread Thomas Huth
On 28/07/2020 12.28, Cornelia Huck wrote: > Fix a copy/paste error. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/virtio-ccw-input.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/virtio-ccw-input.c b/hw/s390x/virtio-ccw-input.c > index

Re: [PATCH v5 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-07-28 Thread Stefan Hajnoczi
On Tue, Jun 23, 2020 at 04:42:30PM +0200, Lukas Straub wrote: > In many cases, if qemu has a network connection (qmp, migration, chardev, > etc.) > to some other server and that server dies or hangs, qemu hangs too. > These patches introduce the new 'yank' out-of-band qmp command to recover from

Re: [PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-28 Thread Aleksandar Markovic
On Tuesday, July 28, 2020, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> wrote: > > > On Tuesday, July 28, 2020, Aleksandar Markovic < > aleksandar.qemu.de...@gmail.com> wrote: > >> >> >> On Thursday, July 16, 2020, Ahmed Karaman >> wrote: >> >>> Python script that prints executed

Re: [RFC v2 2/3] libvhost-user: handle endianness as mandated by the spec

2020-07-28 Thread Marc Hartmayer
On Tue, Jul 21, 2020 at 06:44 PM +0200, Halil Pasic wrote: > On Tue, 21 Jul 2020 09:40:10 -0400 > "Michael S. Tsirkin" wrote: > >> On Fri, Jul 17, 2020 at 11:29:28AM +0200, Marc Hartmayer wrote: >> > Since virtio existed even before it got standardized, the virtio >> > standard defines the

[Bug 1888923] Re: Configured Memory access latency and bandwidth not taking effect

2020-07-28 Thread Vishnu Dixit
It indeed was a non NUMA machine -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888923 Title: Configured Memory access latency and bandwidth not taking effect Status in QEMU: Invalid Bug

Re: Qemu installation error from source

2020-07-28 Thread Asmita Jha
Thanks for the information. Yes this helps. Regards Asmita On Tue, Jul 28, 2020, 4:07 PM Stefan Hajnoczi wrote: > On Wed, Jul 01, 2020 at 06:04:33AM +0530, Asmita Jha wrote: > > Thanks for your response. I am not sure I compiled libbz2. > > Because while installing qemu from source , I just

Re: [PATCH v5 4/7] migration: Add yank feature

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 04:42:52PM +0200, Lukas Straub wrote: > Register yank functions on sockets to shut them down. > > Signed-off-by: Lukas Straub > --- > migration/channel.c | 12 > migration/migration.c | 18 +- > migration/multifd.c

RE: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread Paul Durrant
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: 28 July 2020 11:09 > To: qemu-devel@nongnu.org > Cc: Paul Durrant ; Paolo Bonzini ; > xen-de...@lists.xenproject.org; > Stefano Stabellini ; Anthony Perard > ; Philippe > Mathieu-Daudé ; Paul Durrant ; Peter > Maydell > >

Re: [PATCH v11 10/11] qcow2_format.py: introduce Qcow2HeaderExtensionsDoc class

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 11:14, Andrey Shinkevich wrote: Per original script design, QcowHeader class may dump the QCOW2 header info separately from the QCOW2 extensions info. To implement the to_dict() method for dumping extensions, let us introduce the class Qcow2HeaderExtensionsDoc. I think, when dumping

Re: [PATCH for-5.1 1/2] block: Fix bdrv_aligned_p*v() for qiov_offset != 0

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2020 15:08, Max Reitz wrote: Since these functions take a @qiov_offset, they must always take it into account when working with @qiov. There are a couple of places where they do not, but they should. Fixes: 65cd4424b9df03bb5195351c33e04cbbecc0705c Fixes:

Re: [PATCH] qemu-options.hx: Fix typo for netdev documentation

2020-07-28 Thread Tianjia Zhang
On 2020/7/27 17:44, Michael S. Tsirkin wrote: On Mon, Jul 27, 2020 at 12:59:25PM +0800, Tianjia Zhang wrote: This patch fixes the netdev document description typo in qemu-option.hx. Signed-off-by: Tianjia Zhang Reviewed-by: Michael S. Tsirkin Trivial tree? Jason's ? It's for

[PATCH v2] iotests/197: Fix for non-qcow2 formats

2020-07-28 Thread Max Reitz
While 197 is very much a qcow2 test, and it looks like the partial cluster case at the end (introduced in b0ddcbbb36a66a6) is specifically a qcow2 case, the whole test scripts actually marks itself to work with generic formats (and generic protocols, even). Said partial cluster case happened to

[PATCH v5 for-5.2] spapr: Use error_append_hint() in spapr_caps.c

2020-07-28 Thread Greg Kurz
We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. While here, have cap_fwnmi_apply(), which already uses error_append_hint(), to call ERRP_GUARD() as well. Signed-off-by: Greg Kurz Reviewed-by:

Re: [RFC PATCH] s390x/pci: vfio-pci breakage with disabled mem enforcement

2020-07-28 Thread Niklas Schnelle
On 7/28/20 2:52 PM, Alex Williamson wrote: > On Tue, 28 Jul 2020 11:33:55 +0200 > Niklas Schnelle wrote: > >> On 7/27/20 6:47 PM, Alex Williamson wrote: >>> On Mon, 27 Jul 2020 17:40:39 +0200 >>> Pierre Morel wrote: >>> On 2020-07-23 18:29, Alex Williamson wrote: > On Thu, 23

Re: [PATCH] hw: add compat machines for 5.2

2020-07-28 Thread Greg Kurz
On Tue, 28 Jul 2020 11:46:45 +0200 Cornelia Huck wrote: > Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. > Heh, you win the race for adding new machine types again :) > Signed-off-by: Cornelia Huck > --- > hw/arm/virt.c | 9 - > hw/core/machine.c | 3

Re: [PATCH v2 0/2] QEMU Gating CI

2020-07-28 Thread Peter Maydell
On Mon, 20 Jul 2020 at 18:22, Cleber Rosa wrote: > Sure. It's important that PATCH 2/2 in this series is included in a > branch that you need to push to the "staging" branch on the > https://gitlab.com/qemu-project/qemu repo (it could be just that one > patch). Then, you can run: > >

Re: [PATCH v2 4/4] iotests: Test convert to qcow2 compressed to NBD

2020-07-28 Thread Eric Blake
On 7/27/20 4:58 PM, Nir Soffer wrote: Add test for "qemu-img convert -O qcow2 -c" to NBD target. The tests create a OVA file and write compressed qcow2 disk content directly into the OVA file via qemu-nbd. Signed-off-by: Nir Soffer --- tests/qemu-iotests/302 | 127

[PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Paul Durrant
From: Paul Durrant The recent commit da278d58a092 "accel: Move Xen accelerator code under accel/xen/" introduced a subtle semantic change, making xen_enabled() always return false unless CONFIG_XEN is defined prior to inclusion of sysemu/xen.h, which appears to be the normal case. This causes

Re: [PATCH v11 03/11] qcow2_format.py: change Qcow2BitmapExt initialization method

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 11:14, Andrey Shinkevich wrote: There are two ways to initialize a class derived from Qcow2Struct: 1. Pass a block of binary data to the constructor. 2. Pass the file descriptor to allow reading the file from constructor. Let's change the Qcow2BitmapExt initialization method from 1 to

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Philippe Mathieu-Daudé
On 7/28/20 11:27 AM, Peter Maydell wrote: > On Tue, 28 Jul 2020 at 10:19, Paul Durrant wrote: >> >> From: Paul Durrant >> >> The recent commit da278d58a092 "accel: Move Xen accelerator code under >> accel/xen/" introduced a subtle semantic change, making xen_enabled() always >> return false

Re: [PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

2020-07-28 Thread David Gibson
On Tue, Jul 28, 2020 at 11:07:26AM +0200, Greg Kurz wrote: > On Tue, 28 Jul 2020 09:26:08 +0200 > Markus Armbruster wrote: > > > Greg Kurz writes: > > > > > On Mon, 20 Jul 2020 17:24:35 +0200 > > > Markus Armbruster wrote: > > > > > >> Greg Kurz writes: > > >> > > >> > We have a dedicated

[PATCH for-5.1? 3/3] msf2-soc, stellaris: Don't wire up SYSRESETREQ

2020-07-28 Thread Peter Maydell
The MSF2 SoC model and the Stellaris board code both wire SYSRESETREQ up to a function that just invokes qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET); This is now the default action that the NVIC does if the line is not connected, so we can delete the handling code. Signed-off-by:

[PATCH for-5.1? 0/3] Fix AIRCR.SYSRESETREQ for most M-profile boards

2020-07-28 Thread Peter Maydell
QEMU's NVIC device provides an outbound qemu_irq "SYSRESETREQ" which it signals when the guest sets the SYSRESETREQ bit in the AIRCR register. This matches the hardware design (where the CPU has a signal of this name and it is up to the SoC to connect that up to an actual reset mechanism), but in

Re: Qemu installation error from source

2020-07-28 Thread Stefan Hajnoczi
On Wed, Jul 01, 2020 at 06:04:33AM +0530, Asmita Jha wrote: > Thanks for your response. I am not sure I compiled libbz2. > Because while installing qemu from source , I just followed the steps as > mentioned in wiki. > I am noob in this field. > > I tried using ./configure --static, it gave an

Re: [PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-28 Thread Aleksandar Markovic
On Tuesday, July 28, 2020, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> wrote: > > > On Thursday, July 16, 2020, Ahmed Karaman > wrote: > >> Python script that prints executed helpers of a QEMU invocation. >> >> > Hi, Ahmed. > > You outlined the envisioned user workflow regarding this

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-28 Thread Paolo Bonzini
On 28/07/20 13:33, Vladimir Sementsov-Ogievskiy wrote: >> Thanks for both your investigation.  Does the attached patch help? > > For me, the reproducer is fixed with your patch. Is it possible to make a quick testcase using qemu-io? Paolo

Re: [PATCH v5 3/7] chardev/char-socket.c: Add yank feature

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 04:42:48PM +0200, Lukas Straub wrote: > Register a yank function to shutdown the socket on yank. > > Signed-off-by: Lukas Straub > --- > chardev/char-socket.c | 24 > 1 file changed, 24 insertions(+) Reviewed-by: Daniel P. Berrangé Regards,

Re: [PATCH v5 2/7] block/nbd.c: Add yank feature

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 04:42:45PM +0200, Lukas Straub wrote: > Register a yank function which shuts down the socket and sets > s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an > error occured. > > Signed-off-by: Lukas Straub > --- > block/nbd.c | 101

Re: [PATCH v5 7/7] MAINTAINERS: Add myself as maintainer for yank feature

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 04:43:13PM +0200, Lukas Straub wrote: > I'll maintain this for now as the colo usecase is the first user > of this functionality. > > Signed-off-by: Lukas Straub > --- > MAINTAINERS | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/MAINTAINERS

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-28 Thread Paolo Bonzini
On 28/07/20 13:45, Max Reitz wrote: >> Is it possible to make a quick testcase using qemu-io? > This seems to work: > > $ qemu-img create -f qcow2 -o cluster_size=512 base.qcow2 512 > $ qemu-img create -f qcow2 -o cluster_size=512 -F qcow2 -b base.qcow2 \ > top.qcow2 1024 > $ qemu-io -c 'write

qemu icount to run guest SMP code

2020-07-28 Thread Wu, Wentong
Hi, We are trying to run guest SMP code with qemu icount mode, but based on my current understanding I don't think we can do that, because with icount enabled, the multi cpus will be simulated in round-robin way(tcg kick vcpu timer, or current cpu exit in order to handle interrupt or the ending

Re: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-07-28 Thread Vivek Goyal
On Tue, Jul 28, 2020 at 12:00:20PM +0200, Roman Mohr wrote: > On Tue, Jul 28, 2020 at 3:07 AM misono.tomoh...@fujitsu.com < > misono.tomoh...@fujitsu.com> wrote: > > > > Subject: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an > > error > > > > > > An assertion failure is raised

Re: [PATCH v2 3/4] iotests: Add more qemu_img helpers

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2020 00:58, Nir Soffer wrote: Add 2 helpers for measuring and checking images: - qemu_img_measure() - qemu_img_check() Both use --output-json and parse the returned json to make easy to use in other tests. I'm going to use them in a new test, and I hope they will be useful in may other

Re: [PULL 2/2] s390x/s390-virtio-ccw: fix loadparm property getter

2020-07-28 Thread Peter Maydell
On Mon, 27 Jul 2020 at 15:05, Cornelia Huck wrote: > > From: Halil Pasic > > The function machine_get_loadparm() is supposed to produce a C-string, > that is a NUL-terminated one, but it does not. ElectricFence can detect > this problem if the loadparm machine property is used. > > Let us make

[PATCH v1 1/2] qemu-timer: gracefully handle the end of time

2020-07-28 Thread Alex Bennée
The previous behaviour was rather user hostile as timers set for INT64_MAX would continually re-arm leaving the system locked in a loop and the console unavailable. With this patch we detect the situation and gracefully suspend the machine. NB: we need a proper fix before the 23rd century.

[PATCH] qapi/block-core.json: Remove stale description of 'blockdev-add'

2020-07-28 Thread Kashyap Chamarthy
On a 'qemu-discuss' thread[1], Kevin identifies that the current doc blurb for @blockdev-add is stale: This is actually a documentation bug. @id doesn't exist, blockdev-add never creates a BlockBackend. This was different in the very first versions of the patches to add blockdev-add

[PULL 0/2] Update slirp (+ debug test-serial)

2020-07-28 Thread Marc-André Lureau
The following changes since commit 264991512193ee50e27d43e66f832d5041cf3b28: Merge remote-tracking branch 'remotes/ericb/tags/pull-bitmaps-2020-07-27' into staging (2020-07-28 14:38:17 +0100) are available in the Git repository at: https://github.com/elmarco/qemu.git

Re: [PATCH for-5.1?] qapi/block-core.json: Remove stale description of 'blockdev-add'

2020-07-28 Thread Eric Blake
On 7/28/20 9:32 AM, Kashyap Chamarthy wrote: On a 'qemu-discuss' thread[1], Kevin identifies that the current doc blurb for @blockdev-add is stale: This is actually a documentation bug. @id doesn't exist, blockdev-add never creates a BlockBackend. This was different in the very

[Bug 1859021] Re: qemu-system-aarch64 (tcg): cval + voff overflow not handled, causes qemu to hang

2020-07-28 Thread Alex Bennée
A different approach was posted that basically elides the overflow case by not scheduling timers for IRQ events which have already happened: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07915.html -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [PATCH v2 0/2] QEMU Gating CI

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 03:48:38PM +0100, Peter Maydell wrote: > On Mon, 20 Jul 2020 at 18:22, Cleber Rosa wrote: > > Sure. It's important that PATCH 2/2 in this series is included in a > > branch that you need to push to the "staging" branch on the > > https://gitlab.com/qemu-project/qemu repo

[PULL 1/9] nbd: Fix large trim/zero requests

2020-07-28 Thread Eric Blake
Although qemu as NBD client limits requests to <2G, the NBD protocol allows clients to send requests almost all the way up to 4G. But because our block layer is not yet 64-bit clean, we accidentally wrap such requests into a negative size, and fail with EIO instead of performing the intended

Re: [PULL 2/2] s390x/s390-virtio-ccw: fix loadparm property getter

2020-07-28 Thread Cornelia Huck
On Tue, 28 Jul 2020 14:52:36 +0100 Peter Maydell wrote: > On Mon, 27 Jul 2020 at 15:05, Cornelia Huck wrote: > > > > From: Halil Pasic > > > > The function machine_get_loadparm() is supposed to produce a C-string, > > that is a NUL-terminated one, but it does not. ElectricFence can detect > >

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 10:19, Paul Durrant wrote: > > From: Paul Durrant > > The recent commit da278d58a092 "accel: Move Xen accelerator code under > accel/xen/" introduced a subtle semantic change, making xen_enabled() always > return false unless CONFIG_XEN is defined prior to inclusion of

Re: [PULL 0/3] Block patches for 5.1

2020-07-28 Thread Peter Maydell
On Mon, 27 Jul 2020 at 15:38, Max Reitz wrote: > > The following changes since commit 4215d3413272ad6d1c6c9d0234450b602e46a74c: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.1-20200727' > into staging (2020-07-27 09:33:04 +0100) > > are available in the Git repository at: >

Re: [PATCH] hw: add compat machines for 5.2

2020-07-28 Thread Thomas Huth
On 28/07/2020 11.46, Cornelia Huck wrote: > Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck > --- > hw/arm/virt.c | 9 - > hw/core/machine.c | 3 +++ > hw/i386/pc.c | 3 +++ > hw/i386/pc_piix.c | 14

Re: Questions regarding the usage of the QIO API

2020-07-28 Thread Stefan Hajnoczi
On Thu, Jul 02, 2020 at 11:58:47AM +0200, Karaoui mohamed lamine wrote: > I am currently debugging a problem related to the usage of the QIO > interface (qio_channel_closee, qio_channel_add_watch, ...). Where can > I find more information on the internal working of this queues? How > does the

Re: [PATCH v1 2/2] target/arm: only set the nexttick timer if !ISTATUS

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 15:10, Alex Bennée wrote: > > Otherwise we have an unfortunate interaction with -count sleep=off > which means we fast forward time when we don't need to. The easiest > way to trigger it was to attach to the gdbstub and place a break point > at the timers IRQ routine. Once

[PULL 1/2] test-char: abort on serial test error

2020-07-28 Thread Marc-André Lureau
We are having issues debugging and bisecting this issue that happen mostly on patchew. Let's make it abort where it failed to gather some new informations. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Marc-André Lureau --- tests/test-char.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2] cputlb: Make store_helper less fragile to compiler optimizations

2020-07-28 Thread Alex Bennée
Richard Henderson writes: > On 7/24/20 12:51 PM, Shu-Chun Weng wrote: >> This change has no functional change. >> >> There is a potential link error with "undefined symbol: >> qemu_build_not_reached" due to how `store_helper` is structured. >> This does not produce at current QEMU head, but

[PATCH for-5.2 v4 03/11] hw/arm/smmu: Introduce smmu_get_iotlb_key()

2020-07-28 Thread Eric Auger
Introduce the smmu_get_iotlb_key() helper and the SMMU_IOTLB_ASID() macro. Also move smmu_get_iotlb_key and smmu_iotlb_key_hash in the IOTLB related code section. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell --- v1 -> v2: - creation --- hw/arm/smmu-internal.h | 1 +

Re: [PATCH v3 11/11] hw/arm/smmuv3: Advertise SMMUv3.2 range invalidation

2020-07-28 Thread Auger Eric
Hi Peter, On 7/10/20 11:47 AM, Peter Maydell wrote: > On Wed, 8 Jul 2020 at 15:20, Eric Auger wrote: >> >> Expose the RIL bit so that the guest driver uses range >> invalidation. Range invalidation being an SMMU3.2 feature, >> let AIDR advertise SMMUv3.2 support. >> >> Signed-off-by: Eric Auger

[PULL 4/9] iotests: Add more qemu_img helpers

2020-07-28 Thread Eric Blake
From: Nir Soffer Add 2 helpers for measuring and checking images: - qemu_img_measure() - qemu_img_check() Both use --output-json and parse the returned json to make easy to use in other tests. I'm going to use them in a new test, and I hope they will be useful in may other tests.

Re: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-28 Thread zhukeqian
Hi Thomas, On 2020/7/28 16:48, Thomas Huth wrote: > On 27/07/2020 16.41, Peter Maydell wrote: >> On Mon, 27 Jul 2020 at 14:03, Keqian Zhu wrote: >>> >>> Avoid covering object refcount of qemu_irq, otherwise it may causes >>> memory leak. >>> >>> Signed-off-by: Keqian Zhu >>> --- >>>

[PATCH] hw: add compat machines for 5.2

2020-07-28 Thread Cornelia Huck
Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 14 +- hw/i386/pc_q35.c | 13

Re: [PATCH v7 5/6] 9pfs: differentiate readdir lock between 9P2000.u vs. 9P2000.L

2020-07-28 Thread Christian Schoenebeck
On Sonntag, 19. Juli 2020 15:20:11 CEST Christian Schoenebeck wrote: > Previous patch suggests that it might make sense to use a different mutex > type now while handling readdir requests, depending on the precise > protocol variant, as v9fs_do_readdir_with_stat() (used by 9P2000.u) uses > a

Re: [PATCH v7 3/6] 9pfs: add new function v9fs_co_readdir_many()

2020-07-28 Thread Greg Kurz
On Tue, 28 Jul 2020 11:34:12 +0200 Christian Schoenebeck wrote: > On Dienstag, 28. Juli 2020 10:46:00 CEST Greg Kurz wrote: > > > So I'll prepare a v8 with this patch here split into two. > > > > > > But this is it. I don't see another chunk in this patch set that could be > > > split further

Re: [PATCH v2 4/4] cirrus.yml: Update the macOS jobs to Catalina

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 09:44:05AM +0200, Thomas Huth wrote: > When looking at the CI jobs on cirrus-ci.com, it seems like the mojave-based > images have been decomissioned a while ago already, since apparently all our > jobs get automatically upgraded to catalina. So let's update our YML script >

[PATCH] virtio-ccw-input: fix description

2020-07-28 Thread Cornelia Huck
Fix a copy/paste error. Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw-input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/virtio-ccw-input.c b/hw/s390x/virtio-ccw-input.c index 5601e25deed8..83136fbba15c 100644 --- a/hw/s390x/virtio-ccw-input.c +++

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-28 Thread Max Reitz
On 28.07.20 01:09, Bruce Rogers wrote: > On Tue, 2020-07-21 at 10:22 +0200, Claudio Fontana wrote: >> On 7/20/20 8:24 PM, Claudio Fontana wrote: >>> I have now been able to reproduce this on X86 as well. >>> >>> It happens much more rarely, about once every 10 times. >>> >>> I will sort out the

Re: [PATCH v11 09/11] qcow2_format.py: collect fields to dump in JSON format

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 11:14, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary with desired fields and their values. Extend it in subclass when necessary to print the final dictionary in the JSON

Re: [RFC v2 2/3] libvhost-user: handle endianness as mandated by the spec

2020-07-28 Thread Halil Pasic
On Tue, 28 Jul 2020 12:48:50 +0200 Cornelia Huck wrote: > On Tue, 21 Jul 2020 18:44:56 +0200 > Halil Pasic wrote: > > > On Tue, 21 Jul 2020 09:40:10 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jul 17, 2020 at 11:29:28AM +0200, Marc Hartmayer wrote: > > > > Since virtio existed

Re: [PATCH] virtio-ccw-input: fix description

2020-07-28 Thread Cornelia Huck
On Tue, 28 Jul 2020 12:28:20 +0200 Cornelia Huck wrote: > Fix a copy/paste error. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/virtio-ccw-input.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/virtio-ccw-input.c b/hw/s390x/virtio-ccw-input.c > index

Re: [PATCH for-5.1 1/2] block: Fix bdrv_aligned_p*v() for qiov_offset != 0

2020-07-28 Thread Philippe Mathieu-Daudé
On 7/28/20 2:08 PM, Max Reitz wrote: > Since these functions take a @qiov_offset, they must always take it into > account when working with @qiov. There are a couple of places where > they do not, but they should. > > Fixes: 65cd4424b9df03bb5195351c33e04cbbecc0705c > Fixes:

Re: [PATCH for-5.1 1/2] block: Fix bdrv_aligned_p*v() for qiov_offset != 0

2020-07-28 Thread Claudio Fontana
Tested-by: Claudio Fontana On 7/28/20 2:08 PM, Max Reitz wrote: > Since these functions take a @qiov_offset, they must always take it into > account when working with @qiov. There are a couple of places where > they do not, but they should. > > Fixes: 65cd4424b9df03bb5195351c33e04cbbecc0705c >

Re: [PATCH for-5.1 2/2] iotests/028: Add test for cross-base-EOF reads

2020-07-28 Thread Claudio Fontana
Tested-by: Claudio Fontana On 7/28/20 2:08 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/028 | 19 +++ > tests/qemu-iotests/028.out | 11 +++ > 2 files changed, 30 insertions(+) > > diff --git a/tests/qemu-iotests/028

Re: qemu icount to run guest SMP code

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 13:34, Wu, Wentong wrote: > We are trying to run guest SMP code with qemu icount mode, but based on my > current understanding I don’t think we can do that, because with icount > enabled, the multi cpus will be simulated in round-robin way(tcg kick vcpu > timer, or

Re: [PATCH v11 10/11] qcow2_format.py: introduce Qcow2HeaderExtensionsDoc class

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2020 16:27, Andrey Shinkevich wrote: On 28.07.2020 14:36, Vladimir Sementsov-Ogievskiy wrote: 17.07.2020 11:14, Andrey Shinkevich wrote: Per original script design, QcowHeader class may dump the QCOW2 header info separately from the QCOW2 extensions info. To implement the to_dict()

QEMU | Pipeline #171639775 has failed for master | 1b242c3b

2020-07-28 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 1b242c3b ( https://gitlab.com/qemu-project/qemu/-/commit/1b242c3b1ec7c6011901b4f3b4b0876e31746afb ) Commit Message: Merge

[PULL 6/9] block/nbd: split nbd_establish_connection out of nbd_client_connect

2020-07-28 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We are going to implement non-blocking version of nbd_establish_connection, which for a while will be used only for nbd_reconnect_attempt, not for nbd_open, so we need to call it separately. Refactor nbd_reconnect_attempt in a way which makes next commit

[PULL 2/9] block: nbd: Fix convert qcow2 compressed to nbd

2020-07-28 Thread Eric Blake
From: Nir Soffer When converting to qcow2 compressed format, the last step is a special zero length compressed write, ending in a call to bdrv_co_truncate(). This call always fails for the nbd driver since it does not implement bdrv_co_truncate(). For block devices, which have the same limits,

[PULL 0/9] nbd patches for -rc2, 2020-07-28

2020-07-28 Thread Eric Blake
The following changes since commit 1b242c3b1ec7c6011901b4f3b4b0876e31746afb: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20200727' into staging (2020-07-28 13:46:31 +0100) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git

Re: [PATCH] osdep.h: Add doc comment for qemu_get_thread_id()

2020-07-28 Thread Eric Blake
On 7/16/20 10:41 AM, Peter Maydell wrote: Add a documentation comment for qemu_get_thread_id(): since this is rather host-OS-specific it's useful if people writing the implementation and people thinking of using the function know what the purpose and limitations are. Signed-off-by: Peter

[PATCH for-5.2 v4 02/11] hw/arm/smmu-common: Add IOTLB helpers

2020-07-28 Thread Eric Auger
Add two helpers: one to lookup for a given IOTLB entry and one to insert a new entry. We also move the tracing there. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell --- include/hw/arm/smmu-common.h | 2 ++ hw/arm/smmu-common.c | 36

[PATCH for-5.2 v4 11/11] hw/arm/smmuv3: Advertise SMMUv3.2 range invalidation

2020-07-28 Thread Eric Auger
Expose the RIL bit so that the guest driver uses range invalidation. Although RIL is a 3.2 features, We let the AIDR advertise SMMUv3.1 support as v3.x implementation is allowed to implement features from v3.(x+1). Signed-off-by: Eric Auger Reviewed-by: Peter Maydell --- v2 -> v3: - keep the

[PATCH for-5.2 v4 06/11] hw/arm/smmuv3: Introduce smmuv3_s1_range_inval() helper

2020-07-28 Thread Eric Auger
Let's introduce an helper for S1 IOVA range invalidation. This will be used for NH_VA and NH_VAA commands. It decodes the same fields, trace, calls the UNMAP notifiers and invalidate the corresponding IOTLB entries. At the moment, we do not support 3.2 range invalidation yet. So it reduces to a

[PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread Philippe Mathieu-Daudé
CONFIG_XEN is generated by configure and stored in "config-target.h", which is (obviously) only include for target-specific objects. This is a problem for target-agnostic objects as CONFIG_XEN is never defined and xen_enabled() is always inlined as 'false'. Fix by following the KVM schema,

  1   2   3   4   >