Re: elf2dmp: Fix memory leak on main() error paths

2020-09-11 Thread Laurent Vivier
Le 11/09/2020 à 06:18, Thomas Huth a écrit : > On 26/08/2020 12.15, AlexChen wrote: >> From: AlexChen >> >> The 'kdgb' is allocating memory in get_kdbg(), but it is not freed >> in both fill_header() and fill_context() failed branches, fix it. >> >> Signed-off-by: AlexChen >> --- >>

Re: [PATCH 4/6] hw/net/xilinx_axienet: Rename StreamSlave as StreamSink

2020-09-11 Thread Edgar E. Iglesias
On Fri, Sep 11, 2020 at 09:28:38AM +0200, Paolo Bonzini wrote: > On 10/09/20 09:01, Philippe Mathieu-Daudé wrote: > > In order to use inclusive terminology, rename 'slave stream' > > as 'sink stream'. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > hw/net/xilinx_axienet.c | 24

Re: [PATCH 4/6] hw/net/xilinx_axienet: Rename StreamSlave as StreamSink

2020-09-11 Thread Paolo Bonzini
On 10/09/20 09:01, Philippe Mathieu-Daudé wrote: > In order to use inclusive terminology, rename 'slave stream' > as 'sink stream'. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/xilinx_axienet.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > >

Re: [PATCH v5 1/7] usb/hcd-xhci: Make dma read/writes hooks pci free

2020-09-11 Thread Edgar E. Iglesias
On Thu, Sep 10, 2020 at 12:01:03PM +0530, Sai Pavan Boddu wrote: > This patch starts making the hcd-xhci.c pci free, as part of this > restructuring dma read/writes are handled without passing pci object. > > Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias > --- >

Re: [PATCH v5 5/7] misc: Add versal-usb2-regs module

2020-09-11 Thread Edgar E. Iglesias
On Thu, Sep 10, 2020 at 12:01:07PM +0530, Sai Pavan Boddu wrote: > This module emulates control registers of versal usb2 controller, this is > added > just to make guest happy. In general this module would control the phy-reset > signal from usb controller, data coherency of the transactions,

Re: [PATCH 00/18] chardev: QOM cleanups

2020-09-11 Thread Marc-André Lureau
Hi On Thu, Sep 10, 2020 at 11:50 PM Eduardo Habkost wrote: > Some chardev QOM cleanup patches had to be dropped from my queue > due to build erros introduced by code movements across ifdef > boundaries at char-parallel.c. This series redo the changes from > those patches, but the macro renames

Re: [PATCH 09/14] block/qcow2: qcow2_get_specific_info(): drop error propagation

2020-09-11 Thread Greg Kurz
On Wed, 9 Sep 2020 21:59:25 +0300 Vladimir Sementsov-Ogievskiy wrote: > Don't use error propagation in qcow2_get_specific_info(). For this > refactor qcow2_get_bitmap_info_list, its current interface rather ... interface is rather > weird. > > Signed-off-by: Vladimir Sementsov-Ogievskiy >

[PATCH v5 1/7] vhost: recheck dev state in the vhost_migration_log routine

2020-09-11 Thread Dima Stepanov
vhost-user devices can get a disconnect in the middle of the VHOST-USER handshake on the migration start. If disconnect event happened right before sending next VHOST-USER command, then the vhost_dev_set_log() call in the vhost_migration_log() function will return error. This error will lead to

[PATCH v5 4/7] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

2020-09-11 Thread Dima Stepanov
Add support for the vhost-user-blk-pci device. This node can be used by the vhost-user-blk tests. Tests for the vhost-user-blk device are added in the following patches. Signed-off-by: Dima Stepanov --- tests/qtest/libqos/virtio-blk.c | 14 +- 1 file changed, 13 insertions(+), 1

Re: [PULL 02/10] usb-host: restrict workaround to new libusb versions

2020-09-11 Thread Igor Mammedov
On Thu, 10 Sep 2020 14:14:56 +0100 Alex Bennée wrote: > From: Gerd Hoffmann > > Fixes build failures with old kernels (USBDEVFS_GET_SPEED missing), > on the assumtion that distros with old kernels also have old libusb. > > Reported-by: Alex Bennée > Signed-off-by: Gerd Hoffmann >

Re: [Bug 1895080] [NEW] pgb_reserved_va: Assertion `addr == test' failed

2020-09-11 Thread Hansni Bu
> This problem occurs on CentOS-7.5 (64-bit) with qemu-5.1.0, qemu head > > (commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a) for riscv32-linux- > > user. > > I tried to build qemu-5.1 on CentOS-7.5.1 but as python 3.5 is not > available, I gave up. > Thank you for your effort. I installed

Re: [PATCH 2/6] hw/core/stream: Rename StreamSlave as StreamSink

2020-09-11 Thread Paolo Bonzini
On 10/09/20 09:01, Philippe Mathieu-Daudé wrote: > In order to use inclusive terminology, rename 'slave stream' > as 'sink stream'. > > Signed-off-by: Philippe Mathieu-Daudé >From Edgar Iglesias: Regarding streams, our stream module can be used to model a stream channel such as AXI stream but

Re: [PATCH 00/18] chardev: QOM cleanups

2020-09-11 Thread Daniel P . Berrangé
On Fri, Sep 11, 2020 at 12:07:27PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Sep 10, 2020 at 11:50 PM Eduardo Habkost > wrote: > > > Some chardev QOM cleanup patches had to be dropped from my queue > > due to build erros introduced by code movements across ifdef > > boundaries at

[PATCH v5 0/7] vhost-user-blk: fix the migration issue and enhance qtests

2020-09-11 Thread Dima Stepanov
v4 -> v5: - vhost: check queue state in the vhost_dev_set_log routine tests/qtest/vhost-user-test: prepare the tests for adding new dev class tests/qtest/vhost-user-test: add support for the vhost-user-blk device tests/qtest/vhost-user-test: add migrate_reconnect test

[PATCH v5 6/7] tests/qtest/vhost-user-test: add migrate_reconnect test

2020-09-11 Thread Dima Stepanov
Add new migrate_reconnect test for the vhost-user-blk device. Perform a disconnect after sending response for the VHOST_USER_SET_LOG_BASE command. Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz --- tests/qtest/vhost-user-test.c | 25 + 1 file changed, 25

[PATCH v5 2/7] vhost: check queue state in the vhost_dev_set_log routine

2020-09-11 Thread Dima Stepanov
If the vhost-user-blk daemon provides only one virtqueue, but device was added with several queues, then QEMU will send more VHOST-USER command than expected by daemon side. The vhost_virtqueue_start() routine handles such case by checking the return value from the virtio_queue_get_desc_addr()

[PATCH v5 3/7] tests/qtest/vhost-user-test: prepare the tests for adding new dev class

2020-09-11 Thread Dima Stepanov
For now only vhost-user-net device is supported by the test. Other vhost-user devices are not tested. As a first step make source code refactoring so new devices can reuse the same test routines. To make this provide a new vhost_user_ops structure with the methods to initialize device, its command

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-11 Thread Greg Kurz
s/startus/status On Wed, 9 Sep 2020 21:59:27 +0300 Vladimir Sementsov-Ogievskiy wrote: > It's better to return status together with setting errp. It makes > possible to avoid error propagation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.h| 2 +- >

Re: [for-5.2 v4 10/10] s390: Recognize host-trust-limitation option

2020-09-11 Thread Greg Kurz
On Fri, 11 Sep 2020 10:07:18 +1000 David Gibson wrote: > On Thu, Sep 10, 2020 at 08:29:24PM +0200, Halil Pasic wrote: > > On Thu, 10 Sep 2020 13:36:09 +0200 > > Cornelia Huck wrote: > > > > > On Mon, 7 Sep 2020 17:22:53 +0200 > > > Halil Pasic wrote: > > > > > > > On Fri, 24 Jul 2020

Re: [PATCH 00/10] edk2: adopt the edk2-stable202008 release

2020-09-11 Thread Laszlo Ersek
On 09/10/20 21:31, Philippe Mathieu-Daudé wrote: > On 9/8/20 9:29 AM, Laszlo Ersek wrote: >> Ref:https://bugs.launchpad.net/qemu/+bug/1852196 >> Repo: https://github.com/lersek/qemu.git >> Branch: edk2stable202008_lp_1852196 >> >> This series consumes the following upstream edk2 releases: >>

PATCH: Increase System Firmware Max Size

2020-09-11 Thread McMillan, Erich
Hi all, (this is my first Qemu patch submission, please let me know if my formatting/content needs to be fixed). We have a need for increased firmware size, currently we are building Qemu with the following change to test our Uefi Firmware and it works well for us. Hope that this change can be

Re: [PATCH 3/6] hw/dma/xilinx_axidma: Rename StreamSlave as StreamSink

2020-09-11 Thread Edgar E. Iglesias
On Fri, Sep 11, 2020 at 09:28:34AM +0200, Paolo Bonzini wrote: > On 10/09/20 09:01, Philippe Mathieu-Daudé wrote: > > In order to use inclusive terminology, rename 'slave stream' > > as 'sink stream'. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > hw/dma/xilinx_axidma.c | 26

Re: [PATCH 2/6] hw/core/stream: Rename StreamSlave as StreamSink

2020-09-11 Thread Edgar E. Iglesias
On Fri, Sep 11, 2020 at 09:28:16AM +0200, Paolo Bonzini wrote: > On 10/09/20 09:01, Philippe Mathieu-Daudé wrote: > > In order to use inclusive terminology, rename 'slave stream' > > as 'sink stream'. > > > > Signed-off-by: Philippe Mathieu-Daudé > > From Edgar Iglesias: > > Regarding streams,

Re: [PATCH] spapr: Handle HPT allocation failure in nested guest

2020-09-11 Thread Greg Kurz
On Fri, 11 Sep 2020 01:31:23 -0300 Fabiano Rosas wrote: > The nested KVM code does not yet support HPT guests. Calling the > KVM_CAP_PPC_ALLOC_HTAB ioctl currently leads to KVM setting the guest > as HPT and erroneously executing code in L1 that should only run in > hypervisor mode, leading to

Re: [PATCH 00/18] chardev: QOM cleanups

2020-09-11 Thread Daniel P . Berrangé
On Fri, Sep 11, 2020 at 12:19:08PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Sep 11, 2020 at 12:10 PM Daniel P. Berrangé > wrote: > > > On Fri, Sep 11, 2020 at 12:07:27PM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On Thu, Sep 10, 2020 at 11:50 PM Eduardo Habkost > > > wrote: >

Re: [PATCH] qemu-img: Support bitmap --merge into backing image

2020-09-11 Thread Max Reitz
On 09.09.20 14:33, Eric Blake wrote: > If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a > bitmap from top into base, qemu-img was failing with: > > qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to > get shared "write" lock > Is another process using

Re: [PULL 06/10] configure: don't enable ppc64abi32-linux-user by default

2020-09-11 Thread Alex Bennée
Peter Maydell writes: > On Thu, 10 Sep 2020 at 14:15, Alex Bennée wrote: >> >> The user can still enable this explicitly but they will get a warning >> at the end of configure for their troubles. This also drops any builds >> of ppc64abi32 from our CI tests. >> >> Signed-off-by: Alex Bennée

Re: [PATCH v5 7/7] Versal: Connect DWC3 controller with virt-versal

2020-09-11 Thread Edgar E. Iglesias
On Thu, Sep 10, 2020 at 12:01:09PM +0530, Sai Pavan Boddu wrote: > From: Vikram Garhwal > > Connect dwc3 controller and usb2-reg module to virt-versal. > Configure it as dual port host controller. > > Signed-off-by: Vikram Garhwal > Signed-off-by: Sai Pavan Boddu > --- >

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-11 Thread Markus Armbruster
Ari Sundholm writes: > Hi Vladimir! > > Thank you for working on this. My comments below. > > On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote: >> It's simple to avoid error propagation in blk_log_writes_open(), we >> just need to refactor blk_log_writes_find_cur_log_sector() a bit. >>

Re: [PATCH 08/14] blockjob: return status from block_job_set_speed()

2020-09-11 Thread Greg Kurz
On Wed, 9 Sep 2020 21:59:24 +0300 Vladimir Sementsov-Ogievskiy wrote: > Better to return status together with setting errp. It allows to avoid > error propagation in the caller. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Reviewed-by: Greg Kurz > include/block/blockjob.h | 2 +-

Re: PATCH: Increase System Firmware Max Size

2020-09-11 Thread Dr. David Alan Gilbert
* Laszlo Ersek (ler...@redhat.com) wrote: > +Markus, Dave, Phil > > On 09/11/20 03:45, McMillan, Erich wrote: > > Hi all, > > > > (this is my first Qemu patch submission, please let me know if my > > formatting/content needs to be fixed). > > We have a need for increased firmware size,

Re: [PATCH v3 1/2] qcow2: Report BDRV_BLOCK_ZERO more accurately in bdrv_co_block_status()

2020-09-11 Thread Vladimir Sementsov-Ogievskiy
10.09.2020 20:46, Alberto Garcia wrote: If a BlockDriverState supports backing files but has none then any unallocated area reads back as zeroes. bdrv_co_block_status() is only reporting this is if want_zero is true, but this is an inexpensive test and there is no reason not to do it in all

Re: [PATCH 3/6] hw/dma/xilinx_axidma: Rename StreamSlave as StreamSink

2020-09-11 Thread Paolo Bonzini
On 10/09/20 09:01, Philippe Mathieu-Daudé wrote: > In order to use inclusive terminology, rename 'slave stream' > as 'sink stream'. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/dma/xilinx_axidma.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > >

Re: [PATCH] qcow2: Return the original error code in qcow2_co_pwrite_zeroes()

2020-09-11 Thread Max Reitz
On 09.09.20 14:37, Alberto Garcia wrote: > This function checks the current status of a (sub)cluster in order to > see if an unaligned 'write zeroes' request can be done efficiently by > simply updating the L2 metadata and without having to write actual > zeroes to disk. > > If the situation does

Re: [PATCH 0/2] block: remove stale runtime_opts

2020-09-11 Thread Max Reitz
On 06.08.20 23:13, John Snow wrote: > > > John Snow (2): > block/rbd: remove runtime_opts > block/qcow: remove runtime opts > > block/qcow.c | 9 - > block/rbd.c | 42 -- > 2 files changed, 51 deletions(-) Thanks, applied to my block

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-11 Thread Greg Kurz
On Fri, 11 Sep 2020 07:30:37 +0200 Markus Armbruster wrote: > Markus Armbruster writes: > > > Greg Kurz writes: > > > >> On Wed, 9 Sep 2020 21:59:23 +0300 > >> Vladimir Sementsov-Ogievskiy wrote: > >> > >>> It's simple to avoid error propagation in blk_log_writes_open(), we > >>> just need

Re: PATCH: Increase System Firmware Max Size

2020-09-11 Thread Laszlo Ersek
+Markus, Dave, Phil On 09/11/20 03:45, McMillan, Erich wrote: > Hi all, > > (this is my first Qemu patch submission, please let me know if my > formatting/content needs to be fixed). > We have a need for increased firmware size, currently we are building Qemu > with the following change to

[Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-11 Thread Petunia
mhm thats somehow unfortunate since I dont know in what direction I would have to go to solve the issue :/ I tried 245.7 but without success. Do you maybe have an idea on how to investigate further? Is this some kind of distribution problem? What is the actual problem anyway? -- You received

[PATCH v5 5/7] tests/qtest/vhost-user-test: add support for the vhost-user-blk device

2020-09-11 Thread Dima Stepanov
Add vhost_user_ops structure for the vhost-user-blk device class. Add the test_reconnect and test_migrate tests for this device. Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz --- tests/qtest/vhost-user-test.c | 139 +- 1 file changed, 137

[PATCH 2/3] doc: Cleanup "'-mem-path' fallback to RAM" deprecation text

2020-09-11 Thread Igor Mammedov
it was actually removed in 5.0, commit 68a86dc15c (numa: remove deprecated -mem-path fallback to anonymous RAM) clean up forgotten remnants in docs. Signed-off-by: Igor Mammedov --- docs/system/deprecated.rst | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff

[PATCH v5 7/7] tests/qtest/vhost-user-test: enable the reconnect tests

2020-09-11 Thread Dima Stepanov
For now a QTEST_VHOST_USER_FIXME environment variable is used to separate reconnect tests for the vhost-user-net device. Looks like the reconnect functionality is pretty stable, so this separation is deprecated. Remove it and enable these tests for the default run. Signed-off-by: Dima Stepanov

Re: [PATCH v6 3/4] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-09-11 Thread Stefan Hajnoczi
On Thu, Sep 10, 2020 at 05:29:25PM +0200, Philippe Mathieu-Daudé wrote: > Hi Stefan, Alex. > > On 9/10/20 12:44 PM, Stefan Hajnoczi wrote: > > On Wed, Sep 09, 2020 at 04:23:53PM +0200, Philippe Mathieu-Daudé wrote: > >> +/** > >> + * Initialize device MSIX IRQs and register event notifiers. > >>

[PATCH 3/3] numa: remove fixup numa_state->num_nodes to MAX_NODES

2020-09-11 Thread Igor Mammedov
current code permits only nodeids in [0..MAX_NODES) range due to nodeid check in parse_numa_node() if (nodenr >= MAX_NODES) { error_setg(errp, "Max number of NUMA nodes reached: %" so subj fixup is not reachable, drop it. Signed-off-by: Igor Mammedov --- hw/core/numa.c | 4

Re: [PATCH v3 2/2] qcow2: Skip copy-on-write when allocating a zero cluster

2020-09-11 Thread Vladimir Sementsov-Ogievskiy
10.09.2020 20:46, Alberto Garcia wrote: Since commit c8bb23cbdbe32f5c326365e0a82e1b0e68cdcd8a when a write request results in a new allocation QEMU first tries to see if the rest of the cluster outside the written area contains only zeroes. In that case, instead of doing a normal copy-on-write

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-11 Thread Robert Hoo
On Wed, 2020-09-09 at 14:15 -0400, Eduardo Habkost wrote: > Hi, > > Thanks for the patch, and sorry for taking so long to review > this. I'm finally getting to the patches that were postponed to > 5.2. > > Comments and questions below: > > On Thu, Jun 11, 2020 at 10:47:55AM +0800, Robert Hoo

Re: [PATCH 00/18] chardev: QOM cleanups

2020-09-11 Thread Marc-André Lureau
Hi On Fri, Sep 11, 2020 at 12:10 PM Daniel P. Berrangé wrote: > On Fri, Sep 11, 2020 at 12:07:27PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Thu, Sep 10, 2020 at 11:50 PM Eduardo Habkost > > wrote: > > > > > Some chardev QOM cleanup patches had to be dropped from my queue > > > due to

[Bug 1895080] Re: pgb_reserved_va: Assertion `addr == test' failed

2020-09-11 Thread Alex Bennée
Have you got a static version of the test binary (or a mini rootfs with the libraries it needs)? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895080 Title: pgb_reserved_va: Assertion `addr ==

Re: [PATCH 0/2] Fix error handling in preallocate_co()

2020-09-11 Thread Max Reitz
On 08.09.20 16:08, Alberto Garcia wrote: > This is a follow-up to "Fix removal of list members from > BDRVQcow2State.cluster_allocs": > >https://lists.gnu.org/archive/html/qemu-block/2020-09/msg00247.html > > However the patches themselves are independent and can be applied > separately. >

[PATCH 1/3] numa: drop support for '-numa node' (without memory specified)

2020-09-11 Thread Igor Mammedov
it was deprecated since 4.1 commit 4bb4a2732e (numa: deprecate implict memory distribution between nodes) Users of existing VMs, wishing to preserve the same RAM distribution, should configure it explicitly using ``-numa node,memdev`` options. Current RAM distribution can be retrieved using HMP

[PATCH 0/3] numa: cleanups for 5.2

2020-09-11 Thread Igor Mammedov
Remove deprecated default RAM splitting beween numa nodes that was deprecated since 4.1, and a couple of minor numa clean ups. Igor Mammedov (3): numa: drop support for '-numa node' (without memory specified) doc: Cleanup "'-mem-path' fallback to RAM" deprecation text numa: remove fixup

[Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-11 Thread Laurent Vivier
We can try to see what is failing by enabling qemu strace. To do that, I don't know a better solution than using a wrapper. Once /mnt is mounted, copy qemu-arm-static inside with a new name: sudo cp /usr/bin/qemu-arm-static /mnt/usr/bin/qemu-arm-org Then create the wrapper: cat >

Re: [Bug 1895080] [NEW] pgb_reserved_va: Assertion `addr == test' failed

2020-09-11 Thread Alex Bennée
Alex Bennée writes: > Laurent Vivier writes: > >>> Then trying qemu-riscv32 with a simple ELF, I get: >>> linux-user/elfload.c:2341: pgb_reserved_va: Assertion `addr == test' failed. >>> >>> strace shows that: >>> mmap(0x1000, 4294963200, PROT_NONE, >>>

Re: [PATCH 0/8] virtiofsd: Announce submounts to the guest

2020-09-11 Thread Stefan Hajnoczi
On Wed, Sep 09, 2020 at 08:40:20PM +0200, Max Reitz wrote: > We want to (be able to) announce the host mount structure of the shared > directory to the guest so it can replicate that structure. This ensures > that whenever the combination of st_dev and st_ino is unique on the > host, it will be

Re: [PATCH 1/1] accel/tcg/user-exec: support computing is_write for mips32

2020-09-11 Thread Peter Maydell
On Fri, 11 Sep 2020 at 02:14, zou xu wrote: > > From 533ed02427bdaf0265f62fcb4f961854a41b7037 Mon Sep 17 00:00:00 2001 > From: ZouXu > Date: Wed, 9 Sep 2020 21:59:13 +0800 > Subject: [PATCH 1/1] accel/tcg/user-exec: support computing is_write for > mips32 > > Those MIPS32 instructions can cause

Re: [PATCH v3 0/7] migration: bring improved savevm/loadvm/delvm to QMP

2020-09-11 Thread Dr. David Alan Gilbert
Kevin: While we're still arguing about details of the last commit; can we get the first few commits in - they seem to be generally nice cleanups/error handling. Dave * Daniel P. Berrangé (berra...@redhat.com) wrote: > v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html >

[PATCH] smp: drop support for deprecated (invalid topologies)

2020-09-11 Thread Igor Mammedov
it's was deprecated since 3.1 Support for invalid topologies is removed, the user must ensure that topologies described with -smp include all possible cpus, i.e. (sockets * cores * threads) == maxcpus or QEMU will exit with error. Signed-off-by: Igor Mammedov --- docs/system/deprecated.rst |

Re: device compatibility interface for live migration with assigned devices

2020-09-11 Thread Cornelia Huck
On Fri, 11 Sep 2020 08:56:00 +0800 Yan Zhao wrote: > On Thu, Sep 10, 2020 at 12:02:44PM -0600, Alex Williamson wrote: > > On Thu, 10 Sep 2020 13:50:11 +0100 > > Sean Mooney wrote: > > > > > On Thu, 2020-09-10 at 14:38 +0200, Cornelia Huck wrote: > > > > On Wed, 9 Sep 2020 10:13:09 +0800 >

Re: [PATCH] trace/simple: Enable tracing on startup only if the user specifies a trace option

2020-09-11 Thread Stefan Hajnoczi
On Sun, Aug 16, 2020 at 12:46:10PM -0500, dubo...@gmail.com wrote: > From: Josh DuBois > > Tracing can be enabled at the command line or via the > monitor. Command-line trace options are recorded during > trace_opt_parse(), but tracing is not enabled until the various > front-ends later call

RE: device compatibility interface for live migration with assigned devices

2020-09-11 Thread Tian, Kevin
> From: Cornelia Huck > Sent: Friday, September 11, 2020 6:08 PM > > On Fri, 11 Sep 2020 08:56:00 +0800 > Yan Zhao wrote: > > > On Thu, Sep 10, 2020 at 12:02:44PM -0600, Alex Williamson wrote: > > > On Thu, 10 Sep 2020 13:50:11 +0100 > > > Sean Mooney wrote: > > > > > > > On Thu, 2020-09-10

Re: [PATCH v5 5/8] s390/sclp: use cpu offset to locate cpu entries

2020-09-11 Thread Cornelia Huck
On Thu, 10 Sep 2020 05:36:52 -0400 Collin Walling wrote: > The start of the CPU entry region in the Read SCP Info response data is > denoted by the offset_cpu field. As such, QEMU needs to begin creating > entries at this address. > > This is in preparation for when Read SCP Info inevitably

转发: [PATCH RESEND] Fix video playback slowdown when spice client no audio enabled

2020-09-11 Thread zhou qi
Because I don't received any feedback, so i have decide resend again. with more detail. @DirtY.iCE.hu, Can you review this patch? or someone else has time ? Issue: video playback slowdown, using spice client --spice-disable-audio option How to reproduce: 1. compile qemu master for x86_64

Re: [PATCH] hw/arm/pxa2xx: Add missing fallthrough comment

2020-09-11 Thread Philippe Mathieu-Daudé
On 9/11/20 2:18 PM, Thomas Huth wrote: > Let's make this file compilable with -Werror=implicit-fallthrough : > Looking at the code, it seems like the fallthrough is intended here, > so we should add the corresponding "/* fallthrough */" comment here. > > Signed-off-by: Thomas Huth > --- >

[PATCH 2/2] meson: error out if qemu_suffix starts with /

2020-09-11 Thread marcandre . lureau
From: Marc-André Lureau Since the variable is used for path concatenation, the result would ignore the prefix directory altogether. Signed-off-by: Marc-André Lureau --- meson.build | 5 + 1 file changed, 5 insertions(+) diff --git a/meson.build b/meson.build index 5421eca66a..cbe1cb51b3

[PATCH 1/2] meson: fix MSI rule

2020-09-11 Thread marcandre . lureau
From: Marc-André Lureau The environment variables can't be passed through an env: argument yet (meson#2723), use 'env' as suggested in: https://github.com/mesonbuild/meson/issues/2723#issuecomment-348630957 Signed-off-by: Marc-André Lureau --- qga/meson.build | 1 + 1 file changed, 1

Re: [PATCH] hw/arm/pxa2xx: Add missing fallthrough comment

2020-09-11 Thread Thomas Huth
On 11/09/2020 14.41, Philippe Mathieu-Daudé wrote: > On 9/11/20 2:18 PM, Thomas Huth wrote: >> Let's make this file compilable with -Werror=implicit-fallthrough : >> Looking at the code, it seems like the fallthrough is intended here, >> so we should add the corresponding "/* fallthrough */"

[PATCH] meson: clean up build_by_default

2020-09-11 Thread Paolo Bonzini
Build all executables by default except for the known-broken ones. This also allows running qemu-iotests without manually building socket_scm_helper. Reported-by: Max Reitz Signed-off-by: Paolo Bonzini --- docs/devel/build-system.rst| 5 + tests/fp/meson.build | 2 --

Re: [PATCH 2/2] meson: error out if qemu_suffix starts with /

2020-09-11 Thread Paolo Bonzini
On 11/09/20 14:42, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Since the variable is used for path concatenation, the result would > ignore the prefix directory altogether. > > Signed-off-by: Marc-André Lureau > --- > meson.build | 5 + > 1 file changed, 5

Re: [Bug 1895080] [NEW] pgb_reserved_va: Assertion `addr == test' failed

2020-09-11 Thread Alex Bennée
Laurent Vivier writes: > Le 10/09/2020 à 07:21, Launchpad Bug Tracker a écrit : >> This problem occurs on CentOS-7.5 (64-bit) with qemu-5.1.0, qemu head >> (commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a) for riscv32-linux- >> user. > > I tried to build qemu-5.1 on CentOS-7.5.1 but as python

Re: [PATCH v3 2/2] qcow2: Skip copy-on-write when allocating a zero cluster

2020-09-11 Thread Alberto Garcia
On Fri 11 Sep 2020 11:34:37 AM CEST, Vladimir Sementsov-Ogievskiy wrote: >> -if (!is_zero_cow(bs, m)) { >> +ret = is_zero_cow(bs, m); >> +if (ret < 0) { >> +return ret; > > It's a common practice to treat block-status errors as "unknown" > status and not

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-11 Thread Paolo Bonzini
On Thu, Sep 10, 2020 at 7:49 PM wrote: > The usage is relatively simple: > > - from_qemu_none(ptr: *const sys::P) -> T > Return a Rust type T for a const ffi pointer P. > > - from_qemu_full(ptr: *mut sys::P) -> T > Return a Rust type T for a ffi pointer P, taking ownership. > > -

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-11 Thread Daniel P . Berrangé
On Thu, Sep 10, 2020 at 09:48:50PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > Among the QEMU developers, there is a desire to use Rust. (see previous > thread from Stefan "Why QEMU should move from C to Rust", the rust-vmm > related projects and other

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-11 Thread Greg Kurz
On Fri, 11 Sep 2020 13:18:32 +0300 Vladimir Sementsov-Ogievskiy wrote: > 11.09.2020 12:38, Greg Kurz wrote: > > s/startus/status > > > > On Wed, 9 Sep 2020 21:59:27 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > >> It's better to return status together with setting errp. It makes > >>

[PATCH] cphp: remove deprecated cpu-add command(s)

2020-09-11 Thread Igor Mammedov
theses were deprecatedince since 4.0, remove both HMP and QMP variants. Users should use device_add commnad instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov --- include/hw/boards.h |

Re: [for-5.2 v4 10/10] s390: Recognize host-trust-limitation option

2020-09-11 Thread Halil Pasic
On Fri, 11 Sep 2020 10:07:18 +1000 David Gibson wrote: > On Thu, Sep 10, 2020 at 08:29:24PM +0200, Halil Pasic wrote: > > On Thu, 10 Sep 2020 13:36:09 +0200 > > Cornelia Huck wrote: > > > > > On Mon, 7 Sep 2020 17:22:53 +0200 > > > Halil Pasic wrote: > > > > > > > On Fri, 24 Jul 2020

Re: [PATCH v1 2/3] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag

2020-09-11 Thread Igor Mammedov
On Thu, 10 Sep 2020 22:34:20 +0530 Ani Sinha wrote: > On Sep 5, 2020, 16:05 +0530, Ani Sinha , wrote: > > This change adds a new unit test for the global flag > > 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged > > pci > > bridges in i440fx. The flag can be used to

Re: VHOST_USER_PROTOCOL_F_VDPA

2020-09-11 Thread Stefan Hajnoczi
On Thu, Sep 10, 2020 at 10:55:00AM +0200, Maxime Coquelin wrote: > I understand the need and like the idea. If no one plans to work on this within the next 6 months it could be an internship project since the Outreachy December-March round is coming up. The time requirement is typically ~5 hours

[PATCH] target/i386/kvm: Add missing fallthrough comment

2020-09-11 Thread Thomas Huth
Let's make this file compilable with -Werror=implicit-fallthrough : Looking at the code, it seems like the fallthrough is intended here, so we should add the corresponding "/* fallthrough */" comment here. Signed-off-by: Thomas Huth --- target/i386/kvm.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH 12/14] block/qcow2: read_cache_sizes: return status value

2020-09-11 Thread Greg Kurz
On Wed, 9 Sep 2020 21:59:28 +0300 Vladimir Sementsov-Ogievskiy wrote: > It's better to return status together with setting errp. It allows to > reduce error propagation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Reviewed-by: Greg Kurz > block/qcow2.c | 19 +-- >

Re: [Bug 1895080] Re: pgb_reserved_va: Assertion `addr == test' failed

2020-09-11 Thread Hansni Bu
Have you got a static version of the test binary (or a mini rootfs with > the libraries it needs)? > If the problem occurs, it does not reach the stage of the dependent libraries of the test ELF. Anyway, I've attached the static test binary as hello.static.elf. Thanks > -- > You received this

Re: [Bug 1895080] [NEW] pgb_reserved_va: Assertion `addr == test' failed

2020-09-11 Thread Hansni Bu
No, it's not set by CentOS-7.5. Does it mean that we just cannot run the ELF in such a case? I've tried many times, the assert always fails. Maybe, we can blame CentOS-7.5. BTW: with the option "-p 65536", the case runs successfully. On Fri, Sep 11, 2020 at 5:50 PM Alex Bennée

Re: [PULL v2 01/46] qemu-iotests: move check-block back to Makefiles

2020-09-11 Thread Max Reitz
On 06.09.20 19:53, Paolo Bonzini wrote: > check-block has its own test harness, unlike every other test. If > we capture its output, as is in general nicer to do without V=1, > there will be no sign of progress. So for lack of a better option > just move the invocation of the test back to

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-11 Thread Paolo Bonzini
On 11/09/20 12:46, Daniel P. Berrangé wrote: > Do we actually need/want it to be in the same monolithic repo > as qemu, as opposed to a qemu-qapi-rust repo ? I think QAPI and qemu-ga should be separate repos altogether. QAPI should be included as a submodule in both qemu and qemu-ga. qemu-ga

[PATCH] hw/arm/pxa2xx: Add missing fallthrough comment

2020-09-11 Thread Thomas Huth
Let's make this file compilable with -Werror=implicit-fallthrough : Looking at the code, it seems like the fallthrough is intended here, so we should add the corresponding "/* fallthrough */" comment here. Signed-off-by: Thomas Huth --- hw/arm/pxa2xx.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] riscv: sifive_test: Allow 16-bit writes to memory region

2020-09-11 Thread Michael Roth
Quoting Alistair Francis (2020-09-10 13:10:43) > On Thu, Sep 3, 2020 at 2:05 PM Michael Roth wrote: > > > > Quoting Alistair Francis (2020-09-01 18:59:29) > > > On Mon, Aug 31, 2020 at 10:59 PM Nathan Chancellor > > > wrote: > > > > > > > > When shutting down the machine running a mainline Linux

Re: [PATCH v9 11/14] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-09-11 Thread Philippe Mathieu-Daudé
On 9/11/20 7:20 AM, Havard Skinnemoen via wrote: > This allows these NPCM7xx-based boards to boot from a flash image, e.g. > one built with OpenBMC. For example like this: > > IMAGE=${OPENBMC}/build/tmp/deploy/images/gsj/image-bmc > qemu-system-arm -machine quanta-gsj -nographic \ >

Re: [PATCH v9 00/14] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

2020-09-11 Thread Philippe Mathieu-Daudé
On 9/11/20 7:20 AM, Havard Skinnemoen via wrote: > This should be fully reviewed now, but the Timer patch may deserve another > look, as I fixed a few bugs in it. Huge thanks to everyone who reviewed and/or > tested this patchset, it has clearly improved a lot since I started. Yes, all patches

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-11 Thread Paolo Bonzini
On 11/09/20 12:24, Paolo Bonzini wrote: >> >> - from_qemu_none(ptr: *const sys::P) -> T >> Return a Rust type T for a const ffi pointer P. >> >> - from_qemu_full(ptr: *mut sys::P) -> T >> Return a Rust type T for a ffi pointer P, taking ownership. >> >> - T::to_qemu_none() -> Stash >>

[PATCH] ninjatool: rebuild multi-output targets if outputs are missing

2020-09-11 Thread Paolo Bonzini
The "stamp file trick" used to group targets of a single multi-output rule prevents the user from deleting one such target in order to force its rebuild. Doing so will not touch the stamp file, and therefore only the dummy ":" command will be executed. With this patch, ninjatool writes rules

Re: [PATCH v5 6/8] s390/sclp: add extended-length sccb support for kvm guest

2020-09-11 Thread Thomas Huth
On 10/09/2020 11.36, Collin Walling wrote: > As more features and facilities are added to the Read SCP Info (RSCPI) > response, more space is required to store them. The space used to store > these new features intrudes on the space originally used to store CPU > entries. This means as more

[PATCH] tests: add missing genh dependency

2020-09-11 Thread Paolo Bonzini
Fix high-parallelism builds by forcing all generated headers to be created before tests are compiled. Reported-by: Claudio Fontana Signed-off-by: Paolo Bonzini --- tests/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/meson.build b/tests/meson.build

Re: [PATCH v5 2/8] s390/sclp: rework sclp boundary checks

2020-09-11 Thread Cornelia Huck
On Thu, 10 Sep 2020 19:45:01 +0200 Thomas Huth wrote: > On 10/09/2020 11.36, Collin Walling wrote: > > Rework the SCLP boundary check to account for different SCLP commands > > (eventually) allowing different boundary sizes. > > > > Signed-off-by: Collin Walling > > Acked-by: Janosch Frank >

Re: flatview_write_continue global mutex deadlock

2020-09-11 Thread Stefan Hajnoczi
On Thu, Sep 03, 2020 at 06:42:12PM +0300, Vladimir Sementsov-Ogievskiy wrote: > But still, is it OK to do blk_drain holding the global mutex? Drain may take > a relatively long time, and vm is not responding due to global mutex locked > in cpu thread.. This is a fundamental problem in QEMU.

Re: [PATCH v3 2/2] qcow2: Skip copy-on-write when allocating a zero cluster

2020-09-11 Thread Vladimir Sementsov-Ogievskiy
11.09.2020 13:04, Alberto Garcia wrote: On Fri 11 Sep 2020 11:34:37 AM CEST, Vladimir Sementsov-Ogievskiy wrote: -if (!is_zero_cow(bs, m)) { +ret = is_zero_cow(bs, m); +if (ret < 0) { +return ret; It's a common practice to treat block-status errors as

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-11 Thread Daniel P . Berrangé
On Fri, Sep 11, 2020 at 01:28:13PM +0200, Paolo Bonzini wrote: > On 11/09/20 12:46, Daniel P. Berrangé wrote: > > Do we actually need/want it to be in the same monolithic repo > > as qemu, as opposed to a qemu-qapi-rust repo ? > > I think QAPI and qemu-ga should be separate repos altogether.

Re: [Bug 1895080] [NEW] pgb_reserved_va: Assertion `addr == test' failed

2020-09-11 Thread Alex Bennée
Hansni Bu <1895...@bugs.launchpad.net> writes: > No, it's not set by CentOS-7.5. > Does it mean that we just cannot run the ELF in such a case? I've tried > many times, the assert always fails. Maybe, we can blame CentOS-7.5. The trouble is without MAP_FIXED_NOREPLACE we are at the mercy of

[PATCH] hw: usb: hcd-ohci: check len and frame_number variables

2020-09-11 Thread P J P
From: Prasad J Pandit While servicing the OHCI transfer descriptors(TD), OHCI host controller derives variables 'start_addr', 'end_addr', 'len' etc. from values supplied by the host controller driver. Host controller driver may supply values such that using above variables leads to out-of-bounds

Re: [PATCH v1 2/3] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag

2020-09-11 Thread Ani Sinha
On Sep 11, 2020, 18:15 +0530, Igor Mammedov , wrote: > On Thu, 10 Sep 2020 22:34:20 +0530 > Ani Sinha wrote: > > > On Sep 5, 2020, 16:05 +0530, Ani Sinha , wrote: > > > This change adds a new unit test for the global flag > > > 'acpi-pci-hotplug-with-bridge-support' which is available for cold >

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-11 Thread Vladimir Sementsov-Ogievskiy
11.09.2020 12:38, Greg Kurz wrote: s/startus/status On Wed, 9 Sep 2020 21:59:27 +0300 Vladimir Sementsov-Ogievskiy wrote: It's better to return status together with setting errp. It makes possible to avoid error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h

Re: [PATCH v5 6/8] s390/sclp: add extended-length sccb support for kvm guest

2020-09-11 Thread Cornelia Huck
On Thu, 10 Sep 2020 05:36:53 -0400 Collin Walling wrote: > As more features and facilities are added to the Read SCP Info (RSCPI) > response, more space is required to store them. The space used to store > these new features intrudes on the space originally used to store CPU > entries. This

Re: [PULL v2 01/46] qemu-iotests: move check-block back to Makefiles

2020-09-11 Thread Max Reitz
On 11.09.20 12:58, Max Reitz wrote: > On 06.09.20 19:53, Paolo Bonzini wrote: >> check-block has its own test harness, unlike every other test. If >> we capture its output, as is in general nicer to do without V=1, >> there will be no sign of progress. So for lack of a better option >> just move

  1   2   3   >