[Bug 1618301] Re: qemu-input: Mouse stops working in Windows guest

2020-09-13 Thread kjonca
Another observation (not sure if 100% relevant) When I leave "Generic PS/2 mouse" as an ONLY pointing device, I can observe erratic moving ("jumping") cursor in (at least) windows guests (NT4 sp 6 , XP, Win 8.1) QEMU emulator version 5.0.0 (Debian 1:5.0-6) -- You received this bug

[PATCH 3/3] configure: automatically parse command line for meson -D options

2020-09-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile| 6 ++ configure | 71 + docs/devel/build-system.rst | 35 +-- meson-buildoptions.json | 130

Re: [PATCH v4 0/9] user-mode: Prune build dependencies (part 2)

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/12/20 11:16 AM, Paolo Bonzini wrote: > On 10/09/20 17:22, Philippe Mathieu-Daudé wrote: >> This is the second part of a series reducing user-mode >> dependencies. By stripping out unused code, the build >> and testing time is reduced (as is space used by objects). >> >> Part 2: >> - Extract

Re: [PATCH v8 20/27] tests: Fixes test-io-channel-file by mask only owner file state mask bits

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/13/20 12:44 AM, Yonggang Luo wrote: > This is the error on msys2/mingw > Running test test-io-channel-file > ** > ERROR:../tests/test-io-channel-file.c:59:test_io_channel_file_helper: > assertion failed (TEST_MASK & ~mask == st.st_mode & 0777): (384 == 438) > ERROR test-io-channel-file -

Re: [PATCH v8 02/27] block: Fixes nfs compiling error on msys2/mingw

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/13/20 12:44 AM, Yonggang Luo wrote: > These compiling errors are fixed: > ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory >27 | #include > | ^~~~ > compilation terminated. > > ../block/nfs.c:63:5: error: unknown type name 'blkcnt_t' >63 |

[PATCH v5 2/9] rcu: Implement drain_call_rcu

2020-09-13 Thread Maxim Levitsky
This will allow is to preserve the semantics of hmp_device_del, that the device is deleted immediatly which was changed by previos patch that delayed this to RCU callback Signed-off-by: Maxim Levitsky Suggested-by: Stefan Hajnoczi Reviewed-by: Stefan Hajnoczi --- include/qemu/rcu.h | 1 +

Re: [PATCH v8 02/27] block: Fixes nfs compiling error on msys2/mingw

2020-09-13 Thread Yonggang Luo
On Sun, Sep 13, 2020 at 11:47 PM Philippe Mathieu-Daudé wrote: > On 9/13/20 12:44 AM, Yonggang Luo wrote: > > These compiling errors are fixed: > > ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory > >27 | #include > > | ^~~~ > > compilation terminated.

[PATCH v5 1/9] scsi/scsi_bus: switch search direction in scsi_device_find

2020-09-13 Thread Maxim Levitsky
This change will allow us to convert the bus children list to RCU, while not changing the logic of this function Signed-off-by: Maxim Levitsky Reviewed-by: Stefan Hajnoczi --- hw/scsi/scsi-bus.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

2020-09-13 Thread Yonggang Luo
On Sun, Sep 13, 2020 at 10:08 PM Paolo Bonzini wrote: > On 13/09/20 00:44, Yonggang Luo wrote: > > This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. > > > > The --ninja option doesn't need anymore because of upgrade meson to > 0.55.2 > > At that version we can use ninjatool > > We

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

2020-09-13 Thread Paolo Bonzini
On 13/09/20 18:03, 罗勇刚(Yonggang Luo) wrote: > > _WIN32 are more precise and only depends on the compiler, on the > other hand, CONFIG_POSIX and CONFIG_WIN32 need configure > scripts. I prefer _WIN32 unless the compiler can not provide enough > information. That's not what the QEMU coding

Re: [PATCH v4 0/9] user-mode: Prune build dependencies (part 2)

2020-09-13 Thread Paolo Bonzini
On 13/09/20 17:51, Philippe Mathieu-Daudé wrote: >>> >> Yes, I'm not sure about the stub _in general_. I would prefer to either >> have the type available even on user-mode emulation, or remove the >> property altogether... I don't know, anything but not a property that >> aborts. :) > I plan to

Re: [PATCH] hw/block/nand: Decommission the NAND museum

2020-09-13 Thread Philippe Mathieu-Daudé
On 8/14/20 3:23 PM, Philippe Mathieu-Daudé wrote: > I forgot to Cc qemu-arm@, doing it now since most of the users > of this are ARM machines. The machine using this device are: - axis-dev88 - tosa (via tc6393xb_init) - spitz based (akita, borzoi, terrier) $ git grep nand_init

Re: [PATCH v4 0/9] user-mode: Prune build dependencies (part 2)

2020-09-13 Thread Paolo Bonzini
On 13/09/20 13:31, Philippe Mathieu-Daudé wrote: >> I'm not sure about the first. It's a bit ugly to have a property whose >> getter aborts. > This is (IIUC) the change Markus requested in v3 (see [*]). > > Commit description: "add a stub to satisfy the linker." > > This stub should be never

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-13 Thread Paolo Bonzini
On 13/09/20 12:15, 罗勇刚(Yonggang Luo) wrote: > > I am confusing about this? we were converting configure to meson, > and python is a force dependencies, why we need rewrite the script in > Perl? If we wanna build qemu, the first thing we need to install is > python+meson, so there is no need

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

2020-09-13 Thread Paolo Bonzini
On 13/09/20 00:44, Yonggang Luo wrote: > This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. > > The --ninja option doesn't need anymore because of upgrade meson to 0.55.2 > At that version we can use ninjatool We might actually get rid of ninjatool before QEMU 5.2 goes out, if we

Re: [PATCH v8 08/27] tests: Fixes test-replication.c on msys2/mingw.

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/13/20 12:44 AM, Yonggang Luo wrote: > On Windows there is no path like /tmp/s_local_disk.XX > Use g_get_tmp_dir instead of /tmp. > > Signed-off-by: Yonggang Luo > Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé > --- > tests/test-replication.c | 18

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/13/20 12:44 AM, Yonggang Luo wrote: > On windows, a difference in line endings causes testsuite failures > complaining that every single line in files such as > 'tests/qapi-schemadoc-good.texi' is wrong. Fix it by adding -b to diff. Isn't '--strip-trailing-cr' more adapted? > >

Re: [PATCH v8 10/27] osdep: file locking functions are not available on Win32

2020-09-13 Thread Philippe Mathieu-Daudé
Please add here: "Do not declare the following locking functions on Win32:" On 9/13/20 12:44 AM, Yonggang Luo wrote: > int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive); > int qemu_unlock_fd(int fd, int64_t start, int64_t len); > int qemu_lock_fd_test(int fd, int64_t start,

[PATCH v5 4/9] device-core: use RCU for list of childs of a bus

2020-09-13 Thread Maxim Levitsky
This fixes the race between device emulation code that tries to find a child device to dispatch the request to (e.g a scsi disk), and hotplug of a new device to that bus. Note that this doesn't convert all the readers of the list but only these that might go over that list without BQL held. This

[PATCH v5 8/9] virtio-scsi: use scsi_device_get

2020-09-13 Thread Maxim Levitsky
This will help us to avoid the scsi device disappearing after we took a reference to it. It doesn't by itself forbid case when we try to access an unrealized device Suggested-by: Stefan Hajnoczi Signed-off-by: Maxim Levitsky Reviewed-by: Stefan Hajnoczi --- hw/scsi/virtio-scsi.c | 21

[PATCH v5 5/9] device-core: use atomic_set on .realized property

2020-09-13 Thread Maxim Levitsky
Some code might race with placement of new devices on a bus. We currently first place a (unrealized) device on the bus and then realize it. As a workaround, users that scan the child device list, can check the realized property to see if it is safe to access such a device. Use an atomic write

[Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-13 Thread Petunia
Hi thanks i ran the above, but where is the strace stored? its neither in the console output nor journalctl -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895053 Title: Cannot nspawn raspbian 10

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-13 Thread Yonggang Luo
On Sun, Sep 13, 2020 at 6:07 PM Paolo Bonzini wrote: > Right now meson_options.txt lists less than a dozen options, but about > 40 more could come as configure tests are converted and moved to > meson.build. Each option needs code in configure to parse it and pass > the option down to Meson as

Re: [PATCH] Fix video playback slowdown when spice client no audio enabled

2020-09-13 Thread Volker Rümelin
Am 10.09.20 um 13:17 schrieb zhou qi: > From e8c2e283f0954de255a32ea70d577d5e61992399 Mon Sep 17 00:00:00 2001 > From: Qi Zhou > Date: Thu, 10 Sep 2020 19:09:29 +0800 > Subject: [PATCH] Fix video playback slowdown when spice client no audio > enabled > > You will get video playback slowdown on

Re: [PATCH v8 12/27] gcrypt: test_tls_psk_init should write binary file instead text file.

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/13/20 12:44 AM, Yonggang Luo wrote: > On windows, if open file with "w", it's will automatically convert > "\n" to "\r\n" when writing to file. This is one change. > > Convert unlink to use g_remove. This is another (unrelated) change. We expect patches to be atomic (only one change at a

Re: [PATCH v4 0/9] user-mode: Prune build dependencies (part 2)

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/13/20 3:40 PM, Paolo Bonzini wrote: > On 13/09/20 13:31, Philippe Mathieu-Daudé wrote: >>> I'm not sure about the first. It's a bit ugly to have a property whose >>> getter aborts. >> This is (IIUC) the change Markus requested in v3 (see [*]). >> >> Commit description: "add a stub to satisfy

[PATCH v5 6/9] scsi/scsi-bus: scsi_device_find: don't return unrealized devices

2020-09-13 Thread Maxim Levitsky
The device core first places a device on the bus and then realizes it. Make scsi_device_find avoid returing such devices to avoid races in drivers that use an iothread (currently virtio-scsi) Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1812399 Suggested-by: Paolo Bonzini

[PATCH v5 3/9] device_core: use drain_call_rcu in in hmp_device_del/qmp_device_add

2020-09-13 Thread Maxim Levitsky
Soon, a device removal might only happen on RCU callback execution, but to avoid chanding HMP semantics, just drain all pending RCU callbacks Signed-off-by: Maxim Levitsky Suggested-by: Stefan Hajnoczi Reviewed-by: Stefan Hajnoczi --- qdev-monitor.c | 22 ++ 1 file

[PATCH v5 0/9] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

2020-09-13 Thread Maxim Levitsky
Hi! This is a patch series that is a result of my discussion with Paulo on how to correctly fix the root cause of the BZ #1812399. The root cause of this bug is the fact that IO thread is running mostly unlocked versus main thread on which device hotplug is done. qdev_device_add first creates

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

2020-09-13 Thread Yonggang Luo
On Sun, Sep 13, 2020 at 11:35 PM Philippe Mathieu-Daudé wrote: > On 9/13/20 12:44 AM, Yonggang Luo wrote: > > On windows, a difference in line endings causes testsuite failures > > complaining that every single line in files such as > > 'tests/qapi-schemadoc-good.texi' is wrong. Fix it by

[PATCH 1/3] configure: quote command line arguments in config.status

2020-09-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 53723ace57..beae010e39 100755 --- a/configure +++ b/configure @@ -89,6 +89,10 @@ printf " '%s'" "$0" "$@" >> config.log echo >> config.log echo "#" >>

[RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-13 Thread Paolo Bonzini
Right now meson_options.txt lists less than a dozen options, but about 40 more could come as configure tests are converted and moved to meson.build. Each option needs code in configure to parse it and pass the option down to Meson as a -D command-line argument; in addition the default must be

[PATCH 2/3] configure: early test for Python

2020-09-13 Thread Paolo Bonzini
--- configure | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/configure b/configure index beae010e39..b4f5d2e272 100755 --- a/configure +++ b/configure @@ -1631,6 +1631,23 @@ for opt do esac done +if test -n "$python" +then +#

Re: [PATCH v2 2/2] hw/timer/hpet: Fix DPRINTF format string

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/12/20 7:40 PM, Dov Murik wrote: > Hi Phil, > > On 10/09/2020 16:58, Philippe Mathieu-Daudé wrote: >> Fix building with HPET_DEBUG enabled: >> >>    hw/timer/hpet.c:512:73: error: format specifies type 'unsigned int' >> but the argument has type 'uint64_t' (aka 'unsigned long') >>

Re: [PATCH 0/2] hw/timer/hpet: Fix compiler errors with -DHPET_DEBUG

2020-09-13 Thread Philippe Mathieu-Daudé
Cc'ing qemu-trivial@ On 9/10/20 2:53 PM, Dov Murik wrote: > On 09/09/2020 20:24, Philippe Mathieu-Daudé wrote: >> On 9/9/20 10:36 AM, Dov Murik wrote: >>> Fix several compiler errors when compiling withe -DHPET_DEBUG. >>> >>> Steps to reproduce the issue: >>> >>> mkdir build >>> cd

[PATCH v5 7/9] scsi/scsi_bus: Add scsi_device_get

2020-09-13 Thread Maxim Levitsky
Add scsi_device_get which finds the scsi device and takes a reference to it. Suggested-by: Stefan Hajnoczi Signed-off-by: Maxim Levitsky --- hw/scsi/scsi-bus.c | 22 +- include/hw/scsi/scsi.h | 1 + 2 files changed, 18 insertions(+), 5 deletions(-) diff --git

[PATCH v5 9/9] scsi/scsi_bus: fix races in REPORT LUNS

2020-09-13 Thread Maxim Levitsky
Currently scsi_target_emulate_report_luns iterates over the child device list twice, and there is no guarantee that this list is the same in both iterations. The reason for iterating twise is that the first iteration calculates how much memory to allocate. However if we use a dynamic array we

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

2020-09-13 Thread Yonggang Luo
On Sun, Sep 13, 2020 at 10:08 PM Paolo Bonzini wrote: > On 13/09/20 00:44, Yonggang Luo wrote: > > This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. > > > > The --ninja option doesn't need anymore because of upgrade meson to > 0.55.2 > > At that version we can use ninjatool > > We

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

2020-09-13 Thread Yonggang Luo
On Mon, Sep 14, 2020 at 12:12 AM Paolo Bonzini wrote: > On 13/09/20 18:03, 罗勇刚(Yonggang Luo) wrote: > > > > _WIN32 are more precise and only depends on the compiler, on the > > other hand, CONFIG_POSIX and CONFIG_WIN32 need configure > > scripts. I prefer _WIN32 unless the compiler can not

[PATCH v3 00/15] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-09-13 Thread Dmitry Fomichev
v2 -> v3: - Moved nvme_fill_data() function to the NSTypes patch as it is now used there to output empty namespace identify structs. - Fixed typo in Maxim's email address. v1 -> v2: - Rebased on top of qemu-nvme/next branch. - Incorporated feedback from Klaus and Alistair. - Dropped

[PATCH v3 01/15] hw/block/nvme: Define 64 bit cqe.result

2020-09-13 Thread Dmitry Fomichev
From: Ajay Joshi A new write command, Zone Append, is added as a part of Zoned Namespace Command Set. Upon successful completion of this command, the controller returns the start LBA of the performed write operation in cqe.result field. Therefore, the maximum size of this variable needs to be

[PATCH v3 08/15] hw/block/nvme: Make Zoned NS Command Set definitions

2020-09-13 Thread Dmitry Fomichev
Define values and structures that are needed to support Zoned Namespace Command Set (NVMe TP 4053) in PCI NVMe controller emulator. All new protocol definitions are located in include/block/nvme.h and everything added that is specific to this implementation is kept in hw/block/nvme.h. In order

[PATCH v3 12/15] hw/block/nvme: Support Zone Descriptor Extensions

2020-09-13 Thread Dmitry Fomichev
Zone Descriptor Extension is a label that can be assigned to a zone. It can be set to an Empty zone and it stays assigned until the zone is reset. This commit adds a new optional module property, "zone_descr_ext_size". Its value must be a multiple of 64 bytes. If this value is non-zero, it

[PATCH v3 07/15] hw/block/nvme: Add support for active/inactive namespaces

2020-09-13 Thread Dmitry Fomichev
From: Niklas Cassel In NVMe, a namespace is active if it exists and is attached to the controller. CAP.CSS (together with the I/O Command Set data structure) defines what command sets are supported by the controller. CC.CSS (together with Set Profile) can be set to enable a subset of the

[PATCH v3 11/15] hw/block/nvme: Introduce max active and open zone limits

2020-09-13 Thread Dmitry Fomichev
Added two module properties, "max_active" and "max_open" to control the maximum number of zones that can be active or open. Once these variables are set to non-default values, these limits are checked during I/O and Too Many Active or Too Many Open command status is returned if they are exceeded.

[PATCH v3 13/15] hw/block/nvme: Add injection of Offline/Read-Only zones

2020-09-13 Thread Dmitry Fomichev
ZNS specification defines two zone conditions for the zones that no longer can function properly, possibly because of flash wear or other internal fault. It is useful to be able to "inject" a small number of such zones for testing purposes. This commit defines two optional device properties,

[PATCH 03/11] disas: Move host asm annotations to tb_gen_code

2020-09-13 Thread Richard Henderson
Instead of creating GStrings and passing them into log_disas, just print the annotations directly in tb_gen_code. Fix the annotations for the slow paths of the TB, after the part implementing the final guest instruction. Signed-off-by: Richard Henderson --- include/disas/disas.h | 2 +-

[PATCH 00/11] capstone + disassembler patches

2020-09-13 Thread Richard Henderson
The primary change here is the update for capstone to meson. This bypasses capstone's build system entirely. There's more commentary on that subject with the first patch. Plus a collection of other fixes and cleanups in the area. There are a couple of other targets that could use capstone: The

[PATCH 11/11] disas: Enable capstone disassembly for sparc

2020-09-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- disas.c| 2 ++ target/sparc/cpu.c | 4 meson.build| 10 ++ 3 files changed, 16 insertions(+) diff --git a/disas.c b/disas.c index 5e943181d8..b71d06d890 100644 --- a/disas.c +++ b/disas.c @@ -196,6 +196,8 @@ static void

[PATCH 07/11] disas: Configure capstone for aarch64 host without libvixl

2020-09-13 Thread Richard Henderson
The ifdef tangle failed to set cap_arch if libvixl itself was not configured (e.g. due to lack of c++ compiler). Signed-off-by: Richard Henderson --- disas.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/disas.c b/disas.c index ed9965c32f..5d81403125 100644 ---

[PATCH 01/11] capstone: Convert Makefile bits to meson bits

2020-09-13 Thread Richard Henderson
There are better ways to do this, e.g. meson cmake subproject, but that requires cmake 3.7 and some of our CI environments only provide cmake 3.5. Nor can we add a meson.build file to capstone/, because the git submodule would then always report "untracked files". Fixing that would require

[PATCH 05/11] disas: Use qemu/bswap.h for bfd endian loads

2020-09-13 Thread Richard Henderson
Use the routines we have already instead of open-coding. Signed-off-by: Richard Henderson --- include/disas/dis-asm.h | 32 disas.c | 55 - 2 files changed, 27 insertions(+), 60 deletions(-) diff --git

Re: [PATCH resend] configure: actually disable 'git_update' mode with --disable-git-update

2020-09-13 Thread Philippe Mathieu-Daudé
Cc'ing Daniel as this is related to 'GIT submodules' which he maintains: $ scripts/get_maintainer.pl -f scripts/git-submodule.sh "Daniel P. Berrangé" (odd fixer:GIT submodules) On 9/13/20 8:57 PM, Dan Streetman wrote: > The --disable-git-update configure param sets git_update=no, but > some

Re: [PULL 00/30] riscv-to-apply queue

2020-09-13 Thread Peter Maydell
On Thu, 10 Sep 2020 at 19:20, Alistair Francis wrote: > > The following changes since commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a: > > Merge remote-tracking branch > 'remotes/kraxel/tags/sirius/ipxe-20200908-pull-request' into staging > (2020-09-08 21:21:13 +0100) > > are available in the

[REPORT] Nightly Performance Tests - Sunday, September 13, 2020

2020-09-13 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-09-13 21:35:01 End Time (UTC) : 2020-09-13 22:07:44 Execution Time : 0:32:42.230467 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%.

[PATCH v3 03/15] hw/block/nvme: Add Commands Supported and Effects log

2020-09-13 Thread Dmitry Fomichev
This log page becomes necessary to implement to allow checking for Zone Append command support in Zoned Namespace Command Set. This commit adds the code to report this log page for NVM Command Set only. The parts that are specific to zoned operation will be added later in the series.

[PATCH v3 09/15] hw/block/nvme: Define Zoned NS Command Set trace events

2020-09-13 Thread Dmitry Fomichev
The Zoned Namespace Command Set / Namespace Types implementation that is being introduced in this series adds a good number of trace events. Combine all tracepoint definitions into a separate patch to make reviewing more convenient. Signed-off-by: Dmitry Fomichev --- hw/block/trace-events | 26

[PATCH v3 02/15] hw/block/nvme: Report actual LBA data shift in LBAF

2020-09-13 Thread Dmitry Fomichev
Calculate the data shift value to report based on the set value of logical_block_size device property. In the process, use a local variable to calculate the LBA format index instead of the hardcoded value 0. This makes the code more readable and it will make it easier to add support for multiple

[PATCH v3 04/15] hw/block/nvme: Introduce the Namespace Types definitions

2020-09-13 Thread Dmitry Fomichev
From: Niklas Cassel Define the structures and constants required to implement Namespace Types support. Signed-off-by: Niklas Cassel Signed-off-by: Dmitry Fomichev --- hw/block/nvme.c | 2 +- hw/block/nvme.h | 3 ++ include/block/nvme.h | 74

[PATCH v3 10/15] hw/block/nvme: Support Zoned Namespace Command Set

2020-09-13 Thread Dmitry Fomichev
The emulation code has been changed to advertise NVM Command Set when "zoned" device property is not set (default) and Zoned Namespace Command Set otherwise. Handlers for three new NVMe commands introduced in Zoned Namespace Command Set specification are added, namely for Zone Management Receive,

[PATCH v3 14/15] hw/block/nvme: Use zone metadata file for persistence

2020-09-13 Thread Dmitry Fomichev
A ZNS drive that is emulated by this module is currently initialized with all zones Empty upon startup. However, actual ZNS SSDs save the state and condition of all zones in their internal NVRAM in the event of power loss. When such a drive is powered up again, it closes or finishes all zones that

[PATCH v3 06/15] hw/block/nvme: Add support for Namespace Types

2020-09-13 Thread Dmitry Fomichev
From: Niklas Cassel Namespace Types introduce a new command set, "I/O Command Sets", that allows the host to retrieve the command sets associated with a namespace. Introduce support for the command set and enable detection for the NVM Command Set. The new workflows for identify commands rely

[PATCH v3 15/15] hw/block/nvme: Document zoned parameters in usage text

2020-09-13 Thread Dmitry Fomichev
Added brief descriptions of the new device properties that are now available to users to configure features of Zoned Namespace Command Set in the emulator. This patch is for documentation only, no functionality change. Signed-off-by: Dmitry Fomichev --- hw/block/nvme.c | 43

[PATCH v3 05/15] hw/block/nvme: Define trace events related to NS Types

2020-09-13 Thread Dmitry Fomichev
A few trace events are defined that are relevant to implementing Namespace Types (NVMe TP 4056). Signed-off-by: Dmitry Fomichev Reviewed-by: Klaus Jensen --- hw/block/trace-events | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/block/trace-events b/hw/block/trace-events

[PATCH] hw/scsi/vmw_pvscsi.c: Fix wrong usage of gboolean types in PVSCSIState

2020-09-13 Thread Amey Narkhede
rings_info_valid, msg_ring_info_valid and use_msg fields of struct PVSCSIState are using gboolean TRUE/FALSE values with the type uint8_t. Change their type to bool along with the usage of initialization macro VMSTATE_BOOL during initialization of vmstate_pvscsi and pvscsi_properties.

[PATCH 09/11] disas: Enable capstone disassembly for s390x

2020-09-13 Thread Richard Henderson
Enable s390x, aka SYSZ, in the git submodule build. Set the capstone parameters for both s390x host and guest. Signed-off-by: Richard Henderson --- disas.c| 3 +++ target/s390x/cpu.c | 4 meson.build| 11 +++ 3 files changed, 18 insertions(+) diff --git

[PATCH 02/11] capstone: Update to upstream "next" branch

2020-09-13 Thread Richard Henderson
This branch contains a number of improvements over master, including making all of the disassembler data constant. We are skipping past the 4.0 branchpoint, which changed the location of the includes within the source directory. Signed-off-by: Richard Henderson --- capstone| 2 +-

Re: [PATCH v7 03/25] block: Fixes nfs compiling error on msys2/mingw

2020-09-13 Thread Peter Lieven
> Am 10.09.2020 um 22:36 schrieb 罗勇刚(Yonggang Luo) : > >  > > >> On Fri, Sep 11, 2020 at 4:16 AM Peter Lieven wrote: >> >> >>> Am 10.09.2020 um 12:30 schrieb Yonggang Luo : >>> >>> These compiling errors are fixed: >>> ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory

Re: [PATCH v8 02/27] block: Fixes nfs compiling error on msys2/mingw

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/13/20 6:00 PM, 罗勇刚(Yonggang Luo) wrote: > > > On Sun, Sep 13, 2020 at 11:47 PM Philippe Mathieu-Daudé > mailto:phi...@redhat.com>> wrote: > > On 9/13/20 12:44 AM, Yonggang Luo wrote: > > These compiling errors are fixed: > > ../block/nfs.c:27:10: fatal error: poll.h: No such

[Bug 1895471] [NEW] compilation error with clang in util/async.c

2020-09-13 Thread Amey Narkhede
Public bug reported: configured with ` CC=clang CXX=clang++ ../configure --target- list=x86_64-softmmu --enable-kvm --enable-curl --enable-debug --enable- jemalloc --enable-fuzzing --enable-sdl` and after make I get the following error related to c11 atomics. I'm using clang because I'm

Re: [PULL 00/10] testing and other mix fixes

2020-09-13 Thread Peter Maydell
On Thu, 10 Sep 2020 at 14:15, Alex Bennée wrote: > > The following changes since commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a: > > Merge remote-tracking branch > 'remotes/kraxel/tags/sirius/ipxe-20200908-pull-request' into staging > (2020-09-08 21:21:13 +0100) > > are available in the Git

[PATCH v5 0/8] user-mode: Prune build dependencies (part 2)

2020-09-13 Thread Philippe Mathieu-Daudé
This is the second part of a series reducing user-mode dependencies. By stripping out unused code, the build and testing time is reduced (as is space used by objects). Series is fully Acked. Part 2: - Extract code not related to user-mode from qapi/misc.json Since v4: - Rebased on "QOM

[PATCH v5 6/8] qapi: Restrict device memory commands to machine code

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Restricting the memory commands to machine.json allows pulling less declarations/definitions to user-mode. Acked-by: Igor Mammedov Acked-by:

[PATCH v5 7/8] qapi: Extract ACPI commands to 'acpi.json'

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Extracting the ACPI commands to their own schema reduces the size of the qapi-misc* headers generated, and allows pulling less

RE: [PATCH v1 2/2] colo-compare: Record packet creation time by QEMU_CLOCK_REALTIME

2020-09-13 Thread Zhang, Chen
> -Original Message- > From: Zhang, Chen > Sent: Monday, September 14, 2020 4:02 AM > To: 'Derek Su' ; qemu-devel@nongnu.org > Cc: lizhij...@cn.fujitsu.com; jasow...@redhat.com > Subject: RE: [PATCH v1 2/2] colo-compare: Record packet creation time by > QEMU_CLOCK_REALTIME > > > > >

[Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-13 Thread Petunia
Mhm, that doesnt work for me. My output is unchanged... file /mnt/usr/bin/qemu-arm-* /mnt/usr/bin/qemu-arm-org:ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, stripped /mnt/usr/bin/qemu-arm-static: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux),

[Bug 1717414] Re: Sending certain keysyms results in wrong symbol input

2020-09-13 Thread Iordan Iordanov
Seems to work fine now. Thank you!! iordan -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1717414 Title: Sending certain keysyms results in wrong symbol input Status in QEMU: Incomplete Bug

[Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-13 Thread Laurent Vivier
Normally, they are on the standard output, something like: $ sudo systemd-nspawn -D root --boot Spawning container root on /mnt. Press ^] three times within 1s to kill container. 1 brk(NULL) = 0x4013f000 1 uname(0x3a00) = 0 1 access("/etc/ld.so.preload",R_OK) = 0 1

[PATCH resend] configure: actually disable 'git_update' mode with --disable-git-update

2020-09-13 Thread Dan Streetman
The --disable-git-update configure param sets git_update=no, but some later checks only look for the .git dir. This changes the --enable-git-update to set git_update=yes but also fail if it does not find a .git dir. Then all the later checks for the .git dir can just be changed to a check for

[PATCH v5 8/8] qapi: Extract PCI commands to 'pci.json'

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Extracting the PCI commands to their own schema reduces the size of the qapi-misc* headers generated, and allows pulling less

RE: [PATCH v1 2/2] colo-compare: Record packet creation time by QEMU_CLOCK_REALTIME

2020-09-13 Thread Zhang, Chen
> -Original Message- > From: Derek Su > Sent: Saturday, September 12, 2020 3:05 AM > To: qemu-devel@nongnu.org > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; Derek Su > Subject: [PATCH v1 2/2] colo-compare: Record packet creation time by > QEMU_CLOCK_REALTIME >

RE: [PATCH v1 1/2] colo-compare: Fix incorrect data type conversion

2020-09-13 Thread Zhang, Chen
> -Original Message- > From: Derek Su > Sent: Saturday, September 12, 2020 3:05 AM > To: qemu-devel@nongnu.org > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; Derek Su > Subject: [PATCH v1 1/2] colo-compare: Fix incorrect data type conversion > > Fix data type

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/13/20 6:01 PM, 罗勇刚(Yonggang Luo) wrote: > > > On Sun, Sep 13, 2020 at 11:35 PM Philippe Mathieu-Daudé > mailto:phi...@redhat.com>> wrote: > > On 9/13/20 12:44 AM, Yonggang Luo wrote: > > On windows, a difference in line endings causes testsuite failures > > complaining that

[PATCH v5 1/8] qapi: Restrict LostTickPolicy enum to machine code

2020-09-13 Thread Philippe Mathieu-Daudé
Acked-by: Markus Armbruster Acked-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json| 32 qapi/misc.json | 32 include/hw/rtc/mc146818rtc.h | 2 +- hw/core/qdev-properties.c

[PATCH v5 2/8] qapi: Correct balloon documentation

2020-09-13 Thread Philippe Mathieu-Daudé
The documentation incorrectly uses the "size of the balloon" description when it should be "logical size of the VM". Fix it. The relation between both values is: logical_vm_size = vm_ram_size - balloon_size Reported-by: David Hildenbrand Suggested-by: David Hildenbrand Reviewed-by: David

[PATCH v5 3/8] qapi: Restrict balloon-related commands to machine code

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Restricting the balloon-related commands to machine.json allows pulling less declarations/definitions to user-mode. Reviewed-by: David

[PATCH v5 5/8] qapi: Restrict query-uuid command to machine code

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Restricting the query-uuid command to machine.json allows pulling less declarations/definitions to user-mode. Acked-by: Markus Armbruster

[PATCH v5 4/8] qapi: Restrict query-vm-generation-id command to machine code

2020-09-13 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Restricting the query-vm-generation-id command to machine.json allows pulling less declarations/definitions to user-mode. Acked-by: Igor Mammedov

Re: [PATCH V2 00/10] fix some comment spelling errors

2020-09-13 Thread zhaolichang
ping

Re: Moving to C11? (was Re: Redefinition of typedefs (C11 feature))

2020-09-13 Thread Thomas Huth
On 13/09/2020 04.51, Eduardo Habkost wrote: > On Sat, Sep 12, 2020 at 08:45:19AM +0200, Thomas Huth wrote: >> On 11/09/2020 22.06, Eduardo Habkost wrote: >>> On Fri, Sep 11, 2020 at 08:06:10PM +0100, Peter Maydell wrote: On Fri, 11 Sep 2020 at 19:49, Eduardo Habkost wrote: > > I'm

Re: [PULL v2] Block layer patches

2020-09-13 Thread Thomas Huth
On 12/09/2020 20.38, Peter Maydell wrote: > On Sat, 12 Sep 2020 at 13:27, Thomas Huth wrote: >> Peter, why did this slip through your merge tests, do you still skip the >> iotests there? > > I forget what the reason for them being skipped is, maybe > it's because they demand a gnu sed ? The

Re: [PATCH 05/11] disas: Use qemu/bswap.h for bfd endian loads

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/14/20 2:01 AM, Richard Henderson wrote: > Use the routines we have already instead of open-coding. Yay \o/ Reviewed-by: Philippe Mathieu-Daudé > > Signed-off-by: Richard Henderson > --- > include/disas/dis-asm.h | 32 > disas.c | 55

Re: [PATCH 10/11] disas/capstone: Add skipdata hook for s390x

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/14/20 2:01 AM, Richard Henderson wrote: > It is always possible to tell the length of an insn, even if the > actual insn is unknown. Skip the correct number of bytes, so that > we stay in sync with the instruction stream. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe

Re: qemu disassembler status

2020-09-13 Thread Richard Henderson
On 9/12/20 12:03 AM, Thomas Huth wrote: > Is capstone good enough already to replace libvixl? Yes as far as the version that we currently have imported, but no if we were to update vixl. In particular, capstone has no support for SVE or other v8.2+ additions. > And what about the other old

Re: [PATCH v1 1/2] colo-compare: Fix incorrect data type conversion

2020-09-13 Thread Derek Su
Hi, Chen Got it, thank you :) Regards, Derek Zhang, Chen 於 2020年9月14日 週一,上午4:02寫道: > > > > > > -Original Message- > > > From: Derek Su > > > Sent: Saturday, September 12, 2020 3:05 AM > > > To: qemu-devel@nongnu.org > > > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; > > >

Re: [PATCH v1 2/2] colo-compare: Record packet creation time by QEMU_CLOCK_REALTIME

2020-09-13 Thread Derek Su
Zhang, Chen 於 2020年9月14日 週一,上午4:06寫道: > > > > > > -Original Message- > > > From: Zhang, Chen > > > Sent: Monday, September 14, 2020 4:02 AM > > > To: 'Derek Su' ; qemu-devel@nongnu.org > > > Cc: lizhij...@cn.fujitsu.com; jasow...@redhat.com > > > Subject: RE: [PATCH v1 2/2] colo-compare:

Re: [PATCH 01/11] capstone: Convert Makefile bits to meson bits

2020-09-13 Thread Richard Henderson
On 9/13/20 5:01 PM, Richard Henderson wrote: > case "$capstone" in > - git | internal) > + git) > if test "$capstone" = git; then >git_submodules="${git_submodules} capstone" > fi The if here can be removed now. Alternately... > -mkdir -p capstone > -if test

[PATCH] lockable.h: always define unknown_lock_type

2020-09-13 Thread mingli.yu
From: Mingli Yu There comes below build failure when use gcc 10.1.0 and "-Og" passed to compiler. | /usr/lib/gcc/x86_64-wrs-linux/10.1.0/../../../../x86_64-wrs-linux/bin/ld.bfd: /mnt/build/tmp/work/x86_64-linux/qemu-system-native/5.1.0-r0/qemu-5.1.0/fsdev/qemu-fsdev-throttle.c:25: undefined

[PULL 4/4] qga: add command guest-get-devices for reporting VirtIO devices

2020-09-13 Thread Michael Roth
From: Tomáš Golembiovský Add command for reporting devices on Windows guest. The intent is not so much to report the devices but more importantly the driver (and its version) that is assigned to the device. This gives caller the information whether VirtIO drivers are installed and/or whether

Re: [PATCH] lockable.h: always define unknown_lock_type

2020-09-13 Thread Richard Henderson
On 9/13/20 6:42 PM, mingli...@windriver.com wrote: > From: Mingli Yu > > There comes below build failure when use gcc 10.1.0 and > "-Og" passed to compiler. > | > /usr/lib/gcc/x86_64-wrs-linux/10.1.0/../../../../x86_64-wrs-linux/bin/ld.bfd: >

  1   2   >