Re: [PATCH] meson: Fixes curses detection on msys2

2020-11-18 Thread Paolo Bonzini
On 16/11/20 22:31, Yonggang Luo wrote: Fixes regression on curses detection in msys2 by commit#925a40df2828d32d3aaaf022282cba81082fb263 Signed-off-by: Yonggang Luo --- meson.build | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build

Re: [PATCH for-5.2] docs: Fix some typos (found by codespell)

2020-11-18 Thread Paolo Bonzini
On 17/11/20 20:34, Stefan Weil wrote: Fix also a similar typo in a code comment. Signed-off-by: Stefan Weil --- docs/can.txt | 8 docs/interop/vhost-user.rst | 2 +- docs/replay.txt | 2 +- docs/specs/ppc-spapr-numa.rst | 2 +-

[PATCH v2 06/27] failover: Remove external partially_hotplugged property

2020-11-18 Thread Juan Quintela
It was only set "once", and with the wrong value. As far as I can see, libvirt still don't use it. Signed-off-by: Juan Quintela --- hw/net/virtio-net.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 3f658d6246..6ca85627d8 100644 ---

[PATCH v2 04/27] failover: primary bus is only used once, and where it is set

2020-11-18 Thread Juan Quintela
Just remove the struct member. Signed-off-by: Juan Quintela --- include/hw/virtio/virtio-net.h | 1 - hw/net/virtio-net.c| 8 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h index

Re: [PATCH v3] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

2020-11-18 Thread Stefan Hajnoczi
On Tue, Nov 17, 2020 at 02:41:31PM -0500, Vivek Goyal wrote: > This is V3 of the patch. A minor change since V2 is to reverse the list > before executing requests. We are prepending elements to the list and that > means when we start processing requests, we are processing these in > the reverse

[PATCH v2 16/27] failover: Rename function to hide_device()

2020-11-18 Thread Juan Quintela
You should not use pasive. Signed-off-by: Juan Quintela --- include/hw/qdev-core.h | 28 +++- hw/core/qdev.c | 4 ++-- hw/net/virtio-net.c| 7 +++ 3 files changed, 20 insertions(+), 19 deletions(-) diff --git a/include/hw/qdev-core.h

Re: [PATCH 00/10] vhost/qemu: thread per IO SCSI vq

2020-11-18 Thread Michael S. Tsirkin
On Tue, Nov 17, 2020 at 01:13:14PM -0600, Mike Christie wrote: > On 11/17/20 10:40 AM, Stefan Hajnoczi wrote: > > On Thu, Nov 12, 2020 at 05:18:59PM -0600, Mike Christie wrote: > >> The following kernel patches were made over Michael's vhost branch: > >> > >>

[PULL 6/7] hvf: Fix segment selector format

2020-11-18 Thread Paolo Bonzini
From: Jessica Clarke The Requested Privilege Level field is 2 bits, the Table Indicator field is 1 bit and the Index field is the remaining 15 bits, with TI=0 meaning GDT and TI=1 meaning LDT. Signed-off-by: Jessica Clarke Message-Id: <20201116200414.28286-1-jrt...@jrtc27.com> Signed-off-by:

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-18 Thread Cornelia Huck
On Wed, 18 Nov 2020 10:38:00 +0100 Thomas Huth wrote: > On 18/11/2020 09.51, Cornelia Huck wrote: > > The zPCI group and function structures are big endian. However, we do > > not consistently store them as big endian locally, and are missing some > > conversions. > > > > Let's just store the

[RFC v3 9/9] i386: split cpu accelerators from cpu.c

2020-11-18 Thread Claudio Fontana
split cpu.c into: cpu.ccpuid and common x86 cpu functionality host-cpu.c host x86 cpu functions and "host" cpu type kvm/cpu.cKVM x86 cpu type hvf/cpu.cHVF x86 cpu type tcg/cpu.cTCG x86 cpu type The accel interface of the X86CPUClass is set at

[RFC v3 5/9] i386: move TCG accel files into tcg/

2020-11-18 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- target/i386/meson.build | 14 +- target/i386/{ => tcg}/bpt_helper.c | 0 target/i386/{ => tcg}/cc_helper.c | 0 target/i386/{ => tcg}/excp_helper.c | 0 target/i386/{ => tcg}/fpu_helper.c | 0 target/i386/{ => tcg}/int_helper.c

[RFC v3 1/9] i386: move kvm accel files into kvm/

2020-11-18 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- MAINTAINERS | 2 +- hw/i386/fw_cfg.c | 2 +- hw/i386/intel_iommu.c| 2 +- hw/i386/kvm/apic.c | 2 +- hw/i386/kvm/clock.c | 2 +- hw/i386/microvm.c

[PATCH 4/7] Implementation of write-tracking migration thread.

2020-11-18 Thread Andrey Gruzdev via
Signed-off-by: Andrey Gruzdev --- migration/migration.c | 174 +- migration/migration.h | 3 + migration/savevm.c| 1 - migration/savevm.h| 2 + 4 files changed, 177 insertions(+), 3 deletions(-) diff --git a/migration/migration.c

[PATCH 7/7] Introduced simple linear scan rate limiting mechanism for write tracking migration.

2020-11-18 Thread Andrey Gruzdev via
Since reading UFFD events and saving paged data are performed from the same thread, write fault latencies are sensitive to migration stream stalls. Limiting total page saving rate is a method to reduce amount of noticiable fault resolution latencies. Migration bandwidth limiting is achieved via

[Bug 1680991] Re: raspi2: system timer device not implemented

2020-11-18 Thread Philippe Mathieu-Daudé
The timer has been implemented, see commits: d05be883fc9 ("hw/timer/bcm2835: Add the BCM2835 SYS_timer") 0e5bbd74064 ("hw/arm/bcm2835_peripherals: Use the SYS_timer") 722bde6789c ("hw/arm/bcm2835_peripherals: Correctly wire the SYS_timer IRQs") Running the attached test with "-trace

[PATCH 3/7] Support UFFD write fault processing in ram_save_iterate().

2020-11-18 Thread Andrey Gruzdev via
In this particular implementation the same single migration thread is responsible for both normal linear dirty page migration and procesing UFFD page fault events. Processing write faults includes reading UFFD file descriptor, finding respective RAM block and saving faulting page to the migration

Re: Property '.hmat' not found

2020-11-18 Thread Eduardo Habkost
On Wed, Nov 18, 2020 at 06:16:36PM +0800, 郭俊甫 (Jack Kuo) wrote: > > > > Could you check what happens if you use > > "-machine pc-i440fx-5.2,hmat=on" instead of "-machine hmat=on"? > > > It failed, but `-machine pc-i440fx-4.2` worked without `hmat` option. > So, the problem could be that I didn't

[PULL 1/4] authz-list-file: Fix file read error handling

2020-11-18 Thread Daniel P . Berrangé
From: Markus Armbruster The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call.

[PULL 0/4] Misc fixes patches

2020-11-18 Thread Daniel P . Berrangé
The following changes since commit 66a300a107ec286725bdc943601cbd4247b82158: Update version for v5.2.0-rc2 release (2020-11-17 22:58:10 +) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/misc-fixes-pull-request for you to fetch changes up to

[PATCH v1 1/7] Introduce 'track-writes-ram' migration capability.

2020-11-18 Thread Andrey Gruzdev via
Signed-off-by: Andrey Gruzdev --- migration/migration.c | 96 +++ migration/migration.h | 1 + qapi/migration.json | 7 +++- 3 files changed, 103 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index

[PATCH 0/2] libvhost-user: lower dependency on QEMU headers

2020-11-18 Thread marcandre . lureau
From: Marc-André Lureau Hi, libvhost-user is meant to be free of glib dependency, and easily copyable/reusable outside of QEMU. Clean-up some dependencies that crept in recently (the one remaining is qemu/atomic.h, from which a subset is used) Marc-André Lureau (2): libvhost-user: replace

[PATCH] dbus-vmstate: replace g_return with error handling

2020-11-18 Thread marcandre . lureau
From: Marc-André Lureau Since g_input_stream_read_all() may return less than requested when the stream is malformed, we should treat this condition as a runtime user error (g_return are for programming errors). Signed-off-by: Marc-André Lureau --- backends/dbus-vmstate.c | 5 - 1 file

[PATCH v2 02/27] failover: fix indentantion

2020-11-18 Thread Juan Quintela
Once there, remove not needed cast. Signed-off-by: Juan Quintela --- hw/net/virtio-net.c| 33 +++-- softmmu/qdev-monitor.c | 4 ++-- 2 files changed, 17 insertions(+), 20 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index

[PATCH v2 10/27] failover: Remove primary_device_opts

2020-11-18 Thread Juan Quintela
It was really only used once, in failover_add_primary(). Just search for it on global opts when it is needed. Signed-off-by: Juan Quintela --- include/hw/virtio/virtio-net.h | 1 - hw/net/virtio-net.c| 21 + 2 files changed, 5 insertions(+), 17 deletions(-)

[PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-18 Thread Thomas Huth
Both headers, sysbus.h and module.h, are not required to compile this file. Signed-off-by: Thomas Huth --- hw/watchdog/wdt_diag288.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/watchdog/wdt_diag288.c b/hw/watchdog/wdt_diag288.c index 71a945f0bd..4c4b6a6ab7 100644 ---

[PULL 0/7] HVF and Windows changes for QEMU 5.2-rc

2020-11-18 Thread Paolo Bonzini
The following changes since commit 66a300a107ec286725bdc943601cbd4247b82158: Update version for v5.2.0-rc2 release (2020-11-17 22:58:10 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to

[PULL 3/7] meson: Fix build with --disable-guest-agent-msi

2020-11-18 Thread Paolo Bonzini
From: Stefan Weil The QGA MSI target requires several macros which are only available without --disable-guest-agent-msi. Don't define that target if configure was called with --disable-guest-agent-msi. Signed-off-by: Stefan Weil Message-Id: <20201117201834.408892-1...@weilnetz.de>

[PULL 7/7] buildsys: Help git-diff adding .gitattributes config file

2020-11-18 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Since commits 0979ed017f0 ("meson: rename .inc.h files to .h.inc") and 139c1837db7 ("meson: rename included C source files to .c.inc") 'git-diff --function-context' stopped displaying C function context correctly. We can help git-diff by providing attributes to the

[PULL 1/7] meson: Fix argument for makensis (build regression)

2020-11-18 Thread Paolo Bonzini
From: Stefan Weil `make installer` with a DLL directory was broken. Signed-off-by: Stefan Weil Message-Id: <20201117190640.390359-1...@weilnetz.de> Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- scripts/nsis.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Bug 1837651] Re: -netdev socket uses 100% cpu on Windows host

2020-11-18 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2020-11-18 Thread Thomas Huth
Patch had been merged here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=86dbcdd9c7590d06db89ca ... thus closing this ticket now. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[PATCH v2 0/5] ARM: reduce the memory consumed when mapping UEFI flash images

2020-11-18 Thread David Edmondson
Currently ARM UEFI images are built as 2MB/768kB flash images for code and variables respectively. These images are both then padded out to 64MB before being loaded by QEMU. Because the images are 64MB each, QEMU allocates 128MB of memory to read them, and then proceeds to read all 128MB from

[PATCH-for-5.2? 2/2] tests/qtest: fix memleak in npcm7xx_watchdog_timer-test

2020-11-18 Thread Chen Qun
Properly free resp for get_watchdog_action() to avoid memory leak. ASAN shows memory leak stack: Indirect leak of 12360 byte(s) in 3 object(s) allocated from: #0 0x7f41ab6cbd4e in __interceptor_calloc (/lib64/libasan.so.5+0x112d4e) #1 0x7f41ab4eaa50 in g_malloc0

[PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized

2020-11-18 Thread Chen Qun
According to the glib function requirements, we need initialise the variable. Otherwise there will be compilation warnings: glib-autocleanups.h:28:3: warning: ‘full_name’ may be used uninitialized in this function [-Wmaybe-uninitialized] 28 | g_free (*pp); | ^~~~

[PATCH-for-5.2? 0/2] two qtest bugfix

2020-11-18 Thread Chen Qun
Hi folks, There are two bug caused by recent testcase code merge. EulerRobot found them, and this series fixed them. Thanks, Chen Qun Chen Qun (2): tests/qtest: variable defined by g_autofree need to be initialized tests/qtest: fix memleak in npcm7xx_watchdog_timer-test

[RFC 08/15] target/riscv: rvb: single-bit instructions

2020-11-18 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng --- target/riscv/insn32-64.decode | 8 ++ target/riscv/insn32.decode | 9 ++ target/riscv/insn_trans/trans_rvb.c.inc | 90 ++ target/riscv/translate.c| 155 4 files

[RFC 07/15] target/riscv: rvb: sign-extend instructions

2020-11-18 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng --- target/riscv/insn32.decode | 2 ++ target/riscv/insn_trans/trans_rvb.c.inc | 13 + 2 files changed, 15 insertions(+) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 372476f1d2c..626641333c6

[RFC 10/15] target/riscv: rvb: rotate (left/right)

2020-11-18 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32-64.decode | 3 ++ target/riscv/insn32.decode | 3 ++ target/riscv/insn_trans/trans_rvb.c.inc | 54 + target/riscv/translate.c| 48

[RFC 14/15] target/riscv: rvb: add/sub with postfix zero-extend

2020-11-18 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng --- target/riscv/insn32-64.decode | 7 + target/riscv/insn_trans/trans_rvb.c.inc | 38 + target/riscv/translate.c| 18 3 files changed, 63 insertions(+) diff --git

[Bug 1903470] Re: qemu 5.1.0: Add UNIX socket support for netdev socket

2020-11-18 Thread elmarco
With the fd= argument/property, you can setup a private socketpair connection already. Is this enough? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1903470 Title: qemu 5.1.0: Add UNIX socket

Should bus-less devices default to .user_creatable = false? (was: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category)

2020-11-18 Thread Markus Armbruster
Markus Armbruster writes: [...] > qdev_device_add() looks like a bus-less device is usable if the machine > provides a hotplug handler for it. Commit 03fcbd9dc5 "qdev: Check for > the availability of a hotplug controller before adding a device" seems > to be pertinent. Nope. A hotplug handler

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-18 Thread Christian Borntraeger
On 18.11.20 10:03, Thomas Huth wrote: > Both headers, sysbus.h and module.h, are not required to compile this file. > > Signed-off-by: Thomas Huth It is not a sysbus device and not a module. Reviewed-by: Christian Borntraeger > --- > hw/watchdog/wdt_diag288.c | 2 -- > 1 file changed, 2

[PATCH 0/4] vhost-user: avoid g_return_val_if() in get/set_config()

2020-11-18 Thread Stefan Hajnoczi
Markus Armbruster pointed out that g_return_val_if() is meant for programming errors. It must not be used for input validation since it can be compiled out. Use explicit if statements instead. This patch series converts vhost-user device backends that use g_return_val_if() in get/set_config().

[Bug 1243968] Re: VMware ESXi on QEmu Kernel Panic

2020-11-18 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[PATCH v2 1/5] hw/block: blk_check_size_and_read_all should report backend name

2020-11-18 Thread David Edmondson
If there are problems examining or reading data from the block backend, the error messages should include an appropriate identifier to assist in diagnoses. Signed-off-by: David Edmondson --- hw/block/block.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v2 3/5] hw/arm: Convert assertions about flash image size to error_report

2020-11-18 Thread David Edmondson
Rather than throwing an assertion, provide a more detailed report if a flash image is inappropriately sized or aligned. Signed-off-by: David Edmondson --- hw/arm/virt.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index

[PATCH 1/7] Introduce 'track-writes-ram' migration capability.

2020-11-18 Thread Andrey Gruzdev via
Signed-off-by: Andrey Gruzdev --- migration/migration.c | 96 +++ migration/migration.h | 1 + qapi/migration.json | 7 +++- 3 files changed, 103 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index

RE: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized

2020-11-18 Thread Chenqun (kuhn)
> -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Wednesday, November 18, 2020 8:14 PM > To: Chenqun (kuhn) ; qemu-devel@nongnu.org; > qemu-triv...@nongnu.org > Cc: lviv...@redhat.com; peter.mayd...@linaro.org; th...@redhat.com; > Zhanghailiang ; >

[PATCH v1 7/7] Introduced simple linear scan rate limiting mechanism for write tracking migration.

2020-11-18 Thread Andrey Gruzdev via
Since reading UFFD events and saving paged data are performed from the same thread, write fault latencies are sensitive to migration stream stalls. Limiting total page saving rate is a method to reduce amount of noticiable fault resolution latencies. Migration bandwidth limiting is achieved via

[PATCH v1 5/7] Implementation of vm_start() BH.

2020-11-18 Thread Andrey Gruzdev via
To avoid saving updated versions of memory pages we need to start tracking RAM writes before we resume operation of vCPUs. This sequence is especially critical for virtio device backends whos VQs are mapped to main memory and accessed directly not using MMIO callbacks. One problem is that

[RFC 02/15] target/riscv: rvb: count leading/trailing zeros

2020-11-18 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32-64.decode | 4 +++ target/riscv/insn32.decode | 7 +++- target/riscv/insn_trans/trans_rvb.c.inc | 47 target/riscv/translate.c| 48

[RFC 09/15] target/riscv: rvb: shift ones

2020-11-18 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng --- target/riscv/insn32-64.decode | 4 ++ target/riscv/insn32.decode | 4 ++ target/riscv/insn_trans/trans_rvb.c.inc | 58 target/riscv/translate.c| 70 + 4 files

[PATCH v2 21/27] failover: make sure that id always exist

2020-11-18 Thread Juan Quintela
We check that it exist at device creation time, so we don't have to check anywhere else. Signed-off-by: Juan Quintela --- hw/net/virtio-net.c| 3 --- softmmu/qdev-monitor.c | 4 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c

[PATCH v2 25/27] failover: Caller of this two functions already have primary_dev

2020-11-18 Thread Juan Quintela
Pass it as an argument. Signed-off-by: Juan Quintela --- hw/net/virtio-net.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 746ed3fb71..b37e9cd1d9 100644 --- a/hw/net/virtio-net.c +++

[PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-18 Thread Cornelia Huck
The zPCI group and function structures are big endian. However, we do not consistently store them as big endian locally, and are missing some conversions. Let's just store the structures as host endian instead and convert to big endian when actually handling the instructions retrieving the data.

Re: [PATCH for-5.2] meson: Fix argument for makensis (build regression)

2020-11-18 Thread Paolo Bonzini
On 17/11/20 20:06, Stefan Weil wrote: `make installer` with a DLL directory was broken. Signed-off-by: Stefan Weil --- scripts/nsis.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/nsis.py b/scripts/nsis.py index e1c409344e..5135a05831 100644 ---

[PATCH v2 27/27] failover: Remove primary_dev member

2020-11-18 Thread Juan Quintela
Only three uses remained, and we can remove them on that case. Signed-off-by: Juan Quintela --- include/hw/virtio/virtio-net.h | 1 - hw/net/virtio-net.c| 55 +++--- 2 files changed, 24 insertions(+), 32 deletions(-) diff --git

[PATCH 3/4] contrib/vhost-user-input: avoid g_return_val_if() input validation

2020-11-18 Thread Stefan Hajnoczi
Do not validate input with g_return_val_if(). This API is intended for checking programming errors and is compiled out with -DG_DISABLE_CHECKS. Use an explicit if statement for input validation so it cannot accidentally be compiled out. Suggested-by: Markus Armbruster Signed-off-by: Stefan

[PATCH 1/4] contrib/vhost-user-blk: avoid g_return_val_if() input validation

2020-11-18 Thread Stefan Hajnoczi
Do not validate input with g_return_val_if(). This API is intended for checking programming errors and is compiled out with -DG_DISABLE_CHECKS. Use an explicit if statement for input validation so it cannot accidentally be compiled out. Suggested-by: Markus Armbruster Signed-off-by: Stefan

[PATCH 2/4] contrib/vhost-user-gpu: avoid g_return_val_if() input validation

2020-11-18 Thread Stefan Hajnoczi
Do not validate input with g_return_val_if(). This API is intended for checking programming errors and is compiled out with -DG_DISABLE_CHECKS. Use an explicit if statement for input validation so it cannot accidentally be compiled out. Suggested-by: Markus Armbruster Signed-off-by: Stefan

[PATCH] cirrus-ci: parallelize "make check"

2020-11-18 Thread Paolo Bonzini
Otherwise, the tests risk failing due to timeouts. Signed-off-by: Paolo Bonzini --- .cirrus.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index f0209b7a3e..111e19f1bf 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -29,7 +29,7 @@ macos_task:

[PATCH v2 4/5] hw/arm: Flash image mapping follows image size

2020-11-18 Thread David Edmondson
When mapping flash images into the bottom 128MB, create mappings that match the size of the underlying block device rather than 64MB. Signed-off-by: David Edmondson --- hw/arm/trace-events | 2 + hw/arm/virt-acpi-build.c | 29 --- hw/arm/virt.c| 79

[PATCH v2 2/5] hw/block: Flash images can be smaller than the device

2020-11-18 Thread David Edmondson
When loading a flash image into a device, allow the image to be smaller than the extent of the device. Signed-off-by: David Edmondson --- hw/block/block.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/block/block.c b/hw/block/block.c index

[PATCH 0/7] UFFD write-tracking migration/snapshots

2020-11-18 Thread Andrey Gruzdev via
Currently the only way to make (external) live VM snapshot is using existing dirty page logging migration mechanism. The main problem is that it tends to produce a lot of page duplicates while running VM goes on updating already saved pages. That leads to the fact that vmstate image size is

Re: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized

2020-11-18 Thread Philippe Mathieu-Daudé
On 11/18/20 12:56 PM, Chen Qun wrote: > According to the glib function requirements, we need initialise > the variable. Otherwise there will be compilation warnings: > > glib-autocleanups.h:28:3: warning: ‘full_name’ may be > used uninitialized in this function [-Wmaybe-uninitialized] >28 |

Re: [RFC v3 8/9] module: introduce MODULE_INIT_ACCEL_CPU

2020-11-18 Thread Claudio Fontana
On 11/18/20 11:29 AM, Claudio Fontana wrote: > apply this to the registration of the cpus accel interfaces, > > but this will be also in preparation for later use of this > new module init step to also defer the registration of the cpu models, this is not true anymore, so my commit message

[PATCH v1 4/7] Implementation of write-tracking migration thread.

2020-11-18 Thread Andrey Gruzdev via
Signed-off-by: Andrey Gruzdev --- migration/migration.c | 168 +- migration/migration.h | 3 + migration/savevm.c| 1 - migration/savevm.h| 2 + 4 files changed, 171 insertions(+), 3 deletions(-) diff --git a/migration/migration.c

[PULL 4/4] authz-simple: Check that 'identity' property is set

2020-11-18 Thread Daniel P . Berrangé
From: Kevin Wolf If the 'identify' property is not set, we'll pass a NULL pointer to g_str_equal() and crash. Catch the error condition during the creation of the object. Signed-off-by: Kevin Wolf Signed-off-by: Daniel P. Berrangé --- authz/simple.c | 14 ++ 1 file changed, 14

[RFC 05/15] target/riscv: rvb: pack two words into one register

2020-11-18 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng --- target/riscv/insn32-64.decode | 3 + target/riscv/insn32.decode | 3 + target/riscv/insn_trans/trans_rvb.c.inc | 30 target/riscv/translate.c| 92 + 4 files changed, 128

[RFC 15/15] target/riscv: rvb: support and turn on B-extension from command line

2020-11-18 Thread frank . chang
From: Kito Cheng B-extension is default off, use cpu rv32 or rv64 with x-b=true to enable B-extension. Signed-off-by: Kito Cheng --- target/riscv/cpu.c | 4 target/riscv/cpu.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index

[PATCH v2 13/27] failover: Remove memory leak

2020-11-18 Thread Juan Quintela
Two things, at this point: * n->primary_device_id has to be set, otherwise virtio_net_find_primary don't work. So we have a leak here. * it has to be exactly the same that prim_dev->id because what qdev_find_recursive() does is just compare this two values. So remove the unneeded

[PATCH v2 23/27] failover: split failover_find_primary_device_id()

2020-11-18 Thread Juan Quintela
So we can calculate the device id when we need it. Signed-off-by: Juan Quintela --- hw/net/virtio-net.c | 63 + 1 file changed, 47 insertions(+), 16 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index b994796734..2c502c13fd

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Paolo Bonzini
On 18/11/20 09:36, Markus Armbruster wrote: The part that counts is do_configure_accelerator(). I works as follows: 1. Look up the chosen accelerator's QOM type (can fail) 2. Instantiate it (can't fail) 3. Set properties (can fail) 4. Connect the accelerator to the current machine (can fail)

Re: [PATCH v1 2/6] tests: add prefixes to the bare mkdtemp calls

2020-11-18 Thread Thomas Huth
On 17/11/2020 18.36, Alex Bennée wrote: > The first step to debug a thing is to know what created the thing in > the first place. Add some prefixes so random tmpdir's have something > grep in the code. > > Signed-off-by: Alex Bennée > > --- > v2 > - fix long lines > --- >

Re: Property '.hmat' not found

2020-11-18 Thread Jack Kuo
> > Could you check what happens if you use > "-machine pc-i440fx-5.2,hmat=on" instead of "-machine hmat=on"? It failed, but `-machine pc-i440fx-4.2` worked without `hmat` option. So, the problem could be that I didn't fully compile QEMU, which specified `--target-list=x86_64-softmmu` in the

[RFC v3 8/9] module: introduce MODULE_INIT_ACCEL_CPU

2020-11-18 Thread Claudio Fontana
apply this to the registration of the cpus accel interfaces, but this will be also in preparation for later use of this new module init step to also defer the registration of the cpu models, in order to make them subclasses of a per-accel cpu type. Signed-off-by: Claudio Fontana ---

[Bug 1903470] Re: qemu 5.1.0: Add UNIX socket support for netdev socket

2020-11-18 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1903470 Title: qemu 5.1.0: Add UNIX socket support for netdev socket Status in QEMU:

Re: question about bdrv_replace_node

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
18.11.2020 01:28, Vladimir Sementsov-Ogievskiy wrote: Hi! bdrv_replace_node_common() keeps old node parents in a list and call bdrv_replace_child_noperm() in a loop.. But bdrv_replace_child_noperm() may do aio_poll, which may trigger any graph change, up to freeing child which we keep in a

Re: [PATCH for-5.2] meson: Fix build with --disable-guest-agent-msi

2020-11-18 Thread Philippe Mathieu-Daudé
On 11/18/20 9:30 AM, Paolo Bonzini wrote: > On 17/11/20 21:18, Stefan Weil wrote: >> The QGA MSI target requires several macros which are only available >> without --disable-guest-agent-msi. >> >> Don't define that target if configure was called with >> --disable-guest-agent-msi. Can we have a CI

[PATCH 6/7] The rest of write tracking migration code.

2020-11-18 Thread Andrey Gruzdev via
Signed-off-by: Andrey Gruzdev --- migration/migration.c | 72 +-- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 381da4a4d3..92bcb9105d 100644 --- a/migration/migration.c +++

[Bug 1163034] Re: linux-user mode can't handle guest setting a very small RLIMIT_AS (hangs running gnutls28, coreutils configure check code)

2020-11-18 Thread Peter Maydell
This bug is still valid, yes. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1163034 Title: linux-user mode can't handle guest setting a very small RLIMIT_AS (hangs running gnutls28, coreutils

[Bug 1903470] Re: qemu 5.1.0: Add UNIX socket support for netdev socket

2020-11-18 Thread Mark Karpelès
Thanks for the response. I'm not sure, how would I run qemu with a fd= socketpair on the command line? The wiki (https://wiki.qemu.org/index.php/Documentation/Networking) suggests for example to use: -netdev socket,id=mynet0,listen=:1234 -netdev socket,id=mynet0,connect=:1234 This would allow

[PATCH 1/2] libvhost-user: replace qemu/bswap.h with glibc endian.h

2020-11-18 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- contrib/libvhost-user/libvhost-user.c | 77 ++- 1 file changed, 40 insertions(+), 37 deletions(-) diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c index

[RFC 03/15] target/riscv: rvb: count bits set

2020-11-18 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng --- target/riscv/insn32-64.decode | 1 + target/riscv/insn32.decode | 1 + target/riscv/insn_trans/trans_rvb.c.inc | 12 target/riscv/translate.c| 21 + 4 files changed, 35

[RFC 04/15] target/riscv: rvb: logic-with-negate

2020-11-18 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng --- target/riscv/insn32.decode | 4 +++ target/riscv/insn_trans/trans_rvb.c.inc | 18 ++ target/riscv/translate.c| 33 + 3 files changed, 55 insertions(+) diff --git

[RFC 13/15] target/riscv: rvb: address calculation

2020-11-18 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng Signed-off-by: Frank Chang --- target/riscv/insn32-64.decode | 3 +++ target/riscv/insn32.decode | 3 +++ target/riscv/insn_trans/trans_rvb.c.inc | 23 + target/riscv/translate.c| 33

[PATCH v2 11/27] failover: remove standby_id variable

2020-11-18 Thread Juan Quintela
We can calculate it, and we only use it once anyways. Signed-off-by: Juan Quintela --- include/hw/virtio/virtio-net.h | 1 - hw/net/virtio-net.c| 11 +++ 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/include/hw/virtio/virtio-net.h

[PATCH v2 22/27] failover: remove failover_find_primary_device() error parameter

2020-11-18 Thread Juan Quintela
It can never give one error. Signed-off-by: Juan Quintela --- hw/net/virtio-net.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index c708c03cf6..b994796734 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@

[PATCH v2 08/27] failover: Rename bool to failover_primary_hidden

2020-11-18 Thread Juan Quintela
You should not use passive naming variables. And once there, be able to search for them. Signed-off-by: Juan Quintela --- include/hw/virtio/virtio-net.h | 3 ++- hw/net/virtio-net.c| 14 +++--- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH v2 03/27] failover: Use always atomics for primary_should_be_hidden

2020-11-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 1011a524bf..a0fa63e7cb 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -3136,7 +3136,7 @@ static bool

[PATCH v2 18/27] failover: Rename to failover_find_primary_device()

2020-11-18 Thread Juan Quintela
This commit: * Rename them to failover_find_primary_devices() so - it starts with failover_ - it don't connect anything, just find the primary device * Create documentation for the function Signed-off-by: Juan Quintela --- hw/net/virtio-net.c | 12 +--- 1 file changed, 9

Re: [PATCH v2 00/27] Virtio net failover fixes

2020-11-18 Thread Michael S. Tsirkin
On Wed, Nov 18, 2020 at 09:37:21AM +0100, Juan Quintela wrote: > Hi > > This is a big rework of the network failover setup. General idea is: > * We don't cache the name of the primary/standby devices > We have several problems there with stale pointers > * After this: > - We can always remove

[PULL 5/7] hvf: Gate RDTSCP on CPU_BASED2_RDTSCP, not just CPU_BASED_TSC_OFFSET

2020-11-18 Thread Paolo Bonzini
From: Jessica Clarke Buglink: https://bugs.launchpad.net/qemu/+bug/1894836 Signed-off-by: Jessica Clarke Message-Id: <20201116200319.28138-1-jrt...@jrtc27.com> Signed-off-by: Paolo Bonzini --- target/i386/hvf/x86_cpuid.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH for-5.2 v3] s390x/pci: fix endianness issues

2020-11-18 Thread Cornelia Huck
The zPCI group and function structures are big endian. However, we do not consistently store them as big endian locally, and are missing some conversions. Let's just store the structures as host endian instead and convert to big endian when actually handling the instructions retrieving the data.

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-18 Thread Philippe Mathieu-Daudé
On 11/18/20 10:03 AM, Thomas Huth wrote: > Both headers, sysbus.h and module.h, are not required to compile this file. > > Signed-off-by: Thomas Huth > --- > hw/watchdog/wdt_diag288.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/watchdog/wdt_diag288.c

Re: [PATCH for-5.2 v3] s390x/pci: fix endianness issues

2020-11-18 Thread Thomas Huth
On 18/11/2020 11.42, Cornelia Huck wrote: > The zPCI group and function structures are big endian. However, we do > not consistently store them as big endian locally, and are missing some > conversions. > > Let's just store the structures as host endian instead and convert to > big endian when

[PATCH v2 5/5] hw/arm: Only minimise flash size on older machines

2020-11-18 Thread David Edmondson
Prior to 5.2 the flash images loaded into the bottom 128MB always filled the region. Ensure that this continues to be the case. Signed-off-by: David Edmondson --- hw/arm/virt-acpi-build.c | 11 +++--- hw/arm/virt.c| 79 ++-- include/hw/arm/virt.h

Re: [PATCH for-6.0 1/6] qapi: Add query-accel command

2020-11-18 Thread Daniel P . Berrangé
On Wed, Nov 18, 2020 at 12:28:45PM +0100, Kevin Wolf wrote: > Am 18.11.2020 um 09:36 hat Markus Armbruster geschrieben: > > >> >> [...] Even better would be > > >> >> returning an array of KvmInfo with information on all supported > > >> >> accelerators at

[PULL 2/4] authz-list-file: Improve an error message

2020-11-18 Thread Daniel P . Berrangé
From: Markus Armbruster When qauthz_list_file_load() rejects JSON values other than JSON object with a rather confusing error message: $ echo 1 | qemu-system-x86_64 -nodefaults -S -display none -object authz-list-file,id=authz0,filename=/dev/stdin qemu-system-x86_64: -object

[RFC 06/15] target/riscv: rvb: min/max instructions

2020-11-18 Thread frank . chang
From: Kito Cheng Signed-off-by: Kito Cheng --- target/riscv/insn32.decode | 4 target/riscv/insn_trans/trans_rvb.c.inc | 24 2 files changed, 28 insertions(+) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index

  1   2   3   4   >