On 16/11/20 22:31, Yonggang Luo wrote:
Fixes regression on curses detection in msys2
by commit#925a40df2828d32d3aaaf022282cba81082fb263
Signed-off-by: Yonggang Luo
---
meson.build | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/meson.build b/meson.build
On 17/11/20 20:34, Stefan Weil wrote:
Fix also a similar typo in a code comment.
Signed-off-by: Stefan Weil
---
docs/can.txt | 8
docs/interop/vhost-user.rst | 2 +-
docs/replay.txt | 2 +-
docs/specs/ppc-spapr-numa.rst | 2 +-
It was only set "once", and with the wrong value. As far as I can see,
libvirt still don't use it.
Signed-off-by: Juan Quintela
---
hw/net/virtio-net.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 3f658d6246..6ca85627d8 100644
---
Just remove the struct member.
Signed-off-by: Juan Quintela
---
include/hw/virtio/virtio-net.h | 1 -
hw/net/virtio-net.c| 8
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h
index
On Tue, Nov 17, 2020 at 02:41:31PM -0500, Vivek Goyal wrote:
> This is V3 of the patch. A minor change since V2 is to reverse the list
> before executing requests. We are prepending elements to the list and that
> means when we start processing requests, we are processing these in
> the reverse
You should not use pasive.
Signed-off-by: Juan Quintela
---
include/hw/qdev-core.h | 28 +++-
hw/core/qdev.c | 4 ++--
hw/net/virtio-net.c| 7 +++
3 files changed, 20 insertions(+), 19 deletions(-)
diff --git a/include/hw/qdev-core.h
On Tue, Nov 17, 2020 at 01:13:14PM -0600, Mike Christie wrote:
> On 11/17/20 10:40 AM, Stefan Hajnoczi wrote:
> > On Thu, Nov 12, 2020 at 05:18:59PM -0600, Mike Christie wrote:
> >> The following kernel patches were made over Michael's vhost branch:
> >>
> >>
From: Jessica Clarke
The Requested Privilege Level field is 2 bits, the Table Indicator field
is 1 bit and the Index field is the remaining 15 bits, with TI=0 meaning
GDT and TI=1 meaning LDT.
Signed-off-by: Jessica Clarke
Message-Id: <20201116200414.28286-1-jrt...@jrtc27.com>
Signed-off-by:
On Wed, 18 Nov 2020 10:38:00 +0100
Thomas Huth wrote:
> On 18/11/2020 09.51, Cornelia Huck wrote:
> > The zPCI group and function structures are big endian. However, we do
> > not consistently store them as big endian locally, and are missing some
> > conversions.
> >
> > Let's just store the
split cpu.c into:
cpu.ccpuid and common x86 cpu functionality
host-cpu.c host x86 cpu functions and "host" cpu type
kvm/cpu.cKVM x86 cpu type
hvf/cpu.cHVF x86 cpu type
tcg/cpu.cTCG x86 cpu type
The accel interface of the X86CPUClass is set at
Signed-off-by: Claudio Fontana
---
target/i386/meson.build | 14 +-
target/i386/{ => tcg}/bpt_helper.c | 0
target/i386/{ => tcg}/cc_helper.c | 0
target/i386/{ => tcg}/excp_helper.c | 0
target/i386/{ => tcg}/fpu_helper.c | 0
target/i386/{ => tcg}/int_helper.c
Signed-off-by: Claudio Fontana
---
MAINTAINERS | 2 +-
hw/i386/fw_cfg.c | 2 +-
hw/i386/intel_iommu.c| 2 +-
hw/i386/kvm/apic.c | 2 +-
hw/i386/kvm/clock.c | 2 +-
hw/i386/microvm.c
Signed-off-by: Andrey Gruzdev
---
migration/migration.c | 174 +-
migration/migration.h | 3 +
migration/savevm.c| 1 -
migration/savevm.h| 2 +
4 files changed, 177 insertions(+), 3 deletions(-)
diff --git a/migration/migration.c
Since reading UFFD events and saving paged data are performed
from the same thread, write fault latencies are sensitive to
migration stream stalls. Limiting total page saving rate is a
method to reduce amount of noticiable fault resolution latencies.
Migration bandwidth limiting is achieved via
The timer has been implemented, see commits:
d05be883fc9 ("hw/timer/bcm2835: Add the BCM2835 SYS_timer")
0e5bbd74064 ("hw/arm/bcm2835_peripherals: Use the SYS_timer")
722bde6789c ("hw/arm/bcm2835_peripherals: Correctly wire the SYS_timer IRQs")
Running the attached test with "-trace
In this particular implementation the same single migration
thread is responsible for both normal linear dirty page
migration and procesing UFFD page fault events.
Processing write faults includes reading UFFD file descriptor,
finding respective RAM block and saving faulting page to
the migration
On Wed, Nov 18, 2020 at 06:16:36PM +0800, 郭俊甫 (Jack Kuo) wrote:
> >
> > Could you check what happens if you use
> > "-machine pc-i440fx-5.2,hmat=on" instead of "-machine hmat=on"?
>
>
> It failed, but `-machine pc-i440fx-4.2` worked without `hmat` option.
> So, the problem could be that I didn't
From: Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
The following changes since commit 66a300a107ec286725bdc943601cbd4247b82158:
Update version for v5.2.0-rc2 release (2020-11-17 22:58:10 +)
are available in the Git repository at:
https://gitlab.com/berrange/qemu tags/misc-fixes-pull-request
for you to fetch changes up to
Signed-off-by: Andrey Gruzdev
---
migration/migration.c | 96 +++
migration/migration.h | 1 +
qapi/migration.json | 7 +++-
3 files changed, 103 insertions(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index
From: Marc-André Lureau
Hi,
libvhost-user is meant to be free of glib dependency, and easily
copyable/reusable outside of QEMU. Clean-up some dependencies that crept in
recently (the one remaining is qemu/atomic.h, from which a subset is used)
Marc-André Lureau (2):
libvhost-user: replace
From: Marc-André Lureau
Since g_input_stream_read_all() may return less than requested when the
stream is malformed, we should treat this condition as a runtime user
error (g_return are for programming errors).
Signed-off-by: Marc-André Lureau
---
backends/dbus-vmstate.c | 5 -
1 file
Once there, remove not needed cast.
Signed-off-by: Juan Quintela
---
hw/net/virtio-net.c| 33 +++--
softmmu/qdev-monitor.c | 4 ++--
2 files changed, 17 insertions(+), 20 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index
It was really only used once, in failover_add_primary(). Just search
for it on global opts when it is needed.
Signed-off-by: Juan Quintela
---
include/hw/virtio/virtio-net.h | 1 -
hw/net/virtio-net.c| 21 +
2 files changed, 5 insertions(+), 17 deletions(-)
Both headers, sysbus.h and module.h, are not required to compile this file.
Signed-off-by: Thomas Huth
---
hw/watchdog/wdt_diag288.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/watchdog/wdt_diag288.c b/hw/watchdog/wdt_diag288.c
index 71a945f0bd..4c4b6a6ab7 100644
---
The following changes since commit 66a300a107ec286725bdc943601cbd4247b82158:
Update version for v5.2.0-rc2 release (2020-11-17 22:58:10 +)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to
From: Stefan Weil
The QGA MSI target requires several macros which are only available
without --disable-guest-agent-msi.
Don't define that target if configure was called with --disable-guest-agent-msi.
Signed-off-by: Stefan Weil
Message-Id: <20201117201834.408892-1...@weilnetz.de>
From: Philippe Mathieu-Daudé
Since commits 0979ed017f0 ("meson: rename .inc.h files to .h.inc")
and 139c1837db7 ("meson: rename included C source files to .c.inc")
'git-diff --function-context' stopped displaying C function context
correctly.
We can help git-diff by providing attributes to the
From: Stefan Weil
`make installer` with a DLL directory was broken.
Signed-off-by: Stefan Weil
Message-Id: <20201117190640.390359-1...@weilnetz.de>
Reviewed-by: Marc-André Lureau
Signed-off-by: Paolo Bonzini
---
scripts/nsis.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The QEMU project is currently considering to move its bug tracking to another
system. For this we need to know which bugs are still valid and which could be
closed already. Thus we are setting older bugs to "Incomplete" now.
If you still think this bug report here is valid, then please switch
Patch had been merged here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=86dbcdd9c7590d06db89ca
... thus closing this ticket now.
** Changed in: qemu
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed
Currently ARM UEFI images are built as 2MB/768kB flash images for code
and variables respectively. These images are both then padded out to
64MB before being loaded by QEMU.
Because the images are 64MB each, QEMU allocates 128MB of memory to
read them, and then proceeds to read all 128MB from
Properly free resp for get_watchdog_action() to avoid memory leak.
ASAN shows memory leak stack:
Indirect leak of 12360 byte(s) in 3 object(s) allocated from:
#0 0x7f41ab6cbd4e in __interceptor_calloc (/lib64/libasan.so.5+0x112d4e)
#1 0x7f41ab4eaa50 in g_malloc0
According to the glib function requirements, we need initialise
the variable. Otherwise there will be compilation warnings:
glib-autocleanups.h:28:3: warning: ‘full_name’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
28 | g_free (*pp);
| ^~~~
Hi folks,
There are two bug caused by recent testcase code merge.
EulerRobot found them, and this series fixed them.
Thanks,
Chen Qun
Chen Qun (2):
tests/qtest: variable defined by g_autofree need to be initialized
tests/qtest: fix memleak in npcm7xx_watchdog_timer-test
From: Kito Cheng
Signed-off-by: Kito Cheng
---
target/riscv/insn32-64.decode | 8 ++
target/riscv/insn32.decode | 9 ++
target/riscv/insn_trans/trans_rvb.c.inc | 90 ++
target/riscv/translate.c| 155
4 files
From: Kito Cheng
Signed-off-by: Kito Cheng
---
target/riscv/insn32.decode | 2 ++
target/riscv/insn_trans/trans_rvb.c.inc | 13 +
2 files changed, 15 insertions(+)
diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode
index 372476f1d2c..626641333c6
From: Kito Cheng
Signed-off-by: Kito Cheng
Signed-off-by: Frank Chang
---
target/riscv/insn32-64.decode | 3 ++
target/riscv/insn32.decode | 3 ++
target/riscv/insn_trans/trans_rvb.c.inc | 54 +
target/riscv/translate.c| 48
From: Kito Cheng
Signed-off-by: Kito Cheng
---
target/riscv/insn32-64.decode | 7 +
target/riscv/insn_trans/trans_rvb.c.inc | 38 +
target/riscv/translate.c| 18
3 files changed, 63 insertions(+)
diff --git
With the fd= argument/property, you can setup a private socketpair
connection already. Is this enough?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1903470
Title:
qemu 5.1.0: Add UNIX socket
Markus Armbruster writes:
[...]
> qdev_device_add() looks like a bus-less device is usable if the machine
> provides a hotplug handler for it. Commit 03fcbd9dc5 "qdev: Check for
> the availability of a hotplug controller before adding a device" seems
> to be pertinent.
Nope. A hotplug handler
On 18.11.20 10:03, Thomas Huth wrote:
> Both headers, sysbus.h and module.h, are not required to compile this file.
>
> Signed-off-by: Thomas Huth
It is not a sysbus device and not a module.
Reviewed-by: Christian Borntraeger
> ---
> hw/watchdog/wdt_diag288.c | 2 --
> 1 file changed, 2
Markus Armbruster pointed out that g_return_val_if() is meant for programming
errors. It must not be used for input validation since it can be compiled out.
Use explicit if statements instead.
This patch series converts vhost-user device backends that use
g_return_val_if() in get/set_config().
The QEMU project is currently considering to move its bug tracking to another
system. For this we need to know which bugs are still valid and which could be
closed already. Thus we are setting older bugs to "Incomplete" now.
If you still think this bug report here is valid, then please switch
If there are problems examining or reading data from the block
backend, the error messages should include an appropriate identifier
to assist in diagnoses.
Signed-off-by: David Edmondson
---
hw/block/block.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
Rather than throwing an assertion, provide a more detailed report if a
flash image is inappropriately sized or aligned.
Signed-off-by: David Edmondson
---
hw/arm/virt.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index
Signed-off-by: Andrey Gruzdev
---
migration/migration.c | 96 +++
migration/migration.h | 1 +
qapi/migration.json | 7 +++-
3 files changed, 103 insertions(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Wednesday, November 18, 2020 8:14 PM
> To: Chenqun (kuhn) ; qemu-devel@nongnu.org;
> qemu-triv...@nongnu.org
> Cc: lviv...@redhat.com; peter.mayd...@linaro.org; th...@redhat.com;
> Zhanghailiang ;
>
Since reading UFFD events and saving paged data are performed
from the same thread, write fault latencies are sensitive to
migration stream stalls. Limiting total page saving rate is a
method to reduce amount of noticiable fault resolution latencies.
Migration bandwidth limiting is achieved via
To avoid saving updated versions of memory pages we need
to start tracking RAM writes before we resume operation of
vCPUs. This sequence is especially critical for virtio device
backends whos VQs are mapped to main memory and accessed
directly not using MMIO callbacks.
One problem is that
From: Kito Cheng
Signed-off-by: Kito Cheng
Signed-off-by: Frank Chang
---
target/riscv/insn32-64.decode | 4 +++
target/riscv/insn32.decode | 7 +++-
target/riscv/insn_trans/trans_rvb.c.inc | 47
target/riscv/translate.c| 48
From: Kito Cheng
Signed-off-by: Kito Cheng
---
target/riscv/insn32-64.decode | 4 ++
target/riscv/insn32.decode | 4 ++
target/riscv/insn_trans/trans_rvb.c.inc | 58
target/riscv/translate.c| 70 +
4 files
We check that it exist at device creation time, so we don't have to
check anywhere else.
Signed-off-by: Juan Quintela
---
hw/net/virtio-net.c| 3 ---
softmmu/qdev-monitor.c | 4
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
Pass it as an argument.
Signed-off-by: Juan Quintela
---
hw/net/virtio-net.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 746ed3fb71..b37e9cd1d9 100644
--- a/hw/net/virtio-net.c
+++
The zPCI group and function structures are big endian. However, we do
not consistently store them as big endian locally, and are missing some
conversions.
Let's just store the structures as host endian instead and convert to
big endian when actually handling the instructions retrieving the data.
On 17/11/20 20:06, Stefan Weil wrote:
`make installer` with a DLL directory was broken.
Signed-off-by: Stefan Weil
---
scripts/nsis.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/nsis.py b/scripts/nsis.py
index e1c409344e..5135a05831 100644
---
Only three uses remained, and we can remove them on that case.
Signed-off-by: Juan Quintela
---
include/hw/virtio/virtio-net.h | 1 -
hw/net/virtio-net.c| 55 +++---
2 files changed, 24 insertions(+), 32 deletions(-)
diff --git
Do not validate input with g_return_val_if(). This API is intended for
checking programming errors and is compiled out with -DG_DISABLE_CHECKS.
Use an explicit if statement for input validation so it cannot
accidentally be compiled out.
Suggested-by: Markus Armbruster
Signed-off-by: Stefan
Do not validate input with g_return_val_if(). This API is intended for
checking programming errors and is compiled out with -DG_DISABLE_CHECKS.
Use an explicit if statement for input validation so it cannot
accidentally be compiled out.
Suggested-by: Markus Armbruster
Signed-off-by: Stefan
Do not validate input with g_return_val_if(). This API is intended for
checking programming errors and is compiled out with -DG_DISABLE_CHECKS.
Use an explicit if statement for input validation so it cannot
accidentally be compiled out.
Suggested-by: Markus Armbruster
Signed-off-by: Stefan
Otherwise, the tests risk failing due to timeouts.
Signed-off-by: Paolo Bonzini
---
.cirrus.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.cirrus.yml b/.cirrus.yml
index f0209b7a3e..111e19f1bf 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -29,7 +29,7 @@ macos_task:
When mapping flash images into the bottom 128MB, create mappings that
match the size of the underlying block device rather than 64MB.
Signed-off-by: David Edmondson
---
hw/arm/trace-events | 2 +
hw/arm/virt-acpi-build.c | 29 ---
hw/arm/virt.c| 79
When loading a flash image into a device, allow the image to be
smaller than the extent of the device.
Signed-off-by: David Edmondson
---
hw/block/block.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/block/block.c b/hw/block/block.c
index
Currently the only way to make (external) live VM snapshot is using existing
dirty page logging migration mechanism. The main problem is that it tends to
produce a lot of page duplicates while running VM goes on updating already
saved pages. That leads to the fact that vmstate image size is
On 11/18/20 12:56 PM, Chen Qun wrote:
> According to the glib function requirements, we need initialise
> the variable. Otherwise there will be compilation warnings:
>
> glib-autocleanups.h:28:3: warning: ‘full_name’ may be
> used uninitialized in this function [-Wmaybe-uninitialized]
>28 |
On 11/18/20 11:29 AM, Claudio Fontana wrote:
> apply this to the registration of the cpus accel interfaces,
>
> but this will be also in preparation for later use of this
> new module init step to also defer the registration of the cpu models,
this is not true anymore, so my commit message
Signed-off-by: Andrey Gruzdev
---
migration/migration.c | 168 +-
migration/migration.h | 3 +
migration/savevm.c| 1 -
migration/savevm.h| 2 +
4 files changed, 171 insertions(+), 3 deletions(-)
diff --git a/migration/migration.c
From: Kevin Wolf
If the 'identify' property is not set, we'll pass a NULL pointer to
g_str_equal() and crash. Catch the error condition during the creation
of the object.
Signed-off-by: Kevin Wolf
Signed-off-by: Daniel P. Berrangé
---
authz/simple.c | 14 ++
1 file changed, 14
From: Kito Cheng
Signed-off-by: Kito Cheng
---
target/riscv/insn32-64.decode | 3 +
target/riscv/insn32.decode | 3 +
target/riscv/insn_trans/trans_rvb.c.inc | 30
target/riscv/translate.c| 92 +
4 files changed, 128
From: Kito Cheng
B-extension is default off, use cpu rv32 or rv64 with x-b=true to
enable B-extension.
Signed-off-by: Kito Cheng
---
target/riscv/cpu.c | 4
target/riscv/cpu.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index
Two things, at this point:
* n->primary_device_id has to be set, otherwise
virtio_net_find_primary don't work. So we have a leak here.
* it has to be exactly the same that prim_dev->id because what
qdev_find_recursive() does is just compare this two values.
So remove the unneeded
So we can calculate the device id when we need it.
Signed-off-by: Juan Quintela
---
hw/net/virtio-net.c | 63 +
1 file changed, 47 insertions(+), 16 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index b994796734..2c502c13fd
On 18/11/20 09:36, Markus Armbruster wrote:
The part that counts is do_configure_accelerator(). I works as follows:
1. Look up the chosen accelerator's QOM type (can fail)
2. Instantiate it (can't fail)
3. Set properties (can fail)
4. Connect the accelerator to the current machine (can fail)
On 17/11/2020 18.36, Alex Bennée wrote:
> The first step to debug a thing is to know what created the thing in
> the first place. Add some prefixes so random tmpdir's have something
> grep in the code.
>
> Signed-off-by: Alex Bennée
>
> ---
> v2
> - fix long lines
> ---
>
>
> Could you check what happens if you use
> "-machine pc-i440fx-5.2,hmat=on" instead of "-machine hmat=on"?
It failed, but `-machine pc-i440fx-4.2` worked without `hmat` option.
So, the problem could be that I didn't fully compile QEMU, which specified
`--target-list=x86_64-softmmu` in the
apply this to the registration of the cpus accel interfaces,
but this will be also in preparation for later use of this
new module init step to also defer the registration of the cpu models,
in order to make them subclasses of a per-accel cpu type.
Signed-off-by: Claudio Fontana
---
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1903470
Title:
qemu 5.1.0: Add UNIX socket support for netdev socket
Status in QEMU:
18.11.2020 01:28, Vladimir Sementsov-Ogievskiy wrote:
Hi!
bdrv_replace_node_common() keeps old node parents in a list and call
bdrv_replace_child_noperm() in a loop..
But bdrv_replace_child_noperm() may do aio_poll, which may trigger any graph
change, up to freeing child which we keep in a
On 11/18/20 9:30 AM, Paolo Bonzini wrote:
> On 17/11/20 21:18, Stefan Weil wrote:
>> The QGA MSI target requires several macros which are only available
>> without --disable-guest-agent-msi.
>>
>> Don't define that target if configure was called with
>> --disable-guest-agent-msi.
Can we have a CI
Signed-off-by: Andrey Gruzdev
---
migration/migration.c | 72 +--
1 file changed, 70 insertions(+), 2 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 381da4a4d3..92bcb9105d 100644
--- a/migration/migration.c
+++
This bug is still valid, yes.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1163034
Title:
linux-user mode can't handle guest setting a very small RLIMIT_AS
(hangs running gnutls28, coreutils
Thanks for the response. I'm not sure, how would I run qemu with a fd=
socketpair on the command line?
The wiki (https://wiki.qemu.org/index.php/Documentation/Networking)
suggests for example to use:
-netdev socket,id=mynet0,listen=:1234
-netdev socket,id=mynet0,connect=:1234
This would allow
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
contrib/libvhost-user/libvhost-user.c | 77 ++-
1 file changed, 40 insertions(+), 37 deletions(-)
diff --git a/contrib/libvhost-user/libvhost-user.c
b/contrib/libvhost-user/libvhost-user.c
index
From: Kito Cheng
Signed-off-by: Kito Cheng
---
target/riscv/insn32-64.decode | 1 +
target/riscv/insn32.decode | 1 +
target/riscv/insn_trans/trans_rvb.c.inc | 12
target/riscv/translate.c| 21 +
4 files changed, 35
From: Kito Cheng
Signed-off-by: Kito Cheng
---
target/riscv/insn32.decode | 4 +++
target/riscv/insn_trans/trans_rvb.c.inc | 18 ++
target/riscv/translate.c| 33 +
3 files changed, 55 insertions(+)
diff --git
From: Kito Cheng
Signed-off-by: Kito Cheng
Signed-off-by: Frank Chang
---
target/riscv/insn32-64.decode | 3 +++
target/riscv/insn32.decode | 3 +++
target/riscv/insn_trans/trans_rvb.c.inc | 23 +
target/riscv/translate.c| 33
We can calculate it, and we only use it once anyways.
Signed-off-by: Juan Quintela
---
include/hw/virtio/virtio-net.h | 1 -
hw/net/virtio-net.c| 11 +++
2 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/include/hw/virtio/virtio-net.h
It can never give one error.
Signed-off-by: Juan Quintela
---
hw/net/virtio-net.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index c708c03cf6..b994796734 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@
You should not use passive naming variables.
And once there, be able to search for them.
Signed-off-by: Juan Quintela
---
include/hw/virtio/virtio-net.h | 3 ++-
hw/net/virtio-net.c| 14 +++---
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git
Signed-off-by: Juan Quintela
---
hw/net/virtio-net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 1011a524bf..a0fa63e7cb 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -3136,7 +3136,7 @@ static bool
This commit:
* Rename them to failover_find_primary_devices() so
- it starts with failover_
- it don't connect anything, just find the primary device
* Create documentation for the function
Signed-off-by: Juan Quintela
---
hw/net/virtio-net.c | 12 +---
1 file changed, 9
On Wed, Nov 18, 2020 at 09:37:21AM +0100, Juan Quintela wrote:
> Hi
>
> This is a big rework of the network failover setup. General idea is:
> * We don't cache the name of the primary/standby devices
> We have several problems there with stale pointers
> * After this:
> - We can always remove
From: Jessica Clarke
Buglink: https://bugs.launchpad.net/qemu/+bug/1894836
Signed-off-by: Jessica Clarke
Message-Id: <20201116200319.28138-1-jrt...@jrtc27.com>
Signed-off-by: Paolo Bonzini
---
target/i386/hvf/x86_cpuid.c | 4
1 file changed, 4 insertions(+)
diff --git
The zPCI group and function structures are big endian. However, we do
not consistently store them as big endian locally, and are missing some
conversions.
Let's just store the structures as host endian instead and convert to
big endian when actually handling the instructions retrieving the data.
On 11/18/20 10:03 AM, Thomas Huth wrote:
> Both headers, sysbus.h and module.h, are not required to compile this file.
>
> Signed-off-by: Thomas Huth
> ---
> hw/watchdog/wdt_diag288.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/watchdog/wdt_diag288.c
On 18/11/2020 11.42, Cornelia Huck wrote:
> The zPCI group and function structures are big endian. However, we do
> not consistently store them as big endian locally, and are missing some
> conversions.
>
> Let's just store the structures as host endian instead and convert to
> big endian when
Prior to 5.2 the flash images loaded into the bottom 128MB always
filled the region. Ensure that this continues to be the case.
Signed-off-by: David Edmondson
---
hw/arm/virt-acpi-build.c | 11 +++---
hw/arm/virt.c| 79 ++--
include/hw/arm/virt.h
On Wed, Nov 18, 2020 at 12:28:45PM +0100, Kevin Wolf wrote:
> Am 18.11.2020 um 09:36 hat Markus Armbruster geschrieben:
> > >> >> [...] Even better would be
> > >> >> returning an array of KvmInfo with information on all supported
> > >> >> accelerators at
From: Markus Armbruster
When qauthz_list_file_load() rejects JSON values other than JSON
object with a rather confusing error message:
$ echo 1 | qemu-system-x86_64 -nodefaults -S -display none -object
authz-list-file,id=authz0,filename=/dev/stdin
qemu-system-x86_64: -object
From: Kito Cheng
Signed-off-by: Kito Cheng
---
target/riscv/insn32.decode | 4
target/riscv/insn_trans/trans_rvb.c.inc | 24
2 files changed, 28 insertions(+)
diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode
index
1 - 100 of 340 matches
Mail list logo