[PULL 2/5] target/ppc/kvm: Cache timebase frequency

2021-03-31 Thread David Gibson
From: Greg Kurz Each vCPU core exposes its timebase frequency in the DT. When running under KVM, this means parsing /proc/cpuinfo in order to get the timebase frequency of the host CPU. The parsing appears to slow down the boot quite a bit with higher number of cores: # of cores seconds

[PATCH] gitlab-ci.yml: Fix the filtering for the git submodules

2021-03-31 Thread Thomas Huth
Commit 7d7dbf9dc15be6e introduced a new line starting with "GIT_SUBMODULES_ACTION=" in the config-host.mak file. The grep that tries to determine the submodules in the gitlab-ci.yml file matches this new line, too, causing a warning message when updating the modules: warn: ignoring non-existent

[RFC PATCH v2 0/4] Add migration support for VFIO PCI devices in SMMUv3 nested stage mode

2021-03-31 Thread Kunkun Jiang
Hi all, Since the SMMUv3's nested translation stages[1] has been introduced by Eric, we need to pay attention to the migration of VFIO PCI devices in SMMUv3 nested stage mode. At present, it is not yet supported in QEMU. There are two problems in the existing framework. First, the current way

[PULL 1/5] hw/ppc: e500: Add missing #address-cells and #size-cells in the eTSEC node

2021-03-31 Thread David Gibson
From: Bin Meng Per devicetree spec v0.3 [1] chapter 2.3.5: The #address-cells and #size-cells properties are not inherited from ancestors in the devicetree. They shall be explicitly defined. If missing, a client program should assume a default value of 2 for #address-cells, and a value of 1 for

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-31 Thread Greg Kurz
On Wed, 31 Mar 2021 15:47:26 +1100 David Gibson wrote: > On Wed, Mar 31, 2021 at 06:04:27AM +0200, Greg Kurz wrote: > > On Wed, 31 Mar 2021 11:09:06 +1100 > > David Gibson wrote: > > > > > On Tue, Mar 30, 2021 at 08:01:13AM -0700, Richard Henderson wrote: > > > > On 3/29/21 10:54 PM, David

Re: [PATCH] hw/block/nvme: add device self test command support

2021-03-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210331073233.11198-1-anaidu.go...@samsung.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210331073233.11198-1-anaidu.go...@samsung.com Subject: [PATCH] hw/block/nvme: add

Re: Serious doubts about Gitlab CI

2021-03-31 Thread Thomas Huth
On 30/03/2021 15.19, Daniel P. Berrangé wrote: On Tue, Mar 30, 2021 at 01:55:48PM +0200, Thomas Huth wrote: On 30/03/2021 13.19, Daniel P. Berrangé wrote: [...] ccache is a no-brainer and assuming it isn't already working with our gitlab jobs, we must fix that asap. I've found some nice

Re: [PATCH v2] IOMMU not supported by vhost-user.

2021-03-31 Thread Stefan Hajnoczi
On Wed, Feb 17, 2021 at 04:55:12PM -0300, lagar...@linux.ibm.com wrote: > diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c > index 2fdd5daf74..6ab760364b 100644 > --- a/hw/virtio/vhost-user.c > +++ b/hw/virtio/vhost-user.c > @@ -1849,6 +1849,13 @@ static int

Re: Serious doubts about Gitlab CI

2021-03-31 Thread Andrea Bolognani
On Wed, 2021-03-31 at 09:54 +0200, Thomas Huth wrote: > On 30/03/2021 15.19, Daniel P. Berrangé wrote: > > Yep, that looks similar to what we do in libvirt, though we don't override > > the compiler at the job level. Instead we just ensure the dir containing > > ccache symlinks appears first in

[RFC PATCH 4/6] hw/i386/pc: Parse cluster cpu topology for PC machines

2021-03-31 Thread Yanan Wang
There is a separate function pc_smp_parse() in hw/i386/pc.c used to parse cpu topology for the PC machines. And there are some x86 implementations that have a similar concept of cluster, for example, on Jacobsville there are 6 clusters of 4 Atom cores, each cluster sharing a separate L2 cache, and

[RFC PATCH 6/6] hw/arm/virt: Add cluster level for ARM device tree

2021-03-31 Thread Yanan Wang
Add a cluster level between core level and package level for ARM device tree. Signed-off-by: Yanan Wang --- hw/arm/virt.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index c9ad76ff64..d78db3387e 100644 --- a/hw/arm/virt.c +++

[RFC PATCH v2 2/4] vfio: Add vfio_prereg_listener_log_sync in nested stage

2021-03-31 Thread Kunkun Jiang
On Intel, the DMA mapped through the host single stage. Instead we set up the stage 2 and stage 1 separately in nested mode as there is no "Caching Mode". Legacy vfio_listener_log_sync cannot be used in nested stage as we don't need to pay close attention to stage 1 mapping. This patch adds

Re: [PATCH 18/24] DAX/unmap virtiofsd: Parse unmappable elements

2021-03-31 Thread Stefan Hajnoczi
On Thu, Feb 25, 2021 at 10:19:31AM +, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Tue, Feb 09, 2021 at 07:02:18PM +, Dr. David Alan Gilbert (git) > > wrote: > > > diff --git a/tools/virtiofsd/fuse_common.h b/tools/virtiofsd/fuse_common.h > > >

[PATCH] hw/riscv: sifive_e: Add 'const' to sifive_e_memmap[]

2021-03-31 Thread Bin Meng
This was accidentally dropped before. Add it back. Reported-by: Emmanuel Blot Signed-off-by: Bin Meng --- hw/riscv/sifive_e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c index f939bcf9ea..82096b3e5a 100644 ---

[PULL 3/5] spapr: Assert DIMM unplug state in spapr_memory_unplug()

2021-03-31 Thread David Gibson
From: Greg Kurz spapr_memory_unplug() is the last step of the hot unplug sequence. It is indirectly called by: spapr_lmb_release() hotplug_handler_unplug() and spapr_lmb_release() already buys us that DIMM unplug state is present : it gets restored with spapr_recover_pending_dimm_state() if

[PULL 5/5] hw/net: fsl_etsec: Tx padding length should exclude CRC

2021-03-31 Thread David Gibson
From: Bin Meng As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU", min_frame_len should excluce CRC, so it should be 60 instead of 64. Signed-off-by: Bin Meng Message-Id: <20210316081505.72898-1-bmeng...@gmail.com> Signed-off-by: David Gibson --- hw/net/fsl_etsec/rings.c |

[Bug 1921948] Re: MTE tags not checked properly for unaligned accesses at EL1

2021-03-31 Thread Richard Henderson
Ah, perfect, I was missing dram_metadata.is_enabled. And my userland unaligned test case demonstrates that the second granule is tested, as reported. ** Changed in: qemu Status: New => Confirmed ** Changed in: qemu Status: Confirmed => In Progress -- You received this bug

Re: [PATCH v2] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-03-31 Thread Paolo Bonzini
On 31/03/21 07:40, Thomas Huth wrote: On 30/03/2021 12.53, Paolo Bonzini wrote: On 30/03/21 11:08, Thomas Huth wrote:   I've picked the Django Code of Conduct as a base, since it sounds rather   friendly and still welcoming to me, but I'm open for other suggestions, too   (but we should

Re: [PATCH] target/openrisc: fix icount handling for timer instructions

2021-03-31 Thread Pavel Dovgalyuk
On 31.03.2021 01:05, Stafford Horne wrote: Hi Pavel, Thanks for the patch. On Mon, Mar 29, 2021 at 10:42:41AM +0300, Pavel Dovgalyuk wrote: This patch adds icount handling to mfspr/mtspr instructions that may deal with hardware timers. Signed-off-by: Pavel Dovgalyuk ---

[PULL for-6.0 0/6] Block patches

2021-03-31 Thread Stefan Hajnoczi
The following changes since commit 6d40ce00c1166c317e298ad82ecf10e650c4f87d: Update version for v6.0.0-rc1 release (2021-03-30 18:19:07 +0100) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to

[PULL for-6.0 1/6] block/vdi: When writing new bmap entry fails, don't leak the buffer

2021-03-31 Thread Stefan Hajnoczi
From: David Edmondson If a new bitmap entry is allocated, requiring the entire block to be written, avoiding leaking the buffer allocated for the block should the write fail. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Edmondson Signed-off-by: Paolo Bonzini Acked-by: Max Reitz

Re: [RFC PATCH 0/6] Introduce cluster cpu topology support

2021-03-31 Thread Paolo Bonzini
On 31/03/21 11:53, Yanan Wang wrote: A cluster means a group of cores that share some resources (e.g. cache) among them under the LLC. For example, ARM64 server chip Kunpeng 920 has 6 or 8 clusters in each NUMA, and each cluster has 4 cores. All clusters share L3 cache data while cores within

[RFC PATCH 1/6] vl.c: Add arch-neutral -smp, clusters=* command line support

2021-03-31 Thread Yanan Wang
A cluster means a group of cores that share some resources (e.g. cache) among them under the LLC. For example, ARM64 server chip Kunpeng 920 has 6 or 8 clusters in each NUMA, and each cluster has 4 cores. All clusters share L3 cache data while cores within each cluster share the L2 cache. Also,

[RFC PATCH 2/6] hw/core/machine: Parse cluster cpu topology in smp_parse()

2021-03-31 Thread Yanan Wang
Function smp_parse() in hw/core/machine.c is a generic/default function used for parsing the -smp command line. Since the new cluster parameter has been added in struct CpuTopology, we should parse this new parameter in the default function. In smp_parse(), the computing logic of missing values

Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

2021-03-31 Thread Steven Price
On 31/03/2021 10:32, David Hildenbrand wrote: On 31.03.21 11:21, Catalin Marinas wrote: On Wed, Mar 31, 2021 at 09:34:44AM +0200, David Hildenbrand wrote: On 30.03.21 12:30, Catalin Marinas wrote: On Mon, Mar 29, 2021 at 05:06:51PM +0100, Steven Price wrote: On 28/03/2021 13:21, Catalin

[PATCH v2] hw/block/nvme: add device self test command support

2021-03-31 Thread Gollu Appalanaidu
This is to add support for Device Self Test Command (DST) and DST Log Page. Refer NVM Express specification 1.4b section 5.8 ("Device Self-test command") Signed-off-by: Gollu Appalanaidu --- changes: -v2: addressed style fixes in hw/block/nvme.h hw/block/nvme.c |

Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

2021-03-31 Thread David Hildenbrand
On 31.03.21 11:21, Catalin Marinas wrote: On Wed, Mar 31, 2021 at 09:34:44AM +0200, David Hildenbrand wrote: On 30.03.21 12:30, Catalin Marinas wrote: On Mon, Mar 29, 2021 at 05:06:51PM +0100, Steven Price wrote: On 28/03/2021 13:21, Catalin Marinas wrote: On Sat, Mar 27, 2021 at 03:23:24PM

Re: [PATCH] sockets: update SOCKET_ADDRESS_TYPE_FD listen(2) backlog

2021-03-31 Thread Stefan Hajnoczi
On Tue, Mar 16, 2021 at 08:35:14AM -0500, Eric Blake wrote: > On 3/16/21 4:10 AM, Stefan Hajnoczi wrote: > > On Wed, Mar 10, 2021 at 05:30:04PM +, Stefan Hajnoczi wrote: > >> socket_get_fd() fails with the error "socket_get_fd: too many > >> connections" if the given listen backlog value is

[RFC PATCH v2 3/4] vfio: Add vfio_prereg_listener_global_log_start/stop in nested stage

2021-03-31 Thread Kunkun Jiang
In nested mode, we set up the stage 2 and stage 1 separately. In my opinion, vfio_memory_prereg_listener is used for stage 2 and vfio_memory_listener is used for stage 1. So it feels weird to call the global_log_start/stop interface in vfio_memory_listener to switch dirty tracking, although this

Re: [PATCH v4 for-6.0? 0/3] qcow2: fix parallel rewrite and discard (rw-lock)

2021-03-31 Thread Vladimir Sementsov-Ogievskiy
30.03.2021 19:39, Max Reitz wrote: == OK, I think now that you didn't mean qcow2_alloc_clusters(). So, we are saying about only functions returning an offset to cluster with "guest data", not to any kind of host cluster. Than what you propose looks like this to me:   - take my v5   - rename

[PATCH] hw/arm/smmuv3: Support 16K translation granule

2021-03-31 Thread Kunkun Jiang
The driver can query some bits in SMMUv3 IDR5 to learn which translation granules are supported. Arm recommends that SMMUv3 implementations support at least 4K and 64K granules. But in the vSMMUv3, there seems to be no reason not to support 16K translation granule. In addition, if 16K is not

Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

2021-03-31 Thread David Hildenbrand
On 30.03.21 12:30, Catalin Marinas wrote: On Mon, Mar 29, 2021 at 05:06:51PM +0100, Steven Price wrote: On 28/03/2021 13:21, Catalin Marinas wrote: On Sat, Mar 27, 2021 at 03:23:24PM +, Catalin Marinas wrote: On Fri, Mar 12, 2021 at 03:18:58PM +, Steven Price wrote: diff --git

Re: [PATCH v2] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-03-31 Thread Daniel P . Berrangé
On Tue, Mar 30, 2021 at 04:07:06PM +0200, Paolo Bonzini wrote: > On 30/03/21 15:02, Daniel P. Berrangé wrote: > > Consider someone is kicked out from another project for violation > > of that project's CoC, that would also be considered a violation > > under QEMU's CoC. This qualifier is

Re: [PATCH v2] hw/block/nvme: add device self test command support

2021-03-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210331083306.12461-1-anaidu.go...@samsung.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210331083306.12461-1-anaidu.go...@samsung.com Subject: [PATCH v2] hw/block/nvme:

Re: [PATCH RFC RESEND v2 0/6] Introduce IOMMU Option For PCI Root Bus

2021-03-31 Thread Wang Xingang
Hi, everyone! Do you have any suggestions about this iommu configuration feature? Please help review these patches, thanks very much. On 2021/3/25 15:22, Wang Xingang wrote: From: Xingang Wang These patches add support for configure iommu on/off for pci root bus, including primary bus and

Re: [PATCH v2] qapi: introduce 'query-cpu-model-cpuid' action

2021-03-31 Thread Igor Mammedov
On Tue, 30 Mar 2021 12:37:11 +0300 Valeriy Vdovin wrote: > On Tue, Mar 30, 2021 at 02:15:10AM +0200, Igor Mammedov wrote: > > On Thu, 25 Mar 2021 19:57:05 +0300 > > Valeriy Vdovin wrote: > > > > > Introducing new qapi method 'query-cpu-model-cpuid'. This method can be > > > used to > > >

[PULL for-6.0 2/6] block/vdi: Don't assume that blocks are larger than VdiHeader

2021-03-31 Thread Stefan Hajnoczi
From: David Edmondson Given that the block size is read from the header of the VDI file, a wide variety of sizes might be seen. Rather than re-using a block sized memory region when writing the VDI header, allocate an appropriately sized buffer. Signed-off-by: David Edmondson Signed-off-by:

Re: [PATCH v10 1/6] arm64: mte: Sync tags for pages where PTE is untagged

2021-03-31 Thread Steven Price
On 30/03/2021 11:13, Catalin Marinas wrote: On Mon, Mar 29, 2021 at 04:55:29PM +0100, Steven Price wrote: On 26/03/2021 18:56, Catalin Marinas wrote: On Fri, Mar 12, 2021 at 03:18:57PM +, Steven Price wrote: A KVM guest could store tags in a page even if the VMM hasn't mapped the page

Re: [PATCH v3 3/3] ppc: Enable 2nd DAWR support on p10

2021-03-31 Thread Ravi Bangoria
On 3/31/21 5:06 AM, David Gibson wrote: On Tue, Mar 30, 2021 at 06:48:38PM +0200, Greg Kurz wrote: On Tue, 30 Mar 2021 15:23:50 +0530 Ravi Bangoria wrote: As per the PAPR, bit 0 of byte 64 in pa-features property indicates availability of 2nd DAWR registers. i.e. If this bit is set, 2nd

[PULL 4/5] spapr: Fix typo in the patb_entry comment

2021-03-31 Thread David Gibson
From: Alexey Kardashevskiy There is no H_REGISTER_PROCESS_TABLE, it is H_REGISTER_PROC_TBL handler for which is still called h_register_process_table() though. Signed-off-by: Alexey Kardashevskiy Message-Id: <20210225032335.64245-1-...@ozlabs.ru> Reviewed-by: Daniel Henrique Barboza

[PULL 0/5] ppc-for-6.0 queue 20210331

2021-03-31 Thread David Gibson
The following changes since commit 6d40ce00c1166c317e298ad82ecf10e650c4f87d: Update version for v6.0.0-rc1 release (2021-03-30 18:19:07 +0100) are available in the Git repository at: https://gitlab.com/dgibson/qemu.git tags/ppc-for-6.0-20210331 for you to fetch changes up

Re: [PATCH v2] IOMMU not supported by vhost-user.

2021-03-31 Thread Stefan Hajnoczi
On Tue, Feb 23, 2021 at 04:55:41PM +0100, Greg Kurz wrote: > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > > index 6e17d631f7..78e58d2148 100644 > > --- a/hw/virtio/vhost.c > > +++ b/hw/virtio/vhost.c > > @@ -1293,7 +1293,6 @@ int vhost_dev_init(struct vhost_dev *hdev, void > > *opaque,

Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

2021-03-31 Thread Catalin Marinas
On Wed, Mar 31, 2021 at 09:34:44AM +0200, David Hildenbrand wrote: > On 30.03.21 12:30, Catalin Marinas wrote: > > On Mon, Mar 29, 2021 at 05:06:51PM +0100, Steven Price wrote: > > > On 28/03/2021 13:21, Catalin Marinas wrote: > > > > On Sat, Mar 27, 2021 at 03:23:24PM +, Catalin Marinas

[RFC PATCH 5/6] hw/arm/virt-acpi-build: Add cluster level for ARM PPTT table

2021-03-31 Thread Yanan Wang
Add a Processor Hierarchy Node of cluster level between core level and package level for ARM PPTT table. Signed-off-by: Yanan Wang --- hw/acpi/aml-build.c | 11 ++ hw/arm/virt-acpi-build.c| 43 + include/hw/acpi/aml-build.h | 2 ++ 3

Re: [PATCH 16/24] DAX/unmap: virtiofsd: Add VHOST_USER_SLAVE_FS_IO

2021-03-31 Thread Stefan Hajnoczi
On Tue, Mar 16, 2021 at 07:59:59PM +, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Tue, Feb 09, 2021 at 07:02:16PM +, Dr. David Alan Gilbert (git) > > wrote: > > > +if (!mrs_size) { > > > +error_report("No guest region

[RFC PATCH v2 1/4] vfio: Introduce helpers to mark dirty pages of a RAM section

2021-03-31 Thread Kunkun Jiang
Extract part of the code from vfio_sync_dirty_bitmap to form a new helper, which allows to mark dirty pages of a RAM section. This helper will be called for nested stage. Signed-off-by: Kunkun Jiang --- hw/vfio/common.c | 22 ++ 1 file changed, 14 insertions(+), 8

[RFC PATCH v2 4/4] hw/arm/smmuv3: Post-load stage 1 configurations to the host

2021-03-31 Thread Kunkun Jiang
In nested mode, we call the set_pasid_table() callback on each STE update to pass the guest stage 1 configuration to the host and apply it at physical level. In the case of live migration, we need to manual call the set_pasid_table() to load the guest stage 1 configurations to the host. If this

Re: [PATCH qemu] spapr: Rename RTAS_MAX_ADDR to FDT_MAX_ADDR

2021-03-31 Thread Greg Kurz
On Wed, 31 Mar 2021 13:51:23 +1100 Alexey Kardashevskiy wrote: > SLOF instantiates RTAS since > 744a928ccee9 ("spapr: Stop providing RTAS blob") > so the max address applies to the FDT only. > > This renames the macro and fixes up the comment. > > This should not cause any behavioral change. >

Re: [PATCH] target/arm: Make number of counters in PMCR follow the CPU

2021-03-31 Thread Zenghui Yu
[+kvmarm, Marc] On 2021/3/12 0:59, Peter Maydell wrote: Currently we give all the v7-and-up CPUs a PMU with 4 counters. This means that we don't provide the 6 counters that are required by the Arm BSA (Base System Architecture) specification if the CPU supports the Virtualization extensions.

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-31 Thread Igor Mammedov
On Wed, 31 Mar 2021 10:46:49 +1100 David Gibson wrote: > On Tue, Mar 30, 2021 at 01:28:31AM +0200, Igor Mammedov wrote: > > On Wed, 24 Mar 2021 16:09:59 -0300 > > Daniel Henrique Barboza wrote: > > > > > On 3/23/21 10:40 PM, David Gibson wrote: > > > > On Tue, Mar 23, 2021 at 02:10:22PM

[RFC PATCH 0/6] Introduce cluster cpu topology support

2021-03-31 Thread Yanan Wang
Hi, This series introduces the cluster cpu topology support, besides now existing sockets, cores, and threads. A cluster means a group of cores that share some resources (e.g. cache) among them under the LLC. For example, ARM64 server chip Kunpeng 920 has 6 or 8 clusters in each NUMA, and each

[PULL for-6.0 5/6] test-coroutine: Add rwlock upgrade test

2021-03-31 Thread Stefan Hajnoczi
From: Paolo Bonzini Test that rwlock upgrade is fair, and that readers go back to sleep if a writer is in line. Signed-off-by: Paolo Bonzini Message-id: 20210325112941.365238-6-pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/unit/test-coroutine.c | 62

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-31 Thread David Gibson
On Wed, Mar 31, 2021 at 06:04:27AM +0200, Greg Kurz wrote: > On Wed, 31 Mar 2021 11:09:06 +1100 > David Gibson wrote: > > > On Tue, Mar 30, 2021 at 08:01:13AM -0700, Richard Henderson wrote: > > > On 3/29/21 10:54 PM, David Gibson wrote: > > > >B) Just the hflags patches from my / Richard's

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-31 Thread Richard Henderson
On 3/30/21 10:47 PM, David Gibson wrote: Richard - the remaining possible problem with the hflags stuff seems to manifest with the assert failing in the last patch. However, I'm guess that's just exposing some more subtle problem introduced by an earlier patch. Any chance you could re-order

[PATCH v3] hw/block/nvme: add device self test command support

2021-03-31 Thread Gollu Appalanaidu
This is to add support for Device Self Test Command (DST) and DST Log Page. Refer NVM Express specification 1.4b section 5.8 ("Device Self-test command") Signed-off-by: Gollu Appalanaidu --- changes: -v3: removed unwanted patch file added -v2: addressed style fixes in hw/block/nvme.h

Re: [PATCH] target/arm: Make number of counters in PMCR follow the CPU

2021-03-31 Thread Peter Maydell
On Wed, 31 Mar 2021 at 09:59, Zenghui Yu wrote: > > [+kvmarm, Marc] > > On 2021/3/12 0:59, Peter Maydell wrote: > > Currently we give all the v7-and-up CPUs a PMU with 4 counters. This > > means that we don't provide the 6 counters that are required by the > > Arm BSA (Base System Architecture)

[PULL for-6.0 4/6] coroutine-lock: Reimplement CoRwlock to fix downgrade bug

2021-03-31 Thread Stefan Hajnoczi
From: Paolo Bonzini An invariant of the current rwlock is that if multiple coroutines hold a reader lock, all must be runnable. The unlock implementation relies on this, choosing to wake a single coroutine when the final read lock holder exits the critical section, assuming that it will wake a

[PATCH] hw/block/nvme: add device self test command support

2021-03-31 Thread Gollu Appalanaidu
This is to add support for Device Self Test Command (DST) and DST Log Page. Refer NVM Express specification 1.4b section 5.8 ("Device Self-test command") Signed-off-by: Gollu Appalanaidu --- hw/block/nvme.c | 118 +- hw/block/nvme.h | 13

[PATCH] configure: Do not use default_feature for EXESUF

2021-03-31 Thread mrezanin
From: Miroslav Rezanina Commit "c87ea11631 configure: add --without-default-features" use default_feature to set default values for configure option. This value is used for EXESUF too. However, EXESUF is not option to be tested, it is just append to any binary name so using

Re: An error due to installation that require binutils package

2021-03-31 Thread John Simpson
Got you Stefano, Appreciate for your reply. On Tue, Mar 30, 2021 at 8:46 AM Stefano Garzarella wrote: > Hi John, > > On Mon, Mar 29, 2021 at 09:46:49PM +0300, John Simpson wrote: > >Hello, > > > >Kindly ask you to have a look at this bug. > >Thank you for your replies. > > It's already fixed

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-31 Thread Greg Kurz
On Tue, 30 Mar 2021 22:37:06 +0530 Vaibhav Jain wrote: > > Thanks for looking into this patch Greg. My responses below inline. > > > Greg Kurz writes: > > > Hi Vaibhav, > > > > Great to see you around :-) > > :-) > > > > > On Mon, 29 Mar 2021 21:52:59 +0530 > > Vaibhav Jain wrote: > > >

[RFC PATCH 3/6] hw/arm/virt: Parse cluster cpu topology for ARM machines

2021-03-31 Thread Yanan Wang
There is a separate function virt_smp_parse() in hw/virt/arm.c used to parse cpu topology for the ARM machines. And there are some ARM implementations that have the concept of cluster, for example, ARM64 server chip Kunpeng 920 has 6 or 8 clusters in each NUMA node and each cluster has 4 cores.

[PULL for-6.0 3/6] coroutine-lock: Store the coroutine in the CoWaitRecord only once

2021-03-31 Thread Stefan Hajnoczi
From: David Edmondson When taking the slow path for mutex acquisition, set the coroutine value in the CoWaitRecord in push_waiter(), rather than both there and in the caller. Reviewed-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Edmondson Signed-off-by: Paolo

[PULL for-6.0 6/6] test-coroutine: Add rwlock downgrade test

2021-03-31 Thread Stefan Hajnoczi
From: David Edmondson Test that downgrading an rwlock does not result in a failure to schedule coroutines queued on the rwlock. The diagram associated with test_co_rwlock_downgrade() describes the intended behaviour, but what was observed previously corresponds to: | c1 | c2 | c3

Re: [PATCH] target/openrisc: fix icount handling for timer instructions

2021-03-31 Thread Stafford Horne
On Wed, Mar 31, 2021 at 10:27:21AM +0300, Pavel Dovgalyuk wrote: > On 31.03.2021 01:05, Stafford Horne wrote: > > Hi Pavel, > > > > Thanks for the patch. > > > > On Mon, Mar 29, 2021 at 10:42:41AM +0300, Pavel Dovgalyuk wrote: > > > This patch adds icount handling to mfspr/mtspr instructions > >

Re: [PATCH v1 2/6] tests/docker: don't set DOCKER_REGISTRY on non-x86_64

2021-03-31 Thread Philippe Mathieu-Daudé
Hi Alex, Willian, On 3/29/21 1:02 PM, Alex Bennée wrote: > Currently our gitlab registry is x86_64 only so attempting to pull an > image from it on something else will end in tears. > > Signed-off-by: Alex Bennée > --- > tests/docker/Makefile.include | 5 - > 1 file changed, 4

[PATCH] block/export: improve vu_blk_sect_range_ok()

2021-03-31 Thread Stefan Hajnoczi
The checks in vu_blk_sect_range_ok() assume VIRTIO_BLK_SECTOR_SIZE is equal to BDRV_SECTOR_SIZE. This is true, but let's add a QEMU_BUILD_BUG_ON() to make it explicit. We might as well check that the request buffer size is a multiple of VIRTIO_BLK_SECTOR_SIZE while we're at it. Suggested-by: Max

Re: [PULL 0/1] Linux user for 6.0 patches

2021-03-31 Thread Peter Maydell
On Tue, 30 Mar 2021 at 15:49, Laurent Vivier wrote: > > The following changes since commit ec2e6e016d24bd429792d08cf607e4c5350dcdaa: > > Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-= > request' into staging (2021-03-28 19:49:57 +0100) > > are available in the Git

Re: [PATCH] gitlab-ci.yml: Fix the filtering for the git submodules

2021-03-31 Thread Willian Rampazzo
On Wed, Mar 31, 2021 at 4:33 AM Thomas Huth wrote: > > Commit 7d7dbf9dc15be6e introduced a new line starting with > "GIT_SUBMODULES_ACTION=" in the config-host.mak file. The grep that > tries to determine the submodules in the gitlab-ci.yml file matches > this new line, too, causing a warning

Re: [PATCH for-6.1] hw: add compat machines for 6.1

2021-03-31 Thread Greg Kurz
On Wed, 31 Mar 2021 13:19:00 +0200 Cornelia Huck wrote: > Add 6.1 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck > --- > hw/arm/virt.c | 7 ++- > hw/core/machine.c | 3 +++ > hw/i386/pc.c | 3 +++ > hw/i386/pc_piix.c

Re: [PATCH] hw/riscv: sifive_e: Add 'const' to sifive_e_memmap[]

2021-03-31 Thread Philippe Mathieu-Daudé
On 3/31/21 12:36 PM, Bin Meng wrote: > This was accidentally dropped before. Add it back. > Fixes: 732612856a8 ("hw/riscv: Drop 'struct MemmapEntry'") > Reported-by: Emmanuel Blot > Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé > --- > > hw/riscv/sifive_e.c | 2 +- > 1 file

Re: [PATCH] target/openrisc: fix icount handling for timer instructions

2021-03-31 Thread Paolo Bonzini
On 31/03/21 14:48, Pavel Dovgalyuk wrote: Acked-by: Stafford Horne I am not currently maintaining an openrisc queue, but I could start one.  Do you have another way to submit this upstream? Paolo, can you queue this one? Sure, done. Paolo

Re: [PATCH] virtiofsd: Changed allocations of fuse_session to GLib's functions

2021-03-31 Thread Stefan Hajnoczi
On Wed, Mar 24, 2021 at 08:49:43AM +0200, Mahmoud Mandour wrote: > Replaced the allocation and deallocation of fuse_session structs > from calloc() and free() calls to g_try_new0() and g_free(). > > Signed-off-by: Mahmoud Mandour > --- > tools/virtiofsd/fuse_lowlevel.c | 6 +++--- > 1 file

Re: [PATCH] target/openrisc: fix icount handling for timer instructions

2021-03-31 Thread Pavel Dovgalyuk
CC'ed Paolo. On 31.03.2021 15:33, Stafford Horne wrote: On Wed, Mar 31, 2021 at 10:27:21AM +0300, Pavel Dovgalyuk wrote: On 31.03.2021 01:05, Stafford Horne wrote: Hi Pavel, Thanks for the patch. On Mon, Mar 29, 2021 at 10:42:41AM +0300, Pavel Dovgalyuk wrote: This patch adds icount

Re: An error due to installation that require binutils package

2021-03-31 Thread George Dunlap via
[Dropping some irrelevant cc’s] > On Mar 30, 2021, at 1:46 PM, Stefano Garzarella wrote: > > Hi John, > > On Mon, Mar 29, 2021 at 09:46:49PM +0300, John Simpson wrote: >> Hello, >> >> Kindly ask you to have a look at this bug. >> Thank you for your replies. > > It's already fixed in QEMU

Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

2021-03-31 Thread David Hildenbrand
On 31.03.21 12:41, Steven Price wrote: On 31/03/2021 10:32, David Hildenbrand wrote: On 31.03.21 11:21, Catalin Marinas wrote: On Wed, Mar 31, 2021 at 09:34:44AM +0200, David Hildenbrand wrote: On 30.03.21 12:30, Catalin Marinas wrote: On Mon, Mar 29, 2021 at 05:06:51PM +0100, Steven Price

Re: [PATCH for-6.0 0/2] document gdbstub debugging of multicore machines

2021-03-31 Thread Alex Bennée
Peter Maydell writes: > The way gdb and our gdbstub handle multicore and multicluster > machines is not very obvious. This patchset adds some documentation > of how to do it. In particular it gives the necessary runes > for how to get gdb to work with machines which have multiple > clusters

[PATCH v2] i386: Make 'hv-reenlightenment' require explicit 'tsc-frequency' setting

2021-03-31 Thread Vitaly Kuznetsov
Commit 561dbb41b1d7 "i386: Make migration fail when Hyper-V reenlightenment was enabled but 'user_tsc_khz' is unset" forbade migrations with when guest has opted for reenlightenment notifications but 'tsc-frequency' wasn't set explicitly on the command line. This works but the migration fails late

[PATCH for-6.1] hw: add compat machines for 6.1

2021-03-31 Thread Cornelia Huck
Add 6.1 machine types for arm/i440fx/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 7 ++- hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 14 +- hw/i386/pc_q35.c | 13 -

Re: [PATCH qemu v16] spapr: Implement Open Firmware client interface

2021-03-31 Thread BALATON Zoltan
On Thu, 25 Mar 2021, Alexey Kardashevskiy wrote: On 25/03/2021 13:52, David Gibson wrote: On Tue, Mar 23, 2021 at 01:58:30PM +1100, Alexey Kardashevskiy wrote: The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it

[PATCH] iotests: Test mirror-top filter permissions

2021-03-31 Thread Max Reitz
Add a test accompanying commit 53431b9086b2832ca1aeff0c55e186e9ed79bd11 ("block/mirror: Fix mirror_top's permissions"). Signed-off-by: Max Reitz --- tests/qemu-iotests/tests/mirror-top-perms | 121 ++ tests/qemu-iotests/tests/mirror-top-perms.out | 5 + 2 files changed,

Re: [RFC 3/8] virtio: Add API to batch set host notifiers

2021-03-31 Thread Stefan Hajnoczi
On Tue, Mar 30, 2021 at 04:17:32PM +0200, Greg Kurz wrote: > On Tue, 30 Mar 2021 14:55:42 +0100 > Stefan Hajnoczi wrote: > > > On Tue, Mar 30, 2021 at 12:17:40PM +0200, Greg Kurz wrote: > > > On Mon, 29 Mar 2021 18:10:57 +0100 > > > Stefan Hajnoczi wrote: > > > > On Thu, Mar 25, 2021 at

Re: [PATCH for-6.0 3/3] migration: Pre-fault memory before starting background snasphot

2021-03-31 Thread Andrey Gruzdev
On 31.03.2021 20:37, David Hildenbrand wrote: On 31.03.21 19:33, David Hildenbrand wrote: On 31.03.21 19:28, Andrey Gruzdev wrote: This commit solves the issue with userfault_fd WP feature that background snapshot is based on. For any never poluated or discarded memory page, the

[PATCH v6 4/4] Add NVMM Accelerator: add maintainers for NetBSD/NVMM

2021-03-31 Thread Reinoud Zandijk
Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 554be84b32..cf9d81ea7c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -510,6 +510,15 @@ F: accel/stubs/hax-stub.c F:

Re: [PATCH] iotests: Test mirror-top filter permissions

2021-03-31 Thread Eric Blake
On 3/31/21 7:28 AM, Max Reitz wrote: > Add a test accompanying commit 53431b9086b2832ca1aeff0c55e186e9ed79bd11 > ("block/mirror: Fix mirror_top's permissions"). > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/tests/mirror-top-perms | 121 ++ >

Re: [PATCH v3 0/8] [RfC] fix tracing for modules

2021-03-31 Thread Gerd Hoffmann
Hi, > > Well, "make install" with --prefix=$HOME/qemu-install fixed that for the > > time > > being. > > > > Now I have this: > > > > kraxel@sirius ~/qemu-install/bin# sudo ./qemu-trace-stap -v run > > ./qemu-system-x86_64 "qxl_soft_reset" > > Using tapset dir

Re: [RFC v1 1/5] hw/s390x: only build qemu-tod from the CONFIG_TCG build

2021-03-31 Thread Cornelia Huck
On Mon, 22 Mar 2021 20:15:47 +0100 Claudio Fontana wrote: > this allows to remove unneeded stubs for target/s390x. This patch doesn't seem to remove any, though? > > Signed-off-by: Claudio Fontana > --- > hw/s390x/tod.c | 9 - > hw/s390x/meson.build | 5 - > 2 files

Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

2021-03-31 Thread Catalin Marinas
On Wed, Mar 31, 2021 at 11:41:20AM +0100, Steven Price wrote: > On 31/03/2021 10:32, David Hildenbrand wrote: > > On 31.03.21 11:21, Catalin Marinas wrote: > > > On Wed, Mar 31, 2021 at 09:34:44AM +0200, David Hildenbrand wrote: > > > > On 30.03.21 12:30, Catalin Marinas wrote: > > > > > On Mon,

[PATCH v6 2/4] Add NVMM accelerator: x86 CPU support

2021-03-31 Thread Reinoud Zandijk
Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski --- target/i386/meson.build |1 + target/i386/nvmm/meson.build |4 + target/i386/nvmm/nvmm-accel-ops.c | 111 +++ target/i386/nvmm/nvmm-accel-ops.h | 25 + target/i386/nvmm/nvmm-all.c | 1231

Re: Bug: object-add qmp command that used to work fails now

2021-03-31 Thread Lukas Straub
On Wed, 31 Mar 2021 15:16:18 -0500 Eric Blake wrote: > On 3/31/21 3:00 PM, Lukas Straub wrote: > > Hi, > > This qmp command that used to work: > > {"execute": "object-add", "arguments": {"qom-type": "filter-mirror", "id": > > "m0", "props": {"netdev": "hn0", "queue": "tx", "outdev": "mirror0",

Re: [PATCH for-6.0 3/3] migration: Pre-fault memory before starting background snasphot

2021-03-31 Thread Andrey Gruzdev
On 31.03.2021 20:33, David Hildenbrand wrote: On 31.03.21 19:28, Andrey Gruzdev wrote: This commit solves the issue with userfault_fd WP feature that background snapshot is based on. For any never poluated or discarded memory page, the UFFDIO_WRITEPROTECT ioctl() would skip updating PTE for

Re: [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-03-31 Thread Alex Bennée
Paolo Bonzini writes: > + > +This isn't an exhaustive list of things that you can't do. Rather, take > +it in the spirit in which it's intended—a guide to make it easier to > +be excellent to each other. I think a colon might work better here: Rather, take it in the spirit in which it's

Re: [PATCH] migration: Remove time_t cast for OpenBSD

2021-03-31 Thread Brad Smith
On 3/13/2021 6:33 PM, Brad Smith wrote: On 3/11/2021 1:39 PM, Daniel P. Berrangé wrote: On Thu, Mar 11, 2021 at 06:28:57PM +, Dr. David Alan Gilbert wrote: * Laurent Vivier (laur...@vivier.eu) wrote: Le 08/03/2021 à 12:46, Thomas Huth a écrit : On 22/02/2021 08.28, Brad Smith wrote:

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-31 Thread Daniel Henrique Barboza
On 3/30/21 8:46 PM, David Gibson wrote: On Tue, Mar 30, 2021 at 01:28:31AM +0200, Igor Mammedov wrote: On Wed, 24 Mar 2021 16:09:59 -0300 Daniel Henrique Barboza wrote: On 3/23/21 10:40 PM, David Gibson wrote: On Tue, Mar 23, 2021 at 02:10:22PM -0300, Daniel Henrique Barboza wrote: On

Bug: object-add qmp command that used to work fails now

2021-03-31 Thread Lukas Straub
Hi, This qmp command that used to work: {"execute": "object-add", "arguments": {"qom-type": "filter-mirror", "id": "m0", "props": {"netdev": "hn0", "queue": "tx", "outdev": "mirror0", "vnet_hdr_support": false}}} now fails with the following error: {"error": {"class": "GenericError", "desc":

[PATCH v6 3/4] Add NVMM accelerator: acceleration enlightenments

2021-03-31 Thread Reinoud Zandijk
Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski --- include/sysemu/hw_accel.h | 1 + include/sysemu/nvmm.h | 26 ++ target/i386/helper.c | 2 +- 3 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 include/sysemu/nvmm.h diff

[PATCH v6 1/4] Add NVMM accelerator: configure and build logic

2021-03-31 Thread Reinoud Zandijk
Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski --- accel/Kconfig | 3 +++ configure | 12 +--- meson.build | 23 --- meson_options.txt | 2 ++ qemu-options.hx | 8 5 files changed, 38 insertions(+), 10 deletions(-)

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-31 Thread Daniel Henrique Barboza
On 3/29/21 8:28 PM, Igor Mammedov wrote: On Wed, 24 Mar 2021 16:09:59 -0300 Daniel Henrique Barboza wrote: On 3/23/21 10:40 PM, David Gibson wrote: On Tue, Mar 23, 2021 at 02:10:22PM -0300, Daniel Henrique Barboza wrote: On 3/22/21 10:12 PM, David Gibson wrote: On Fri, Mar 12, 2021 at

[PATCH v6 0/4] Implements the NetBSD Virtual Machine Monitor accelerator

2021-03-31 Thread Reinoud Zandijk
The NetBSD team has been working hard on a new user-mode API for our hypervisor that will be released as part of the upcoming NetBSD 9.0. The NetBSD team has implemented its new hypervisor called NVMM. It has been included since NetBSD 9.0 and has been in use now for quite some time. NVMM adds

Re: [PATCH] block/export: improve vu_blk_sect_range_ok()

2021-03-31 Thread Eric Blake
On 3/31/21 9:27 AM, Stefan Hajnoczi wrote: > The checks in vu_blk_sect_range_ok() assume VIRTIO_BLK_SECTOR_SIZE is > equal to BDRV_SECTOR_SIZE. This is true, but let's add a > QEMU_BUILD_BUG_ON() to make it explicit. > > We might as well check that the request buffer size is a multiple of >

  1   2   3   >