On 5/20/21 9:53 PM, Willian Rampazzo wrote:
> Conceptually speaking, acceptance tests "are a series of specific tests
> conducted by the customer in an attempt to uncover product errors before
> accepting the software from the developer. Conducted by the end-user rather
> than software engineers,
Thank you for fixing the problem.
I confirmed that https://bugs.launchpad.net/bugs/1924231 is fixed with
https://launchpad.net/~ci-train-ppa-
service/+archive/ubuntu/4535/+packages.
Thank you.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed
John Snow writes:
> On 5/20/21 10:42 AM, Markus Armbruster wrote:
>> First step is to find out how _end_section() can be called twice in a
>> row. It isn't in all of "make check". Hmm.
>
> Ah, maybe not twice in a *row*. It does seem to be called when we have
> an "empty section" sometimes,
On Wed, May 12, 2021 at 07:12:20PM -0400, John Snow wrote:
> Add setup.cfg and setup.py, necessary for installing a package via
> pip. Add a ReST document (PACKAGE.rst) explaining the basics of what
> this package is for and who to contact for more information. This
> document will be used as the
A bus lock is acquired through either split locked access to writeback
(WB) memory or any locked access to non-WB memory. It is typically >1000
cycles slower than an atomic operation within a cache and can also
disrupts performance on other cores.
Virtual Machines can exploit bus locks to degrade
Since commit e2e7168a214b0ed98dc357bba96816486a289762, if oprsz
is still zero(as we don't use this field), simd_desc will trigger an
assert.
Besides, tcg_gen_gvec_*_ptr calls simd_desc in it's implementation.
Here we pass the value to maxsz and oprsz to bypass the assert.
Signed-off-by: LIU
ping.
or there is other suggestion so that qxl can be used on system
with 16K pagesize.
regards
bibo, mao
在 2021年05月18日 20:20, Bibo Mao 写道:
> From: maobibo
>
> On some MIPS system, page size is 16K, and qxl vga device can
> be used for VM in kvm mode. Qxl pci rom size is set 8K fixed,
>
Patchew URL:
https://patchew.org/QEMU/20210521030146.2831663-1-...@linux.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210521030146.2831663-1-...@linux.ibm.com
Subject: [PATCH 0/2] Fix SIGILL psw.addr
Besides some internal changes, new features, and bug fixes, on the QEMU side,
this version fixes the following message seen when running the acceptance
tests: "Error running method "pre_tests" of plugin "fetchasset": 'bytes'
object has no attribute 'encode'".
The release notes are available at
CI pipeline: https://gitlab.com/willianrampazzo/qemu/-/pipelines/306904401
Besides some internal changes, new features, and bug fixes, on the QEMU side,
this version fixes the following message seen when running the acceptance
tests: "Error running method "pre_tests" of plugin "fetchasset":
Signed-off-by: John Snow
---
This can be merged with the previous commit, if desired.
Signed-off-by: John Snow
---
scripts/qapi/pylintrc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index c5275d5f59b..1a633b2b88e 100644
Eh. Two properties, a bool method and a public method are non-trivial
enough for me. (Especially in typed python!)
Signed-off-by: John Snow
---
scripts/qapi/parser.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index
It simplifies the typing to say that _section is always a
QAPIDoc.Section().
To accommodate this change, we must allow for this object to evaluate to
False for functions like _end_section which behave differently based on
whether or not a Section has been started.
Signed-off-by: John Snow
---
Signed-off-by: John Snow
---
As always, this can be merged with the previous commit.
Signed-off-by: John Snow
---
scripts/qapi/mypy.ini | 5 -
1 file changed, 5 deletions(-)
diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini
index 54ca4483d6d..66253564297 100644
---
This is part five (b), and focuses on QAPIDoc in parser.py.
gitlab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5b
Requirements:
- Python 3.6+
- mypy >= 0.770
- pylint >= 2.6.0 (2.7.0+ when using Python 3.9+)
Every commit should pass with:
- `isort -c qapi/`
- `flake8 qapi/`
Annotations do not change runtime behavior.
This commit adds mostly annotations, but uses a TYPE_CHECKING runtime
check to conditionally import dependencies, which only triggers during
runs of mypy.
Signed-off-by: John Snow
---
TopLevelExpr, an idea from previous drafts, makes a return here
On 21/05/2021 07:59, BALATON Zoltan wrote:
On Thu, 20 May 2021, Alexey Kardashevskiy wrote:
The PAPR platform describes an OS environment that's presented by
a combination of a hypervisor and firmware. The features it specifies
require collaboration between the firmware and the hypervisor.
Verify that s390x-specific uc_mcontext.psw.addr is reported correctly.
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.target | 1 +
tests/tcg/s390x/sigill.c| 41 +
2 files changed, 42 insertions(+)
create mode 100644
On Thu, 2021-05-20 at 23:36 +0200, Philippe Mathieu-Daudé wrote:
> On 2/15/21 2:16 PM, Paolo Bonzini wrote:
> > From: James Bottomley
> >
> > If the gpa isn't specified, it's value is extracted from the OVMF
> > properties table located below the reset vector (and if this
> > doesn't
> > exist,
On Thu, May 20, 2021 at 11:51 PM Peter Maydell wrote:
>
> On Tue, 11 May 2021 at 11:21, Alistair Francis
> wrote:
> >
> > From: Hou Weiying
> >
> > This commit adds support for ePMP v0.9.1.
> >
> > The ePMP spec can be found in:
> >
Pylint informs us we're not using these arguments. Oops, it's
right. Correct the error message and remove the remaining unused
parameter.
Fix test output now that the error message is improved.
Fixes: e151941d1b
Signed-off-by: John Snow
---
scripts/qapi/parser.py| 16
On Fri, May 21, 2021 at 6:56 AM Alistair Francis
wrote:
>
> Although we construct epmp_operation in such a way that it can only be
> between 0 and 15 Coverity complains that we don't handle the other
> possible cases. To fix Coverity and make it easier for humans to read
> add a default case to
From: Ruimei Yan
At present MSI / MSI-X interrupts are triggered regardless of the
irq level. We should have checked the level to determine whether
the interrupt needs to be delivered.
The level check logic was present in early versions of the xhci
model, but got dropped later by a rework of
ping
邹旭 于2021年5月14日周五 下午5:23写道：
> From e805b793f7d4b3e8c37d540b7d6cc0c6ac682311 Mon Sep 17 00:00:00 2001
> From: Xu Zou
> Date: Fri, 14 May 2021 15:55:07 +0800
> Subject: [PATCH] linux-user: Handle EXCP10_COPR properly for i386
>
> Handle EXCP10_COPR properly for i386 in cpu loop.
>
> NE flag
On 5/20/21 11:05 AM, Markus Armbruster wrote:
John Snow writes:
Annotations do not change runtime behavior.
This commit adds mostly annotations, but uses a TYPE_CHECKING runtime
check to conditionally import dependencies, which only triggers during
runs of mypy.
Signed-off-by: John Snow
From: Ruimei Yan
Per xHCI spec v1.2 chapter 4.17.5 page 296:
If MSI or MSI-X interrupts are enabled, Interrupt Pending (IP)
shall be cleared automatically when the PCI dword write generated
by the interrupt assertion is complete.
Currently QEMU does not clear the IP flag in the MSI /
On 5/21/21 6:55 AM, Alistair Francis wrote:
On Thu, May 20, 2021 at 11:55 PM Peter Maydell wrote:
On Tue, 11 May 2021 at 11:22, Alistair Francis wrote:
Signed-off-by: Alistair Francis
Reviewed-by: Richard Henderson
Message-id:
qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it
should be a pointer to the instruction following the illegal
instruction, but at the moment it is a pointer to the illegal
instruction itself. This breaks OpenJDK, which relies on this value.
Patch 1 fixes the issue, patch 2
It was not supposed to be an RFC, resending as PATCH.
On Thu, May 20, 2021 at 5:51 PM Willian Rampazzo wrote:
>
> CI pipeline: https://gitlab.com/willianrampazzo/qemu/-/pipelines/306904401
>
> Besides some internal changes, new features, and bug fixes, on the QEMU side,
> this version fixes the
On Thu, Apr 22, 2021 at 06:11:20PM +0200, Vitaly Kuznetsov wrote:
> The intention is to call hyperv_expand_features() early, before vCPUs
> are created and use the acquired data later when we set guest visible
> CPUID data.
>
> Signed-off-by: Vitaly Kuznetsov
Reviewed-by: Eduardo Habkost
--
On 2/15/21 2:16 PM, Paolo Bonzini wrote:
> From: James Bottomley
>
> If the gpa isn't specified, it's value is extracted from the OVMF
> properties table located below the reset vector (and if this doesn't
> exist, an error is returned). OVMF has defined the GUID for the SEV
> secret area as
Reviewed-by: LIU Zhiwei
On 5/21/21 6:55 AM, Alistair Francis wrote:
Although we construct epmp_operation in such a way that it can only be
between 0 and 15 Coverity complains that we don't handle the other
possible cases. To fix Coverity and make it easier for humans to read
add a default case
When a s390x CPU attempts to execute an illegal instruction, an
operation exception is recognized. This is a suppressing exception,
which means that the PSW is advanced by the length of the illegal
instruction.
On the real hardware or in qemu-system-s390x the kernel then raises
SIGILL with
CI pipeline: https://gitlab.com/willianrampazzo/qemu/-/pipelines/306904401
Besides some internal changes, new features, and bug fixes, on the QEMU side,
this version fixes the following message seen when running the acceptance
tests: "Error running method "pre_tests" of plugin "fetchasset":
Besides some internal changes, new features, and bug fixes, on the QEMU side,
this version fixes the following message seen when running the acceptance
tests: "Error running method "pre_tests" of plugin "fetchasset": 'bytes'
object has no attribute 'encode'".
The release notes are available at
On Thu, 20 May 2021, Alexey Kardashevskiy wrote:
The PAPR platform describes an OS environment that's presented by
a combination of a hypervisor and firmware. The features it specifies
require collaboration between the firmware and the hypervisor.
Since the beginning, the runtime component of
On 5/20/21 10:42 AM, Markus Armbruster wrote:
First step is to find out how _end_section() can be called twice in a
row. It isn't in all of "make check". Hmm.
Ah, maybe not twice in a *row*. It does seem to be called when we have
an "empty section" sometimes, which arises from stuff like
On Thu, May 20, 2021 at 11:55 PM Peter Maydell wrote:
>
> On Tue, 11 May 2021 at 11:22, Alistair Francis
> wrote:
> >
> > Signed-off-by: Alistair Francis
> > Reviewed-by: Richard Henderson
> > Message-id:
> > fcc125d96da941b56c817c9dd6068dc36478fc53.1619234854.git.alistair.fran...@wdc.com
>
Although we construct epmp_operation in such a way that it can only be
between 0 and 15 Coverity complains that we don't handle the other
possible cases. To fix Coverity and make it easier for humans to read
add a default case to the switch statement that calls
g_assert_not_reached().
Fixes: CID
On 19/05/2021 20.45, Philippe Mathieu-Daudé wrote:
Add the $MAKE variable to call GNU make, and set it to 'gmake'
on FreeBSD to avoid:
$ make -j"$JOBS"
make: Unknown modifier ','
make: "/builds/dTyar424/0/qemu/build/Makefile" line 3: Need an operator
make:
rdma_freeaddrinfo() is the reverse operation of rdma_getaddrinfo()
Signed-off-by: Li Zhijian
---
migration/rdma.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/migration/rdma.c b/migration/rdma.c
index 7e7595faab..651534e825 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@
On 19/05/2021 20.45, Philippe Mathieu-Daudé wrote:
If a runner has ccache installed, use it and display statistics
at the end of the build.
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.d/buildtest-template.yml | 5 +
1 file changed, 5 insertions(+)
diff --git
destination side:
$ build/qemu-system-x86_64 -enable-kvm -netdev
tap,id=hn0,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -device
e1000,netdev=hn0,mac=50:52:54:00:11:22 -boot c -drive
if=none,file=./Fedora-rdma-server-migration.qcow2,id=drive-virtio-disk0 -device
source side always blocks if postcopy is only enabled at source side.
users are not able to cancel this migration in this case.
Here we try to get the cm_event every 100ms tile timeout.
Signed-off-by: Li Zhijian
---
migration/rdma.c | 59
1 file
Hello all,
I found the latest Qemu release can't bootup the VM with latest guest
kernel(>5.13).
The normal v6.0.0 release is good to bootup the latest guest kernel.
There are two issues were found
1. Guest kernel panic.
2. kvm disabled by bios
The panic log as below:
[2.250024] BUG:
From: Peter Xu
kvm_physical_sync_dirty_bitmap() calculates the ramblock offset in an
awkward way from the MemoryRegionSection that passed in from the
caller. The truth is for each KVMSlot the ramblock offset never
change for the lifecycle. Cache the ramblock offset for each KVMSlot
into the
Right now --with-git-submodules=ignore has a subtle difference from
just running without a .git directory, in that it does not check
that submodule sources actually exist. Move the check for
ui/keycodemapdb/README so that it happens even if the user
specified --with-git-submodules=ignore, with a
From: Yang Zhong
Expose AVX (VEX-encoded) versions of the Vector Neural Network
Instructions to guest.
The bit definition:
CPUID.(EAX=7,ECX=1):EAX[bit 4] AVX_VNNI
The following instructions are available when this feature is
present in the guest.
1. VPDPBUS: Multiply and Add Unsigned and
From: Peter Xu
Previously we have two places that will create the per KVMSlot dirty
bitmap:
1. When a newly created KVMSlot has dirty logging enabled,
2. When the first log_sync() happens for a memory slot.
The 2nd case is lazy-init, while the 1st case is not (which is a fix
of what the
From: Peter Xu
KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 is for KVM_CLEAR_DIRTY_LOG, which is only
useful for KVM_GET_DIRTY_LOG. Skip enabling it for kvm dirty ring.
More importantly, KVM_DIRTY_LOG_INITIALLY_SET will not wr-protect all the pages
initially, which is against how kvm dirty ring is used -
Do not guard each assignment with a check for --with-git-submodules=ignore.
To avoid a confusing "GIT" line from the Makefile, guard the
git-submodule-update
recipe so that it is empty when --with-git-submodules=ignore.
Signed-off-by: Paolo Bonzini
---
Makefile | 2 ++
configure | 20
From: Katsuhiro Ueno
Without this, libvixl cannot be compiled with macOS 11.3 SDK due to
include file name conflict (usr/include/c++/v1/version conflicts with
VERSION).
Signed-off-by: Katsuhiro Ueno
Message-Id:
Tested-by: Alexander Graf
Signed-off-by: Paolo Bonzini
---
meson.build | 1 +
1
From: Peter Xu
KVM dirty ring is a new interface to pass over dirty bits from kernel to the
userspace. Instead of using a bitmap for each memory region, the dirty ring
contains an array of dirtied GPAs to fetch (in the form of offset in slots).
For each vcpu there will be one dirty ring that
The qtest server right now can only be created using the -qtest
and -qtest-log options. Allow an alternative way to create it
using "-object qtest,chardev=...,log=...".
This is part of the long term plan to make more (or all) of
QEMU configurable through QMP and preconfig mode.
Signed-off-by:
The main advantage of 0.57 is that it fixes
https://github.com/mesonbuild/meson/pull/7900, thus avoiding unnecessary
rebuilds after running meson.
Signed-off-by: Paolo Bonzini
---
meson | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson b/meson
index
From: Peter Xu
kvm_physical_sync_dirty_bitmap() on the whole section is inaccurate, because
the section can be a superset of the memslot that we're working on. The result
is that if the section covers multiple kvm memslots, we could be doing the
synchronization for multiple times for each
From: Peter Xu
Add a parameter for dirty gfn count for dirty rings. If zero, dirty ring is
disabled. Otherwise dirty ring will be enabled with the per-vcpu gfn count as
specified. If dirty ring cannot be enabled due to unsupported kernel or
illegal parameter, it'll fallback to dirty logging.
Right now the SPICE module is special cased to be loaded when processing
of the -spice command line option. However, the spice option group
can also be brought in via -readconfig, in which case the module is
not loaded.
Add a generic hook to load modules that provide a QemuOpts group,
and use it
Only allow accelerator properties to be set when the
accelerator is being created.
Signed-off-by: Paolo Bonzini
---
accel/kvm/kvm-all.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 4e0168e88b..54c0860979 100644
should make some changes for this patch like below:
# git diff
diff --git a/migration/rdma.c b/migration/rdma.c
index 3b228c46ebf..067ea272276 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -316,7 +316,7 @@ typedef struct RDMALocalBlocks {
typedef struct RDMAContext {
char *host;
The replication.h file is included from migration/colo.c and
tests/unit/test-replication.c,
so it should be in include/.
Signed-off-by: Paolo Bonzini
---
block/replication.c | 2 +-
replication.h => include/block/replication.h | 4 ++--
migration/colo.c
These headers are also included from softmmu/vl.c, so they should be
in include/. Remove qemu-options-wrapper.h, since elsewhere
we include "template" headers directly and #define the parameters in
the including file; move qemu-options.h to include/.
Reviewed-by: Markus Armbruster
From: Peter Xu
Cache it too because we'll reference it more frequently in the future.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
Message-Id: <20210506160549.130416-8-pet...@redhat.com>
Signed-off-by: Paolo Bonzini
---
accel/kvm/kvm-all.c | 1 +
include/sysemu/kvm_int.h
Starting in QEMU 6.0's commit f5c9fcb82d ("vl: separate
qemu_create_machine", 2020-12-10), a function have_custom_ram_size()
replaced the return value of set_memory_options().
The purpose of the return value was to record the presence of
"-m size", and if it was not there, change the default RAM
On 20/05/2021 08:41, Mark Cave-Ayland wrote:
3) Add a new pci_isa_bridge_get_isabus(PCIDevice *d) function that the devices such
as via-ide can use to obtain a reference to the ISABus from their own PCIDevice. It
should hopefully be quite simple like this:
ISABus
On Thu, May 20, 2021 at 02:46:47AM +0200, BALATON Zoltan wrote:
> On Wed, 19 May 2021, John Snow wrote:
> > On 5/18/21 7:05 PM, BALATON Zoltan wrote:
> > > On Tue, 18 May 2021, Philippe Mathieu-Daudé wrote:
> > > > IDE bus depends on ISA bus for IRQ/DMA.
> > > >
> > > > Add an ISABus reference in
the error path after calling qemu_rdma_dest_init() should do rdma cleanup
Signed-off-by: Li Zhijian
---
migration/rdma.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 41726cc74a..7e7595faab 100644
--- a/migration/rdma.c
+++
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210512045821.3257963-1-phi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
configure | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 0e4233fd8a..1bb29fcda1
Creating and destroying QOM objects does not require a fully constructed
machine. Allow running object-add and object-del before machine
initialization has concluded.
Signed-off-by: Paolo Bonzini
---
hmp-commands.hx | 2 ++
qapi/qom.json | 6 --
2 files changed, 6 insertions(+), 2
From: Peter Xu
Per-kml slots_lock will bring some trouble if we want to take all slots_lock of
all the KMLs, especially when we're in a context that we could have taken some
of the KML slots_lock, then we even need to figure out what we've taken and
what we need to take.
Make this simple by
From: Peter Xu
Some of the memory listener may want to do log synchronization without
being able to specify a range of memory to sync but always globally.
Such a memory listener should provide this new method instead of the
log_sync() method.
Obviously we can also achieve similar thing when we
The following changes since commit 15e147b3c778f9f4c08c79b99747b848b6e2117b:
Merge remote-tracking branch 'remotes/nvme/tags/nvme-next-pull-request' into
staging (2021-05-18 12:22:16 +0100)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git
From: Philippe Mathieu-Daudé
Per the kconfig.rst:
A device should be listed [...] ``imply`` if (depending on
the QEMU command line) the board may or may not be started
without it.
This is the case with the NVDIMM device, so use the 'imply'
weak reverse dependency to select the symbol.
I/O to a disk via read/write is not limited by the number of segments allowed
by the host adapter; the kernel can split requests if needed, and the limit
imposed by the host adapter can be very low (256k or so) to avoid that SG_IO
returns EINVAL if memory is heavily fragmented.
Since this value
From: Peter Xu
Provide a helper kvm_slot_get_dirty_log() to make the function
kvm_physical_sync_dirty_bitmap() clearer. We can even cache the as_id
into KVMSlot when it is created, so that we don't even need to pass it
down every time.
Since at it, remove return value of
From: Philippe Mathieu-Daudé
On Fedora 32, using clang (version 10.0.1-3.fc32) we get:
tests/qtest/fuzz/fuzz.c:237:5: error: implicit declaration of function
'qemu_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
qemu_init(result.we_wordc, result.we_wordv, NULL);
Patchew URL:
https://patchew.org/QEMU/20210520082257.187061-1-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210520082257.187061-1-pbonz...@redhat.com
Subject: [PULL 00/26] Misc patches for
On Wed, 19 May 2021 11:48:21 +0100,
Steven Price wrote:
>
> On 17/05/2021 17:45, Marc Zyngier wrote:
> > On Mon, 17 May 2021 13:32:35 +0100,
> > Steven Price wrote:
> >>
> >> Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging
> >> for a VM. This will expose the feature to the
On 20/05/2021 09:35, Stefan Hajnoczi wrote:
I realized I don't really understand how ISA IDE and PCI IDE interact in
PIIX3:
- ISA IDE has well-known PIO registers that are always present?
- PCI IDE has the same registers, but the BAR must be mapped and PCI IO
space access must be enabled?
On Wed, 19 May 2021 at 13:52, David Gibson wrote:
>
> The following changes since commit c313e52e6459de2e9064767083a0c949c476e32b:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/linux-user-for-6.1-pull-request' into staging
> (2021-05-18 16:17:22 +0100)
>
> are available in the Git
The PAPR platform describes an OS environment that's presented by
a combination of a hypervisor and firmware. The features it specifies
require collaboration between the firmware and the hypervisor.
Since the beginning, the runtime component of the firmware (RTAS) has
been implemented as a 20
Hi Gerd,
> > +#ifdef CONFIG_LINUX
>
> > +void virtio_gpu_init_udmabuf(struct virtio_gpu_simple_resource *res)
>
> > +#else
>
> > +void *virtio_gpu_init_udmabuf(struct virtio_gpu_simple_resource *res)
> > +{
> > +/* nothing (stub) */
> > +return NULL
> > +}
>
> Fails to build for
On 19/05/2021 23.32, John Snow wrote:
Copied from Peter Krempa's libvirt template, feature.md.
CC: Peter Krempa
Signed-off-by: John Snow
---
.gitlab/issue_templates/feature_request.md | 13 +
1 file changed, 13 insertions(+)
create mode 100644
On Wed, May 19, 2021 at 17:32:01 -0400, John Snow wrote:
> Based loosely on libvirt's template, written by Peter Krempa.
>
> CC: Peter Krempa
> Signed-off-by: John Snow
> ---
> .gitlab/issue_templates/bug.md | 52 ++
> 1 file changed, 52 insertions(+)
> create
On Wed, May 19, 2021 at 06:46:01AM -0700, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20210519125148.27720-1-da...@gibson.dropbear.id.au/
So, these style warnings are actually existing style problems just
being triggered in checkpatch by code motion. Yes we'd like to
Such comments make reviewing this file somehow easier.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/virtio/virtio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index e02544b2df7..2b4c6c4b875 100644
--- a/hw/virtio/virtio.c
+++
Reviewed-by: John Snow
Reviewed-by: Max Reitz
Signed-off-by: Emanuele Giuseppe Esposito
---
python/qemu/qtest.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/python/qemu/qtest.py b/python/qemu/qtest.py
index afea210d9d..e6a8fb5984 100644
--- a/python/qemu/qtest.py
+++
Define -gdb flag and GDB_OPTIONS environment variable
to python tests to attach a gdbserver to each qemu instance.
This patch only adds and parses this flag, it does not yet add
the implementation for it.
if -gdb is not provided but $GDB_OPTIONS is set, ignore the
environment variable.
Introduce the "Debugging a test case" section, in preparation
to the additional flags that will be added in the next patches.
Signed-off-by: Emanuele Giuseppe Esposito
---
docs/devel/testing.rst | 8
1 file changed, 8 insertions(+)
diff --git a/docs/devel/testing.rst
rdma_freeaddrinfo() is the reverse operation of rdma_getaddrinfo()
Signed-off-by: Li Zhijian
---
migration/rdma.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/migration/rdma.c b/migration/rdma.c
index 7e7595faab..651534e825 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@
The priority will be given to gdb command line, meaning if the -gdb
parameter and -valgrind are given, gdb will be wrapped around
the qemu binary.
Signed-off-by: Emanuele Giuseppe Esposito
---
tests/qemu-iotests/iotests.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
The only limitation here is that running a script with gdbserver
will make the test output mismatch with the expected
results, making the test fail.
Signed-off-by: Emanuele Giuseppe Esposito
---
tests/qemu-iotests/common.rc | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff
Missing patch description. Could you please elaborate why this change is ok?
Thanks,
Thomas
On 19/05/2021 20.45, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.d/buildtest-template.yml | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
Currently, the check script only parses the option and sets the
VALGRIND_QEMU environmental variable to "y".
Add another local python variable that prepares the command line,
identical to the one provided in the test scripts.
Because the python script does not know in advance the valgring
PID to
On Thu, May 6, 2021 at 2:17 AM wrote:
>
> From: Kito Cheng
>
> Signed-off-by: Kito Cheng
> Signed-off-by: Frank Chang
> Reviewed-by: Richard Henderson
Reviewed-by: Alistair Francis
Alistair
> ---
> target/riscv/insn32.decode | 6
>
On Fri, May 14, 2021 at 3:24 PM Bin Meng wrote:
>
> riscv_excp_names[] and riscv_intr_names[] are only referenced by
> target/riscv/cpu.c locally.
>
> Signed-off-by: Bin Meng
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
>
> target/riscv/cpu.h | 2 --
> target/riscv/cpu.c | 4 ++--
>
On 19/05/2021 13.05, Philippe Mathieu-Daudé wrote:
On 5/19/21 10:23 AM, Thomas Huth wrote:
On 18/05/2021 21.32, Philippe Mathieu-Daudé wrote:
isa_superio_realize() calls isa_fdc_init_drives(), which is defined
in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol.
If I get that
On 19/05/21 16:40, Kevin Wolf wrote:
+qemu_opts_absorb_qdict(opts, qdict, errp);
Shouldn't we check that qdict is empty now and return an error if there
are any options that the QemuOptsList doesn't accept?
Indeed, my bad for not checking exactly the contract of
qemu_opts_absorb_qdict.
On 19/05/2021 00:05, BALATON Zoltan wrote:
On Tue, 18 May 2021, Philippe Mathieu-Daudé wrote:
IDE bus depends on ISA bus for IRQ/DMA.
Add an ISABus reference in PCIIDEState, and add link properties
to it in the PIIX and VIA objects (which inherit PCI_IDE).
Signed-off-by: Philippe
This series adds the option to attach gdbserver and valgrind
to the QEMU binary running in qemu_iotests.
It also allows to redirect QEMU binaries output of the python tests
to the stdout, instead of a log file.
Patches 1-6 introduce the -gdb option to both python and bash tests,
7-10 extend the
1 - 100 of 332 matches
Mail list logo
