Re: [PULL 0/3] Update meson version

2021-09-23 Thread Paolo Bonzini
On 22/09/21 20:22, Peter Maydell wrote: I had another go at this. As far as I can tell it causes all the vm-build-{openbsd,netbsd,freebsd} build-and-tests to hang. At any rate the VMs are sat there eating host CPU. Does 'make vm-build-freebsd' etc work for you ? It has been hanging for some

[PATCH v5 17/20] nubus-bridge: make slot_available_mask a qdev property

2021-09-23 Thread Mark Cave-Ayland
This is to allow Macintosh machines to further specify which slots are available since the number of addressable slots may not match the number of physical slots present in the machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/nubus/nubus-bridge.c | 7 +++ 1 file

[PATCH v5 19/20] q800: wire up nubus IRQs

2021-09-23 Thread Mark Cave-Ayland
Nubus IRQs are routed to the CPU through the VIA2 device so wire up the IRQs using gpios accordingly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/m68k/q800.c

[PATCH v5 20/20] q800: configure nubus available slots for Quadra 800

2021-09-23 Thread Mark Cave-Ayland
Slot 0x9 is reserved for use by the in-built framebuffer whilst only slots 0xc, 0xd and 0xe physically exist on the Quadra 800. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 9 + 1 file changed, 9 insertions(+)

Re: [PATCH] docs/nvdimm: Update nvdimm option value in machine example

2021-09-23 Thread Laurent Vivier
Le 23/09/2021 à 11:47, Pankaj Gupta a écrit : > ping Could you post your patch with an email address ("From") that is the same as the "Signed-off-by"? https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line Thanks, Laurent >> Update nvdimm option value in

Re: [PATCH] tests: qtest: bios-tables-test depends on the unpacked edk2 ROMs

2021-09-23 Thread Peter Maydell
On Thu, 23 Sept 2021 at 11:32, Paolo Bonzini wrote: > > On 23/09/21 12:00, Philippe Mathieu-Daudé wrote: > > See also "blobs: Only install required (system emulation) files": > > https://lore.kernel.org/qemu-devel/20210323155132.238193-1-f4...@amsat.org/ > > Nice and makes a lot of sense.

Re: [PATCH 2/6] iotests: add warning for rogue 'qemu' packages

2021-09-23 Thread Kevin Wolf
Am 23.09.2021 um 02:16 hat John Snow geschrieben: > Add a warning for when 'iotests' runs against a qemu namespace that > isn't the one in the source tree. This might occur if you have > (accidentally) installed the Python namespace package to your local > packages. > > (I'm not going to say that

Re: [PULL 18/28] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

2021-09-23 Thread Paolo Bonzini
On 22/09/21 21:51, Halil Pasic wrote: We have figured out what is going on here. The problem seems to be specific to linux aio, which seems to limit the size of the iovec to 1024 (UIO_MAXIOV). Hi Halil, I'll send a patch shortly to fix this issue. Sorry about the delay as I was busy with

[PATCH v2 1/2] meson: unpack edk2 firmware even if --disable-blobs

2021-09-23 Thread Paolo Bonzini
The edk2 firmware blobs are needed to run bios-tables-test. Unpack them if any UEFI-enabled target is selected, so that the test can run. This is a bit more than is actually necessary, since bios-tables-test does not run for all UEFI-enabled targets, but it is the easiest way to write this logic.

Re: [RFC PATCH v2 10/16] qdev-monitor: allow adding any sysbus device before machine is ready

2021-09-23 Thread Ani Sinha
On Thu, 23 Sep 2021, Ani Sinha wrote: > > > On Wed, 22 Sep 2021, Damien Hedde wrote: > > > Skip the sysbus device type per-machine allow-list check before the > > MACHINE_INIT_PHASE_READY phase. > > > > This patch permits adding any sysbus device (it still needs to be > > user_creatable) when

Re: [PATCH v3 0/3] tests/acpi/pcihp: add unit tests for hotplug on multifunction bridges for q35

2021-09-23 Thread Ani Sinha
ping ... On Mon, 20 Sep 2021, Ani Sinha wrote: > This patchset adds a unit test to exercize acpi hotplug support for > multifunction > bridges on q35 machines. This support was added with the commit: > > d7346e614f4ec ("acpi: x86: pcihp: add support hotplug on multifunction > bridges") > >

Re: [PATCH v2] monitor: Rate-limit MEMORY_DEVICE_SIZE_CHANGE qapi events per device

2021-09-23 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * David Hildenbrand (da...@redhat.com) wrote: >> We want to rate-limit MEMORY_DEVICE_SIZE_CHANGE events per device, >> otherwise we can lose some events for devices. As we might not always have >> a device id, add the qom-path to the event and use that to

Re: [PATCH v5 05/20] nubus: move slot bitmap checks from NubusDevice realize() to BusClass check_address()

2021-09-23 Thread Laurent Vivier
Le 23/09/2021 à 11:12, Mark Cave-Ayland a écrit : > Allow Nubus to manage the slot allocations itself using the BusClass > check_address() > virtual function rather than managing this during NubusDevice realize(). > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Laurent Vivier > --- >

Re: [PATCH] tests: qtest: bios-tables-test depends on the unpacked edk2 ROMs

2021-09-23 Thread Paolo Bonzini
On 23/09/21 10:22, Daniel P. Berrangé wrote: On Thu, Sep 23, 2021 at 04:15:55AM -0400, Paolo Bonzini wrote: Skip the test if bzip2 is not available, and run it after they are uncompressed. Signed-off-by: Paolo Bonzini --- pc-bios/meson.build | 3 ++- tests/qtest/meson.build | 6 +++---

Re: [PATCH] tests: qtest: bios-tables-test depends on the unpacked edk2 ROMs

2021-09-23 Thread Paolo Bonzini
On 23/09/21 12:00, Philippe Mathieu-Daudé wrote: See also "blobs: Only install required (system emulation) files": https://lore.kernel.org/qemu-devel/20210323155132.238193-1-f4...@amsat.org/ Nice and makes a lot of sense. Regarding "there is probably a nicer way to do this with Meson", I

Re: [PATCH v5 16/20] nubus-bridge: embed the NubusBus object directly within nubus-bridge

2021-09-23 Thread Laurent Vivier
Le 23/09/2021 à 11:13, Mark Cave-Ayland a écrit : > Since nubus-bridge is a container for NubusBus then it should be embedded > directly within the bridge device using qbus_create_inplace(). > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/m68k/q800.c

[PATCH v2 0/2] tests: qtest: bios-tables-test depends on the unpacked edk2 ROMs

2021-09-23 Thread Paolo Bonzini
Compared to v1, this adds another patch in front, so that tests are not disabled unnecessarily by --disable-blobs. Paolo Bonzini (2): meson: unpack edk2 firmware even if --disable-blobs tests: qtest: bios-tables-test depends on the unpacked edk2 ROMs meson.build | 14

[PATCH] tests: qtest: bios-tables-test depends on the unpacked edk2 ROMs

2021-09-23 Thread Paolo Bonzini
Skip the test if bzip2 is not available, and run it after they are uncompressed. Signed-off-by: Paolo Bonzini --- pc-bios/meson.build | 3 ++- tests/qtest/meson.build | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/pc-bios/meson.build b/pc-bios/meson.build index

Re: [PATCH v5 18/20] nubus: add support for slot IRQs

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 11:13, Mark Cave-Ayland wrote: Each Nubus slot has an IRQ line that can be used to request service from the CPU. Connect the IRQs to the Nubus bridge so that they can be wired up using qdev gpios accordingly, and introduce a new nubus_set_irq() function that can be used by Nubus

[PATCH v2] docs/nvdimm: Update nvdimm option value in machine example

2021-09-23 Thread Pankaj Gupta
Update nvdimm option value in example command from "-machine pc,nvdimm" to "-machine pc,nvdimm=on" as former complains with the below error: "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 'nvdimm'" Reviewed-by: Laurent Vivier Signed-off-by: Pankaj Gupta ---

Re: [PATCH v5 12/20] nubus: move nubus to its own 32-bit address space

2021-09-23 Thread Laurent Vivier
Le 23/09/2021 à 11:13, Mark Cave-Ayland a écrit : > According to "Designing Cards and Drivers for the Macintosh Family" the Nubus > has its own 32-bit address space based upon physical slot addressing. > > Move Nubus to its own 32-bit address space and then use memory region aliases > to map

Re: [PATCH] hw/char/mchp_pfsoc_mmuart: QOM'ify PolarFire MMUART

2021-09-23 Thread Peter Maydell
On Thu, 23 Sept 2021 at 11:29, Philippe Mathieu-Daudé wrote: > > On 9/23/21 07:16, Bin Meng wrote:> On Sun, Sep 19, 2021 at 2:07 AM > Philippe Mathieu-Daudé wrote: > >> +static void mchp_pfsoc_mmuart_realize(DeviceState *dev, Error **errp) > >> +{ > >> +MchpPfSoCMMUartState *s =

Re: [RFC PATCH v2 07/16] hw/core/machine: add machine_class_is_dynamic_sysbus_dev_allowed

2021-09-23 Thread Ani Sinha
On Wed, 22 Sep 2021, Damien Hedde wrote: > Right now the allowance check for adding a sysbus device using > -device cli option (or device_add qmp command) is done well after > the device has been created. It is done during the machine init done > notifier: machine_init_notify() in

Re: [PATCH] hw/char/mchp_pfsoc_mmuart: QOM'ify PolarFire MMUART

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 12:41, Peter Maydell wrote: On Thu, 23 Sept 2021 at 11:29, Philippe Mathieu-Daudé wrote: On 9/23/21 07:16, Bin Meng wrote:> On Sun, Sep 19, 2021 at 2:07 AM Philippe Mathieu-Daudé wrote: +static void mchp_pfsoc_mmuart_realize(DeviceState *dev, Error **errp) +{ +

[PATCH v2 2/2] tests: qtest: bios-tables-test depends on the unpacked edk2 ROMs

2021-09-23 Thread Paolo Bonzini
Skip the test if bzip2 is not available, and run it after they are uncompressed. Signed-off-by: Paolo Bonzini --- pc-bios/meson.build | 3 ++- tests/qtest/meson.build | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/pc-bios/meson.build b/pc-bios/meson.build index

Re: [PATCH 8/8] qapi: add blockdev-replace command

2021-09-23 Thread Vladimir Sementsov-Ogievskiy
23.09.2021 13:09, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Thanks a lot for reviewing! 20.09.2021 09:44, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add command that can add and remove filters. Key points of functionality: What the command does is

Re: [PATCH 1/2] docs/devel/testing: add instruction to run a single acceptance test

2021-09-23 Thread Willian Rampazzo
On Thu, Sep 23, 2021 at 5:27 AM Daniel P. Berrangé wrote: > > On Wed, Sep 22, 2021 at 04:03:23PM -0300, Willian Rampazzo wrote: > > Add instructions to the Acceptance tests section about running a > > single test file or a test within the test file. > > > > Signed-off-by: Willian Rampazzo > >

Re: [PATCH v6 17/21] LoongArch Linux User Emulation

2021-09-23 Thread Laurent Vivier
Le 17/09/2021 à 10:12, Song Gao a écrit : > Implementation of linux user emulation for LoongArch. > > Signed-off-by: Song Gao > Signed-off-by: XiaoJuan Yang > --- > accel/tcg/user-exec.c | 15 ++ > configure | 5 + > include/elf.h

Re: [PATCH v6 17/21] LoongArch Linux User Emulation

2021-09-23 Thread Song Gao
Hi, Laurent. On 09/23/2021 02:53 PM, Laurent Vivier wrote: >> diff --git a/linux-user/loongarch64/syscall_nr.h >> b/linux-user/loongarch64/syscall_nr.h >> new file mode 100644 >> index 000..8fbf287 >> --- /dev/null >> +++ b/linux-user/loongarch64/syscall_nr.h >> @@ -0,0 +1,312 @@ >> +/* >> +

[PATCH v5 06/20] nubus: implement BusClass get_dev_path()

2021-09-23 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/nubus/nubus-bus.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/nubus/nubus-bus.c b/hw/nubus/nubus-bus.c index d4daaa36f2..df93a07dfe 100644 ---

Re: [RFC PATCH] spapr/xive: Allocate vCPU IPIs from local context

2021-09-23 Thread Greg Kurz
On Wed, 22 Sep 2021 16:41:20 +0200 Cédric Le Goater wrote: > When QEMU switches to the XIVE interrupt mode, it creates all possible > guest interrupts at the level of the KVM device. These interrupts are > backed by real HW interrupts from the IPI interrupt pool of the XIVE > controller. > >

[PATCH v5 00/20] nubus: bus, device, bridge, IRQ and address space improvements

2021-09-23 Thread Mark Cave-Ayland
This patchset is the next set of changes required to boot MacOS on the q800 machine. The main aim of these patches is to improve the Nubus support so that devices can be plugged into the Nubus from the command line i.e. -device nubus-macfb[,slot=num][,romfile=decl.rom] At the moment the

[PATCH v5 05/20] nubus: move slot bitmap checks from NubusDevice realize() to BusClass check_address()

2021-09-23 Thread Mark Cave-Ayland
Allow Nubus to manage the slot allocations itself using the BusClass check_address() virtual function rather than managing this during NubusDevice realize(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/nubus/nubus-bus.c| 30 ++

Re: [PATCH v5 04/20] nubus: use bitmap to manage available slots

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 11:12, Mark Cave-Ayland wrote: Convert nubus_device_realize() to use a bitmap to manage available slots to allow for future Nubus devices to be plugged into arbitrary slots from the command line using a new qdev "slot" parameter for nubus devices. Update mac_nubus_bridge_init() to

Re: [PATCH 2/2] tests/Makefile: add TESTFILES option to make check-acceptance

2021-09-23 Thread Daniel P . Berrangé
On Thu, Sep 23, 2021 at 11:34:18AM +0200, Philippe Mathieu-Daudé wrote: > On 9/22/21 21:46, Willian Rampazzo wrote: > > On Wed, Sep 22, 2021 at 4:08 PM Philippe Mathieu-Daudé > > wrote: > > > > > > On 9/22/21 21:03, Willian Rampazzo wrote: > > > > Add the possibility of running all the tests

Re: [PATCH v5 17/20] nubus-bridge: make slot_available_mask a qdev property

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 11:13, Mark Cave-Ayland wrote: This is to allow Macintosh machines to further specify which slots are available since the number of addressable slots may not match the number of physical slots present in the machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier ---

Re: [PATCH 2/2] tests/Makefile: add TESTFILES option to make check-acceptance

2021-09-23 Thread Willian Rampazzo
On Thu, Sep 23, 2021 at 6:42 AM Daniel P. Berrangé wrote: > > On Thu, Sep 23, 2021 at 11:34:18AM +0200, Philippe Mathieu-Daudé wrote: > > On 9/22/21 21:46, Willian Rampazzo wrote: > > > On Wed, Sep 22, 2021 at 4:08 PM Philippe Mathieu-Daudé > > > wrote: > > > > > > > > On 9/22/21 21:03, Willian

Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-23 Thread Paolo Bonzini
On 21/09/21 15:46, Jose R. Ziviani wrote: Alternatively, you could C-ify the contents of config-devices.mak, and embed them in the per-arch modinfo-*.c; and record CONFIG_* symbols for each module (e.g. '{ "CONFIG_QXL", "hw-display-qxl" }' from a 'module_config("CONFIG_QXL")' line in the global

Re: [PATCH] hw/loader: Restrict PC_ROM_* definitions to hw/i386/pc

2021-09-23 Thread Laurent Vivier
Le 17/09/2021 à 20:59, Philippe Mathieu-Daudé a écrit : > The PC_ROM_* definitions are only used by the PC machine, > and are irrelevant to the other architectures / machines. > Reduce their scope by moving them to hw/i386/pc.c. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v2] monitor: Rate-limit MEMORY_DEVICE_SIZE_CHANGE qapi events per device

2021-09-23 Thread David Hildenbrand
On 23.09.21 09:34, Markus Armbruster wrote: David Hildenbrand writes: We want to rate-limit MEMORY_DEVICE_SIZE_CHANGE events per device, otherwise we can lose some events for devices. As we might not always have a device id, add the qom-path to the event and use that to rate-limit per device.

Re: [PATCH] 9pfs: fix wrong I/O block size in Rgetattr

2021-09-23 Thread Greg Kurz
On Wed, 22 Sep 2021 17:55:02 +0200 Christian Schoenebeck wrote: > On Mittwoch, 22. September 2021 17:42:08 CEST Philippe Mathieu-Daudé wrote: > > On 9/22/21 15:13, Christian Schoenebeck wrote: > > > When client sent a 9p Tgetattr request then the wrong I/O block > > > size value was returned by

Re: [PATCH v6 00/21] Add LoongArch linux-user emulation support

2021-09-23 Thread Song Gao
Hi, Richard. On 09/17/2021 04:12 PM, Song Gao wrote: > Based-on: <20210822035537.283193-6-richard.hender...@linaro.org> This patch failed in applying to current master. I am not sure how to use it ...  Thanks. Song Gao

Recent qemu patch results in aio failures with host DASD disks resulting in guest I/O errors

2021-09-23 Thread Christian Borntraeger
Am 22.09.21 um 21:51 schrieb Halil Pasic: On Mon, 6 Sep 2021 16:24:20 +0200 Halil Pasic wrote: On Fri, 25 Jun 2021 16:18:12 +0200 Paolo Bonzini wrote: bs->sg is only true for character devices, but block devices can also be used with scsi-block and scsi-generic. Unfortunately BLKSECTGET

Re: [PATCH 2/2] tests/Makefile: add TESTFILES option to make check-acceptance

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/22/21 21:46, Willian Rampazzo wrote: On Wed, Sep 22, 2021 at 4:08 PM Philippe Mathieu-Daudé wrote: On 9/22/21 21:03, Willian Rampazzo wrote: Add the possibility of running all the tests from a single file, or multiple files, running a single test within a file or multiple tests within

Re: [PATCH] docs/nvdimm: Update nvdimm option value in machine example

2021-09-23 Thread Pankaj Gupta
ping > Update nvdimm option value in example command from "-machine pc,nvdimm" > to "-machine pc,nvdimm=on" as former complains with the below error: > > "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter > 'nvdimm'" > > Signed-off-by: Pankaj Gupta > --- > docs/nvdimm.txt |

Re: [PATCH 1/2] tests/qapi-schema: Use Python OSError instead of outmoded IOError

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 11:33, Markus Armbruster wrote: John Snow writes: On Wed, Sep 22, 2021 at 8:56 AM Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- tests/qapi-schema/test-qapi.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v5 01/20] nubus: add comment indicating reference documents

2021-09-23 Thread Laurent Vivier
Le 23/09/2021 à 11:12, Mark Cave-Ayland a écrit : > Signed-off-by: Mark Cave-Ayland > --- > hw/nubus/nubus-bus.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/hw/nubus/nubus-bus.c b/hw/nubus/nubus-bus.c > index 5c13452308..f4410803ff 100644 > --- a/hw/nubus/nubus-bus.c > +++

Re: [PATCH] tests: qtest: bios-tables-test depends on the unpacked edk2 ROMs

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 10:22, Daniel P. Berrangé wrote: On Thu, Sep 23, 2021 at 04:15:55AM -0400, Paolo Bonzini wrote: Skip the test if bzip2 is not available, and run it after they are uncompressed. Signed-off-by: Paolo Bonzini --- pc-bios/meson.build | 3 ++- tests/qtest/meson.build | 6 +++---

Re: [PATCH v5 14/20] mac-nubus-bridge: rename MacNubusState to MacNubusBridge

2021-09-23 Thread Laurent Vivier
Le 23/09/2021 à 11:13, Mark Cave-Ayland a écrit : > This better reflects that the mac-nubus-bridge device is derived from the > nubus-bridge device, and that the structure represents the state of the bridge > device and not the Nubus itself. Also update the comment in the file header to > reflect

Re: [PATCH 2/3] scsi: make io_timeout configurable

2021-09-23 Thread Paolo Bonzini
On 22/09/21 17:47, Philippe Mathieu-Daudé wrote: @@ -637,7 +639,7 @@ static int get_stream_blocksize(BlockBackend *blk)   cmd[0] = MODE_SENSE;   cmd[4] = sizeof(buf); -    ret = scsi_SG_IO_FROM_DEV(blk, cmd, sizeof(cmd), buf, sizeof(buf)); +    ret = scsi_SG_IO_FROM_DEV(blk, cmd,

Re: [PATCH 1/2] docs/devel/testing: add instruction to run a single acceptance test

2021-09-23 Thread Daniel P . Berrangé
On Wed, Sep 22, 2021 at 04:03:23PM -0300, Willian Rampazzo wrote: > Add instructions to the Acceptance tests section about running a > single test file or a test within the test file. > > Signed-off-by: Willian Rampazzo > --- > docs/devel/testing.rst | 14 ++ > 1 file changed, 14

[PATCH v5 01/20] nubus: add comment indicating reference documents

2021-09-23 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-bus.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/nubus/nubus-bus.c b/hw/nubus/nubus-bus.c index 5c13452308..f4410803ff 100644 --- a/hw/nubus/nubus-bus.c +++ b/hw/nubus/nubus-bus.c @@ -8,6 +8,14 @@ * */ +/* + *

[PATCH v5 12/20] nubus: move nubus to its own 32-bit address space

2021-09-23 Thread Mark Cave-Ayland
According to "Designing Cards and Drivers for the Macintosh Family" the Nubus has its own 32-bit address space based upon physical slot addressing. Move Nubus to its own 32-bit address space and then use memory region aliases to map available slot and super slot ranges into the q800 system

Re: [PATCH 8/8] qapi: add blockdev-replace command

2021-09-23 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Thanks a lot for reviewing! > > 20.09.2021 09:44, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Add command that can add and remove filters. >>> >>> Key points of functionality: >>> >>> What the command does is simply replace

Re: [PATCH 2/3] scsi: make io_timeout configurable

2021-09-23 Thread Hannes Reinecke
On 9/22/21 5:47 PM, Philippe Mathieu-Daudé wrote: Hi Hannes, On 11/16/20 19:31, Hannes Reinecke wrote: The current code sets an infinite timeout on SG_IO requests, causing the guest to stall if the host experiences a frame loss. This patch adds an 'io_timeout' parameter for SCSIDevice to make

[PATCH v5 11/20] nubus-device: add romfile property for loading declaration ROMs

2021-09-23 Thread Mark Cave-Ayland
The declaration ROM is located at the top-most address of the standard slot space. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/nubus/nubus-device.c | 44 +++- include/hw/nubus/nubus.h | 6 ++ 2 files changed, 49 insertions(+), 1

[PATCH v5 10/20] nubus-device: remove nubus_register_rom() and nubus_register_format_block()

2021-09-23 Thread Mark Cave-Ayland
Since there is no need to generate a dummy declaration ROM, remove both nubus_register_rom() and nubus_register_format_block(). These will shortly be replaced with a mechanism to optionally load a declaration ROM from disk to allow real images to be used within QEMU. Signed-off-by: Mark

[PATCH v5 08/20] nubus: generate bus error when attempting to access empty slots

2021-09-23 Thread Mark Cave-Ayland
According to "Designing Cards and Drivers for the Macintosh Family" any attempt to access an unimplemented address location on Nubus generates a bus error. MacOS uses a custom bus error handler to detect empty Nubus slots, and with the current implementation assumes that all slots are occupied

[PATCH v5 03/20] nubus-device: expose separate super slot memory region

2021-09-23 Thread Mark Cave-Ayland
According to "Designing Cards and Drivers for the Macintosh Family" each physical nubus slot can access 2 separate address ranges: a super slot memory region which is 256MB and a standard slot memory region which is 16MB. Currently a Nubus device uses the physical slot number to determine

Re: [PATCH 1/2] tests/qapi-schema: Use Python OSError instead of outmoded IOError

2021-09-23 Thread Markus Armbruster
John Snow writes: > On Wed, Sep 22, 2021 at 8:56 AM Markus Armbruster wrote: > >> Signed-off-by: Markus Armbruster >> --- >> tests/qapi-schema/test-qapi.py | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tests/qapi-schema/test-qapi.py >>

Re: [PATCH] docs/nvdimm: Update nvdimm option value in machine example

2021-09-23 Thread Pankaj Gupta
> > ping > > Could you post your patch with an email address ("From") that is the same as > the "Signed-off-by"? Sure sent a V2. Thank you, Pankaj > > https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line > > Thanks, > Laurent > > >> Update nvdimm option

Re: [PATCH 1/6] iotests: add 'qemu' package location to PYTHONPATH in testenv

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 02:16, John Snow wrote: We can drop the sys.path hacking in various places by doing this. Additionally, by doing it in one place right up top, we can print interesting warnings in case the environment does not look correct. If we ever decide to change how the environment is crafted,

Re: [PATCH v5 15/20] nubus: move NubusBus from mac-nubus-bridge to nubus-bridge

2021-09-23 Thread Laurent Vivier
Le 23/09/2021 à 11:13, Mark Cave-Ayland a écrit : > Now that Nubus has its own address space rather than mapping directly into the > system bus, move the Nubus reference from MacNubusBridge to NubusBridge. > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH 3/6] iotests/linters: check mypy files all at once

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 02:16, John Snow wrote: We can circumvent the '__main__' redefinition problem by passing --scripts-are-modules. Take mypy out of the loop per-filename and check everything in one go: it's quite a bit faster. Signed-off-by: John Snow Reviewed-by: Hanna Reitz ---

Re: [PATCH] tests: qtest: bios-tables-test depends on the unpacked edk2 ROMs

2021-09-23 Thread Paolo Bonzini
On 23/09/21 12:44, Peter Maydell wrote: On Thu, 23 Sept 2021 at 11:32, Paolo Bonzini wrote: On 23/09/21 12:00, Philippe Mathieu-Daudé wrote: See also "blobs: Only install required (system emulation) files": https://lore.kernel.org/qemu-devel/20210323155132.238193-1-f4...@amsat.org/ Nice

Re: [PATCH v3 24/35] acpi: x86: madt: use build_append_int_noprefix() API to compose MADT table

2021-09-23 Thread Igor Mammedov
On Wed, 22 Sep 2021 17:37:40 +0200 Eric Auger wrote: > Hi, > On 9/22/21 5:30 PM, Igor Mammedov wrote: > > On Wed, 22 Sep 2021 12:20:54 +0200 > > Eric Auger wrote: > > > >> On 9/7/21 4:48 PM, Igor Mammedov wrote: > >>> Drop usage of packed structures and explicit endian conversions > >>>

[PATCH v5 13/20] nubus-bridge: introduce separate NubusBridge structure

2021-09-23 Thread Mark Cave-Ayland
This is to allow the Nubus bridge to store its own additional state. Also update the comment in the file header to reflect that nubus-bridge is not specific to the Macintosh. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/nubus/nubus-bridge.c | 4 ++--

[PATCH v5 14/20] mac-nubus-bridge: rename MacNubusState to MacNubusBridge

2021-09-23 Thread Mark Cave-Ayland
This better reflects that the mac-nubus-bridge device is derived from the nubus-bridge device, and that the structure represents the state of the bridge device and not the Nubus itself. Also update the comment in the file header to reflect that mac-nubus-bridge is specific to the Macintosh.

[PATCH v5 16/20] nubus-bridge: embed the NubusBus object directly within nubus-bridge

2021-09-23 Thread Mark Cave-Ayland
Since nubus-bridge is a container for NubusBus then it should be embedded directly within the bridge device using qbus_create_inplace(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 2 +- hw/nubus/mac-nubus-bridge.c | 9 +

[PATCH v5 18/20] nubus: add support for slot IRQs

2021-09-23 Thread Mark Cave-Ayland
Each Nubus slot has an IRQ line that can be used to request service from the CPU. Connect the IRQs to the Nubus bridge so that they can be wired up using qdev gpios accordingly, and introduce a new nubus_set_irq() function that can be used by Nubus devices to control the slot IRQ. Signed-off-by:

Re: [RFC v7] virtio/vsock: add two more queues for datagram types

2021-09-23 Thread Stefano Garzarella
On Wed, Sep 22, 2021 at 10:36:24AM -0700, Jiang Wang . wrote: On Wed, Sep 22, 2021 at 2:23 AM Stefano Garzarella wrote: On Wed, Sep 22, 2021 at 12:00:24AM +, Jiang Wang wrote: >Datagram sockets are connectionless and unreliable. >The sender does not know the capacity of the receiver >and

Re: [PATCH v5 05/20] nubus: move slot bitmap checks from NubusDevice realize() to BusClass check_address()

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 11:12, Mark Cave-Ayland wrote: Allow Nubus to manage the slot allocations itself using the BusClass check_address() virtual function rather than managing this during NubusDevice realize(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/nubus/nubus-bus.c|

Re: [PATCH] docs/nvdimm: Update nvdimm option value in machine example

2021-09-23 Thread Laurent Vivier
Le 26/07/2021 à 09:11, Pankaj Gupta a écrit : > Update nvdimm option value in example command from "-machine pc,nvdimm" > to "-machine pc,nvdimm=on" as former complains with the below error: > > "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter > 'nvdimm'" > > Signed-off-by:

Re: [PATCH] hw/char/mchp_pfsoc_mmuart: QOM'ify PolarFire MMUART

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 07:16, Bin Meng wrote:> On Sun, Sep 19, 2021 at 2:07 AM Philippe Mathieu-Daudé wrote: - Embed SerialMM in MchpPfSoCMMUartState and QOM-initialize it - Alias SERIAL_MM 'chardev' property on MCHP_PFSOC_UART - Forward SerialMM sysbus IRQ in mchp_pfsoc_mmuart_realize() - Keep

Re: [PATCH] hw/char/mchp_pfsoc_mmuart: QOM'ify PolarFire MMUART

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 12:52, Philippe Mathieu-Daudé wrote: On 9/23/21 12:41, Peter Maydell wrote: On Thu, 23 Sept 2021 at 11:29, Philippe Mathieu-Daudé wrote: On 9/23/21 07:16, Bin Meng wrote:> On Sun, Sep 19, 2021 at 2:07 AM Philippe Mathieu-Daudé wrote: +static void

Re: [RFC PATCH v2 10/16] qdev-monitor: allow adding any sysbus device before machine is ready

2021-09-23 Thread Ani Sinha
On Wed, 22 Sep 2021, Damien Hedde wrote: > Skip the sysbus device type per-machine allow-list check before the > MACHINE_INIT_PHASE_READY phase. > > This patch permits adding any sysbus device (it still needs to be > user_creatable) when using the -preconfig experimental option. > >

Re: [PATCH 2/6] iotests: add warning for rogue 'qemu' packages

2021-09-23 Thread Kevin Wolf
Am 23.09.2021 um 12:57 hat Kevin Wolf geschrieben: > Am 23.09.2021 um 02:16 hat John Snow geschrieben: > > Add a warning for when 'iotests' runs against a qemu namespace that > > isn't the one in the source tree. This might occur if you have > > (accidentally) installed the Python namespace

Re: [PATCH v2] monitor: Rate-limit MEMORY_DEVICE_SIZE_CHANGE qapi events per device

2021-09-23 Thread Markus Armbruster
David Hildenbrand writes: > We want to rate-limit MEMORY_DEVICE_SIZE_CHANGE events per device, > otherwise we can lose some events for devices. As we might not always have > a device id, add the qom-path to the event and use that to rate-limit > per device. There are actually two reasons for

[PATCH v4 29/35] acpi: arm/virt: convert build_iort() to endian agnostic build_append_FOO() API

2021-09-23 Thread Igor Mammedov
Drop usage of packed structures and explicit endian conversions when building IORT table use endian agnostic build_append_int_noprefix() API to build it. Signed-off-by: Igor Mammedov --- CC: Eric Auger v4: - (Eric Auger ) * keep nb_nodes * encode 'Memory access properties' as

Re: [PATCH] tests: qtest: bios-tables-test depends on the unpacked edk2 ROMs

2021-09-23 Thread Daniel P . Berrangé
On Thu, Sep 23, 2021 at 04:15:55AM -0400, Paolo Bonzini wrote: > Skip the test if bzip2 is not available, and run it after they are > uncompressed. > > Signed-off-by: Paolo Bonzini > --- > pc-bios/meson.build | 3 ++- > tests/qtest/meson.build | 6 +++--- > 2 files changed, 5 insertions(+),

[PATCH v5 07/20] nubus: add trace-events for empty slot accesses

2021-09-23 Thread Mark Cave-Ayland
Increase the max_access_size to 4 bytes for empty Nubus slot and super slot accesses to allow tracing of the Nubus enumeration process by the guest OS. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/nubus/nubus-bus.c | 10 +++---

[PATCH v5 02/20] nubus-device: rename slot_nb variable to slot

2021-09-23 Thread Mark Cave-Ayland
This is in preparation for creating a qdev property of the same name. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/nubus/nubus-device.c | 14 +++--- include/hw/nubus/nubus.h | 2 +- 2 files changed, 8 insertions(+), 8

[PATCH v5 04/20] nubus: use bitmap to manage available slots

2021-09-23 Thread Mark Cave-Ayland
Convert nubus_device_realize() to use a bitmap to manage available slots to allow for future Nubus devices to be plugged into arbitrary slots from the command line using a new qdev "slot" parameter for nubus devices. Update mac_nubus_bridge_init() to only allow slots 0x9 to 0xe on a Macintosh

[PATCH v5 09/20] macfb: don't register declaration ROM

2021-09-23 Thread Mark Cave-Ayland
The macfb device is an on-board framebuffer and so is initialised by the system declaration ROM included within the MacOS toolbox ROM. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/display/macfb.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/display/macfb.c

[PATCH v5 15/20] nubus: move NubusBus from mac-nubus-bridge to nubus-bridge

2021-09-23 Thread Mark Cave-Ayland
Now that Nubus has its own address space rather than mapping directly into the system bus, move the Nubus reference from MacNubusBridge to NubusBridge. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 2 +-

Re: [PATCH v5 01/20] nubus: add comment indicating reference documents

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 11:12, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-bus.c | 8 1 file changed, 8 insertions(+) Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

Re: [PATCH 2/2] tests/Makefile: add TESTFILES option to make check-acceptance

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/23/21 11:42, Daniel P. Berrangé wrote: On Thu, Sep 23, 2021 at 11:34:18AM +0200, Philippe Mathieu-Daudé wrote: On 9/22/21 21:46, Willian Rampazzo wrote: On Wed, Sep 22, 2021 at 4:08 PM Philippe Mathieu-Daudé wrote: On 9/22/21 21:03, Willian Rampazzo wrote: Add the possibility of

Re: [PATCH v5 03/20] nubus-device: expose separate super slot memory region

2021-09-23 Thread Laurent Vivier
Le 23/09/2021 à 11:12, Mark Cave-Ayland a écrit : > According to "Designing Cards and Drivers for the Macintosh Family" each > physical > nubus slot can access 2 separate address ranges: a super slot memory region > which > is 256MB and a standard slot memory region which is 16MB. > > Currently

Re: [PATCH v5 04/20] nubus: use bitmap to manage available slots

2021-09-23 Thread Laurent Vivier
Le 23/09/2021 à 11:12, Mark Cave-Ayland a écrit : > Convert nubus_device_realize() to use a bitmap to manage available slots to > allow > for future Nubus devices to be plugged into arbitrary slots from the command > line > using a new qdev "slot" parameter for nubus devices. > > Update

Re: [PATCH v3 03/30] tcg/loongarch64: Add the tcg-target.h file

2021-09-23 Thread Philippe Mathieu-Daudé
On 9/22/21 20:58, Richard Henderson wrote: On 9/22/21 11:34 AM, Philippe Mathieu-Daudé wrote: Here could go:     TCG_TARGET_NB_REGS, Not a fan of putting NFOO in the enumeration. It interferes with -Wenum stuff. Oh good point... TIL :)

Re: [PATCH v5 13/20] nubus-bridge: introduce separate NubusBridge structure

2021-09-23 Thread Laurent Vivier
Le 23/09/2021 à 11:13, Mark Cave-Ayland a écrit : > This is to allow the Nubus bridge to store its own additional state. Also > update > the comment in the file header to reflect that nubus-bridge is not specific to > the Macintosh. > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Philippe

Re: [RFC PATCH v2 00/16] Initial support for machine creation via QMP

2021-09-23 Thread Damien Hedde
On 9/22/21 19:50, Philippe Mathieu-Daudé wrote: Hi Damien, On 9/22/21 18:13, Damien Hedde wrote: The goal of this work is to bring dynamic machine creation to QEMU: we want to setup a machine without compiling a specific machine C code. It would ease supporting highly configurable

Re: [PATCH 2/6] iotests: add warning for rogue 'qemu' packages

2021-09-23 Thread Daniel P . Berrangé
On Wed, Sep 22, 2021 at 08:16:21PM -0400, John Snow wrote: > Add a warning for when 'iotests' runs against a qemu namespace that > isn't the one in the source tree. This might occur if you have > (accidentally) installed the Python namespace package to your local > packages. IIUC, it is/was a

[PATCH 0/6] Improve consistency of bus init function names

2021-09-23 Thread Peter Maydell
Currently we have a bit of a mishmash of different function names for bus creation. There are two basic patterns: you can have a function that allocates and returns a new bus object; or you can have a function that takes a pointer to a bus object and initializes it in-place. We have to some extent

Re: [PATCH v5 14/20] mac-nubus-bridge: rename MacNubusState to MacNubusBridge

2021-09-23 Thread Mark Cave-Ayland
On 23/09/2021 11:35, Laurent Vivier wrote: Le 23/09/2021 à 11:13, Mark Cave-Ayland a écrit : This better reflects that the mac-nubus-bridge device is derived from the nubus-bridge device, and that the structure represents the state of the bridge device and not the Nubus itself. Also update the

Re: [Qemu-devel] [PULL 18/18] qapi: move RTC_CHANGE to the target schema

2021-09-23 Thread Peter Maydell
On Mon, 18 Feb 2019 at 14:19, Markus Armbruster wrote: > > From: Marc-André Lureau > > A few targets don't emit RTC_CHANGE, we could restrict the event to > the tagets that do emit it. > > Note: There is a lot more of events & commands that we could restrict > to capable targets, with the cost

[PATCH 3/3] linux-aio: add `dev_max_batch` parameter to laio_io_unplug()

2021-09-23 Thread Stefano Garzarella
Between the submission of a request and the unplug, other devices with larger limits may have been queued new requests without flushing the batch. Using the new `dev_max_batch` parameter, laio_io_unplug() can check if the batch exceeds the device limit to flush the current batch. Signed-off-by:

Re: [PATCH 2/2] hmp: Drop a bogus sentence from set_password's documentation

2021-09-23 Thread Laurent Vivier
Le 09/09/2021 à 10:12, Markus Armbruster a écrit : > Signed-off-by: Markus Armbruster > --- > hmp-commands.hx | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 8e45bce2cd..cf723c69ac 100644 > --- a/hmp-commands.hx >

Re: [PATCH 1/6] iotests: add 'qemu' package location to PYTHONPATH in testenv

2021-09-23 Thread Vladimir Sementsov-Ogievskiy
23.09.2021 03:16, John Snow wrote: We can drop the sys.path hacking in various places by doing this. Additionally, by doing it in one place right up top, we can print interesting warnings in case the environment does not look correct. If we ever decide to change how the environment is crafted,

Re: [PATCH 5/6] iotests/migrate-bitmaps-test: delint

2021-09-23 Thread Vladimir Sementsov-Ogievskiy
23.09.2021 03:16, John Snow wrote: Mostly uninteresting stuff. Move the test injections under a function named main() so that the variables used during that process aren't in the global scope. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hanna Reitz Reviewed-by:

  1   2   3   >