[PULL 26/44] spapr_numa.c: scrap 'legacy_numa' concept

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza When first introduced, 'legacy_numa' was a way to refer to guests that either wouldn't be affected by associativity domain calculations, namely the ones with only 1 NUMA node, and pre 5.2 guests that shouldn't be affected by it because it would be an userspace

[PULL 19/44] spapr: use DEVICE_UNPLUG_GUEST_ERROR to report unplug errors

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza Linux Kernel 5.12 is now unisolating CPU DRCs in the device_removal error path, signalling that the hotunplug process wasn't successful. This allow us to send a DEVICE_UNPLUG_GUEST_ERROR in drc_unisolate_logical() to signal this error to the management layer. We

[PULL 15/44] spapr.c: handle dev->id in spapr_memory_unplug_rollback()

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza As done in hw/acpi/memory_hotplug.c, pass an empty string if dev->id is NULL to qapi_event_send_mem_unplug_error() to avoid relying on a behavior that can be changed in the future. Suggested-by: Markus Armbruster Reviewed-by: Greg Kurz Reviewed-by: David Gibson

[PULL 42/44] MAINTAINERS: Remove David & Greg as reviewers/co-maintainers of powernv

2021-09-30 Thread David Gibson
With our interests moving to other areas, Greg and myself no longer have capacity to be regular reviewers of code for the powernv machine type, let alone co-maintainers. Additionally, not being IBM employees, we don't have easy access to the hardware information we'd need for good review.

[PULL 28/44] spapr_numa.c: rename numa_assoc_array to FORM1_assoc_array

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza Introducing a new NUMA affinity, FORM2, requires a new mechanism to switch between affinity modes after CAS. Also, we want FORM2 data structures and functions to be completely separated from the existing FORM1 code, allowing us to avoid adding new code that inherits

[Bug 1945540] Re: Java crashes on s390x VM with SIGILL/ILL_PRVOPC at '__kernel_getcpu+0x8'

2021-09-30 Thread Thomas Huth
There were some fixes in QEMU v6.1. Please try that one to see whether it solves your problem, too. ** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1945540

[PULL 43/44] MAINTAINERS: Add information for OpenPIC

2021-09-30 Thread David Gibson
The OpenPIC interrupt controller was once the de facto standard on ppc machines. In qemu it's now only used on some Macintosh and the Freescale e500 machine. It has no listed maintainer, and as far as I know, no-one who's really familiar with it any more. Since I'm moving away from the area, I

Re: [PATCH v2 3/5] s390x: topology: CPU topology objects and structures

2021-09-30 Thread Pierre Morel
On 9/29/21 10:12 AM, Thomas Huth wrote: On 07/09/2021 14.45, Pierre Morel wrote: On 9/7/21 9:32 AM, Thomas Huth wrote: On 22/07/2021 19.42, Pierre Morel wrote: We use new objects to have a dynamic administration of the CPU topology. The highier level object is the S390 book. In a first

Re: [PATCH 0/1] vmx: Fix mapping

2021-09-30 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 08:33:48AM +0100, Richard W.M. Jones wrote: > > More data: I found a colleague who has a Hyper-V instance with a > Windows guest and he helped me to understand how Hyper-V represents > generation IDs. Hyper-V has had support for generation IDs since long > before

Re: [PATCH 0/6] Improve consistency of bus init function names

2021-09-30 Thread Peter Maydell
On Thu, 23 Sept 2021 at 13:11, Peter Maydell wrote: > > Currently we have a bit of a mishmash of different function > names for bus creation. There are two basic patterns: you > can have a function that allocates and returns a new bus > object; or you can have a function that takes a pointer to >

[PULL 33/44] target/ppc: Fix 64-bit decrementer

2021-09-30 Thread David Gibson
From: Cédric Le Goater The current way the mask is built can overflow with a 64-bit decrementer. Use sextract64() to extract the signed values and remove the logic to handle negative values which has become useless. Cc: Luis Fernando Fujita Pires Fixes: a8dafa525181 ("target/ppc: Implement

[PULL 35/44] hw/intc: openpic: Drop Raven related codes

2021-09-30 Thread David Gibson
From: Bin Meng There is no machine that uses Motorola MCP750 (aka Raven) model. Drop the related codes. While we are here, drop the mentioning of Intel GW80314 I/O companion chip in the comments as it has been obsolete for years, and correct a typo too. Signed-off-by: Bin Meng Message-Id:

[PATCH v4 0/2] x86/sev: Measured Linux SEV guest with kernel/initrd/cmdline

2021-09-30 Thread Dov Murik
Currently booting with -kernel/-initrd/-append is not supported in SEV confidential guests, because the content of these blobs is not measured and therefore not trusted by the SEV guest. However, in some cases the kernel, initrd, and cmdline are not secret but should not be modified by the host.

Re: [PATCH v3] nbd/server: Add --selinux-label option

2021-09-30 Thread Vladimir Sementsov-Ogievskiy
9/30/21 11:47, Richard W.M. Jones wrote: Under SELinux, Unix domain sockets have two labels. One is on the disk and can be set with commands such as chcon(1). There is a different label stored in memory (called the process label). This can only be set by the process creating the socket. When

Re: [PATCH] MAINTAINERS: add myself as a reviewer for KVM guest cpu related changes

2021-09-30 Thread Ani Sinha
I take this back. I’m not sure if I’ll have a lot of spare time to review patches in this area. Sadly there is no means to monitor changes/commits in a particular area without taking on review responsibilities. Essentially there has to be a “watchers” category. Badly needed IMHO. Someone mentioned

[PATCH v2] failover: fix unplug pending detection

2021-09-30 Thread Laurent Vivier
Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in pcie_unplug_device(). But since 17858a169508 ("hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35") we

Re: [PULL 00/20] Q800 for 6.2 patches

2021-09-30 Thread Peter Maydell
On Wed, 29 Sept 2021 at 10:32, Laurent Vivier wrote: > > The following changes since commit 6b54a31bf7b403672a798b6443b1930ae6c74dea: > > Merge remote-tracking branch > 'remotes/jsnow-gitlab/tags/python-pull-request' into staging (2021-09-28 > 13:07:32 +0100) > > are available in the Git

[PULL 39/44] MAINTAINERS: Remove machine specific files from ppc TCG CPUs entry

2021-09-30 Thread David Gibson
Currently the PowerPC TCG CPUs entry in MAINTAINERS lists all of hw/ppc/ and include/hw/ppc. Nearly all the files in those places are related to specific ppc machine types, rather than to the actual CPUs however. Those machine types list their own files separately, often overlapping with this.

[PULL 30/44] spapr_numa.c: FORM2 NUMA affinity support

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza The main feature of FORM2 affinity support is the separation of NUMA distances from ibm,associativity information. This allows for a more flexible and straightforward NUMA distance assignment without relying on complex associations between several levels of NUMA via

Re: [PATCH v4 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-09-30 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 08:49:14AM +0300, Dov Murik wrote: > Add the sev_add_kernel_loader_hashes function to calculate the hashes of > the kernel/initrd/cmdline and fill a designated OVMF encrypted hash > table area. For this to work, OVMF must support an encrypted area to > place the data which

Re: [PATCH v3 2/3] QIOChannelSocket: Implement io_async_write & io_async_flush

2021-09-30 Thread Daniel P . Berrangé
On Wed, Sep 29, 2021 at 04:32:12PM -0300, Leonardo Bras Soares Passos wrote: > Hello Daniel, > > On Fri, Sep 24, 2021 at 2:38 PM Daniel P. Berrangé > wrote: > [...] > > > @@ -154,6 +171,19 @@ int qio_channel_socket_connect_sync(QIOChannelSocket > > > *ioc, > > > return -1; > > >

Re: [PATCH] hw/misc: Add a virtual pci device to dynamically attach memory to QEMU

2021-09-30 Thread david.dai
On Wed, Sep 29, 2021 at 11:30:53AM +0200, David Hildenbrand (da...@redhat.com) wrote: > > On 27.09.21 14:28, david.dai wrote: > > On Mon, Sep 27, 2021 at 11:07:43AM +0200, David Hildenbrand > > (da...@redhat.com) wrote: > > > > > > CAUTION: This email originated from outside of the

Re: [PATCH v5] Prevent vhost-user-blk-test hang

2021-09-30 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 05:29:06AM +, Raphael Norwitz wrote: > On Tue, Sep 28, 2021 at 10:55:00AM +0200, Stefan Hajnoczi wrote: > > On Mon, Sep 27, 2021 at 05:17:01PM +, Raphael Norwitz wrote: > > > In the vhost-user-blk-test, as of now there is nothing stoping > > > vhost-user-blk in QEMU

Re: [PATCH] failover: fix unplug pending detection

2021-09-30 Thread Laurent Vivier
On 30/09/2021 11:24, Ani Sinha wrote: On Thu, 30 Sep 2021, Laurent Vivier wrote: Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in pcie_unplug_device().

Re: [PATCH v2 3/6] qapi/parser: add type hint annotations (QAPIDoc)

2021-09-30 Thread Markus Armbruster
John Snow writes: > On Tue, Sep 7, 2021 at 6:44 AM Markus Armbruster wrote: > >> John Snow writes: >> >> > Annotations do not change runtime behavior. >> > >> > This commit adds mostly annotations, but uses a TYPE_CHECKING runtime >> > check to conditionally import dependencies, which only

Re: [RFC PATCH 00/10] security: Introduce qemu_security_policy_taint() API

2021-09-30 Thread Daniel P . Berrangé
On Tue, Sep 14, 2021 at 01:30:27PM +, P J P wrote: > Hello Philippe, all > > >On Thursday, 9 September, 2021, 03:58:40 pm IST, Daniel P. Berrangé > > wrote: > >On Thu, Sep 09, 2021 at 01:20:14AM +0200, Philippe Mathieu-Daudé wrote: > >> This series is experimental! The goal is to better

Re: Rust in Qemu BoF followup 2: Rust toolchain availability

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 03:21, David Gibson wrote: > > Hi again all, > > I've now done.. or at least started... the second part of my followup > from the KVM Forum BoF on Rust in Qemu. > > I've extended the page at https://wiki.qemu.org/RustInQemu with > information on Rust toolchain

Re: Rust in Qemu BoF followup 2: Rust toolchain availability

2021-09-30 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 11:59:42AM +1000, David Gibson wrote: > Hi again all, > > I've now done.. or at least started... the second part of my followup > from the KVM Forum BoF on Rust in Qemu. > > I've extended the page at https://wiki.qemu.org/RustInQemu with > information on Rust toolchain

[PULL 08/44] ppc/xive: Export priority_to_ipb() helper

2021-09-30 Thread David Gibson
From: Cédric Le Goater Signed-off-by: Cédric Le Goater Message-Id: <20210901094153.227671-7-...@kaod.org> Signed-off-by: David Gibson --- hw/intc/xive.c| 21 ++--- include/hw/ppc/xive.h | 11 +++ 2 files changed, 17 insertions(+), 15 deletions(-) diff --git

Re: [RFC PATCH 1/1] hw: aspeed_adc: Add initial Aspeed ADC support

2021-09-30 Thread Cédric Le Goater
Hello Peter, If you run ./scripts/get_maintainer.pl on the patch, it will build the list of persons and mailing list to send to. On 9/30/21 02:42, p...@fb.com wrote: From: Peter Delevoryas This change sets up Aspeed SoC ADC emulation, so that most ADC drivers will pass the initialization

Re: [PATCH 3/3] dtc: Update to version 1.6.1

2021-09-30 Thread Thomas Huth
On 27/08/2021 14.09, Thomas Huth wrote: The dtc submodule is currently pointing to non-release commit. It's nicer if submodules point to release versions instead and since dtc 1.6.1 is available now, let's update to that version. Signed-off-by: Thomas Huth --- dtc | 2 +- 1 file changed, 1

Re: [PATCH v3 06/13] qapi/parser: remove FIXME comment from _append_body_line

2021-09-30 Thread Markus Armbruster
John Snow writes: > True, we do not check the validity of this symbol -- but we don't check > the validity of definition names during parse, either -- that happens > later, during the expr check. I don't want to introduce a dependency on > expr.py:check_name_str here and introduce a cycle. > >

Re: [PATCH] failover: fix unplug pending detection

2021-09-30 Thread Ani Sinha
On Thu, 30 Sep 2021, Laurent Vivier wrote: > Failover needs to detect the end of the PCI unplug to start migration > after the VFIO card has been unplugged. > > To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in > pcie_unplug_device(). > > But since > 17858a169508

Re: TCG Floating Point Support (Work in Progress)

2021-09-30 Thread Alex Bennée
Matt writes: > Hello-- > > I'm excited to share that I have been developing support for TCG > floating point operations; specifically, to accelerate emulation of > x86 guest code which heavily exercises the x87 FPU for a game console > emulator project based on QEMU. So far, this work has

[PULL 32/44] target/ppc: Convert debug to trace events (decrementer and IRQ)

2021-09-30 Thread David Gibson
From: Cédric Le Goater Signed-off-by: Cédric Le Goater Message-Id: <20210920061203.989563-4-...@kaod.org> Signed-off-by: David Gibson --- hw/ppc/ppc.c| 169 hw/ppc/trace-events | 22 +- 2 files changed, 82 insertions(+), 109

Re: [PATCH v2 0/8] i386: Assorted KVM PV and Hyper-V feature improvements

2021-09-30 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 02/09/21 11:35, Vitaly Kuznetsov wrote: >> This is a continuation of "[PATCH 0/3] i386/kvm: Paravirtualized features >> usage >> enforcement" series, thus v2. >> >> This series implements several unrelated features but as there are code >> dependencies between them

Re: [PULL 00/20] NBD patches through 2021-09-27

2021-09-30 Thread Richard W.M. Jones
On Wed, Sep 29, 2021 at 01:29:21PM -0500, Eric Blake wrote: > On Wed, Sep 29, 2021 at 05:03:08PM +0200, Paolo Bonzini wrote: > > On 29/09/21 15:58, Richard Henderson wrote: > > > > > > > /usr/bin/ld: /usr/lib64/libselinux.so: error adding symbols: file > > > in > > > > wrong format > >

Re: [PATCH qemu v2] QEMU coding style mandates spaces for indentation. This change replaces TABs in block files.

2021-09-30 Thread Kevin Wolf
Am 29.09.2021 um 07:30 hat ~farzon geschrieben: > From: Farzon Lotfi > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371 > > Signed-off-by: Farzon Lotfi Just picking one example, but it applies to most hunks of the patch: > diff --git a/block/parallels.c b/block/parallels.c >

[PULL 23/44] target/ppc: add LPCR[HR] to DisasContext and hflags

2021-09-30 Thread David Gibson
From: Matheus Ferst Add a Host Radix field (hr) in DisasContext with LPCR[HR] value to allow us to decide between Radix and HPT while validating instructions arguments. Note that PowerISA v3.1 does not require LPCR[HR] and PATE.HR to match if the thread is in ultravisor/hypervisor real

[PULL 31/44] spapr_numa.c: handle auto NUMA node with no distance info

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza numa_complete_configuration() in hw/core/numa.c always adds a NUMA node for the pSeries machine if none was specified, but without node distance information for the single node created. NUMA FORM1 affinity code didn't rely on numa_state information to do its job,

[PULL 14/44] memory_hotplug.c: handle dev->id = NULL in acpi_memory_hotplug_write()

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza qapi_event_send_mem_unplug_error() deals with @device being NULL by replacing it with an empty string ("") when emitting the event. Aside from the fact that this behavior (qapi visitor mapping NULL pointer to "") can be patched/changed someday, there's also the lack

[PULL 36/44] hw/intc: openpic: Clean up the styles

2021-09-30 Thread David Gibson
From: Bin Meng Correct the multi-line comment format. No functional changes. Signed-off-by: Bin Meng Message-Id: <20210918032653.646370-3-bin.m...@windriver.com> Signed-off-by: David Gibson --- hw/intc/openpic.c| 55 +--- include/hw/ppc/openpic.h

[PULL 37/44] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza This patch has a handful of modifications for the recent added FORM2 support: - to not allocate more than the necessary size in 'distance_table'. At this moment the array is oversized due to allocating uint32_t for all elements, when most of them fits in an

[PULL 38/44] spapr/xive: Fix kvm_xive_source_reset trace event

2021-09-30 Thread David Gibson
From: Cédric Le Goater The trace event was placed in the wrong routine. Move it under kvmppc_xive_source_reset_one(). Fixes: 4e960974d4ee ("xive: Add trace events") Signed-off-by: Cédric Le Goater Message-Id: <20210922070205.1235943-1-...@kaod.org> Reviewed-by: Greg Kurz Signed-off-by: David

Re: TCG Floating Point Support (Work in Progress)

2021-09-30 Thread Matt
Clarification: In my previous message, I talked a lot about x87 emulation; I want to make clear that x87 is merely my motivator. The eventual goal of this TCG FP support is not only to enable fast x87 emulation, but to be generic and robust enough that other QEMU targets could be modified to

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-30 Thread Igor Mammedov
On Wed, 29 Sep 2021 17:47:37 -0400 "Michael S. Tsirkin" wrote: > On Wed, Sep 29, 2021 at 04:41:49PM +0300, Marcel Apfelbaum wrote: > > Hi Michael, > > > > On Mon, Sep 27, 2021 at 12:49 PM Michael S. Tsirkin wrote: > > > > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote:

Re: [PATCH v3 1/3] QIOChannel: Add io_async_writev & io_async_flush callbacks

2021-09-30 Thread Daniel P . Berrangé
On Wed, Sep 29, 2021 at 04:06:33PM -0300, Leonardo Bras Soares Passos wrote: > Hello Peter, thanks for reviewing! > > On Tue, Sep 28, 2021 at 6:52 PM Peter Xu wrote: > > > > On Fri, Sep 24, 2021 at 06:16:04PM +0100, Daniel P. Berrangé wrote: > > > > +ssize_t qio_channel_async_writev(QIOChannel

Re: [PATCH v3 05/13] qapi/parser: improve detection of '@symbol:' preface

2021-09-30 Thread Markus Armbruster
John Snow writes: > Leading and trailing whitespace are now discarded, addressing the FIXME > comment. A new error is raised to detect this accidental case. > > Parsing for args sections is left alone here; the 'name' variable is > moved into the only block where it is used. > > Signed-off-by:

Re: [PATCH v3 08/13] qapi/parser: Introduce NullSection

2021-09-30 Thread Markus Armbruster
John Snow writes: > Here's the weird bit. QAPIDoc generally expects -- virtually everywhere > -- that it will always have a current section. The sole exception to > this is in the case that end_comment() is called, which leaves us with > *no* section. However, in this case, we also don't expect

[PULL 24/44] target/ppc: Check privilege level based on PSR and LPCR[HR] in tlbie[l]

2021-09-30 Thread David Gibson
From: Matheus Ferst PowerISA v3.0B made tlbie[l] hypervisor privileged when PSR=0 and HR=1. To allow the check at translation time, we'll use the HR bit of LPCR to check the MMU mode instead of the PATE.HR. Signed-off-by: Matheus Ferst Message-Id:

[PULL 16/44] spapr_drc.c: do not error_report() when drc->dev->id == NULL

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza The error_report() call in drc_unisolate_logical() is not considering that drc->dev->id can be NULL, and the underlying functions error_report() calls to do its job (vprintf(), g_strdup_printf() ...) has undefined behavior when trying to handle "%s" with NULL

[PULL 06/44] ppc/pnv: Add a comment on the "primary-topology-index" property

2021-09-30 Thread David Gibson
From: Cédric Le Goater On P10, the chip id is calculated from the "Primary topology table index". See skiboot commits for more information [1]. This information is extracted from the hdata on real systems which QEMU needs to emulate. Add this property for all machines even if it is only used on

[PULL 27/44] spapr_numa.c: parametrize FORM1 macros

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza The next preliminary step to introduce NUMA FORM2 affinity is to make the existing code independent of FORM1 macros and values, i.e. MAX_DISTANCE_REF_POINTS, NUMA_ASSOC_SIZE and VCPU_ASSOC_SIZE. This patch accomplishes that by doing the following: - move the NUMA

[PULL 21/44] target/ppc: Convert debug to trace events (exceptions)

2021-09-30 Thread David Gibson
From: Cédric Le Goater Signed-off-by: Cédric Le Goater Message-Id: <20210920061203.989563-2-...@kaod.org> Signed-off-by: David Gibson --- target/ppc/excp_helper.c | 38 ++ target/ppc/trace-events | 8 2 files changed, 18 insertions(+), 28

[PULL 41/44] MAINTAINERS: Orphan obscure ppc platforms

2021-09-30 Thread David Gibson
There are a nunber of old embedded ppc machine types which have been little changed and in "Odd Fixes" state for a long time. With both myself and Greg Kurz moving toward other areas, we no longer have the capacity to keep reviewing and maintaining even the rare patches that come in for those

[PATCH v4 2/2] x86/sev: generate SEV kernel loader hashes in x86_load_linux

2021-09-30 Thread Dov Murik
If SEV is enabled and a kernel is passed via -kernel, pass the hashes of kernel/initrd/cmdline in an encrypted guest page to OVMF for SEV measured boot. Co-developed-by: James Bottomley Signed-off-by: James Bottomley Signed-off-by: Dov Murik Reviewed-by: Daniel P. Berrangé --- hw/i386/x86.c

[PATCH] failover: fix unplug pending detection

2021-09-30 Thread Laurent Vivier
Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in pcie_unplug_device(). But since 17858a169508 ("hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35") we

Re: [PULL 00/20] NBD patches through 2021-09-27

2021-09-30 Thread Daniel P . Berrangé
On Wed, Sep 29, 2021 at 01:29:21PM -0500, Eric Blake wrote: > On Wed, Sep 29, 2021 at 05:03:08PM +0200, Paolo Bonzini wrote: > > On 29/09/21 15:58, Richard Henderson wrote: > > > > > > > /usr/bin/ld: /usr/lib64/libselinux.so: error adding symbols: file > > > in > > > > wrong format > >

[PATCH v3] nbd/server: Add --selinux-label option

2021-09-30 Thread Richard W.M. Jones
Under SELinux, Unix domain sockets have two labels. One is on the disk and can be set with commands such as chcon(1). There is a different label stored in memory (called the process label). This can only be set by the process creating the socket. When using SELinux + SVirt and wanting qemu to

Re: [PATCH 0/1] vmx: Fix mapping

2021-09-30 Thread Richard W.M. Jones
On Thu, Sep 30, 2021 at 09:47:01AM +0100, Daniel P. Berrangé wrote: > On Thu, Sep 30, 2021 at 08:33:48AM +0100, Richard W.M. Jones wrote: > > I propose we deprecate the guid parameter in: > > > > -device vmgenid,guid=8987940a-0951-2cc5-e815-10634ff550b9,id=vmgenid0 > > > > Instead it will be

Re: [PATCH v3 09/13] qapi/parser: add import cycle workaround

2021-09-30 Thread Markus Armbruster
John Snow writes: > There is a cycle that exists in the QAPI generator: [schema -> expr -> "There is" or "there will be once we add strong type hints"? > parser -> schema]. It exists because the QAPIDoc class needs the names > of types defined by the schema module, but the schema module needs

Re: [PATCH v4 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-09-30 Thread Dov Murik
On 30/09/2021 11:32, Daniel P. Berrangé wrote: > > Reviewed-by: Daniel P. Berrangé > Thanks! -Dov

Re: [PATCH v3 00/13] qapi: static typing conversion, pt5b

2021-09-30 Thread Markus Armbruster
John Snow writes: > Hello darkness my old friend; This is part five (b), and focuses on > QAPIDoc in parser.py. Looks basically ready except for PATCH 5, which we can chop off (I think), so you don't have to respin the whole series. "Basically" means we may want to tweak a few commit messages

Re: [PATCH] hw/misc: Add a virtual pci device to dynamically attach memory to QEMU

2021-09-30 Thread David Hildenbrand
On 30.09.21 11:40, david.dai wrote: On Wed, Sep 29, 2021 at 11:30:53AM +0200, David Hildenbrand (da...@redhat.com) wrote: On 27.09.21 14:28, david.dai wrote: On Mon, Sep 27, 2021 at 11:07:43AM +0200, David Hildenbrand (da...@redhat.com) wrote: CAUTION: This email originated from outside

Re: [PATCH] virtio-net : Add check for VIRTIO_NET_F_MAC

2021-09-30 Thread Michael Tokarev
30.09.2021 04:35, Cindy Lu wrote: [] so here come to the final question. which mac address has the higher priority? I think the NET_F_MAC bit means the hw mac address > command-line address. if the hw drivers want to change this. they can simply remove this bit. At the very least, qemu should

[PULL 17/44] qapi/qdev.json: fix DEVICE_DELETED parameters doc

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza Clarify that @device is optional and that 'path' is the device path from QOM. This change follows Markus' suggestion verbatim, provided in full context here: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01891.html Suggested-by: Markus Armbruster

[PULL 29/44] spapr: move FORM1 verifications to post CAS

2021-09-30 Thread David Gibson
From: Daniel Henrique Barboza FORM2 NUMA affinity is prepared to deal with empty (memory/cpu less) NUMA nodes. This is used by the DAX KMEM driver to locate a PAPR SCM device that has a different latency than the original NUMA node from the regular memory. FORM2 is also able to deal with

[PULL 40/44] MAINTAINERS: Remove David & Greg as reviewers for a number of boards

2021-09-30 Thread David Gibson
Greg and I are moving towards other areas and no longer have capacity to act as regular reviewers for several of the secondary ppc machine types. So, remove ourselves as reviewers for Macintosh, PReP, sam460ex and pegasos2 in MAINTAINERS. Signed-off-by: David Gibson Reviewed-by: Greg Kurz

[PULL 34/44] hw/intc: openpic: Correct the reset value of IPIDR for FSL chipset

2021-09-30 Thread David Gibson
From: Bin Meng The reset value of IPIDR should be zero for Freescale chipset, per the following 2 manuals I checked: - P2020RM (https://www.nxp.com/webapp/Download?colCode=P2020RM) - P4080RM (https://www.nxp.com/webapp/Download?colCode=P4080RM) Currently it is set to 1, which leaves the IPI

[PULL 44/44] MAINTAINERS: Demote sPAPR from "Supported" to "Maintained"

2021-09-30 Thread David Gibson
qemu/KVM on Power is no longer my primary job responsibility, nor Greg Kurz'. I still have some time for upstream maintenance, but it's no longer accurate to say that I'm paid to do so. Therefore, reduce sPAPR (the "pseries" machine type) from Supported to Maintained. Signed-off-by: David

Re: [PATCH v3 0/3] monitor: Rate-limit MEMORY_DEVICE_SIZE_CHANGE qapi events per device

2021-09-30 Thread Markus Armbruster
David Hildenbrand writes: > Some fixes for virtio-mem-pci, to properly handle MEMORY_DEVICE_SIZE_CHANGE > events, especially not dropping events of some devices when rate-limiting. Series Reviewed-by: Markus Armbruster

[PATCH v4 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-09-30 Thread Dov Murik
Add the sev_add_kernel_loader_hashes function to calculate the hashes of the kernel/initrd/cmdline and fill a designated OVMF encrypted hash table area. For this to work, OVMF must support an encrypted area to place the data which is advertised via a special GUID in the OVMF reset table. The

Re: [PATCH 0/1] vmx: Fix mapping

2021-09-30 Thread Richard W.M. Jones
More data: I found a colleague who has a Hyper-V instance with a Windows guest and he helped me to understand how Hyper-V represents generation IDs. Hyper-V has had support for generation IDs since long before Microsoft proposed the feature for standardization. Originally (I think pre-2013)

Re: [PATCH 0/1] vmx: Fix mapping

2021-09-30 Thread Laszlo Ersek
On 09/30/21 09:33, Richard W.M. Jones wrote: > > More data: I found a colleague who has a Hyper-V instance with a > Windows guest and he helped me to understand how Hyper-V represents > generation IDs. Hyper-V has had support for generation IDs since long > before Microsoft proposed the feature

[PATCH v3 07/19] qapi: introduce x-query-roms QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info roms" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command is

[PATCH v3 11/19] qapi: introduce x-query-rdma QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info rdma" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command is

[PATCH 3/7] docs: put "make" information together in build-system.rst

2021-09-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/devel/build-system.rst | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst index 3baec158f2..0f636d620e 100644 --- a/docs/devel/build-system.rst +++

Re: Moving QEMU downloads to GitLab Releases?

2021-09-30 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 3:08 PM Stefan Hajnoczi wrote: > > Hi Mike, > QEMU downloads are currently hosted on qemu.org's Apache web server. > Paolo and I were discussing ways to reduce qemu.org network traffic to > save money and eventually turn off the qemu.org server since there is no >

Re: [PULL 00/20] NBD patches through 2021-09-27

2021-09-30 Thread Richard W.M. Jones
On Thu, Sep 30, 2021 at 10:27:45AM -0400, Richard Henderson wrote: > On 9/30/21 4:45 AM, Richard W.M. Jones wrote: > > PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig ../configure --extra-cflags=-m32 > > --disable-vhost-user > > Not --extra-cflags, use --cpu=i386. That also builds the 32 bit binary

[PULL v2 00/33] x86 and misc changes for 2021-09-28

2021-09-30 Thread Paolo Bonzini
The following changes since commit ba0fa56bc06e563de68d2a2bf3ddb0cfea1be4f9: Merge remote-tracking branch 'remotes/vivier/tags/q800-for-6.2-pull-request' into staging (2021-09-29 21:20:49 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-30 Thread Michael S. Tsirkin
On Thu, Sep 30, 2021 at 10:34:24AM +0200, Igor Mammedov wrote: > On Wed, 29 Sep 2021 17:47:37 -0400 > "Michael S. Tsirkin" wrote: > > > On Wed, Sep 29, 2021 at 04:41:49PM +0300, Marcel Apfelbaum wrote: > > > Hi Michael, > > > > > > On Mon, Sep 27, 2021 at 12:49 PM Michael S. Tsirkin > > >

Re: [PATCH qemu v2] QEMU coding style mandates spaces for indentation. This change replaces TABs in block files.

2021-09-30 Thread Vladimir Sementsov-Ogievskiy
9/30/21 12:46, Kevin Wolf wrote: Am 29.09.2021 um 07:30 hat ~farzon geschrieben: From: Farzon Lotfi Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371 Signed-off-by: Farzon Lotfi Just picking one example, but it applies to most hunks of the patch: diff --git a/block/parallels.c

[PATCH v3 00/19] monitor: explicitly permit QMP commands to be added for all use cases

2021-09-30 Thread Daniel P . Berrangé
Previous postings: v1: https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg02295.html v2: https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg03703.html We are still adding HMP commands without any QMP counterparts. This is done because there are a reasonable number of scenarios

[PATCH v3 09/19] qapi: introduce x-query-numa QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info numa" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command is

[PATCH v3 16/19] qapi: introduce x-query-lapic QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info lapic" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command is

[PATCH v3 18/19] qapi: introduce x-query-jit QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info jit" command. It is being added with an "x-" prefix because this QMP command is intended as an ad hoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command is

[PATCH 4/7] docs: reorganize qgraph.rst

2021-09-30 Thread Paolo Bonzini
Clean up the heading levels to use === --- ~~~, and move the command line building near to the other execution steps. Signed-off-by: Paolo Bonzini --- docs/devel/qgraph.rst | 132 +- 1 file changed, 67 insertions(+), 65 deletions(-) diff --git

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

2021-09-30 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 03:20:19PM +0200, Christian Schoenebeck wrote: > On Mittwoch, 29. September 2021 19:48:38 CEST Daniel P. Berrangé wrote: > > On Wed, Sep 29, 2021 at 07:32:39PM +0200, Christian Schoenebeck wrote: > > > On Dienstag, 28. September 2021 18:41:17 CEST Daniel P. Berrangé wrote:

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

2021-09-30 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 03:55:36PM +0200, Christian Schoenebeck wrote: > On Donnerstag, 30. September 2021 15:31:10 CEST Daniel P. Berrangé wrote: > > On Thu, Sep 30, 2021 at 03:20:19PM +0200, Christian Schoenebeck wrote: > > > On Mittwoch, 29. September 2021 19:48:38 CEST Daniel P. Berrangé

Re: [PATCH 1/1] hw: aspeed_gpio: Fix pin I/O type declarations

2021-09-30 Thread Peter Delevoryas
> On Sep 30, 2021, at 5:05 AM, Rashmica Gupta wrote: > > On Thu, 2021-09-30 at 00:45 +, Peter Delevoryas wrote: >> >>> On Sep 28, 2021, at 3:53 AM, Damien Hedde >>> wrote: >>> >>> >>> >>> On 9/28/21 05:24, p...@fb.com wrote: From: Peter Delevoryas Some of the pin

Re: [PATCH 1/7] docs: name included files ".rst.inc"

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 14:33, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > --- a/docs/devel/ci.rst > +++ b/docs/devel/ci.rst > @@ -8,6 +8,6 @@ found at:: > > https://wiki.qemu.org/Testing/CI > > -.. include:: ci-definitions.rst > -.. include:: ci-jobs.rst > -.. include::

Re: [PATCH 3/3] dtc: Update to version 1.6.1

2021-09-30 Thread Greg Kurz
On Thu, 30 Sep 2021 09:10:12 +0200 Thomas Huth wrote: > On 27/08/2021 14.09, Thomas Huth wrote: > > The dtc submodule is currently pointing to non-release commit. It's nicer > > if submodules point to release versions instead and since dtc 1.6.1 is > > available now, let's update to that

Re: [PATCH v2] hw/arm: sabrelite: Connect SPI flash CS line to GPIO3_19

2021-09-30 Thread Peter Maydell
On Mon, 27 Sept 2021 at 15:28, Xuzhou Cheng wrote: > > From: Xuzhou Cheng > > The Linux spi-imx driver does not work on QEMU. The reason is that the > state of m25p80 loops in STATE_READING_DATA state after receiving > RDSR command, the new command is ignored. Before sending a new command, > CS

Re: [PATCH qemu v2] QEMU coding style mandates spaces for indentation. This change replaces TABs in block files.

2021-09-30 Thread Kevin Wolf
Am 30.09.2021 um 14:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > 9/30/21 12:46, Kevin Wolf wrote: > > Am 29.09.2021 um 07:30 hat ~farzon geschrieben: > > > From: Farzon Lotfi > > > > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371 > > > > > > Signed-off-by: Farzon Lotfi >

[PATCH v3 10/19] qapi: introduce x-query-usb QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info usb" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command is

[PATCH 6/7] docs: move gcov section at the end of testing.rst

2021-09-30 Thread Paolo Bonzini
gcov testing applies to all tests, not just make check. Move it out of the make check section. Signed-off-by: Paolo Bonzini --- docs/devel/testing.rst | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/docs/devel/testing.rst

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

2021-09-30 Thread Christian Schoenebeck
On Donnerstag, 30. September 2021 15:31:10 CEST Daniel P. Berrangé wrote: > On Thu, Sep 30, 2021 at 03:20:19PM +0200, Christian Schoenebeck wrote: > > On Mittwoch, 29. September 2021 19:48:38 CEST Daniel P. Berrangé wrote: > > > On Wed, Sep 29, 2021 at 07:32:39PM +0200, Christian Schoenebeck

[PULL v2 17/33] hw/i386/fw_cfg: Set SGX bits in feature control fw_cfg accordingly

2021-09-30 Thread Paolo Bonzini
From: Sean Christopherson Request SGX an SGX Launch Control to be enabled in FEATURE_CONTROL when the features are exposed to the guest. Our design is the SGX Launch Control bit will be unconditionally set in FEATURE_CONTROL, which is unlike host bios. Signed-off-by: Sean Christopherson

[PATCH v3 17/19] qapi: introduce x-query-irq QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info irq" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command is

[PATCH 5/7] docs: reorganize tcg-plugins.rst

2021-09-30 Thread Paolo Bonzini
Clean up the heading levels to use === --- ~~~, and create a new "writing plugins" section. Signed-off-by: Paolo Bonzini --- docs/devel/tcg-plugins.rst | 117 ++--- 1 file changed, 58 insertions(+), 59 deletions(-) diff --git a/docs/devel/tcg-plugins.rst

  1   2   3   >