Re: [PATCH v2 04/10] vdpa-dev: implement the instance_init/class_init interface

2022-03-07 Thread Stefano Garzarella
Hi Longpeng, On Sat, Mar 05, 2022 at 06:06:42AM +, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: Hi Stefano, -Original Message- From: Stefano Garzarella [mailto:sgarz...@redhat.com] Sent: Wednesday, January 19, 2022 7:24 PM To: Longpeng (Mike, Cloud

Re: [PATCH 11/18] tests: expand the migration precopy helper to support failures

2022-03-07 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:25PM +, Daniel P. Berrangé wrote: > static void test_precopy_common(const char *listen_uri, > const char *connect_uri, > TestMigrateStartHook start_hook, >

Re: [PATCH 1/7] target/ppc: Fix vmul[eo]* instructions marked 2.07

2022-03-07 Thread Mark Cave-Ayland
On 05/03/2022 06:36, Cédric Le Goater wrote: On 3/4/22 18:51, matheus.fe...@eldorado.org.br wrote: From: "Lucas Mateus Castro (alqotel)" Some ISA v2.03 Vector Multiply instructions marked to be ISA v2.07 only. This patch fixes it. and MacOSX 10 is also fixed. There are of lot invalid

Re: [PATCH v2 04/10] vdpa-dev: implement the instance_init/class_init interface

2022-03-07 Thread Stefano Garzarella
On Mon, Mar 07, 2022 at 08:55:35AM +, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: -Original Message- From: Stefano Garzarella [mailto:sgarz...@redhat.com] Sent: Monday, March 7, 2022 4:10 PM To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.)

Re: [PATCH v7 00/46] CXl 2.0 emulation Support

2022-03-07 Thread Jonathan Cameron via
On Sun, 6 Mar 2022 16:33:40 -0500 "Michael S. Tsirkin" wrote: > On Sun, Mar 06, 2022 at 05:40:51PM +, Jonathan Cameron wrote: > > Ideally I'd love it if we could start picking up the earlier > > sections of this series as I think those have been reasonably > > well reviewed and should not be

[PULL v2 12/47] hw/vhost-user-i2c: Add support for VIRTIO_I2C_F_ZERO_LENGTH_REQUEST

2022-03-07 Thread Michael S. Tsirkin
From: Viresh Kumar VIRTIO_I2C_F_ZERO_LENGTH_REQUEST is a mandatory feature, that must be implemented by everyone. Add its support. Reviewed-by: Alex Bennée Signed-off-by: Viresh Kumar Message-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-07 Thread Thomas Huth
On 07/03/2022 11.06, Daniel P. Berrangé wrote: On Mon, Mar 07, 2022 at 02:51:23PM +0800, Peter Xu wrote: On Wed, Mar 02, 2022 at 05:49:18PM +, Daniel P. Berrangé wrote: The QMP commands have a trailing newline, but the response does not. This makes the qtest logs hard to follow as the next

[PULL v2 37/47] x86: cleanup unused compat_apic_id_mode

2022-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov commit f862ddbb1a4 (hw/i386: Remove the deprecated pc-1.x machine types) removed the last user of broken APIC ID compat knob, but compat_apic_id_mode itself was forgotten. Clean it up and simplify x86_cpu_apic_id_from_index() Signed-off-by: Igor Mammedov Message-Id:

[PULL 16/16] tests/avocado/linux_ssh_mips_malta.py: add missing accel (tcg) tag

2022-03-07 Thread Philippe Mathieu-Daudé
From: Cleber Rosa Being explicit about the accelerator used on these tests is a good thing in itself, but it will also be used in the filtering rules applied on "make check-avocado". Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL v2 40/47] event_notifier: add event_notifier_get_wfd()

2022-03-07 Thread Michael S. Tsirkin
From: Sergio Lopez event_notifier_get_fd(const EventNotifier *e) always returns EventNotifier's read file descriptor (rfd). This is not a problem when the EventNotifier is backed by a an eventfd, as a single file descriptor is used both for reading and triggering events (rfd == wfd). But, when

[PULL 15/16] isa: Inline and remove one-line isa_init_irq()

2022-03-07 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). It can therefore be removed. isa_ipmi_kcs) Signed-off-by: Bernhard Beschow Reviewed-by: Stefan Berger (tpm_tis_isa) Acked-by: Corey Minyard (isa_ipmi_bt, Reviewed-by: Philippe Mathieu-Daudé

[PULL 17/23] block/io: introduce block driver snapshot-access API

2022-03-07 Thread Hanna Reitz
From: Vladimir Sementsov-Ogievskiy Add new block driver handlers and corresponding generic wrappers. It will be used to allow copy-before-write filter to provide reach fleecing interface in further commit. In future this approach may be used to allow reading qcow2 internal snapshots, for

[PULL 07/23] iotests: Write test output to TEST_DIR

2022-03-07 Thread Hanna Reitz
Drop the use of OUTPUT_DIR (test/qemu-iotests under the build directory), and instead write test output files (.out.bad, .notrun, and .casenotrun) to TEST_DIR. With this, the same test can be run concurrently without the separate instances interfering, because they will need separate TEST_DIRs

[PULL 02/16] target/mips: Remove duplicated MIPSCPU::cp0_count_rate

2022-03-07 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Since the previous commit 9ea89876f9d ("target/mips: Fix cycle counter timing calculations"), MIPSCPU::cp0_count_rate is not used anymore. We don't need it since it is already expressed as mips_def_t::CCRes. Remove the duplicate and clean. Signed-off-by: Philippe

Re: [PATCH] Revert "check-block: replace -makecheck with TAP output"

2022-03-07 Thread Thomas Huth
On 04/03/2022 17.57, Daniel P. Berrangé wrote: On Tue, Feb 08, 2022 at 07:44:32AM -0500, Paolo Bonzini wrote: This reverts commit d316859f4e28c74ab8b618895d2a5e0a865d3cf1. The TAP output is inferior in that it does not include the diff for failed tests. Reported-by: Peter Maydell

Re: [PATCH v6 12/19] vfio-user: IOMMU support for remote device

2022-03-07 Thread Stefan Hajnoczi
On Thu, Mar 03, 2022 at 02:49:53PM +, Jag Raman wrote: > > > > On Mar 2, 2022, at 11:49 AM, Stefan Hajnoczi wrote: > > > > On Mon, Feb 28, 2022 at 07:54:38PM +, Jag Raman wrote: > >> > >> > >>> On Feb 22, 2022, at 5:40 AM, Stefan Hajnoczi wrote: > >>> > >>> On Thu, Feb 17, 2022 at

[PULL v2 04/47] docs/acpi/erst: add device id for ACPI ERST device in pci-ids.txt

2022-03-07 Thread Michael S. Tsirkin
From: Ani Sinha Adding device ID for ERST device in pci-ids.txt. It was missed when ERST related patches were reviewed. CC: Eric DeVolder Reviewed-by: Eric DeVolder Signed-off-by: Ani Sinha Message-Id: <20220223143322.927136-4-...@anisinha.ca> Reviewed-by: Michael S. Tsirkin Signed-off-by:

[PULL v2 10/47] vhost-user: fix VirtQ notifier cleanup

2022-03-07 Thread Michael S. Tsirkin
From: Xueming Li When vhost-user device cleanup, remove notifier MR and munmaps notifier address in the event-handling thread, VM CPU thread writing the notifier in concurrent fails with an error of accessing invalid address. It happens because MR is still being referenced and accessed in

[PULL v2 16/47] hw/i386: Improve bounds checking in OVMF table parsing

2022-03-07 Thread Michael S. Tsirkin
From: Dov Murik When pc_system_parse_ovmf_flash() parses the optional GUIDed table in the end of the OVMF flash memory area, the table length field is checked for sizes that are too small, but doesn't error on sizes that are too big (bigger than the flash content itself). Add a check for

[PULL v2 34/47] acpi: pcihp: pcie: set power on cap on parent slot

2022-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov on creation a PCIDevice has power turned on at the end of pci_qdev_realize() however later on if PCIe slot isn't populated with any children it's power is turned off. It's fine if native hotplug is used as plug callback will power slot on among other things. However when ACPI

[PULL v2 22/47] hw/pci-bridge/pxb: Fix missing swizzle

2022-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron pxb_map_irq_fn() handled the necessary removal of the swizzle applied to the PXB interrupts by the bus to which it was attached but neglected to apply the normal swizzle for PCI root ports on the expander bridge. Result of this was on ARM virt, the PME interrupts for a

[PULL v2 25/47] pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt

2022-03-07 Thread Michael S. Tsirkin
From: Knut Omang Add a small intro + minimal documentation for how to implement SR/IOV support for an emulated device. Signed-off-by: Knut Omang Message-Id: <20220217174504.1051716-3-lukasz.man...@linux.intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL v2 39/47] pci: drop COMPAT_PROP_PCP for 2.0 machine types

2022-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov COMPAT_PROP_PCP is 'on' by default and it's used for turning off PCP capability on PCIe slots for 2.0 machine types using compat machinery. Drop not needed compat glue as Q35 supports migration starting from 2.4 machine types. Signed-off-by: Igor Mammedov Message-Id:

[PULL v2 42/47] configure, meson: allow enabling vhost-user on all POSIX systems

2022-03-07 Thread Michael S. Tsirkin
From: Sergio Lopez With the possibility of using a pipe pair via qemu_pipe() as a replacement on operating systems that doesn't support eventfd, vhost-user can also work on all POSIX systems. This change allows enabling vhost-user on all non-Windows platforms and makes libvhost_user (which

[PULL 11/16] hw/rtc/m48t59-isa: QOM'ify IRQ number

2022-03-07 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow Exposing the IRQ number as a QOM property not only allows it to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id:

Re: [PATCH v2 4/5] Replace qemu_gettimeofday() with g_get_real_time()

2022-03-07 Thread Marc-André Lureau
Hi On Mon, Mar 7, 2022 at 2:13 PM Laurent Vivier wrote: > Le 05/03/2022 à 20:17, Marc-André Lureau a écrit : > > On Sat, Mar 5, 2022 at 1:18 AM wrote: > >> > >> From: Marc-André Lureau > >> > >> GLib g_get_real_time() is an alternative to gettimeofday() which allows > >> to simplify our code.

Re: [PATCH v2 05/10] vdpa-dev: implement the realize interface

2022-03-07 Thread Stefano Garzarella
On Sat, Mar 05, 2022 at 07:07:54AM +, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: -Original Message- From: Stefano Garzarella [mailto:sgarz...@redhat.com] Sent: Wednesday, January 19, 2022 7:31 PM To: Longpeng (Mike, Cloud Infrastructure Service Product

[PULL v2 09/47] vhost-user: remove VirtQ notifier restore

2022-03-07 Thread Michael S. Tsirkin
From: Xueming Li Notifier set when vhost-user backend asks qemu to mmap an FD and offset. When vhost-user backend restart or getting killed, VQ notifier FD and mmap addresses become invalid. After backend restart, MR contains the invalid address will be restored and fail on notifier access. On

[PULL v2 23/47] virtio-net: Unlimit tx queue size if peer is vdpa

2022-03-07 Thread Michael S. Tsirkin
From: Eugenio Pérez The code used to limit the maximum size of tx queue for others backends than vhost_user since the introduction of configurable tx queue size in 9b02e1618cf2 ("virtio-net: enable configurable tx queue size"). As vhost_user, vhost_vdpa devices should deal with memory region

[PULL v2 46/47] tests/acpi: i386: update FACP table differences

2022-03-07 Thread Michael S. Tsirkin
From: Liav Albani After changing the IAPC boot flags register to indicate support of i8042 in the machine chipset to help the guest OS to determine its existence "faster", we need to have the updated FACP ACPI binary images in tree. The ASL changes introduced are shown by the following diff:

[PULL v2 30/47] headers: Add pvpanic.h

2022-03-07 Thread Michael S. Tsirkin
From: zhenwei pi Since 2020, linux kernel started to export pvpanic.h. Import the latest version from linux into QEMU. Signed-off-by: zhenwei pi Message-Id: <20220221122717.1371010-1-pizhen...@bytedance.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by:

Re: [PATCH 07/18] migration: fix use of TLS PSK credentials with a UNIX socket

2022-03-07 Thread Daniel P . Berrangé
On Mon, Mar 07, 2022 at 03:08:53PM +0800, Peter Xu wrote: > On Wed, Mar 02, 2022 at 05:49:21PM +, Daniel P. Berrangé wrote: > > The migration TLS code has a check mandating that a hostname be > > available when starting a TLS session. This is expected when using > > x509 credentials, but is

Re: [PATCH v3] i386/sev: Ensure attestation report length is valid before retrieving

2022-03-07 Thread Daniel P . Berrangé
On Fri, Mar 04, 2022 at 03:11:43PM -0500, Tyler Fanelli wrote: > The length of the attestation report buffer is never checked to be > valid before allocation is made. If the length of the report is returned > to be 0, the buffer to retrieve the attestation buffer is allocated with > length 0 and

[PULL 00/16] MIPS patches for 2022-03-07

2022-03-07 Thread Philippe Mathieu-Daudé
/qemu.git tags/mips-20220307 for you to fetch changes up to 9be5a9f464c1fc106a4aaf941f7792404c43556d: tests/avocado/linux_ssh_mips_malta.py: add missing accel (tcg) tag (2022-03-07 01:35:07 +0100) MIPS patches queue - Fix CP0 cycle

[PULL 14/23] block/reqlist: reqlist_find_conflict(): use ranges_overlap()

2022-03-07 Thread Hanna Reitz
From: Vladimir Sementsov-Ogievskiy Let's reuse convenient helper. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz Message-Id: <20220303194349.2304213-8-vsement...@virtuozzo.com> Signed-off-by: Hanna Reitz --- block/reqlist.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-07 Thread Akihiko Odaki
On 2022/03/07 16:46, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau egl-headless depends on the backing surface to be set before texture are set and updated. Display it (update=true) iff the current scanout kind is SURFACE. egl-headless does not dynamically call

[PULL v2 24/47] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2022-03-07 Thread Michael S. Tsirkin
From: Knut Omang This patch provides the building blocks for creating an SR/IOV PCIe Extended Capability header and register/unregister SR/IOV Virtual Functions. Signed-off-by: Knut Omang Message-Id: <20220217174504.1051716-2-lukasz.man...@linux.intel.com> Reviewed-by: Michael S. Tsirkin

[PULL v2 14/47] vhost-vdpa: make notifiers _init()/_uninit() symmetric

2022-03-07 Thread Michael S. Tsirkin
From: Laurent Vivier vhost_vdpa_host_notifiers_init() initializes queue notifiers for queues "dev->vq_index" to queue "dev->vq_index + dev->nvqs", whereas vhost_vdpa_host_notifiers_uninit() uninitializes the same notifiers for queue "0" to queue "dev->nvqs". This asymmetry seems buggy, fix that

[PULL v2 28/47] pci-bridge/xio3130_upstream: Fix error handling

2022-03-07 Thread Michael S. Tsirkin
From: Jonathan Cameron Goto label is incorrect so msi cleanup would not occur if there is an error in the ssvid initialization. Signed-off-by: Jonathan Cameron Message-Id: <20220218102303.7061-1-jonathan.came...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[PULL v2 32/47] pci: show id info when pci BDF conflict

2022-03-07 Thread Michael S. Tsirkin
From: Zhenzhong Duan During qemu init stage, when there is pci BDF conflicts, qemu print a warning but not showing which device the BDF is occupied by. E.x: "PCI: slot 2 function 0 not available for virtio-scsi-pci, in use by virtio-scsi-pci" To facilitate user knowing the offending device

Re: [PATCH v1] ui/gtk-egl: Check for a valid context before making EGL calls

2022-03-07 Thread Marc-André Lureau
Hi Vivek On Mon, Mar 7, 2022 at 8:39 AM Vivek Kasireddy wrote: > > Since not all listeners (i.e VirtualConsoles) of GL events have > a valid EGL context, make sure that there is a valid context > before making EGL calls. > > This fixes the following crash seen while launching the VM with >

Re: [PATCH v3] tests/tcg/s390x: Cleanup of mie3 tests.

2022-03-07 Thread Thomas Huth
On 01/03/2022 22.43, David Miller wrote: Adds clobbers and merges remaining separate asm statements. v2 -> v3: * Removed all direct memory references in mie3-sel.c v1 -> v2: * Corrected side in rebase conflict, removing older code. Signed-off-by: David Miller ---

RE: [PATCH v2 04/10] vdpa-dev: implement the instance_init/class_init interface

2022-03-07 Thread longpeng2--- via
> -Original Message- > From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Monday, March 7, 2022 4:10 PM > To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.) > > Cc: stefa...@redhat.com; m...@redhat.com; coh...@redhat.com; > pbonz...@redhat.com; Gonglei (Arei) ;

[PULL v2 02/47] ACPI ERST: specification for ERST support

2022-03-07 Thread Michael S. Tsirkin
From: Eric DeVolder Information on the implementation of the ACPI ERST support. Signed-off-by: Eric DeVolder Acked-by: Ani Sinha Message-Id: <20220223143322.927136-2-...@anisinha.ca> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- docs/specs/acpi_erst.rst | 200

[PULL v2 08/47] hw/smbios: add assertion to ensure handles of tables 19 and 32 do not collide

2022-03-07 Thread Michael S. Tsirkin
From: Ani Sinha Since change dcf359832eec02 ("hw/smbios: fix table memory corruption with large memory vms") we reserve additional space between handle numbers of tables 17 and 19 for large VMs. This may cause table 19 to collide with table 32 in their handle numbers for those large VMs. This

[PULL v2 17/47] hw/i386: Replace magic number with field length calculation

2022-03-07 Thread Michael S. Tsirkin
From: Dov Murik Replce the literal magic number 48 with length calculation (32 bytes at the end of the firmware after the table footer + 16 bytes of the OVMF table footer GUID). No functional change intended. Signed-off-by: Dov Murik Message-Id:

[PULL v2 13/47] hw/virtio: vdpa: Fix leak of host-notifier memory-region

2022-03-07 Thread Michael S. Tsirkin
From: Laurent Vivier If call virtio_queue_set_host_notifier_mr fails, should free host-notifier memory-region. This problem can trigger a coredump with some vDPA drivers (mlx5, but not with the vdpasim), if we unplug the virtio-net card from the guest after a stop/start. The same fix has been

[PULL v2 43/47] docs: vhost-user: add subsection for non-Linux platforms

2022-03-07 Thread Michael S. Tsirkin
From: Sergio Lopez Add a section explaining how vhost-user is supported on platforms other than Linux. Signed-off-by: Sergio Lopez Reviewed-by: Stefan Hajnoczi Message-Id: <20220304100854.14829-5-...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL 01/16] target/mips: Fix cycle counter timing calculations

2022-03-07 Thread Philippe Mathieu-Daudé
From: Simon Burge The cp0_count_ns value is calculated from the CP0_COUNT_RATE_DEFAULT constant in target/mips/cpu.c. The cycle counter resolution is defined per-CPU in target/mips/cpu-defs.c.inc; use this value for calculating cp0_count_ns. Fixings timing problems on guest OSs for the 20Kc

[PULL v2 38/47] hw/smbios: Add table 4 parameter, "processor-id"

2022-03-07 Thread Michael S. Tsirkin
From: Patrick Venture This parameter is to be used in the processor_id entry in the type 4 table. This parameter is set as optional and if left will use the values from the CPU model. This enables hiding the host information from the guest and allowing AMD VMs to run pretending to be Intel for

[PULL 14/16] isa: Drop unused attributes from ISADevice

2022-03-07 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow Now that the last users of ISADevice::isairq[] have been resolved during the previous commits, it can be removed for good. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220301220037.76555-7-shen...@gmail.com> Signed-off-by: Philippe

[PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

2022-03-07 Thread marcandre . lureau
From: Marc-André Lureau egl-headless depends on the backing surface to be set before texture are set and updated. Display it (update=true) iff the current scanout kind is SURFACE. Reported-by: Akihiko Odaki Signed-off-by: Marc-André Lureau --- ui/console.c | 7 --- 1 file changed, 4

Re: What is the correct way to handle the VirtIO config space in vhost-user?

2022-03-07 Thread Stefan Hajnoczi
On Fri, Mar 04, 2022 at 04:49:30PM +, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > [[PGP Signed Part:Undecided]] > > On Mon, Feb 28, 2022 at 04:16:43PM +, Alex Bennée wrote: > >> > >> Stefan Hajnoczi writes: > >> > >> > [[PGP Signed Part:Undecided]] > >> > On Fri, Feb 25,

[PULL v2 01/47] qom: assert integer does not overflow

2022-03-07 Thread Michael S. Tsirkin
QOM reference counting is not designed with an infinite amount of references in mind, trying to take a reference in a loop without dropping a reference will overflow the integer. It is generally a symptom of a reference leak (a missing deref, commonly as part of error handling - such as one fixed

[PULL v2 06/47] hw/smbios: code cleanup - use macro definitions for table header handles

2022-03-07 Thread Michael S. Tsirkin
From: Ani Sinha This is a minor cleanup. Using macro definitions makes the code more readable. It is at once clear which tables use which handle numbers in their header. It also makes it easy to calculate the gaps between the numbers and update them if needed. Reviewed-by: Igor Mammedov

[PULL v2 27/47] pcie: Add 1.2 version token for the Power Management Capability

2022-03-07 Thread Michael S. Tsirkin
From: Łukasz Gieryk Signed-off-by: Łukasz Gieryk Message-Id: <20220217174504.1051716-5-lukasz.man...@linux.intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/pci/pci_regs.h

[PULL v2 44/47] tests/acpi: i386: allow FACP acpi table changes

2022-03-07 Thread Michael S. Tsirkin
From: Liav Albani The FACP table is going to be changed for x86/q35 machines. To be sure the following changes are not breaking any QEMU test this change follows step 2 from the bios-tables-test.c guide on changes that affect ACPI tables. Signed-off-by: Liav Albani Acked-by: Ani Sinha

[PULL v2 26/47] pcie: Add a helper to the SR/IOV API

2022-03-07 Thread Michael S. Tsirkin
From: Łukasz Gieryk Convenience function for retrieving the PCIDevice object of the N-th VF. Signed-off-by: Łukasz Gieryk Reviewed-by: Knut Omang Message-Id: <20220217174504.1051716-4-lukasz.man...@linux.intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL v2 31/47] hw/misc/pvpanic: Use standard headers instead

2022-03-07 Thread Michael S. Tsirkin
From: zhenwei pi QEMU side has already imported pvpanic.h from linux, remove bit definitions from include/hw/misc/pvpanic.h, and use include/standard-headers/linux/pvpanic.h instead. Also minor changes for PVPANIC_CRASHLOADED -> PVPANIC_CRASH_LOADED. Signed-off-by: zhenwei pi Message-Id:

[PULL v2 47/47] hw/acpi/microvm: turn on 8042 bit in FADT boot architecture flags if present

2022-03-07 Thread Michael S. Tsirkin
From: Ani Sinha The second bit of IAPC_BOOT_ARCH in FADT table indicates the presence of keyboard controller implemented as 8042 or equivalent micro controller. This change enables this flag for microvms if such a device exists (for example, when added explicitly from the QEMU commandline).

[PULL 07/16] hw/isa/piix4: Resolve global instance variable

2022-03-07 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow Now that piix4_set_irq's opaque parameter references own PIIX4State, piix4_dev becomes redundant. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Message-Id: <20220217101924.15347-6-shen...@gmail.com> Signed-off-by:

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-07 Thread Peter Xu
On Mon, Mar 07, 2022 at 11:09:37AM +0100, Thomas Huth wrote: > On 07/03/2022 11.06, Daniel P. Berrangé wrote: > > On Mon, Mar 07, 2022 at 02:51:23PM +0800, Peter Xu wrote: > > > On Wed, Mar 02, 2022 at 05:49:18PM +, Daniel P. Berrangé wrote: > > > > The QMP commands have a trailing newline,

Re: [PATCH 1/6] aspeed/smc: Use max number of CE instead of 'num_cs'

2022-03-07 Thread Philippe Mathieu-Daudé
On 7/3/22 08:18, Cédric Le Goater wrote: The Aspeed SMC model uses the 'num_cs' field to allocate resources fitting the number of devices of the machine. This is a small optimization without real need in the controller. Simplify modelling and use the max_peripherals field instead. "(which by

[PULL v2 36/47] vhost-vsock: detach the virqueue element in case of error

2022-03-07 Thread Michael S. Tsirkin
From: Stefano Garzarella In vhost_vsock_common_send_transport_reset(), if an element popped from the virtqueue is invalid, we should call virtqueue_detach_element() to detach it from the virtqueue before freeing its memory. Fixes: fc0b9b0e1c ("vhost-vsock: add virtio sockets device") Fixes:

[PULL v2 45/47] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-03-07 Thread Michael S. Tsirkin
From: Liav Albani This can allow the guest OS to determine more easily if i8042 controller is present in the system or not, so it doesn't need to do probing of the controller, but just initialize it immediately, before enumerating the ACPI AML namespace. The 8042 bit in IAPC_BOOT_ARCH was

[PULL 03/23] block/curl.c: Check error return from curl_easy_setopt()

2022-03-07 Thread Hanna Reitz
From: Peter Maydell Coverity points out that we aren't checking the return value from curl_easy_setopt() for any of the calls to it we make in block/curl.c. Some of these options are documented as always succeeding (e.g. CURLOPT_VERBOSE) but others have documented failure cases (e.g.

[PATCH v3 11/12] ui/dbus: do not send 2d scanout until gfx_update

2022-03-07 Thread marcandre . lureau
From: Marc-André Lureau gfx_switch() is called to set the new_surface, not necessarily to display it. It should be displayed after gfx_update(). Send the whole scanout only in this case. Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 37 - 1 file

Re: [PATCH 18/18] tests: ensure migration status isn't reported as failed

2022-03-07 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:32PM +, Daniel P. Berrangé wrote: > Various methods in the migration test call 'query_migrate' to fetch the > current status and then access a particular field. Almost all of these > cases expect the migration to be in a non-failed state. In the case of >

[PATCH v3] qga: Introduce disk smart

2022-03-07 Thread zhenwei pi
After assigning a NVMe/SCSI controller to guest by VFIO, we lose everything on the host side. A guest uses these devices exclusively, we usually don't care the actions on these devices. But there is a low probability that hitting physical hardware warning, we need a chance to get the basic smart

Re: [PATCH v3] qga: Introduce disk smart

2022-03-07 Thread Marc-André Lureau
On Mon, Mar 7, 2022 at 12:46 PM zhenwei pi wrote: > After assigning a NVMe/SCSI controller to guest by VFIO, we lose > everything on the host side. A guest uses these devices exclusively, > we usually don't care the actions on these devices. But there is a > low probability that hitting physical

RE: [PATCH v2 04/10] vdpa-dev: implement the instance_init/class_init interface

2022-03-07 Thread longpeng2--- via
> -Original Message- > From: Stefano Garzarella [mailto:sgarz...@redhat.com] > Sent: Monday, March 7, 2022 5:13 PM > To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.) > > Cc: stefa...@redhat.com; m...@redhat.com; coh...@redhat.com; > pbonz...@redhat.com; Gonglei (Arei) ;

Re: [PULL 00/19] 9p queue 2022-03-04

2022-03-07 Thread Christian Schoenebeck
On Sonntag, 6. März 2022 21:59:55 CET Will Cohen wrote: > On Fri, Mar 4, 2022 at 4:31 PM Will Cohen wrote: > > On Fri, Mar 4, 2022 at 3:16 PM Christian Schoenebeck < > > > > qemu_...@crudebyte.com> wrote: > >> On Freitag, 4. März 2022 19:42:18 CET Peter Maydell wrote: > >> > On Fri, 4 Mar 2022

[PULL v2 00/47] virtio,pc,pci: features, cleanups, fixes

2022-03-07 Thread Michael S. Tsirkin
The following changes since commit 6629bf78aac7e53f83fd0bcbdbe322e2302dfd1f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20220302' into staging (2022-03-03 14:46:48 +) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[PULL v2 11/47] virtio: fix the condition for iommu_platform not supported

2022-03-07 Thread Michael S. Tsirkin
From: Halil Pasic The commit 04ceb61a40 ("virtio: Fail if iommu_platform is requested, but unsupported") claims to fail the device hotplug when iommu_platform is requested, but not supported by the (vhost) device. On the first glance the condition for detecting that situation looks perfect, but

[PULL v2 19/47] virtio-iommu: Support bypass domain

2022-03-07 Thread Michael S. Tsirkin
From: Jean-Philippe Brucker The driver can create a bypass domain by passing the VIRTIO_IOMMU_ATTACH_F_BYPASS flag on the ATTACH request. Bypass domains perform slightly better than domains with identity mappings since they skip translation. Signed-off-by: Jean-Philippe Brucker Message-Id:

[PULL v2 35/47] pc: add option to disable PS/2 mouse/keyboard

2022-03-07 Thread Michael S. Tsirkin
From: Joelle van Dyne On some older software like Windows 7 installer, having both a PS/2 mouse and USB mouse results in only one device working property (which might be a different device each boot). While the workaround to not use a USB mouse with such software is valid, it creates an

[PULL 10/16] hw/rtc/mc146818rtc: QOM'ify IRQ number

2022-03-07 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow Exposing the IRQ number as a QOM property not only allows it to be configurable but also to be displayed in HMP: Before: (qemu) info qtree ... dev: mc146818rtc, id "" gpio-out "" 1 base_year = 0 (0x0) lost_tick_policy

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-07 Thread Daniel P . Berrangé
On Mon, Mar 07, 2022 at 02:51:23PM +0800, Peter Xu wrote: > On Wed, Mar 02, 2022 at 05:49:18PM +, Daniel P. Berrangé wrote: > > The QMP commands have a trailing newline, but the response does not. > > This makes the qtest logs hard to follow as the next QMP command > > appears in the same line

Re: [PATCH 11/18] tests: expand the migration precopy helper to support failures

2022-03-07 Thread Daniel P . Berrangé
On Mon, Mar 07, 2022 at 03:39:22PM +0800, Peter Xu wrote: > On Wed, Mar 02, 2022 at 05:49:25PM +, Daniel P. Berrangé wrote: > > The migration precopy testing helper function always expects the > > migration to run to a completion state. There will be test scenarios > > for TLS where expect

How to backtrace an separate stack?

2022-03-07 Thread Stefan Hajnoczi
Hi, The QEMU emulator uses coroutines with separate stacks. It can be challenging to debug coroutines that have yielded because GDB is not aware of them (no thread is currently executing them). QEMU has a GDB Python script that helps. It "creates" a stack frame for a given coroutine by

Re: [PATCH 2/5] qtest/meson.build: check CONFIG_TCG for boot-serial-test in qtests_ppc

2022-03-07 Thread Thomas Huth
On 03/03/2022 16.35, Daniel Henrique Barboza wrote: 'boot-serial-test' does not work with a QEMU built with --disable-tcg in a IBM POWER9 host. The reason is that without TCG QEMU will default to KVM acceleration, but then the KVM module in IBM POWER hosts aren't able to handle other CPUs. The

Re: [PATCH v3 2/5] qtest: replace gettimeofday with GTimer

2022-03-07 Thread Marc-André Lureau
Hi On Mon, Mar 7, 2022 at 11:46 AM Thomas Huth wrote: > On 07/03/2022 08.03, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > glib provides a convenience helper to measure elapsed time. It isn't > > subject to wall-clock time changes. > > > > Note that this changes the

Re: [PATCH v4 3/4] configure, meson: allow enabling vhost-user on all POSIX systems

2022-03-07 Thread Thomas Huth
On 04/03/2022 11.08, Sergio Lopez wrote: With the possibility of using a pipe pair via qemu_pipe() as a replacement on operating systems that doesn't support eventfd, vhost-user can also work on all POSIX systems. This change allows enabling vhost-user on all non-Windows platforms and makes

Re: [PATCH v3 2/5] qtest: replace gettimeofday with GTimer

2022-03-07 Thread Thomas Huth
On 07/03/2022 09.05, Marc-André Lureau wrote: Hi On Mon, Mar 7, 2022 at 11:46 AM Thomas Huth > wrote: On 07/03/2022 08.03, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau

[PULL v2 03/47] MAINTAINERS: no need to add my name explicitly as a reviewer for VIOT tables

2022-03-07 Thread Michael S. Tsirkin
From: Ani Sinha I am already listed as a reviewer for ACPI/SMBIOS subsystem. There is no need to again add me as a reviewer for ACPI/VIOT. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Ani Sinha Message-Id: <20220223143322.927136-3-...@anisinha.ca> Reviewed-by: Michael S. Tsirkin

Re: [PULL 16/45] tests/qtest/libqos: Add generic pci host bridge in arm-virt machine

2022-03-07 Thread Michael S. Tsirkin
On Fri, Mar 04, 2022 at 08:39:36AM -0500, Michael S. Tsirkin wrote: > From: Eric Auger > > Up to now the virt-machine node contains a virtio-mmio node. > However no driver produces any PCI interface node. Hence, PCI > tests cannot be run with aarch64 binary. > > Add a GPEX driver node that

[PULL 04/16] malta: Move PCI interrupt handling from gt64xxx_pci to piix4

2022-03-07 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow Handling PCI interrupts in piix4 increases cohesion and reduces differences between piix4 and piix3. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220217101924.15347-3-shen...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé ---

[PULL 03/16] hw/mips/gt64xxx_pci: Fix PCI IRQ levels to be preserved during migration

2022-03-07 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow Based on commit e735b55a8c11dd455e31ccd4420e6c9485191d0c: piix_pci: eliminate PIIX3State::pci_irq_levels PIIX3State::pci_irq_levels are redundant which is already tracked by PCIBus layer. So eliminate them. The IRQ levels in the PCIBus layer are already preserved

[PULL v2 33/47] pci: expose TYPE_XIO3130_DOWNSTREAM name

2022-03-07 Thread Michael S. Tsirkin
From: Igor Mammedov Type name will be used in followup patch for cast check in pcihp code. Signed-off-by: Igor Mammedov Message-Id: <20220301151200.3507298-2-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci-bridge/xio3130_downstream.h

[PULL v2 41/47] vhost: use wfd on functions setting vring call fd

2022-03-07 Thread Michael S. Tsirkin
From: Sergio Lopez When ioeventfd is emulated using qemu_pipe(), only EventNotifier's wfd can be used for writing. Use the recently introduced event_notifier_get_wfd() function to obtain the fd that our peer must use to signal the vring. Signed-off-by: Sergio Lopez Reviewed-by: Stefan

Re: [PATCH 3/6] aspeed/smc: Remove 'num_cs' field

2022-03-07 Thread Philippe Mathieu-Daudé
On 7/3/22 08:18, Cédric Le Goater wrote: It is not used anymore. Signed-off-by: Cédric Le Goater --- include/hw/ssi/aspeed_smc.h | 1 - hw/arm/aspeed.c | 2 -- hw/arm/aspeed_ast2600.c | 2 -- hw/arm/aspeed_soc.c | 2 -- hw/ssi/aspeed_smc.c | 7 --- 5

Re: [PATCH 4/6] aspeed/smc: Rename 'max_peripherals' to 'max_cs'

2022-03-07 Thread Philippe Mathieu-Daudé
On 7/3/22 08:18, Cédric Le Goater wrote: The naming makes more sense in a SPI controller model. Signed-off-by: Cédric Le Goater --- include/hw/ssi/aspeed_smc.h | 2 +- hw/ssi/aspeed_smc.c | 42 ++--- 2 files changed, 22 insertions(+), 22

Re: [PATCH 1/5] qtest/meson.build: check CONFIG_TCG for prom-env-test in qtests_ppc

2022-03-07 Thread Thomas Huth
On 03/03/2022 16.35, Daniel Henrique Barboza wrote: 'prom-env-test' is a TCG test that will fail if QEMU is compiled with --disable-tcg: $ QTEST_QEMU_BINARY=./qemu-system-ppc64 ./tests/qtest/prom-env-test /ppc64/prom-env/mac99: qemu-system-ppc64: -accel tcg: invalid accelerator tcg (... hangs

Re: [PATCH v3 3/5] qga: replace qemu_gettimeofday() with g_get_real_time()

2022-03-07 Thread Thomas Huth
On 07/03/2022 08.03, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau GLib g_get_real_time() is an alternative to gettimeofday() which allows to simplify our code. Signed-off-by: Marc-André Lureau Reviewed-by: Laurent Vivier --- qga/commands-posix.c | 14 --

Re: [PATCH 14/18] tests: convert XBZRLE migration test to use common helper

2022-03-07 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:28PM +, Daniel P. Berrangé wrote: > @@ -1255,6 +1259,7 @@ static void > test_precopy_unix_common(TestMigrateStartHook start_hook, > TestMigrateFinishHook finish_hook, > bool expect_fail,

Re: [PATCH 5/5] avocado/replay_kernel.py: make tcg-icount check in run_vm()

2022-03-07 Thread Cédric Le Goater
On 3/3/22 16:35, Daniel Henrique Barboza wrote: The icount framework relies on TCG availability. If QEMU is built with --disable-tcg we won't have icount either, and then this test will fail with the following message in an IBM POWER9 host:

Re: [PULL 13/18] tests/tcg: add vectorised sha512 versions

2022-03-07 Thread Thomas Huth
On 01/03/2022 10.47, Alex Bennée wrote: This builds vectorised versions of sha512 to exercise the vector code: - aarch64 (AdvSimd) - i386 (SSE) - s390x (MVX) - ppc64/ppc64le (power10 vectors) Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id:

Re: [PATCH v2 09/14] vhost: Add VhostIOVATree

2022-03-07 Thread Eugenio Perez Martin
On Mon, Mar 7, 2022 at 4:42 AM Jason Wang wrote: > > On Fri, Mar 4, 2022 at 4:02 PM Eugenio Perez Martin > wrote: > > > > On Fri, Mar 4, 2022 at 3:04 AM Jason Wang wrote: > > > > > > On Fri, Mar 4, 2022 at 12:33 AM Eugenio Perez Martin > > > wrote: > > > > > > > > On Mon, Feb 28, 2022 at 8:06

Re: [PATCH v4 0/4] Enable vhost-user to be used on BSD systems

2022-03-07 Thread Stefan Hajnoczi
On Fri, Mar 04, 2022 at 11:08:50AM +0100, Sergio Lopez wrote: > Since QEMU is already able to emulate ioeventfd using pipefd, we're already > pretty close to supporting vhost-user on non-Linux systems. > > This two patches bridge the gap by: > > 1. Adding a new event_notifier_get_wfd() to return

[PULL v2 07/47] hw/smbios: fix overlapping table handle numbers with large memory vms

2022-03-07 Thread Michael S. Tsirkin
From: Ani Sinha The current smbios table implementation splits the main memory in 16 GiB (DIMM like) chunks. With the current smbios table assignment code, we can have only 512 such chunks before the 16 bit handle numbers in the header for tables 17 and 19 conflict. A guest with more than 8 TiB

  1   2   3   4   5   6   >