Re: [PATCH 02/12] pc-bios/s390-ccw/virtio: Introduce a macro for the DASD block size

2022-07-04 Thread Cornelia Huck
On Sat, Jul 02 2022, Thomas Huth wrote: > On 28/06/2022 15.21, Cornelia Huck wrote: >> On Tue, Jun 28 2022, Thomas Huth wrote: >> >>> Use VIRTIO_DASD_BLOCK_SIZE instead of the magic value 4096. >>> >>> Signed-off-by: Thomas Huth >>> --- >>> pc-bios/s390-ccw/virtio.h| 1 + >>>

Re: [PATCH] e1000: set RX descriptor status in a separate operation

2022-07-04 Thread Jason Wang
在 2022/6/29 17:40, Ding Hui 写道: The code of setting RX descriptor status field maybe work fine in previously, however with the update of glibc version, it shows two issues when guest using dpdk receive packets: 1. The dpdk has a certain probability getting wrong buffer_addr this

[PATCH 3/3] scripts/make-release: Remove CI yaml and more git files from the tarball

2022-07-04 Thread Thomas Huth
These files are of no use in a normal tarball and thus should not be included here. Signed-off-by: Thomas Huth --- scripts/make-release | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/make-release b/scripts/make-release index 176304f30b..61c0fd0bfb 100755 ---

[PATCH 0/3] scripts/make-release: Decrease the size of the release tarballs

2022-07-04 Thread Thomas Huth
Our release tarballs are huge - qemu-7.0.0.tar.xz has a size of 119 MiB. If you look at the contents, more than half of the size is used for the edk2 sources that we ship along to provide the sources for the firmware binaries, too. This feels very wrong, why do we urge users to download such huge

Re: [PATCH] ebpf: replace deprecated bpf_program__set_socket_filter

2022-07-04 Thread Jason Wang
On Fri, Jul 1, 2022 at 10:05 PM Peter Maydell wrote: > > On Wed, 8 Jun 2022 at 09:17, Jason Wang wrote: > > > > On Tue, May 31, 2022 at 1:40 PM Zhang, Chen wrote: > > > > > > > > > > > > > -Original Message- > > > > From: Qemu-devel > > > bounces+chen.zhang=intel@nongnu.org> On

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Markus Armbruster
Leonardo Bras writes: > Signed-off-by: Leonardo Bras > --- > qapi/migration.json | 5 - > migration/migration.c | 1 + > monitor/hmp-cmds.c| 4 > 3 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/qapi/migration.json b/qapi/migration.json > index

[PATCH 1/3] scripts/make-release: Do not include the edk2 sources in the tarball anymore

2022-07-04 Thread Thomas Huth
The edk2 sources are bigger than the sources of QEMU - so they double the size of our release tarballs if we include them. Fortunately, edk2 has a permissive license, so there is no need for us to do this as long as we continue to distribute the edk2 license information in our release tarball.

Re: [PATCH 08/11] target/loongarch: Fix the meaning of ECFG reg's VS field

2022-07-04 Thread gaosong
On 2022/7/4 下午1:18, Richard Henderson wrote: On 7/1/22 15:04, Xiaojuan Yang wrote: By the manual of LoongArch CSR, the VS field(18:16 bits) of ECFG reg means that the number of instructions between each exception entry is 2^VS. Is it a typo in the manual that says "2VS", i.e.

[PATCH 2/3] scripts/make-release: Do not include the skiboot sources in the tarball anymore

2022-07-04 Thread Thomas Huth
The skiboot sources are licensed under the Apache license, so we don't have to include them in our tarball as long as we continue to distribute the skiboot license information in our release tarball. Signed-off-by: Thomas Huth --- scripts/make-release | 15 ++- 1 file changed, 14

Re: API to change the vendor of IDE disk

2022-07-04 Thread Thomas Huth
Hi! On 01/07/2022 10.18, Alex wrote: ... Here is my questions: Q1: How to change the vendor-name of a IDE disk? Is there any API(s) to config it? I can't find the way from libvirt-doc. ​In Qemu code, I seems that "QEMU HARDDISK" is just by default, and it's configurable. I think you

[PATCH] tests/docker/dockerfiles: Add debian-loongarch-cross.docker

2022-07-04 Thread Richard Henderson
Use the pre-packaged toolchain provided by Loongson via github. Signed-off-by: Richard Henderson --- configure | 5 tests/docker/Makefile.include | 2 ++ .../dockerfiles/debian-loongarch-cross.docker | 25 +++ 3 files

Re: Re: [PATCH v2 1/1] qga: add command 'guest-get-cpustats'

2022-07-04 Thread zhenwei pi
On 7/4/22 15:28, Marc-André Lureau wrote: Hi On Mon, Jul 4, 2022 at 6:42 AM zhenwei pi > wrote: A vCPU thread always reaches 100% utilization when: - guest uses idle=poll - disable HLT vm-exit - enable MWAIT Add new guest agent command

[PULL 4/8] ui/cocoa: Fix clipboard text release

2022-07-04 Thread Gerd Hoffmann
From: Akihiko Odaki [-NSPasteboard dataForType:] returns an autoreleased NSString, and callings its release method will result in double-free when the global autorelease pool is released. Use NSAutoreleasePool to release it properly. Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Daniel P . Berrangé
On Mon, Jul 04, 2022 at 08:18:54AM +0200, Markus Armbruster wrote: > Leonardo Bras writes: > > > Signed-off-by: Leonardo Bras > > --- > > qapi/migration.json | 5 - > > migration/migration.c | 1 + > > monitor/hmp-cmds.c| 4 > > 3 files changed, 9 insertions(+), 1 deletion(-) >

Re: [PATCH 1/3] scripts/make-release: Do not include the edk2 sources in the tarball anymore

2022-07-04 Thread Daniel P . Berrangé
On Mon, Jul 04, 2022 at 08:26:34AM +0100, Stefan Hajnoczi wrote: > On Mon, 4 Jul 2022 at 07:45, Thomas Huth wrote: > > > > The edk2 sources are bigger than the sources of QEMU - so they double the > > size of our release tarballs if we include them. Fortunately, edk2 has a > > permissive license,

[PULL 04/23] linux-user: Add LoongArch syscall support

2022-07-04 Thread Richard Henderson
From: Song Gao Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220624031049.1716097-5-gaos...@loongson.cn> Signed-off-by: Richard Henderson --- linux-user/loongarch64/syscall_nr.h | 312

[PULL 07/23] target/loongarch: remove badaddr from CPULoongArch

2022-07-04 Thread Richard Henderson
From: Song Gao We can use CSR_BADV to replace badaddr. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220624031049.1716097-8-gaos...@loongson.cn> Signed-off-by: Richard Henderson --- target/loongarch/cpu.h | 2 --

[PULL 10/23] target/loongarch: remove unused include hw/loader.h

2022-07-04 Thread Richard Henderson
From: Song Gao Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220624031049.1716097-11-gaos...@loongson.cn> Signed-off-by: Richard Henderson --- target/loongarch/cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PULL 12/23] default-configs: Add loongarch linux-user support

2022-07-04 Thread Richard Henderson
From: Song Gao This patch adds loongarch64 linux-user default configs file. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: WANG Xuerui Message-Id: <20220624031049.1716097-13-gaos...@loongson.cn> Signed-off-by: Richard Henderson ---

[PULL 18/23] hw/rtc/ls7a_rtc: Add reset function

2022-07-04 Thread Richard Henderson
From: Xiaojuan Yang Add ls7a rtc reset function to delete timers and clear regs when rtc reset. Signed-off-by: Xiaojuan Yang Message-Id: <20220701093407.2150607-5-yangxiaoj...@loongson.cn> Signed-off-by: Richard Henderson --- hw/rtc/ls7a_rtc.c | 20 1 file changed, 20

Re: [PATCH v4 19/45] target/arm: Implement SME MOVA

2022-07-04 Thread Richard Henderson
On 7/4/22 15:01, Peter Maydell wrote: Columns will not be 8-aligned. On page 38 of 0616A.a, see the illustration of ZA0V.B[22], which is 6 mod 8. Yes, but the column slice number isn't part of offset, it's in index, so (contra the comment) you could do the xor before the "add offset to

[PULL 20/23] hw/rtc/ls7a_rtc: Use tm struct pointer as arguments in toy_time_to_val()

2022-07-04 Thread Richard Henderson
From: Xiaojuan Yang Use pointer as arguments in toy_time_to_val() instead of struct tm. Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220701093407.2150607-7-yangxiaoj...@loongson.cn> Signed-off-by: Richard Henderson --- hw/rtc/ls7a_rtc.c | 14 +++--- 1

[PULL 22/23] target/loongarch: Fix the meaning of ECFG reg's VS field

2022-07-04 Thread Richard Henderson
From: Xiaojuan Yang By the manual of LoongArch CSR, the VS field(18:16 bits) of ECFG reg means that the number of instructions between each exception entry is 2^VS. Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220701093407.2150607-9-yangxiaoj...@loongson.cn>

Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-04 Thread Richard Henderson
On 7/4/22 02:58, Stafford Horne wrote: -static const MemoryRegionOps goldfish_rtc_ops = { -.read = goldfish_rtc_read, -.write = goldfish_rtc_write, -.endianness = DEVICE_NATIVE_ENDIAN, -.valid = { -.min_access_size = 4, -.max_access_size = 4 -} +static const

Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-04 Thread Laurent Vivier
On 04/07/2022 11:59, Richard Henderson wrote: On 7/4/22 02:58, Stafford Horne wrote: -static const MemoryRegionOps goldfish_rtc_ops = { -    .read = goldfish_rtc_read, -    .write = goldfish_rtc_write, -    .endianness = DEVICE_NATIVE_ENDIAN, -    .valid = { -    .min_access_size = 4, - 

Re: [PATCH v2 10/11] hw/openrisc: virt: pass random seed to fdt

2022-07-04 Thread Richard Henderson
On 7/4/22 02:58, Stafford Horne wrote: From: "Jason A. Donenfeld" If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to initialize early. Set this using the usual guest random number generation function. This is confirmed to successfully initialize the RNG on Linux 5.19-rc2.

Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-04 Thread Richard Henderson
On 7/4/22 15:46, Laurent Vivier wrote: On 04/07/2022 11:59, Richard Henderson wrote: On 7/4/22 02:58, Stafford Horne wrote: -static const MemoryRegionOps goldfish_rtc_ops = { -    .read = goldfish_rtc_read, -    .write = goldfish_rtc_write, -    .endianness = DEVICE_NATIVE_ENDIAN, -    .valid

Re: [PATCH v2 11/11] docs/system: openrisc: Add OpenRISC documentation

2022-07-04 Thread Richard Henderson
On 7/4/22 02:58, Stafford Horne wrote: Signed-off-by: Stafford Horne --- docs/system/openrisc/cpu-features.rst | 15 ++ docs/system/openrisc/emulation.rst| 17 +++ docs/system/openrisc/or1k-sim.rst | 43 docs/system/openrisc/virt.rst | 50

Re: [PATCH v4 23/45] target/arm: Implement SME ADDHA, ADDVA

2022-07-04 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:36, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v4: Drop restrict. > --- > target/arm/helper-sme.h| 5 +++ > target/arm/sme.decode | 11 + > target/arm/sme_helper.c| 90 ++ >

Re: [PULL 0/8] Kraxel 20220704 patches

2022-07-04 Thread Richard Henderson
/kraxel/qemu.git tags/kraxel-20220704-pull-request for you to fetch changes up to 927b968d1bc7c0a25edad8161608223b1122a253: hw: canokey: Remove HS support as not compliant to the spec (2022-07-01 12:39:51 +0200) usb: canokey fixes

[PATCH v2 02/12] pc-bios/s390-ccw/virtio: Introduce a macro for the DASD block size

2022-07-04 Thread Thomas Huth
Use VIRTIO_DASD_DEFAULT_BLOCK_SIZE instead of the magic value 4096. Reviewed-by: Eric Farman Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/virtio.h| 1 + pc-bios/s390-ccw/virtio-blkdev.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/virtio.h

[PATCH v2 00/12] s390-ccw bios fixes and clean-ups

2022-07-04 Thread Thomas Huth
The s390-ccw bios currently fails to boot a guest that has been installed into a partition on a DASD drive with 4k sectors. While trying to fix this, I noticed a couple of other problems and possibilites for clean-ups that this series is trying to address now. The first patch is an old one which

[PATCH v2 07/12] pc-bios/s390-ccw/virtio: Read device config after feature negotiation

2022-07-04 Thread Thomas Huth
Feature negotiation should be done first, since some fields in the config area can depend on the negotiated features and thus should rather be read afterwards. While we're at it, also adjust the error message here a little bit (the code is nowadays used for non-block virtio devices, too).

[PATCH v2 08/12] pc-bios/s390-ccw/virtio: Beautify the code for reading virtqueue configuration

2022-07-04 Thread Thomas Huth
It looks nicer if we separate the run_ccw() from the IPL_assert() statement, and the error message should talk about "virtio device" instead of "block device", since this code is nowadays used for non-block (i.e. network) devices, too. Reviewed-by: Cornelia Huck Reviewed-by: Eric Farman

[PATCH v2 03/12] pc-bios/s390-ccw/bootmap: Improve the guessing logic in zipl_load_vblk()

2022-07-04 Thread Thomas Huth
The logic of trying an final ISO or ECKD boot on virtio-block devices is very weird: Since the geometry hardly ever matches in virtio_disk_is_scsi(), virtio_blk_setup_device() always sets a "guessed" disk geometry via virtio_assume_scsi() (which is certainly also wrong in a lot of cases).

Re: [PATCH 0/3] scripts/make-release: Decrease the size of the release tarballs

2022-07-04 Thread Stefan Hajnoczi
Thanks for doing this! I haven't reviewed the licensing impact. Acked-by: Stefan Hajnoczi

[PULL 5/8] hw/usb/canokey: Fix CCID ZLP

2022-07-04 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" CCID could send zero-length packet (ZLP) if we invoke two data_in, two packets would be concated and we could not distinguish them. The CANOKEY_EMU_EP_CTAPHID is imported from canokey-qemu.h Reported-by: MkfsSion Signed-off-by: Hongren (Zenithal) Zheng

[PATCH] acpi/nvdimm: Define trace events for NVDIMM and substitute nvdimm_debug()

2022-07-04 Thread Robert Hoo
Signed-off-by: Robert Hoo Reviewed-by: Jingqi Liu --- This is separated from patch set https://lore.kernel.org/qemu-devel/20220616143542.3e049...@redhat.com/ hw/acpi/nvdimm.c| 35 --- hw/acpi/trace-events| 13 + include/hw/mem/nvdimm.h |

Re: [PATCH v4 0/4] hmat acpi: Don't require initiator value in -numa

2022-07-04 Thread Igor Mammedov
On Fri, 1 Jul 2022 17:08:48 +0100 Jonathan Cameron wrote: > On Thu, 30 Jun 2022 09:30:58 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Jun 30, 2022 at 02:40:13PM +0200, Brice Goglin wrote: > > > > > > Le 30/06/2022 à 14:23, Igor Mammedov a écrit : > > > > On Thu, 30 Jun 2022

Re: [PATCH v4 19/45] target/arm: Implement SME MOVA

2022-07-04 Thread Richard Henderson
On 7/1/22 21:49, Peter Maydell wrote: On Tue, 28 Jun 2022 at 05:40, Richard Henderson wrote: We can reuse the SVE functions for implementing moves to/from horizontal tile slices, but we need new ones for moves to/from vertical tile slices. Signed-off-by: Richard Henderson --- diff --git

Re: [PATCH v1 2/2] migration/multifd: Warn user when zerocopy not working

2022-07-04 Thread Dr. David Alan Gilbert
* Leonardo Brás (leob...@redhat.com) wrote: > On Tue, 2022-06-28 at 17:56 +0100, Dr. David Alan Gilbert wrote: > > * Leonardo Bras Soares Passos (leob...@redhat.com) wrote: > > > On Tue, Jun 28, 2022 at 10:52 AM Dr. David Alan Gilbert > > > wrote: > > > > > > > > * Daniel P. Berrangé

Re: [PATCH] e1000: set RX descriptor status in a separate operation

2022-07-04 Thread Ding Hui
On 2022/7/4 15:10, Jason Wang wrote: 在 2022/6/29 17:40, Ding Hui 写道: @@ -1013,6 +1013,9 @@ e1000_receive_iov(NetClientState *nc, const struct iovec *iov, int iovcnt)   DBGOUT(RX, "Null RX descriptor!!\n");   }   pci_dma_write(d, base, , sizeof(desc)); +   

[PULL 05/23] linux-user: Add LoongArch cpu_loop support

2022-07-04 Thread Richard Henderson
From: Song Gao Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220624031049.1716097-6-gaos...@loongson.cn> Signed-off-by: Richard Henderson --- linux-user/loongarch64/target_cpu.h | 34 ++ linux-user/loongarch64/cpu_loop.c | 96

[PULL 06/23] scripts: add loongarch64 binfmt config

2022-07-04 Thread Richard Henderson
From: Song Gao Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220624031049.1716097-7-gaos...@loongson.cn> Signed-off-by: Richard Henderson --- scripts/qemu-binfmt-conf.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PULL 09/23] target/loongarch: Fix helper_asrtle_d/asrtgt_d raise wrong exception

2022-07-04 Thread Richard Henderson
From: Song Gao Raise EXCCODE_BCE instead of EXCCODE_ADEM for helper_asrtle_d/asrtgt_d. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220624031049.1716097-10-gaos...@loongson.cn> Signed-off-by: Richard Henderson --- target/loongarch/cpu.c

Re: [PATCH 1/3] scripts/make-release: Do not include the edk2 sources in the tarball anymore

2022-07-04 Thread Gerd Hoffmann
> > Also it would need more guidance on what to actually do with the > > tarball, as if you merely unpack it into this dir, it won't work > > as it will be one level of dirs nesting too deep for QEMU's > > build scripts to work. > > I could add some wording how to use the edk2-build.sh script

[PULL 17/23] hw/rtc/ls7a_rtc: Remove unimplemented device in realized function

2022-07-04 Thread Richard Henderson
From: Xiaojuan Yang Remove the unimplemented device when realized ls7a RTC, as it is not uesd. Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220701093407.2150607-4-yangxiaoj...@loongson.cn> Signed-off-by: Richard Henderson --- hw/rtc/ls7a_rtc.c | 1 - 1 file

Re: [PATCH 1/3] scripts/make-release: Do not include the edk2 sources in the tarball anymore

2022-07-04 Thread Thomas Huth
On 04/07/2022 11.14, Daniel P. Berrangé wrote: On Mon, Jul 04, 2022 at 08:26:34AM +0100, Stefan Hajnoczi wrote: On Mon, 4 Jul 2022 at 07:45, Thomas Huth wrote: ... +cat > sources.txt

Re: [PATCH v2 06/11] hw/openrisc: Initialize timer time at startup

2022-07-04 Thread Richard Henderson
On 7/4/22 02:58, Stafford Horne wrote: The last_clk time was initialized at zero, this means when we calculate the first delta we will calculate 0 vs current time which could cause unnecessary hops. Initialize last_clk to the qemu clock on initialization. Signed-off-by: Stafford Horne ---

Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-04 Thread Laurent Vivier
On 04/07/2022 12:21, Richard Henderson wrote: On 7/4/22 15:46, Laurent Vivier wrote: On 04/07/2022 11:59, Richard Henderson wrote: On 7/4/22 02:58, Stafford Horne wrote: -static const MemoryRegionOps goldfish_rtc_ops = { -    .read = goldfish_rtc_read, -    .write = goldfish_rtc_write, -   

Re: [PATCH 1/3] scripts/make-release: Do not include the edk2 sources in the tarball anymore

2022-07-04 Thread Daniel P . Berrangé
On Mon, Jul 04, 2022 at 11:37:11AM +0200, Thomas Huth wrote: > On 04/07/2022 11.14, Daniel P. Berrangé wrote: > > On Mon, Jul 04, 2022 at 08:26:34AM +0100, Stefan Hajnoczi wrote: > > > On Mon, 4 Jul 2022 at 07:45, Thomas Huth wrote: > ... > > > > +cat > sources.txt < > > > +The edk2 sources can

[PATCH v2 01/12] pc-bios/s390-ccw: Add a proper prototype for main()

2022-07-04 Thread Thomas Huth
Older versions of Clang complain if there is no prototype for main(). Add one, and while we're at it, make sure that we use the same type for main.c and netmain.c - since the return value does not matter, declare the return type of main() as "void". Reviewed-by: Cornelia Huck Reviewed-by: Eric

[PATCH v2 11/12] pc-bios/s390-ccw/virtio: Remove "extern" keyword from prototypes

2022-07-04 Thread Thomas Huth
All the other protytpes in the headers here do not use the "extern" keyword, so let's unify this by removing the "extern" from the misfits, too. Reviewed-by: Cornelia Huck Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/virtio.h | 12 ++-- 1 file changed, 6 insertions(+), 6

Re: [PATCH v4 33/45] linux-user/aarch64: Clear tpidr2_el0 if CLONE_SETTLS

2022-07-04 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:57, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > linux-user/aarch64/target_cpu.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/linux-user/aarch64/target_cpu.h b/linux-user/aarch64/target_cpu.h > index

Re: [PATCH v5 04/10] crypto: Make block callbacks return 0 on success

2022-07-04 Thread Hanna Reitz
On 09.06.22 17:27, Alberto Faria wrote: They currently return the value of their headerlen/buflen parameter on success. Returning 0 instead makes it clear that short reads/writes are not possible. Signed-off-by: Alberto Faria Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi ---

Re: [PATCH v5 01/10] block: Add a 'flags' param to bdrv_{pread,pwrite,pwrite_sync}()

2022-07-04 Thread Hanna Reitz
On 09.06.22 17:27, Alberto Faria wrote: For consistency with other I/O functions, and in preparation to implement them using generated_co_wrapper. Callers were updated using this Coccinelle script: @@ expression child, offset, buf, bytes; @@ - bdrv_pread(child, offset, buf, bytes)

Re: [PATCH 1/3] scripts/make-release: Do not include the edk2 sources in the tarball anymore

2022-07-04 Thread Stefan Hajnoczi
On Mon, 4 Jul 2022 at 07:45, Thomas Huth wrote: > > The edk2 sources are bigger than the sources of QEMU - so they double the > size of our release tarballs if we include them. Fortunately, edk2 has a > permissive license, so there is no need for us to do this as long as we > continue to

Re: [PATCH 3/3] scripts/make-release: Remove CI yaml and more git files from the tarball

2022-07-04 Thread Stefan Hajnoczi
On Mon, 4 Jul 2022 at 07:50, Thomas Huth wrote: > > These files are of no use in a normal tarball and thus should not > be included here. > > Signed-off-by: Thomas Huth > --- > scripts/make-release | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/make-release

Re: [PATCH v2 1/1] qga: add command 'guest-get-cpustats'

2022-07-04 Thread Marc-André Lureau
On Mon, Jul 4, 2022 at 11:28 AM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Mon, Jul 4, 2022 at 6:42 AM zhenwei pi wrote: > >> A vCPU thread always reaches 100% utilization when: >> - guest uses idle=poll >> - disable HLT vm-exit >> - enable MWAIT >> >> Add new guest agent

[PULL 6/8] hw/usb/canokey: fix compatibility of qemu-xhci

2022-07-04 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" XHCI wont poll interrupt IN endpoint if NAKed, and needs wakeup Suggested-by: Gerd Hoffmann Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- hw/usb/canokey.c | 23 +++ 1 file changed, 23 insertions(+)

[PATCH] stubs: update replay-tools to match replay.h types

2022-07-04 Thread Claudio Fontana
detected with GCC 13 [-Werror=enum-int-mismatch] Solves Issue #1096. Signed-off-by: Claudio Fontana Cc: Pavel Dovgalyuk --- stubs/replay-tools.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/stubs/replay-tools.c b/stubs/replay-tools.c index

[PULL 1/8] Rename docs/specs/fw_cfg.txt to .rst

2022-07-04 Thread Gerd Hoffmann
From: Simon Sapin This is a separate commit in order to make reviewing the next one easier. Signed-off-by: Simon Sapin Message-Id: <20220625161455.1232954-1-simon.sa...@exyr.org> Signed-off-by: Gerd Hoffmann --- docs/specs/{fw_cfg.txt => fw_cfg.rst} | 0 1 file changed, 0 insertions(+), 0

[PULL 0/8] Kraxel 20220704 patches

2022-07-04 Thread Gerd Hoffmann
The following changes since commit d495e432c04a6394126c35cf96517749708b410f: Merge tag 'pull-aspeed-20220630' of https://github.com/legoater/qemu into staging (2022-06-30 22:04:12 +0530) are available in the Git repository at: https://gitlab.com/kraxel/qemu.git tags/kraxel-20220704-pull

Re: [PATCH 0/3] scripts/make-release: Decrease the size of the release tarballs

2022-07-04 Thread Daniel P . Berrangé
On Mon, Jul 04, 2022 at 08:42:51AM +0200, Thomas Huth wrote: > Our release tarballs are huge - qemu-7.0.0.tar.xz has a size of 119 MiB. > If you look at the contents, more than half of the size is used for the > edk2 sources that we ship along to provide the sources for the firmware > binaries,

Re: [PATCH v2 08/11] target/openrisc: Enable MTTCG

2022-07-04 Thread Richard Henderson
On 7/4/22 02:58, Stafford Horne wrote: case TO_SPR(10, 1): /* TTCR */ -cpu_openrisc_count_update(cpu); +if (cpu_openrisc_timer_has_advanced(cpu)) { +qemu_mutex_lock_iothread(); +cpu_openrisc_count_update(cpu); +

Re: [PATCH v2 09/11] target/openrisc: Interrupt handling fixes

2022-07-04 Thread Richard Henderson
On 7/4/22 02:58, Stafford Horne wrote: When running SMP systems we sometimes were seeing lockups where IPI interrupts were being raised by never handled. This looks to be caused by 2 issues in the openrisc interrupt handling logic. 1. After clearing an interrupt the openrisc_cpu_set_irq

Re: [PATCH v3 4/4] target/mips: introduce Cavium Octeon CPU model

2022-07-04 Thread Pavel Dovgalyuk
ping This is the only non-reviewed patch in the series. On 20.06.2022 15:05, Pavel Dovgalyuk wrote: This patch adds Cavium Octeon 68XX vCPU which provides Octeon-specific instructions. Signed-off-by: Pavel Dovgalyuk -- v3 changes: - split the patch to instruction set introduction and new

Re: [PATCH v5 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() param order

2022-07-04 Thread Hanna Reitz
On 09.06.22 17:27, Alberto Faria wrote: Swap 'buf' and 'bytes' around for consistency with bdrv_co_{pread,pwrite}(), and in preparation to implement these functions using generated_co_wrapper. Callers were updated using this Coccinelle script: @@ expression child, offset, buf, bytes,

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Daniel P. Berrangé (berra...@redhat.com) wrote: >> On Mon, Jul 04, 2022 at 08:18:54AM +0200, Markus Armbruster wrote: >> > Leonardo Bras writes: >> > >> > > Signed-off-by: Leonardo Bras >> > > --- >> > > qapi/migration.json | 5 - >> > >

[PULL 3/8] ui/console: allow display device to be labeled with given id

2022-07-04 Thread Gerd Hoffmann
From: "Wen, Jianxian" The update makes it easier to find and specify devices. They can only be found by device type name without the id field, for example, devices of the same type have the same label. The update also adds a head field, which is useful for devices that support multiple heads,

[PULL 7/8] docs/system/devices/usb/canokey: remove limitations on qemu-xhci

2022-07-04 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- docs/system/devices/canokey.rst | 10 -- 1 file changed, 10 deletions(-) diff --git a/docs/system/devices/canokey.rst b/docs/system/devices/canokey.rst index

Re: [PATCH 1/3] scripts/make-release: Do not include the edk2 sources in the tarball anymore

2022-07-04 Thread Thomas Huth
On 04/07/2022 09.26, Stefan Hajnoczi wrote: On Mon, 4 Jul 2022 at 07:45, Thomas Huth wrote: The edk2 sources are bigger than the sources of QEMU - so they double the size of our release tarballs if we include them. Fortunately, edk2 has a permissive license, so there is no need for us to do

Re: [PATCH v4 19/45] target/arm: Implement SME MOVA

2022-07-04 Thread Peter Maydell
On Mon, 4 Jul 2022 at 10:08, Richard Henderson wrote: > > On 7/1/22 21:49, Peter Maydell wrote: > > On Tue, 28 Jun 2022 at 05:40, Richard Henderson > > wrote: > >> > >> We can reuse the SVE functions for implementing moves to/from > >> horizontal tile slices, but we need new ones for moves

[PULL 21/23] hw/rtc/ls7a_rtc: Fix 'calculate' spelling errors

2022-07-04 Thread Richard Henderson
From: Xiaojuan Yang Fix 'calculate' spelling errors. Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220701093407.2150607-8-yangxiaoj...@loongson.cn> Signed-off-by: Richard Henderson --- hw/rtc/ls7a_rtc.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PULL 15/23] hw/rtc/ls7a_rtc: Fix uninitialied bugs and toymatch writing function

2022-07-04 Thread Richard Henderson
From: Xiaojuan Yang 1. Initialize the tm struct in toymatch_write() and ls7a_toy_start() to fix uninitialized bugs. 2. Fix toymatch_val_to_time function. By the document, when we calculate the expiration year, we should first get current year, and replace the 0-5 bits with toymatch's

[PULL 13/23] target/loongarch: Update README

2022-07-04 Thread Richard Henderson
From: Song Gao Add linux-user emulation introduction Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220624031049.1716097-14-gaos...@loongson.cn> Signed-off-by: Richard Henderson --- target/loongarch/README | 39

[PULL 23/23] target/loongarch: Add lock when writing timer clear reg

2022-07-04 Thread Richard Henderson
From: Xiaojuan Yang There is such error info when running linux kernel: tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked()). calling stack: #0 in raise () at /lib64/libc.so.6 #1 in abort () at /lib64/libc.so.6 #2 in g_assertion_message_expr.cold () at

Re: [PATCH v2 02/11] target/openrisc: Fix memory reading in debugger

2022-07-04 Thread Richard Henderson
On 7/4/22 02:58, Stafford Horne wrote: In commit f0655423ca ("target/openrisc: Reorg tlb lookup") data and instruction TLB reads were combined. This, broke debugger reads where we first tried to map using the data tlb then fall back to the instruction tlb. This patch replicates this logic by

[PATCH v2 04/12] pc-bios/s390-ccw/virtio-blkdev: Simplify/fix virtio_ipl_disk_is_valid()

2022-07-04 Thread Thomas Huth
The s390-ccw bios fails to boot if the boot disk is a virtio-blk disk with a sector size of 4096. For example: dasdfmt -b 4096 -d cdl -y -p -M quick /dev/dasdX fdasd -a /dev/dasdX install a guest onto /dev/dasdX1 using virtio-blk qemu-system-s390x -nographic -hda /dev/dasdX1 The bios then

Re: [PATCH v2 1/1] qga: add command 'guest-get-cpustats'

2022-07-04 Thread Marc-André Lureau
Hi On Mon, Jul 4, 2022 at 6:42 AM zhenwei pi wrote: > A vCPU thread always reaches 100% utilization when: > - guest uses idle=poll > - disable HLT vm-exit > - enable MWAIT > > Add new guest agent command 'guest-get-cpustats' to get guest CPU > statistics, we can know the guest workload and how

[PULL 2/8] Convert fw_cfg.rst to reStructuredText syntax

2022-07-04 Thread Gerd Hoffmann
From: Simon Sapin And add it to specs/index.rst Signed-off-by: Simon Sapin Message-Id: <20220625161455.1232954-2-simon.sa...@exyr.org> Signed-off-by: Gerd Hoffmann --- docs/specs/fw_cfg.rst | 211 +++--- docs/specs/index.rst | 1 + 2 files changed, 119

Re: [PATCH v4 03/45] target/arm: Trap non-streaming usage when Streaming SVE is active

2022-07-04 Thread Richard Henderson
On 7/1/22 16:36, Peter Maydell wrote: +/* + * The SME exception we are testing for is raised via + * AArch64.CheckFPAdvSIMDEnabled(), and for AArch32 this is called + * when EL1 is using A64 or EL2 using A64 and !TGE. + * See AArch32.CheckAdvSIMDOrFPEnabled(). + */ +

Re: [PATCH 2/3] scripts/make-release: Do not include the skiboot sources in the tarball anymore

2022-07-04 Thread Cédric Le Goater
On 7/4/22 08:42, Thomas Huth wrote: The skiboot sources are licensed under the Apache license, so we don't have to include them in our tarball as long as we continue to distribute the skiboot license information in our release tarball. Signed-off-by: Thomas Huth Reviewed-by: Cédric Le Goater

Re: [PATCH 10/11] hw/intc/loongarch_ipi: Fix ipi device access of 64bits

2022-07-04 Thread gaosong
On 2022/7/4 下午1:28, Richard Henderson wrote: On 7/1/22 15:04, Xiaojuan Yang wrote: +static const MemoryRegionOps loongarch_ipi64_ops = { +    .write = loongarch_ipi_writeq, +    .impl.min_access_size = 8, +    .impl.max_access_size = 8, +    .valid.min_access_size = 4, +   

Re: [PATCH 11/11] hw/intc/loongarch_ipi: Fix mail send and any send function

2022-07-04 Thread Richard Henderson
On 7/4/22 14:40, gaosong wrote: After fix these problem, should we only send these two patches? Correct. I will merge the other loongarch patches today, so you should be able to rebase on master. r~

[PULL 00/23] loongarch64 patch queue

2022-07-04 Thread Richard Henderson
The following changes since commit e8e86b484eac70cd86e15fa10a2f0038a536cbba: Merge tag 'pull-riscv-to-apply-20220703-1' of github.com:alistair23/qemu into staging (2022-07-03 06:29:02 +0530) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-la-20220704

[PULL 01/23] linux-user: Add LoongArch generic header files

2022-07-04 Thread Richard Henderson
From: Song Gao This includes: - sockbits.h - target_errno_defs.h - target_fcntl.h - termbits.h - target_resource.h - target_structs.h Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: WANG Xuerui Message-Id:

[PULL 11/23] target/loongarch: Adjust functions and structure to support user-mode

2022-07-04 Thread Richard Henderson
From: Song Gao Some functions and member of the structure are different with softmmu-mode So we need adjust them to support user-mode. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220624031049.1716097-12-gaos...@loongson.cn>

[PULL 16/23] hw/rtc/ls7a_rtc: Fix timer call back function

2022-07-04 Thread Richard Henderson
From: Xiaojuan Yang Replace qemu_irq_pulse with qemu_irq_raise in ls7a_timer_cb function to keep consistent with hardware behavior when raise irq. Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Message-Id: <20220701093407.2150607-3-yangxiaoj...@loongson.cn> Signed-off-by: Richard

[PATCH] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-04 Thread Roman Kagan
It's possible to create non-working configurations by attaching a device to a derivative of PCIe slot (pcie-root-port, ioh3420, etc) and specifying a slot number other that zero, e.g.: -device pcie-root-port,id=s0,... \ -device virtio-blk-pci,bus=s0,addr=4,... Make QEMU reject such

[PATCH v2 05/12] pc-bios/s390-ccw/virtio-blkdev: Remove virtio_assume_scsi()

2022-07-04 Thread Thomas Huth
The virtio_assume_scsi() function is very questionable: First, it is only called for virtio-blk, and not for virtio-scsi, so the naming is already quite confusing. Second, it is called if we detected a "invalid" IPL disk, trying to fix it by blindly setting a sector size of 512. This of course

[PATCH v2 12/12] pc-bios/s390-ccw/netboot.mak: Ignore Clang's warnings about GNU extensions

2022-07-04 Thread Thomas Huth
When compiling the s390-ccw bios with Clang (v14.0), there is currently an unuseful warning like this: CC pc-bios/s390-ccw/ipv6.o ../../roms/SLOF/lib/libnet/ipv6.c:447:18: warning: variable length array folded to constant array as an extension [-Wgnu-folding-constant]

Re: [PATCH v2 2/3] Add zero-copy-copied migration stat

2022-07-04 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Jul 04, 2022 at 08:18:54AM +0200, Markus Armbruster wrote: > > Leonardo Bras writes: > > > > > Signed-off-by: Leonardo Bras > > > --- > > > qapi/migration.json | 5 - > > > migration/migration.c | 1 + > > > monitor/hmp-cmds.c

Re: [PATCH v5 06/10] block: Make 'bytes' param of bdrv_co_{pread,pwrite,preadv,pwritev}() an int64_t

2022-07-04 Thread Hanna Reitz
On 09.06.22 17:27, Alberto Faria wrote: For consistency with other I/O functions, and in preparation to implement bdrv_{pread,pwrite}() using generated_co_wrapper. unsigned int fits in int64_t, so all callers remain correct. bdrv_check_request32() is called further down the stack and causes

[PULL 8/8] hw: canokey: Remove HS support as not compliant to the spec

2022-07-04 Thread Gerd Hoffmann
From: MkfsSion Canokey core currently using 16 bytes as maximum packet size for control endpoint, but to run the device in high-speed a 64 bytes maximum packet size is required according to USB 2.0 specification. Since we don't acutally need to run the device in high-speed, simply don't assign

Re: [PATCH v4 03/45] target/arm: Trap non-streaming usage when Streaming SVE is active

2022-07-04 Thread Peter Maydell
On Mon, 4 Jul 2022 at 09:28, Richard Henderson wrote: > > On 7/1/22 16:36, Peter Maydell wrote: > >> +/* > >> + * The SME exception we are testing for is raised via > >> + * AArch64.CheckFPAdvSIMDEnabled(), and for AArch32 this is called > >> + * when EL1 is using A64 or EL2 using

Re: [PATCH v4 07/45] target/arm: Mark PMULL, FMMLA as non-streaming

2022-07-04 Thread Richard Henderson
On 7/1/22 17:48, Peter Maydell wrote: On Tue, 28 Jun 2022 at 05:28, Richard Henderson wrote: Mark these as a non-streaming instructions, which should trap if full a64 support is not enabled in streaming mode. Signed-off-by: Richard Henderson --- target/arm/sme-fa64.decode | 2 --

Re: [PATCH 11/11] hw/intc/loongarch_ipi: Fix mail send and any send function

2022-07-04 Thread gaosong
On 2022/7/4 下午1:37, Richard Henderson wrote: On 7/1/22 15:04, Xiaojuan Yang wrote: By the document of ipi mailsend device, byte is written only when the mask bit is 0. The original code discards mask bit and overwrite the data always, this patch fixes the issue. Signed-off-by: Xiaojuan Yang

[PULL 03/23] linux-user: Add LoongArch elf support

2022-07-04 Thread Richard Henderson
From: Song Gao Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220624031049.1716097-4-gaos...@loongson.cn> Signed-off-by: Richard Henderson --- linux-user/loongarch64/target_elf.h | 12

[PULL 02/23] linux-user: Add LoongArch signal support

2022-07-04 Thread Richard Henderson
From: Song Gao Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Message-Id: <20220624031049.1716097-3-gaos...@loongson.cn> [rth: Rework extctx frame allocation and locking; Properly read/write fcc from signal frame.] Signed-off-by: Richard Henderson ---

  1   2   3   4   >