Re: [PATCH v2 04/39] semihosting/arm-compat-semi: Avoid using hardcoded /tmp

2022-09-23 Thread Alex Bennée
Bin Meng writes: > From: Bin Meng > > Use g_get_tmp_dir() to get the directory to use for temporary files. > > Signed-off-by: Bin Meng Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 05/39] tcg: Avoid using hardcoded /tmp

2022-09-23 Thread Alex Bennée
Bin Meng writes: > From: Bin Meng > > Use g_get_tmp_dir() to get the directory to use for temporary files. > > Signed-off-by: Bin Meng > Reviewed-by: Marc-André Lureau Reviewed-by: Alex Bennée -- Alex Bennée

[PATCH v12 00/11] target/hexagon: introduce idef-parser

2022-09-23 Thread Anton Johansson via
This patchset introduces the idef-parser for target/hexagon. It's the twelfth iteration of the patchset and includes fixes suggested in previous iterations. idef-parser is a build-time tool built using flex and bison. Its aim is to generate a large part of the tiny code generator frontend for

[PATCH v12 08/11] target/hexagon: import lexer for idef-parser

2022-09-23 Thread Anton Johansson via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson --- target/hexagon/idef-parser/idef-parser.h | 253 +++ target/hexagon/idef-parser/idef-parser.lex | 471 +

Re: [PATCH] arm/monitor: add register name resolution

2022-09-23 Thread Nikola Brkovic
Hello, thank you for your feedback. The choice of registers was relatively arbitrary, I chose registers that would be accessible and valid under all profiles and not part of the CP15. I will look into how this could be implemented through gdbstub, as I was not aware of that possibility. Kind

[PATCH 10/12] audio: refactor audio_get_avail()

2022-09-23 Thread Volker Rümelin
Split out the code in audio_get_avail() that calculates the buffer size that the audio frontend can read. This is similar to the code changes in audio_get_free(). Signed-off-by: Volker Rümelin --- audio/audio.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-)

[PATCH 04/12] alsaaudio: reduce playback latency

2022-09-23 Thread Volker Rümelin
Change the buffer_get_free pcm_ops function to report the free ALSA playback buffer. The generic buffer becomes a temporary buffer and is empty after a call to audio_run_out(). Signed-off-by: Volker Rümelin --- audio/alsaaudio.c | 38 +- 1 file changed, 37

[PATCH 06/12] spiceaudio: add a pcm_ops buffer_get_free function

2022-09-23 Thread Volker Rümelin
It seems there is a demand [1] for low latency playback over SPICE. Add a pcm_ops buffer_get_free function to reduce the playback latency. The mixing engine buffer becomes a temporary buffer. [1] https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg01644.html Signed-off-by: Volker Rümelin

Re: [PATCH] i386: Add new CPU model SapphireRapids

2022-09-23 Thread Xiaoyao Li
On 9/23/2022 9:30 PM, Yang Zhong wrote: On Wed, Sep 21, 2022 at 03:51:42PM +0100, Dr. David Alan Gilbert wrote: * Wang, Lei (lei4.w...@intel.com) wrote: The new CPU model mostly inherits features from Icelake-Server, while adding new features: - AMX (Advance Matrix eXtensions) - Bus Lock

[PATCH qemu] m68k: rework BI_VIRT_RNG_SEED as BI_RNG_SEED

2022-09-23 Thread Jason A. Donenfeld
Following a change on the kernel side (see link), pass BI_RNG_SEED instead of BI_VIRT_RNG_SEED. This should have no impact on compatibility, as there will simply be no effect if it's an old kernel, which is how things have always been. We then use this as an opportunity to add this to q800, since

[PATCH v12 01/11] target/hexagon: update MAINTAINERS for idef-parser

2022-09-23 Thread Anton Johansson via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico Signed-off-by: Anton Johansson Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 738c4eb647..395233061a

[PATCH v12 03/11] target/hexagon: make slot number an unsigned

2022-09-23 Thread Anton Johansson via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Acked-by: Richard Henderson Reviewed-by: Taylor Simpson --- target/hexagon/genptr.c | 24 +--- target/hexagon/macros.h | 2 +- 2 files changed, 14 insertions(+), 12 deletions(-)

[PATCH v12 10/11] target/hexagon: call idef-parser functions

2022-09-23 Thread Anton Johansson via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson --- target/hexagon/gen_helper_funcs.py | 17 -

Re: [PATCH v2 01/39] tests: Change to use g_mkdir()

2022-09-23 Thread Thomas Huth
On 23/09/2022 03.09, Bin Meng wrote: On Fri, Sep 23, 2022 at 3:32 AM Marc-André Lureau wrote: Hi On Tue, Sep 20, 2022 at 1:48 PM Bin Meng wrote: From: Bin Meng Commit 413bebc04603 ("tests: Use g_mkdir_with_parents()") replaces the mkdir() call in the test codes with glib's

[PATCH 05/12] audio: add more audio rate control functions

2022-09-23 Thread Volker Rümelin
The next patch needs two new rate control functions. The first one returns the bytes needed at call time to maintain the selected rate. The second one adjusts the bytes actually sent. Split the audio_rate_get_bytes() function into these two functions and reintroduce audio_rate_get_bytes().

[PATCH 01/12] audio: refactor code in audio_run_out()

2022-09-23 Thread Volker Rümelin
Refactoring the code in audio_run_out() avoids code duplication in the next patch. There's no functional change. Signed-off-by: Volker Rümelin --- audio/audio.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index

[PATCH 11/12] audio: fix sw->buf size for audio recording

2022-09-23 Thread Volker Rümelin
The calculation of the buffer size needed to store audio samples after resampling is wrong for audio recording. For audio recording sw->ratio is calculated as sw->ratio = frontend sample rate / backend sample rate. >From this follows frontend samples = frontend sample rate / backend sample rate

Re: [PATCH 2/5] migration: Fix race on qemu_file_shutdown()

2022-09-23 Thread Peter Xu
On Fri, Sep 23, 2022 at 08:14:25AM +0100, Daniel P. Berrangé wrote: > > Besides that, do you have anything else in mind that would make > > QIOChannelCached better than qemufile (e.g. on how we do caching)? > > Depends what you mean by better ? I think the caching code would be > a bit easier to

Re: [PATCH v8 8/8] s390x/s390-virtio-ccw: add zpcii-disable machine property

2022-09-23 Thread Thomas Huth
On 02/09/2022 19.27, Matthew Rosato wrote: The zpcii-disable machine property can be used to force-disable the use of zPCI interpretation facilities for a VM. By default, this setting will be off for machine 7.2 and newer. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-kvm.c

[PATCH v12 07/11] target/hexagon: prepare input for the idef-parser

2022-09-23 Thread Anton Johansson via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. A build option is also added to fully disable the output of idef-parser, which is useful for debugging. Signed-off-by: Alessandro Di Federico Signed-off-by: Anton

[PATCH v12 11/11] target/hexagon: import additional tests

2022-09-23 Thread Anton Johansson via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson --- tests/tcg/hexagon/Makefile.target | 28 - tests/tcg/hexagon/crt.S| 14 +++ tests/tcg/hexagon/test_abs.S | 17

Re: [PATCH v2 20/39] tests/qtest: {ahci, ide}-test: Use relative path for temporary files for win32

2022-09-23 Thread John Snow
On Thu, Sep 22, 2022 at 4:03 PM Marc-André Lureau wrote: > > Hi > > On Tue, Sep 20, 2022 at 1:50 PM Bin Meng wrote: >> >> From: Bin Meng >> >> These test cases uses "blkdebug:path/to/config:path/to/image" for >> testing. On Windows, absolute file paths contain the delimiter ':' >> which causes

Re: [PATCH v5 4/4] accel: abort if we fail to load the accelerator plugin

2022-09-23 Thread Claudio Fontana
On 9/23/22 17:28, Philippe Mathieu-Daudé via wrote: > On 23/9/22 16:51, Claudio Fontana wrote: >> if QEMU is configured with modules enabled, it is possible that the >> load of an accelerator module will fail. >> Abort in this case, relying on module_object_class_by_name to report >> the specific

Re: [PATCH v5 3/4] module: add Error arguments to module_load and module_load_qom

2022-09-23 Thread Claudio Fontana
On 9/23/22 17:51, Daniel P. Berrangé wrote: > On Fri, Sep 23, 2022 at 04:51:30PM +0200, Claudio Fontana wrote: >> improve error handling during module load, by changing: >> >> bool module_load(const char *prefix, const char *lib_name); >> void module_load_qom(const char *type); >> >> to: >> >> int

[PATCH v12 04/11] target/hexagon: make helper functions non-static

2022-09-23 Thread Anton Johansson via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. This commit also makes some functions in op_helper.c non-static in order to avoid having them marked as unused when using the

[PATCH v12 02/11] target/hexagon: import README for idef-parser

2022-09-23 Thread Anton Johansson via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 722 ++ 2 files changed, 727 insertions(+) create

[PATCH 08/12] audio: swap audio_rate_get_bytes() function parameters

2022-09-23 Thread Volker Rümelin
Swap the rate and info parameters of the audio_rate_get_bytes() function to align the parameter order with the rest of the audio_rate_*() functions. Signed-off-by: Volker Rümelin --- audio/audio.c | 2 +- audio/audio_int.h | 2 +- audio/dbusaudio.c | 4 ++-- audio/noaudio.c| 4 ++--

[PATCH 12/12] audio: prevent an integer overflow in resampling code

2022-09-23 Thread Volker Rümelin
There are corner cases where rate->opos can overflow. For example, if QEMU is started with -audiodev pa,id=audio0, out.frequency=11025 -device ich9-intel-hda -device hda-duplex, audiodev=audio0 and the guest plays audio with a sampling frequency of 44100Hz, rate->opos will overflow after 27.05h

[PATCH] mem/cxl-type3: Add sn option to provide serial number for PCI ecap

2022-09-23 Thread Jonathan Cameron via
The Device Serial Number Extended Capability PCI r6.0 sec 7.9.3 provides a standard way to provide a device serial number as an IEEE defined 64-bit extended unique identifier EUI-64. CXL 2.0 section 8.1.12.2 Memory Device PCIe Capabilities and Extended Capabilities requires this to be used to

Re: [PATCH v8 3/8] s390x/pci: enable for load/store intepretation

2022-09-23 Thread Thomas Huth
On 02/09/2022 19.27, Matthew Rosato wrote: If the ZPCI_OP ioctl reports that is is available and usable, then the underlying KVM host will enable load/store intepretation for any guest device without a SHM bit in the guest function handle. For a device that will be using interpretation support,

[PATCH 07/12] spiceaudio: update comment

2022-09-23 Thread Volker Rümelin
Replace a comment with a question with the answer. Signed-off-by: Volker Rümelin --- audio/spiceaudio.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c index 22892a7b9d..f52f3a8bbb 100644 --- a/audio/spiceaudio.c +++

Re: [PATCH v2 36/39] .gitlab-ci.d/windows.yml: Increase the timeout to 90 minutes

2022-09-23 Thread Alex Bennée
Bin Meng writes: > From: Bin Meng > > commit 9f8e6cad65a6 ("gitlab-ci: Speed up the msys2-64bit job by using > --without-default-devices" > changed to compile QEMU with the --without-default-devices switch for > the msys2-64bit job, due to the build could not complete within the > project

Re: [PATCH v3 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-23 Thread Kevin Wolf
Am 23.09.2022 um 16:46 hat Claudio Fontana geschrieben: > On 9/23/22 16:42, Kevin Wolf wrote: > > Am 23.09.2022 um 16:10 hat Claudio Fontana geschrieben: > >> On 9/21/22 13:56, Kevin Wolf wrote: > >>> Am 21.09.2022 um 09:50 hat Claudio Fontana geschrieben: > On 9/20/22 18:50, Kevin Wolf

[PATCH v12 06/11] target/hexagon: expose next PC in DisasContext

2022-09-23 Thread Anton Johansson via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson --- target/hexagon/translate.c | 3 ++- target/hexagon/translate.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 36/39] .gitlab-ci.d/windows.yml: Increase the timeout to 90 minutes

2022-09-23 Thread Thomas Huth
On 23/09/2022 18.22, Alex Bennée wrote: Bin Meng writes: From: Bin Meng commit 9f8e6cad65a6 ("gitlab-ci: Speed up the msys2-64bit job by using --without-default-devices" changed to compile QEMU with the --without-default-devices switch for the msys2-64bit job, due to the build could not

[PATCH v12 09/11] target/hexagon: import parser for idef-parser

2022-09-23 Thread Anton Johansson via
Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson --- target/hexagon/idef-parser/idef-parser.y| 965 target/hexagon/idef-parser/parser-helpers.c | 2360 +++

[PATCH 00/12] audio: misc. improvements and bug fixes

2022-09-23 Thread Volker Rümelin
A series of audio improvements and fixes. One note: Patch 11/12 "audio: fix sw->buf size for audio recording": If this patch is applied without the patch series "[PATCH 0/2] audio: prevent a class of guest-triggered aborts" at

[PATCH 09/12] audio: rename audio_sw_bytes_free()

2022-09-23 Thread Volker Rümelin
Rename and refactor audio_sw_bytes_free(). This function is not limited to calculate the free audio buffer size. The renamed function returns the number of frames instead of bytes. Signed-off-by: Volker Rümelin --- audio/audio.c | 20 ++-- 1 file changed, 14 insertions(+), 6

[PATCH 02/12] audio: fix GUS audio playback with out.mixing-engine=off

2022-09-23 Thread Volker Rümelin
Fix GUS audio playback with out.mixing-engine=off. The GUS audio device needs to know the amount of samples to produce in advance. To reproduce start qemu with -parallel none -device gus,audiodev=audio0 -audiodev pa,id=audio0,out.mixing-engine=off and start the cartoon.exe demo in a FreeDOS

Re: [PATCH v8 5/8] s390x/pci: enable adapter event notification for interpreted devices

2022-09-23 Thread Thomas Huth
On 02/09/2022 19.27, Matthew Rosato wrote: Use the associated kvm ioctl operation to enable adapter event notification and forwarding for devices when requested. This feature will be set up with or without firmware assist based upon the 'forwarding_assist' setting. Signed-off-by: Matthew

Re: [PATCH v8 0/8] s390x/pci: zPCI interpretation support

2022-09-23 Thread Thomas Huth
On 02/09/2022 19.27, Matthew Rosato wrote: Now that the kernel series [1] is merged and the freeze is over, here is a refresh of the zPCI interpretation series. For QEMU, the majority of the work in enabling instruction interpretation

Re: Maximum QMP reply size

2022-09-23 Thread John Snow
On Wed, Sep 7, 2022 at 7:54 AM Markus Armbruster wrote: > > John Snow writes: > > > Hi, I suspect I have asked this before, but I didn't write it down in > > a comment, so I forget my justification... > > > > In the QMP lib, we need to set a buffering limit for how big a QMP > > message can be

Re: Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2022 at 12:05:40PM +0800, Jason Wang wrote: > On Fri, Sep 23, 2022 at 11:55 AM ho...@yusur.tech wrote: > > > > On Thu, 22 Sep 2022 09:34:41 +0800 Jason Wang wrote: > > > > > > >On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz > > > wrote: > > >> > > >> If I read your response on

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread Thomas Huth
On 22/09/2022 19.18, David Hildenbrand wrote: On 22.09.22 17:55, Thomas Huth wrote: On 22/09/2022 17.38, David Hildenbrand wrote: From: "Jason A. Donenfeld" In order to fully support MSA_EXT_5, we have to support the SHA-512 special instructions. So implement those. The implementation began

Re: [PATCH v8.1 1/2] target/s390x: support SHA-512 extensions

2022-09-23 Thread Thomas Huth
On 22/09/2022 18.35, Jason A. Donenfeld wrote: On Thu, Sep 22, 2022 at 5:55 PM Thomas Huth wrote: On 22/09/2022 17.38, David Hildenbrand wrote: From: "Jason A. Donenfeld" In order to fully support MSA_EXT_5, we have to support the SHA-512 special instructions. So implement those. The

Re: [PATCH v4] x86: add etc/phys-bits fw_cfg file

2022-09-23 Thread Paolo Bonzini
Il gio 22 set 2022, 22:33 Gerd Hoffmann ha scritto: > On Thu, Sep 22, 2022 at 02:38:02PM +0200, Paolo Bonzini wrote: > > On Thu, Sep 22, 2022 at 2:21 PM Gerd Hoffmann wrote: > > > No. This will basically inform the guest that host-phys-bits has been > > > enabled (and pass the number of bits).

[PATCH] virtio: del net client if net_init_tap_one failed

2022-09-23 Thread luzhipeng
From: lu zhipeng If the net tap initializes successful, but failed during network card hot-plugging, the net-tap will remains, so cleanup. Signed-off-by: lu zhipeng --- net/tap.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/net/tap.c b/net/tap.c

Re: [PATCH v5 3/4] module: add Error arguments to module_load and module_load_qom

2022-09-23 Thread Daniel P . Berrangé
On Fri, Sep 23, 2022 at 04:51:30PM +0200, Claudio Fontana wrote: > improve error handling during module load, by changing: > > bool module_load(const char *prefix, const char *lib_name); > void module_load_qom(const char *type); > > to: > > int module_load(const char *prefix, const char *name,

[PATCH v12 05/11] target/hexagon: introduce new helper functions

2022-09-23 Thread Anton Johansson via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code, to correctly implement instruction semantics. "Helper" functions, in the context of this patch, refers to functions which provide a manual TCG implementation of certain features. Signed-off-by: Alessandro Di

Re: [PATCH v2 18/39] tests/qtest: libqtest: Install signal handler via signal()

2022-09-23 Thread Thomas Huth
On 22/09/2022 21.55, Marc-André Lureau wrote: Hi On Tue, Sep 20, 2022 at 2:32 PM Bin Meng > wrote: From: Bin Meng mailto:bin.m...@windriver.com>> At present the codes uses sigaction() to install signal handler with a flag SA_RESETHAND. Such usage can be

[PATCH 03/12] audio: run downstream playback queue unconditionally

2022-09-23 Thread Volker Rümelin
Run the downstream playback queue even if the emulated audio device didn't write new samples. There still may be buffered audio samples downstream. This is for the -audiodev out.mixing-engine=off case. Commit a8a98cfd42 ("audio: run downstream playback queue uncondition- ally") fixed the

[PATCH 09/12] target/ppc: Use gvec to decode XVCPSGN[SD]P

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Moved XVCPSGNSP and XVCPSGNDP to decodetree and used gvec to translate them. xvcpsgnsp: reptloopmaster patch 8 12500 0,00722000 0,00587700 (-18.6%) 25 40000,00604300 0,00521500 (-13.7%) 100 1000

[PATCH 06/12] target/ppc: Move VAVG[SU][BHW] to decodetree and use gvec

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Moved the instructions VAVGUB, VAVGUH, VAVGUW, VAVGSB, VAVGSH, VAVGSW, to decodetree and use gvec with them. For these one the right shift had to be made before the sum as to avoid an overflow, so add 1 at the end if any of the entries had 1 in its LSB as to

Re: [PATCH v3 5/5] tests/tcg/linux-test: Add linux-madvise test

2022-09-23 Thread Laurent Vivier
Le 06/09/2022 à 02:08, Ilya Leoshkevich a écrit : Add a test that checks madvise(MADV_DONTNEED) behavior with anonymous and file mappings in order to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/multiarch/linux/linux-madvise.c | 70 +++ 1 file

Re: [PATCH v5 3/4] module: add Error arguments to module_load and module_load_qom

2022-09-23 Thread Claudio Fontana
On 9/23/22 17:28, Philippe Mathieu-Daudé wrote: > On 23/9/22 16:51, Claudio Fontana wrote: >> improve error handling during module load, by changing: >> >> bool module_load(const char *prefix, const char *lib_name); >> void module_load_qom(const char *type); >> >> to: >> >> int module_load(const

[PATCH v6 1/5] module: removed unused function argument "mayfail"

2022-09-23 Thread Claudio Fontana
mayfail is always passed as false for every invocation throughout the program. It controls whether to printf or not to printf an error on g_module_open failure. Remove this unused argument. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé ---

Re: [PATCH] linux-user: fix readlinkat handling with magic exe symlink

2022-09-23 Thread Laurent Vivier
Le 08/08/2022 à 21:07, Jameson Nash a écrit : Exactly the same as f17f4989fa193fa8279474c5462289a3cfe69aea before was for readlink. I suppose this was simply missed at the time. Signed-off-by: Jameson Nash --- linux-user/syscall.c | 15 +-- 1 file changed, 13 insertions(+), 2

[PATCH 04/12] target/ppc: Move VNEG[WD] to decodtree and use gvec

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Moved the instructions VNEGW and VNEGD to decodetree and used gvec to decode it. vnegw: reptloopmaster patch 8 12500 0,01053200 0,00548400 (-47.9%) 25 40000,01030500 0,0039 (-62.2%) 100 1000

[PATCH 05/12] target/ppc: Move VPRTYB[WDQ] to decodetree and use gvec

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Moved VPRTYBW and VPRTYBD to use gvec and both of them and VPRTYBQ to decodetree. vprtybw: reptloopmaster patch 8 12500 0,01215900 0,00705600 (-42.0%) 25 40000,01198700 0,00574400 (-52.1%) 100 1000

Re: [PATCH v3 3/5] linux-user: Implement stracing madvise()

2022-09-23 Thread Laurent Vivier
Le 06/09/2022 à 02:08, Ilya Leoshkevich a écrit : The default implementation has several problems: the first argument is not displayed as a pointer, making it harder to grep; the third argument is not symbolized; and there are several extra unused arguments. Signed-off-by: Ilya Leoshkevich ---

[PATCH v6 0/5] improve error handling for module load

2022-09-23 Thread Claudio Fontana
CHANGELOG: v5 -> v6: * added a patch by Kevin to handle the dmg warning about missing decompression submodules. (Kevin) * added more verbose comments about all the affected callers of module_load and module_load_qom (Markus) (OPEN ISSUE): change abort() to exit() when type not present even

[PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom

2022-09-23 Thread Claudio Fontana
improve error handling during module load, by changing: bool module_load(const char *prefix, const char *lib_name); void module_load_qom(const char *type); to: int module_load(const char *prefix, const char *name, Error **errp); int module_load_qom(const char *type, Error **errp); where the

Re: [PATCH 5/7] block/nfs: Fix 32-bit Windows build

2022-09-23 Thread Bin Meng
Hi, On Wed, Sep 21, 2022 at 8:10 PM Meng, Bin wrote: > > -Original Message- > From: Philippe Mathieu-Daudé On Behalf Of > Philippe Mathieu-Daudé > Sent: Sunday, September 18, 2022 5:32 AM > To: Bin Meng ; qemu-devel@nongnu.org > Cc: Meng, Bin ; Hanna Reitz ; > Kevin Wolf ; Peter

[PATCH 07/12] target/ppc: Move VABSDU[BHW] to decodetree and use gvec

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Moved VABSDUB, VABSDUH and VABSDUW to decodetree and use gvec to translate them. vabsdub: reptloopmaster patch 8 12500 0,03601600 0,00688500 (-80.9%) 25 40000,03651000 0,00532100 (-85.4%) 100 1000

Re: [PATCH v3 2/3] module: add Error arguments to module_load_one and module_load_qom_one

2022-09-23 Thread Claudio Fontana
On 9/23/22 18:29, Kevin Wolf wrote: > Am 23.09.2022 um 16:46 hat Claudio Fontana geschrieben: >> On 9/23/22 16:42, Kevin Wolf wrote: >>> Am 23.09.2022 um 16:10 hat Claudio Fontana geschrieben: On 9/21/22 13:56, Kevin Wolf wrote: > Am 21.09.2022 um 09:50 hat Claudio Fontana geschrieben:

Re: [PATCH v3 4/5] linux-user: Passthrough MADV_DONTNEED for certain file mappings

2022-09-23 Thread Laurent Vivier
Le 06/09/2022 à 02:08, Ilya Leoshkevich a écrit : This is a follow-up for commit 892a4f6a750a ("linux-user: Add partial support for MADV_DONTNEED"), which added passthrough for anonymous mappings. File mappings can be handled in a similar manner. In order to do that, mark pages, for which

[PATCH v6 2/5] module: rename module_load_one to module_load

2022-09-23 Thread Claudio Fontana
Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé --- audio/audio.c | 2 +- block.c | 4 ++-- block/dmg.c | 4 ++-- hw/core/qdev.c| 2 +- include/qemu/module.h | 10 +- qom/object.c | 4 ++-- softmmu/qtest.c |

[PATCH v6 5/5] accel: abort if we fail to load the accelerator plugin

2022-09-23 Thread Claudio Fontana
if QEMU is configured with modules enabled, it is possible that the load of an accelerator module will fail. Abort in this case, relying on module_object_class_by_name to report the specific load error if any. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson ---

Re: [PATCH v2 36/39] .gitlab-ci.d/windows.yml: Increase the timeout to 90 minutes

2022-09-23 Thread Bin Meng
On Sat, Sep 24, 2022 at 12:24 AM Alex Bennée wrote: > > > Bin Meng writes: > > > From: Bin Meng > > > > commit 9f8e6cad65a6 ("gitlab-ci: Speed up the msys2-64bit job by using > > --without-default-devices" > > changed to compile QEMU with the --without-default-devices switch for > > the

Re: [PATCH] Revert "intel_iommu: Fix irqchip / X2APIC configuration checks"

2022-09-23 Thread Peter Xu
On Fri, Sep 23, 2022 at 06:03:44PM -0400, Peter Xu wrote: > On Fri, Sep 23, 2022 at 10:41:59AM +0200, Igor Mammedov wrote: > > It's worth putting history excavation with explanation what is broken and > > why > > compat stuff is being ignored in the patch. > > Makes sense, I'll amend the commit

[PATCH 03/12] target/ppc: Move V(ADD|SUB)CUW to decodetree and use gvec

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" This patch moves VADDCUW and VSUBCUW to decodtree with gvec using an implementation based on the helper, with the main difference being changing the -1 (aka all bits set to 1) result returned by cmp when true to +1 vaddcuw: reptloopmaster

[PATCH 01/12] target/ppc: Moved VMLADDUHM to decodetree and use gvec

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" This patch moves VMLADDUHM to decodetree a creates a gvec implementation using mul_vec and add_vec. reptloopmaster patch 8 12500 0,01810500 0,00903100 (-50.1%) 25 40000,01739400 0,00747700 (-57.0%) 100

[PATCH 08/12] target/ppc: Use gvec to decode XV[N]ABS[DS]P/XVNEG[DS]P

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Moved XVABSSP, XVABSDP, XVNABSSP,XVNABSDP, XVNEGSP and XVNEGDP to decodetree and used gvec to translate them. xvabssp: reptloopmaster patch 8 12500 0,00477900 0,00476000 (-0.4%) 25 40000,00442800

Re: [PATCH] Revert "intel_iommu: Fix irqchip / X2APIC configuration checks"

2022-09-23 Thread Peter Xu
On Fri, Sep 23, 2022 at 10:41:59AM +0200, Igor Mammedov wrote: > It's worth putting history excavation with explanation what is broken and why > compat stuff is being ignored in the patch. Makes sense, I'll amend the commit message and repost. Thanks, -- Peter Xu

[PATCH 11/12] target/ppc: Moved XSTSTDC[QDS]P to decodetree

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Moved XSTSTDCSP, XSTSTDCDP and XSTSTDCQP to decodetree and moved some of its decoding away from the helper as previously the DCMX, XB and BF were calculated in the helper with the help of cpu_env, now that part was moved to the decodetree with the rest.

[PATCH 10/12] target/ppc: Moved XVTSTDC[DS]P to decodetree

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Moved XVTSTDCSP and XVTSTDCDP to decodetree an restructured the helper to be simpler and do all decoding in the decodetree (so XB, XT and DCMX are all calculated outside the helper). Obs: The tests in this one are slightly different, these are the sum of

Re: [PATCH] linux-user: fix readlinkat handling with magic exe symlink

2022-09-23 Thread Laurent Vivier
Le 08/08/2022 à 21:07, Jameson Nash a écrit : Exactly the same as f17f4989fa193fa8279474c5462289a3cfe69aea before was for readlink. I suppose this was simply missed at the time. Signed-off-by: Jameson Nash --- linux-user/syscall.c | 15 +-- 1 file changed, 13 insertions(+), 2

[PATCH 02/12] target/ppc: Move VMH[R]ADDSHS instruction to decodetree

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" This patch moves VMHADDSHS and VMHRADDSHS to decodetree I couldn't find a satisfactory implementation with TCG inline. vmhaddshs: reptloopmaster patch 8 12500 0,02983400 0,02648500 (-11.2%) 25 40000,02946000

[PATCH 00/12] VMX/VSX instructions with gvec

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" This patch series moves some instructions from decode legacy to decodetree and translate said instructions with gvec. Some cases using gvec ended up with a bigger, more complex and slower so those instructions were only moved to decodetree. In each patch

Re: [PATCH v3 1/5] linux-user: Provide MADV_* definitions

2022-09-23 Thread Laurent Vivier
Le 06/09/2022 à 02:08, Ilya Leoshkevich a écrit : Provide MADV_* definitions using target_mman.h header, similar to what kernel does. Most architectures use the same values, with the exception of alpha and hppa. Signed-off-by: Ilya Leoshkevich --- linux-user/aarch64/target_mman.h | 1 +

[PATCH 12/12] target/ppc: Use gvec to decode XVTSTDC[DS]P

2022-09-23 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Used gvec to translate XVTSTDCSP and XVTSTDCDP. xvtstdcsp: reptlooppatch10 patch12 8 12500 2,70288900 1,24050300 (-54.1%) 25 40002,65665700 1,14078900 (-57.1%) 100 10002,82795400

Re: [PATCH v3 2/5] linux-user: Fix madvise(MADV_DONTNEED) on alpha

2022-09-23 Thread Laurent Vivier
Le 06/09/2022 à 02:08, Ilya Leoshkevich a écrit : MADV_DONTNEED has a different value on alpha, compared to all the other architectures. Fix by using TARGET_MADV_DONTNEED instead of MADV_DONTNEED. Fixes: 892a4f6a750a ("linux-user: Add partial support for MADV_DONTNEED") Signed-off-by: Ilya

[PATCH v6 4/5] dmg: warn when opening dmg images containing blocks of unknown type

2022-09-23 Thread Claudio Fontana
From: Kevin Wolf Signed-off-by: Claudio Fontana --- block/dmg.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/block/dmg.c b/block/dmg.c index a422cf8d5b..f54f1d99d4 100644 --- a/block/dmg.c +++ b/block/dmg.c @@ -254,6 +254,25 @@ static int

Re: [PATCH] hw/net: npcm7xx_emc: set MAC in register space

2022-09-23 Thread Patrick Venture
On Thu, Sep 22, 2022 at 8:21 PM Jason Wang wrote: > On Thu, Sep 22, 2022 at 8:35 PM Peter Maydell > wrote: > > > > On Thu, 22 Sept 2022 at 00:47, Patrick Venture > wrote: > > > > > > The MAC address set from Qemu wasn't being saved into the register > space. > > > > > > Reviewed-by: Hao Wu >

Re: [PATCH] ratelimit: restrict the delay time to a non-negative value

2022-09-23 Thread Markus Armbruster
Alberto Garcia writes: > On Wed 21 Sep 2022 09:47:32 AM +08, Wang Liang wrote: >>> > -return limit->slice_end_time - now; >>> > +return MAX(limit->slice_end_time - now, 0); >>> >>> How can this be negative? slice_end_time is guaranteed to be larger >>> than >>> now: >>> >>> if

[PATCH v7 2/2] i386: Add notify VM exit support

2022-09-23 Thread Chenyi Qiang
There are cases that malicious virtual machine can cause CPU stuck (due to event windows don't open up), e.g., infinite loop in microcode when nested #AC (CVE-2015-5307). No event window means no event (NMI, SMI and IRQ) can be delivered. It leads the CPU to be unavailable to host or other VMs.

Re: [PATCH] Revert "intel_iommu: Fix irqchip / X2APIC configuration checks"

2022-09-23 Thread Igor Mammedov
On Thu, 22 Sep 2022 12:40:01 -0400 Peter Xu wrote: > On Thu, Sep 22, 2022 at 03:46:17PM +0200, Igor Mammedov wrote: > > On Wed, 21 Sep 2022 12:12:27 -0400 > > Peter Xu wrote: > > > > > It's true that when vcpus<=255 we don't require the length of 32bit APIC > > > IDs. However here since we

[PATCH 3/6] hw/core/cpu-sysemu: used cached class in cpu_asidx_from_attrs

2022-09-23 Thread Cédric Le Goater
From: Alex Bennée This is a heavily used function so lets avoid the cost of CPU_GET_CLASS. On the romulus-bmc run it has a modest effect: Before: 36.812 s ± 0.506 s After: 35.912 s ± 0.168 s Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id:

[PATCH 1/6] tests/avocado/machine_aspeed.py: Fix typos on buildroot

2022-09-23 Thread Cédric Le Goater
Replace 'buidroot' and 'builroot' by 'buildroot'. Fixes: f7bc7da0724f ("test/avocado/machine_aspeed.py: Add tests using buildroot images") Signed-off-by: Cédric Le Goater --- tests/avocado/machine_aspeed.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

Re: Re: [PATCH v2] hw/virtio/vhost-user: support obtain vdpa device's mac address automatically

2022-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2022 at 11:53:22AM +0800, ho...@yusur.tech wrote: > On Thu, 22 Sep 2022 09:34:41 +0800 Jason Wang wrote: > > > >On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz > > wrote: > >> > >> If I read your response on the other thread correctly, this change is >

Re: [PATCH 2/5] qga: Add initial FreeBSD support

2022-09-23 Thread Marc-André Lureau
Hi On Thu, Sep 22, 2022 at 4:28 PM Alexander Ivanov < alexander.iva...@virtuozzo.com> wrote: > Add commands-bsd.c file with dumb functions, fix device path and make > the code buildable in FreeBSD. > > Signed-off-by: Alexander Ivanov > --- > meson.build | 2 +- > qga/commands-bsd.c

Re: [PATCH] virtio-gpu: Resource UUID

2022-09-23 Thread Marc-André Lureau
Hi On Wed, Sep 21, 2022 at 1:24 PM Antonio Caggiano < antonio.caggi...@collabora.com> wrote: > Enable resource UUID feature and implement command resource assign UUID. > This is done by introducing a hash table to map resource IDs to their > UUIDs. > > Signed-off-by: Antonio Caggiano > --- >

[PATCH 5/6] ssi: cache SSIPeripheralClass to avoid GET_CLASS()

2022-09-23 Thread Cédric Le Goater
From: Alex Bennée Investigating why some BMC models are so slow compared to a plain ARM virt machines I did some profiling of: ./qemu-system-arm -M romulus-bmc -nic user \ -drive file=obmc-phosphor-image-romulus.static.mtd,format=raw,if=mtd \ -nographic -serial mon:stdio And saw

[PATCH 0/6] aspeed: avocado test boosts

2022-09-23 Thread Cédric Le Goater
Hello, Alex's patchset [1] showed that by avoiding the class cast checkers in hot code paths, performance is greatly improved. See results below. This is a partial resend of [1] plus an extra caching a reference on the AspeedSMC class, which adds an extra 10% boost. Thanks , C. [1]

[PATCH 2/6] cpu: cache CPUClass in CPUState for hot code paths

2022-09-23 Thread Cédric Le Goater
From: Alex Bennée The class cast checkers are quite expensive and always on (unlike the dynamic case who's checks are gated by CONFIG_QOM_CAST_DEBUG). To avoid the overhead of repeatedly checking something which should never change we cache the CPUClass reference for use in the hot code paths.

Re: [PATCH v2] hw/acpi: Add ospm_status hook implementation for acpi-ged

2022-09-23 Thread zhukeqian via
>> > I notice this doesn't seem to have gone in yet -- whose tree is it >> > going to go via? >> >> I'd guess ARM tree (due to almost sole user virt-arm). >> (there are toy users like microvm and new loongarch) > >OK; applied to target-arm.next, thanks. Thanks, Peter. Keqian.

Re: [PATCH v4] x86: add etc/phys-bits fw_cfg file

2022-09-23 Thread Gerd Hoffmann
Hi, > > Given newer processors have more than 40 and for older ones we know > > the possible values for the two relevant x86 vendors we could do > > something along the lines of: > > > >phys-bits >= 41 -> valid > >phys-bits == 40+ AuthenticAMD -> valid > >

Re: [PATCH 2/5] migration: Fix race on qemu_file_shutdown()

2022-09-23 Thread Daniel P . Berrangé
On Thu, Sep 22, 2022 at 03:37:11PM -0400, Peter Xu wrote: > On Thu, Sep 22, 2022 at 05:58:25PM +0100, Daniel P. Berrangé wrote: > > On Tue, Sep 20, 2022 at 06:37:57PM -0400, Peter Xu wrote: > > > In qemu_file_shutdown(), there's a possible race if with current order of > > > operation. There're

[PATCH v7 0/2] Enable notify VM exit

2022-09-23 Thread Chenyi Qiang
Notify VM exit is introduced to mitigate the potential DOS attach from malicious VM. This series is the userspace part to enable this feature through a new KVM capability KVM_CAP_X86_NOTIFY_VMEXIT. The detailed info can be seen in Patch 2. The corresponding KVM support can be found in linux

Re: Inscrutable CI jobs (avocado & Travis s390 check-tcg)

2022-09-23 Thread Thomas Huth
On 23/09/2022 09.28, Daniel P. Berrangé wrote: On Thu, Sep 22, 2022 at 03:04:12PM -0400, Stefan Hajnoczi wrote: QEMU's avocado and Travis s390x check-tcg CI jobs fail often and I don't know why. I think it's due to timeouts but maybe there is something buried in the logs that I missed. I waste

  1   2   >