[Qemu-devel] gsoc idea

2015-03-07 Thread Kővágó Zoltán
hi, i'm thinking about doing a gsoc this year, and i'm interested if you have any opinions on my idea. (i hope i'm not late for this...) currently the audio system in qemu is limited to 2 channels (stereo) sound. also it mixes all sound (if there's more than one sound card) into a single

[Qemu-devel] Removing old/unused audio backends

2015-05-20 Thread Kővágó Zoltán
Hi, I'll be doing doing gsoc this year, where I'll rework the audio backend of qemu to allow multiple backend instances and multichannel audio. This will of course require modifications of the existing audio drivers in qemu, so it's probably a good idea to remove drivers that nobody use

Re: [Qemu-devel] [PATCH v2 00/12] Audio backend cleanup

2015-06-03 Thread Kővágó Zoltán
2015-06-03 21:08 keltezéssel, Peter Maydell írta: On 3 June 2015 at 12:44, Peter Maydell peter.mayd...@linaro.org wrote: On 3 June 2015 at 12:37, Gerd Hoffmann kra...@redhat.com wrote: Any takers to verify coreaudio changes? Alex? Peter? I can have a go but it may take me a while to get to.

[Qemu-devel] [PATCH v3 04/12] audio: expose drv_opaque to init_out and init_in

2015-06-03 Thread Kővágó, Zoltán
init_out and init_in. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/alsaaudio.c | 5 +++-- audio/audio_int.h | 4 ++-- audio/audio_template.h | 2 +- audio/coreaudio.c | 3 ++- audio/dsound_template.h | 6 -- audio/noaudio.c | 4 ++-- audio/ossaudio.c

[Qemu-devel] [PATCH v3 06/12] paaudio: do not use global variables

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/paaudio.c | 98 ++--- 1 file changed, 52 insertions(+), 46 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index bdf6cd5..35e8887 100644 --- a/audio/paaudio.c +++ b

[Qemu-devel] [PATCH v3 00/12] Audio backend cleanup

2015-06-03 Thread Kővágó, Zoltán
: * fixed typo in coreaudio Please review. Kővágó, Zoltán (12): audio: remove esd backend audio: remove fmod backend audio: remove winwave audio driver audio: expose drv_opaque to init_out and init_in alsaaudio: do not use global variables paaudio: do not use global variables ossaudio: do

[Qemu-devel] [PATCH v3 12/12] sdlaudio: do not allow multiple instances

2015-06-03 Thread Kővágó, Zoltán
Since SDL uses a lot of global data, we can't create independent instances of sdl audio backend. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/sdlaudio.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c index b95a7e0..1140f2e 100644

[Qemu-devel] [PATCH v3 02/12] audio: remove fmod backend

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/Makefile.objs | 2 - audio/audio_int.h | 1 - audio/fmodaudio.c | 685 configure | 27 +-- 4 files changed, 2 insertions(+), 713 deletions(-) delete mode 100644

[Qemu-devel] [PATCH v3 07/12] ossaudio: do not use global variables

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/ossaudio.c | 110 ++- 1 file changed, 61 insertions(+), 49 deletions(-) diff --git a/audio/ossaudio.c b/audio/ossaudio.c index 069ff60..d247969 100644 --- a/audio/ossaudio.c +++ b

[Qemu-devel] [PATCH v3 10/12] paaudio: fix possible resource leak

2015-06-03 Thread Kővágó, Zoltán
qpa_audio_init did not clean up resources properly if the initialization failed. This hopefully fixes it. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/paaudio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index

Re: [Qemu-devel] [RFC PATCH] qapi for audio backends

2015-06-03 Thread Kővágó Zoltán
2015-06-03 21:17 keltezéssel, Eric Blake írta: On 06/03/2015 10:48 AM, Kővágó, Zoltán wrote: This is a proposal to add structures into qapi-schema.json to replace the existing configuration structures used by audio backends currently. I'm going to use it to implement a new way to specify audio

[Qemu-devel] [PATCH v3 08/12] wavaudio: do not use global variables

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/wavaudio.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/audio/wavaudio.c b/audio/wavaudio.c index 09083da..c586020 100644 --- a/audio/wavaudio.c +++ b/audio/wavaudio.c

Re: [Qemu-devel] [PATCH v2 11/12] coreaudio: do not use global variables where possible

2015-06-03 Thread Kővágó Zoltán
2015-06-03 21:19 keltezéssel, Peter Maydell írta: On 3 June 2015 at 11:49, Kővágó, Zoltán dirty.ice...@gmail.com wrote: Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/coreaudio.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions

[Qemu-devel] [PATCH v3 11/12] coreaudio: do not use global variables where possible

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/coreaudio.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index 20346bc..6dfd63e 100644 --- a/audio/coreaudio.c +++ b/audio

[Qemu-devel] [PATCH v3 01/12] audio: remove esd backend

2015-06-03 Thread Kővágó, Zoltán
ESD is no longer developed and replaced by PulseAudio. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/Makefile.objs | 1 - audio/audio_int.h | 1 - audio/esdaudio.c| 557 configure | 18 +- 4 files changed

[Qemu-devel] [PATCH v3 09/12] dsoundaudio: do not use global variables

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/dsound_template.h | 18 audio/dsoundaudio.c | 106 2 files changed, 74 insertions(+), 50 deletions(-) diff --git a/audio/dsound_template.h b/audio/dsound_template.h index

[Qemu-devel] [PATCH v3 03/12] audio: remove winwave audio driver

2015-06-03 Thread Kővágó, Zoltán
DirectSound should be a superior choice on Windows. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/Makefile.objs | 1 - audio/audio_int.h| 1 - audio/winwaveaudio.c | 717 --- configure| 13 +- 4 files changed

Re: [Qemu-devel] [RFC PATCH v2] qapi for audio backends

2015-06-04 Thread Kővágó Zoltán
Hi, 2015-06-04 17:30 keltezéssel, Gerd Hoffmann írta: Not sure about this one, so it's not yet in this patch: * remove poll_mode: another obscure setting, and it's only matter of time until the code bitrots enough to break it. I'd tend to drop this too, but it's probably good to check what

[Qemu-devel] [PATCH v3 05/12] alsaaudio: do not use global variables

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/alsaaudio.c | 160 +- 1 file changed, 87 insertions(+), 73 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 87e71c6..d7e181b 100644 --- a/audio/alsaaudio.c

Re: [Qemu-devel] [RFC PATCH v2] qapi for audio backends

2015-06-05 Thread Kővágó Zoltán
Hi, 2015-06-05 12:57 keltezéssel, Gerd Hoffmann írta: Yeah, I've already hit a problem. The opts_visitor doesn't really handle nested structs (it just flattens it into a single, non hierarchic namespace), which is a problem because of the input and output options. First I need to make them

[Qemu-devel] [PATCH v2 08/12] wavaudio: do not use global variables

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/wavaudio.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/audio/wavaudio.c b/audio/wavaudio.c index 09083da..c586020 100644 --- a/audio/wavaudio.c +++ b/audio/wavaudio.c

[Qemu-devel] [PATCH v2 01/12] audio: remove esd backend

2015-06-03 Thread Kővágó, Zoltán
ESD is no longer developed and replaced by PulseAudio. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/Makefile.objs | 1 - audio/audio_int.h | 1 - audio/esdaudio.c| 557 configure | 18 +- 4 files changed

[Qemu-devel] [PATCH v2 00/12] Audio backend cleanup

2015-06-03 Thread Kővágó, Zoltán
backend, as I do not have a Mac to test it. Patches are also available at https://github.com/DirtYiCE/qemu.git in tag audio-cleanup-v2 to simplify testing. Changes since v1: * sdl no longer removed * fixed style issues in `audio: expose drv_opaque to init_out and init_in' Please review. Kővágó

[Qemu-devel] [PATCH v2 07/12] ossaudio: do not use global variables

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/ossaudio.c | 110 ++- 1 file changed, 61 insertions(+), 49 deletions(-) diff --git a/audio/ossaudio.c b/audio/ossaudio.c index 069ff60..d247969 100644 --- a/audio/ossaudio.c +++ b

[Qemu-devel] [PATCH v2 11/12] coreaudio: do not use global variables where possible

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/coreaudio.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index 20346bc..9f731b7 100644 --- a/audio/coreaudio.c +++ b/audio

[Qemu-devel] [PATCH v2 05/12] alsaaudio: do not use global variables

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/alsaaudio.c | 160 +- 1 file changed, 87 insertions(+), 73 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 87e71c6..d7e181b 100644 --- a/audio/alsaaudio.c

[Qemu-devel] [PATCH v2 03/12] audio: remove winwave audio driver

2015-06-03 Thread Kővágó, Zoltán
DirectSound should be a superior choice on Windows. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/Makefile.objs | 1 - audio/audio_int.h| 1 - audio/winwaveaudio.c | 717 --- configure| 13 +- 4 files changed

[Qemu-devel] [PATCH v2 12/12] sdlaudio: do not allow multiple instances

2015-06-03 Thread Kővágó, Zoltán
Since SDL uses a lot of global data, we can't create independent instances of sdl audio backend. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/sdlaudio.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c index b95a7e0..1140f2e 100644

[Qemu-devel] [PATCH v2 10/12] paaudio: fix possible resource leak

2015-06-03 Thread Kővágó, Zoltán
qpa_audio_init did not clean up resources properly if the initialization failed. This hopefully fixes it. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/paaudio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index

[Qemu-devel] [PATCH v2 02/12] audio: remove fmod backend

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/Makefile.objs | 2 - audio/audio_int.h | 1 - audio/fmodaudio.c | 685 configure | 27 +-- 4 files changed, 2 insertions(+), 713 deletions(-) delete mode 100644

[Qemu-devel] [PATCH v2 06/12] paaudio: do not use global variables

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/paaudio.c | 98 ++--- 1 file changed, 52 insertions(+), 46 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index bdf6cd5..35e8887 100644 --- a/audio/paaudio.c +++ b

[Qemu-devel] [PATCH v2 04/12] audio: expose drv_opaque to init_out and init_in

2015-06-03 Thread Kővágó, Zoltán
init_out and init_in. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/alsaaudio.c | 5 +++-- audio/audio_int.h | 4 ++-- audio/audio_template.h | 2 +- audio/coreaudio.c | 3 ++- audio/dsound_template.h | 6 -- audio/noaudio.c | 4 ++-- audio/ossaudio.c

[Qemu-devel] [PATCH v2 09/12] dsoundaudio: do not use global variables

2015-06-03 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/dsound_template.h | 18 audio/dsoundaudio.c | 106 2 files changed, 74 insertions(+), 50 deletions(-) diff --git a/audio/dsound_template.h b/audio/dsound_template.h index

[Qemu-devel] [RFC PATCH] qapi for audio backends

2015-06-03 Thread Kővágó, Zoltán
no idea what ADC and DAC stands for. Any comment is appreciated. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- qapi-schema.json | 330 +++ 1 file changed, 330 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index

Re: [Qemu-devel] [PULL 00/12] audio patch queue

2015-06-09 Thread Kővágó Zoltán
2015-06-09 15:03 keltezéssel, Peter Maydell írta: ...and a further long list of errors which I assume are mostly run-on from not finding the header file. This looks like it's because configure is now using dsound by default rather than winwave. Yes, the winwave backend was removed, so dsound

[Qemu-devel] [PATCH 3/5] qapi: change Netdev and NetLegacy into a flat union

2015-06-23 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- hw/arm/musicpal.c| 2 +- hw/core/qdev-properties-system.c | 2 +- hw/net/allwinner_emac.c | 2 +- hw/net/cadence_gem.c | 2 +- hw/net/dp8393x.c | 2 +- hw/net/e1000.c

[Qemu-devel] [PATCH 4/5] qapi: support nested structs in OptsVisitor

2015-06-23 Thread Kővágó, Zoltán
create backward compatibility problems. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- Rationale for this commit: see these threads http://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg04189.html http://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg04186.html Change from v2

[Qemu-devel] [PATCH 0/5] qapi flattening + some miscellaneous patches

2015-06-23 Thread Kővágó, Zoltán
into OptsVisitor, without requiring backward-compatibility hacks. These patches are essentially same as the patches in v3 -audiodev option, except that I updated it to master (and fixed the conflicts due to error handling related changes). Please review. Kővágó, Zoltán (5): qapi: support implicit structs

[Qemu-devel] [PATCH 2/5] qapi: convert NumaOptions into a flat union

2015-06-23 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- numa.c | 2 +- qapi-schema.json | 47 --- 2 files changed, 37 insertions(+), 12 deletions(-) diff --git a/numa.c b/numa.c index 91fc6c1..8b0755d 100644 --- a/numa.c +++ b/numa.c

[Qemu-devel] [PATCH 5/5] opts: produce valid command line in qemu_opts_print

2015-06-23 Thread Kővágó, Zoltán
=, if the option has an id * do not print separator before the first element * do not quote string arguments which only contains letters or numbers * properly escape commas (,) for QEMU, apostrophe (') for shell Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- Chages from v1 -audiodev patch: * print

[Qemu-devel] [PATCH 1/5] qapi: support implicit structs in OptsVisitor

2015-06-23 Thread Kővágó, Zoltán
They are required for flat unions (you still have to allocate the structs). Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- qapi/opts-visitor.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 7ae33b3..aa68814 100644

[Qemu-devel] [PATCH v3 0/8] -audiodev option

2015-06-18 Thread Kővágó, Zoltán
paths accepted * qemu_opts_print: hopefully produces valid command line in all cases * other small fixes... Changes from v1: * updated to master, removed commits already merged * now every time-related option takes usecs * some small fixes Kővágó, Zoltán (8): qapi: support implicit structs

[Qemu-devel] [PATCH v3 2/8] qapi: convert NumaOptions into a flat union

2015-06-18 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- numa.c | 2 +- qapi-schema.json | 47 --- 2 files changed, 37 insertions(+), 12 deletions(-) diff --git a/numa.c b/numa.c index d227ccc..822a22e 100644 --- a/numa.c +++ b/numa.c

[Qemu-devel] [PATCH v3 5/8] qapi: support nested structs in OptsVisitor

2015-06-18 Thread Kővágó, Zoltán
hopefully ensures that this change doesn't create backward compatibility problems. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- Change from v2: * only fully qualified paths are allowed qapi/opts-visitor.c | 114 ++-- tests/qapi-schema/qapi

[Qemu-devel] [PATCH v3 7/8] audio: use qapi AudioFormat instead of audfmt_e

2015-06-18 Thread Kővágó, Zoltán
AUDIO_FORMAT_MAX caused problems. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- Changes from v2: * replaced case AUDIO_FORMAT_MAX with default audio/alsaaudio.c | 53 ++ audio/audio.c | 97 ++- audio

[Qemu-devel] [PATCH v3 3/8] qapi: change Netdev and NetLegacy into a flat union

2015-06-18 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- hw/arm/musicpal.c| 2 +- hw/core/qdev-properties-system.c | 2 +- hw/net/allwinner_emac.c | 2 +- hw/net/cadence_gem.c | 2 +- hw/net/dp8393x.c | 2 +- hw/net/e1000.c

[Qemu-devel] [PATCH v3 6/8] opts: produce valid command line in qemu_opts_print

2015-06-18 Thread Kővágó, Zoltán
=, if the option has an id * do not print separator before the first element * do not quote string arguments which only contains letters or numbers * properly escape commas (,) for QEMU, apostrophe (') for shell Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- Chages from v2: * print id= * proper

[Qemu-devel] [PATCH v3 8/8] audio: -audiodev command line option

2015-06-18 Thread Kővágó, Zoltán
-audiodev based config of the currently specified environment variables. Although now it's possible to specify multiple -audiodev options on command line, multiple audio backends are not supported yet. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- Changes from v2: * fixed alsa threshold

[Qemu-devel] [PATCH v3 1/8] qapi: support implicit structs in OptsVisitor

2015-06-18 Thread Kővágó, Zoltán
They are required for flat unions (you still have to allocate the structs). Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- qapi/opts-visitor.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index f2ad6d7..f02059d 100644

[Qemu-devel] [PATCH v3 4/8] qapi: qapi for audio backends

2015-06-18 Thread Kővágó, Zoltán
will simply ignore them). Also using usecs, as it's probably more user friendly than samples or bytes. * try-poll is now an alsa and oss backend specific option (as all other backends currently ignore it) Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- Changes from v2 patch

Re: [Qemu-devel] [PATCH v3 5/8] qapi: support nested structs in OptsVisitor

2015-06-18 Thread Kővágó Zoltán
2015-06-18 19:15 keltezéssel, Laszlo Ersek írta: On 06/18/15 18:43, Kővágó, Zoltán wrote: The current OptsVisitor flattens the whole structure, if there are same named fields under different paths (like `in' and `out' in `Audiodev'), the current visitor can't cope with them (for example setting

Re: [Qemu-devel] [PATCH v3 3/8] qapi: change Netdev and NetLegacy into a flat union

2015-06-19 Thread Kővágó Zoltán
2015-06-19 16:06 keltezéssel, Stefan Hajnoczi írta: On Thu, Jun 18, 2015 at 06:43:45PM +0200, Kővágó, Zoltán wrote: @@ -713,8 +710,6 @@ int net_init_tap(const NetClientOptions *opts, const char *name, const char *vhostfdname; char ifname[128]; -assert(opts-kind

[Qemu-devel] [PATCH v2 4/6] qapi: AllocVisitor

2015-06-16 Thread Kővágó, Zoltán
Simple visitor that recursively allocates structures with only optional variables. Unions are initialized to the first type specified. Other non optional types are not supported. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- include/qapi/alloc-visitor.h | 18 + qapi

[Qemu-devel] [PATCH v2 6/6] audio: -audiodev command line option

2015-06-16 Thread Kővágó, Zoltán
it's possible to specify multiple -audiodev options on command line, multiple audio backends are not supported yet. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- Changes from v1: * updated to everything usecs without suffix * better rounding when converting between usecs and frames

[Qemu-devel] [PATCH v2 3/6] opts: do not print separator before first item in qemu_opts_print

2015-06-16 Thread Kővágó, Zoltán
This allows to print options in a format that the user would actually write it on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious comma at the beginning of the list. Only block.c depended on the old behavior, but it was also updated. Signed-off-by: Kővágó, Zoltán

[Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends

2015-06-16 Thread Kővágó, Zoltán
will simply ignore them). Also using usecs, as it's probably more user friendly than samples or bytes. * try-poll is now an alsa and oss backend specific option (as all other backends currently ignore it) Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- Changes from v1 patch: * every time

[Qemu-devel] [PATCH v2 0/6] -audiodev option

2015-06-16 Thread Kővágó, Zoltán
did not break anything accidentally. For easier testing, pull https://github.com/DirtYiCE/qemu.git tag audio-cmdline-v2. Please review. --- Changes from v1: * updated to master, removed commits already merged * now every time-related option takes usecs * some small fixes Kővágó, Zoltán (6): qapi

[Qemu-devel] [PATCH v2 5/6] audio: use qapi AudioFormat instead of audfmt_e

2015-06-16 Thread Kővágó, Zoltán
AUDIO_FORMAT_MAX caused problems. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/alsaaudio.c | 53 ++ audio/audio.c | 97 ++- audio/audio.h | 11 +- audio/audio_win_int.c | 18

[Qemu-devel] [PATCH v2 2/6] qapi: support nested structs in OptsVisitor

2015-06-16 Thread Kővágó, Zoltán
become 44100, because only `frequency' matches it). Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- qapi/opts-visitor.c | 144 +--- tests/qapi-schema/qapi-schema-test.json | 9 +- tests/test-opts-visitor.c | 34 3

[Qemu-devel] [PATCH 07/12] qapi: qapi for audio backends

2015-06-12 Thread Kővágó, Zoltán
will simply ignore them). Also using usecs, as it's probably more user friendly than samples or bytes. * try-poll is now an alsa and oss backend specific option (as all other backends currently ignore it) Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- Changes from v2 RFC patch: * in, out

[Qemu-devel] [PATCH 10/12] qapi: AllocVisitor

2015-06-12 Thread Kővágó, Zoltán
Simple visitor that recursively allocates structures with only optional variables. Unions are initialized to the first type specified. Other non optional types are not supported. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- include/qapi/alloc-visitor.h | 18 + qapi

[Qemu-devel] [PATCH 11/12] audio: use qapi AudioFormat instead of audfmt_e

2015-06-12 Thread Kővágó, Zoltán
AUDIO_FORMAT_MAX caused problems. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/alsaaudio.c | 53 ++ audio/audio.c | 97 ++- audio/audio.h | 11 +- audio/audio_win_int.c | 18

[Qemu-devel] [PATCH 12/12] audio: -audiodev command line option

2015-06-12 Thread Kővágó, Zoltán
it's possible to specify multiple -audiodev options on command line, multiple audio backends are not supported yet. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/Makefile.objs | 2 +- audio/alsaaudio.c | 284 ++ audio/audio.c | 745

[Qemu-devel] [PATCH 06/12] ossaudio: use trace events instead of debug config flag

2015-06-12 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/ossaudio.c | 25 - trace-events | 4 2 files changed, 8 insertions(+), 21 deletions(-) diff --git a/audio/ossaudio.c b/audio/ossaudio.c index d247969..d5362ab 100644 --- a/audio/ossaudio.c +++ b

[Qemu-devel] [PATCH 05/12] alsaaudio: use trace events instead of verbose

2015-06-12 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/alsaaudio.c | 60 +-- trace-events | 12 +++ 2 files changed, 26 insertions(+), 46 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index d7e181b

[Qemu-devel] [PATCH 02/12] audio: remove plive

2015-06-12 Thread Kővágó, Zoltán
It was useless even 3 years ago, so it can probably safely go away: https://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg02427.html Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/audio.c | 12 audio/audio_template.h | 41

[Qemu-devel] [PATCH 00/12] -audiodev option

2015-06-12 Thread Kővágó, Zoltán
tag audio-cmdline-v1. Please review. Kővágó, Zoltán (12): audio: remove LOG_TO_MONITOR along with default_mon audio: remove plive dsoundaudio: remove *_retries kludges dsoundaudio: remove primary buffer alsaaudio: use trace events instead of verbose ossaudio: use trace events instead

[Qemu-devel] [PATCH 01/12] audio: remove LOG_TO_MONITOR along with default_mon

2015-06-12 Thread Kővágó, Zoltán
problems). Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/audio.c | 23 +++ include/monitor/monitor.h | 1 - monitor.c | 4 3 files changed, 3 insertions(+), 25 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index

[Qemu-devel] [PATCH 03/12] dsoundaudio: remove *_retries kludges

2015-06-12 Thread Kővágó, Zoltán
. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/dsound_template.h | 35 + audio/dsoundaudio.c | 68 ++--- 2 files changed, 20 insertions(+), 83 deletions(-) diff --git a/audio/dsound_template.h b/audio

[Qemu-devel] [PATCH 04/12] dsoundaudio: remove primary buffer

2015-06-12 Thread Kővágó, Zoltán
should have the same effect as setting (the now removed) primary buffer. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/dsoundaudio.c | 104 1 file changed, 104 deletions(-) diff --git a/audio/dsoundaudio.c b/audio/dsoundaudio.c

[Qemu-devel] [PATCH 08/12] qapi: support nested structs in OptsVisitor

2015-06-12 Thread Kővágó, Zoltán
become 44100, because only `frequency' matches it). Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- qapi/opts-visitor.c | 144 +--- tests/qapi-schema/qapi-schema-test.json | 9 +- tests/test-opts-visitor.c | 34 3

[Qemu-devel] [PATCH 09/12] opts: do not print separator before first item in qemu_opts_print

2015-06-12 Thread Kővágó, Zoltán
This allows to print options in a format that the user would actually write it on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious comma at the beginning of the list. Only block.c depended on the old behavior, but it was also updated. Signed-off-by: Kővágó, Zoltán

Re: [Qemu-devel] [PATCH 07/12] qapi: qapi for audio backends

2015-06-12 Thread Kővágó Zoltán
2015-06-13 00:11 keltezéssel, Eric Blake írta: +## +# @AudiodevAlsaOptions +# +# Options of the alsa audio backend. +# +# @in: #optional options of the capture stream +# +# @out: #optional options of the playback stream Marked optional here... +# +# @threshold: #optional set the threshold

Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends

2015-06-17 Thread Kővágó Zoltán
2015-06-17 18:06 keltezéssel, Markus Armbruster írta: Kővágó Zoltán dirty.ice...@gmail.com writes: 2015-06-17 15:37 keltezéssel, Markus Armbruster írta: Kővágó Zoltán dirty.ice...@gmail.com writes: 2015-06-17 13:48 keltezéssel, Markus Armbruster írta: Kővágó Zoltán dirty.ice...@gmail.com

Re: [Qemu-devel] [PATCH v2 4/6] qapi: AllocVisitor

2015-06-17 Thread Kővágó Zoltán
2015-06-17 09:56 keltezéssel, Markus Armbruster írta: Kővágó, Zoltán dirty.ice...@gmail.com writes: Simple visitor that recursively allocates structures with only optional variables. Unions are initialized to the first type specified. Other non optional types are not supported. Sounds

Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends

2015-06-17 Thread Kővágó Zoltán
2015-06-17 13:48 keltezéssel, Markus Armbruster írta: Kővágó Zoltán dirty.ice...@gmail.com writes: 2015-06-17 09:46 keltezéssel, Markus Armbruster írta: Copying Eric for additional QAPI schema expertise. My questions inline, pretty sure they show my ignorance. Kővágó, Zoltán dirty.ice

Re: [Qemu-devel] [PATCH v2 2/6] qapi: support nested structs in OptsVisitor

2015-06-17 Thread Kővágó Zoltán
2015-06-17 13:18 keltezéssel, Markus Armbruster írta: Copying Kevin because similar issues exist in the block layer. Gerd Hoffmann kra...@redhat.com writes: On Mi, 2015-06-17 at 09:50 +0200, Markus Armbruster wrote: Copying László because his fingerprints are on OptsVisitor. Kővágó, Zoltán

Re: [Qemu-devel] [PATCH v2 6/6] audio: -audiodev command line option

2015-06-17 Thread Kővágó Zoltán
2015-06-17 10:13 keltezéssel, Markus Armbruster írta: Kővágó, Zoltán dirty.ice...@gmail.com writes: This patch adds an -audiodev command line option, and deprecates the QEMU_* environment variables for audio backend configuration. It's syntax is similar to existing options (-netdev, -device

Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends

2015-06-17 Thread Kővágó Zoltán
2015-06-17 09:46 keltezéssel, Markus Armbruster írta: Copying Eric for additional QAPI schema expertise. My questions inline, pretty sure they show my ignorance. Kővágó, Zoltán dirty.ice...@gmail.com writes: This patch adds structures into qapi to replace the existing configuration

Re: [Qemu-devel] [PATCH v2 2/6] qapi: support nested structs in OptsVisitor

2015-06-17 Thread Kővágó Zoltán
2015-06-17 10:41 keltezéssel, Gerd Hoffmann írta: On Mi, 2015-06-17 at 09:50 +0200, Markus Armbruster wrote: Copying László because his fingerprints are on OptsVisitor. Kővágó, Zoltán dirty.ice...@gmail.com writes: The current OptsVisitor flattens the whole structure, if there are same named

Re: [Qemu-devel] [PATCH v2 5/6] audio: use qapi AudioFormat instead of audfmt_e

2015-06-17 Thread Kővágó Zoltán
2015-06-17 10:01 keltezéssel, Markus Armbruster írta: Kővágó, Zoltán dirty.ice...@gmail.com writes: I had to include an enum for audio sampling formats into qapi, but that meant duplicating the audfmt_e enum. This patch replaces audfmt_e and associated values with the qapi generated

Re: [Qemu-devel] [PATCH v2 6/6] audio: -audiodev command line option

2015-06-17 Thread Kővágó Zoltán
2015-06-17 14:27 keltezéssel, Markus Armbruster írta: Kővágó Zoltán dirty.ice...@gmail.com writes: 2015-06-17 10:13 keltezéssel, Markus Armbruster írta: Kővágó, Zoltán dirty.ice...@gmail.com writes: This patch adds an -audiodev command line option, and deprecates the QEMU_* environment

Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends

2015-06-17 Thread Kővágó Zoltán
2015-06-17 15:37 keltezéssel, Markus Armbruster írta: Kővágó Zoltán dirty.ice...@gmail.com writes: 2015-06-17 13:48 keltezéssel, Markus Armbruster írta: Kővágó Zoltán dirty.ice...@gmail.com writes: 2015-06-17 09:46 keltezéssel, Markus Armbruster írta: Copying Eric for additional QAPI

Re: [Qemu-devel] [PATCH v2 2/6] qapi: support nested structs in OptsVisitor

2015-06-17 Thread Kővágó Zoltán
2015-06-17 15:41 keltezéssel, Markus Armbruster írta: Kővágó Zoltán dirty.ice...@gmail.com writes: 2015-06-17 13:18 keltezéssel, Markus Armbruster írta: Copying Kevin because similar issues exist in the block layer. Gerd Hoffmann kra...@redhat.com writes: On Mi, 2015-06-17 at 09:50 +0200

Re: [Qemu-devel] [RFC PATCH] qapi for audio backends

2015-06-04 Thread Kővágó Zoltán
2015-06-04 09:43 keltezéssel, Gerd Hoffmann írta: +# +# @mmap: #optional try using memory mapped access IIRC this doesn't work everywhere, especially when the oss api is implemented as library. Linux had that, but on linux everybody uses alsa these days ... Dunno about other platforms. idk,

[Qemu-devel] [RFC PATCH v2] qapi for audio backends

2015-06-04 Thread Kővágó, Zoltán
. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- qapi-schema.json | 3 + qapi/audio.json | 225 +++ 2 files changed, 228 insertions(+) create mode 100644 qapi/audio.json diff --git a/qapi-schema.json b/qapi-schema.json index 0662a9b

[Qemu-devel] [PATCH 05/12] audio: expose drv_opaque to init_out and init_in

2015-06-01 Thread Kővágó, Zoltán
init_out and init_in. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/alsaaudio.c | 9 +++-- audio/audio_int.h | 4 ++-- audio/audio_template.h | 2 +- audio/coreaudio.c | 5 - audio/dsound_template.h | 6 -- audio/noaudio.c | 6 -- audio

[Qemu-devel] [PATCH 01/12] audio: remove esd backend

2015-06-01 Thread Kővágó, Zoltán
ESD is no longer developed and replaced by PulseAudio. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/Makefile.objs | 1 - audio/audio_int.h | 1 - audio/esdaudio.c| 557 configure | 18 +- 4 files changed

[Qemu-devel] [PATCH 03/12] audio: remove sdl backend

2015-06-01 Thread Kővágó, Zoltán
It's broken and we have native drivers for almost all platforms. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/Makefile.objs | 3 - audio/audio_int.h | 1 - audio/sdlaudio.c| 458 configure | 24 ++- 4

[Qemu-devel] [PATCH 09/12] wavaudio: do not use global variables

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/wavaudio.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/audio/wavaudio.c b/audio/wavaudio.c index 5132aed..8acea8f 100644 --- a/audio/wavaudio.c +++ b/audio/wavaudio.c

[Qemu-devel] [PATCH 02/12] audio: remove fmod backend

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/Makefile.objs | 2 - audio/audio_int.h | 1 - audio/fmodaudio.c | 685 configure | 27 +-- 4 files changed, 2 insertions(+), 713 deletions(-) delete mode 100644

Re: [Qemu-devel] [PATCH 00/12] Audio backend cleanup

2015-06-01 Thread Kővágó Zoltán
2015-06-01 15:38 keltezéssel, Michael Tokarev írta: 01.06.2015 16:23, Kővágó, Zoltán wrote: This series of patch removes the following audio backends: esd, fmod, sdl, winwave. Why do you remove sdl backend? This is my preferred backend so far, it works better than all other backends

[Qemu-devel] [PATCH 00/12] Audio backend cleanup

2015-06-01 Thread Kővágó, Zoltán
the coreaudio backend, as I do not have a Mac to test it. Patches are also available at https://github.com/DirtYiCE/qemu.git in branch audio-cleanup to simplify testing. Please review. Kővágó, Zoltán (12): audio: remove esd backend audio: remove fmod backend audio: remove sdl backend audio

[Qemu-devel] [PATCH 12/12] coreaudio: do not use global variables where possible

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/coreaudio.c | 45 - 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index f38fd82..6dfd63e 100644 --- a/audio/coreaudio.c +++ b/audio

[Qemu-devel] [PATCH 10/12] dsoundaudio: do not use global variables

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/dsound_template.h | 18 audio/dsoundaudio.c | 106 2 files changed, 74 insertions(+), 50 deletions(-) diff --git a/audio/dsound_template.h b/audio/dsound_template.h index

[Qemu-devel] [PATCH 08/12] ossaudio: do not use global variables

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/ossaudio.c | 114 +-- 1 file changed, 61 insertions(+), 53 deletions(-) diff --git a/audio/ossaudio.c b/audio/ossaudio.c index 80ac610..d247969 100644 --- a/audio/ossaudio.c +++ b

[Qemu-devel] [PATCH 04/12] audio: remove winwave audio driver

2015-06-01 Thread Kővágó, Zoltán
DirectSound should be a superior choice on Windows. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/Makefile.objs | 1 - audio/audio_int.h| 1 - audio/winwaveaudio.c | 717 --- configure| 11 +- 4 files changed

[Qemu-devel] [PATCH 11/12] paaudio: fix possible resource leak

2015-06-01 Thread Kővágó, Zoltán
qpa_audio_init did not clean up resources properly if the initialization failed. This hopefully fixes it. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/paaudio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index

[Qemu-devel] [PATCH 06/12] alsaaudio: do not use global variables

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/alsaaudio.c | 154 +- 1 file changed, 82 insertions(+), 72 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index eb33bff..d7e181b 100644 --- a/audio/alsaaudio.c

[Qemu-devel] [PATCH 07/12] paaudio: do not use global variables

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- audio/paaudio.c | 102 +--- 1 file changed, 52 insertions(+), 50 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 11c2d29..35e8887 100644 --- a/audio/paaudio.c +++ b

  1   2   3   4   5   6   7   >