On Tue, Jun 22, 2021 at 2:38 PM Peter Xu wrote:
[...]
> Yes, looks right to me:
>
> Reviewed-by: Peter Xu
>
> --
> Peter Xu
Thanks Peter!
On Tue, Jun 29, 2021 at 3:14 PM Peter Xu wrote:
>
> The 1st patch should fix yank with unregister instance; I think it should also
> fix the issue that Leonardo used to fix in this patch:
>
> https://lore.kernel.org/qemu-devel/20210629050522.147057-1-leob...@redhat.com/
>
> The 2nd patch fixes
Hello Lukas,
On Wed, Aug 4, 2021 at 4:27 PM Lukas Straub wrote:
>
> When introducing yank functionality in the migration code I forgot
> to cover the multifd send side.
>
> Signed-off-by: Lukas Straub
> ---
>
> @Leonardo Could you check if this fixes your issue?
In the same scenario I was
On Mon, Aug 16, 2021 at 2:44 AM Leonardo Bras Soares Passos
wrote:
>
> Hello Lukas,
>
> On Wed, Aug 4, 2021 at 4:27 PM Lukas Straub wrote:
> >
> > When introducing yank functionality in the migration code I forgot
> > to cover the multifd send side.
>
Hello Peter,
On Tue, Aug 31, 2021 at 6:24 PM Peter Xu wrote:
>
> On Tue, Aug 31, 2021 at 08:02:36AM -0300, Leonardo Bras wrote:
> > Results:
> > So far, the resource usage of __sys_sendmsg() reduced 15 times, and the
> > overall migration took 13-18% less time, based in synthetic workload.
>
>
Hello Daniel, thank you for the feedback!
Comments inline.
On Tue, Aug 31, 2021 at 9:57 AM Daniel P. Berrangé wrote:
>
> On Tue, Aug 31, 2021 at 08:02:38AM -0300, Leonardo Bras wrote:
> > MSG_ZEROCOPY is a feature that enables copy avoidance in TCP/UDP socket
> > send calls. It does so by
A few more comments on this one:
On Wed, Sep 1, 2021 at 12:44 PM Daniel P. Berrangé wrote:
>
> > From the safe side we may want to only enable one of them until we prove
> > they'll work together I guess..
>
> MPTCP is good when we're network limited for migration
>
> KTLS will be good when
On Thu, Sep 2, 2021 at 5:47 AM Daniel P. Berrangé wrote:
>
> On Thu, Sep 02, 2021 at 03:38:11AM -0300, Leonardo Bras Soares Passos wrote:
> > Hello Daniel, thank you for the feedback!
> >
> > Comments inline.
> >
> > On Tue, Aug 31, 2021 at 9:
Hello Peter, thank you for this feedback!
On Tue, Aug 31, 2021 at 5:29 PM Peter Xu wrote:
> Yes it would be great to be a migration capability in parallel to multifd. At
> initial phase if it's easy to be implemented on multi-fd only, we can add a
> dependency between the caps. In the future we
Thanks for this feedback Peter!
I ended up reading/replying the e-mails in thread order, so I may have
been redundant
with your argument, sorry about that.
I will add my comments inline, but I will add references to the
previous mail I sent
Daniel, so please read it too.
On Tue, Aug 31, 2021 at
Hello Daniel, thanks for the feedback !
On Tue, Aug 31, 2021 at 10:17 AM Daniel P. Berrangé wrote:
>
> On Tue, Aug 31, 2021 at 08:02:39AM -0300, Leonardo Bras wrote:
> > Call qio_channel_set_zerocopy(true) in the start of every multifd thread.
> >
> > Change the send_write() interface of
Thanks for the feedback Eric!
On Wed, Sep 1, 2021 at 5:54 PM Eric Blake wrote:
>
> On Tue, Aug 31, 2021 at 08:02:37AM -0300, Leonardo Bras wrote:
> > Some syscalls used for writting, such as sendmsg(), accept flags that
> > can modify their behavior, even allowing the usage of features such as
>
On Thu, Sep 2, 2021 at 5:21 AM Daniel P. Berrangé wrote:
>
> On Thu, Sep 02, 2021 at 04:22:55AM -0300, Leonardo Bras Soares Passos wrote:
> > Hello Daniel, thanks for the feedback !
> >
> > On Tue, Aug 31, 2021 at 10:17 AM Daniel P. Berrangé
> > wrote:
> > &
Hello Daniel,.
A few more comments:
On Wed, Sep 1, 2021 at 5:51 AM Daniel P. Berrangé wrote:
>
> On Tue, Aug 31, 2021 at 04:27:04PM -0400, Peter Xu wrote:
> > On Tue, Aug 31, 2021 at 01:57:33PM +0100, Daniel P. Berrangé wrote:
> > > On Tue, Aug 31, 2021 at 08:02:38AM -0300, Leonardo Bras wrote:
Thanks for contributing Jason!
On Thu, Sep 2, 2021 at 4:23 AM Jason Wang wrote:
>
>
> 在 2021/9/1 下午11:35, Peter Xu 写道:
> > On Wed, Sep 01, 2021 at 09:53:07AM +0100, Daniel P. Berrangé wrote:
> >> On Tue, Aug 31, 2021 at 04:29:09PM -0400, Peter Xu wrote:
> >>> On Tue, Aug 31, 2021 at 02:16:42PM
On Thu, Sep 2, 2021 at 6:20 AM Daniel P. Berrangé wrote:
>
> On Thu, Sep 02, 2021 at 05:52:15AM -0300, Leonardo Bras Soares Passos wrote:
> > On Thu, Sep 2, 2021 at 5:21 AM Daniel P. Berrangé
> > wrote:
> > >
> > > On Thu, Sep 02, 2021 at 04:22:55A
On Thu, Sep 2, 2021 at 6:59 AM Daniel P. Berrangé wrote:
>
> On Thu, Sep 02, 2021 at 06:49:06AM -0300, Leonardo Bras Soares Passos wrote:
> > On Thu, Sep 2, 2021 at 6:20 AM Daniel P. Berrangé
> > wrote:
> > >
> > > On Thu, Sep 02, 2021 at 05:52:15A
On Thu, Sep 2, 2021 at 6:50 AM Daniel P. Berrangé wrote:
>
> On Thu, Sep 02, 2021 at 06:34:01AM -0300, Leonardo Bras Soares Passos wrote:
> > On Thu, Sep 2, 2021 at 5:47 AM Daniel P. Berrangé
> > wrote:
> > >
> > > On Thu, Sep 02, 2021 at 03:38:11A
On Tue, Sep 7, 2021 at 8:06 AM Dr. David Alan Gilbert
wrote:
> > Possibly, yes. This really need David G's input since he understands
> > the code in way more detail than me.
>
> Hmm I'm not entirely sure why we have the sync after each iteration;
> the case I can think of is if we're doing async
On Tue, Sep 7, 2021 at 1:44 PM Peter Xu wrote:
>
> On Thu, Sep 02, 2021 at 03:59:25AM -0300, Leonardo Bras Soares Passos wrote:
> > I also suggested something like that, but I thought it could be good if we
> > could
> > fall back to io_writev() if we didn't h
On Wed, Sep 8, 2021 at 11:05 PM Peter Xu wrote:
>
> On Wed, Sep 08, 2021 at 10:57:06PM +0100, Daniel P. Berrangé wrote:
> > We think we're probably ok with migration as we are going to rely on the
> > face that we eventually pause the guest to stop page changes during the
> > final switchover.
Hello Lukas,
On Tue, Aug 3, 2021 at 3:42 AM Lukas Straub wrote:
> Hi,
> There is an easier explanation: I forgot the send side of multifd
> altogether (I thought it was covered by migration_channel_connect()).
> So yank won't actually shutdown() the multifd sockets on the send side.
If I could
Hello Dave,
> > diff --git a/migration/multifd.c b/migration/multifd.c
> > index 377da78f5b..744a180dfe 100644
> > --- a/migration/multifd.c
> > +++ b/migration/multifd.c
> > @@ -1040,6 +1040,17 @@ void multifd_recv_sync_main(void)
> >
On Mon, Oct 11, 2021 at 5:45 PM Eric Blake wrote:
>
> On Mon, Oct 11, 2021 at 04:38:23PM -0300, Leonardo Bras Soares Passos wrote:
> > > > /**
> > > > - * qio_channel_writev_full:
> > > > + * qio_channel_writev_full_flags:
> > > >
Hello Eric, thank you for the feedback!
On Mon, Oct 11, 2021 at 4:17 PM Eric Blake wrote:
>
> On Sat, Oct 09, 2021 at 04:56:11AM -0300, Leonardo Bras wrote:
> > Adds io_async_writev and io_async_flush as optional callback to
> > QIOChannelClass,
>
> Are these names accurate?
I am sorry, I
Hello Eric,
On Mon, Oct 11, 2021 at 4:28 PM Eric Blake wrote:
>
> On Sat, Oct 09, 2021 at 04:56:12AM -0300, Leonardo Bras wrote:
> > For CONFIG_LINUX, implement the new optional callbacks io_write_zerocopy and
> > io_flush_zerocopy on QIOChannelSocket, but enables it only when MSG_ZEROCOPY
> >
Hello Eric,
On Mon, Oct 11, 2021 at 4:32 PM Eric Blake wrote:
>
> On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote:
> > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel
> > zerocopy interface.
> >
> > Change multifd_send_sync_main() so it can distinguish the
On Tue, Sep 28, 2021 at 7:45 PM Peter Xu wrote:
>
> On Wed, Sep 22, 2021 at 07:24:22PM -0300, Leonardo Bras wrote:
> > +static void qio_channel_socket_async_flush(QIOChannel *ioc,
> > + Error **errp)
> > +{
> > +QIOChannelSocket *sioc =
On Tue, Sep 28, 2021 at 7:49 PM Peter Xu wrote:
>
> On Fri, Sep 24, 2021 at 06:43:49PM +0100, Daniel P. Berrangé wrote:
> > > @@ -546,6 +546,7 @@ void multifd_save_cleanup(void)
> > > MultiFDSendParams *p = _send_state->params[i];
> > > Error *local_err = NULL;
> > >
> > > +
On Wed, Sep 29, 2021 at 4:23 PM Peter Xu wrote:
>
> On Wed, Sep 29, 2021 at 03:34:01PM -0300, Leonardo Bras Soares Passos wrote:
> > You mean like I did in pre-V1, enabling ZEROCOPY for multifd it in QMP?
> > Or is this something else?
>
> I mean any way to still be able t
Hello Peter,
On Tue, Sep 28, 2021 at 7:51 PM Peter Xu wrote:
>
> On Wed, Sep 22, 2021 at 07:24:20PM -0300, Leonardo Bras wrote:
> > This patch series intends to enable MSG_ZEROCOPY in QIOChannel, and make
> > use of it for multifd migration performance improvement.
> >
> > Patch #1 creates new
Hello Daniel, thank you for reviewing!
On Fri, Sep 24, 2021 at 2:16 PM Daniel P. Berrangé wrote:
>
> On Wed, Sep 22, 2021 at 07:24:21PM -0300, Leonardo Bras wrote:
> > Adds io_async_writev and io_async_flush as optional callback to
> > QIOChannelClass,
> > allowing the implementation of
On Fri, Sep 24, 2021 at 2:44 PM Daniel P. Berrangé wrote:
>
> On Wed, Sep 22, 2021 at 07:24:23PM -0300, Leonardo Bras wrote:
> > Change multifd nocomp version to use asynchronous write for RAM pages, and
> > benefit of MSG_ZEROCOPY when it's available.
> >
> > The asynchronous flush happens on
Hello Peter, thanks for reviewing!
On Tue, Sep 28, 2021 at 6:52 PM Peter Xu wrote:
>
> On Fri, Sep 24, 2021 at 06:16:04PM +0100, Daniel P. Berrangé wrote:
> > > +ssize_t qio_channel_async_writev(QIOChannel *ioc,
> > > + const struct iovec *iov,
> > > +
Hello Daniel,
On Fri, Sep 24, 2021 at 2:38 PM Daniel P. Berrangé wrote:
[...]
> > @@ -154,6 +171,19 @@ int qio_channel_socket_connect_sync(QIOChannelSocket
> > *ioc,
> > return -1;
> > }
> >
> > +#ifdef CONFIG_LINUX
> > +if (addr->type != SOCKET_ADDRESS_TYPE_INET) {
> > +
I sent an v3 to this series, due to some errors on testing
MSG_ZEROCOPY on a user with a low memory locking resource.
- If there is not enough memory locking resource, fall back to sync
(non-zerocopy) approach.
Best regards,
Leo
Hello Daniel,
Thanks for the feedback!
On Fri, Nov 12, 2021 at 7:13 AM Daniel P. Berrangé wrote:
>
> On Fri, Nov 12, 2021 at 02:10:36AM -0300, Leonardo Bras wrote:
> > -int qio_channel_writev_all(QIOChannel *ioc,
> > - const struct iovec *iov,
> > -
Hello Daniel,
On Fri, Nov 12, 2021 at 7:54 AM Daniel P. Berrangé wrote:
[...]
> > @@ -561,12 +577,15 @@ static ssize_t
> > qio_channel_socket_writev_flags(QIOChannel *ioc,
> > retry:
> > ret = sendmsg(sioc->fd, , flags);
> > if (ret <= 0) {
> > -if (errno == EAGAIN) {
> > +
Hello Daniel,
Thanks for reviewing!
Best regards,
Leo
On Fri, Nov 12, 2021 at 7:15 AM Daniel P. Berrangé wrote:
>
> On Fri, Nov 12, 2021 at 02:10:37AM -0300, Leonardo Bras wrote:
> > Change qio_channel_socket_writev() in order to accept flags, so its possible
> > to selectively make use of
On Thu, Oct 28, 2021 at 1:30 AM Markus Armbruster wrote:
>
> Leonardo Bras Soares Passos writes:
>
> [...]
>
> >> The general argument for having QAPI schema 'if' mirror the C
> >> implementation's #if is introspection. Let me explain why that matters
Hello Markus!
(comments at the bottom)
On Tue, Oct 12, 2021 at 2:54 AM Markus Armbruster wrote:
>
> Leonardo Bras Soares Passos writes:
>
> > Hello Eric,
> >
> > On Mon, Oct 11, 2021 at 4:32 PM Eric Blake wrote:
> >>
> >> On Sat, Oct 09,
Hello Peter, sorry for the delay.
On Wed, Oct 13, 2021 at 3:33 AM Peter Xu wrote:
>
> On Wed, Oct 13, 2021 at 02:07:13PM +0800, Peter Xu wrote:
> > On Sat, Oct 09, 2021 at 04:56:11AM -0300, Leonardo Bras wrote:
> > > -int qio_channel_writev_full_all(QIOChannel *ioc,
> > > -
On Wed, Oct 13, 2021 at 3:26 AM Peter Xu wrote:
>
> On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote:
> > @@ -105,7 +105,13 @@ static int nocomp_send_prepare(MultiFDSendParams *p,
> > uint32_t used,
> > */
> > static int nocomp_send_write(MultiFDSendParams *p, uint32_t used,
On Wed, Oct 13, 2021 at 3:18 AM Peter Xu wrote:
>
> On Sat, Oct 09, 2021 at 04:56:12AM -0300, Leonardo Bras wrote:
> > @@ -154,6 +161,17 @@ int qio_channel_socket_connect_sync(QIOChannelSocket
> > *ioc,
> > return -1;
> > }
> >
> > +#ifdef CONFIG_LINUX
> > +ret =
On Wed, Oct 13, 2021 at 3:24 AM Peter Xu wrote:
>
> On Sat, Oct 09, 2021 at 04:56:13AM -0300, Leonardo Bras wrote:
> > diff --git a/qapi/migration.json b/qapi/migration.json
> > index 88f07baedd..c4890cbb54 100644
> > --- a/qapi/migration.json
> > +++ b/qapi/migration.json
> > @@ -724,6 +724,11
On Wed, Oct 27, 2021 at 3:15 AM Peter Xu wrote:
>
> On Wed, Oct 27, 2021 at 03:07:13AM -0300, Leonardo Bras Soares Passos wrote:
> > > >
> > > >if (flags & ZEROCOPY) {
> > > >assert(fds == NULL && nfds ==
On Tue, Nov 2, 2021 at 10:13 AM Juan Quintela wrote:
>
> Leonardo Bras wrote:
> > For CONFIG_LINUX, implement the new optional callbacks io_write_zerocopy and
> > io_flush_zerocopy on QIOChannelSocket, but enables it only when MSG_ZEROCOPY
> > feature is available in the host kernel, which is
Hello Juan,
On Tue, Nov 2, 2021 at 9:32 AM Juan Quintela wrote:
>
> Leonardo Bras wrote:
> > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel
> > zerocopy interface.
> >
> > Change multifd_send_sync_main() so it can distinguish the last sync from
> > the setup and
On Wed, Nov 3, 2021 at 8:24 PM Juan Quintela wrote:
>
> Leonardo Bras Soares Passos wrote:
> > Hello Juan,
>
> hi
>
> > Current multifd's sendmsg() will block until all data is sent, is that
> > correct?
> >
> > If that's the case, and supposing the
Hello Markus,
Thanks for sharing this info!
Best regards,
Leo
On Fri, Nov 12, 2021 at 8:59 AM Markus Armbruster wrote:
>
> Daniel P. Berrangé writes:
>
> > On Fri, Nov 12, 2021 at 12:04:33PM +0100, Juan Quintela wrote:
> >> Leonardo Bras wrote:
>
> [...]
>
> >> > diff --git
Hello Juan,
On Fri, Nov 12, 2021 at 8:04 AM Juan Quintela wrote:
> Leonardo Bras wrote:
> > Add property that allows zerocopy migration of memory pages,
> > and also includes a helper function migrate_use_zerocopy() to check
> > if it's enabled.
> >
> > No code is introduced to actually do the
Hello Daniel,
On Fri, Nov 12, 2021 at 8:05 AM Daniel P. Berrangé wrote:
>
> On Fri, Nov 12, 2021 at 02:10:39AM -0300, Leonardo Bras wrote:
> > Add property that allows zerocopy migration of memory pages,
> > and also includes a helper function migrate_use_zerocopy() to check
> > if it's enabled.
Hello Daniel,
On Tue, Nov 23, 2021 at 6:45 AM Daniel P. Berrangé wrote:
>
> On Mon, Nov 22, 2021 at 08:18:09PM -0300, Leonardo Bras Soares Passos wrote:
> > Hello Daniel,
> > Thanks for the feedback!
> >
> > On Fri, Nov 12, 2021 at 7:13 AM Daniel P. Berrangé
>
Hello Daniel,
On Tue, Nov 23, 2021 at 6:56 AM Daniel P. Berrangé wrote:
>
> On Tue, Nov 23, 2021 at 01:46:44AM -0300, Leonardo Bras Soares Passos wrote:
> > Hello Daniel,
> >
> > On Fri, Nov 12, 2021 at 7:54 AM Daniel P. Berrangé
> > wrote:
> > [...]
On Thu, Dec 9, 2021 at 5:51 AM Leonardo Bras Soares Passos
wrote:
>
> Hello Juan,
>
> On Tue, Nov 16, 2021 at 1:08 PM Juan Quintela wrote:
> >
> > Leonardo Bras wrote:
> > > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel
> > &
On Tue, Nov 16, 2021 at 1:40 PM Daniel P. Berrangé wrote:
>
> On Tue, Nov 16, 2021 at 05:34:50PM +0100, Juan Quintela wrote:
> > Daniel P. Berrangé wrote:
> >
> > >>
> > >> if (params->zerocopy &&
> > >> (params->parameters.multifd_compression !=
> > >> MULTIFD_COMPRESSION_NONE ||
>
On Tue, Nov 16, 2021 at 1:35 PM Daniel P. Berrangé wrote:
>
> On Tue, Nov 16, 2021 at 04:17:47PM +, Daniel P. Berrangé wrote:
> > On Tue, Nov 16, 2021 at 05:08:06PM +0100, Juan Quintela wrote:
> > > Leonardo Bras wrote:
> > > > Implement zerocopy on nocomp_send_write(), by making use of
Hello Markus,
On Fri, Nov 12, 2021 at 9:01 AM Markus Armbruster wrote:
>
> Juan Quintela writes:
>
> > Leonardo Bras wrote:
> >> Add property that allows zerocopy migration of memory pages,
> >> and also includes a helper function migrate_use_zerocopy() to check
> >> if it's enabled.
> >>
> >>
On Tue, Nov 16, 2021 at 1:08 PM Juan Quintela wrote:
>
> Leonardo Bras wrote:
> > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel
> > zerocopy interface.
> >
> > Change multifd_send_sync_main() so it can distinguish each iteration sync
> > from
> > the setup and the
Hello Daniel,
On Fri, Dec 3, 2021 at 6:18 AM Daniel P. Berrangé wrote:
>
> On Fri, Dec 03, 2021 at 02:42:19AM -0300, Leonardo Bras Soares Passos wrote:
> > Hello Daniel,
> >
> > On Tue, Nov 23, 2021 at 6:56 AM Daniel P. Berrangé
> > wrote:
> > >
> &g
On Thu, Dec 9, 2021 at 5:38 AM Leonardo Bras Soares Passos
wrote:
>
> Hello Daniel,
>
> On Fri, Dec 3, 2021 at 6:18 AM Daniel P. Berrangé wrote:
> >
> > On Fri, Dec 03, 2021 at 02:42:19AM -0300, Leonardo Bras Soares Passos wrote:
> > > Hello Daniel,
> >
Hello Juan,
On Tue, Nov 16, 2021 at 1:08 PM Juan Quintela wrote:
>
> Leonardo Bras wrote:
> > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel
> > zerocopy interface.
> >
> > Change multifd_send_sync_main() so it can distinguish each iteration sync
> > from
> > the setup
Hello Juan,
Thanks for reviewing!
Best regards,
Leo
On Fri, Nov 12, 2021 at 8:04 AM Juan Quintela wrote:
> Leonardo Bras wrote:
> > A lot of places check parameters.tls_creds in order to evaluate if TLS is
> > in use, and sometimes call migrate_get_current() just for that test.
> >
> > Add
On Tue, Mar 1, 2022 at 12:57 AM Peter Xu wrote:
>
> On Fri, Feb 18, 2022 at 05:57:13PM +0100, Juan Quintela wrote:
> > I did a change on:
> >
> > commit d48c3a044537689866fe44e65d24c7d39a68868a
> > Author: Juan Quintela
> > Date: Fri Nov 19 15:35:58 2021 +0100
> >
> > multifd: Use a single
On Fri, Feb 18, 2022 at 2:36 PM Juan Quintela wrote:
>
> Leonardo Bras Soares Passos wrote:
> > Hello Peter, thanks for reviewing!
> >
> > On Mon, Feb 7, 2022 at 11:22 PM Peter Xu wrote:
> >>
> >> On Tue, Feb 01, 2022 at 03:29:03AM -0300, Leonardo Bras
Hello Juan, thanks for the feedback!
On Fri, Feb 18, 2022 at 1:57 PM Juan Quintela wrote:
>
> Leonardo Bras wrote:
> > Implement zero copy send on nocomp_send_write(), by making use of QIOChannel
> > writev + flags & flush interface.
> >
> > Change multifd_send_sync_main() so flush_zero_copy()
Hello Juan,
Thanks for thew feedback!
On Fri, Feb 18, 2022 at 1:31 PM Juan Quintela wrote:
>
> Leonardo Bras Soares Passos wrote:
> > On Wed, Jan 19, 2022 at 3:16 PM Daniel P. Berrangé
> > wrote:
> >>
> >> On Wed, Jan 19, 2022 at 03:03:29PM -0300, Leo
Thanks for reviewing, Juan!
On Fri, Feb 18, 2022 at 1:36 PM Juan Quintela wrote:
>
> Leonardo Bras wrote:
> > Add flags to io_writev and introduce io_flush as optional callback to
> > QIOChannelClass, allowing the implementation of zero copy writes by
> > subclasses.
> >
> > How to use them:
>
On Mon, Feb 21, 2022 at 4:41 PM Leonardo Bras Soares Passos
wrote:
>
> Hello Juan, thanks for the feedback!
>
> On Fri, Feb 18, 2022 at 1:57 PM Juan Quintela wrote:
> >
> > Leonardo Bras wrote:
> > > Implement zero copy send on nocomp_send_write(), b
Hello David Edmondson and Igor Memmedov,
Thank you for the feedback!
For some reason I did not get your comments in my email.
I could only notice them when I opened Patchwork to get the link.
Sorry for the delay. I will do my best to address them in a few minutes.
Best regards,
Leo
On Sat,
Hello Daniel, thanks for reviewing!
On Tue, Feb 1, 2022 at 6:35 AM Daniel P. Berrangé wrote:
>
> On Tue, Feb 01, 2022 at 03:28:59AM -0300, Leonardo Bras wrote:
> > Add flags to io_writev and introduce io_flush as optional callback to
> > QIOChannelClass, allowing the implementation of zero copy
Hello David, thank you for the feedback.
On Wed, Feb 2, 2022 at 12:47 PM David Edmondson
wrote:
>
> On Tuesday, 2022-02-01 at 16:09:57 -03, Leonardo Brás wrote:
>
> > Hello David, thanks for this feedback!
> >
> > On Mon, 2022-01-31 at 12:53 +, David Edmondson wrote:
> >> On Saturday,
Hello Daniel,
On Mon, Jan 31, 2022 at 6:08 AM Daniel P. Berrangé wrote:
>
> CC'ing Babu Moger who aded the Milan CPU model.
>
> On Sat, Jan 29, 2022 at 07:23:37AM -0300, Leonardo Bras wrote:
> > While trying to bring a VM with EPYC-Milan cpu on a host with
> > EPYC-Milan cpu (EPYC 7313), the
On Mon, Jan 31, 2022 at 3:04 PM Daniel P. Berrangé wrote:
>
> On Mon, Jan 31, 2022 at 02:56:38PM -0300, Leonardo Bras Soares Passos wrote:
> > Hello Daniel,
> >
> > On Mon, Jan 31, 2022 at 6:08 AM Daniel P. Berrangé
> > wrote:
> > >
> > >
Hello Peter,
Re-reading everything before submitting the next version.
I think I finally got that you are suggesting to just add a break at
the end of the case, after the if :)
Sorry I misunderstand that before,
Best regards,
Leo
On Thu, Jan 13, 2022 at 3:48 AM Peter Xu wrote:
>
> On Thu, Jan
Hello Peter,
On Mon, Feb 7, 2022 at 9:50 AM Peter Xu wrote:
>
> On Tue, Feb 01, 2022 at 03:28:59AM -0300, Leonardo Bras wrote:
> > Add flags to io_writev and introduce io_flush as optional callback to
> > QIOChannelClass, allowing the implementation of zero copy writes by
> > subclasses.
> >
> >
Hello Peter, thanks for reviewing!
On Mon, Feb 7, 2022 at 11:22 PM Peter Xu wrote:
>
> On Tue, Feb 01, 2022 at 03:29:03AM -0300, Leonardo Bras wrote:
> > -void multifd_send_sync_main(QEMUFile *f)
> > +int multifd_send_sync_main(QEMUFile *f)
> > {
> > int i;
> > +bool flush_zero_copy;
>
Hello Peter,
On Thu, Jan 13, 2022 at 3:28 AM Peter Xu wrote:
>
> On Thu, Jan 06, 2022 at 07:13:38PM -0300, Leonardo Bras wrote:
> > diff --git a/io/channel.c b/io/channel.c
> > index e8b019dc36..904855e16e 100644
> > --- a/io/channel.c
> > +++ b/io/channel.c
> > @@ -67,12 +67,13 @@ ssize_t
Hello Daniel,
On Thu, Jan 13, 2022 at 7:53 AM Daniel P. Berrangé wrote:
>
> On Thu, Jan 06, 2022 at 07:13:38PM -0300, Leonardo Bras wrote:
> > Add flags to io_writev and introduce io_flush as optional callback to
> > QIOChannelClass, allowing the implementation of zero copy writes by
> >
On Thu, Jan 13, 2022 at 7:34 AM Peter Xu wrote:
>
> On Thu, Jan 13, 2022 at 10:06:14AM +, Daniel P. Berrangé wrote:
> > On Thu, Jan 13, 2022 at 02:48:15PM +0800, Peter Xu wrote:
> > > On Thu, Jan 06, 2022 at 07:13:39PM -0300, Leonardo Bras wrote:
> > > > @@ -558,15 +575,26 @@ static ssize_t
On Thu, Jan 13, 2022 at 9:12 AM Peter Xu wrote:
>
> On Thu, Jan 13, 2022 at 10:42:39AM +, Daniel P. Berrangé wrote:
> > On Thu, Jan 13, 2022 at 06:34:12PM +0800, Peter Xu wrote:
> > > On Thu, Jan 13, 2022 at 10:06:14AM +, Daniel P. Berrangé wrote:
> > > > On Thu, Jan 13, 2022 at
On Thu, Jan 13, 2022 at 10:06 AM Daniel P. Berrangé wrote:
>
> On Thu, Jan 06, 2022 at 07:13:39PM -0300, Leonardo Bras wrote:
> > For CONFIG_LINUX, implement the new zero copy flag and the optional callback
> > io_flush on QIOChannelSocket, but enables it only when MSG_ZEROCOPY
> > feature is
Hello Daniel,
On Thu, Jan 13, 2022 at 10:11 AM Daniel P. Berrangé wrote:
>
> On Thu, Jan 06, 2022 at 07:13:41PM -0300, Leonardo Bras wrote:
> > A lot of places check parameters.tls_creds in order to evaluate if TLS is
> > in use, and sometimes call migrate_get_current() just for that test.
> >
>
Hello Peter,
On Thu, Jan 13, 2022 at 4:02 AM Peter Xu wrote:
>
> On Thu, Jan 06, 2022 at 07:13:41PM -0300, Leonardo Bras wrote:
> > void migration_channel_process_incoming(QIOChannel *ioc)
> > {
> > -MigrationState *s = migrate_get_current();
> > Error *local_err = NULL;
> >
> >
Hello Peter,
On Thu, Jan 13, 2022 at 4:15 AM Peter Xu wrote:
>
> On Thu, Jan 06, 2022 at 07:13:42PM -0300, Leonardo Bras wrote:
> > Implement zero copy on nocomp_send_write(), by making use of QIOChannel
> > writev + flags & flush interface.
> >
> > Change multifd_send_sync_main() so it can
On Wed, Jan 19, 2022 at 3:16 PM Daniel P. Berrangé wrote:
>
> On Wed, Jan 19, 2022 at 03:03:29PM -0300, Leonardo Bras Soares Passos wrote:
> > Hello Daniel,
> >
> > On Thu, Jan 13, 2022 at 10:10 AM Daniel P. Berrangé
> > wrote:
> > >
> > > On Thu,
Hello Daniel,
On Thu, Jan 13, 2022 at 10:10 AM Daniel P. Berrangé wrote:
>
> On Thu, Jan 06, 2022 at 07:13:40PM -0300, Leonardo Bras wrote:
> > Add property that allows zero-copy migration of memory pages,
> > and also includes a helper function migrate_use_zero_copy() to check
> > if it's
Hello Daniel,
On Thu, Jan 13, 2022 at 7:42 AM Daniel P. Berrangé wrote:
>
> On Thu, Jan 13, 2022 at 06:34:12PM +0800, Peter Xu wrote:
> > On Thu, Jan 13, 2022 at 10:06:14AM +, Daniel P. Berrangé wrote:
> > > On Thu, Jan 13, 2022 at 02:48:15PM +0800, Peter Xu wrote:
> > > > On Thu, Jan 06,
On Tue, Jan 18, 2022 at 10:58 PM Peter Xu wrote:
>
> On Tue, Jan 18, 2022 at 05:45:09PM -0300, Leonardo Bras Soares Passos wrote:
> > Hello Peter,
> >
> > On Thu, Jan 13, 2022 at 3:28 AM Peter Xu wrote:
> > >
> > > On Thu, Jan 06, 2022 at 07:13:38PM -030
Hello Peter,
On Thu, Jan 13, 2022 at 3:48 AM Peter Xu wrote:
>
> On Thu, Jan 06, 2022 at 07:13:39PM -0300, Leonardo Bras wrote:
> > @@ -558,15 +575,26 @@ static ssize_t qio_channel_socket_writev(QIOChannel
> > *ioc,
> > memcpy(CMSG_DATA(cmsg), fds, fdsize);
> > }
> >
> > +if
Hello Peter,
On Thu, Jan 13, 2022 at 4:00 AM Peter Xu wrote:
>
> On Thu, Jan 06, 2022 at 07:13:40PM -0300, Leonardo Bras wrote:
> > Add property that allows zero-copy migration of memory pages,
> > and also includes a helper function migrate_use_zero_copy() to check
> > if it's enabled.
> >
> >
On Tue, Apr 26, 2022 at 9:59 AM Peter Xu wrote:
>
> On Mon, Apr 25, 2022 at 06:50:54PM -0300, Leonardo Bras wrote:
> > Even though multifd_send_sync_main() currently emits error_reports, it's
> > callers don't really check it before continuing.
> >
> > Change multifd_send_sync_main() to return -1
Hello Peter, thanks for helping!
On Tue, Apr 26, 2022 at 1:02 PM Peter Xu wrote:
>
> Leo,
>
> This patch looks mostly good to me, a few nitpicks below.
>
> On Mon, Apr 25, 2022 at 06:50:56PM -0300, Leonardo Bras wrote:
[...]
> > }
> > +
> > +/*
> > + * When using zero-copy, it's
Hello Daniel, thank you for the feedback!
On Tue, Apr 26, 2022 at 5:11 AM Daniel P. Berrangé wrote:
>
> On Mon, Apr 25, 2022 at 06:50:55PM -0300, Leonardo Bras wrote:
> > Since d48c3a0445 ("multifd: Use a single writev on the send side"),
> > sending the header packet and the memory pages
On Wed, May 11, 2022 at 5:55 AM Dr. David Alan Gilbert
wrote:
>
> * Leonardo Bras Soares Passos (leob...@redhat.com) wrote:
> > From a previous thread:
> >
> > On Thu, Apr 28, 2022 at 1:20 PM Dr. David Alan Gilbert
> > wrote:
> > >
> > > Leo:
>
Hello Peter,
On Thu, Jul 7, 2022 at 2:54 PM Peter Xu wrote:
>
> On Mon, Jul 04, 2022 at 05:23:14PM -0300, Leonardo Bras wrote:
> > Signed-off-by: Leonardo Bras
> > ---
> > qapi/migration.json | 7 ++-
> > migration/migration.c | 2 ++
> > monitor/hmp-cmds.c| 4
> > 3 files
Hello Peter,
On Thu, Jul 7, 2022 at 2:56 PM Peter Xu wrote:
>
> On Mon, Jul 04, 2022 at 05:23:15PM -0300, Leonardo Bras wrote:
> > Some errors, like the lack of Scatter-Gather support by the network
> > interface(NETIF_F_SG) may cause sendmsg(...,MSG_ZEROCOPY) to fail on using
> > zero-copy,
Hello Peter,
On Thu, Jul 7, 2022 at 2:47 PM Peter Xu wrote:
>
> Hi, Leo,
>
> On Mon, Jul 04, 2022 at 05:23:13PM -0300, Leonardo Bras wrote:
> > If flush is called when no buffer was sent with MSG_ZEROCOPY, it currently
> > returns 1. This return code should be used only when Linux fails to use
>
On Tue, Jun 28, 2022 at 4:53 AM Daniel P. Berrangé wrote:
>
> On Mon, Jun 27, 2022 at 10:09:09PM -0300, Leonardo Bras wrote:
> > Some errors, like the lack of Scatter-Gather support by the network
> > interface(NETIF_F_SG) may cause sendmsg(...,MSG_ZEROCOPY) to fail on using
> > zero-copy, which
On Thu, Jul 7, 2022 at 7:18 PM Peter Xu wrote:
>
> On Thu, Jul 07, 2022 at 06:14:17PM -0300, Leonardo Brás wrote:
> > Having 'if(queued == sent)' will cause us to falsely return '1' in two buggy
> > cases, while 'if queued == 0) will either skip early or go into 'infinite'
> > loop.
>
> I'm not
1 - 100 of 153 matches
Mail list logo
