Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-21 Thread Stefan Hajnoczi
On Mon, May 20, 2013 at 09:23:43AM +0200, Paolo Bonzini wrote: Il 20/05/2013 08:24, Stefan Hajnoczi ha scritto: You only need to fdatasync() before every guest flush, no? No, you need to set the dirty bit before issuing the write on the host. Otherwise the image data may be modified

Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-05-21 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 12:46:09PM +0800, Amos Kong wrote: On Fri, May 17, 2013 at 09:39:31AM +0200, Stefan Hajnoczi wrote: On Thu, May 16, 2013 at 07:07:25PM +0800, Amos Kong wrote: Hi Stefan, @@ -961,6 +961,44 @@ void print_net_client(Monitor *mon, NetClientState *nc

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-21 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 11:25:01AM +0800, Wenchao Xia wrote: 于 2013-5-17 17:14, Stefan Hajnoczi 写道: On Fri, May 17, 2013 at 02:58:57PM +0800, Wenchao Xia wrote: 于 2013-5-16 15:47, Stefan Hajnoczi 写道: On Thu, May 16, 2013 at 02:16:20PM +0800, Wenchao Xia wrote: After checking the code, I

Re: [Qemu-devel] [PATCH] hw/9pfs: use O_NOFOLLOW for mapped readlink operation

2013-05-21 Thread Stefan Hajnoczi
model and find real symlinks in export path, never follow them and return proper error. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p-local.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [PATCH 0/2] coroutine: dataplane support

2013-05-21 Thread Stefan Hajnoczi
On Fri, May 17, 2013 at 04:08:36PM +0100, Peter Maydell wrote: On 17 May 2013 14:51, Stefan Hajnoczi stefa...@redhat.com wrote: There is ongoing work to enable multiple event loop threads. This will allow QEMU itself to take advantage of SMP and reduce Big QEMU Lock (BQL) contention

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-21 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 10:30:22AM +0200, Paolo Bonzini wrote: Il 21/05/2013 09:31, Stefan Hajnoczi ha scritto: On Mon, May 20, 2013 at 09:23:43AM +0200, Paolo Bonzini wrote: Il 20/05/2013 08:24, Stefan Hajnoczi ha scritto: You only need to fdatasync() before every guest flush

[Qemu-devel] [PATCH v2] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-21 Thread Stefan Hajnoczi
we pick a random value from 1 to 255 to expose more bugs. If you need to reproduce a crash use 'show environment' in gdb to extract the MALLOC_PERTURB_ value from a core dump. Both make check and qemu-iotests pass with MALLOC_PERTURB_ enabled. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [PATCH v3 2/8] block: add basic backup support to block driver

2013-05-21 Thread Stefan Hajnoczi
On Mon, May 20, 2013 at 01:30:37PM +0200, Paolo Bonzini wrote: Il 15/05/2013 16:34, Stefan Hajnoczi ha scritto: +wait_for_overlapping_requests(job, start, end); +cow_request_begin(cow_request, job, start, end); + +for (; start end; start++) { +if (hbitmap_get(job

Re: [Qemu-devel] [PATCH v1 07/14] net: hub use lock to protect ports list

2013-05-21 Thread Stefan Hajnoczi
On Tue, May 07, 2013 at 01:46:55PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Hub ports will run on multi-threads, so use lock to protect them. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- net/hub.c | 25 - 1 files

Re: [Qemu-devel] [PATCH v1 08/14] net: introduce lock to protect NetQueue

2013-05-21 Thread Stefan Hajnoczi
On Tue, May 07, 2013 at 01:46:56PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com NetQueue will be accessed by nc and its peers at the same time, need lock to protect it. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- net/queue.c | 11

Re: [Qemu-devel] [PATCH v2] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-21 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 06:56:07AM -0600, Eric Blake wrote: On 05/21/2013 06:43 AM, Stefan Hajnoczi wrote: glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment variable is set. The value of the environment variable determines the bit pattern used to wipe memory. For more

[Qemu-devel] [PATCH v3] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-22 Thread Stefan Hajnoczi
we pick a random value from 1 to 255 to expose more bugs. If you need to reproduce a crash use 'show environment' in gdb to extract the MALLOC_PERTURB_ value from a core dump. Both make check and qemu-iotests pass with MALLOC_PERTURB_ enabled. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [PATCH] kvm: add detail error message when fail to add ioeventfd

2013-05-22 Thread Stefan Hajnoczi
-off-by: Amos Kong ak...@redhat.com --- kvm-all.c |4 1 files changed, 4 insertions(+), 0 deletions(-) It would be nice to make kvm bus scalable so that the hardcoded in-kernel I/O device limit can be lifted. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-22 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 08:01:10PM +, Mark Trumpold wrote: Linux kernel 3.3.1 with Qemu patch to enable kernel flushing: http://thread.gmane.org/gmane.linux.drivers.nbd.general/1108 Did you check that the kernel is sending NBD_FLUSH commands? You can use tcpdump and then check

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 12:46:45AM +0300, Michael S. Tsirkin wrote: Once in a while make gets killed and doesn't clean up partial object files after it. Result is nasty errors from link. This hack checks object is well formed before linking, and rebuilds it if not. Signed-off-by: Michael

[Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-22 Thread Stefan Hajnoczi
' inside a Windows 7 guest: $ qemu -netdev tap,id=tap0,... -device rtl8139,netdev=tap0 The Linux guest driver does not trigger the bug, probably due to a different buffer management strategy. Reported-by: Oliver Francke oliver.fran...@filoo.de Signed-off-by: Stefan Hajnoczi stefa

Re: [Qemu-devel] Fwd: [Qemu-stable] connectivity problem with Windows 7 + heavy network-traffic

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 11:27 AM, Oliver Francke oliver.fran...@filoo.dewrote: Hi Stefan, thanks for your attention. See all infos below including complete command-line. Hi Oliver, I just sent a fix for qemu.git/master. If you need to backport it, replace qemu_get_queue(s-nic) with

Re: [Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 2:53 PM, Andreas Färber afaer...@suse.de wrote: Am 22.05.2013 14:50, schrieb Stefan Hajnoczi: Net queues support efficient receive disable. For example, tap's file descriptor will not be polled while its peer has receive disabled. This saves CPU cycles for needlessly

Re: [Qemu-devel] [PATCH v3 2/8] block: add basic backup support to block driver

2013-05-22 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 06:46:39PM +0200, Paolo Bonzini wrote: Il 21/05/2013 18:26, Dietmar Maurer ha scritto: Hmm, right. But do we need the bitmap at all? We can just use bdrv_is_allocated like bdrv_co_do_readv does. Does that works with a nbd driver? Ah, right. That's the answer.

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-22 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 10:58:47AM +, Dietmar Maurer wrote: True, but that would happen only in case the host crashes. Even for a QEMU crash the changes would be safe, I think. They would be written back when the persistent dirty bitmap's mmap() area is unmapped, during process

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 11:56:45AM +0200, Kevin Wolf wrote: Am 22.05.2013 um 11:54 hat Paolo Bonzini geschrieben: Il 22/05/2013 11:38, Kevin Wolf ha scritto: + +DPRINTF(brdv_co_backup_cow done C% PRId64 \n, start); +} + +out: +if (bounce_buffer) { +

Re: [Qemu-devel] [PATCH v4 4/8] qemu-iotests: add 055 drive-backup test case

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 01:19:58PM +0200, Kevin Wolf wrote: Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: Testing drive-backup is similar to image streaming and drive mirroring. This test case is based on 041. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests

Re: [Qemu-devel] [PATCH v4 3/8] block: add drive-backup QMP command

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 11:53:44AM +0200, Kevin Wolf wrote: Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: +proto_drv = bdrv_find_protocol(target); +if (!proto_drv) { +error_set(errp, QERR_INVALID_BLOCK_FORMAT, format); +return; +} I see

Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 12:12:24PM +0100, Richard W.M. Jones wrote: On Wed, May 22, 2013 at 01:04:51PM +0200, Paolo Bonzini wrote: Something is trying to write, but there's no write operation defined for CURL. I guess curl (and other backends too) should reject being opened for write.

Re: [Qemu-devel] [PATCH] hw/9pfs: Use O_NOFOLLOW when opening files on server

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 04:52:54PM +0530, Aneesh Kumar K.V wrote: diff --git a/hw/9pfs/virtio-9p-handle.c b/hw/9pfs/virtio-9p-handle.c index fe8e0ed..e2a89e3 100644 --- a/hw/9pfs/virtio-9p-handle.c +++ b/hw/9pfs/virtio-9p-handle.c @@ -608,7 +608,7 @@ static int handle_init(FsContext *ctx)

Re: [Qemu-devel] [PATCH] kvm: add detail error message when fail to add ioeventfd

2013-05-23 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 09:48:21PM +0800, Amos Kong wrote: On Wed, May 22, 2013 at 11:32:27AM +0200, Stefan Hajnoczi wrote: On Wed, May 22, 2013 at 12:57:35PM +0800, Amos Kong wrote: I try to hotplug 28 * 8 multiple-function devices to guest with old host kernel, ioeventfds in host kernel

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

2013-05-23 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 11:46:15PM +0200, Paolo Bonzini wrote: Il 22/05/2013 22:47, Richard W.M. Jones ha scritto: I meant if there was interest in reading from a disk that isn't fully synchronized (yet) to the original disk (it might have old blocks). Or would you only want to

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-23 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 03:34:18PM +, Dietmar Maurer wrote: That sounds like more work than a persistent dirty bitmap. The advantage is that while dirty bitmaps are consumed by a single user, the Merkle tree can be used to sync up any number of replicas. I also consider it

Re: [Qemu-devel] QMP interface for drive-add (or even blockdev-add)

2013-05-23 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 03:53:05PM +0200, Kevin Wolf wrote: Am 16.05.2013 um 21:05 hat Eric Blake geschrieben: On 05/16/2013 02:24 AM, Kevin Wolf wrote: The other thing that I'm not sure about is whether we should teach QAPI to parse certain data structures just into QDicts instead of C

Re: [Qemu-devel] [PATCH 0/2] coroutine: dataplane support

2013-05-23 Thread Stefan Hajnoczi
On Fri, May 17, 2013 at 03:51:24PM +0200, Stefan Hajnoczi wrote: There is ongoing work to enable multiple event loop threads. This will allow QEMU itself to take advantage of SMP and reduce Big QEMU Lock (BQL) contention. This series is one step in that effort. These patches make

Re: [Qemu-devel] [Bug 1182490] [NEW] [qemu-1.5] coroutine-win32.c broken on NULL pointer

2013-05-23 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 02:11:05PM -, Cauchy Song wrote: Public bug reported: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 4340.0x163c] qemu_coroutine_switch (action=COROUTINE_TERMINATE, to_=0x0, from_=0x3ba1c80) at

Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while compiling with c++ compilier

2013-05-23 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 11:33:41AM -0400, Tomoki Sekiyama wrote: Add C++ keywords to avoid errors in compiling with c++ compiler. This also renames class member of PciDeviceInfo to q_class. Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com --- hmp.c |2 +- hw/pci/pci.c

Re: [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-05-23 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 11:33:33AM -0400, Tomoki Sekiyama wrote: * How to build run qemu-ga with VSS support - Download Microsoft VSS SDK from: http://www.microsoft.com/en-us/download/details.aspx?id=23490 - Setup the SDK scripts/extract-vsssdk-headers setup.exe (on

Re: [Qemu-devel] [RFC PATCH v3 11/11] QMP/qmp.py: set locale for exceptions to display non-ascii messages correctly

2013-05-23 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 11:34:16AM -0400, Tomoki Sekiyama wrote: qemu-ga in Windows may return error message with multibyte characters when the guest OS language is set to other than English. To display such messages correctly, this encodes the message based on the locale settings.

[Qemu-devel] Designing QMP APIs at KVM Forum

2013-05-23 Thread Stefan Hajnoczi
With better QMP introspection on the horizon and work in various subsystems pushing QMP boundaries it would be useful to bring together the latest best practices for designing QMP APIs. There are design rules for keeping QMP APIs extensible and for allowing clients to detect the presence of

Re: [Qemu-devel] qemu seabios issue with vhost-scsi

2013-05-23 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 05:36:08PM -0700, Badari wrote: Hi, While testing vhost-scsi in the current qemu git, ran into an earlier issue with seabios. I had to disable scsi support in seabios to get it working. I was hoping this issue got resolved when vhost-scsi support got merged into

Re: [Qemu-devel] [RFC PATCH v3 05/11] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-05-23 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 11:33:52AM -0400, Tomoki Sekiyama wrote: Implements a basic stub of software VSS provider. Currently, this modules only provides a relay function of events between qemu-guest-agent and Windows VSS when VSS finished filesystem freeze and when qemu snapshot is done. In

Re: [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-05-23 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 3:20 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 23/05/2013 14:15, Stefan Hajnoczi ha scritto: On Tue, May 21, 2013 at 11:33:33AM -0400, Tomoki Sekiyama wrote: * How to build run qemu-ga with VSS support - Download Microsoft VSS SDK from: http

Re: [Qemu-devel] qemu seabios issue with vhost-scsi

2013-05-23 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 11:48 AM, Gleb Natapov g...@redhat.com wrote: On Thu, May 23, 2013 at 08:53:55AM +0800, Asias He wrote: On Wed, May 22, 2013 at 05:36:08PM -0700, Badari wrote: Hi, While testing vhost-scsi in the current qemu git, ran into an earlier issue with seabios. I had to

Re: [Qemu-devel] [PATCH v5 01/11] curl: introduce CURLSockInfo to BDRVCURLState.

2013-05-23 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 11:37:59AM +0800, Fam Zheng wrote: @@ -90,7 +98,16 @@ static int curl_aio_flush(void *opaque); static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action, void *s, void *sp) { +BDRVCURLState *bs = s; bs is used for BlockDriverState

Re: [Qemu-devel] [PATCH v5 05/11] curl: add timer to BDRVCURLState

2013-05-23 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 11:38:03AM +0800, Fam Zheng wrote: diff --git a/block/curl.c b/block/curl.c index fc464ad..4fd5bb9 100644 --- a/block/curl.c +++ b/block/curl.c @@ -89,6 +89,7 @@ typedef struct BDRVCURLState { QLIST_HEAD(, CURLSockInfo) socks; char *url; size_t

Re: [Qemu-devel] [PATCH v5 06/11] curl: introduce CURLDataCache

2013-05-23 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 11:38:04AM +0800, Fam Zheng wrote: +typedef struct CURLDataCache { +char *data; +size_t base_pos; Must be int64_t. QEMU compiled on 32-bit hosts would only allow 4 GB images with size_t! +size_t data_len; +size_t write_pos; +/* Ref count for

Re: [Qemu-devel] [PATCH v5 07/11] curl: make use of CURLDataCache.

2013-05-23 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 11:38:05AM +0800, Fam Zheng wrote: @@ -221,31 +215,35 @@ static void curl_complete_io(BDRVCURLState *bs, CURLAIOCB *acb, static size_t curl_read_cb(void *ptr, size_t size, size_t nmemb, void *opaque) { -CURLState *s = ((CURLState*)opaque); +CURLState

Re: [Qemu-devel] [PATCH v5 08/11] curl: use list to store CURLState

2013-05-23 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 11:38:06AM +0800, Fam Zheng wrote: @@ -660,9 +651,13 @@ static BlockDriverAIOCB *curl_aio_readv(BlockDriverState *bs, static void curl_close(BlockDriverState *bs) { BDRVCURLState *s = bs-opaque; -int i; DPRINTF(CURL: Close\n); +if (s-timer) {

Re: [Qemu-devel] [PATCH v5 00/11] curl: fix curl read

2013-05-23 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 11:37:58AM +0800, Fam Zheng wrote: CURL library API has changed, the current curl driver is not working. This patch rewrites the use of API as well as the structure of internal states. BDRVCURLState holds the pointer to curl multi interface (man 3 libcurl-multi), and

Re: [Qemu-devel] [PATCH v5 09/11] curl: add cache quota.

2013-05-23 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 11:38:07AM +0800, Fam Zheng wrote: Introduce a cache quota: BDRVCURLState.cache_quota. When adding new CURLDataCache to BDRVCURLState, if number of existing CURLDataCache is larger than CURL_CACHE_QUOTA, try to release some first to limit the in memory cache size. A

Re: [Qemu-devel] QMP interface for drive-add (or even blockdev-add)

2013-05-23 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 4:41 PM, Kevin Wolf kw...@redhat.com wrote: Am 23.05.2013 um 13:57 hat Stefan Hajnoczi geschrieben: On Wed, May 22, 2013 at 03:53:05PM +0200, Kevin Wolf wrote: Am 16.05.2013 um 21:05 hat Eric Blake geschrieben: On 05/16/2013 02:24 AM, Kevin Wolf wrote: The other

Re: [Qemu-devel] qemu seabios issue with vhost-scsi

2013-05-23 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 6:47 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 23/05/2013 18:38, Badari Pulavarty ha scritto: If that is with the old SeaBIOS, then SIGABRT is intended. :) The guest is buggy, the problem in QEMU only lies in _how_ it fails. Paolo I am confused now. Without

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 08:11:42AM +, Dietmar Maurer wrote: I also consider it safer, because you make sure the data exists (using hash keys like SHA1). I am unsure how you can check if a dirty bitmap contains errors, or is out of date? Also, you can compare

Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while compiling with c++ compilier

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 06:34:43PM +, Tomoki Sekiyama wrote: On 5/23/13 8:12 , Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, May 21, 2013 at 11:33:41AM -0400, Tomoki Sekiyama wrote: Add C++ keywords to avoid errors in compiling with c++ compiler. This also renames class member

Re: [Qemu-devel] [RFC PATCH v3 05/11] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 06:36:35PM +, Tomoki Sekiyama wrote: On 5/23/13 8:22 , Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, May 21, 2013 at 11:33:52AM -0400, Tomoki Sekiyama wrote: diff --git a/qga/vss-win32.h b/qga/vss-win32.h new file mode 100644 index 000..7600087

Re: [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 03:50:19PM +0200, Paolo Bonzini wrote: Il 23/05/2013 15:28, Stefan Hajnoczi ha scritto: On Thu, May 23, 2013 at 3:20 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 23/05/2013 14:15, Stefan Hajnoczi ha scritto: On Tue, May 21, 2013 at 11:33:33AM -0400, Tomoki

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 09:58:31PM +, Mark Trumpold wrote: I have a working configuration using the signal approach suggested by Stefan. 'qemu-nbd.c' is patched as follows: do { main_loop_wait(false); + if (sighup_reported) { + sighup_reported = false; +

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 11:35:24PM +, Mark Trumpold wrote: I had one question I forgot to ask.. Is it possible to switch from '--cache=writeback' functionality to '--cache=writethrough' (and visa versa) while qemu-nbd is connected to the '/dev/nbdx' device? No. The block layer APIs to

Re: [Qemu-devel] [RFC PATCH v3 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 03:50:19PM +0200, Paolo Bonzini wrote: Il 23/05/2013 15:28, Stefan Hajnoczi ha scritto: On Thu, May 23, 2013 at 3:20 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 23/05/2013 14:15, Stefan Hajnoczi ha scritto: On Tue, May 21, 2013 at 11:33:33AM -0400, Tomoki

Re: [Qemu-devel] [PATCH v5 07/11] curl: make use of CURLDataCache.

2013-05-24 Thread Stefan Hajnoczi
On Fri, May 24, 2013 at 11:10:26AM +0800, Fam Zheng wrote: On Thu, 05/23 16:23, Stefan Hajnoczi wrote: On Thu, May 23, 2013 at 11:38:05AM +0800, Fam Zheng wrote: +CURLDataCache *c = s-cache; size_t realsize = size * nmemb; -int i; - -DPRINTF(CURL: Just reading

Re: [Qemu-devel] Designing QMP APIs at KVM Forum

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 07:59:17AM -0600, Eric Blake wrote: On 05/23/2013 06:46 AM, Luiz Capitulino wrote: On Thu, 23 May 2013 13:51:22 +0200 Stefan Hajnoczi stefa...@gmail.com wrote: With better QMP introspection on the horizon and work in various subsystems pushing QMP boundaries

Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 01:44:40PM -0400, Corey Bryant wrote: This patch series provides VNVRAM persistent storage support that QEMU can use internally. The initial target user will be a software vTPM 1.2 backend that needs to store keys in VNVRAM and be able to reboot/migrate and retain the

Re: [Qemu-devel] [PATCH V2 2/5] block: move snapshot code in block.c to block/snapshot.c

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 04:47:13PM +0800, Wenchao Xia wrote: -int bdrv_is_snapshot(BlockDriverState *bs) -{ -return !!(bs-open_flags BDRV_O_SNAPSHOT); -} No need to respin, but this function has nothing to do with the other functions. This function is about -drive snapshot=on, the

Re: [Qemu-devel] [PATCH V2 4/5] util: add new function message_printf()

2013-05-24 Thread Stefan Hajnoczi
On Thu, May 23, 2013 at 04:47:15PM +0800, Wenchao Xia wrote: This function takes an input parameter *output, which can be specified by caller as stderr, stdout or a monitor. error_vprintf() now calls message_vprintf(), which is a static function added in this patch. Signed-off-by: Wenchao

Re: [Qemu-devel] use O_DIRECT to open disk images for IDE failed under xen-4.1.2 and qemu upstream

2013-05-24 Thread Stefan Hajnoczi
On Fri, May 24, 2013 at 02:59:05AM +, Gonglei (Arei) wrote: Hi, On Thu, 23 May 2013, Gonglei (Arei) wrote: Hi, all I use O_DIRECT to open disk images for IDE, but I'm failed. After debug, I get the below logs: [2013-05-22 23:25:46] ide: CMD=c8 [2013-05-22 23:25:46]

Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-24 Thread Stefan Hajnoczi
On Fri, May 24, 2013 at 08:13:27AM -0400, Stefan Berger wrote: On 05/24/2013 05:59 AM, Stefan Hajnoczi wrote: On Thu, May 23, 2013 at 01:44:40PM -0400, Corey Bryant wrote: This patch series provides VNVRAM persistent storage support that QEMU can use internally. The initial target user

[Qemu-devel] [PULL 00/11] Block patches

2013-05-24 Thread Stefan Hajnoczi
: Subcommand for changing header fields qemu-iotests: Try creating huge qcow2 image Stefan Hajnoczi (2): coroutine: protect global pool with a mutex coroutine: stop using AioContext in CoQueue Wenchao Xia (5): block: package preparation code in qmp_transaction() block: move

[Qemu-devel] [PATCH 02/11] block: move input parsing code in qmp_transaction()

2013-05-24 Thread Stefan Hajnoczi
From: Wenchao Xia xiaw...@linux.vnet.ibm.com The code is moved into preparation function, and changed a bit to tip more clearly what it is doing. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Kevin Wolf kw...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] [PATCH 03/11] block: package committing code in qmp_transaction()

2013-05-24 Thread Stefan Hajnoczi
From: Wenchao Xia xiaw...@linux.vnet.ibm.com The code is simply moved into a separate function. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Kevin Wolf kw...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off

[Qemu-devel] [PATCH 07/11] qemu-io: Fix 'map' output

2013-05-24 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com The output of the 'map' command in qemu-io used to directly resemble bdrv_is_allocated() and could contain many lines for small chunks that all have the same allocation status. After this patch, they will be coalesced into a single output line for a large chunk.

[Qemu-devel] [PATCH 05/11] block: make all steps in qmp_transaction() as callback

2013-05-24 Thread Stefan Hajnoczi
...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c | 95 ++ 1 file changed, 71 insertions(+), 24 deletions(-) diff --git a/blockdev.c b

[Qemu-devel] [PATCH 09/11] qemu-iotests: Try creating huge qcow2 image

2013-05-24 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com It's supposed to fail gracefully instead of segfaulting. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/054 | 58 tests/qemu-iotests/054.out | 10 tests/qemu-iotests/common.rc | 2

[Qemu-devel] [PATCH 08/11] qcow2.py: Subcommand for changing header fields

2013-05-24 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/qcow2.py | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/qemu-iotests/qcow2.py b/tests/qemu-iotests/qcow2.py index fecf5b9..44a2b45 100755 ---

[Qemu-devel] [PATCH 06/11] blockdev: Rename BlockdevAction - TransactionAction

2013-05-24 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com There's no reason to restrict transactions to operations related to block devices, so rename the type now before schema introspection stops us from doing so. Also change the schema documentation of 'transaction' to not refer to block devices or snapshots any

[Qemu-devel] [PATCH 10/11] coroutine: protect global pool with a mutex

2013-05-24 Thread Stefan Hajnoczi
The coroutine freelist is a global pool of unused coroutines. It avoids the setup/teardown overhead associated with the coroutine lifecycle. Since the pool is global, we need to synchronize access so that coroutines can be used outside the BQL. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] [PATCH 01/11] block: package preparation code in qmp_transaction()

2013-05-24 Thread Stefan Hajnoczi
Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Kevin Wolf kw...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c | 139 ++--- 1 file

[Qemu-devel] [PATCH 2/2] rtl8139: flush queued packets when RxBufPtr is written

2013-05-24 Thread Stefan Hajnoczi
' inside a Windows 7 guest: $ qemu -netdev tap,id=tap0,... -device rtl8139,netdev=tap0 The Linux guest driver does not trigger the bug, probably due to a different buffer management strategy. Reported-by: Oliver Francke oliver.fran...@filoo.de Signed-off-by: Stefan Hajnoczi stefa

[Qemu-devel] [PATCH 1/2] net: support for bridged networking on Mac OS X

2013-05-24 Thread Stefan Hajnoczi
://forum.gns3.net/post17679.html#p17679 And also as used in the MacPorts installation: https://trac.macports.org/browser/trunk/dports/emulators/qemu/files/patch-net-tap-interface.diff Signed-off-by: Alasdair McLeay alasdair.mcl...@me.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- net/tap

[Qemu-devel] [PULL 0/2] Net patches

2013-05-24 Thread Stefan Hajnoczi
to 00b7ade807b5ce6779ddd86ce29c5521ec5c529a: rtl8139: flush queued packets when RxBufPtr is written (2013-05-24 16:34:13 +0200) Alasdair McLeay (1): net: support for bridged networking on Mac OS X Stefan Hajnoczi (1): rtl8139: flush

[Qemu-devel] [PATCH 11/11] coroutine: stop using AioContext in CoQueue

2013-05-24 Thread Stefan Hajnoczi
queue. The wakeup queue is processed when we yield or terminate. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/block/coroutine_int.h | 4 qemu-coroutine-lock.c | 56 --- qemu-coroutine.c | 3 +++ trace-events

[Qemu-devel] [PATCH 04/11] block: package rollback code in qmp_transaction()

2013-05-24 Thread Stefan Hajnoczi
From: Wenchao Xia xiaw...@linux.vnet.ibm.com Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Kevin Wolf kw...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c | 11

Re: [Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-24 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 02:50:18PM +0200, Stefan Hajnoczi wrote: Net queues support efficient receive disable. For example, tap's file descriptor will not be polled while its peer has receive disabled. This saves CPU cycles for needlessly copying and then dropping packets which the peer

Re: [Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-27 Thread Stefan Hajnoczi
On Mon, May 27, 2013 at 08:15:42AM +0200, Peter Lieven wrote: I ocassionally have seen a probably related problem in the past. It mainly happend with rtl8139 under WinXP where we most likely use rtl8139 due to lack of shipped e1000 drivers. My question is if you see increasing dropped

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-27 Thread Stefan Hajnoczi
On Sun, May 26, 2013 at 10:38:14AM +0300, Michael S. Tsirkin wrote: On Fri, May 24, 2013 at 04:00:42PM -0400, Luiz Capitulino wrote: On Fri, 24 May 2013 12:05:12 -0600 Eric Blake ebl...@redhat.com wrote: On 05/24/2013 10:12 AM, Michael S. Tsirkin wrote: Event message contains

Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-27 Thread Stefan Hajnoczi
On Fri, May 24, 2013 at 11:39:09AM -0400, Corey Bryant wrote: On 05/24/2013 08:36 AM, Stefan Hajnoczi wrote: On Fri, May 24, 2013 at 08:13:27AM -0400, Stefan Berger wrote: On 05/24/2013 05:59 AM, Stefan Hajnoczi wrote: On Thu, May 23, 2013 at 01:44:40PM -0400, Corey Bryant wrote

Re: [Qemu-devel] [PATCH 2/2] rtl8139: flush queued packets when RxBufPtr is written

2013-05-27 Thread Stefan Hajnoczi
On Fri, May 24, 2013 at 05:18:09PM +0200, Paolo Bonzini wrote: Il 24/05/2013 16:38, Stefan Hajnoczi ha scritto: diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 9369507..7993f9f 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -2575,6 +2575,9 @@ static void

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-27 Thread Stefan Hajnoczi
On Sun, May 26, 2013 at 11:32:49AM +0200, Luke Gorrie wrote: Stefan put us onto the highly promising track of vhost/virtio. We have implemented this between Snabb Switch and the Linux kernel, but not directly between Snabb Switch and QEMU guests. The roadblock we have hit is embarrasingly

Re: [Qemu-devel] [PATCH] kvm: exclude ioeventfd from counting kvm_io_range limit

2013-05-27 Thread Stefan Hajnoczi
in kvm_host.h Signed-off-by: Amos Kong ak...@redhat.com --- include/linux/kvm_host.h | 3 ++- virt/kvm/eventfd.c | 2 ++ virt/kvm/kvm_main.c | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] IDE disk FLUSH take more than 30 secs, the SUSE guest reports lost interrupt and the file system becomes read-only

2013-05-27 Thread Stefan Hajnoczi
On Sun, May 26, 2013 at 07:08:02PM +0200, Andreas Färber wrote: Am 21.05.2013 09:12, schrieb Gonglei (Arei): Through analysis, I found that because the system call the fdatasync command in the Qemu over 30s, after the Guest's kernel thread detects the io transferation is timeout, went

Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while compiling with c++ compilier

2013-05-27 Thread Stefan Hajnoczi
On Fri, May 24, 2013 at 05:25:21PM +0200, Markus Armbruster wrote: Tomoki Sekiyama tomoki.sekiy...@hds.com writes: On 5/24/13 4:52 , Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, May 23, 2013 at 06:34:43PM +, Tomoki Sekiyama wrote: On 5/23/13 8:12 , Stefan Hajnoczi stefa

Re: [Qemu-devel] [RFC PATCH v3 11/11] QMP/qmp.py: set locale for exceptions to display non-ascii messages correctly

2013-05-27 Thread Stefan Hajnoczi
On Fri, May 24, 2013 at 06:55:21PM +, Tomoki Sekiyama wrote: On 5/23/13 8:30 , Stefan Hajnoczi stefa...@gmail.com wrote: Either or both bugs could be present. Once they are fixed you shouldn't see encoding problems. Stefan Anyway, as I understood this patch for qmp.py is not correct

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-27 Thread Stefan Hajnoczi
On Sat, May 25, 2013 at 09:42:08AM -0800, Mark Trumpold wrote: On 5/24/13 1:05 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, May 23, 2013 at 09:58:31PM +, Mark Trumpold wrote: One thing to be careful of is whether these operations are asynchronous. The signal is asynchronous, you

Re: [Qemu-devel] [Bug 1184089] [NEW] [Feature request] loadvm snapshot as read-only

2013-05-27 Thread Stefan Hajnoczi
On Sat, May 25, 2013 at 08:29:11AM -, Michael Coppola wrote: There are many ways to take and manage snapshots in QEMU, but one main feature that's missing is the ability to 'loadvm' a LIVE snapshot and have all future changes redirected to a temporary file. This would effectively be

Re: [Qemu-devel] use O_DIRECT to open disk images for IDE failed under xen-4.1.2 and qemu upstream

2013-05-27 Thread Stefan Hajnoczi
On Sat, May 25, 2013 at 07:32:55AM +, Gonglei (Arei) wrote: -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Friday, May 24, 2013 8:20 PM To: Gonglei (Arei) Cc: Stefano Stabellini; Hanweidong; Luonengjun; qemu-devel@nongnu.org; Wangzhenguo; xen

[Qemu-devel] [PATCH v4] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-27 Thread Stefan Hajnoczi
we pick a random value from 1 to 255 to expose more bugs. If you need to reproduce a crash use 'show environment' in gdb to extract the MALLOC_PERTURB_ value from a core dump. Both make check and qemu-iotests pass with MALLOC_PERTURB_ enabled. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-27 Thread Stefan Hajnoczi
reported: commit a9d8f7b1c41a8a346f4cf5a0c6963a79fbd1249e Author: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Date: Mon Aug 20 13:35:23 2012 +0100 net: do not report queued packets as sent

Re: [Qemu-devel] [Bug 1184616] [NEW] undefined reference to `trace_qemu_anon_ram_alloc'

2013-05-27 Thread Stefan Hajnoczi
On Mon, May 27, 2013 at 4:02 PM, Nigel Horne 1184...@bugs.launchpad.net wrote: The latest git version (commit 6a4e17711442849bf2cc731ccddef5a2a2d92d29) fails to compile: ... LINK qemu-ga libqemuutil.a(oslib-posix.o): In function `qemu_anon_ram_alloc': oslib-posix.c:(.text+0x154):

Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable

2013-05-28 Thread Stefan Hajnoczi
On Mon, May 27, 2013 at 05:25:16PM +0200, Kevin Wolf wrote: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: From: Stefan Hajnoczi stefa...@redhat.com The bs_snapshots global variable points to the BlockDriverState which will be used to save vmstate. This is really a savevm.c concept

Re: [Qemu-devel] [PATCH] block: add read only to whitelist

2013-05-28 Thread Stefan Hajnoczi
On Tue, May 28, 2013 at 02:44:26PM +0800, Fam Zheng wrote: We may want to include a driver in the whitelist for read only tasks such as diagnosing or exporting guest data (with libguestfs as a good example). This patch introduces the magic prefix ^ to include a driver to the whitelist, but

Re: [Qemu-devel] kvm process disappears

2013-05-28 Thread Stefan Hajnoczi
On Mon, May 27, 2013 at 11:09:51PM +0200, Stefan Priebe wrote: Am 10.05.2013 13:09, schrieb Stefan Hajnoczi: On Fri, May 10, 2013 at 11:07 AM, Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 10.05.2013 09:42, schrieb Stefan Hajnoczi: On Fri, May 10, 2013 at 08:12:39AM +0200

Re: [Qemu-devel] [Bug 1184089] Re: [Feature request] loadvm snapshot as read-only

2013-05-28 Thread Stefan Hajnoczi
On Mon, May 27, 2013 at 10:42:17PM -, Michael Coppola wrote: Awesome, looking forward to it. I may be misunderstanding what's happening under the hood, but at least for me, calling 'loadvm' on a single snapshot over and over seems to work the first few times and then immediately blue

Re: [Qemu-devel] [Bug 1184616] [NEW] undefined reference to`trace_qemu_anon_ram_alloc'

2013-05-28 Thread Stefan Hajnoczi
On Mon, May 27, 2013 at 09:04:26PM -, Nigel Horne wrote: On Mon, May 27, 2013 at 4:02 PM, Nigel Horne 1184...@bugs.launchpad.net wrote: The latest git version (commit 6a4e17711442849bf2cc731ccddef5a2a2d92d29) fails to compile: ... LINK qemu-ga libqemuutil.a(oslib-posix.o):

[Qemu-devel] [PATCH] qemu-iotests: fix 054 cluster size help output

2013-05-28 Thread Stefan Hajnoczi
Commit f3f4d2c09b9cf46903ba38425ec46c44185162bd added a hint to increase the cluster size when a large image cannot be created. Test 054 now has outdated output and fails because the golden output does not match. This patch updates the 054 golden output. Signed-off-by: Stefan Hajnoczi stefa

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-28 Thread Stefan Hajnoczi
On Tue, May 28, 2013 at 12:10 PM, Luke Gorrie luk...@gmail.com wrote: On 27 May 2013 11:34, Stefan Hajnoczi stefa...@redhat.com wrote: vhost_net is about connecting the a virtio-net speaking process to a tun-like device. The problem you are trying to solve is connecting a virtio-net speaking

  1   2   3   4   5   6   7   8   9   10   >