Re: [Qemu-devel] QEMU License and proprietary hardware

From: Luke -Jr [EMAIL PROTECTED] Subject: Re: [Qemu-devel] QEMU License and proprietary hardware Date: Fri, 22 Jun 2007 10:18:01 -0500 On Thursday 21 June 2007 17:33, M. Warner Losh wrote: The GPL only has as much force of law as copyright law gives it, and in order to be applicable

Re: [Qemu-devel] [PATCH] target_posix_types.h

From: Paul Brook [EMAIL PROTECTED] Subject: Re: [Qemu-devel] [PATCH] target_posix_types.h Date: Wed, 14 Nov 2007 20:39:36 + This means that time_t had to be tracked down on varying architectures to find the size and there was an assumption made that time_t is 32 bits - which isn't true

Re: [Qemu-devel] Making qemu use 10.0.3.x not 10.0.2.x

From: Andreas Färber [EMAIL PROTECTED] Subject: Re: [Qemu-devel] Making qemu use 10.0.3.x not 10.0.2.x Date: Tue, 5 Feb 2008 13:58:28 +0100 Am 05.02.2008 um 12:30 schrieb Ian Jackson: I don't believe that 10.0.2.0/24 was chosen randomly :-). It would be better for qemu's default range

Re: [Qemu-devel] It told me to report this...

On Mon, Dec 11, 2017 at 5:29 AM, Dr. David Alan Gilbert <dgilb...@redhat.com > wrote: > * Warner Losh (i...@bsdimp.com) wrote: > > unknown keycodes `empty+aliases(qwerty)', please report to > > qemu-devel@nongnu.org > > > > My X server is Mac XQuartz 2.7.11. I

Re: [Qemu-devel] It told me to report this...

On Mon, Dec 11, 2017 at 5:33 AM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Mon, Dec 11, 2017 at 12:29:36PM +, Dr. David Alan Gilbert wrote: > > * Warner Losh (i...@bsdimp.com) wrote: > > > unknown keycodes `empty+aliases(qwerty)', please report to >

[Qemu-devel] It told me to report this...

unknown keycodes `empty+aliases(qwerty)', please report to qemu-devel@nongnu.org My X server is Mac XQuartz 2.7.11. I saw this question raised several years ago in the archives, with promises of patches, but couldn't find anything relevant in the latest tree I grabbed from github (I saw this

Re: [Qemu-devel] QEMU 3.0 proposed release schedule

On Tue, May 22, 2018 at 9:24 AM, Peter Maydell wrote: > I've put up a draft release schedule at: > https://wiki.qemu.org/Planning/3.0 > > 2018-04-24 Beginning of development phase > 2018-07-03 Soft feature freeze. > 2018-07-10 Hard feature freeze. Tag rc0

Re: [Qemu-devel] QEMU 3.0 proposed release schedule

On Tue, May 22, 2018 at 9:50 AM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 22 May 2018 at 16:39, Warner Losh <i...@bsdimp.com> wrote: > > On Tue, May 22, 2018 at 9:24 AM, Peter Maydell <peter.mayd...@linaro.org > > > > wrote: > >&

Re: [Qemu-devel] Large patch set advice

On Thu, Apr 26, 2018 at 2:11 AM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 25 April 2018 at 20:57, Warner Losh <i...@bsdimp.com> wrote: > > I’ve foolishly volunteered to rebase all the changes that the bad-user > > mode folks have done to a recent mast

[Qemu-devel] Large patch set advice

to the later parts if my past experience with these things has any relevance. Thanks for any help you can give me. Warner Losh i...@freesbd.org P.S. Yes, I get that we should have been more engaged all along.

Re: [Qemu-devel] Large patch set advice

On Thu, Apr 26, 2018 at 2:11 AM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 25 April 2018 at 20:57, Warner Losh <i...@bsdimp.com> wrote: > > I’ve foolishly volunteered to rebase all the changes that the bad-user > > mode folks have done to a recent mast

Re: [Qemu-devel] Large patch set advice

On Thu, Apr 26, 2018 at 5:22 AM, Kamil Rytarowski <n...@gmx.com> wrote: > On 26.04.2018 10:11, Peter Maydell wrote: > > On 25 April 2018 at 20:57, Warner Losh <i...@bsdimp.com> wrote: > >> I’ve foolishly volunteered to rebase all the changes that the bad-user > &g

Re: [Qemu-devel] Are FreeBSD guest images working?

On Thu, Nov 15, 2018 at 7:54 PM Peter Xu wrote: > On Thu, Nov 15, 2018 at 11:05:33AM +0100, Philippe Mathieu-Daudé wrote: > > On 15/11/18 9:58, Peter Xu wrote: > > > Hi, the list, > > > > > > I am trying to boot a FreeBSD guest but failed. It hangs at the > > > kernel booting phase: > > > > > >

Re: [Qemu-devel] Are FreeBSD guest images working?

On Fri, Nov 16, 2018, 5:30 AM Gerd Hoffmann On Fri, Nov 16, 2018 at 09:47:48AM +, Peter Maydell wrote: > > On 16 November 2018 at 05:01, Peter Xu wrote: > > > I would guess there aren't many people like me to prefer booting a VM > > > using console, though I agree that it'll be nice if we

Re: [Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

On Sun, Mar 3, 2019, 12:45 AM Samuel Thibault wrote: > By default, curses will only report single ESC key event after 1s delay, > since ESC is also used for keypad escape sequences. This however makes > users > believe that ESC is not working. Reducing to 0.2s provides good enough user >

Re: [RFC] QEMU Gating CI

On Mon, Dec 2, 2019 at 11:29 AM Cleber Rosa wrote: > On Mon, Dec 02, 2019 at 05:08:35PM +, Peter Maydell wrote: > > On Mon, 2 Dec 2019 at 17:00, Stefan Hajnoczi > wrote: > > > > > > On Mon, Dec 02, 2019 at 09:05:52AM -0500, Cleber Rosa wrote: > > > > To exemplify my point, if one specific

Re: QEMU user mode execve

On Thu, Oct 3, 2019 at 1:36 PM Michal Suchánek wrote: > On Thu, Oct 03, 2019 at 10:48:46AM -0700, Mauricio Galindo wrote: > > Hi, > > > > I'm running QEMU in user mode and I'm running into issues when trying > > to exec binaries within the emulated process given that binaries are > > expected to

Re: [PATCH] linux-user: Reserve space for brk

On Fri, Jan 17, 2020 at 4:03 PM Richard Henderson < richard.hender...@linaro.org> wrote: > With bad luck, we can wind up with no space at all for brk, > which will generally cause the guest malloc to fail. > ... > The choice of 16MB is somewhat arbitrary. It's enough for libc > to get going,

Re: [PATCH 0/4] migration: Replace gemu_log with qemu_log

On Mon, Jan 13, 2020, 8:03 PM Josh Kunz wrote: > The linux-user and bsd-user trees both widely use a function called > `gemu_log` (notice the 'g') for miscellaneous and strace logging. This > function predates the newer `qemu_log` function, and has a few drawbacks > compared to `qemu_log`: > >

Re: Moving to C11? (was Re: Redefinition of typedefs (C11 feature))

On Fri, Sep 11, 2020 at 2:07 PM Eduardo Habkost wrote: > On Fri, Sep 11, 2020 at 08:06:10PM +0100, Peter Maydell wrote: > > On Fri, 11 Sep 2020 at 19:49, Eduardo Habkost > wrote: > > > > > > I'm wondering: do our supported build host platforms all include > > > compilers that are new enough to

Re: Moving to C11? (was Re: Redefinition of typedefs (C11 feature))

On Sat, Sep 12, 2020, 2:16 AM Philippe Mathieu-Daudé wrote: > On 9/11/20 10:10 PM, Warner Losh wrote: > > > > > > On Fri, Sep 11, 2020 at 2:07 PM Eduardo Habkost > <mailto:ehabk...@redhat.com>> wrote: > > > > On Fri, Sep 11, 2020 at 08:06:10PM

Re: Python 3.5 EOL; when can require 3.6?

On Thu, Sep 17, 2020 at 9:37 AM Markus Armbruster wrote: > Thomas Huth writes: > > > On 16/09/2020 16.00, Thomas Huth wrote: > >> On 16/09/2020 14.30, Peter Maydell wrote: > >>> On Wed, 16 Sep 2020 at 08:43, Markus Armbruster > wrote: > We require Python 3.5. It will reach its "end of

Re: qemu bsd-user plans

On Mon, Jan 11, 2021 at 6:27 AM Daniel P. Berrangé wrote: > On Fri, Jan 08, 2021 at 12:41:30PM -0700, Warner Losh wrote: > > The FreeBSD project has rewritten bsd-user. We've been working on this > for > > quite some time (the earliest commits date from 2013). Maybe a dozen

Re: Status/future of QEMU bsd-user impl ? (Wea Re: [PULL 00/12] Compile QEMU with -Wimplicit-fallthrough)

On Thu, Dec 17, 2020 at 9:21 AM Peter Maydell wrote: > On Thu, 17 Dec 2020 at 16:03, Warner Losh wrote: > > On Thu, Dec 17, 2020 at 7:02 AM Daniel P. Berrangé > wrote: > >> I don't recall what happened after that initial discussion about > >> merging the new

Re: Status/future of QEMU bsd-user impl ? (Wea Re: [PULL 00/12] Compile QEMU with -Wimplicit-fallthrough)

On Thu, Dec 17, 2020 at 7:02 AM Daniel P. Berrangé wrote: > On Thu, Dec 17, 2020 at 02:03:47PM +0100, Thomas Huth wrote: > > On 17/12/2020 13.51, Peter Maydell wrote: > > > On Wed, 16 Dec 2020 at 17:29, Thomas Huth wrote: > > >> > > >> Hi! > > >> > > >> The following changes since commit >

Re: Status/future of QEMU bsd-user impl ? (Wea Re: [PULL 00/12] Compile QEMU with -Wimplicit-fallthrough)

On Thu, Dec 17, 2020 at 10:10 AM Warner Losh wrote: > > > On Thu, Dec 17, 2020 at 9:21 AM Peter Maydell > wrote: > >> On Thu, 17 Dec 2020 at 16:03, Warner Losh wrote: >> > On Thu, Dec 17, 2020 at 7:02 AM Daniel P. Berrangé >> wrote: >> >>

Re: [PATCH 2/4] tcg: Additional Trap type for FreeBSD

On Fri, Dec 18, 2020 at 1:55 PM wrote: > From: Sean Bruno > > FreeBSD can generate a trap 0xc as well as 0xe when writing to a > read-only page. > > Signed-off-by: Juergen Lock > [imp rewored commit message for clarity] > Signed-off-by: Warner Losh > --- &

Re: [PATCH 0/4] A few preliminary bsd-user patches

I'm not at all sure why this was sent twice. I thought I'd cleared out all the 'failed' attempts on the first system I tried to git email-send from after realizing sendmail hadn't been configured... Sorry about that. Warner On Sat, Dec 19, 2020 at 1:54 PM wrote: > From: Warner L

Re: [PATCH 2/4] tcg: Additional Trap type for FreeBSD

; [imp rewored commit message for clarity] > Signed-off-by: Warner Losh > --- > accel/tcg/user-exec.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c > index 4ebe25461a..1f5befa9f9 100644 > --- a

Re: [PATCH 0/2] bsd-user, FreeBSD update

eview and so on. > > Regards. > > On Mon, 28 Dec 2020 at 16:21, Warner Losh wrote: > > > > > > > > On Mon, Dec 28, 2020 at 1:15 AM David CARLIER > wrote: > >> > >> From 10b13162949debdbbd8394bc1047511d1a900176 Mon Sep 17 00:00:00 2001

Re: [PATCH 0/2] bsd-user, FreeBSD update

On Mon, Dec 28, 2020 at 1:15 AM David CARLIER wrote: > From 10b13162949debdbbd8394bc1047511d1a900176 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Mon, 28 Dec 2020 08:10:43 + > Subject: [PATCH 0/2] *** SUBJECT HERE *** > > bsd-user, FreeBSD update. > > David Carlier (2): >

qemu bsd-user plans

The FreeBSD project has rewritten bsd-user. We've been working on this for quite some time (the earliest commits date from 2013). Maybe a dozen people have worked on this over time, and there's 3 or 4 active developers focused on FreeBSD changes at the moment. For a while, we'd merge in upstream

Re: qemu bsd-user plans

And add a couple of FreeBSD people I also forgot to CC. Warner On Fri, Jan 8, 2021 at 12:56 PM Peter Maydell wrote: > Adding the people to the CC list who were on the previous discussion > thread... > > -- PMM > > > On Fri, 8 Jan 2021 at 19:43, Warner Losh wrote: > &

Re: qemu bsd-user plans

On Sat, Jan 9, 2021 at 10:03 AM Kyle Evans wrote: > On Fri, 8 Jan 2021 at 19:43, Warner Losh wrote: > > > > The FreeBSD project has rewritten bsd-user. We've been working on this > for quite some time (the earliest commits date from 2013). Maybe a dozen > people have wor

Re: [PATCH v3 08/21] bsd-user: Tidy VERIFY_READ/VERIFY_WRITE

Maydell > Signed-off-by: Richard Henderson > This looks OK to me. Reviewed-by: Warner Losh > --- > bsd-user/qemu.h | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h > index f8bb1e5459..4076adabd0 100644 &g

Re: [PATCH V4 3/4] bsd-user: do not use C99 // comments

Same: please submit this via http://github.com/qemu-bsd-user... Warner On Sun, Jan 17, 2021, 7:20 PM shiliyang wrote: > This patch fixes error messages found by checkpatch.pl: > ERROR: do not use C99 // comments > > Signed-off-by: Liyang Shi > --- > bsd-user/elfload.c | 4 ++-- > 1 file

Re: [PATCH V4 4/4] bsd-user: space required after semicolon

Can you submit this to our current fork at http://github.com/qemu-bsd-user on the rebase-3.1 branch? Having churn like this upstream just slows us down since we have extensive changes and these will conflict. Warner On Sun, Jan 17, 2021, 7:21 PM shiliyang wrote: > This patch fixes error style

Re: [PATCH V4 0/4] bsd-user: Fix some code style problems

Please submit these via http://github.com/qemu-bsd-user/ On Sun, Jan 17, 2021, 7:17 PM shiliyang wrote: > This patch series fixes error style problems found by checkpatch.pl. > > V3->V4: > Fix code style problems with branch bsd-user-rebase-3.1. > > V2->V3: > Make the patch into a series. > >

Re: [PATCH v9 03/11] configure: check for sys/disk.h

On Mon, Jan 25, 2021 at 6:33 PM Joelle van Dyne wrote: > Some BSD platforms do not have this header. > > Signed-off-by: Joelle van Dyne > --- > meson.build| 1 + > block.c| 2 +- > block/file-posix.c | 2 +- > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v9 03/11] configure: check for sys/disk.h

the systems that it exists on. > -j > > On Mon, Jan 25, 2021 at 8:35 PM Warner Losh wrote: > > > > > > > > On Mon, Jan 25, 2021 at 6:33 PM Joelle van Dyne wrote: > >> > >> Some BSD platforms do not have this header. > >> > >> Sign

Re: [PATCH v9 03/11] configure: check for sys/disk.h

avoid top-posting, and to > instead reply inline to make the conversation easier to follow. > > > > > -j > > > > On Mon, Jan 25, 2021 at 8:35 PM Warner Losh wrote: > >> > >> > >> > >> On Mon, Jan 25, 2021 at 6:33 PM

Re: [PATCH V3 0/4] bsd-user: Fix some code style problems

While these changes look good, can you submit this against the bsd-user repository? White space changes like this in mainline make rebasing harder than needed. https://github.com/qemu-bsd-user/qemu-bsd-user branch bsd-user-rebase-3.1and we'll make sure they get via our coming pull requests..

Re: [PATCH 0/4] A few preliminary bsd-user patches

On Fri, Dec 18, 2020 at 1:55 PM wrote: > From: Warner Losh > > Here's the first round of bsd-user patches. There's on the order of 280 > that > we've done, but that's too much to review all at once. In addition, 3.1 > release > was the last rebase point that

Re: [PATCH] MAINTAINERS: update bsd-user maintainers

On Sun, Jan 31, 2021 at 11:30 PM Thomas Huth wrote: > On 30/01/2021 17.46, Warner Losh wrote: > > bsd-user: Add new mainatiners > > > > The FreeBSD project has a number of enhancements to bsd-user. Add myself > > as maintainer and Kyle Evans as a reviewe

[PATCH] MAINTAINERS: update bsd-user maintainers

bsd-user: Add new mainatiners The FreeBSD project has a number of enhancements to bsd-user. Add myself as maintainer and Kyle Evans as a reviewer. Also add our github repo. Signed-off-by: Warner Losh --- MAINTAINERS | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: Makefile has local changes that will be overwritten

On Tue, Feb 2, 2021, 2:27 AM Greg Kurz wrote: > On Mon, 1 Feb 2021 10:30:25 -0500 > Programmingkid wrote: > > > > > > > > On Feb 1, 2021, at 9:52 AM, Peter Maydell > wrote: > > > > > > On Mon, 1 Feb 2021 at 14:49, Dan Streetman > wrote: > > >> > > >> On Mon, Feb 1, 2021 at 9:23 AM

Re: [PATCH] tests/vm/freebsd: Increase code coverage

> On Jun 15, 2021, at 2:09 PM, Warner Losh wrote: > > > >> On Jun 15, 2021, at 10:55 AM, Philippe Mathieu-Daudé wrote: >> >> On 5/31/21 10:53 PM, Wainer dos Santos Moschetta wrote: >>> Hi, >>> >>> On 5/31/21 7:03 AM, Philippe Mathie

Re: [PATCH] tests/vm/freebsd: Increase code coverage

> On Jun 15, 2021, at 10:55 AM, Philippe Mathieu-Daudé wrote: > > On 5/31/21 10:53 PM, Wainer dos Santos Moschetta wrote: >> Hi, >> >> On 5/31/21 7:03 AM, Philippe Mathieu-Daudé wrote: >>> Install more dependencies to increase code coverage. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>>

Re: Regarding commit a9bcedd (SD card size has to be power of 2)

On Mon, Jun 7, 2021 at 2:31 AM Tom Yan wrote: > Hi philmd (and others), > > So I just noticed your commit of requiring the size of an emulated SD > card to be a power of 2, when I was trying to emulate one for an > actual one (well, it's a microSD, but still), as it errored out. > > You claim

Re: [RFC PATCH 9/9] hw/sd: Allow card size not power of 2 again

> On Jun 24, 2021, at 4:56 AM, Peter Maydell wrote: > > On Thu, 24 Jun 2021 at 11:27, Tom Yan wrote: >> I really think we should get (/ have gotten) things clear first. What >> exactly is the bug we have been talking about here? I mean like, where >> does it occur and what's the nature of it.

[PATCH v2 1/1] tcg: Use correct trap number for page faults on *BSD systems

it to i386 ] Signed-off-by: Warner Losh --- accel/tcg/user-exec.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index fb2d43e6a9..e2d0165670 100644 --- a/accel/tcg/user-exec.c +++ b/accel/tcg/user-exec.c @@ -254,28

[PATCH v2 0/1] Use correct trap number for *BSD

itself. Warner Losh (1): tcg: Use correct trap number for page faults on *BSD systems accel/tcg/user-exec.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) -- 2.22.1

[PATCH v2 0/1] Use correct trap number for *BSD

This is a resend of a patch I sent back in March that was missing the proper includes due to a rebasing mistake. Warner Losh (1): tcg: Use correct trap number for page faults on *BSD systems accel/tcg/user-exec.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions

Re: [PATCH v2 0/1] Use correct trap number for *BSD

On Thu, Jun 24, 2021 at 10:57 PM Warner Losh wrote: > This is a resend of a patch I sent back in March that was missing the > proper > includes due to a rebasing mistake. > > The issue is that all the BSDs use T_PAGEFLT to signal a page fault on x86, > while linux uses 0xe. Th

[PATCH 3/3] bsd-user: rename linux_binprm to bsd_binprm

Rename linux_binprm to bsd_binprm to reflect that we're loading BSD binaries, not ELF ones. Signed-off-by: Warner Losh --- bsd-user/bsdload.c | 4 ++-- bsd-user/elfload.c | 4 ++-- bsd-user/qemu.h| 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/bsd-user/bsdload.c b

[PATCH 2/3] bsd-user: Stop building the sparc platforms

to review and satisfy that all revisions of a patch series are buildable. Signed-off-by: Warner Losh --- default-configs/targets/sparc-bsd-user.mak | 3 --- default-configs/targets/sparc64-bsd-user.mak | 4 2 files changed, 7 deletions(-) delete mode 100644 default-configs/targets/sparc-bsd

[PATCH 0/3] bsd-user cleanup

, this just removes sparc from the build, deletes a file that's not in the final product and renames a bsd-specific structure to have a bsd name, not a linux one. Warner Losh (3): bsd-user: remove target_signal.h, it's unused bsd-user: Stop building the sparc platforms bsd-user: rename

[PATCH 1/3] bsd-user: remove target_signal.h, it's unused

Remove the target_signal.h file. None of its contents are currently used and the bsd-user fork doesn't use them (so this reduces the diffs there). Signed-off-by: Warner Losh --- bsd-user/i386/target_signal.h| 20 bsd-user/qemu.h | 1 - bsd-user

Re: [PATCH 07/23] hw/block/nvme: Use definition to avoid dynamic stack allocation

On Wed, May 5, 2021, 5:10 PM Eric Blake wrote: > On 5/5/21 5:07 PM, Philippe Mathieu-Daudé wrote: > > +Eric > > > > On 5/5/21 11:22 PM, Keith Busch wrote: > >> On Wed, May 05, 2021 at 11:10:31PM +0200, Philippe Mathieu-Daudé wrote: > >>> The compiler isn't clever enough to figure

Re: [PATCH v2 0/9] misc: Replace alloca() by g_malloc()

On Thu, May 6, 2021 at 7:39 AM Philippe Mathieu-Daudé wrote: > The ALLOCA(3) man-page mentions its "use is discouraged". > Replace few calls by equivalent GLib malloc(). > Except g_alloc and g_malloc are not at all the same, and you can't drop in replace one with the other. g_alloc allocates

Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new()

On Thu, May 6, 2021 at 8:21 AM Peter Maydell wrote: > On Thu, 6 May 2021 at 15:17, Warner Losh wrote: > > > > > > > > On Thu, May 6, 2021, 7:38 AM Philippe Mathieu-Daudé > wrote: > >> > >> The ALLOCA(3) man-page mentions its "use is

Re: [PATCH v2 0/9] misc: Replace alloca() by g_malloc()

On Thu, May 6, 2021 at 8:28 AM Eric Blake wrote: > On 5/6/21 9:22 AM, Warner Losh wrote: > > On Thu, May 6, 2021 at 7:39 AM Philippe Mathieu-Daudé > > > wrote: > > > >> The ALLOCA(3) man-page mentions its "use is discouraged". >

Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new()

On Thu, May 6, 2021, 7:38 AM Philippe Mathieu-Daudé wrote: > The ALLOCA(3) man-page mentions its "use is discouraged". > > Replace it by a g_new() call. > > Signed-off-by: Philippe Mathieu-Daudé > --- > bsd-user/syscall.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new()

On Thu, May 6, 2021 at 8:26 AM Eric Blake wrote: > On 5/6/21 9:16 AM, Warner Losh wrote: > > On Thu, May 6, 2021, 7:38 AM Philippe Mathieu-Daudé > > wrote: > > > >> The ALLOCA(3) man-page mentions its "use is discouraged". > >> > &

Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new()

On Thu, May 6, 2021 at 8:57 AM Philippe Mathieu-Daudé wrote: > On 5/6/21 4:48 PM, Warner Losh wrote: > > > > > > On Thu, May 6, 2021 at 8:21 AM Peter Maydell > <mailto:peter.mayd...@linaro.org>> wrote: > > > > On Thu, 6 May 2021 at 15:17, Warne

Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new()

On Thu, May 6, 2021 at 9:59 AM Peter Maydell wrote: > On Thu, 6 May 2021 at 15:57, Warner Losh wrote: > > malloc, on the other hand, involves taking out a number of mutexes > > and similar things to obtain the memory, which may not necessarily > > be safe in all the cont

Re: [PATCH v2] tcg: Use correct trap number for page faults on *BSD systems

On Thu, May 6, 2021 at 11:51 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 5/6/21 10:38 AM, Warner Losh wrote: > > The trap number for a page fault on BSD systems is T_PAGEFLT not 0xe. > 0xe is > > used by Linux and represents the intel hardware trap v

Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new()

On Thu, May 6, 2021 at 9:12 AM Eric Blake wrote: > On 5/6/21 9:55 AM, Warner Losh wrote: > > >>> Where is this freed? Also, alloca just moves a stack pointer, where > >> malloc > >>> has complex interactions. Are you sure that's a safe change here? >

[PATCH v2] tcg: Use correct trap number for page faults on *BSD systems

it to i386 ] Signed-off-by: Warner Losh --- accel/tcg/user-exec.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index 0d8cc27b21..959fec1257 100644 --- a/accel/tcg/user-exec.c +++ b/accel/tcg/user-exec.c @@ -260,6 +260,7

Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new()

On Thu, May 6, 2021 at 10:04 AM Peter Maydell wrote: > On Thu, 6 May 2021 at 16:46, Eric Blake wrote: > > > > On 5/6/21 10:30 AM, Warner Losh wrote: > > > > > > > > But for the real answer, I need to contact the original authors of > > > this p

[PATCH] tcg: Use correct trap number for page faults on *BSD systems

of the trap hanlder can very on the flavor of BSD. As far as I can tell, Linux doesn't provide a avoid uglier #ifdefs. Signed-off-by: Mark Johnston Signed-off-by: Juergen Lock [ Rework to avoid ifdefs and expand it to i386 ] Signed-off-by: Warner Losh --- accel/tcg/user-exec.c | 14

Re: [PATCH] tcg: Use correct trap number for page faults on *BSD systems

On Thu, May 6, 2021 at 10:43 AM Warner Losh wrote: > The trap number for a page fault on BSD systems is T_PAGEFLT not 0xe. 0xe > is > used by Linux and represents the intel hardware trap vector. The BSD > kernels, > however, translate this to T_PAGEFLT in their Xpage, Xtrap0

[PULL 00/20] bsd-user style tweaks and start cleanup

ngs, 0 lines checked FAIL one or more commits failed scripts/checkpatch.pl Cleaning up file based variables ERROR: Job failed: exit code 1 Warner Losh (20): bsd-user: whitespace changes bsd-user: style tweak: use C not C++ comments bsd-user: style tweak: Remove #if 0'd c

[PULL 08/20] bsd-user: style tweak: Use preferred block comments

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/qemu.h | 74 - 1 file changed, 43 insertions(+), 31 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index de20e8329a..7f3cfa68aa 100644 --- a/bsd-user/qemu.h +++ b

[PULL 10/20] bsd-user: style tweak: use {} for all if statements, format else correctly

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/qemu.h | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index 2494d9209d..8d3767964d 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -358,16

[PULL 18/20] bsd-user: remove target_signal.h, it's unused

Remove the target_signal.h file. None of its contents are currently used and the bsd-user fork doesn't use them (so this reduces the diffs there). Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/i386/target_signal.h| 20 bsd-user/qemu.h

[PULL 03/20] bsd-user: style tweak: Remove #if 0'd code

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 143 1 file changed, 143 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 5253ceb24b..c342dd7829 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c

[PULL 06/20] bsd-user: style tweak: move extern to header file

Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 1 - bsd-user/qemu.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index cd1c26516b..71bfe17f38 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -47,7 +47,6 @@ unsigned long

[PULL 16/20] bsd-user: style tweak: Remove #if 0'd code

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/strace.c | 8 1 file changed, 8 deletions(-) diff --git a/bsd-user/strace.c b/bsd-user/strace.c index 2c3b59caf0..be40b8a20c 100644 --- a/bsd-user/strace.c +++ b/bsd-user/strace.c @@ -128,14 +128,6 @@ static void

[PULL 13/20] bsd-user: whitespace changes

Fix various whitespace-only issues from checkpatch: keyword space ( no space before ( on function calls spaces around operators suspect indentations (including one functions reindented) extra spaces around unary operators Reviewed-by: Richard Henderson Signed-off-by: Warner

[PULL 02/20] bsd-user: style tweak: use C not C++ comments

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 079520737b..5253ceb24b 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -147,7 +147,7

[PULL 01/20] bsd-user: whitespace changes

Space after keywords, no space for function calls and spaces around operators. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/bsd-user/main.c b/bsd-user

[PULL 15/20] bsd-user: style tweak: keyword space (

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/uaccess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsd-user/uaccess.c b/bsd-user/uaccess.c index 91e2067933..89163257f4 100644 --- a/bsd-user/uaccess.c +++ b/bsd-user/uaccess.c @@ -46,7 +46,7

[PULL 20/20] bsd-user: rename linux_binprm to bsd_binprm

Rename linux_binprm to bsd_binprm to reflect that we're loading BSD binaries, not ELF ones. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/bsdload.c | 4 ++-- bsd-user/elfload.c | 4 ++-- bsd-user/qemu.h| 6 +++--- 3 files changed, 7 insertions(+), 7 deletions

[PULL 19/20] bsd-user: Stop building the sparc targets

to review and satisfy that all revisions of a patch series are buildable. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- default-configs/targets/sparc-bsd-user.mak | 3 --- default-configs/targets/sparc64-bsd-user.mak | 4 2 files changed, 7 deletions(-) delete mode 100644

[PULL 09/20] bsd-user: style tweak: don't assign in if statements

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/qemu.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index 7f3cfa68aa..2494d9209d 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -288,7 +288,8 @@ static

[PULL 07/20] bsd-user: style tweak: remove spacing after '*' and add after }

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/qemu.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index 5a82722281..de20e8329a 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -124,19

[PULL 05/20] bsd-user: Remove commented out code

Remove dead code that's been commented out forever. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/qemu.h | 4 1 file changed, 4 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index b836b603af..7ccc8ad397 100644 --- a/bsd-user/qemu.h +++ b/bsd-user

[PULL 14/20] bsd-user: style tweak: keyword space (

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/syscall.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 4abff796c7..7d986e9700 100644 --- a/bsd-user/syscall.c +++ b/bsd-user/syscall.c

[PULL 17/20] bsd-user: style tweak: keyword space (

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/mmap.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/bsd-user/mmap.c b/bsd-user/mmap.c index 01ec808003..0ac1b92706 100644 --- a/bsd-user/mmap.c +++ b/bsd-user/mmap.c @@ -93,11

[PULL 04/20] bsd-user: style tweak: Use preferred block comments

Use the preferred block comment style. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index c342dd7829..cd1c26516b 100644

[PULL 11/20] bsd-user: style tweak: use {} consistently in for / if / else statements

Fix various issues with {} not being present on if / for statements. Minor line length tweaks Move an assignment in an if out. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 66 - 1 file changed, 43 insertions

[PULL 12/20] bsd-user: use qemu_strtoul in preference to strtol

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/main.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 0f9e6bfbc0..18f806b032 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -36,6 +36,7

Re: [PATCH v2 6/6] gitlab-ci: Add FreeBSD jobs

typo below. Fix that and it's Reviewed by: Warner Losh I can't wait to use it... Warner > diff --git a/.gitlab-ci.d/buildtest-freebsd.yml > b/.gitlab-ci.d/buildtest-freebsd.yml > new file mode 100644 > index 000..683e815afbf > --- /dev/null > +++ b/.gitlab-ci.d/buildtes

Re: [PATCH v2] tcg: Use correct trap number for page faults on *BSD systems

On Fri, May 14, 2021 at 6:23 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 5/6/21 12:53 PM, Warner Losh wrote: > > > > > > On Thu, May 6, 2021 at 11:51 AM Richard Henderson < > richard.hender...@linaro.org > > <mailto:richard.hender...

Re: [PATCH v3 2/6] gitlab-ci: Adapt JOBS variable for FreeBSD runners

On Thu, May 20, 2021 at 12:18 PM Wainer dos Santos Moschetta < waine...@redhat.com> wrote: > Hi, > > On 5/19/21 3:45 PM, Philippe Mathieu-Daudé wrote: > > 'nproc' is not available on FreeBSD: > > > >$ JOBS=$(expr $(nproc) + 1) > >bash: line 119: nproc: command not found > >expr:

Re: Qemu on Haiku

On Fri, Jun 25, 2021 at 8:45 PM Richard Zak wrote: > Hello and thanks for the detailed response! I wasn't aware that a Linux > host could compile for Haiku as a target, that's interesting. > > Seems like the big tasks are: > 1) Haiku VM for continuous integration. Is this hosted in Amazon or

Re: [PULL 15/24] bsd-user: Fix commentary issues

On Mon, Apr 26, 2021 at 3:13 AM Peter Maydell wrote: > On Mon, 26 Apr 2021 at 10:01, Daniel P. Berrangé > wrote: > > > > On Fri, Apr 23, 2021 at 02:39:50PM -0600, i...@bsdimp.com wrote: > > > -#define TARGET_FREEBSD_MAP_RESERVED0080 0x0080 /* previously > misimplemented MAP_INHERIT */ > > >

[PULL 1/5] bsd-user: whitespace changes

keyword space paren, no space before ( in function calls, spaces around operators. Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/bsdload.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/bsd-user/bsdload.c b/bsd

[PULL 5/5] bsd-user: style tweak: Put {} around all if/else/for statements

Reviewed-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/bsdload.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/bsd-user/bsdload.c b/bsd-user/bsdload.c index fd14ffa4cd..e1ed3b7b60 100644 --- a/bsd-user/bsdload.c +++ b/bsd-user/bsdload.c

  1   2   3   4   5   6   7   8   9   10   >