Re: [Qemu-devel] [PATCH v2 0/2] Produce better termination message

2016-09-21 Thread Paolo Bonzini 


On 21/09/2016 13:26, Michal Privoznik wrote:
> v2 of:
> 
> http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg04710.html
> 
> The checkpatch.pl shows the following error for 1/2:
> 
>   ERROR: architecture specific defines should be avoided
>   #63: FILE: util/oslib-posix.c:441:
>   +#if defined(__FreeBSD__)
> 
> But I guess we should ignore the error, since in this case we
> want OS specific code.

Yeah, this should probably be degraded to WARN.

> diff to v1:
> - Reworked 1/2 to follow Paolo's review suggestions
> - Produce "()" instead of "()" in 2/2 in case
>   the PID is unknown.
> 
> Michal Privoznik (2):
>   util: Introduce qemu_get_pid_name
>   qemu_kill_report: Report PID name too
> 
>  include/qemu/osdep.h | 10 ++
>  util/oslib-posix.c   | 37 +
>  util/oslib-win32.c   |  7 +++
>  vl.c |  8 ++--
>  4 files changed, 60 insertions(+), 2 deletions(-)
> 

Looks good, thanks.

Paolo

Re: [Qemu-devel] [PATCH v2 0/2] Produce better termination message

2016-09-21 Thread no-reply 
Hi,

Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.

Type: series
Message-id: cover.1474456806.git.mpriv...@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/2] Produce better termination message

=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
make J=8 docker-test-quick@centos6
make J=8 docker-test-mingw@fedora
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/cover.1474456806.git.mpriv...@redhat.com -> 
patchew/cover.1474456806.git.mpriv...@redhat.com
Switched to a new branch 'test'
0b5fc6f qemu_kill_report: Report PID name too
be88199 util: Introduce qemu_get_pid_name

=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf'
  BUILD centos6
  ARCHIVE qemu.tgz
  ARCHIVE dtc.tgz
  COPY RUNNER
  RUN test-quick in centos6
No C++ compiler available; disabling C++ specific optional code
Install prefix/tmp/qemu-test/src/tests/docker/install
BIOS directory/tmp/qemu-test/src/tests/docker/install/share/qemu
binary directory  /tmp/qemu-test/src/tests/docker/install/bin
library directory /tmp/qemu-test/src/tests/docker/install/lib
module directory  /tmp/qemu-test/src/tests/docker/install/lib/qemu
libexec directory /tmp/qemu-test/src/tests/docker/install/libexec
include directory /tmp/qemu-test/src/tests/docker/install/include
config directory  /tmp/qemu-test/src/tests/docker/install/etc
local state directory   /tmp/qemu-test/src/tests/docker/install/var
Manual directory  /tmp/qemu-test/src/tests/docker/install/share/man
ELF interp prefix /usr/gnemul/qemu-%M
Source path   /tmp/qemu-test/src
C compilercc
Host C compiler   cc
C++ compiler  
Objective-C compiler cc
ARFLAGS   rv
CFLAGS-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -pthread 
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -g 
QEMU_CFLAGS   -I/usr/include/pixman-1-fPIE -DPIE -m64 -D_GNU_SOURCE 
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes 
-Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes 
-fno-strict-aliasing -fno-common -fwrapv  -Wendif-labels -Wmissing-include-dirs 
-Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self 
-Wignored-qualifiers -Wold-style-declaration -Wold-style-definition 
-Wtype-limits -fstack-protector-all
LDFLAGS   -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g 
make  make
install   install
pythonpython -B
smbd  /usr/sbin/smbd
module supportno
host CPU  x86_64
host big endian   no
target list   x86_64-softmmu aarch64-softmmu
tcg debug enabled no
gprof enabled no
sparse enabledno
strip binariesyes
profiler  no
static build  no
pixmansystem
SDL support   yes (1.2.14)
GTK support   no 
GTK GL supportno
VTE support   no 
TLS priority  NORMAL
GNUTLS supportno
GNUTLS rndno
libgcrypt no
libgcrypt kdf no
nettleno 
nettle kdfno
libtasn1  no
curses supportno
virgl support no
curl support  no
mingw32 support   no
Audio drivers oss
Block whitelist (rw) 
Block whitelist (ro) 
VirtFS supportno
VNC support   yes
VNC SASL support  no
VNC JPEG support  no
VNC PNG support   no
xen support   no
brlapi supportno
bluez  supportno
Documentation no
PIE   yes
vde support   no
netmap supportno
Linux AIO support no
ATTR/XATTR support yes
Install blobs yes
KVM support   yes
RDMA support  no
TCG interpreter   no
fdt support   yes
preadv supportyes
fdatasync yes
madvise   yes
posix_madvise yes
uuid support  no
libcap-ng support no
vhost-net support yes
vhost-scsi support yes
vhost-vsock support yes
Trace backendslog
spice support no 
rbd support   no
xfsctl supportno
smartcard support no
libusbno
usb net redir no
OpenGL supportno
OpenGL dmabufsno
libiscsi support  no
libnfs supportno
build guest agent yes
QGA VSS support   no
QGA w32 disk info no
QGA MSI support   no
seccomp support   no
coroutine backend ucontext
coroutine poolyes
GlusterFS support no
Archipelago support no
gcov  gcov
gcov enabled  no
TPM support   yes
libssh2 support   no
TPM passthrough   yes
QOM debugging yes
vhdx  no
lzo support   no
snappy supportno
bzip2 support no
NUMA host support no
tcmalloc support  no
jemalloc support  no
avx2 optimization no
replication support yes
  GEN   x86_64-softmmu/config-devices.mak.tmp
  GEN   aarch64-softmmu/config-devices.mak.tmp
  GEN   config-host.h
  GEN   qemu-options.def
  GEN

Re: [Qemu-devel] [PATCH v2 0/2] Produce better termination message

2016-09-21 Thread no-reply 
Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: cover.1474456806.git.mpriv...@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/2] Produce better termination message

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0b5fc6f qemu_kill_report: Report PID name too
be88199 util: Introduce qemu_get_pid_name

=== OUTPUT BEGIN ===
Checking PATCH 1/2: util: Introduce qemu_get_pid_name...
ERROR: architecture specific defines should be avoided
#56: FILE: util/oslib-posix.c:441:
+#if defined(__FreeBSD__)

total: 1 errors, 0 warnings, 78 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: qemu_kill_report: Report PID name too...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org

[Qemu-devel] [PATCH v2 0/2] Produce better termination message

2016-09-21 Thread Michal Privoznik 
v2 of:

http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg04710.html

The checkpatch.pl shows the following error for 1/2:

  ERROR: architecture specific defines should be avoided
  #63: FILE: util/oslib-posix.c:441:
  +#if defined(__FreeBSD__)

But I guess we should ignore the error, since in this case we
want OS specific code.

diff to v1:
- Reworked 1/2 to follow Paolo's review suggestions
- Produce "()" instead of "()" in 2/2 in case
  the PID is unknown.

Michal Privoznik (2):
  util: Introduce qemu_get_pid_name
  qemu_kill_report: Report PID name too

 include/qemu/osdep.h | 10 ++
 util/oslib-posix.c   | 37 +
 util/oslib-win32.c   |  7 +++
 vl.c |  8 ++--
 4 files changed, 60 insertions(+), 2 deletions(-)

-- 
2.8.4