[Qemu-devel] Re: [PATCH] Add support for async page fault to qemu

2010-10-18 Thread Juan Quintela
Gleb Natapov g...@redhat.com wrote:
 Add save/restore of MSR for migration and cpuid bit.

It is there a way to test if async page faults are in use?
if so, we can add a subsection instead of changing the cpuversion.

I think that at some point we are going to need a bitmap that indicates
what MSR's have been used or something like that.

What do you think?

Later, Juan.




[Qemu-devel] Re: [PATCH] Add support for async page fault to qemu

2010-10-18 Thread Avi Kivity

 On 10/18/2010 05:48 PM, Juan Quintela wrote:

Gleb Natapovg...@redhat.com  wrote:
  Add save/restore of MSR for migration and cpuid bit.

It is there a way to test if async page faults are in use?


Yes, msr != 0 - need a subsection.  Good idea.


if so, we can add a subsection instead of changing the cpuversion.

I think that at some point we are going to need a bitmap that indicates
what MSR's have been used or something like that.

What do you think?


We just need to check if an msr is different from its default value 
(which we can get by reading msrs immediately after the initial reset).


Currently the reset code assumes msr reset value is zero, that's wrong.

--
error compiling committee.c: too many arguments to function




[Qemu-devel] Re: [PATCH] Add support for async page fault to qemu

2010-10-18 Thread Gleb Natapov
On Mon, Oct 18, 2010 at 05:48:16PM +0200, Juan Quintela wrote:
 Gleb Natapov g...@redhat.com wrote:
  Add save/restore of MSR for migration and cpuid bit.
 
 It is there a way to test if async page faults are in use?
 if so, we can add a subsection instead of changing the cpuversion.
 
Yeah. Good idea. Forgot about our cool new subsection feature.

--
Gleb.