Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-02-16 Thread Stefan Hajnoczi
On Fri, Feb 10, 2023 at 05:08:16PM +0100, Juan Quintela wrote: > Anton Kuchin wrote: > > On 02/02/2023 11:59, Juan Quintela wrote: > >> Anton Kuchin wrote: > >>> On 01/02/2023 16:26, Juan Quintela wrote: > Anton Kuchin wrote: > > On 19/01/2023 18:02, Stefan Hajnoczi wrote: > >> On

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-02-10 Thread Juan Quintela
Anton Kuchin wrote: > On 02/02/2023 11:59, Juan Quintela wrote: >> Anton Kuchin wrote: >>> On 01/02/2023 16:26, Juan Quintela wrote: Anton Kuchin wrote: > On 19/01/2023 18:02, Stefan Hajnoczi wrote: >> On Thu, 19 Jan 2023 at 10:29, Anton Kuchin >> wrote: >>> On 19/01/2023

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-02-10 Thread Anton Kuchin
On 02/02/2023 11:59, Juan Quintela wrote: Anton Kuchin wrote: On 01/02/2023 16:26, Juan Quintela wrote: Anton Kuchin wrote: On 19/01/2023 18:02, Stefan Hajnoczi wrote: On Thu, 19 Jan 2023 at 10:29, Anton Kuchin wrote: On 19/01/2023 16:30, Stefan Hajnoczi wrote: On Thu, 19 Jan 2023 at

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-02-02 Thread Juan Quintela
Anton Kuchin wrote: > On 01/02/2023 16:26, Juan Quintela wrote: >> Anton Kuchin wrote: >>> On 19/01/2023 18:02, Stefan Hajnoczi wrote: On Thu, 19 Jan 2023 at 10:29, Anton Kuchin wrote: > On 19/01/2023 16:30, Stefan Hajnoczi wrote: >> On Thu, 19 Jan 2023 at 07:43, Anton Kuchin

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-02-01 Thread Anton Kuchin
On 01/02/2023 16:26, Juan Quintela wrote: Anton Kuchin wrote: On 19/01/2023 18:02, Stefan Hajnoczi wrote: On Thu, 19 Jan 2023 at 10:29, Anton Kuchin wrote: On 19/01/2023 16:30, Stefan Hajnoczi wrote: On Thu, 19 Jan 2023 at 07:43, Anton Kuchin wrote: On 18/01/2023 17:52, Stefan Hajnoczi

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-02-01 Thread Juan Quintela
Stefan Hajnoczi wrote: > On Tue, Jan 24, 2023, 04:50 Dr. David Alan Gilbert > wrote: [...] >> > I checked how bad the situation is. libvhost-user currently enables >> > LOG_ALL by default. :( >> > >> > So I don't think the front-end can use LOG_ALL alone to determine >> > whether or not

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-02-01 Thread Juan Quintela
Anton Kuchin wrote: > On 19/01/2023 18:02, Stefan Hajnoczi wrote: >> On Thu, 19 Jan 2023 at 10:29, Anton Kuchin >> wrote: >>> On 19/01/2023 16:30, Stefan Hajnoczi wrote: On Thu, 19 Jan 2023 at 07:43, Anton Kuchin wrote: > On 18/01/2023 17:52, Stefan Hajnoczi wrote: >> On

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-26 Thread Anton Kuchin
On 26/01/2023 17:13, Stefan Hajnoczi wrote: On Thu, 26 Jan 2023 at 09:20, Anton Kuchin wrote: On 25/01/2023 21:46, Stefan Hajnoczi wrote: On Sun, Jan 15, 2023 at 07:09:03PM +0200, Anton Kuchin wrote: Now any vhost-user-fs device makes VM unmigratable, that also prevents qemu update without

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-26 Thread Stefan Hajnoczi
On Thu, 26 Jan 2023 at 09:20, Anton Kuchin wrote: > > On 25/01/2023 21:46, Stefan Hajnoczi wrote: > > On Sun, Jan 15, 2023 at 07:09:03PM +0200, Anton Kuchin wrote: > >> Now any vhost-user-fs device makes VM unmigratable, that also prevents > >> qemu update without stopping the VM. In most cases

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-26 Thread Anton Kuchin
On 25/01/2023 21:46, Stefan Hajnoczi wrote: On Sun, Jan 15, 2023 at 07:09:03PM +0200, Anton Kuchin wrote: Now any vhost-user-fs device makes VM unmigratable, that also prevents qemu update without stopping the VM. In most cases that makes sense because qemu has no way to transfer FUSE session

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-25 Thread Stefan Hajnoczi
On Sun, Jan 15, 2023 at 07:09:03PM +0200, Anton Kuchin wrote: > Now any vhost-user-fs device makes VM unmigratable, that also prevents > qemu update without stopping the VM. In most cases that makes sense > because qemu has no way to transfer FUSE session state. > > But we can give an option to

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-24 Thread Stefan Hajnoczi
On Tue, Jan 24, 2023, 04:50 Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@gmail.com) wrote: > > On Mon, 23 Jan 2023 at 14:54, Stefan Hajnoczi > wrote: > > > > > > On Mon, Jan 23, 2023 at 06:27:23PM +, Dr. David Alan Gilbert wrote: > > > > * Michael S. Tsirkin (m...@redhat.com)

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-24 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Mon, 23 Jan 2023 at 14:54, Stefan Hajnoczi wrote: > > > > On Mon, Jan 23, 2023 at 06:27:23PM +, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > On Sun, Jan 22, 2023 at 06:09:40PM +0200, Anton Kuchin

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-23 Thread Stefan Hajnoczi
On Mon, 23 Jan 2023 at 14:54, Stefan Hajnoczi wrote: > > On Mon, Jan 23, 2023 at 06:27:23PM +, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Sun, Jan 22, 2023 at 06:09:40PM +0200, Anton Kuchin wrote: > > > > > > > > On 22/01/2023 16:46, Michael S.

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-23 Thread Stefan Hajnoczi
On Mon, Jan 23, 2023 at 04:00:50PM -0500, Michael S. Tsirkin wrote: > On Mon, Jan 23, 2023 at 02:49:39PM -0500, Stefan Hajnoczi wrote: > > The point of the migration blocker is to prevent breaking running > > guests. Situations where a migration completes but results in a broken > > guest are

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-23 Thread Michael S. Tsirkin
On Mon, Jan 23, 2023 at 02:49:39PM -0500, Stefan Hajnoczi wrote: > The point of the migration blocker is to prevent breaking running > guests. Situations where a migration completes but results in a broken > guest are problematic for users (especially when they are not logged in > to guests and

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-23 Thread Stefan Hajnoczi
On Mon, Jan 23, 2023 at 06:27:23PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Sun, Jan 22, 2023 at 06:09:40PM +0200, Anton Kuchin wrote: > > > > > > On 22/01/2023 16:46, Michael S. Tsirkin wrote: > > > > On Sun, Jan 22, 2023 at 02:36:04PM +0200,

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-23 Thread Stefan Hajnoczi
On Mon, Jan 23, 2023 at 05:52:17PM +0200, Anton Kuchin wrote: > > On 23/01/2023 16:09, Stefan Hajnoczi wrote: > > On Sun, 22 Jan 2023 at 11:18, Michael S. Tsirkin wrote: > > > On Sun, Jan 22, 2023 at 06:09:40PM +0200, Anton Kuchin wrote: > > > > On 22/01/2023 16:46, Michael S. Tsirkin wrote: > >

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-23 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Sun, Jan 22, 2023 at 06:09:40PM +0200, Anton Kuchin wrote: > > > > On 22/01/2023 16:46, Michael S. Tsirkin wrote: > > > On Sun, Jan 22, 2023 at 02:36:04PM +0200, Anton Kuchin wrote: > > > > > > This flag should be set when qemu don't need to

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-23 Thread Anton Kuchin
On 23/01/2023 16:09, Stefan Hajnoczi wrote: On Sun, 22 Jan 2023 at 11:18, Michael S. Tsirkin wrote: On Sun, Jan 22, 2023 at 06:09:40PM +0200, Anton Kuchin wrote: On 22/01/2023 16:46, Michael S. Tsirkin wrote: On Sun, Jan 22, 2023 at 02:36:04PM +0200, Anton Kuchin wrote: This flag should

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-23 Thread Stefan Hajnoczi
On Sun, 22 Jan 2023 at 11:18, Michael S. Tsirkin wrote: > > On Sun, Jan 22, 2023 at 06:09:40PM +0200, Anton Kuchin wrote: > > > > On 22/01/2023 16:46, Michael S. Tsirkin wrote: > > > On Sun, Jan 22, 2023 at 02:36:04PM +0200, Anton Kuchin wrote: > > > > > > This flag should be set when qemu don't

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-22 Thread Michael S. Tsirkin
On Sun, Jan 22, 2023 at 06:09:40PM +0200, Anton Kuchin wrote: > > On 22/01/2023 16:46, Michael S. Tsirkin wrote: > > On Sun, Jan 22, 2023 at 02:36:04PM +0200, Anton Kuchin wrote: > > > > > This flag should be set when qemu don't need to worry about any > > > > > external state stored in

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-22 Thread Anton Kuchin
On 22/01/2023 16:46, Michael S. Tsirkin wrote: On Sun, Jan 22, 2023 at 02:36:04PM +0200, Anton Kuchin wrote: This flag should be set when qemu don't need to worry about any external state stored in vhost-user daemons during migration: don't fail migration, just pack generic virtio device

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-22 Thread Michael S. Tsirkin
On Sun, Jan 22, 2023 at 02:36:04PM +0200, Anton Kuchin wrote: > > > This flag should be set when qemu don't need to worry about any > > > external state stored in vhost-user daemons during migration: > > > don't fail migration, just pack generic virtio device states to > > > migration stream and

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-22 Thread Anton Kuchin
On 22/01/2023 10:16, Michael S. Tsirkin wrote: On Fri, Jan 20, 2023 at 07:37:18PM +0200, Anton Kuchin wrote: On 20/01/2023 15:58, Michael S. Tsirkin wrote: On Thu, Jan 19, 2023 at 03:45:06PM +0200, Anton Kuchin wrote: On 19/01/2023 14:51, Michael S. Tsirkin wrote: On Sun, Jan 15, 2023 at

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-22 Thread Michael S. Tsirkin
On Fri, Jan 20, 2023 at 07:37:18PM +0200, Anton Kuchin wrote: > On 20/01/2023 15:58, Michael S. Tsirkin wrote: > > On Thu, Jan 19, 2023 at 03:45:06PM +0200, Anton Kuchin wrote: > > > On 19/01/2023 14:51, Michael S. Tsirkin wrote: > > > > On Sun, Jan 15, 2023 at 07:09:03PM +0200, Anton Kuchin

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-20 Thread Anton Kuchin
On 20/01/2023 15:58, Michael S. Tsirkin wrote: On Thu, Jan 19, 2023 at 03:45:06PM +0200, Anton Kuchin wrote: On 19/01/2023 14:51, Michael S. Tsirkin wrote: On Sun, Jan 15, 2023 at 07:09:03PM +0200, Anton Kuchin wrote: Now any vhost-user-fs device makes VM unmigratable, that also prevents qemu

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-20 Thread Michael S. Tsirkin
On Thu, Jan 19, 2023 at 03:45:06PM +0200, Anton Kuchin wrote: > On 19/01/2023 14:51, Michael S. Tsirkin wrote: > > On Sun, Jan 15, 2023 at 07:09:03PM +0200, Anton Kuchin wrote: > > > Now any vhost-user-fs device makes VM unmigratable, that also prevents > > > qemu update without stopping the VM.

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-19 Thread Anton Kuchin
On 19/01/2023 21:00, Dr. David Alan Gilbert wrote: * Anton Kuchin (antonkuc...@yandex-team.ru) wrote: On 19/01/2023 14:51, Michael S. Tsirkin wrote: On Sun, Jan 15, 2023 at 07:09:03PM +0200, Anton Kuchin wrote: Now any vhost-user-fs device makes VM unmigratable, that also prevents qemu

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-19 Thread Stefan Hajnoczi
On Thu, 19 Jan 2023 at 11:58, Anton Kuchin wrote: > > On 19/01/2023 18:02, Stefan Hajnoczi wrote: > > On Thu, 19 Jan 2023 at 10:29, Anton Kuchin > > wrote: > >> On 19/01/2023 16:30, Stefan Hajnoczi wrote: > >>> On Thu, 19 Jan 2023 at 07:43, Anton Kuchin > >>> wrote: > On 18/01/2023

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-19 Thread Dr. David Alan Gilbert
* Anton Kuchin (antonkuc...@yandex-team.ru) wrote: > On 19/01/2023 14:51, Michael S. Tsirkin wrote: > > On Sun, Jan 15, 2023 at 07:09:03PM +0200, Anton Kuchin wrote: > > > Now any vhost-user-fs device makes VM unmigratable, that also prevents > > > qemu update without stopping the VM. In most

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-19 Thread Anton Kuchin
On 19/01/2023 18:02, Stefan Hajnoczi wrote: On Thu, 19 Jan 2023 at 10:29, Anton Kuchin wrote: On 19/01/2023 16:30, Stefan Hajnoczi wrote: On Thu, 19 Jan 2023 at 07:43, Anton Kuchin wrote: On 18/01/2023 17:52, Stefan Hajnoczi wrote: On Sun, 15 Jan 2023 at 12:21, Anton Kuchin wrote: Now

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-19 Thread Stefan Hajnoczi
On Thu, 19 Jan 2023 at 10:29, Anton Kuchin wrote: > > On 19/01/2023 16:30, Stefan Hajnoczi wrote: > > On Thu, 19 Jan 2023 at 07:43, Anton Kuchin > > wrote: > >> On 18/01/2023 17:52, Stefan Hajnoczi wrote: > >>> On Sun, 15 Jan 2023 at 12:21, Anton Kuchin > >>> wrote: > Now any

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-19 Thread Anton Kuchin
On 19/01/2023 16:30, Stefan Hajnoczi wrote: On Thu, 19 Jan 2023 at 07:43, Anton Kuchin wrote: On 18/01/2023 17:52, Stefan Hajnoczi wrote: On Sun, 15 Jan 2023 at 12:21, Anton Kuchin wrote: Now any vhost-user-fs device makes VM unmigratable, that also prevents qemu update without stopping the

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-19 Thread Stefan Hajnoczi
On Thu, 19 Jan 2023 at 07:43, Anton Kuchin wrote: > > On 18/01/2023 17:52, Stefan Hajnoczi wrote: > > On Sun, 15 Jan 2023 at 12:21, Anton Kuchin > > wrote: > >> Now any vhost-user-fs device makes VM unmigratable, that also prevents > >> qemu update without stopping the VM. In most cases that

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-19 Thread Anton Kuchin
On 19/01/2023 14:51, Michael S. Tsirkin wrote: On Sun, Jan 15, 2023 at 07:09:03PM +0200, Anton Kuchin wrote: Now any vhost-user-fs device makes VM unmigratable, that also prevents qemu update without stopping the VM. In most cases that makes sense because qemu has no way to transfer FUSE

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-19 Thread Michael S. Tsirkin
On Sun, Jan 15, 2023 at 07:09:03PM +0200, Anton Kuchin wrote: > Now any vhost-user-fs device makes VM unmigratable, that also prevents > qemu update without stopping the VM. In most cases that makes sense > because qemu has no way to transfer FUSE session state. > > But we can give an option to

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-19 Thread Anton Kuchin
On 18/01/2023 17:52, Stefan Hajnoczi wrote: On Sun, 15 Jan 2023 at 12:21, Anton Kuchin wrote: Now any vhost-user-fs device makes VM unmigratable, that also prevents qemu update without stopping the VM. In most cases that makes sense because qemu has no way to transfer FUSE session state. But

Re: [PATCH] vhost-user-fs: add capability to allow migration

2023-01-18 Thread Stefan Hajnoczi
On Sun, 15 Jan 2023 at 12:21, Anton Kuchin wrote: > > Now any vhost-user-fs device makes VM unmigratable, that also prevents > qemu update without stopping the VM. In most cases that makes sense > because qemu has no way to transfer FUSE session state. > > But we can give an option to