Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

>> s390x: Fix query-cpu-model-FOO error API violations >> >> cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(), >> qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It >> dereferences @errp when the visitor or the QOM setter fails. That's >>

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

On Tue, 03 Dec 2019 08:49:58 +0100 Markus Armbruster wrote: > Cornelia Huck writes: > > > On Sat, 30 Nov 2019 20:42:36 +0100 > > Markus Armbruster wrote: > > > > I don't really want to restart the discussion :), but what about: > > > >> cpu_model_from_info() is a helper for

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

Cornelia Huck writes: > On Sat, 30 Nov 2019 20:42:36 +0100 > Markus Armbruster wrote: > > I don't really want to restart the discussion :), but what about: > >> cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(), >> qmp_query_cpu_model_comparison(),

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

David Hildenbrand writes: > [...] > >> First search hit. Here's my second one: >> >> Q: What are latent bugs? >> >> A: These bugs do not cause problems today. However, they are lurking >> just waiting to reveal themselves later. The Ariane 5 rocket >> failure was caused by a

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

On Sat, 30 Nov 2019 20:42:36 +0100 Markus Armbruster wrote: I don't really want to restart the discussion :), but what about: > cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(), > qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It > crashes when the

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

[...] > First search hit. Here's my second one: > > Q: What are latent bugs? > > A: These bugs do not cause problems today. However, they are lurking > just waiting to reveal themselves later. The Ariane 5 rocket > failure was caused by a float->int conversion error that lay

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

David Hildenbrand writes: > On 01.12.19 14:46, Aleksandar Markovic wrote: >> >> >> On Saturday, November 30, 2019, David Hildenbrand > > wrote: >> >> >> >> > Am 30.11.2019 um 20:42 schrieb Markus Armbruster >> mailto:arm...@redhat.com>>: >> > >> >

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

On Sunday, December 1, 2019, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Sunday, December 1, 2019, Aleksandar Markovic < > aleksandar.m.m...@gmail.com> wrote: > >> >> >> On Saturday, November 30, 2019, David Hildenbrand >> wrote: >> >>> >>> >>> > Am 30.11.2019 um 20:42

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

On 01.12.19 14:46, Aleksandar Markovic wrote: > > > On Saturday, November 30, 2019, David Hildenbrand > wrote: > > > > > Am 30.11.2019 um 20:42 schrieb Markus Armbruster > mailto:arm...@redhat.com>>: > > > > cpu_model_from_info() is a helper for >

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

On Sunday, December 1, 2019, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Saturday, November 30, 2019, David Hildenbrand > wrote: > >> >> >> > Am 30.11.2019 um 20:42 schrieb Markus Armbruster : >> > >> > cpu_model_from_info() is a helper for

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

On Saturday, November 30, 2019, David Hildenbrand wrote: > > > > Am 30.11.2019 um 20:42 schrieb Markus Armbruster : > > > > cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(), > > qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It > > crashes when the

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

> Am 30.11.2019 um 20:42 schrieb Markus Armbruster : > > cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(), > qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It > crashes when the visitor or the QOM setter fails, and its @errp > argument is null. Messed