>> s390x: Fix query-cpu-model-FOO error API violations >> >> cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(), >> qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It >> dereferences @errp when the visitor or the QOM setter fails. That's >> wrong; see the big comment in error.h. Introduced in commit >> 137974cea3 's390x/cpumodel: implement QMP interface >> "query-cpu-model-expansion"'. >> >> Its three callers have the same issue. Introduced in commit >> 4e82ef0502 's390x/cpumodel: implement QMP interface >> "query-cpu-model-comparison"' and commit f1a47d08ef 's390x/cpumodel: >> implement QMP interface "query-cpu-model-baseline"'. >> >> No caller actually passes null. To fix, splice in a local Error *err, >> and error_propagate(). >> >> Cc: David Hildenbrand <da...@redhat.com> >> Cc: Cornelia Huck <coh...@redhat.com> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > That sounds good to me.
Yes, something I would have enjoyed reading from the first sentence. Reviewed-by: David Hildenbrand <da...@redhat.com> -- Thanks, David / dhildenb
