On 11.02.20 16:41, Alberto Garcia wrote:
> On Tue 04 Feb 2020 06:08:18 PM CET, Max Reitz wrote:
>> +/* Child to COW from (backing child) */
>> +BDRV_CHILD_COW = (1 << 3),
>
> Without the comment in brackets I'm not sure that I would have
> understood that this is meant for
On Tue 04 Feb 2020 06:08:18 PM CET, Max Reitz wrote:
> +/* Child to COW from (backing child) */
> +BDRV_CHILD_COW = (1 << 3),
Without the comment in brackets I'm not sure that I would have
understood that this is meant for backing files.
This is the "child that contains the data
On 2/6/20 4:49 AM, Max Reitz wrote:
+
+ /* Filtered child */
+ BDRV_CHILD_FILTERED = (1 << 2),
I'm not sure this comment does justice for what the flag represents, but
am not sure of what longer comment to put in its place.
You’re right. I thought I could just rely on our
On 06.02.20 11:47, Max Reitz wrote:
> On 05.02.20 16:24, Eric Blake wrote:
>> On 2/4/20 11:08 AM, Max Reitz wrote:
>>> This enum will supplement BdrvChildClass when it comes to what role (or
>>> combination of roles) a child takes for its parent.
>>>
>>> Because empty enums are not allowed, let us
On 05.02.20 16:24, Eric Blake wrote:
> On 2/4/20 11:08 AM, Max Reitz wrote:
>> This enum will supplement BdrvChildClass when it comes to what role (or
>> combination of roles) a child takes for its parent.
>>
>> Because empty enums are not allowed, let us just start with it filled.
>>
>>
On 2/4/20 11:08 AM, Max Reitz wrote:
This enum will supplement BdrvChildClass when it comes to what role (or
combination of roles) a child takes for its parent.
Because empty enums are not allowed, let us just start with it filled.
Signed-off-by: Max Reitz
---
include/block/block.h | 27
