Re: [Qemu-devel] [PATCH 0/3] QAPI file renames

2018-02-12 Thread Eric Blake

On 02/11/2018 03:44 AM, Markus Armbruster wrote:

Eric Blake  writes:


This has been mentioned on list before as a possible improvement,
so I went ahead and did some renames to figure out how it would
look.  Patch 1 is something I hit on the way while debugging
patch 2 and 3; patch 2 is rather non-controversial, and patch 3
may or may not be worth doing (but if we do it, it is going
to cause a lot of rebase churn to anyone editing files in the
meantime, although git rename detection will probably get things
right more often than not).


Conflicts with my "[PATCH v2 00/29] Modularize generated QAPI code".
Your series is much smaller.  Would you mind rebasing it?


Of course, yours definitely goes in first.  And let me know if I need to 
take care of some pull requests, based on your current situation.


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



Re: [Qemu-devel] [PATCH 0/3] QAPI file renames

2018-02-11 Thread Markus Armbruster
Eric Blake  writes:

> This has been mentioned on list before as a possible improvement,
> so I went ahead and did some renames to figure out how it would
> look.  Patch 1 is something I hit on the way while debugging
> patch 2 and 3; patch 2 is rather non-controversial, and patch 3
> may or may not be worth doing (but if we do it, it is going
> to cause a lot of rebase churn to anyone editing files in the
> meantime, although git rename detection will probably get things
> right more often than not).

Conflicts with my "[PATCH v2 00/29] Modularize generated QAPI code".
Your series is much smaller.  Would you mind rebasing it?