Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
Eric Blake writes:
> On 08/08/2017 04:20 AM, Markus Armbruster wrote:
>> Just back from the signed-vs-unsigned swamp, still catching up, sorry
>> for the delay...
>>
>
File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py",
line 160, in texi_members
items += member_func(section.member) + desc + '\n'
File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py",
line 133, in texi_enum_value
return '@item @code{%s}\n' % value.name
AttributeError: 'NoneType' object has no attribute 'name'
>>>
>>> Eww, we have a bug in our qapi generator (a stack dump instead of a nice
>>> error message). I suspect this is caused by your use of '@ac_*' instead
>>> of spelling out all the ac_ members added in qapi-schema.json in 4/5 -
>>
>> Yes, we require doc comments to match the schema. Wildcards aren't
>> supported. They could be, if we want them badly enough.
>>
>>> but it IS something that needs to be fixed on your end to quit tripping
>>> up the doc generator.
>>
>> Has anyone worked on a fix for qapi2texi.py?
>
> We worked around the generator bug in the meantime, so the qapi2texi.py
> bug is still latent (sadly, it's not my highest priority)
Marc-André, can you have a look perhaps?
Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
On 08/08/2017 04:20 AM, Markus Armbruster wrote:
> Just back from the signed-vs-unsigned swamp, still catching up, sorry
> for the delay...
>
>>> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py",
>>> line 160, in texi_members
>>> items += member_func(section.member) + desc + '\n'
>>> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py",
>>> line 133, in texi_enum_value
>>> return '@item @code{%s}\n' % value.name
>>> AttributeError: 'NoneType' object has no attribute 'name'
>>
>> Eww, we have a bug in our qapi generator (a stack dump instead of a nice
>> error message). I suspect this is caused by your use of '@ac_*' instead
>> of spelling out all the ac_ members added in qapi-schema.json in 4/5 -
>
> Yes, we require doc comments to match the schema. Wildcards aren't
> supported. They could be, if we want them badly enough.
>
>> but it IS something that needs to be fixed on your end to quit tripping
>> up the doc generator.
>
> Has anyone worked on a fix for qapi2texi.py?
We worked around the generator bug in the meantime, so the qapi2texi.py
bug is still latent (sadly, it's not my highest priority)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
Just back from the signed-vs-unsigned swamp, still catching up, sorry
for the delay...
Eric Blake writes:
> On 07/26/2017 07:09 AM, no-re...@patchew.org wrote:
>> Hi,
>>
>> This series failed build test on s390x host. Please find the details below.
>>
>> Message-id: 20170726115637.21558-1-kra...@redhat.com
>> Subject: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
>> Type: series
>>
>
>> GEN docs/interop/qemu-ga-qapi.texi
>> GEN qga/qapi-generated/qga-qapi-visit.h
>> GEN qga/qapi-generated/qga-qmp-commands.h
>> GEN qga/qapi-generated/qga-qapi-types.h
>> GEN qga/qapi-generated/qga-qapi-types.c
>> GEN qga/qapi-generated/qga-qapi-visit.c
>> GEN qga/qapi-generated/qga-qmp-marshal.c
>> Traceback (most recent call last):
>> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
>> 300, in
>> main(sys.argv)
>> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
>> 296, in main
>> print texi_schema(schema)
>> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
>> 279, in texi_schema
>> gen.symbol(doc, schema.lookup_entity(doc.symbol))
>> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
>> 263, in symbol
>> entity.visit(self)
>> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi.py", line
>> 1137, in visit
>> self.member_names(), self.prefix)
>> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
>> 218, in visit_enum_type
>> member_func=texi_enum_value))
>> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
>> 200, in texi_entity
>> + texi_sections(doc))
>> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
>> 160, in texi_members
>> items += member_func(section.member) + desc + '\n'
>> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
>> 133, in texi_enum_value
>> return '@item @code{%s}\n' % value.name
>> AttributeError: 'NoneType' object has no attribute 'name'
>
> Eww, we have a bug in our qapi generator (a stack dump instead of a nice
> error message). I suspect this is caused by your use of '@ac_*' instead
> of spelling out all the ac_ members added in qapi-schema.json in 4/5 -
Yes, we require doc comments to match the schema. Wildcards aren't
supported. They could be, if we want them badly enough.
> but it IS something that needs to be fixed on your end to quit tripping
> up the doc generator.
Has anyone worked on a fix for qapi2texi.py?
Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
On 07/26/2017 07:49 AM, Gerd Hoffmann wrote: > Hi, > >> error message). I suspect this is caused by your use of '@ac_*' >> instead >> of spelling out all the ac_ members added in qapi-schema.json in 4/5 >> - > > Hmm, adding them all will be a pretty long list, and it will probably > become alot longer when we add more missing keys in 2.11 ... > > Should this maybe summarized along the lines of "# multimedia keys > added in 2.10"? I'm not sure what the doc-generator will insist on, but avoiding the @name form may be sufficient. I agree that for this particular enum, the lists get quite long, so abbreviating may make sense, but at the same time, being precise may be more useful for someone trying to grep documentation. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
Hi, > error message). I suspect this is caused by your use of '@ac_*' > instead > of spelling out all the ac_ members added in qapi-schema.json in 4/5 > - Hmm, adding them all will be a pretty long list, and it will probably become alot longer when we add more missing keys in 2.11 ... Should this maybe summarized along the lines of "# multimedia keys added in 2.10"? cheers, Gerd
Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
On 07/26/2017 07:09 AM, no-re...@patchew.org wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
>
> Message-id: 20170726115637.21558-1-kra...@redhat.com
> Subject: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
> Type: series
>
> GEN docs/interop/qemu-ga-qapi.texi
> GEN qga/qapi-generated/qga-qapi-visit.h
> GEN qga/qapi-generated/qga-qmp-commands.h
> GEN qga/qapi-generated/qga-qapi-types.h
> GEN qga/qapi-generated/qga-qapi-types.c
> GEN qga/qapi-generated/qga-qapi-visit.c
> GEN qga/qapi-generated/qga-qmp-marshal.c
> Traceback (most recent call last):
> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
> 300, in
> main(sys.argv)
> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
> 296, in main
> print texi_schema(schema)
> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
> 279, in texi_schema
> gen.symbol(doc, schema.lookup_entity(doc.symbol))
> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
> 263, in symbol
> entity.visit(self)
> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi.py", line 1137,
> in visit
> self.member_names(), self.prefix)
> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
> 218, in visit_enum_type
> member_func=texi_enum_value))
> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
> 200, in texi_entity
> + texi_sections(doc))
> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
> 160, in texi_members
> items += member_func(section.member) + desc + '\n'
> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line
> 133, in texi_enum_value
> return '@item @code{%s}\n' % value.name
> AttributeError: 'NoneType' object has no attribute 'name'
Eww, we have a bug in our qapi generator (a stack dump instead of a nice
error message). I suspect this is caused by your use of '@ac_*' instead
of spelling out all the ac_ members added in qapi-schema.json in 4/5 -
but it IS something that needs to be fixed on your end to quit tripping
up the doc generator.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
Hi, This series failed build test on s390x host. Please find the details below. Message-id: 20170726115637.21558-1-kra...@redhat.com Subject: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10 Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e echo "=== ENV ===" env echo "=== PACKAGES ===" rpm -qa echo "=== TEST BEGIN ===" CC=$HOME/bin/cc INSTALL=$PWD/install BUILD=$PWD/build echo -n "Using CC: " realpath $CC mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable clean up # make check -j4 V=1 make install === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20170724182751.18261-1-f4...@amsat.org -> patchew/20170724182751.18261-1-f4...@amsat.org - [tag update] patchew/20170725153330.14966-1-coh...@redhat.com -> patchew/20170725153330.14966-1-coh...@redhat.com * [new tag] patchew/20170726115637.21558-1-kra...@redhat.com -> patchew/20170726115637.21558-1-kra...@redhat.com Switched to a new branch 'test' d479f54 ps2: enable multimedia keys f58b5bd ui: add multimedia keys 3534739 ui: update keymaps 6dab999 ui: move qemu_input_linux_to_qcode() 8087dbf ui: add next and prior keysyms === OUTPUT BEGIN === === ENV === XDG_SESSION_ID=167835 SHELL=/bin/sh USER=fam PATCHEW=/home/fam/patchew/patchew-cli -s http://patchew.org --nodebug PATH=/usr/bin:/bin PWD=/var/tmp/patchew-tester-tmp-xs4657r8/src LANG=en_US.UTF-8 HOME=/home/fam SHLVL=2 LOGNAME=fam DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1012/bus XDG_RUNTIME_DIR=/run/user/1012 _=/usr/bin/env === PACKAGES === gpg-pubkey-873529b8-54e386ff xz-libs-5.2.2-2.fc24.s390x libxshmfence-1.2-3.fc24.s390x giflib-4.1.6-15.fc24.s390x trousers-lib-0.3.13-6.fc24.s390x ncurses-base-6.0-6.20160709.fc25.noarch gmp-6.1.1-1.fc25.s390x libidn-1.33-1.fc25.s390x slang-2.3.0-7.fc25.s390x libsemanage-2.5-8.fc25.s390x pkgconfig-0.29.1-1.fc25.s390x alsa-lib-1.1.1-2.fc25.s390x yum-metadata-parser-1.1.4-17.fc25.s390x python3-slip-dbus-0.6.4-4.fc25.noarch python2-cssselect-0.9.2-1.fc25.noarch python-fedora-0.8.0-2.fc25.noarch createrepo_c-libs-0.10.0-6.fc25.s390x initscripts-9.69-1.fc25.s390x wget-1.18-2.fc25.s390x dhcp-client-4.3.5-1.fc25.s390x parted-3.2-21.fc25.s390x flex-2.6.0-3.fc25.s390x colord-libs-1.3.4-1.fc25.s390x python-osbs-client-0.33-3.fc25.noarch perl-Pod-Simple-3.35-1.fc25.noarch python2-simplejson-3.10.0-1.fc25.s390x brltty-5.4-2.fc25.s390x librados2-10.2.4-2.fc25.s390x tcp_wrappers-7.6-83.fc25.s390x libcephfs_jni1-10.2.4-2.fc25.s390x nettle-devel-3.3-1.fc25.s390x bzip2-devel-1.0.6-21.fc25.s390x libuuid-2.28.2-2.fc25.s390x pango-1.40.4-1.fc25.s390x python3-dnf-1.1.10-6.fc25.noarch cryptsetup-libs-1.7.4-1.fc25.s390x texlive-kpathsea-doc-svn41139-33.fc25.1.noarch netpbm-10.77.00-3.fc25.s390x openssh-7.4p1-4.fc25.s390x texlive-kpathsea-bin-svn40473-33.20160520.fc25.1.s390x texlive-graphics-svn41015-33.fc25.1.noarch texlive-dvipdfmx-def-svn40328-33.fc25.1.noarch texlive-mfware-svn40768-33.fc25.1.noarch texlive-texlive-scripts-svn41433-33.fc25.1.noarch texlive-euro-svn22191.1.1-33.fc25.1.noarch texlive-etex-svn37057.0-33.fc25.1.noarch texlive-iftex-svn29654.0.2-33.fc25.1.noarch texlive-palatino-svn31835.0-33.fc25.1.noarch texlive-texlive-docindex-svn41430-33.fc25.1.noarch texlive-xunicode-svn30466.0.981-33.fc25.1.noarch texlive-koma-script-svn41508-33.fc25.1.noarch texlive-pst-grad-svn15878.1.06-33.fc25.1.noarch texlive-pst-blur-svn15878.2.0-33.fc25.1.noarch texlive-jknapltx-svn19440.0-33.fc25.1.noarch netpbm-progs-10.77.00-3.fc25.s390x texinfo-6.1-4.fc25.s390x openssl-devel-1.0.2k-1.fc25.s390x python2-sssdconfig-1.15.2-1.fc25.noarch gdk-pixbuf2-2.36.6-1.fc25.s390x mesa-libEGL-13.0.4-3.fc25.s390x pcre-cpp-8.40-6.fc25.s390x pcre-utf16-8.40-6.fc25.s390x glusterfs-extra-xlators-3.10.1-1.fc25.s390x mesa-libGL-devel-13.0.4-3.fc25.s390x nss-devel-3.29.3-1.1.fc25.s390x libaio-0.3.110-6.fc24.s390x libfontenc-1.1.3-3.fc24.s390x lzo-2.08-8.fc24.s390x isl-0.14-5.fc24.s390x libXau-1.0.8-6.fc24.s390x linux-atm-libs-2.5.1-14.fc24.s390x libXext-1.3.3-4.fc24.s390x libXxf86vm-1.1.4-3.fc24.s390x bison-3.0.4-4.fc24.s390x perl-srpm-macros-1-20.fc25.noarch gawk-4.1.3-8.fc25.s390x libwayland-client-1.12.0-1.fc25.s390x perl-Exporter-5.72-366.fc25.noarch perl-version-0.99.17-1.fc25.s390x fftw-libs-double-3.3.5-3.fc25.s390x libssh2-1.8.0-1.fc25.s390x ModemManager-glib-1.6.4-1.fc25.s390x newt-python3-0.52.19-2.fc25.s390x python-munch-2.0.4-3.fc25.noarch python-bugzilla-1.2.2-4.fc25.noarch libedit-3.1-16.20160618cvs.fc25.s390x python-pycurl-7.43.0-4.fc25.s390x createrepo_c-0.10.0-6.fc25.s390x device-mapper-multipath-libs-0.4.9-83.fc25.s390x yum-3.4.3-510.fc25.noarch dhcp-common-4.3.5-1.fc25.noarch dracut-config-rescue-044-78.fc25.s390x teamd-1.26-1.fc25.s390x mozjs17-17.0.0-16.fc25.s3
