Re: [Qemu-devel] [PATCH 15/15] qtest: add rtc-test test-case

2012-01-11 Thread Paolo Bonzini
On 01/10/2012 08:10 PM, Anthony Liguori wrote: +sec = cmos_read(0x00); +min = cmos_read(0x02); +hour = cmos_read(0x04); +mday = cmos_read(0x07); +mon = cmos_read(0x08); +year = cmos_read(0x09); Please use identifiers for register numbers. +/* + * This check

Re: [Qemu-devel] [PATCH 15/15] qtest: add rtc-test test-case

2012-01-11 Thread Anthony Liguori
On 01/10/2012 01:59 PM, Paolo Bonzini wrote: On 01/10/2012 08:10 PM, Anthony Liguori wrote: + sec = cmos_read(0x00); + min = cmos_read(0x02); + hour = cmos_read(0x04); + mday = cmos_read(0x07); + mon = cmos_read(0x08); + year = cmos_read(0x09); Please use identifiers for register numbers. +

Re: [Qemu-devel] [PATCH 15/15] qtest: add rtc-test test-case

2012-01-11 Thread Paolo Bonzini
On 01/11/2012 06:06 PM, Anthony Liguori wrote: The right thing to do would be to run the test with vm_clock for the rtc_clock, add a way for the qtest machine to bump the vm_clock to the next event, I actually was looking at this yesterday. Just bumping to the next event is not enough, you