Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-10-06 Thread Paolo Bonzini
On 06/10/2017 12:23, David Gibson wrote: > On Tue, Oct 03, 2017 at 05:21:57PM -0500, Michael Roth wrote: >> Patch 1/3 is also needed for another series that Greg is working on >> and I don't want to hold that up for this series, so if it's >> preferred that we just post that patch separately in the

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-10-06 Thread David Gibson
On Tue, Oct 03, 2017 at 05:21:57PM -0500, Michael Roth wrote: > Quoting Michael Roth (2017-07-26 20:30:52) > > This series was motivated by the discussion in this thread: > > > > https://www.redhat.com/archives/libvir-list/2017-June/msg01370.html > > > > The issue this series addresses is that

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-10-03 Thread David Gibson
On Tue, Oct 03, 2017 at 05:21:57PM -0500, Michael Roth wrote: > Quoting Michael Roth (2017-07-26 20:30:52) > > This series was motivated by the discussion in this thread: > > > > https://www.redhat.com/archives/libvir-list/2017-June/msg01370.html > > > > The issue this series addresses is that

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-10-03 Thread Michael Roth
Quoting Michael Roth (2017-07-26 20:30:52) > This series was motivated by the discussion in this thread: > > https://www.redhat.com/archives/libvir-list/2017-June/msg01370.html > > The issue this series addresses is that when libvirt unplugs a VFIO PCI > device, > it may attempt to bind the ho

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-09-05 Thread Greg Kurz
On Wed, 9 Aug 2017 15:08:42 +1000 David Gibson wrote: > On Tue, Aug 08, 2017 at 01:40:08PM -0600, Alex Williamson wrote: > > On Thu, 27 Jul 2017 12:50:42 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Thu, Jul 27, 2017 at 08:53:48PM +1000, David Gibson wrote: > > > > On Thu, Jul 27, 201

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-08-09 Thread Auger Eric
Hi Michael, On 27/07/2017 03:30, Michael Roth wrote: > This series was motivated by the discussion in this thread: > > https://www.redhat.com/archives/libvir-list/2017-June/msg01370.html > > The issue this series addresses is that when libvirt unplugs a VFIO PCI > device, > it may attempt to

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-08-08 Thread David Gibson
On Tue, Aug 08, 2017 at 01:40:08PM -0600, Alex Williamson wrote: > On Thu, 27 Jul 2017 12:50:42 +0100 > "Daniel P. Berrange" wrote: > > > On Thu, Jul 27, 2017 at 08:53:48PM +1000, David Gibson wrote: > > > On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > > > > On 27 July 2017 at

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-08-08 Thread Alex Williamson
On Thu, 27 Jul 2017 12:50:42 +0100 "Daniel P. Berrange" wrote: > On Thu, Jul 27, 2017 at 08:53:48PM +1000, David Gibson wrote: > > On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > > > On 27 July 2017 at 02:30, Michael Roth wrote: > > > > > > > In particular, Mellanox CX4 ada

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-07-27 Thread David Gibson
On Thu, Jul 27, 2017 at 08:47:33AM -0600, Alex Williamson wrote: > On Thu, 27 Jul 2017 20:53:48 +1000 > David Gibson wrote: > > > On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > > > On 27 July 2017 at 02:30, Michael Roth wrote: > > > > > > > In particular, Mellanox CX4 adapte

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-07-27 Thread Alex Williamson
On Thu, 27 Jul 2017 20:53:48 +1000 David Gibson wrote: > On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > > On 27 July 2017 at 02:30, Michael Roth wrote: > > > In particular, Mellanox CX4 adapters on PowerNV hosts might not be fully > > > quiesced by vfio-pci's finalize() routi

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-07-27 Thread Michael Roth
Quoting David Gibson (2017-07-27 05:53:48) > On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > > On 27 July 2017 at 02:30, Michael Roth wrote: > > > In particular, Mellanox CX4 adapters on PowerNV hosts might not be fully > > > quiesced by vfio-pci's finalize() routine until up to 6

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-07-27 Thread Daniel P. Berrange
On Thu, Jul 27, 2017 at 08:53:48PM +1000, David Gibson wrote: > On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > > On 27 July 2017 at 02:30, Michael Roth wrote: > > > In particular, Mellanox CX4 adapters on PowerNV hosts might not be fully > > > quiesced by vfio-pci's finalize() ro

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-07-27 Thread David Gibson
On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > On 27 July 2017 at 02:30, Michael Roth wrote: > > In particular, Mellanox CX4 adapters on PowerNV hosts might not be fully > > quiesced by vfio-pci's finalize() routine until up to 6s after the > > DEVICE_DELETED was emitted, leading

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-07-27 Thread Peter Maydell
On 27 July 2017 at 02:30, Michael Roth wrote: > In particular, Mellanox CX4 adapters on PowerNV hosts might not be fully > quiesced by vfio-pci's finalize() routine until up to 6s after the > DEVICE_DELETED was emitted, leading to detach-device on the libvirt side > pretty > much always crashing