Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-18 Thread Eric Blake
On 04/13/2018 11:59 AM, Halil Pasic wrote: > This ssize_t seems to be an rather interesting type. For instance POSIX says > """ > size_t > Used for sizes of objects. > ssize_t > Used for a count of bytes or an error indication. > """ > and > """ > The type ssize_t shall be capable of stori

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-16 Thread Cornelia Huck
On Fri, 13 Apr 2018 14:09:55 -0400 Collin Walling wrote: > On 04/13/2018 02:06 PM, Philippe Mathieu-Daudé wrote: > > On 04/13/2018 01:59 PM, Halil Pasic wrote: > On 04/13/2018 04:30 PM, Thomas Huth wrote: > > "size_t" should be an unsigned type - the signed counterpart is called > >>

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Collin Walling
On 04/13/2018 02:06 PM, Philippe Mathieu-Daudé wrote: > On 04/13/2018 01:59 PM, Halil Pasic wrote: On 04/13/2018 04:30 PM, Thomas Huth wrote: > "size_t" should be an unsigned type - the signed counterpart is called > "ssize_t" in the C standard instead. Thus we should also use this >>>

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Philippe Mathieu-Daudé
On 04/13/2018 01:59 PM, Halil Pasic wrote: >>> On 04/13/2018 04:30 PM, Thomas Huth wrote: "size_t" should be an unsigned type - the signed counterpart is called "ssize_t" in the C standard instead. Thus we should also use this >>> The first sentence sounds like ssize_t is too a type defin

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Halil Pasic
On 04/13/2018 05:50 PM, Thomas Huth wrote: > On 13.04.2018 17:28, Halil Pasic wrote: >> >> On 04/13/2018 04:30 PM, Thomas Huth wrote: >>> "size_t" should be an unsigned type - the signed counterpart is called >>> "ssize_t" in the C standard instead. Thus we should also use this >> The first sente

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Thomas Huth
On 13.04.2018 17:28, Halil Pasic wrote: > > > On 04/13/2018 04:30 PM, Thomas Huth wrote: >> "size_t" should be an unsigned type - the signed counterpart is called >> "ssize_t" in the C standard instead. Thus we should also use this > > The first sentence sounds like ssize_t is too a type defined

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 16:28, Halil Pasic wrote: > > > On 04/13/2018 04:30 PM, Thomas Huth wrote: >> "size_t" should be an unsigned type - the signed counterpart is called >> "ssize_t" in the C standard instead. Thus we should also use this > > The first sentence sounds like ssize_t is too a type def

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Halil Pasic
On 04/13/2018 04:30 PM, Thomas Huth wrote: > "size_t" should be an unsigned type - the signed counterpart is called > "ssize_t" in the C standard instead. Thus we should also use this The first sentence sounds like ssize_t is too a type defined by some C standard. Is it or does ssize_t come form

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Collin Walling
On 04/13/2018 10:30 AM, Thomas Huth wrote: > "size_t" should be an unsigned type - the signed counterpart is called > "ssize_t" in the C standard instead. Thus we should also use this > convention in the s390-ccw firmware to avoid confusion. I checked the > sources, and apart from one spot in libc.

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Philippe Mathieu-Daudé
On 04/13/2018 11:30 AM, Thomas Huth wrote: > "size_t" should be an unsigned type - the signed counterpart is called > "ssize_t" in the C standard instead. Thus we should also use this > convention in the s390-ccw firmware to avoid confusion. I checked the > sources, and apart from one spot in libc.