Re: [Qemu-devel] [PATCH v2] hw/char/stm32f2xx_usart: fix TXE/TC bit handling

2018-02-22 Thread Peter Maydell
On 15 February 2018 at 22:27, Alistair Francis wrote: > On Tue, Feb 13, 2018 at 12:54 PM, Richard Braun wrote: >> I/O currently being synchronous, there is no reason to ever clear the >> SR_TXE bit. However the SR_TC bit may be cleared by software writing

Re: [Qemu-devel] [PATCH v2] hw/char/stm32f2xx_usart: fix TXE/TC bit handling

2018-02-15 Thread Alistair Francis
On Tue, Feb 13, 2018 at 12:54 PM, Richard Braun wrote: > I/O currently being synchronous, there is no reason to ever clear the > SR_TXE bit. However the SR_TC bit may be cleared by software writing > to the SR register, so set it on each write. > > In addition, fix the reset