Re: [Qemu-devel] [PATCH v2 0/2] refine memory_device_get_free_addr
On Mon, Oct 14, 2019 at 12:05:47PM -0300, Eduardo Habkost wrote: >On Sat, Oct 12, 2019 at 05:02:09PM +0800, Wei Yang wrote: >> On Sat, Sep 14, 2019 at 03:40:41PM -0400, Michael S. Tsirkin wrote: >> >On Fri, Sep 13, 2019 at 11:47:46PM +, Wei Yang wrote: >> >> On Tue, Jul 30, 2019 at 08:37:38AM +0800, Wei Yang wrote: >> >> >When we iterate the memory-device list to get the available range, it is >> >> >not >> >> >necessary to iterate the whole list. >> >> > >> >> >1) no more overlap for hinted range if tmp exceed it >> >> > >> >> >v2: >> >> > * remove #2 as suggested by Igor and David >> >> > * add some comment to inform address assignment stay the same as >> >> > before >> >> > this change >> >> > >> >> >Wei Yang (2): >> >> > memory-device: not necessary to use goto for the last check >> >> > memory-device: break the loop if tmp exceed the hinted range >> >> > >> >> > hw/mem/memory-device.c | 3 ++- >> >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> >> > >> >> >> >> Would someone take this patch set? >> > >> >yes looks good to me too. >> >Eduardo? >> > >> >> Hmm... I don't see this any where. May I ask the status? > >Sorry, I hadn't seen Michael's message. Queued on machine-next. >Thanks! > Thanks~ have a nice day. >-- >Eduardo -- Wei Yang Help you, Help me
Re: [Qemu-devel] [PATCH v2 0/2] refine memory_device_get_free_addr
On Sat, Oct 12, 2019 at 05:02:09PM +0800, Wei Yang wrote: > On Sat, Sep 14, 2019 at 03:40:41PM -0400, Michael S. Tsirkin wrote: > >On Fri, Sep 13, 2019 at 11:47:46PM +, Wei Yang wrote: > >> On Tue, Jul 30, 2019 at 08:37:38AM +0800, Wei Yang wrote: > >> >When we iterate the memory-device list to get the available range, it is > >> >not > >> >necessary to iterate the whole list. > >> > > >> >1) no more overlap for hinted range if tmp exceed it > >> > > >> >v2: > >> > * remove #2 as suggested by Igor and David > >> > * add some comment to inform address assignment stay the same as before > >> > this change > >> > > >> >Wei Yang (2): > >> > memory-device: not necessary to use goto for the last check > >> > memory-device: break the loop if tmp exceed the hinted range > >> > > >> > hw/mem/memory-device.c | 3 ++- > >> > 1 file changed, 2 insertions(+), 1 deletion(-) > >> > > >> > >> Would someone take this patch set? > > > >yes looks good to me too. > >Eduardo? > > > > Hmm... I don't see this any where. May I ask the status? Sorry, I hadn't seen Michael's message. Queued on machine-next. Thanks! -- Eduardo
Re: [Qemu-devel] [PATCH v2 0/2] refine memory_device_get_free_addr
On Sat, Sep 14, 2019 at 03:40:41PM -0400, Michael S. Tsirkin wrote: >On Fri, Sep 13, 2019 at 11:47:46PM +, Wei Yang wrote: >> On Tue, Jul 30, 2019 at 08:37:38AM +0800, Wei Yang wrote: >> >When we iterate the memory-device list to get the available range, it is not >> >necessary to iterate the whole list. >> > >> >1) no more overlap for hinted range if tmp exceed it >> > >> >v2: >> > * remove #2 as suggested by Igor and David >> > * add some comment to inform address assignment stay the same as before >> > this change >> > >> >Wei Yang (2): >> > memory-device: not necessary to use goto for the last check >> > memory-device: break the loop if tmp exceed the hinted range >> > >> > hw/mem/memory-device.c | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> >> Would someone take this patch set? > >yes looks good to me too. >Eduardo? > Hmm... I don't see this any where. May I ask the status? >> >-- >> >2.17.1 >> > >> >> -- >> Wei Yang >> Help you, Help me -- Wei Yang Help you, Help me
Re: [Qemu-devel] [PATCH v2 0/2] refine memory_device_get_free_addr
On Fri, Sep 13, 2019 at 11:47:46PM +, Wei Yang wrote: > On Tue, Jul 30, 2019 at 08:37:38AM +0800, Wei Yang wrote: > >When we iterate the memory-device list to get the available range, it is not > >necessary to iterate the whole list. > > > >1) no more overlap for hinted range if tmp exceed it > > > >v2: > > * remove #2 as suggested by Igor and David > > * add some comment to inform address assignment stay the same as before > > this change > > > >Wei Yang (2): > > memory-device: not necessary to use goto for the last check > > memory-device: break the loop if tmp exceed the hinted range > > > > hw/mem/memory-device.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > Would someone take this patch set? yes looks good to me too. Eduardo? > >-- > >2.17.1 > > > > -- > Wei Yang > Help you, Help me
Re: [Qemu-devel] [PATCH v2 0/2] refine memory_device_get_free_addr
On Tue, Jul 30, 2019 at 08:37:38AM +0800, Wei Yang wrote: >When we iterate the memory-device list to get the available range, it is not >necessary to iterate the whole list. > >1) no more overlap for hinted range if tmp exceed it > >v2: > * remove #2 as suggested by Igor and David > * add some comment to inform address assignment stay the same as before > this change > >Wei Yang (2): > memory-device: not necessary to use goto for the last check > memory-device: break the loop if tmp exceed the hinted range > > hw/mem/memory-device.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Would someone take this patch set? >-- >2.17.1 > -- Wei Yang Help you, Help me
