Re: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification via QMP/HMP

[Michael S. Tsirkin]

On Fri, Mar 02, 2018 at 10:37:20AM +0200, Or Idgar wrote:
> From: Or Idgar 
> 
> This patch allow changing the Virtual Machine Generation
> ID through QMP/HMP while the vm guest is running.
> the spec (http://go.microsoft.com/fwlink/?LinkId=260709)
> mentions that "when the generation ID changes, execute an
> ACPI Notify operation on the generation ID device".
> To test it we need the ability to set the generation ID
> online. QMP/HMP allows that.
> 
> QMP command example:
> { "execute": "set-vm-generation-id",
>   "arguments": {
>   "guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87"
>   }
> }
> 
> HMP command example:
> set-vm-generation-id 324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87

would it make sense to use qom-set for this instead?


> This patch is based off an earlier version by
> Igor Mammedov (imamm...@redhat.com)
> 
> Signed-off-by: Or Idgar 
> Reviewed-by: Gal Hammer 
> ---
> 
> Changes in v3:
> - Explaining why we need this patch in the commit message.
> 
>  docs/specs/vmgenid.txt |  7 ---
>  hmp-commands.hx| 13 +
>  hmp.c  | 10 ++
>  hmp.h  |  1 +
>  hw/acpi/vmgenid.c  | 10 ++
>  qapi-schema.json   | 11 +++
>  tests/vmgenid-test.c   | 31 +++
>  7 files changed, 80 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt
> index aa9f518..04443de 100644
> --- a/docs/specs/vmgenid.txt
> +++ b/docs/specs/vmgenid.txt
> @@ -240,6 +240,7 @@ The property may be queried via QMP/HMP:
>(QEMU) query-vm-generation-id
>{"return": {"guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87"}}
>  
> -Setting of this parameter is intentionally left out from the QMP/HMP
> -interfaces.  There are no known use cases for changing the GUID once QEMU is
> -running, and adding this capability would greatly increase the complexity.
> +Also, the property may be set via QMP/HMP:
> +
> +  (QEMU) set-vm-generation-id guid=ee6726ce-73b4-4a8b-863c-708f26515847
> +  {"return": {}}

I see you dropped the text that said it's not really useful.
It's probably a good idea to supply some use-case examples
where it *is* useful. Testing could be one but as you see
it didn't impress others in this thread too much.

> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 4afd57c..4524669 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1871,5 +1871,18 @@ ETEXI
>  },
>  
>  STEXI
> +@item set-vm-generation-id @var{uuid}
> +Set Virtual Machine Generation ID counter to @var{guid}
> +ETEXI
> +
> +{
> +.name   = "set-vm-generation-id",
> +.args_type  = "guid:s",
> +.params = "guid",
> +.help   = "Set Virtual Machine Generation ID counter",
> +.cmd= hmp_set_vm_generation_id,
> +},
> +
> +STEXI
>  @end table
>  ETEXI
> diff --git a/hmp.c b/hmp.c
> index 35a7041..73f9b00 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -2901,6 +2901,16 @@ void hmp_info_vm_generation_id(Monitor *mon, const 
> QDict *qdict)
>  qapi_free_GuidInfo(info);
>  }
>  
> +void hmp_set_vm_generation_id(Monitor *mon, const QDict *qdict)
> +{
> +Error *errp = NULL;
> +const char *guid = qdict_get_str(qdict, "guid");
> +
> +qmp_set_vm_generation_id(guid, );
> +if (errp)
> +hmp_handle_error(mon, );
> +}
> +
>  void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict)
>  {
>  Error *err = NULL;
> diff --git a/hmp.h b/hmp.h
> index a6f56b1..8cc74d5 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -147,5 +147,6 @@ void hmp_info_ramblock(Monitor *mon, const QDict *qdict);
>  void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict);
>  void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict);
>  void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict);
> +void hmp_set_vm_generation_id(Monitor *mon, const QDict *qdict);
>  
>  #endif
> diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
> index 105044f..5319d70 100644
> --- a/hw/acpi/vmgenid.c
> +++ b/hw/acpi/vmgenid.c
> @@ -129,6 +129,16 @@ void vmgenid_add_fw_cfg(VmGenIdState *vms, FWCfgState 
> *s, GArray *guid)
>   ARRAY_SIZE(vms->vmgenid_addr_le), false);
>  }
>  
> +void qmp_set_vm_generation_id(const char *guid, Error **errp)
> +{
> +Object *obj = find_vmgenid_dev();
> +
> +if (!obj) {
> +return;
> +}
> +object_property_set_str(obj, guid, VMGENID_GUID, errp);
> +}
> +
>  static void vmgenid_update_guest(VmGenIdState *vms)
>  {
>  Object *obj = object_resolve_path_type("", TYPE_ACPI_DEVICE_IF, NULL);
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 1845795..c2ab733 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3193,6 +3193,17 @@
>  { 'command': 'query-vm-generation-id', 'returns': 'GuidInfo' }
>  
>  ##
> +# @set-vm-generation-id:
> +#
> +# Set Virtual Machine Generation ID
> +#

Re: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification via QMP/HMP

[Benjamin Warren via Qemu-devel]

On Fri, Mar 2, 2018 at 2:57 AM, Daniel P. Berrangé 
wrote:

> On Fri, Mar 02, 2018 at 10:37:20AM +0200, Or Idgar wrote:
> > From: Or Idgar 
> >
> > This patch allow changing the Virtual Machine Generation
> > ID through QMP/HMP while the vm guest is running.
> > the spec (http://go.microsoft.com/fwlink/?LinkId=260709)
> > mentions that "when the generation ID changes, execute an
> > ACPI Notify operation on the generation ID device".
> > To test it we need the ability to set the generation ID
> > online. QMP/HMP allows that.
>
> If we want to test vmgenid, why don't we simply trigger one of
> the mgmt actions that are required to change vmgenid. eg do a
> savevm, followed by a loadvm to restore from snapshot. This would
> be better testing of the real world usage of this feature.
>
> I agree.  Verifying functionality in a Windows guest is tricky, but in
Linux you can build and load this (old and badly written) device driver:

https://github.com/ben-skyportsystems/vmgenid-test

You should see the 'notices' number increment after restoring a snapshot.

Regards,
> Daniel
> --
> |: https://berrange.com  -o-https://www.flickr.com/photos/
> dberrange :|
> |: https://libvirt.org -o-
> https://fstop138.berrange.com :|
> |: https://entangle-photo.org-o-https://www.instagram.com/
> dberrange :|
>

regards,
Ben

Re: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification via QMP/HMP

[Daniel P . Berrangé]

On Fri, Mar 02, 2018 at 10:37:20AM +0200, Or Idgar wrote:
> From: Or Idgar 
> 
> This patch allow changing the Virtual Machine Generation
> ID through QMP/HMP while the vm guest is running.
> the spec (http://go.microsoft.com/fwlink/?LinkId=260709)
> mentions that "when the generation ID changes, execute an
> ACPI Notify operation on the generation ID device".
> To test it we need the ability to set the generation ID
> online. QMP/HMP allows that.

If we want to test vmgenid, why don't we simply trigger one of
the mgmt actions that are required to change vmgenid. eg do a
savevm, followed by a loadvm to restore from snapshot. This would
be better testing of the real world usage of this feature.

Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification via QMP/HMP

[Dr. David Alan Gilbert]

* Or Idgar (id...@virtualoco.com) wrote:
> From: Or Idgar 

Hi Or,

> This patch allow changing the Virtual Machine Generation
> ID through QMP/HMP while the vm guest is running.
> the spec (http://go.microsoft.com/fwlink/?LinkId=260709)
> mentions that "when the generation ID changes, execute an
> ACPI Notify operation on the generation ID device".
> To test it we need the ability to set the generation ID
> online. QMP/HMP allows that.
> 
> QMP command example:
> { "execute": "set-vm-generation-id",
>   "arguments": {
>   "guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87"
>   }
> }
> 
> HMP command example:
> set-vm-generation-id 324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87
> 
> This patch is based off an earlier version by
> Igor Mammedov (imamm...@redhat.com)


Note the patchew build failures;  hw/acpi/vmgenid.c isn't built
on all builds, and so you're getting link failures on those for
qmp_set_vm_generation_id.  So check builds for aarch64 and a few others
build OK; you'll need to make the hmp (and qapi?) code conditional. See
the ifdef on hmp_info_spice in hmp.c and the corresponding #if in
hmp-commands-info.hx.

Also, does anything need to sanity check the guid string?

> Signed-off-by: Or Idgar 
> Reviewed-by: Gal Hammer 
> ---
> 
> Changes in v3:
> - Explaining why we need this patch in the commit message.
> 
>  docs/specs/vmgenid.txt |  7 ---
>  hmp-commands.hx| 13 +
>  hmp.c  | 10 ++
>  hmp.h  |  1 +
>  hw/acpi/vmgenid.c  | 10 ++
>  qapi-schema.json   | 11 +++
>  tests/vmgenid-test.c   | 31 +++
>  7 files changed, 80 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt
> index aa9f518..04443de 100644
> --- a/docs/specs/vmgenid.txt
> +++ b/docs/specs/vmgenid.txt
> @@ -240,6 +240,7 @@ The property may be queried via QMP/HMP:
>(QEMU) query-vm-generation-id
>{"return": {"guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87"}}
>  
> -Setting of this parameter is intentionally left out from the QMP/HMP
> -interfaces.  There are no known use cases for changing the GUID once QEMU is
> -running, and adding this capability would greatly increase the complexity.
> +Also, the property may be set via QMP/HMP:
> +
> +  (QEMU) set-vm-generation-id guid=ee6726ce-73b4-4a8b-863c-708f26515847
> +  {"return": {}}
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 4afd57c..4524669 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1871,5 +1871,18 @@ ETEXI
>  },
>  
>  STEXI
> +@item set-vm-generation-id @var{uuid}
> +Set Virtual Machine Generation ID counter to @var{guid}
> +ETEXI
> +
> +{
> +.name   = "set-vm-generation-id",
> +.args_type  = "guid:s",
> +.params = "guid",
> +.help   = "Set Virtual Machine Generation ID counter",
> +.cmd= hmp_set_vm_generation_id,
> +},
> +
> +STEXI
>  @end table
>  ETEXI
> diff --git a/hmp.c b/hmp.c
> index 35a7041..73f9b00 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -2901,6 +2901,16 @@ void hmp_info_vm_generation_id(Monitor *mon, const 
> QDict *qdict)
>  qapi_free_GuidInfo(info);
>  }
>  
> +void hmp_set_vm_generation_id(Monitor *mon, const QDict *qdict)
> +{
> +Error *errp = NULL;
> +const char *guid = qdict_get_str(qdict, "guid");
> +
> +qmp_set_vm_generation_id(guid, );
> +if (errp)
> +hmp_handle_error(mon, );

Note qemu style says you need the { }'s on that 'if' even though it's
one line.

Dave

> +}
> +
>  void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict)
>  {
>  Error *err = NULL;
> diff --git a/hmp.h b/hmp.h
> index a6f56b1..8cc74d5 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -147,5 +147,6 @@ void hmp_info_ramblock(Monitor *mon, const QDict *qdict);
>  void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict);
>  void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict);
>  void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict);
> +void hmp_set_vm_generation_id(Monitor *mon, const QDict *qdict);
>  
>  #endif
> diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
> index 105044f..5319d70 100644
> --- a/hw/acpi/vmgenid.c
> +++ b/hw/acpi/vmgenid.c
> @@ -129,6 +129,16 @@ void vmgenid_add_fw_cfg(VmGenIdState *vms, FWCfgState 
> *s, GArray *guid)
>   ARRAY_SIZE(vms->vmgenid_addr_le), false);
>  }
>  
> +void qmp_set_vm_generation_id(const char *guid, Error **errp)
> +{
> +Object *obj = find_vmgenid_dev();
> +
> +if (!obj) {
> +return;
> +}
> +object_property_set_str(obj, guid, VMGENID_GUID, errp);
> +}
> +
>  static void vmgenid_update_guest(VmGenIdState *vms)
>  {
>  Object *obj = object_resolve_path_type("", TYPE_ACPI_DEVICE_IF, NULL);
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 1845795..c2ab733 100644
> --- 

Re: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification via QMP/HMP

[no-reply]

Hi,

This series failed docker-build@min-glib build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

Type: series
Message-id: 20180302083720.25137-1-id...@virtualoco.com
Subject: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification 
via QMP/HMP

=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
# Let docker tests dump environment info
export SHOW_ENV=1
export J=8
time make docker-test-build@min-glib
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]   
patchew/1519760121-24594-1-git-send-email-wall...@linux.vnet.ibm.com -> 
patchew/1519760121-24594-1-git-send-email-wall...@linux.vnet.ibm.com
Switched to a new branch 'test'
b6a6dfdc19 vmgenid: allow VM Generation ID modification via QMP/HMP

=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-s8fpu6qp/src/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
  BUILD   min-glib
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-s8fpu6qp/src'
  GEN 
/var/tmp/patchew-tester-tmp-s8fpu6qp/src/docker-src.2018-03-02-03.52.52.2365/qemu.tar
Cloning into 
'/var/tmp/patchew-tester-tmp-s8fpu6qp/src/docker-src.2018-03-02-03.52.52.2365/qemu.tar.vroot'...
done.
Checking out files:  45% (2671/5904)   
Checking out files:  46% (2716/5904)   
Checking out files:  47% (2775/5904)   
Checking out files:  48% (2834/5904)   
Checking out files:  49% (2893/5904)   
Checking out files:  50% (2952/5904)   
Checking out files:  51% (3012/5904)   
Checking out files:  52% (3071/5904)   
Checking out files:  53% (3130/5904)   
Checking out files:  54% (3189/5904)   
Checking out files:  55% (3248/5904)   
Checking out files:  56% (3307/5904)   
Checking out files:  57% (3366/5904)   
Checking out files:  58% (3425/5904)   
Checking out files:  59% (3484/5904)   
Checking out files:  60% (3543/5904)   
Checking out files:  61% (3602/5904)   
Checking out files:  62% (3661/5904)   
Checking out files:  63% (3720/5904)   
Checking out files:  64% (3779/5904)   
Checking out files:  65% (3838/5904)   
Checking out files:  66% (3897/5904)   
Checking out files:  67% (3956/5904)   
Checking out files:  68% (4015/5904)   
Checking out files:  69% (4074/5904)   
Checking out files:  70% (4133/5904)   
Checking out files:  71% (4192/5904)   
Checking out files:  72% (4251/5904)   
Checking out files:  73% (4310/5904)   
Checking out files:  74% (4369/5904)   
Checking out files:  75% (4428/5904)   
Checking out files:  76% (4488/5904)   
Checking out files:  77% (4547/5904)   
Checking out files:  78% (4606/5904)   
Checking out files:  79% (4665/5904)   
Checking out files:  80% (4724/5904)   
Checking out files:  81% (4783/5904)   
Checking out files:  82% (4842/5904)   
Checking out files:  83% (4901/5904)   
Checking out files:  84% (4960/5904)   
Checking out files:  85% (5019/5904)   
Checking out files:  86% (5078/5904)   
Checking out files:  87% (5137/5904)   
Checking out files:  88% (5196/5904)   
Checking out files:  89% (5255/5904)   
Checking out files:  90% (5314/5904)   
Checking out files:  91% (5373/5904)   
Checking out files:  92% (5432/5904)   
Checking out files:  93% (5491/5904)   
Checking out files:  94% (5550/5904)   
Checking out files:  95% (5609/5904)   
Checking out files:  96% (5668/5904)   
Checking out files:  97% (5727/5904)   
Checking out files:  98% (5786/5904)   
Checking out files:  99% (5845/5904)   
Checking out files: 100% (5904/5904)   
Checking out files: 100% (5904/5904), done.
Your branch is up-to-date with 'origin/test'.
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into 
'/var/tmp/patchew-tester-tmp-s8fpu6qp/src/docker-src.2018-03-02-03.52.52.2365/qemu.tar.vroot/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered 
for path 'ui/keycodemapdb'
Cloning into 
'/var/tmp/patchew-tester-tmp-s8fpu6qp/src/docker-src.2018-03-02-03.52.52.2365/qemu.tar.vroot/ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out 
'6b3d716e2b6472eb7189d3220552280ef3d832ce'
  COPYRUNNER
RUN test-build in qemu:min-glib 
Environment variables:
HOSTNAME=8dfe70e1c13f
MAKEFLAGS= -j8
J=8
CCACHE_DIR=/var/tmp/ccache
EXTRA_CONFIGURE_OPTS=
V=
SHOW_ENV=1
PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PWD=/
TARGET_LIST=
SHLVL=1
HOME=/root
TEST_DIR=/tmp/qemu-test
FEATURES= dtc
DEBUG=
_=/usr/bin/env

Configure options:
--enable-werror --target-list=x86_64-softmmu,aarch64-softmmu 
--prefix=/tmp/qemu-test/install
No C++ compiler available; disabling C++ specific optional code
Install prefix/tmp/qemu-test/install
BIOS 

Re: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification via QMP/HMP

[no-reply]

Hi,

This series failed docker-quick@centos6 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

Type: series
Message-id: 20180302083720.25137-1-id...@virtualoco.com
Subject: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification 
via QMP/HMP

=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
# Let docker tests dump environment info
export SHOW_ENV=1
export J=8
time make docker-test-quick@centos6
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
b6a6dfdc19 vmgenid: allow VM Generation ID modification via QMP/HMP

=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-pn5yeanh/src/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
  BUILD   centos6
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-pn5yeanh/src'
  GEN 
/var/tmp/patchew-tester-tmp-pn5yeanh/src/docker-src.2018-03-02-03.49.28.22570/qemu.tar
Cloning into 
'/var/tmp/patchew-tester-tmp-pn5yeanh/src/docker-src.2018-03-02-03.49.28.22570/qemu.tar.vroot'...
done.
Checking out files:  45% (2702/5904)   
Checking out files:  46% (2716/5904)   
Checking out files:  47% (2775/5904)   
Checking out files:  48% (2834/5904)   
Checking out files:  49% (2893/5904)   
Checking out files:  50% (2952/5904)   
Checking out files:  51% (3012/5904)   
Checking out files:  52% (3071/5904)   
Checking out files:  53% (3130/5904)   
Checking out files:  54% (3189/5904)   
Checking out files:  55% (3248/5904)   
Checking out files:  56% (3307/5904)   
Checking out files:  57% (3366/5904)   
Checking out files:  58% (3425/5904)   
Checking out files:  59% (3484/5904)   
Checking out files:  60% (3543/5904)   
Checking out files:  61% (3602/5904)   
Checking out files:  62% (3661/5904)   
Checking out files:  63% (3720/5904)   
Checking out files:  64% (3779/5904)   
Checking out files:  65% (3838/5904)   
Checking out files:  66% (3897/5904)   
Checking out files:  67% (3956/5904)   
Checking out files:  68% (4015/5904)   
Checking out files:  69% (4074/5904)   
Checking out files:  70% (4133/5904)   
Checking out files:  71% (4192/5904)   
Checking out files:  72% (4251/5904)   
Checking out files:  73% (4310/5904)   
Checking out files:  74% (4369/5904)   
Checking out files:  75% (4428/5904)   
Checking out files:  76% (4488/5904)   
Checking out files:  77% (4547/5904)   
Checking out files:  78% (4606/5904)   
Checking out files:  79% (4665/5904)   
Checking out files:  80% (4724/5904)   
Checking out files:  81% (4783/5904)   
Checking out files:  82% (4842/5904)   
Checking out files:  83% (4901/5904)   
Checking out files:  84% (4960/5904)   
Checking out files:  85% (5019/5904)   
Checking out files:  86% (5078/5904)   
Checking out files:  87% (5137/5904)   
Checking out files:  88% (5196/5904)   
Checking out files:  89% (5255/5904)   
Checking out files:  90% (5314/5904)   
Checking out files:  91% (5373/5904)   
Checking out files:  92% (5432/5904)   
Checking out files:  93% (5491/5904)   
Checking out files:  94% (5550/5904)   
Checking out files:  95% (5609/5904)   
Checking out files:  96% (5668/5904)   
Checking out files:  97% (5727/5904)   
Checking out files:  98% (5786/5904)   
Checking out files:  99% (5845/5904)   
Checking out files: 100% (5904/5904)   
Checking out files: 100% (5904/5904), done.
Your branch is up-to-date with 'origin/test'.
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into 
'/var/tmp/patchew-tester-tmp-pn5yeanh/src/docker-src.2018-03-02-03.49.28.22570/qemu.tar.vroot/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered 
for path 'ui/keycodemapdb'
Cloning into 
'/var/tmp/patchew-tester-tmp-pn5yeanh/src/docker-src.2018-03-02-03.49.28.22570/qemu.tar.vroot/ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out 
'6b3d716e2b6472eb7189d3220552280ef3d832ce'
  COPYRUNNER
RUN test-quick in qemu:centos6 
Packages installed:
SDL-devel-1.2.14-7.el6_7.1.x86_64
bison-2.4.1-5.el6.x86_64
bzip2-devel-1.0.5-7.el6_0.x86_64
ccache-3.1.6-2.el6.x86_64
csnappy-devel-0-6.20150729gitd7bc683.el6.x86_64
flex-2.5.35-9.el6.x86_64
gcc-4.4.7-18.el6.x86_64
gettext-0.17-18.el6.x86_64
git-1.7.1-9.el6_9.x86_64
glib2-devel-2.28.8-9.el6.x86_64
libepoxy-devel-1.2-3.el6.x86_64
libfdt-devel-1.4.0-1.el6.x86_64
librdmacm-devel-1.0.21-0.el6.x86_64
lzo-devel-2.03-3.1.el6_5.1.x86_64
make-3.81-23.el6.x86_64
mesa-libEGL-devel-11.0.7-4.el6.x86_64
mesa-libgbm-devel-11.0.7-4.el6.x86_64
package g++ is not installed
pixman-devel-0.32.8-1.el6.x86_64
spice-glib-devel-0.26-8.el6.x86_64
spice-server-devel-0.12.4-16.el6.x86_64
tar-1.23-15.el6_8.x86_64
vte-devel-0.25.1-9.el6.x86_64

Re: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification via QMP/HMP

[no-reply]

Hi,

This series failed docker-mingw@fedora build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

Type: series
Message-id: 20180302083720.25137-1-id...@virtualoco.com
Subject: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification 
via QMP/HMP

=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
# Let docker tests dump environment info
export SHOW_ENV=1
export J=8
time make docker-test-mingw@fedora
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
b6a6dfdc19 vmgenid: allow VM Generation ID modification via QMP/HMP

=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-laxr77y7/src/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
  BUILD   fedora
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-laxr77y7/src'
  GEN 
/var/tmp/patchew-tester-tmp-laxr77y7/src/docker-src.2018-03-02-03.42.49.12594/qemu.tar
Cloning into 
'/var/tmp/patchew-tester-tmp-laxr77y7/src/docker-src.2018-03-02-03.42.49.12594/qemu.tar.vroot'...
done.
Your branch is up-to-date with 'origin/test'.
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into 
'/var/tmp/patchew-tester-tmp-laxr77y7/src/docker-src.2018-03-02-03.42.49.12594/qemu.tar.vroot/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered 
for path 'ui/keycodemapdb'
Cloning into 
'/var/tmp/patchew-tester-tmp-laxr77y7/src/docker-src.2018-03-02-03.42.49.12594/qemu.tar.vroot/ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out 
'6b3d716e2b6472eb7189d3220552280ef3d832ce'
  COPYRUNNER
RUN test-mingw in qemu:fedora 
Packages installed:
PyYAML-3.12-5.fc27.x86_64
SDL-devel-1.2.15-29.fc27.x86_64
bc-1.07.1-3.fc27.x86_64
bison-3.0.4-8.fc27.x86_64
bzip2-1.0.6-24.fc27.x86_64
ccache-3.3.5-1.fc27.x86_64
clang-5.0.1-1.fc27.x86_64
findutils-4.6.0-14.fc27.x86_64
flex-2.6.1-5.fc27.x86_64
gcc-7.3.1-2.fc27.x86_64
gcc-c++-7.3.1-2.fc27.x86_64
gettext-0.19.8.1-12.fc27.x86_64
git-2.14.3-2.fc27.x86_64
glib2-devel-2.54.3-2.fc27.x86_64
hostname-3.18-4.fc27.x86_64
libaio-devel-0.3.110-9.fc27.x86_64
libasan-7.3.1-2.fc27.x86_64
libfdt-devel-1.4.6-1.fc27.x86_64
libubsan-7.3.1-2.fc27.x86_64
make-4.2.1-4.fc27.x86_64
mingw32-SDL-1.2.15-9.fc27.noarch
mingw32-bzip2-1.0.6-9.fc27.noarch
mingw32-curl-7.54.1-2.fc27.noarch
mingw32-glib2-2.54.1-1.fc27.noarch
mingw32-gmp-6.1.2-2.fc27.noarch
mingw32-gnutls-3.5.13-2.fc27.noarch
mingw32-gtk2-2.24.31-4.fc27.noarch
mingw32-gtk3-3.22.16-1.fc27.noarch
mingw32-libjpeg-turbo-1.5.1-3.fc27.noarch
mingw32-libpng-1.6.29-2.fc27.noarch
mingw32-libssh2-1.8.0-3.fc27.noarch
mingw32-libtasn1-4.13-1.fc27.noarch
mingw32-nettle-3.3-3.fc27.noarch
mingw32-pixman-0.34.0-3.fc27.noarch
mingw32-pkg-config-0.28-9.fc27.x86_64
mingw64-SDL-1.2.15-9.fc27.noarch
mingw64-bzip2-1.0.6-9.fc27.noarch
mingw64-curl-7.54.1-2.fc27.noarch
mingw64-glib2-2.54.1-1.fc27.noarch
mingw64-gmp-6.1.2-2.fc27.noarch
mingw64-gnutls-3.5.13-2.fc27.noarch
mingw64-gtk2-2.24.31-4.fc27.noarch
mingw64-gtk3-3.22.16-1.fc27.noarch
mingw64-libjpeg-turbo-1.5.1-3.fc27.noarch
mingw64-libpng-1.6.29-2.fc27.noarch
mingw64-libssh2-1.8.0-3.fc27.noarch
mingw64-libtasn1-4.13-1.fc27.noarch
mingw64-nettle-3.3-3.fc27.noarch
mingw64-pixman-0.34.0-3.fc27.noarch
mingw64-pkg-config-0.28-9.fc27.x86_64
nettle-devel-3.4-1.fc27.x86_64
perl-5.26.1-402.fc27.x86_64
pixman-devel-0.34.0-4.fc27.x86_64
python3-3.6.2-13.fc27.x86_64
sparse-0.5.1-2.fc27.x86_64
tar-1.29-7.fc27.x86_64
which-2.21-4.fc27.x86_64
zlib-devel-1.2.11-4.fc27.x86_64

Environment variables:
TARGET_LIST=
PACKAGES=ccache gettext git tar PyYAML sparse flex bison python3 bzip2 hostname 
glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel gcc gcc-c++ 
clang make perl which bc findutils libaio-devel nettle-devel libasan 
libubsan mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL 
mingw32-pkg-config mingw32-gtk2 mingw32-gtk3 mingw32-gnutls mingw32-nettle 
mingw32-libtasn1 mingw32-libjpeg-turbo mingw32-libpng mingw32-curl 
mingw32-libssh2 mingw32-bzip2 mingw64-pixman mingw64-glib2 mingw64-gmp 
mingw64-SDL mingw64-pkg-config mingw64-gtk2 mingw64-gtk3 mingw64-gnutls 
mingw64-nettle mingw64-libtasn1 mingw64-libjpeg-turbo mingw64-libpng 
mingw64-curl mingw64-libssh2 mingw64-bzip2
J=8
V=
HOSTNAME=16495af01e01
DEBUG=
SHOW_ENV=1
PWD=/
HOME=/root
CCACHE_DIR=/var/tmp/ccache
DISTTAG=f27container
QEMU_CONFIGURE_OPTS=--python=/usr/bin/python3
FGC=f27
TEST_DIR=/tmp/qemu-test
SHLVL=1
FEATURES=mingw clang pyyaml asan dtc
PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
MAKEFLAGS= -j8
EXTRA_CONFIGURE_OPTS=
_=/usr/bin/env

Configure options: