Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/22/2018 12:01 PM, Halil Pasic wrote: On 04/22/2018 05:43 PM, Tony Krowiak wrote: +FEAT_INIT_MISC("ap", "AP facilities installed"), Why plural ('facilities')? Would not s/facilities/instructions be more end-user friendly? It's a matter of opinion. I prefer facilities because AP

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 04:59 AM, David Hildenbrand wrote: On 18.04.2018 09:40, Cornelia Huck wrote: On Tue, 17 Apr 2018 20:21:31 +0200 Christian Borntraeger wrote: On 04/16/2018 05:44 PM, David Hildenbrand wrote: diff --git a/target/s390x/gen-features.c

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/22/2018 12:01 PM, Halil Pasic wrote: On 04/22/2018 05:43 PM, Tony Krowiak wrote: +FEAT_INIT_MISC("ap", "AP facilities installed"), Why plural ('facilities')? Would not s/facilities/instructions be more end-user friendly? It's a matter of opinion. I prefer facilities because AP

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/22/2018 05:43 PM, Tony Krowiak wrote: +FEAT_INIT_MISC("ap", "AP facilities installed"), Why plural ('facilities')? Would not s/facilities/instructions be more end-user friendly? It's a matter of opinion. I prefer facilities because AP is comprised of not  only instructions, but 

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/22/2018 05:52 PM, Tony Krowiak wrote: +    FEAT_INIT("apqci", S390_FEAT_TYPE_STFL, 12, "Query AP Configuration  facility"), Why did you change this form qci to apqci. Too may people found the qci good? I changed it by request and I thought it made sense to do so. Maybe we should 

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 07:03 AM, David Hildenbrand wrote: On 18.04.2018 12:55, Halil Pasic wrote: On 04/15/2018 09:07 PM, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. [..] diff --git a/target/s390x/cpu_features.c

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 06:55 AM, Halil Pasic wrote: On 04/15/2018 09:07 PM, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. [..] diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c index

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 06:55 AM, Halil Pasic wrote: On 04/15/2018 09:07 PM, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. [..] diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c index

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 04:59 AM, David Hildenbrand wrote: On 18.04.2018 09:40, Cornelia Huck wrote: On Tue, 17 Apr 2018 20:21:31 +0200 Christian Borntraeger wrote: On 04/16/2018 05:44 PM, David Hildenbrand wrote: diff --git a/target/s390x/gen-features.c

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 03:40 AM, Cornelia Huck wrote: On Tue, 17 Apr 2018 20:21:31 +0200 Christian Borntraeger wrote: On 04/16/2018 05:44 PM, David Hildenbrand wrote: diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 0cdbc15..0d5b0f7 100644

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 18/04/2018 13:03, David Hildenbrand wrote: On 18.04.2018 12:55, Halil Pasic wrote: On 04/15/2018 09:07 PM, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. [..] diff --git a/target/s390x/cpu_features.c

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 18.04.2018 12:55, Halil Pasic wrote: > > > On 04/15/2018 09:07 PM, Tony Krowiak wrote: >> A new CPU model feature and two new CPU model facilities are >> introduced to support AP devices for a KVM guest. > [..] >> diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c >> index

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/15/2018 09:07 PM, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. [..] diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c index 3b9e274..5ee3a2d 100644 ---

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 18.04.2018 09:40, Cornelia Huck wrote: > On Tue, 17 Apr 2018 20:21:31 +0200 > Christian Borntraeger wrote: > >> On 04/16/2018 05:44 PM, David Hildenbrand wrote: >>> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On Tue, 17 Apr 2018 20:21:31 +0200 Christian Borntraeger wrote: > On 04/16/2018 05:44 PM, David Hildenbrand wrote: > > > >> > >> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c > >> index 0cdbc15..0d5b0f7 100644 > >> ---

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/16/2018 05:44 PM, David Hildenbrand wrote: > >> >> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c >> index 0cdbc15..0d5b0f7 100644 >> --- a/target/s390x/gen-features.c >> +++ b/target/s390x/gen-features.c >> @@ -447,6 +447,9 @@ static uint16_t full_GEN12_GA1[] =

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/16/2018 11:44 AM, David Hildenbrand wrote: diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 0cdbc15..0d5b0f7 100644 --- a/target/s390x/gen-features.c +++ b/target/s390x/gen-features.c @@ -447,6 +447,9 @@ static uint16_t full_GEN12_GA1[] = {

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

> > diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c > index 0cdbc15..0d5b0f7 100644 > --- a/target/s390x/gen-features.c > +++ b/target/s390x/gen-features.c > @@ -447,6 +447,9 @@ static uint16_t full_GEN12_GA1[] = { > S390_FEAT_ADAPTER_INT_SUPPRESSION, >