Re: [Qemu-devel] [PULL 00/24] target/hppa patch queue
Hi Peter, On 2/14/19 11:04 AM, Peter Maydell wrote: > On Wed, 13 Feb 2019 at 18:40, Philippe Mathieu-Daudé > wrote: >> What Clang version is that? >> >> I can not reproduce using: >> >> clang version 7.0.1 (Fedora 7.0.1-1.fc29) > > OSX: Apple LLVM version 10.0.0 (clang-1000.11.45.5)> and Ubuntu bionic: clang > version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) I can not reproduce on Bionic: $ clang --version clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) Target: x86_64-pc-linux-gnu ./configure --host-cc=clang \ --cxx=clang++ \ --cc=clang \ --extra-cflags=-Werror=typedef-redefinition Host C compiler clang C++ compiler clang++ Objective-C compiler clang QEMU_CFLAGS -I/usr/include/pixman-1 -I$(SRC_PATH)/dtc/libfdt -Werror -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99 -Werror=typedef-redefinition -Wno-error=address-of-packed-member -Wno-string-plus-int -Wno-initializer-overrides -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/spice-server -I/usr/include/spice-1 -I$(SRC_PATH)/capstone/include [...] $ make subdir-hppa-softmmu [...] $ hppa-softmmu/qemu-system-hppa --version QEMU emulator version 3.1.50 (v3.1.0-1733-gcb82c5728c-dirty) I don't have handy OSX setup except Travis, I'll see what I can do. Regards, Phil.
Re: [Qemu-devel] [PULL 00/24] target/hppa patch queue
On Wed, 13 Feb 2019 at 18:40, Philippe Mathieu-Daudé wrote: > What Clang version is that? > > I can not reproduce using: > > clang version 7.0.1 (Fedora 7.0.1-1.fc29) OSX: Apple LLVM version 10.0.0 (clang-1000.11.45.5) and Ubuntu bionic: clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) thanks -- PMM
Re: [Qemu-devel] [PULL 00/24] target/hppa patch queue
Hi Peter, On 2/12/19 2:15 PM, Peter Maydell wrote: > On Tue, 12 Feb 2019 at 04:57, Richard Henderson > wrote: >> >> The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: >> >> Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into >> staging (2019-02-11 17:04:57 +) >> >> are available in the Git repository at: >> >> https://github.com/rth7680/qemu.git tags/pull-hppa-20190211 >> >> for you to fetch changes up to 23e76627deba013509b5f1a1e1c53e8e45aa: >> >> hw/hppa: forward requests to CPU HPA (2019-02-11 20:49:06 -0800) >> >> >> Convert to decodetree. >> Fix signed overflow conditions. >> Fix dcor. >> Add CPU MIE to PCI address space. > > Hi -- clang compiles fail with: > > In file included from > /home/petmay01/linaro/qemu-for-merges/target/hppa/translate.c:337: > target/hppa/decode.inc.c:471:16: error: redefinition of typedef > 'arg_be' is a C11 feature [-Werror,-Wtypedef-redefinition] > typedef arg_be arg_be; >^ > target/hppa/decode.inc.c:9:3: note: previous definition is here > } arg_be; > ^ > target/hppa/decode.inc.c:473:16: error: redefinition of typedef > 'arg_bl' is a C11 feature [-Werror,-Wtypedef-redefinition] > typedef arg_bl arg_bl; >^ > target/hppa/decode.inc.c:15:3: note: previous definition is here > } arg_bl; > ^ What Clang version is that? I can not reproduce using: clang version 7.0.1 (Fedora 7.0.1-1.fc29) > > thanks > -- PMM >
Re: [Qemu-devel] [PULL 00/24] target/hppa patch queue
Patchew URL: https://patchew.org/QEMU/20190212045721.28041-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/24] target/hppa patch queue Type: series Message-id: 20190212045721.28041-1-richard.hender...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1550029560-30530-1-git-send-email-san...@codesourcery.com -> patchew/1550029560-30530-1-git-send-email-san...@codesourcery.com * [new tag] patchew/20190211170136.18680-1-richard.hender...@linaro.org -> patchew/20190211170136.18680-1-richard.hender...@linaro.org t [tag update]patchew/20190212025241.5330-1-stefa...@redhat.com -> patchew/20190212025241.5330-1-stefa...@redhat.com * [new tag] patchew/20190212045721.28041-1-richard.hender...@linaro.org -> patchew/20190212045721.28041-1-richard.hender...@linaro.org t [tag update]patchew/20190212145722.31891-1-phi...@redhat.com -> patchew/20190212145722.31891-1-phi...@redhat.com Switched to a new branch 'test' b5c5dfdaab hw/hppa: forward requests to CPU HPA a48430e571 target/hppa: fix dcor instruction b2d7de36d5 target/hppa: Fix addition 'http://patchew.org/logs/20190212045721.28041-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [Qemu-devel] [PULL 00/24] target/hppa patch queue
On Tue, 12 Feb 2019 at 04:57, Richard Henderson wrote: > > The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into > staging (2019-02-11 17:04:57 +) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-hppa-20190211 > > for you to fetch changes up to 23e76627deba013509b5f1a1e1c53e8e45aa: > > hw/hppa: forward requests to CPU HPA (2019-02-11 20:49:06 -0800) > > > Convert to decodetree. > Fix signed overflow conditions. > Fix dcor. > Add CPU MIE to PCI address space. Hi -- clang compiles fail with: In file included from /home/petmay01/linaro/qemu-for-merges/target/hppa/translate.c:337: target/hppa/decode.inc.c:471:16: error: redefinition of typedef 'arg_be' is a C11 feature [-Werror,-Wtypedef-redefinition] typedef arg_be arg_be; ^ target/hppa/decode.inc.c:9:3: note: previous definition is here } arg_be; ^ target/hppa/decode.inc.c:473:16: error: redefinition of typedef 'arg_bl' is a C11 feature [-Werror,-Wtypedef-redefinition] typedef arg_bl arg_bl; ^ target/hppa/decode.inc.c:15:3: note: previous definition is here } arg_bl; ^ thanks -- PMM
