Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-26 Thread Richard W.M. Jones
I posted my thoughts about how this could work here: https://www.redhat.com/archives/libguestfs/2011-January/msg00066.html Rich. PS. You don't need to be a subscriber to post to that list -- I manually triage any messages sent by non-subscribers. -- Richard Jones, Virtualization Group, Red

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-25 Thread Richard W.M. Jones
On Mon, Jan 24, 2011 at 05:40:05PM -0600, Anthony Liguori wrote: BTW, how dependent is guestfsd on the guest that libguestfs uses? I wasn't even aware that it could be used outside of that context. The daemon is compiled separately -- separate ./configure, make, etc. You can run it on its own.

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-25 Thread Anthony Liguori
On 01/25/2011 03:21 AM, Richard W.M. Jones wrote: On Mon, Jan 24, 2011 at 05:40:05PM -0600, Anthony Liguori wrote: BTW, how dependent is guestfsd on the guest that libguestfs uses? I wasn't even aware that it could be used outside of that context. The daemon is compiled separately

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-25 Thread Richard W.M. Jones
On Tue, Jan 25, 2011 at 09:12:15AM -0600, Anthony Liguori wrote: How much infrastructure does guestfd depend on within the guest? Do you need a full install with all of the bells and whistles or does it degrade cleanly when certain tools aren't available? On Linux these are the libraries,

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-24 Thread Richard W.M. Jones
On Fri, Jan 21, 2011 at 12:23:40PM -0600, Michael Roth wrote: getfile() is confusingly named however, it's really just a means to peek at a text file like /proc/meminfo. You might as well reuse the libguestfs API here because you get the benefit of all the code that's been written, all the

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-24 Thread Anthony Liguori
On 01/24/2011 04:20 PM, Richard W.M. Jones wrote: On Mon, Jan 24, 2011 at 10:08:09PM +, Richard W.M. Jones wrote: You might as well reuse the libguestfs API here because you get the benefit of all the code that's been written, all the tools on top, and a far more comprehensive API that

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-24 Thread Richard W.M. Jones
On Mon, Jan 24, 2011 at 10:08:09PM +, Richard W.M. Jones wrote: You might as well reuse the libguestfs API here because you get the benefit of all the code that's been written, all the tools on top, and a far more comprehensive API that would take you another 2 years to implement. To put

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-24 Thread Richard W.M. Jones
On Mon, Jan 24, 2011 at 04:26:09PM -0600, Anthony Liguori wrote: On 01/24/2011 04:20 PM, Richard W.M. Jones wrote: On Mon, Jan 24, 2011 at 10:08:09PM +, Richard W.M. Jones wrote: You might as well reuse the libguestfs API here because you get the benefit of all the code that's been

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-24 Thread Anthony Liguori
On 01/24/2011 04:48 PM, Richard W.M. Jones wrote: On Mon, Jan 24, 2011 at 04:26:09PM -0600, Anthony Liguori wrote: On 01/24/2011 04:20 PM, Richard W.M. Jones wrote: On Mon, Jan 24, 2011 at 10:08:09PM +, Richard W.M. Jones wrote: You might as well reuse the libguestfs API

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-24 Thread Michael Roth
On 01/24/2011 05:40 PM, Anthony Liguori wrote: On 01/24/2011 04:48 PM, Richard W.M. Jones wrote: On Mon, Jan 24, 2011 at 04:26:09PM -0600, Anthony Liguori wrote: On 01/24/2011 04:20 PM, Richard W.M. Jones wrote: On Mon, Jan 24, 2011 at 10:08:09PM +, Richard W.M. Jones wrote: You might as

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-24 Thread Anthony Liguori
On 01/24/2011 06:22 PM, Michael Roth wrote: Actually, copyfile is the proposed open/read/write/close interface. getfile is the current interface, and it seems to be a contentious one. I've discussed it quite a bit with Jes here and in the last couple RFCs. I think the current course is that

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-21 Thread Daniel P. Berrange
On Fri, Jan 21, 2011 at 05:40:54PM +0100, Jes Sorensen wrote: On 01/17/11 14:15, Michael Roth wrote: Add RPC to retrieve a guest file. This interface is intended for smaller reads like peeking at logs and /proc and such. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com ---

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-21 Thread Michael Roth
On 01/21/2011 11:20 AM, Daniel P. Berrange wrote: On Fri, Jan 21, 2011 at 05:40:54PM +0100, Jes Sorensen wrote: On 01/17/11 14:15, Michael Roth wrote: Add RPC to retrieve a guest file. This interface is intended for smaller reads like peeking at logs and /proc and such. Signed-off-by: Michael