Re: [Qemu-devel] Set up github repo for pmon sources

2019-03-18 Thread Daniel P . Berrangé
On Sat, Mar 16, 2019 at 10:39:49PM +0100, BALATON Zoltan wrote:
> On Sat, 16 Mar 2019, Eric Blake wrote:
> > On 3/15/19 9:06 PM, Andrew Randrianasulu wrote:
> > > https://github.com/Randrianasulu/pmon/commits/2014
> > > 
> > > hopefully it will stay this way.
> > > 
> > > Anyone know what license I must pick for this?
> > > 3-clause BSD? 4-clause BSD? (from Copyright file it lists 4 terms)
> > 
> > 4-clause BSD is incompatible with the GPL, and thus cannot be used for
> > qemu.  (2-clause and 3-clause are okay, though).
> 
> To clarify, this is the firmware of the mips_fulong2e board. So it's a
> separate project but would make the board work more like the real hardware.
> We don't use code from this firmware in QEMU itself but including the
> firmware binary would make it simpler to run the board. If we include a
> binary we should probably also provide the source (even if BSD license does
> not require that) for convenience in roms, mirrored from the above git repo
> like for other firmwares. Is it still incompatible for that? What should be
> the preferred way then? Can we put the binary and source on qemu.org
> somewhere and link to it so it's not distributed with QEMU but still easy to
> get?

As this is just a self-contained firmware whose build is completely separate
from the QEMU build, & produces standalone output file not linked / integrated
with QEMU except at runtime, it would not be considered a combined work with
main QEMU codebase. As such the GPL incompatiblity would not come into effect.

As the same time though, BSD-with-advertizing clause is an unpleasant
license, so on general principles I'd be against including it in the
QEMU git repo regardless of the GPL license compatibility point.

This kind of issue would be entirely avoided if all firmwares were
separate from QEMU.

Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|



Re: [Qemu-devel] Set up github repo for pmon sources

2019-03-16 Thread BALATON Zoltan

On Sat, 16 Mar 2019, Andrew Randrianasulu wrote:

В сообщении от Saturday 16 March 2019 20:53:01 вы написали:

On 3/15/19 9:06 PM, Andrew Randrianasulu wrote:

https://github.com/Randrianasulu/pmon/commits/2014

hopefully it will stay this way.

Anyone know what license I must pick for this?
3-clause BSD? 4-clause BSD? (from Copyright file it lists 4 terms)


4-clause BSD is incompatible with the GPL, and thus cannot be used for
qemu.  (2-clause and 3-clause are okay, though).




*  $Id: Copyright,v 1.1.1.1 2006/09/14 01:59:06 root Exp $ */

/*
 * Copyright (c) 2000-2002 Opsycon AB  (www.opsycon.se)
 * Copyright (c) 2000 Rtmx, Inc   (www.rtmx.com)
 * Copyright (c) 2001 ipUnplugged AB (www.ipunplugged.com)
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 * 1. Redistributions of source code must retain the above copyright
 *notice, this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright
 *notice, this list of conditions and the following disclaimer in the
 *documentation and/or other materials provided with the distribution.
 * 3. All advertising materials mentioning features or use of this software
 *must display the following acknowledgement:
 *  This product includes software developed for Rtmx, Inc by
 *  Opsycon Open System Consulting AB, Sweden.
 *  This product includes software developed by Opsycon AB.
 *  This product includes software developed by ipUnplugged AB.


Indeed, this is the advertising clause of the 4-clause BSD, which
renders this license unsuitable for use with GPL projects.


Ow. Ok, then I just leave it as-is, github already showing this text as license,
and while qemu as project can't use this firmware - users still can.

Also, there seems to be another pmon branch on github:
https://github.com/jcowgill/pmon-loongson - but I haven't tested it.


And also two more linked from here:
https://www.opsycon.se/pmon2000

Probably there are even more but none with an easy to build pmon.bin for 
fulong2e board I know of, or one that matches the pmon_2e.bin banary 
available which seems to be the original firmware of the board. Therefore 
providing a tested firmware from QEMU would simplify user's life trying 
this board. So at least we could gather this info somewhere on qemu.org.


Regards,
BALATON Zoltan


Morever, what lives in
http://www.anheng.com.cn/loongson/pmon/updates.lemote.com/files/upload/lm/firmware/pmon/source/

seems to be THIRD branch of pmon, at least radeon-specific file is different,
and apparently solved bug I solved independently. (there was confusion between 
Bytes per pixel and Bits per pixel)




 * 4. The name of the author may not be used to endorse or promote products
 *derived from this software without specific prior written permission.
 *










Re: [Qemu-devel] Set up github repo for pmon sources

2019-03-16 Thread BALATON Zoltan

On Sat, 16 Mar 2019, Eric Blake wrote:

On 3/15/19 9:06 PM, Andrew Randrianasulu wrote:

https://github.com/Randrianasulu/pmon/commits/2014

hopefully it will stay this way.

Anyone know what license I must pick for this?
3-clause BSD? 4-clause BSD? (from Copyright file it lists 4 terms)


4-clause BSD is incompatible with the GPL, and thus cannot be used for
qemu.  (2-clause and 3-clause are okay, though).


To clarify, this is the firmware of the mips_fulong2e board. So it's a 
separate project but would make the board work more like the real 
hardware. We don't use code from this firmware in QEMU itself but 
including the firmware binary would make it simpler to run the board. If 
we include a binary we should probably also provide the source (even if 
BSD license does not require that) for convenience in roms, mirrored from 
the above git repo like for other firmwares. Is it still incompatible for 
that? What should be the preferred way then? Can we put the binary and 
source on qemu.org somewhere and link to it so it's not distributed with 
QEMU but still easy to get?


Regards,
BALATON Zoltan






*  $Id: Copyright,v 1.1.1.1 2006/09/14 01:59:06 root Exp $ */

/*
 * Copyright (c) 2000-2002 Opsycon AB  (www.opsycon.se)
 * Copyright (c) 2000 Rtmx, Inc   (www.rtmx.com)
 * Copyright (c) 2001 ipUnplugged AB (www.ipunplugged.com)
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 * 1. Redistributions of source code must retain the above copyright
 *notice, this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright
 *notice, this list of conditions and the following disclaimer in the
 *documentation and/or other materials provided with the distribution.
 * 3. All advertising materials mentioning features or use of this software
 *must display the following acknowledgement:
 *  This product includes software developed for Rtmx, Inc by
 *  Opsycon Open System Consulting AB, Sweden.
 *  This product includes software developed by Opsycon AB.
 *  This product includes software developed by ipUnplugged AB.


Indeed, this is the advertising clause of the 4-clause BSD, which
renders this license unsuitable for use with GPL projects.


 * 4. The name of the author may not be used to endorse or promote products
 *derived from this software without specific prior written permission.
 *








Re: [Qemu-devel] Set up github repo for pmon sources

2019-03-16 Thread Andrew Randrianasulu
В сообщении от Saturday 16 March 2019 20:53:01 вы написали:
> On 3/15/19 9:06 PM, Andrew Randrianasulu wrote:
> > https://github.com/Randrianasulu/pmon/commits/2014
> > 
> > hopefully it will stay this way.
> > 
> > Anyone know what license I must pick for this?
> > 3-clause BSD? 4-clause BSD? (from Copyright file it lists 4 terms)
> 
> 4-clause BSD is incompatible with the GPL, and thus cannot be used for
> qemu.  (2-clause and 3-clause are okay, though).
> 
> > 
> > 
> > *  $Id: Copyright,v 1.1.1.1 2006/09/14 01:59:06 root Exp $ */
> > 
> > /*
> >  * Copyright (c) 2000-2002 Opsycon AB  (www.opsycon.se)
> >  * Copyright (c) 2000 Rtmx, Inc   (www.rtmx.com)
> >  * Copyright (c) 2001 ipUnplugged AB (www.ipunplugged.com)
> >  *
> >  * Redistribution and use in source and binary forms, with or without
> >  * modification, are permitted provided that the following conditions
> >  * are met:
> >  * 1. Redistributions of source code must retain the above copyright
> >  *notice, this list of conditions and the following disclaimer.
> >  * 2. Redistributions in binary form must reproduce the above copyright
> >  *notice, this list of conditions and the following disclaimer in the
> >  *documentation and/or other materials provided with the distribution.
> >  * 3. All advertising materials mentioning features or use of this software
> >  *must display the following acknowledgement:
> >  *  This product includes software developed for Rtmx, Inc by
> >  *  Opsycon Open System Consulting AB, Sweden.
> >  *  This product includes software developed by Opsycon AB.
> >  *  This product includes software developed by ipUnplugged AB.
> 
> Indeed, this is the advertising clause of the 4-clause BSD, which
> renders this license unsuitable for use with GPL projects.

Ow. Ok, then I just leave it as-is, github already showing this text as 
license, 
and while qemu as project can't use this firmware - users still can.

Also, there seems to be another pmon branch on github:
https://github.com/jcowgill/pmon-loongson - but I haven't tested it.

Morever, what lives in 
http://www.anheng.com.cn/loongson/pmon/updates.lemote.com/files/upload/lm/firmware/pmon/source/

seems to be THIRD branch of pmon, at least radeon-specific file is different, 
and apparently solved bug I solved independently. (there was confusion between 
Bytes per pixel and Bits per pixel)

> 
> >  * 4. The name of the author may not be used to endorse or promote products
> >  *derived from this software without specific prior written permission.
> >  *
> 
> 





Re: [Qemu-devel] Set up github repo for pmon sources

2019-03-16 Thread Eric Blake
On 3/15/19 9:06 PM, Andrew Randrianasulu wrote:
> https://github.com/Randrianasulu/pmon/commits/2014
> 
> hopefully it will stay this way.
> 
> Anyone know what license I must pick for this?
> 3-clause BSD? 4-clause BSD? (from Copyright file it lists 4 terms)

4-clause BSD is incompatible with the GPL, and thus cannot be used for
qemu.  (2-clause and 3-clause are okay, though).

> 
> 
> *  $Id: Copyright,v 1.1.1.1 2006/09/14 01:59:06 root Exp $ */
> 
> /*
>  * Copyright (c) 2000-2002 Opsycon AB  (www.opsycon.se)
>  * Copyright (c) 2000 Rtmx, Inc   (www.rtmx.com)
>  * Copyright (c) 2001 ipUnplugged AB (www.ipunplugged.com)
>  *
>  * Redistribution and use in source and binary forms, with or without
>  * modification, are permitted provided that the following conditions
>  * are met:
>  * 1. Redistributions of source code must retain the above copyright
>  *notice, this list of conditions and the following disclaimer.
>  * 2. Redistributions in binary form must reproduce the above copyright
>  *notice, this list of conditions and the following disclaimer in the
>  *documentation and/or other materials provided with the distribution.
>  * 3. All advertising materials mentioning features or use of this software
>  *must display the following acknowledgement:
>  *  This product includes software developed for Rtmx, Inc by
>  *  Opsycon Open System Consulting AB, Sweden.
>  *  This product includes software developed by Opsycon AB.
>  *  This product includes software developed by ipUnplugged AB.

Indeed, this is the advertising clause of the 4-clause BSD, which
renders this license unsuitable for use with GPL projects.

>  * 4. The name of the author may not be used to endorse or promote products
>  *derived from this software without specific prior written permission.
>  *


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature